molecule-core

You've already forked molecule-core

Code Issues 134 Pull Requests 156 Actions Packages Projects Releases Wiki Activity

Compare commits

merge into: molecule-ai/molecule-core:fix/contextmenu-react-error-185

pull from: molecule-ai/molecule-core:test/external-runtimes-coverage

Branches Tags

2 Commits

fix/contextmenu-react-error-185 .. test/external-runtimes-coverage

Author	SHA1	Message	Date
core-fe	8ae0aa7023	fix(canvas/ContextMenu): prevent React error #185 by moving hasChildren derivation out of Zustand selector ContextMenu used `.some()` inside its Zustand selector to compute hasChildren. Zustand's useSyncExternalStore calls the selector on every snapshot; `.some()` returns a new boolean each time, which React 19's stricter comparison and the re-render side-effects from the store subscription created a feedback loop on mobile Chat tab mount → React error #185 ("Maximum update depth exceeded"). Fix: select the stable `nodes` array once, derive children via useMemo outside the store subscription. Also removes the inline `getState().nodes.filter()` call in handleDelete in favour of the memoized children. Regression tests (2 cases): - setPendingDelete receives correct children array when workspace has children - setPendingDelete hasChildren=false and empty children when no children Refs: #651 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 00:08:06 +00:00
core-fe	7bb33bae74	test(canvas/lib): add isExternalLikeRuntime coverage (16 cases) Mirrors the backend isExternalLikeRuntime() contract so both sides agree on which runtimes are external-like (no platform container, no Files/Terminal tabs). Cases: "external", "kimi", "kimi-cli" → true; all other runtimes, undefined, null, empty string → false. Case-sensitivity verified. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 00:08:06 +00:00

Author

SHA1

Message

Date

core-fe

8ae0aa7023

fix(canvas/ContextMenu): prevent React error #185 by moving hasChildren derivation out of Zustand selector

ContextMenu used `.some()` inside its Zustand selector to compute hasChildren.
Zustand's useSyncExternalStore calls the selector on every snapshot; `.some()`
returns a new boolean each time, which React 19's stricter comparison
and the re-render side-effects from the store subscription created a
feedback loop on mobile Chat tab mount → React error #185
("Maximum update depth exceeded").

Fix: select the stable `nodes` array once, derive children via useMemo
outside the store subscription. Also removes the inline `getState().nodes.filter()`
call in handleDelete in favour of the memoized children.

Regression tests (2 cases):
- setPendingDelete receives correct children array when workspace has children
- setPendingDelete hasChildren=false and empty children when no children

Refs: #651

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

2026-05-14 00:08:06 +00:00

core-fe

7bb33bae74

test(canvas/lib): add isExternalLikeRuntime coverage (16 cases)

Mirrors the backend isExternalLikeRuntime() contract so both sides agree
on which runtimes are external-like (no platform container, no Files/Terminal tabs).

Cases: "external", "kimi", "kimi-cli" → true; all other runtimes,
undefined, null, empty string → false. Case-sensitivity verified.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

2026-05-14 00:08:06 +00:00

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Expand all files Collapse all files

Compare commits

2 Commits fix/contextmenu-react-error-185 .. test/external-runtimes-coverage

Diff Content Not Available

2 Commits

fix/contextmenu-react-error-185 .. test/external-runtimes-coverage