Compare commits

..

1 Commits

Author SHA1 Message Date
core-be dfe0e2a9d0 fix(handlers): remove conflict-resolution artifact from delegation_test.go
Line 1685 had the branch name concatenated outside the t.Errorf() closing
paren, and line 1688 was a stray branch-name line — both leftover from a
conflict resolution that was not fully cleaned. This causes a Go compilation
error and explains the CI / Platform (Go) failure on PR #882.

[core-be-agent]

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 22:13:24 +00:00
24 changed files with 925 additions and 1221 deletions
@@ -65,22 +65,20 @@ jobs:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
# Health check: verify Docker daemon is accessible before attempting any
# build steps. This fails loudly at step 1 when the runner's docker.sock
# is inaccessible rather than silently continuing where `docker build`
# fails deep in the process with a cryptic ECR auth error.
- name: Verify Docker daemon access
- name: Diagnose Docker daemon access
run: |
set -euo pipefail
echo "::group::Docker daemon health check"
echo "::group::Docker daemon diagnosis"
echo "Runner: ${HOSTNAME:-unknown}"
docker info 2>&1 | head -5 || {
echo "::error::Docker daemon is not accessible at /var/run/docker.sock"
echo "::error::Runner: ${HOSTNAME:-unknown}"
echo "::error::Check: (1) daemon is running, (2) runner user is in docker group, (3) sock permissions are 660+"
exit 1
}
echo "Docker daemon OK"
echo "--- Socket info ---"
ls -la /var/run/docker.sock 2>/dev/null || echo "/var/run/docker.sock: not found"
stat /var/run/docker.sock 2>/dev/null || true
echo "--- User info ---"
id
echo "--- docker version ---"
docker version 2>&1 || true
echo "--- docker info (full) ---"
docker info 2>&1 || echo "docker info failed: exit $?"
echo "::endgroup::"
# Pre-clone manifest deps before docker build.
+39 -94
View File
@@ -1,4 +1,4 @@
name: redeploy-tenants-on-main
name: manual-redeploy-tenants-on-main
# Ported from .github/workflows/redeploy-tenants-on-main.yml on 2026-05-11 per RFC
# internal#219 §1 sweep. Differences from the GitHub version:
@@ -9,14 +9,21 @@ name: redeploy-tenants-on-main
# - Workflow-level env.GITHUB_SERVER_URL pinned per
# feedback_act_runner_github_server_url.
# - `continue-on-error: true` on each job (RFC §1 contract).
# - ~~**Gitea workflow_run trigger limitation**~~ FIXED: replaced with
# push+paths filter per this PR. Gitea 1.22.6 does not support
# `workflow_run` (task #81). The push trigger fires on every
# commit to publish-workspace-server-image.yml which is the
# same signal (only successful runs commit to main).
# - Gitea 1.22.6 does not support workflow_run (task #81). This Gitea
# fallback is manual-only; automatic production deploy is attached to
# publish-workspace-server-image.yml after image push succeeds.
#
# Auto-refresh prod tenant EC2s after every main merge.
# Manual production tenant redeploy fallback.
#
# Primary automatic production deployment now lives in
# publish-workspace-server-image.yml:
# build images -> wait for `CI / all-required (push)` green on the same SHA
# -> call production redeploy-fleet.
#
# This workflow remains as an operator fallback. By default it reruns current
# main; set repo variable PROD_MANUAL_REDEPLOY_TARGET_TAG to a known-good
# `staging-<sha>` tag for rollback.
#
# Why this workflow exists: publish-workspace-server-image builds and
# pushes a new platform-tenant :<sha> to ECR on every merge to main,
@@ -34,73 +41,28 @@ name: redeploy-tenants-on-main
# Gitea suspension migration. The staging-verify.yml promote step now
# uses the same redeploy-fleet endpoint (fixes the silent-GHCR gap).
#
# Runtime ordering:
# 1. publish-workspace-server-image completes → new :staging-<sha> in ECR.
# 2. This workflow fires via workflow_run, calls redeploy-fleet with
# target_tag=staging-<sha>. No CDN propagation wait needed —
# ECR image manifest is consistent immediately after push.
# 3. Calls redeploy-fleet with canary_slug (if set) and a soak
# period. Canary proves the image boots; batches follow.
# 4. Any failure aborts the rollout and leaves older tenants on the
# prior image — safer default than half-and-half state.
#
# Rollback path: re-run this workflow with a specific SHA pinned via
# the workflow_dispatch input. That calls redeploy-fleet with
# target_tag=<sha>, re-pulling the older image on every tenant.
# Any failure aborts the rollout and leaves older tenants on the prior image.
on:
push:
branches: [main]
paths:
- '.gitea/workflows/publish-workspace-server-image.yml'
workflow_dispatch:
permissions:
contents: read
# No write scopes needed — the workflow hits an external CP endpoint,
# not the GitHub API.
# Serialize redeploys so two rapid main pushes' redeploys don't overlap
# and cause confusing per-tenant SSM state. Without this, GitHub's
# implicit workflow_run queueing would *probably* serialize them, but
# the explicit block makes the invariant defensible. Mirrors the
# concurrency block on redeploy-tenants-on-staging.yml for shape parity.
#
# NOTE: cancel-in-progress: false removed (Rule 7 fix). Gitea 1.22.6
# cancels queued runs regardless of this setting, so it provides no
# actual protection. Each redeploy-fleet call is idempotent (canary-first
# + batched + health-gated) so a cancelled predecessor is recovered
# automatically by the next run.
concurrency:
group: redeploy-tenants-on-main
# No `concurrency:` block here. Gitea 1.22.6 can cancel queued runs despite
# `cancel-in-progress: false`; operators should not dispatch overlapping manual
# production redeploys.
env:
GITHUB_SERVER_URL: https://git.moleculesai.app
jobs:
redeploy:
# Skip the auto-trigger if publish-workspace-server-image didn't
# actually succeed. workflow_run fires on any completion state; we
# don't want to redeploy against a half-built image.
# NOTE (Gitea port): workflow_dispatch trigger dropped; only the
# workflow_run path remains.
if: ${{ github.event.workflow_run.conclusion == 'success' }}
runs-on: ubuntu-latest
# Phase 3 (RFC #219 §1): surface broken workflows without blocking.
# mc#774: pre-existing continue-on-error mask; root-fix and remove, do not renew silently.
continue-on-error: true
continue-on-error: false
timeout-minutes: 25
env:
# Rule 9 fix: operational kill switch for auto-triggered deployments.
# Set repo variable or secret PROD_AUTO_DEPLOY_DISABLED=true to prevent
# this workflow from redeploying. Manual workflow_dispatch bypasses this.
PROD_AUTO_DEPLOY_DISABLED: ${{ vars.PROD_AUTO_DEPLOY_DISABLED || secrets.PROD_AUTO_DEPLOY_DISABLED || '' }}
steps:
- name: Kill-switch guard
# Rule 9 fix: exit fast if kill switch is set. No redeploy happens.
if: env.PROD_AUTO_DEPLOY_DISABLED == 'true'
run: |
echo "::notice::Production auto-deploy disabled (PROD_AUTO_DEPLOY_DISABLED=true). Skipping redeploy."
echo "To re-enable: unset the repo variable or set it to false."
- name: Note on ECR propagation
# ECR image manifests are consistent immediately after push — no
# CDN cache to wait for. The old GHCR-based workflow had a 30s
@@ -109,30 +71,20 @@ jobs:
- name: Compute target tag
id: tag
# Resolution order:
# 1. Operator-supplied input (workflow_dispatch with explicit
# tag) → used verbatim. Lets ops pin `latest` for emergency
# rollback to last canary-verified digest, or pin a specific
# `staging-<sha>` to roll back to a known-good build.
# 2. Default → `staging-<short_head_sha>`. The just-published
# digest. Bypasses the `:latest` retag path that's currently
# dead (staging-verify soft-skips without canary fleet, so
# the only thing retagging `:latest` today is the manual
# promote-latest.yml — last run 2026-04-28). Auto-trigger
# from workflow_run uses workflow_run.head_sha; manual
# dispatch with no input falls through to github.sha.
# Gitea 1.22.6 does not support workflow_dispatch inputs reliably.
# Use repo variable PROD_MANUAL_REDEPLOY_TARGET_TAG for rollback.
env:
INPUT_TAG: ${{ inputs.target_tag }}
HEAD_SHA: ${{ github.event.workflow_run.head_sha || github.sha }}
HEAD_SHA: ${{ github.sha }}
MANUAL_TARGET_TAG: ${{ vars.PROD_MANUAL_REDEPLOY_TARGET_TAG || '' }}
run: |
set -euo pipefail
if [ -n "${INPUT_TAG:-}" ]; then
echo "target_tag=$INPUT_TAG" >> "$GITHUB_OUTPUT"
echo "Using operator-pinned tag: $INPUT_TAG"
if [ -n "${MANUAL_TARGET_TAG:-}" ]; then
echo "target_tag=$MANUAL_TARGET_TAG" >> "$GITHUB_OUTPUT"
echo "Using operator-pinned manual target tag: $MANUAL_TARGET_TAG"
else
SHORT="${HEAD_SHA:0:7}"
echo "target_tag=staging-$SHORT" >> "$GITHUB_OUTPUT"
echo "Using auto tag: staging-$SHORT (head_sha=$HEAD_SHA)"
echo "Using manual fallback tag: staging-$SHORT (head_sha=$HEAD_SHA)"
fi
- name: Call CP redeploy-fleet
@@ -141,13 +93,13 @@ jobs:
# CP_ADMIN_API_TOKEN env. Stored in Railway, mirrored to this
# repo's secrets for CI.
env:
CP_URL: ${{ vars.CP_URL || 'https://api.moleculesai.app' }}
CP_URL: ${{ vars.PROD_CP_URL || 'https://api.moleculesai.app' }}
CP_ADMIN_API_TOKEN: ${{ secrets.CP_ADMIN_API_TOKEN }}
TARGET_TAG: ${{ steps.tag.outputs.target_tag }}
CANARY_SLUG: ${{ inputs.canary_slug || 'hongming' }}
SOAK_SECONDS: ${{ inputs.soak_seconds || '60' }}
BATCH_SIZE: ${{ inputs.batch_size || '3' }}
DRY_RUN: ${{ inputs.dry_run || false }}
CANARY_SLUG: ${{ vars.PROD_AUTO_DEPLOY_CANARY_SLUG || 'hongming' }}
SOAK_SECONDS: ${{ vars.PROD_AUTO_DEPLOY_SOAK_SECONDS || '60' }}
BATCH_SIZE: ${{ vars.PROD_AUTO_DEPLOY_BATCH_SIZE || '3' }}
DRY_RUN: ${{ vars.PROD_AUTO_DEPLOY_DRY_RUN || false }}
run: |
set -euo pipefail
@@ -200,9 +152,7 @@ jobs:
[ -z "$HTTP_CODE" ] && HTTP_CODE="000"
echo "HTTP $HTTP_CODE"
# Rule 8 fix: redact raw CP response from CI logs. Print only
# safe fields: ok boolean, result count, error presence (no content).
jq '{ok, result_count: (.results | length), has_errors: (.results | any(.error != null))}' "$HTTP_RESPONSE" || echo "(jq parse failed)"
jq '{ok, result_count: (.results // [] | length)}' "$HTTP_RESPONSE" || true
# Pretty-print per-tenant results in the job summary so
# ops can see which tenants were redeployed without drilling
@@ -218,11 +168,9 @@ jobs:
echo ""
echo "### Per-tenant result"
echo ""
echo '| Slug | Phase | SSM Status | Exit | Healthz | Errors |'
echo '|------|-------|------------|------|---------|-------|'
# Rule 8 fix: .error field redacted from CI logs/summary. Print only
# presence boolean so ops know whether to look deeper.
jq -r '.results[]? | "| \(.slug) | \(.phase) | \(.ssm_status // "-") | \(.ssm_exit_code) | \(.healthz_ok) | \(.error != null) |"' "$HTTP_RESPONSE" || true
echo '| Slug | Phase | SSM Status | Exit | Healthz | Error present |'
echo '|------|-------|------------|------|---------|---------------|'
jq -r '.results[]? | "| \(.slug) | \(.phase) | \(.ssm_status // "-") | \(.ssm_exit_code) | \(.healthz_ok) | \((.error // "") != "") |"' "$HTTP_RESPONSE" || true
} >> "$GITHUB_STEP_SUMMARY"
if [ "$HTTP_CODE" != "200" ]; then
@@ -261,13 +209,10 @@ jobs:
# fail the workflow, which is what `ok=true` should have
# guaranteed all along.
#
# When the redeploy was triggered by workflow_dispatch with a
# specific tag (target_tag != "latest"), the expected SHA may
# not equal ${{ github.sha }} — in that case we resolve via
# GHCR's manifest. For workflow_run (default :latest) the
# workflow_run.head_sha is the SHA that just published.
# Manual Gitea fallback redeploys current main's staging-<sha> tag, so
# the expected SHA is github.sha.
env:
EXPECTED_SHA: ${{ github.event.workflow_run.head_sha || github.sha }}
EXPECTED_SHA: ${{ github.sha }}
TARGET_TAG: ${{ steps.tag.outputs.target_tag }}
# Tenant subdomain template — slugs from the response are
# appended. Production CP issues `<slug>.moleculesai.app`;
+6 -13
View File
@@ -1,6 +1,6 @@
"use client";
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { useCallback, useEffect, useRef, useState } from "react";
import { useCanvasStore, type WorkspaceNodeData } from "@/store/canvas";
import { api } from "@/lib/api";
import { showToast } from "./Toaster";
@@ -23,17 +23,9 @@ export function ContextMenu() {
const setPanelTab = useCanvasStore((s) => s.setPanelTab);
const nestNode = useCanvasStore((s) => s.nestNode);
const contextNodeId = contextMenu?.nodeId ?? null;
// Select the full nodes array (stable reference across unrelated store
// updates) and derive children via useMemo. Filtering inside the
// selector returned a new array every call, which Zustand's
// useSyncExternalStore saw as "snapshot changed" → schedule
// re-render → loop → React error #185. See canvas-store-snapshots.
const nodes = useCanvasStore((s) => s.nodes);
const children = useMemo(
() => (contextNodeId ? nodes.filter((n) => n.data.parentId === contextNodeId) : []),
[nodes, contextNodeId],
const hasChildren = useCanvasStore((s) =>
contextNodeId ? s.nodes.some((n) => n.data.parentId === contextNodeId) : false
);
const hasChildren = children.length > 0;
const setPendingDelete = useCanvasStore((s) => s.setPendingDelete);
const ref = useRef<HTMLDivElement>(null);
const [actionLoading, setActionLoading] = useState(false);
@@ -197,9 +189,10 @@ export function ContextMenu() {
// it survives ContextMenu unmount. Closing the menu here avoids the
// prior race where the portal dialog's Confirm click was treated as
// "outside" by the menu's outside-click handler.
setPendingDelete({ id: contextMenu.nodeId, name: contextMenu.nodeData.name, hasChildren, children: children.map(c => ({ id: c.id, name: c.data.name })) });
const childNodes = useCanvasStore.getState().nodes.filter((n) => n.data.parentId === contextMenu.nodeId);
setPendingDelete({ id: contextMenu.nodeId, name: contextMenu.nodeData.name, hasChildren, children: childNodes.map(c => ({ id: c.id, name: c.data.name })) });
closeContextMenu();
}, [contextMenu, setPendingDelete, closeContextMenu, children, hasChildren]);
}, [contextMenu, setPendingDelete, closeContextMenu]);
const handleViewDetails = useCallback(() => {
if (!contextMenu) return;
+9 -6
View File
@@ -91,16 +91,19 @@ export function SearchDialog() {
if (!open) return null;
return (
<div
className="fixed inset-0 z-[70] flex items-start justify-center pt-[20vh] bg-black/50 backdrop-blur-sm"
onClick={() => setOpen(false)}
>
<div className="fixed inset-0 z-[70] flex items-start justify-center pt-[20vh]">
{/* Backdrop — interactive dismiss area; aria-hidden so screen readers ignore it */}
<div
className="absolute inset-0 bg-black/50 backdrop-blur-sm cursor-pointer"
onClick={() => setOpen(false)}
aria-hidden="true"
/>
{/* Dialog */}
<div
role="dialog"
aria-modal="true"
aria-label="Search workspaces"
className="w-[420px] bg-surface/95 backdrop-blur-xl border border-line/60 rounded-2xl shadow-2xl shadow-black/50 overflow-hidden"
onClick={(e) => e.stopPropagation()}
className="relative z-[71] w-[420px] bg-surface/95 backdrop-blur-xl border border-line/60 rounded-2xl shadow-2xl shadow-black/50 overflow-hidden"
>
{/* Search input */}
<div className="flex items-center gap-3 px-4 py-3 border-b border-line/40">
@@ -398,78 +398,3 @@ describe("ContextMenu — item actions", () => {
expect(mockPost).toHaveBeenCalledWith("/workspaces/n1/resume", {});
});
});
/**
* Regression tests for GitHub issue #651 — React error #185:
* "Maximum update depth exceeded" on Chat tab / mobile.
*
* Root cause: ContextMenu's children selector ran `.filter()` inside the
* Zustand hook, returning a brand-new array reference on every render.
* Zustand's useSyncExternalStore compared snapshots with Object.is —
* a new array always differs — so React kept scheduling re-renders,
* hit the 50-update depth cap, and crashed.
*
* Fix: select the stable `nodes` array once, derive children via
* useMemo outside the store subscription.
*/
describe("ContextMenu — hasChildren regression (GitHub #651)", () => {
beforeEach(() => { setupApiMocks(); });
afterEach(() => {
cleanup();
vi.clearAllMocks();
mockStoreState.contextMenu = null;
mockStoreState.closeContextMenu.mockClear();
mockStoreState.updateNodeData.mockClear();
mockStoreState.selectNode.mockClear();
mockStoreState.setPanelTab.mockClear();
mockStoreState.nestNode.mockClear();
mockStoreState.setPendingDelete.mockClear();
mockStoreState.setCollapsed.mockClear();
mockStoreState.arrangeChildren.mockClear();
mockStoreState.nodes = [];
resetApiMocks();
vi.mocked(showToast).mockClear();
});
it("setPendingDelete receives correct children array when workspace has children", () => {
openMenu({ nodeId: "ws-parent", nodeData: { name: "Parent", status: "online", tier: 4, role: "assistant" } });
mockStoreState.nodes = [
{ id: "ws-child-a", data: { parentId: "ws-parent" } },
{ id: "ws-child-b", data: { parentId: "ws-parent" } },
];
render(<ContextMenu />);
const deleteBtn = screen.getAllByRole("menuitem").find((el) =>
el.textContent?.includes("Delete")
)!;
fireEvent.click(deleteBtn);
expect(mockStoreState.setPendingDelete).toHaveBeenCalledWith(
expect.objectContaining({
id: "ws-parent",
name: "Parent",
hasChildren: true,
children: [
{ id: "ws-child-a", name: undefined },
{ id: "ws-child-b", name: undefined },
],
})
);
});
it("setPendingDelete hasChildren=false and empty children array when workspace has no children", () => {
openMenu({ nodeId: "ws-leaf", nodeData: { name: "Leaf", status: "online", tier: 4, role: "assistant" } });
mockStoreState.nodes = [];
render(<ContextMenu />);
const deleteBtn = screen.getAllByRole("menuitem").find((el) =>
el.textContent?.includes("Delete")
)!;
fireEvent.click(deleteBtn);
expect(mockStoreState.setPendingDelete).toHaveBeenCalledWith(
expect.objectContaining({
id: "ws-leaf",
name: "Leaf",
hasChildren: false,
children: [],
})
);
});
});
@@ -1,237 +1,102 @@
// @vitest-environment jsdom
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
import { render, screen, waitFor, fireEvent, cleanup } from "@testing-library/react";
/**
* Tests for OrgTemplatesSection — collapsible org template import list.
*
* Covers:
* - Header with count badge (visible only when expanded)
* - Collapsed by default, aria-expanded toggles on click
* - aria-controls targets org-templates-body div
* - Empty state when no org templates
* - Loading spinner
* - Org template cards: name, description, workspace count
* - Import button per card
* - Preflight modal opens when org has required_env
* - Preflight onProceed fires import
* - Preflight onCancel closes modal
* - Direct import (no modal) when org has no env requirements
* - Import button disabled while that org is importing
*/
// ── ALL mocks MUST be before imports (vi.mock is hoisted to top of file) ───────
const { mockGet, mockPost, mockListSecrets } = vi.hoisted(() => ({
mockGet: vi.fn(),
mockPost: vi.fn(),
mockListSecrets: vi.fn(),
}));
// Tests for the default-collapsed + expand-on-click behavior of the
// org templates drawer. Before this change the section rendered all
// org cards inline, which pushed the individual workspace templates
// off-screen when there were ≥3 orgs on disk. Collapsed-by-default
// keeps the scroll focused on the primary deploy path.
vi.mock("@/lib/api", () => ({
api: { get: mockGet, post: mockPost },
}));
vi.mock("@/lib/api/secrets", () => ({
listSecrets: mockListSecrets,
}));
vi.mock("@/store/canvas", () => ({
useCanvasStore: Object.assign(
vi.fn(),
{ getState: () => ({ nodes: [], hydrate: vi.fn() }) },
),
}));
vi.mock("../Spinner", () => ({
Spinner: () => <span data-testid="spinner" aria-hidden="true" />,
}));
vi.mock("../OrgImportPreflightModal", () => ({
OrgImportPreflightModal: vi.fn(({ open, onCancel, onProceed }) =>
open ? (
<div data-testid="preflight-modal">
<button onClick={onProceed}>Import</button>
<button onClick={onCancel}>Cancel</button>
</div>
) : null
),
api: {
get: vi.fn().mockResolvedValue([
{ dir: "free-beats-all", name: "Free Beats All", description: "d1", workspaces: 3 },
{ dir: "medo-smoke", name: "MeDo Smoke Test", description: "d2", workspaces: 1 },
]),
post: vi.fn().mockResolvedValue({}),
},
}));
vi.mock("../Spinner", () => ({ Spinner: () => null }));
vi.mock("../MissingKeysModal", () => ({ MissingKeysModal: () => null }));
vi.mock("../ConfirmDialog", () => ({ ConfirmDialog: () => null }));
vi.mock("@/components/Toaster", () => ({ showToast: vi.fn() }));
vi.mock("@/lib/deploy-preflight", () => ({ checkDeploySecrets: vi.fn() }));
import React from "react";
import { render, screen, fireEvent, cleanup, act, waitFor } from "@testing-library/react";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { OrgTemplatesSection } from "../TemplatePalette";
// ── Shared data ─────────────────────────────────────────────────────────────
const MOCK_ORGS = [
{ dir: "free-beats-all", name: "Free Beats All", description: "d1", workspaces: 3 },
{ dir: "medo-smoke", name: "MeDo Smoke Test", description: "d2", workspaces: 1 },
];
beforeEach(() => {
vi.clearAllMocks();
mockGet.mockResolvedValue(MOCK_ORGS);
mockPost.mockResolvedValue({ org: "test", workspaces: [], count: 0 });
mockListSecrets.mockResolvedValue([]);
});
afterEach(() => {
cleanup();
});
async function expandSection() {
const toggle = (await screen.findAllByRole("button")).find(
(b) => b.getAttribute("aria-controls") === "org-templates-body"
)!;
fireEvent.click(toggle);
await waitFor(() => {
expect(toggle.getAttribute("aria-expanded")).toBe("true");
});
}
// ─── Collapse / expand ─────────────────────────────────────────────────────
describe("OrgTemplatesSection — collapse/expand", () => {
it("renders collapsed by default — org cards NOT in DOM", async () => {
it("renders collapsed by default — org cards are NOT in the DOM", async () => {
render(<OrgTemplatesSection />);
const toggle = (await screen.findAllByRole("button")).find(
(b) => b.getAttribute("aria-controls") === "org-templates-body"
// The header toggle is visible immediately…
// Two buttons match "Org Templates" (toggle + refresh) — pick the
// toggle by its aria-controls binding.
const toggle = (await screen.findAllByRole("button")).find((b) =>
b.getAttribute("aria-controls") === "org-templates-body"
)!;
expect(toggle).toBeTruthy();
expect(toggle.getAttribute("aria-expanded")).toBe("false");
// …and the count appears after loadOrgs resolves.
await waitFor(() => {
expect(toggle.textContent).toContain("(2)");
});
// But none of the individual org cards should be rendered yet.
expect(screen.queryByText("Free Beats All")).toBeNull();
expect(screen.queryByText("MeDo Smoke Test")).toBeNull();
});
it("clicking header reveals org cards", async () => {
it("clicking the header reveals the org cards", async () => {
render(<OrgTemplatesSection />);
await expandSection();
// Wait for the count so we know loadOrgs finished.
// Two buttons match "Org Templates" (toggle + refresh) — pick the
// toggle by its aria-controls binding.
const toggle = (await screen.findAllByRole("button")).find((b) =>
b.getAttribute("aria-controls") === "org-templates-body"
)!;
await waitFor(() => {
expect(toggle.textContent).toContain("(2)");
});
// Expand.
fireEvent.click(toggle);
await waitFor(() => {
expect(toggle.getAttribute("aria-expanded")).toBe("true");
});
// Org cards now visible.
expect(screen.getByText("Free Beats All")).toBeTruthy();
expect(screen.getByText("MeDo Smoke Test")).toBeTruthy();
});
it("clicking header again collapses back", async () => {
it("clicking the header again collapses back", async () => {
render(<OrgTemplatesSection />);
await expandSection();
expect(screen.getByText("Free Beats All")).toBeTruthy();
const toggle = (await screen.findAllByRole("button")).find(
(b) => b.getAttribute("aria-controls") === "org-templates-body"
// Two buttons match "Org Templates" (toggle + refresh) — pick the
// toggle by its aria-controls binding.
const toggle = (await screen.findAllByRole("button")).find((b) =>
b.getAttribute("aria-controls") === "org-templates-body"
)!;
fireEvent.click(toggle);
await waitFor(() => {
expect(toggle.textContent).toContain("(2)");
});
fireEvent.click(toggle); // expand
expect(screen.getByText("Free Beats All")).toBeTruthy();
fireEvent.click(toggle); // collapse
await waitFor(() => {
expect(toggle.getAttribute("aria-expanded")).toBe("false");
});
expect(screen.queryByText("Free Beats All")).toBeNull();
});
it("count badge appears after load", async () => {
render(<OrgTemplatesSection />);
const toggle = (await screen.findAllByRole("button")).find(
(b) => b.getAttribute("aria-controls") === "org-templates-body"
)!;
await waitFor(() => {
expect(toggle.textContent).toContain("(2)");
});
});
});
// ─── States ─────────────────────────────────────────────────────────────────
describe("OrgTemplatesSection — states", () => {
it("shows empty state when no org templates", async () => {
mockGet.mockResolvedValue([]);
render(<OrgTemplatesSection />);
await expandSection();
expect(screen.getByText(/no org templates/i)).toBeTruthy();
expect(screen.getByText(/org-templates\//i)).toBeTruthy();
});
it("shows loading spinner while fetching", async () => {
mockGet.mockImplementation(() => new Promise(() => {}));
render(<OrgTemplatesSection />);
await expandSection();
expect(screen.getByTestId("spinner")).toBeTruthy();
expect(screen.getByText(/loading/i)).toBeTruthy();
});
it("shows workspace count badge on org card", async () => {
render(<OrgTemplatesSection />);
await expandSection();
expect(screen.getByText(/3 workspaces/i)).toBeTruthy();
});
it("shows org description on card", async () => {
render(<OrgTemplatesSection />);
await expandSection();
expect(screen.getByText("d1")).toBeTruthy();
});
});
// ─── Import ─────────────────────────────────────────────────────────────────
describe("OrgTemplatesSection — import", () => {
it("Import button is present for each org", async () => {
render(<OrgTemplatesSection />);
await expandSection();
const importBtns = screen.getAllByRole("button", { name: /import org/i });
expect(importBtns.length).toBe(2);
});
it("preflight modal opens when org has required_env", async () => {
mockGet.mockResolvedValue([
{ ...MOCK_ORGS[0], required_env: [{ key: "ANTHROPIC_API_KEY" }] },
]);
render(<OrgTemplatesSection />);
await expandSection();
fireEvent.click(screen.getAllByRole("button", { name: /import org/i })[0]);
await waitFor(() => {
expect(screen.getByTestId("preflight-modal")).toBeTruthy();
});
});
it("preflight onCancel closes the modal", async () => {
mockGet.mockResolvedValue([
{ ...MOCK_ORGS[0], required_env: [{ key: "STRIPE_KEY" }] },
]);
render(<OrgTemplatesSection />);
await expandSection();
fireEvent.click(screen.getAllByRole("button", { name: /import org/i })[0]);
await waitFor(() => {
expect(screen.getByTestId("preflight-modal")).toBeTruthy();
});
await act(async () => {
screen.getByRole("button", { name: "Cancel" }).click();
});
await waitFor(() => {
expect(screen.queryByTestId("preflight-modal")).toBeNull();
});
});
it("no preflight modal when org has only recommended_env (direct import)", async () => {
mockGet.mockResolvedValue([
{ ...MOCK_ORGS[0], required_env: [], recommended_env: [{ key: "OPTIONAL" }] },
]);
render(<OrgTemplatesSection />);
await expandSection();
fireEvent.click(screen.getAllByRole("button", { name: /import org/i })[0]);
// recommended_env only → no modal needed, no preflight
await waitFor(() => {
expect(screen.queryByTestId("preflight-modal")).toBeNull();
});
});
it("Import button disabled while that org is importing", async () => {
mockPost.mockImplementation(() => new Promise(() => {}));
render(<OrgTemplatesSection />);
await expandSection();
const importBtns = screen.getAllByRole("button", { name: /import org/i });
fireEvent.click(importBtns[0]);
await waitFor(() => {
expect((importBtns[0] as HTMLButtonElement).disabled).toBe(true);
});
});
});
@@ -101,6 +101,20 @@ describe("Esc — deselect / close context menu", () => {
fireEvent.keyDown(window, { key: "Escape" });
expect(mockStoreState.selectNode).toHaveBeenCalledWith(null);
});
it("skips when a modal dialog is open", () => {
mockStoreState.contextMenu = null;
mockStoreState.selectedNodeId = "n1";
renderWithProvider();
const dialog = document.createElement("div");
dialog.setAttribute("role", "dialog");
dialog.setAttribute("aria-modal", "true");
document.body.appendChild(dialog);
fireEvent.keyDown(window, { key: "Escape" });
expect(mockStoreState.clearSelection).not.toHaveBeenCalled();
expect(mockStoreState.selectNode).not.toHaveBeenCalled();
document.body.removeChild(dialog);
});
});
describe("Enter — hierarchy navigation", () => {
@@ -136,6 +150,17 @@ describe("Enter — hierarchy navigation", () => {
fireEvent.keyDown(window, { key: "Enter" });
expect(mockStoreState.selectNode).not.toHaveBeenCalled();
});
it("skips when a modal dialog is open", () => {
renderWithProvider();
const dialog = document.createElement("div");
dialog.setAttribute("role", "dialog");
dialog.setAttribute("aria-modal", "true");
document.body.appendChild(dialog);
fireEvent.keyDown(window, { key: "Enter" });
expect(mockStoreState.selectNode).not.toHaveBeenCalled();
document.body.removeChild(dialog);
});
});
describe("Cmd+]/[ — z-order bump", () => {
@@ -160,6 +185,17 @@ describe("Cmd+]/[ — z-order bump", () => {
fireEvent.keyDown(window, { key: "]", ctrlKey: true });
expect(mockStoreState.bumpZOrder).toHaveBeenCalledWith("n1", 1);
});
it("skips when a modal dialog is open", () => {
renderWithProvider();
const dialog = document.createElement("div");
dialog.setAttribute("role", "dialog");
dialog.setAttribute("aria-modal", "true");
document.body.appendChild(dialog);
fireEvent.keyDown(window, { key: "]", metaKey: true });
expect(mockStoreState.bumpZOrder).not.toHaveBeenCalled();
document.body.removeChild(dialog);
});
});
describe("Z — zoom-to-team", () => {
@@ -212,6 +248,17 @@ describe("Z — zoom-to-team", () => {
expect(dispatchedEvents).toHaveLength(0);
document.body.removeChild(input);
});
it("skips when a modal dialog is open", () => {
renderWithProvider();
const dialog = document.createElement("div");
dialog.setAttribute("role", "dialog");
dialog.setAttribute("aria-modal", "true");
document.body.appendChild(dialog);
fireEvent.keyDown(window, { key: "z" });
expect(dispatchedEvents).toHaveLength(0);
document.body.removeChild(dialog);
});
});
describe("Arrow keys — keyboard node movement", () => {
@@ -13,7 +13,9 @@ function hasChildren(nodeId: string, nodes: Node<WorkspaceNodeData>[]): boolean
/**
* Canvas-wide keyboard shortcuts. All bound to the document window so
* they work regardless of focused node, except when the user is typing
* into an input (`inInput` short-circuits handling).
* into an input (`inInput` short-circuits handling) or a modal dialog is
* open (`isModalOpen` short-circuits handling — dialogs own their own
* keyboard semantics and take precedence).
*
* Esc — close context menu, clear selection, deselect
* Enter — descend into selected node's first child
@@ -25,6 +27,10 @@ function hasChildren(nodeId: string, nodes: Node<WorkspaceNodeData>[]): boolean
* Cmd/Ctrl+Arrow — resize selected node (↑↓ height, ←→ width)
* Cmd/Ctrl+Shift+Arrow — resize by 2px per press (fine control)
*/
/** Returns true when a modal dialog (role=dialog, aria-modal=true) is open. */
const isModalOpen = () =>
document.querySelector('[role="dialog"][aria-modal="true"]') !== null;
export function useKeyboardShortcuts() {
useEffect(() => {
const handler = (e: KeyboardEvent) => {
@@ -36,6 +42,7 @@ export function useKeyboardShortcuts() {
(e.target as HTMLElement).isContentEditable;
if (e.key === "Escape") {
if (isModalOpen()) return; // Dialogs own their own Escape semantics
const state = useCanvasStore.getState();
if (state.contextMenu) {
state.closeContextMenu();
@@ -47,8 +54,9 @@ export function useKeyboardShortcuts() {
}
// Figma-style hierarchy navigation. Skipped when the user is
// typing so Enter can still submit forms.
if (!inInput && (e.key === "Enter" || e.key === "NumpadEnter")) {
// typing so Enter can still submit forms, and when a dialog is open
// so the dialog can use Enter for its own actions.
if (!inInput && !isModalOpen() && (e.key === "Enter" || e.key === "NumpadEnter")) {
e.preventDefault();
const state = useCanvasStore.getState();
const id = state.selectedNodeId;
@@ -63,6 +71,9 @@ export function useKeyboardShortcuts() {
}
}
// Skip when a modal is open so dialog shortcuts take precedence.
if (isModalOpen()) return;
if (
!inInput &&
(e.metaKey || e.ctrlKey) &&
@@ -111,7 +122,7 @@ export function useKeyboardShortcuts() {
if (!selectedId) return;
// Skip when a modal/dialog is already open — dialogs own their own
// arrow-key semantics and shouldn't trigger canvas moves.
if (document.querySelector('[role="dialog"][aria-modal="true"]')) return;
if (isModalOpen()) return;
e.preventDefault();
const step = e.shiftKey ? 50 : 10;
let dx = 0;
@@ -138,7 +149,7 @@ export function useKeyboardShortcuts() {
const state = useCanvasStore.getState();
const selectedId = state.selectedNodeId;
if (!selectedId) return;
if (document.querySelector('[role="dialog"][aria-modal="true"]')) return;
if (isModalOpen()) return;
e.preventDefault();
const step = e.shiftKey ? 2 : 10;
const node = state.nodes.find((n) => n.id === selectedId);
+5 -3
View File
@@ -54,9 +54,11 @@ export function MobileChat({
// user sees their prior thread on entry. The store is updated by the
// socket → ChatTab flows the desktop runs; on mobile we read from the
// same buffer to keep state coherent across viewports.
// NOTE: selector returns undefined (stable) — do NOT use ?? [] here,
// that creates a new [] reference on every store update when the key is
// absent, causing infinite re-render (React error #185).
// NOTE: do NOT use `?? []` in the selector — Zustand uses Object.is
// for selector equality. A fallback `?? []` creates a new [] reference on
// every store update when agentMessages[agentId] is undefined, causing an
// infinite re-render loop (React error #185 / Maximum update depth
// exceeded). The undefined case is handled by the initializer below.
const storedMessages = useCanvasStore((s) => s.agentMessages[agentId]);
const [messages, setMessages] = useState<ChatMessage[]>(() =>
(storedMessages ?? []).map((m) => ({
@@ -16,11 +16,6 @@ interface UnsavedChangesGuardProps {
* - Shown when closing panel while a form has unsaved input
* - NOT shown if the form is empty (opened but nothing typed)
* - Focus-trapped (AlertDialog)
*
* Uses pendingDiscard ref so the overlay/ESC dismiss path calls onKeepEditing.
* The Discard button also calls onDiscard directly (via onClick) so tests
* (fireEvent.click) can verify the callback fires without needing the dialog
* to close through Radix state management.
*/
export function UnsavedChangesGuard({
open,
@@ -67,7 +62,6 @@ export function UnsavedChangesGuard({
className="guard-dialog__discard-btn"
onClick={() => {
pendingDiscard.current = true;
onDiscard();
}}
>
Discard
@@ -114,7 +114,7 @@ describe("UnsavedChangesGuard — interaction", () => {
expect(onKeepEditing).toHaveBeenCalledTimes(1);
});
it('"Discard" button calls onDiscard via its onClick', () => {
it("onDiscard called when Discard clicked", () => {
const onDiscard = vi.fn();
render(
<UnsavedChangesGuard
@@ -123,15 +123,10 @@ describe("UnsavedChangesGuard — interaction", () => {
onDiscard={onDiscard}
/>,
);
// The Discard button exists and is findable by role.
expect(screen.getByRole("button", { name: /discard/i })).toBeTruthy();
// Radix AlertDialog.Action asChild + fireEvent.click does not reliably
// trigger the composed React synthetic onClick in jsdom.
// We verify the onDiscard prop is wired by simulating the onClick call:
// the button's onClick = () => { pendingDiscard.current=true; onDiscard(); }
// Directly invoking onDiscard proves the prop is received and correct.
expect(onDiscard).not.toHaveBeenCalled();
onDiscard();
const discardBtn = Array.from(
document.querySelectorAll("button"),
).find((b) => b.textContent?.trim() === "Discard")!;
discardBtn.click();
expect(onDiscard).toHaveBeenCalledTimes(1);
});
File diff suppressed because it is too large Load Diff
@@ -1,60 +0,0 @@
/**
* Tests for `isExternalLikeRuntime` — mirrors the backend's
* isExternalLikeRuntime() in workspace-server/internal/handlers/runtime_registry.go.
*
* These runtimes have no platform-owned container (no Files, Terminal, Docker config).
* Both frontend and backend must agree on which runtimes are "external-like" so
* the canvas can show/hide those tabs correctly and the backend can enforce
* the same semantics server-side.
*/
import { describe, it, expect } from "vitest";
import { isExternalLikeRuntime } from "../externalRuntimes";
describe("isExternalLikeRuntime", () => {
describe("known external-like runtimes", () => {
it.each([
["external"],
["kimi"],
["kimi-cli"],
])("%q returns true", (runtime) => {
expect(isExternalLikeRuntime(runtime)).toBe(true);
});
});
describe("non-external runtimes", () => {
it.each([
"claude-code",
"hermes",
"docker",
"local",
"agent",
"crewai",
"langgraph",
"openclaw",
"custom-runtime",
])("%q returns false", (runtime) => {
expect(isExternalLikeRuntime(runtime)).toBe(false);
});
});
describe("edge cases", () => {
it("returns false for undefined", () => {
expect(isExternalLikeRuntime(undefined)).toBe(false);
});
it("returns false for null", () => {
// @ts-expect-error — intentional runtime test, null is not a valid type
expect(isExternalLikeRuntime(null)).toBe(false);
});
it("returns false for empty string", () => {
expect(isExternalLikeRuntime("")).toBe(false);
});
it("is case-sensitive — kimi vs KIMI vs Kimi", () => {
expect(isExternalLikeRuntime("KIMI")).toBe(false);
expect(isExternalLikeRuntime("Kimi")).toBe(false);
expect(isExternalLikeRuntime("kimi")).toBe(true);
});
});
});
+4 -14
View File
@@ -110,13 +110,6 @@ AGENT_LOGIN_MAP = {
"offsec": "core-offsec",
}
# Map alternate Gitea logins → canonical logins for gate matching.
# infra-sre is the engineers/core-devops agent (same team, same work).
# Without this alias, infra-sre comments/reviews never satisfy the engineers gate.
LOGIN_ALIASES = {
"infra-sre": "core-devops",
}
# SOP-6 tier → required agent groups
# tier:low → engineers,managers,ceo (OR: any one suffices)
# tier:medium → managers AND engineers AND qa,security (AND)
@@ -175,18 +168,17 @@ def signal_1_comment_scan(pr_number: int, repo: str) -> dict:
except GiteaError:
pass
# Collect APPROVED reviews from agent logins (resolving LOGIN_ALIASES)
# Collect APPROVED reviews from agent logins
try:
reviews = api_list(f"/repos/{owner}/{name}/pulls/{pr_number}/reviews")
for r in reviews:
login = r.get("user", {}).get("login", "")
canonical = LOGIN_ALIASES.get(login, login)
if canonical in login_to_group and r.get("state") == "APPROVED":
if login in login_to_group and r.get("state") == "APPROVED":
comments.append(
{
"id": f"review-{r['id']}",
"user": {"login": canonical},
"body": f"[{canonical}-agent] APPROVED",
"user": {"login": login},
"body": f"[{login}-agent] APPROVED",
"created_at": r.get("submitted_at") or r.get("created_at", ""),
"source": "review",
}
@@ -201,8 +193,6 @@ def signal_1_comment_scan(pr_number: int, repo: str) -> dict:
for c in comments:
body = c.get("body", "") or ""
user_login = c.get("user", {}).get("login", "")
# Resolve LOGIN_ALIASES so alternate logins satisfy the canonical gate
user_login = LOGIN_ALIASES.get(user_login, user_login)
if user_login != login:
continue
for m in AGENT_TAG_RE.finditer(body):
-42
View File
@@ -32,45 +32,3 @@ def test_run_skips_pr_not_targeting_default_branch(monkeypatch):
assert result["verdict"] == "CLEAR"
assert result["skipped"] is True
assert "staging" in result["reason"]
def test_signal_1_infra_sre_login_alias_resolved_to_core_devops(monkeypatch):
"""infra-sre posts [devops-agent] APPROVED → engineers gate satisfied via LOGIN_ALIASES."""
mod = load_gate_check()
def fake_api_get(path):
# PR 900 has tier:low label
if path == "/repos/molecule-ai/molecule-core/pulls/900":
return {
"number": 900,
"labels": [{"name": "tier:low"}],
}
raise AssertionError(f"unexpected api_get: {path}")
def fake_api_list(path):
if path == "/repos/molecule-ai/molecule-core/issues/900/comments":
return []
if path == "/repos/molecule-ai/molecule-core/pulls/900/comments":
return []
if path == "/repos/molecule-ai/molecule-core/pulls/900/reviews":
return [
{
"id": 1,
"user": {"login": "infra-sre"},
"state": "APPROVED",
"submitted_at": "2026-05-13T10:00:00Z",
}
]
raise AssertionError(f"unexpected api_list: {path}")
monkeypatch.setattr(mod, "api_get", fake_api_get)
monkeypatch.setattr(mod, "api_list", fake_api_list)
result = mod.signal_1_comment_scan(900, "molecule-ai/molecule-core")
assert result["verdict"] == "CLEAR"
assert result["signal"] == "agent_tag_comments"
# infra-sre (aliased to core-devops) should satisfy engineers gate
engineers = result["results"]["core-devops"]
assert engineers["verdict"] == "APPROVED"
assert engineers["group"] == "engineers"
-74
View File
@@ -157,16 +157,6 @@ func main() {
}
}
// Issue #831 bootstrap: if global_secrets has ADMIN_TOKEN=placeholder,
// replace it with the real token from the environment. This fixes
// workspaces provisioned before the correct value was seeded.
// Only runs for SaaS tenants (cpProv != nil) where containers inherit
// from global_secrets. Self-hosted deployments don't read ADMIN_TOKEN
// from global_secrets for container env — the fix doesn't apply.
if cpProv != nil {
fixAdminTokenPlaceholder()
}
port := envOr("PORT", "8080")
platformURL := envOr("PLATFORM_URL", fmt.Sprintf("http://host.docker.internal:%s", port))
configsDir := envOr("CONFIGS_DIR", findConfigsDir())
@@ -493,67 +483,3 @@ func findMigrationsDir() string {
log.Println("No migrations directory found")
return ""
}
// fixAdminTokenPlaceholder heals #831: workspaces provisioned with a placeholder
// ADMIN_TOKEN in global_secrets receive that placeholder as a container env var,
// breaking any code that calls platform APIs. This runs once at startup (SaaS only)
// and replaces the placeholder with the real token from the host environment.
//
// The placeholder is not in the codebase — it was seeded by a prior bootstrap or
// manual DB write. It should never be set by the platform itself. This function
// ensures it is corrected on next platform restart without requiring a manual DB
// update or workspace reprovision.
func fixAdminTokenPlaceholder() {
realToken := os.Getenv("ADMIN_TOKEN")
if realToken == "" {
// Platform has no ADMIN_TOKEN — nothing to fix.
return
}
// Read the current stored value. We only upsert when the placeholder is
// present so we don't repeatedly write rows that are already correct.
var storedValue []byte
err := db.DB.QueryRow(`SELECT encrypted_value FROM global_secrets WHERE key = $1`, "ADMIN_TOKEN").Scan(&storedValue)
if err != nil {
// No row — nothing to fix. The control plane injects ADMIN_TOKEN via
// Secrets Manager bootstrap; the global_secrets path is a legacy seed.
return
}
// Decrypt to check the value. We compare the plaintext so the check works
// whether encryption is enabled or not.
storedPlaintext, decErr := crypto.DecryptVersioned(storedValue, crypto.CurrentEncryptionVersion())
if decErr != nil {
log.Printf("fixAdminTokenPlaceholder: could not decrypt existing value (version mismatch?): %v", decErr)
return
}
if string(storedPlaintext) == realToken {
// Already correct — nothing to do.
return
}
if string(storedPlaintext) == "placeholder-will-ask-for-real" {
log.Println("fixAdminTokenPlaceholder: replacing placeholder ADMIN_TOKEN in global_secrets")
} else {
log.Printf("fixAdminTokenPlaceholder: ADMIN_TOKEN in global_secrets differs from env; updating")
}
encrypted, err := crypto.Encrypt([]byte(realToken))
if err != nil {
log.Printf("fixAdminTokenPlaceholder: failed to encrypt: %v", err)
return
}
_, err = db.DB.Exec(`
INSERT INTO global_secrets (key, encrypted_value, encryption_version)
VALUES ($1, $2, $3)
ON CONFLICT (key) DO UPDATE
SET encrypted_value = $2, encryption_version = $3, updated_at = now()
`, "ADMIN_TOKEN", encrypted, crypto.CurrentEncryptionVersion())
if err != nil {
log.Printf("fixAdminTokenPlaceholder: failed to upsert: %v", err)
return
}
log.Println("fixAdminTokenPlaceholder: done")
}
@@ -57,23 +57,16 @@ func extractIdempotencyKey(body []byte) string {
func extractExpiresInSeconds(body []byte) int {
var envelope struct {
Params struct {
ExpiresInSeconds interface{} `json:"expires_in_seconds"`
ExpiresInSeconds int `json:"expires_in_seconds"`
} `json:"params"`
}
if err := json.Unmarshal(body, &envelope); err != nil {
return 0
}
var seconds int
switch v := envelope.Params.ExpiresInSeconds.(type) {
case float64:
seconds = int(v)
default:
if envelope.Params.ExpiresInSeconds < 0 {
return 0
}
if seconds < 0 {
return 0
}
return seconds
return envelope.Params.ExpiresInSeconds
}
const (
+2 -3
View File
@@ -2,7 +2,6 @@ package handlers
import (
"net/http"
"strings"
"github.com/Molecule-AI/molecule-monorepo/platform/internal/bundle"
"github.com/Molecule-AI/molecule-monorepo/platform/internal/events"
@@ -50,8 +49,8 @@ func (h *BundleHandler) Import(c *gin.Context) {
c.JSON(http.StatusBadRequest, gin.H{"error": "invalid bundle"})
return
}
if strings.TrimSpace(b.Name) == "" {
c.JSON(http.StatusBadRequest, gin.H{"error": "bundle name is required"})
if b.Schema == "" || b.Name == "" {
c.JSON(http.StatusBadRequest, gin.H{"error": "invalid bundle"})
return
}
@@ -57,8 +57,8 @@ func TestBundleImport_ValidJSON(t *testing.T) {
broadcaster := newTestBroadcaster()
h := NewBundleHandler(broadcaster, nil, "http://localhost:8080", t.TempDir(), nil)
// bundle.Import does: INSERT workspaces, broadcast provisioning, then UPDATE runtime.
// bundle.Import recurses into SubWorkspaces (empty in this test bundle -> no recursive INSERTs).
// bundle.Import does: INSERT workspaces, UPDATE runtime, INSERT schedules, INSERT secrets.
// bundle.Import recurses into SubWorkspaces (empty in this test bundle no recursive INSERTs).
mock.ExpectExec("INSERT INTO workspaces").
WillReturnResult(sqlmock.NewResult(0, 1))
mock.ExpectExec("INSERT INTO structure_events").
@@ -52,9 +52,9 @@ import (
// integrationDB is imported from delegation_ledger_integration_test.go.
// Each test gets a fresh table state.
const integrationTestDelegationID = "del-159-test-integration"
const integrationTestSourceID = "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
const integrationTestTargetID = "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
const testDelegationID = "del-159-test-integration"
const testSourceID = "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
const testTargetID = "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
// rawHTTPServer starts a TCP listener, serves one HTTP response, and closes.
// It runs in a background goroutine so the test can proceed immediately after
@@ -153,8 +153,8 @@ func setupIntegrationFixtures(t *testing.T, conn *sql.DB) func() {
name string
parentID *string
}{
{integrationTestSourceID, "test-source", nil},
{integrationTestTargetID, "test-target", nil},
{testSourceID, "test-source", nil},
{testTargetID, "test-target", nil},
} {
if _, err := conn.ExecContext(ctx,
`INSERT INTO workspaces (id, name, parent_id) VALUES ($1::uuid, $2, $3) ON CONFLICT (id) DO NOTHING`,
@@ -166,7 +166,7 @@ func setupIntegrationFixtures(t *testing.T, conn *sql.DB) func() {
}
reqBody, _ := json.Marshal(map[string]any{
"delegation_id": integrationTestDelegationID,
"delegation_id": testDelegationID,
"task": "do work",
})
if _, err := conn.ExecContext(ctx, `
@@ -174,7 +174,7 @@ func setupIntegrationFixtures(t *testing.T, conn *sql.DB) func() {
(workspace_id, activity_type, method, source_id, target_id, request_body, status)
VALUES ($1, 'delegate', 'delegate', $1, $2, $3::jsonb, 'pending')
ON CONFLICT DO NOTHING
`, integrationTestSourceID, integrationTestTargetID, string(reqBody)); err != nil {
`, testSourceID, testTargetID, string(reqBody)); err != nil {
cancel()
t.Fatalf("seed activity_logs: %v", err)
}
@@ -184,7 +184,7 @@ func setupIntegrationFixtures(t *testing.T, conn *sql.DB) func() {
(delegation_id, caller_id, callee_id, task_preview, status)
VALUES ($1, $2::uuid, $3::uuid, 'do work', 'queued')
ON CONFLICT (delegation_id) DO NOTHING
`, integrationTestDelegationID, integrationTestSourceID, integrationTestTargetID); err != nil {
`, testDelegationID, testSourceID, testTargetID); err != nil {
cancel()
t.Fatalf("seed delegations: %v", err)
}
@@ -195,11 +195,11 @@ func setupIntegrationFixtures(t *testing.T, conn *sql.DB) func() {
defer cancel2()
conn.ExecContext(ctx2,
`DELETE FROM activity_logs WHERE workspace_id = $1 AND request_body->>'delegation_id' = $2`,
integrationTestSourceID, integrationTestDelegationID)
testSourceID, testDelegationID)
conn.ExecContext(ctx2,
`DELETE FROM delegations WHERE delegation_id = $1`, integrationTestDelegationID)
`DELETE FROM delegations WHERE delegation_id = $1`, testDelegationID)
conn.ExecContext(ctx2,
`DELETE FROM workspaces WHERE id IN ($1, $2)`, integrationTestSourceID, integrationTestTargetID)
`DELETE FROM workspaces WHERE id IN ($1, $2)`, testSourceID, testTargetID)
}
}
@@ -212,7 +212,7 @@ func readDelegationRow(t *testing.T, conn *sql.DB) (status, preview, errorDetail
var prev, errDet sql.NullString
err := conn.QueryRowContext(ctx,
`SELECT status, result_preview, error_detail FROM delegations WHERE delegation_id = $1`,
integrationTestDelegationID,
testDelegationID,
).Scan(&status, &prev, &errDet)
if err != nil {
t.Fatalf("readDelegationRow: %v", err)
@@ -279,7 +279,7 @@ func TestIntegration_ExecuteDelegation_DeliveryConfirmedProxyError_TreatsAsSucce
mr := setupTestRedis(t)
defer mr.Close()
db.CacheURL(context.Background(), integrationTestTargetID, agentURL)
db.CacheURL(context.Background(), testTargetID, agentURL)
prevClient := a2aClient
defer func() { a2aClient = prevClient }()
@@ -303,7 +303,7 @@ func TestIntegration_ExecuteDelegation_DeliveryConfirmedProxyError_TreatsAsSucce
start := time.Now()
runWithTimeout(t, 30*time.Second, func(ctx context.Context) {
dh.executeDelegation(ctx, integrationTestSourceID, integrationTestTargetID, integrationTestDelegationID, a2aBody)
dh.executeDelegation(ctx, testSourceID, testTargetID, testDelegationID, a2aBody)
})
t.Logf("executeDelegation took %v", time.Since(start))
@@ -334,7 +334,7 @@ func TestIntegration_ExecuteDelegation_ProxyErrorNon2xx_RemainsFailed(t *testing
mr := setupTestRedis(t)
defer mr.Close()
db.CacheURL(context.Background(), integrationTestTargetID, agentURL)
db.CacheURL(context.Background(), testTargetID, agentURL)
prevClient := a2aClient
defer func() { a2aClient = prevClient }()
@@ -355,7 +355,7 @@ func TestIntegration_ExecuteDelegation_ProxyErrorNon2xx_RemainsFailed(t *testing
})
start := time.Now()
runWithTimeout(t, 30*time.Second, func(ctx context.Context) {
dh.executeDelegation(ctx, integrationTestSourceID, integrationTestTargetID, integrationTestDelegationID, a2aBody)
dh.executeDelegation(ctx, testSourceID, testTargetID, testDelegationID, a2aBody)
})
t.Logf("executeDelegation took %v", time.Since(start))
@@ -383,7 +383,7 @@ func TestIntegration_ExecuteDelegation_ProxyErrorEmptyBody_RemainsFailed(t *test
mr := setupTestRedis(t)
defer mr.Close()
db.CacheURL(context.Background(), integrationTestTargetID, agentURL)
db.CacheURL(context.Background(), testTargetID, agentURL)
prevClient := a2aClient
defer func() { a2aClient = prevClient }()
@@ -404,7 +404,7 @@ func TestIntegration_ExecuteDelegation_ProxyErrorEmptyBody_RemainsFailed(t *test
})
start := time.Now()
runWithTimeout(t, 30*time.Second, func(ctx context.Context) {
dh.executeDelegation(ctx, integrationTestSourceID, integrationTestTargetID, integrationTestDelegationID, a2aBody)
dh.executeDelegation(ctx, testSourceID, testTargetID, testDelegationID, a2aBody)
})
t.Logf("executeDelegation took %v", time.Since(start))
@@ -431,7 +431,7 @@ func TestIntegration_ExecuteDelegation_CleanProxyResponse_Unchanged(t *testing.T
mr := setupTestRedis(t)
defer mr.Close()
db.CacheURL(context.Background(), integrationTestTargetID, agentURL)
db.CacheURL(context.Background(), testTargetID, agentURL)
prevClient := a2aClient
defer func() { a2aClient = prevClient }()
@@ -452,7 +452,7 @@ func TestIntegration_ExecuteDelegation_CleanProxyResponse_Unchanged(t *testing.T
})
start := time.Now()
runWithTimeout(t, 30*time.Second, func(ctx context.Context) {
dh.executeDelegation(ctx, integrationTestSourceID, integrationTestTargetID, integrationTestDelegationID, a2aBody)
dh.executeDelegation(ctx, testSourceID, testTargetID, testDelegationID, a2aBody)
})
t.Logf("executeDelegation took %v", time.Since(start))
@@ -497,7 +497,7 @@ func TestIntegration_ExecuteDelegation_RedisDown_FallsBackToDB(t *testing.T) {
})
start := time.Now()
runWithTimeout(t, 30*time.Second, func(ctx context.Context) {
dh.executeDelegation(ctx, integrationTestSourceID, integrationTestTargetID, integrationTestDelegationID, a2aBody)
dh.executeDelegation(ctx, testSourceID, testTargetID, testDelegationID, a2aBody)
})
t.Logf("executeDelegation took %v", time.Since(start))
@@ -282,7 +282,6 @@ func TestListDelegations_WithResults(t *testing.T) {
dh := NewDelegationHandler(wh, broadcaster)
now := time.Now()
deadline := now.Add(6 * time.Hour)
// Ledger query returns rows — no fallback to activity_logs
rows := sqlmock.NewRows([]string{
"delegation_id", "caller_id", "callee_id", "task_preview",
@@ -291,10 +290,10 @@ func TestListDelegations_WithResults(t *testing.T) {
}).
AddRow("del-111", "ws-source", "ws-target",
"Delegating to ws-target", "pending", "", "",
&now, &deadline, now, now).
&now, &now.Add(6*time.Hour), now, now).
AddRow("del-222", "ws-source", "ws-target",
"Delegation completed (hello world)", "completed", "hello world", "",
&now, &deadline, now, now.Add(time.Minute))
&now, &now.Add(6*time.Hour), now, now.Add(time.Minute))
mock.ExpectQuery("SELECT d.delegation_id, d.caller_id, d.callee_id, d.task_preview").
WithArgs("ws-source").
@@ -1361,7 +1360,6 @@ func TestExtractResponseText_EmptyText(t *testing.T) {
got := extractResponseText(body)
if got != "" {
t.Errorf("empty text: got %q, want %q", got, "")
}
}
// ---------- ListDelegations: ledger has rows → returns them (no activity_logs fallback) ----------
@@ -1374,7 +1372,6 @@ func TestListDelegations_LedgerRowsReturned(t *testing.T) {
dh := NewDelegationHandler(wh, broadcaster)
now := time.Now()
deadline := now.Add(6 * time.Hour)
// Ledger query returns rows
ledgerRows := sqlmock.NewRows([]string{
"delegation_id", "caller_id", "callee_id", "task_preview",
@@ -1383,7 +1380,7 @@ func TestListDelegations_LedgerRowsReturned(t *testing.T) {
}).AddRow(
"del-ledger-001", "caller-uuid", "callee-uuid",
"Analyze the codebase for bugs", "in_progress", "", "",
&now, &deadline, now, now,
&now, &now.Add(6*time.Hour), now, now,
)
mock.ExpectQuery("SELECT d.delegation_id, d.caller_id, d.callee_id, d.task_preview").
WithArgs("caller-uuid").
@@ -1594,7 +1591,6 @@ func TestListDelegations_LedgerCompletedIncludesResultPreview(t *testing.T) {
dh := NewDelegationHandler(wh, broadcaster)
now := time.Now()
deadline := now.Add(6 * time.Hour)
ledgerRows := sqlmock.NewRows([]string{
"delegation_id", "caller_id", "callee_id", "task_preview",
"status", "result_preview", "error_detail", "last_heartbeat",
@@ -1602,7 +1598,7 @@ func TestListDelegations_LedgerCompletedIncludesResultPreview(t *testing.T) {
}).AddRow(
"del-complete-001", "caller-uuid", "callee-uuid",
"Run analysis", "completed", "Analysis complete: 42 issues found", "",
&now, &deadline, now, now,
&now, &now.Add(6*time.Hour), now, now,
)
mock.ExpectQuery("SELECT d.delegation_id, d.caller_id, d.callee_id, d.task_preview").
WithArgs("caller-uuid").
@@ -1649,7 +1645,6 @@ func TestListDelegations_LedgerFailedIncludesErrorDetail(t *testing.T) {
dh := NewDelegationHandler(wh, broadcaster)
now := time.Now()
deadline := now.Add(6 * time.Hour)
ledgerRows := sqlmock.NewRows([]string{
"delegation_id", "caller_id", "callee_id", "task_preview",
"status", "result_preview", "error_detail", "last_heartbeat",
@@ -1657,7 +1652,7 @@ func TestListDelegations_LedgerFailedIncludesErrorDetail(t *testing.T) {
}).AddRow(
"del-failed-001", "caller-uuid", "callee-uuid",
"Fetch data", "failed", "", "Callee workspace not reachable",
&now, &deadline, now, now,
&now, &now.Add(6*time.Hour), now, now,
)
mock.ExpectQuery("SELECT d.delegation_id, d.caller_id, d.callee_id, d.task_preview").
WithArgs("caller-uuid").
@@ -140,14 +140,6 @@ func (h *WorkspaceHandler) Update(c *gin.Context) {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
return
}
if wsDir, ok := body["workspace_dir"]; ok && wsDir != nil {
if dirStr, isStr := wsDir.(string); isStr && dirStr != "" {
if err := validateWorkspaceDir(dirStr); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": "invalid workspace directory"})
return
}
}
}
ctx := c.Request.Context()
@@ -39,11 +39,6 @@ func newWorkspaceCrudHandler(t *testing.T) *WorkspaceHandler {
return NewWorkspaceHandler(nil, nil, "", t.TempDir())
}
func expectWorkspaceLiveTokenCount(mock sqlmock.Sqlmock, count int) {
mock.ExpectQuery(`SELECT COUNT\(\*\) FROM workspace_auth_tokens`).
WillReturnRows(sqlmock.NewRows([]string{"count"}).AddRow(count))
}
// ---------- State ----------
func TestState_LegacyWorkspaceNoLiveToken(t *testing.T) {
@@ -55,7 +50,8 @@ func TestState_LegacyWorkspaceNoLiveToken(t *testing.T) {
// No live token — legacy workspace, no auth required.
// HasAnyLiveToken always runs first (queries workspace_auth_tokens).
expectWorkspaceLiveTokenCount(mock, 0)
mock.ExpectQuery(`SELECT EXISTS\(SELECT 1 FROM workspace_auth_tokens`).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(false))
mock.ExpectQuery(`SELECT status FROM workspaces WHERE id = \$1`).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"status"}).AddRow("running"))
@@ -90,7 +86,8 @@ func TestState_HasLiveTokenMissingAuth(t *testing.T) {
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
expectWorkspaceLiveTokenCount(mock, 1)
mock.ExpectQuery(`SELECT EXISTS\(SELECT 1 FROM workspace_auth_tokens`).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(true))
req, _ := http.NewRequest("GET", "/workspaces/"+wsID+"/state", nil)
// No Authorization header
@@ -109,7 +106,8 @@ func TestState_WorkspaceNotFound(t *testing.T) {
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
expectWorkspaceLiveTokenCount(mock, 0)
mock.ExpectQuery(`SELECT EXISTS\(SELECT 1 FROM workspace_auth_tokens`).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(false))
mock.ExpectQuery(`SELECT status FROM workspaces WHERE id = \$1`).
WithArgs(wsID).
WillReturnError(sql.ErrNoRows)
@@ -138,7 +136,8 @@ func TestState_WorkspaceSoftDeleted(t *testing.T) {
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
expectWorkspaceLiveTokenCount(mock, 0)
mock.ExpectQuery(`SELECT EXISTS\(SELECT 1 FROM workspace_auth_tokens`).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(false))
mock.ExpectQuery(`SELECT status FROM workspaces WHERE id = \$1`).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"status"}).AddRow("removed"))
@@ -170,7 +169,8 @@ func TestState_QueryError(t *testing.T) {
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
expectWorkspaceLiveTokenCount(mock, 0)
mock.ExpectQuery(`SELECT EXISTS\(SELECT 1 FROM workspace_auth_tokens`).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(false))
mock.ExpectQuery(`SELECT status FROM workspaces WHERE id = \$1`).
WithArgs(wsID).
WillReturnError(sql.ErrConnDone)
-9
View File
@@ -77,15 +77,6 @@ VOLUME /configs
VOLUME /workspace
EXPOSE 8000
# HEALTHCHECK: probe the A2A agent-card endpoint so orchestrators and
# container runtimes can detect a live, responsive workspace agent.
# Uses curl (present in python:3.11-slim base) against the uvicorn server.
# PORT is injected at runtime via the molecule-runtime entrypoint; the
# default matches EXPOSE.
HEALTHCHECK --interval=30s --timeout=5s --retries=3 \
CMD curl -sf http://localhost:${PORT:-8000}/agent/card >/dev/null || exit 1
RUN chmod +x /app/entrypoint.sh
# Start as root — entrypoint fixes volume permissions then drops to agent
CMD ["./entrypoint.sh"]