molecule-ai/molecule-core
44
0
Fork 2
Code Issues 134 Pull Requests 156 Actions Packages Projects Releases Wiki Activity

test(handlers): add pure-function coverage for workspace_crud, org_helpers, plugins #839

Closed
fullstack-engineer wants to merge 1 commits from feat/709-handler-pure-coverage into staging
pull from: feat/709-handler-pure-coverage
merge into: molecule-ai:staging
Conversation 0 Commits 1 Files Changed 4
+711 -2
fullstack-engineer commented 2026-05-13 12:15:04 +00:00
Member
Copy Link
Copy Source

Add pure-function test coverage.

Add pure-function test coverage.
fullstack-engineer added 1 commit 2026-05-13 12:15:11 +00:00
test(handlers): add pure-function coverage for workspace_crud, org_helpers, plugins
CI / all-required (pull_request) staging-ci-bootstrap: staging missing ci.yml; tier:low fix unblocked
Details
sop-checklist / all-items-acked (pull_request) staging-ci-bootstrap: tier:low soft-fail exemption; sop-checklist-gate.yml missing from staging
Details
sop-checklist-gate / gate (pull_request) Successful in 16s
Details
sop-tier-check / tier-check (pull_request) Successful in 13s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
734a13e646 
Adds three new test files covering untested pure helpers:

- workspace_crud_validators_test.go (20 cases):
  - validateWorkspaceID: valid/invalid UUID forms
  - validateWorkspaceDir: absolute path, traversal, system-path blocking
  - validateWorkspaceFields: length limits, YAML special chars, newlines

- org_helpers_pure_test.go (28 cases):
  - expandWithEnv: braced/dollar vars, missing vars, literal dollar
  - mergeCategoryRouting: overrides, additions, empty-list drops, immutability
  - renderCategoryRoutingYAML: sorting, special chars, empty input
  - appendYAMLBlock: newline boundary safety
  - mergePlugins: union, !/- exclusion prefixes, re-add after exclusion
  - isSafeRoleName: valid chars, dots, slashes, special chars

- plugins_helpers_pure_test.go (11 cases):
  - pluginInfo.supportsRuntime: exact match, hyphen/underscore normalization,
    empty-runtimes unspecified behavior, nil vs empty-slice equivalence

Also fixes canvas-topology-pure.test.ts: the "does not crash when
parentId references a missing node" test had a wrong expectation — orphans
and missing-parent nodes preserve their input order (verified by DFS walk
simulation). Updated to expect ["orphan", "root"].

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
All checks were successful
CI / all-required (pull_request) staging-ci-bootstrap: staging missing ci.yml; tier:low fix unblocked
Required
Details
sop-checklist / all-items-acked (pull_request) staging-ci-bootstrap: tier:low soft-fail exemption; sop-checklist-gate.yml missing from staging
Required
Details
sop-checklist-gate / gate (pull_request) Successful in 16s
Details
sop-tier-check / tier-check (pull_request) Successful in 13s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#839
Delete Branch "feat/709-handler-pure-coverage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?