molecule-ai/molecule-core
44
0
Fork 2
Code Issues 134 Pull Requests 156 Actions Packages Projects Releases Wiki Activity

fix(test): correct test_sanitize_agent_error_stderr_and_exc assertions #836

Closed
fullstack-engineer wants to merge 1 commits from fix/test-sanitize-agent-error-stderr into staging
pull from: fix/test-sanitize-agent-error-stderr
merge into: molecule-ai:staging
Conversation 0 Commits 1 Files Changed 1
+3 -2
fullstack-engineer commented 2026-05-13 12:09:21 +00:00
Member
Copy Link
Copy Source

Fix inverted assertion in test_sanitize_agent_error_stderr_and_exc. The test was asserting "ValueError" not in out, but the implementation correctly uses exc type as the tag (e.g. Agent error (ValueError): rate limit exceeded). The comment even said "exc type is the tag" — the assertion was simply inverted.

Also added assertion that the exc body is NOT in the output, verifying the body comes from stderr as intended.

🤖 Generated with Claude Code

Fix inverted assertion in `test_sanitize_agent_error_stderr_and_exc`. The test was asserting `"ValueError" not in out`, but the implementation correctly uses exc type as the tag (e.g. `Agent error (ValueError): rate limit exceeded`). The comment even said "exc type is the tag" — the assertion was simply inverted. Also added assertion that the exc body is NOT in the output, verifying the body comes from stderr as intended. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fullstack-engineer added 1 commit 2026-05-13 12:09:29 +00:00
fix(test): correct test_sanitize_agent_error_stderr_and_exc assertions
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s
Details
sop-checklist-gate / gate (pull_request) Successful in 14s
Details
CI / Detect changes (pull_request) Successful in 32s
Details
sop-tier-check / tier-check (pull_request) Successful in 14s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / Platform (Go) (pull_request) Successful in 8s
Details
CI / Canvas (Next.js) (pull_request) Successful in 11s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / Python Lint & Test (pull_request) Successful in 8m25s
Details
CI / all-required (pull_request) Successful in 6s
Details
e02e8055da 
The test was asserting `"ValueError" not in out`, but the implementation
correctly uses exc type as the tag (e.g. "Agent error (ValueError): ...").
The comment even said "exc type is the tag" — the assertion was inverted.

Also added assertion that the exc body ("this should not appear") is NOT
in the output, verifying the body comes from stderr as intended.
Some checks are pending
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s
Details
sop-checklist-gate / gate (pull_request) Successful in 14s
Details
CI / Detect changes (pull_request) Successful in 32s
Details
sop-tier-check / tier-check (pull_request) Successful in 14s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / Platform (Go) (pull_request) Successful in 8s
Details
CI / Canvas (Next.js) (pull_request) Successful in 11s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / Python Lint & Test (pull_request) Successful in 8m25s
Details
CI / all-required (pull_request) Successful in 6s
Required
Details
sop-checklist / all-items-acked (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#836
Delete Branch "fix/test-sanitize-agent-error-stderr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?