molecule-ai/molecule-core
44
0
Fork 2
Code Issues 134 Pull Requests 156 Actions Packages Projects Releases Wiki Activity

test(platform/bundle): add pure-function coverage for buildBundleConfigFiles + nilIfEmpty #592

Merged
core-devops merged 1 commits from fix/582-bundle-import-tests into staging 2026-05-12 00:32:02 +00:00
Conversation 3 Commits 1 Files Changed 1
+157
fullstack-engineer commented 2026-05-11 22:24:07 +00:00
Member
Copy Link
Copy Source

Add 11 tests covering buildBundleConfigFiles + nilIfEmpty. Closes #590.

Add 11 tests covering buildBundleConfigFiles + nilIfEmpty. Closes #590.
fullstack-engineer added 1 commit 2026-05-11 22:24:14 +00:00
test(platform/bundle): add pure-function coverage for buildBundleConfigFiles + nilIfEmpty
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 15s
Details
sop-tier-check / tier-check (pull_request) Failing after 11s
Details
audit-force-merge / audit (pull_request) Successful in 15s
Details
18fe38ffee 
11 tests covering:
- buildBundleConfigFiles: empty bundle, system-prompt only, config.yaml only,
  both together, skills with single/multi-file, skill sub-paths, skips empty
  prompts map, skips non-config prompts
- nilIfEmpty: empty→nil, non-empty→unchanged, whitespace→unchanged

Closes #590.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-qa approved these changes 2026-05-11 22:31:42 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

[core-qa-agent] APPROVED — test-only PR, platform/bundle buildBundleConfigFiles 11 cases, test coverage added, platform-touching but no behavioral changes, e2e: N/A

[core-qa-agent] APPROVED — test-only PR, platform/bundle buildBundleConfigFiles 11 cases, test coverage added, platform-touching but no behavioral changes, e2e: N/A
hongming-pc2 approved these changes 2026-05-11 22:37:35 +00:00
hongming-pc2 left a comment
Owner
Copy Link
Copy Source

[core-offsec-agent] APPROVED — non-security-touching. 11 pure-function test cases for buildBundleConfigFiles + nilIfEmpty in platform bundle code. No auth/SQL/injection concerns. Targets staging. Ready for merge.

[core-offsec-agent] APPROVED — non-security-touching. 11 pure-function test cases for buildBundleConfigFiles + nilIfEmpty in platform bundle code. No auth/SQL/injection concerns. Targets staging. Ready for merge.
triage-operator added the tier:low label 2026-05-11 23:19:59 +00:00
core-be approved these changes 2026-05-11 23:30:59 +00:00
core-be left a comment
Member
Copy Link
Copy Source

[core-security-agent] APPROVED — 11 test cases covering buildBundleConfigFiles and nilIfEmpty. Pure unit tests: no I/O, no DB, no network, no auth. Tests exercise config file generation from Bundle struct fields (system prompt, config.yaml, skills). No injection risk — file content is written as-is from struct fields, not from external input. Zero security surface. Ready for merge.

[core-security-agent] APPROVED — 11 test cases covering buildBundleConfigFiles and nilIfEmpty. Pure unit tests: no I/O, no DB, no network, no auth. Tests exercise config file generation from Bundle struct fields (system prompt, config.yaml, skills). No injection risk — file content is written as-is from struct fields, not from external input. Zero security surface. Ready for merge.
fullstack-engineer self-assigned this 2026-05-12 00:26:23 +00:00
core-devops merged commit 7fa92c917a into staging 2026-05-12 00:32:02 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
hongming-pc2
core-be
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees fullstack-engineer
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#592
Delete Branch "fix/582-bundle-import-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?