molecule-ai/molecule-core
44
0
Fork 2
Code Issues 134 Pull Requests 156 Actions Packages Projects Releases Wiki Activity

fix(ci): gate-check-v3 crashes on HTTPError during comment posting #548

Closed
core-devops wants to merge 1 commits from fix/gate-check-v3-http-error-crash into main
pull from: fix/gate-check-v3-http-error-crash
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 1
+19 -15
core-devops commented 2026-05-11 19:09:15 +00:00
Member
Copy Link
Copy Source

Summary

  • Wrap the comment-posting section of run() in tools/gate-check-v3/gate_check.py with try/except urllib.error.HTTPError
  • When the token lacks write:repository (403 from Gitea on POST/PATCH comments), the error is now caught, a warning is printed to stderr, and the function returns the already-computed result instead of crashing
  • The verdict (CLEAR/BLOCKED/ERROR) is unaffected — comment posting is best-effort

Root cause

urllib.error.HTTPError is NOT a subclass of GiteaError. The outer except GiteaError block catches API errors during gate computation, but the direct urllib.request.urlopen() calls for comment POST/PATCH were not wrapped. A 403 (token lacks write:repository) would raise HTTPError and propagate as an unhandled exception, causing the script to exit non-zero.

Test plan

  • Verify script still exits 0 for CLEAR verdict when token lacks write:repository (warning printed, no crash)
  • Verify script exits 1 for BLOCKED verdict (correct) when token lacks write:repository
  • Existing gate-check-v3 runs in CI (with the token that has write:repository) are unaffected

🤖 Generated with Claude Code

## Summary - Wrap the comment-posting section of `run()` in `tools/gate-check-v3/gate_check.py` with `try/except urllib.error.HTTPError` - When the token lacks `write:repository` (403 from Gitea on POST/PATCH comments), the error is now caught, a warning is printed to stderr, and the function returns the already-computed result instead of crashing - The verdict (CLEAR/BLOCKED/ERROR) is unaffected — comment posting is best-effort ## Root cause `urllib.error.HTTPError` is NOT a subclass of `GiteaError`. The outer `except GiteaError` block catches API errors during gate computation, but the direct `urllib.request.urlopen()` calls for comment POST/PATCH were not wrapped. A 403 (token lacks write:repository) would raise `HTTPError` and propagate as an unhandled exception, causing the script to exit non-zero. ## Test plan - [ ] Verify script still exits 0 for CLEAR verdict when token lacks write:repository (warning printed, no crash) - [ ] Verify script exits 1 for BLOCKED verdict (correct) when token lacks write:repository - [ ] Existing gate-check-v3 runs in CI (with the token that has write:repository) are unaffected 🤖 Generated with [Claude Code](https://claude.ai/code)
core-devops added 1 commit 2026-05-11 19:09:23 +00:00
fix(ci): catch urllib.error.HTTPError in gate-check-v3 comment posting
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 18s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 16s
Details
gate-check-v3 / gate-check (pull_request) Failing after 21s
Details
qa-review / approved (pull_request) Failing after 15s
Details
security-review / approved (pull_request) Failing after 19s
Details
sop-tier-check / tier-check (pull_request) Successful in 18s
Details
CI / Detect changes (pull_request) Successful in 1m11s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m11s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m7s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m6s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m13s
Details
CI / Platform (Go) (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 9s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 8s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 9s
Details
CI / Python Lint & Test (pull_request) Successful in 11s
Details
CI / Canvas (Next.js) (pull_request) Successful in 11s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 11s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
f0f9d44fde 
HttpError (e.g. 403 from missing write:repository) was not caught,
causing the entire script to crash after the verdict was already
computed. Now wrapped in try/except — comment-posting failure is non-fatal
and logged as a warning; the result with verdict is still returned.

Fixes: #543
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-devops closed this pull request 2026-05-11 19:15:45 +00:00
Some checks are pending
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 18s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 16s
Details
gate-check-v3 / gate-check (pull_request) Failing after 21s
Details
qa-review / approved (pull_request) Failing after 15s
Details
security-review / approved (pull_request) Failing after 19s
Details
sop-tier-check / tier-check (pull_request) Successful in 18s
Details
CI / Detect changes (pull_request) Successful in 1m11s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m11s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m7s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m6s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m13s
Details
CI / Platform (Go) (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 9s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 8s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 9s
Details
CI / Python Lint & Test (pull_request) Successful in 11s
Details
CI / Canvas (Next.js) (pull_request) Successful in 11s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 11s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / all-required (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#548
Delete Branch "fix/gate-check-v3-http-error-crash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?