molecule-ai/molecule-core
44
0
Fork 2
Code Issues 134 Pull Requests 156 Actions Packages Projects Releases Wiki Activity

fix(plugins/test): skip TestLocalResolver_BubblesUpCopyFailure when running as root (closes #87) #186

Closed
core-be wants to merge 0 commits from fix/test-local-resolver-root-skip into main
pull from: fix/test-local-resolver-root-skip
merge into: molecule-ai:main
Conversation 0 Commits - Files Changed -
core-be commented 2026-05-09 22:31:39 +00:00
Member
Copy Link
Copy Source

Summary

Skip TestLocalResolver_BubblesUpCopyFailure when the test runner has uid 0 (root). On Linux, chmod 0o555 does not prevent writes for uid 0 — the filesystem permission model is advisory-only for root. This caused the test to pass vacuously on root-run CI instead of exercising the error path.

Follows the same root-skip pattern already used by:

  • TestLocalResolver_CopyFileSourceUnreadable
  • TestLocalResolver_WalkErrorPropagates
  • TestLocalResolver_NonNotExistStatErrorIsNotErrPluginNotFound

Test plan

  • Test passes on non-root CI (chmod 0o555 is effective)
  • Test skipped on root-run CI (chmod 0o555 is ineffective — vacuous pass)

Claude Code

## Summary Skip TestLocalResolver_BubblesUpCopyFailure when the test runner has uid 0 (root). On Linux, chmod 0o555 does not prevent writes for uid 0 — the filesystem permission model is advisory-only for root. This caused the test to pass vacuously on root-run CI instead of exercising the error path. Follows the same root-skip pattern already used by: - TestLocalResolver_CopyFileSourceUnreadable - TestLocalResolver_WalkErrorPropagates - TestLocalResolver_NonNotExistStatErrorIsNotErrPluginNotFound ## Test plan - [x] Test passes on non-root CI (chmod 0o555 is effective) - [x] Test skipped on root-run CI (chmod 0o555 is ineffective — vacuous pass) Claude Code
core-be closed this pull request 2026-05-09 22:32:00 +00:00
Some checks are pending
sop-tier-check / tier-check (pull_request) Failing after 4s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / all-required (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#186
Delete Branch "fix/test-local-resolver-root-skip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?