molecule-ai/molecule-core
44
0
Fork 2
Code Issues 134 Pull Requests 156 Actions Packages Projects Releases Wiki Activity

ci: remove slash from tenant-token lint workflow name #1574

Open
hongming wants to merge 2 commits from fix/workflow-name-no-token-slash into main
pull from: fix/workflow-name-no-token-slash
merge into: molecule-ai:main
Conversation 3 Commits 2 Files Changed 1
+3 -1
hongming commented 2026-05-19 20:15:16 +00:00
Owner
Copy Link
Copy Source

Phase 1 evidence

Brief claims

  • [H1] 13:11 PDT molecule-core main red has at least one repo-owned CI/security hardening regression worth fixing now.

Verification queries + evidence

  • H1 confirmed: fresh Gitea status for molecule-core/main@302235da2339 showed publish-workspace-server-image / Production auto-deploy and status-reaper / reap failing.
  • Direct logs:
    • /molecule-ai/molecule-core/actions/runs/73720/jobs/1/logs reports lint-workflow-yaml: 1 fatal violation and points at .gitea/workflows/lint-no-tenant-gitea-token.yml.
    • /molecule-ai/molecule-core/actions/runs/73764/jobs/0/logs reports workflow name contains '/' which breaks context parsing: Lint no tenant GITEA/GITHUB token write.

Root cause

The workflow name contains a slash in GITEA/GITHUB, violating the repo-owned context parser convention <workflow> / <job> (<event>).

Phase 2 design

Small repo-owned config fix: rename the workflow to keep the same meaning without /: Lint no tenant Gitea-GitHub token write.

Rollback: revert this single commit.

Verification

  • python3 .gitea/scripts/lint-workflow-yaml.py passed: 59 workflows checked, no fatal Gitea-hostile shapes.
  • git diff --check passed.

No merge, force-push, push to main, secret rotation, protection mutation, destructive cleanup, or runner restart performed.

## Phase 1 evidence ### Brief claims - [H1] 13:11 PDT molecule-core main red has at least one repo-owned CI/security hardening regression worth fixing now. ### Verification queries + evidence - H1 confirmed: fresh Gitea status for `molecule-core/main@302235da2339` showed `publish-workspace-server-image / Production auto-deploy` and `status-reaper / reap` failing. - Direct logs: - `/molecule-ai/molecule-core/actions/runs/73720/jobs/1/logs` reports `lint-workflow-yaml: 1 fatal violation` and points at `.gitea/workflows/lint-no-tenant-gitea-token.yml`. - `/molecule-ai/molecule-core/actions/runs/73764/jobs/0/logs` reports `workflow name contains '/' which breaks context parsing: Lint no tenant GITEA/GITHUB token write`. ### Root cause The workflow name contains a slash in `GITEA/GITHUB`, violating the repo-owned context parser convention `<workflow> / <job> (<event>)`. ## Phase 2 design Small repo-owned config fix: rename the workflow to keep the same meaning without `/`: `Lint no tenant Gitea-GitHub token write`. Rollback: revert this single commit. ## Verification - `python3 .gitea/scripts/lint-workflow-yaml.py` passed: 59 workflows checked, no fatal Gitea-hostile shapes. - `git diff --check` passed. No merge, force-push, push to main, secret rotation, protection mutation, destructive cleanup, or runner restart performed.
hongming added 1 commit 2026-05-19 20:15:16 +00:00
ci: remove slash from tenant-token lint workflow name
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 9s
Details
CI / Detect changes (pull_request) Successful in 12s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 23s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 15s
Details
E2E Chat / detect-changes (pull_request) Successful in 13s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 11s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 11s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
Lint no tenant Gitea-GitHub token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Failing after 27s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m22s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 3s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 21s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 8s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
Details
gate-check-v3 / gate-check (pull_request) Successful in 4s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m21s
Details
qa-review / approved (pull_request) Failing after 3s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 4s
Details
security-review / approved (pull_request) Failing after 8s
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m25s
Details
CI / Platform (Go) (pull_request) Successful in 5m16s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7m0s
Details
CI / Python Lint & Test (pull_request) Successful in 7m3s
Details
CI / all-required (pull_request) Successful in 7m18s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 5s
Details
E2E Chat / E2E Chat (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 3s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
c8c692e600
hongming added 1 commit 2026-05-19 21:14:35 +00:00
ci: annotate renamed tenant-token lint context
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 8s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 20s
Details
E2E Chat / detect-changes (pull_request) Successful in 10s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
Details
Harness Replays / detect-changes (pull_request) Successful in 5s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint no tenant Gitea-GitHub token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
CI / Platform (Go) (pull_request) Successful in 2m41s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m17s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m9s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 33s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 3s
Details
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 6s
Details
gate-check-v3 / gate-check (pull_request) Successful in 6s
Details
qa-review / approved (pull_request) Failing after 4s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 30s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
Details
publish-runtime-autobump / pr-validate (pull_request) Successful in 35s
Details
security-review / approved (pull_request) Failing after 3s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m10s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 29s
Details
CI / Canvas (Next.js) (pull_request) Successful in 5m27s
Details
CI / Python Lint & Test (pull_request) Successful in 6m34s
Details
CI / all-required (pull_request) Successful in 6m26s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 53s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 2m7s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2m41s
Details
E2E Chat / E2E Chat (pull_request) Failing after 7m6s
Details
4d626c76f3
hongming commented 2026-05-19 21:15:00 +00:00
Author
Owner
Copy Link
Copy Source

14:11 PDT follow-up on PR #1574:

The first PR run correctly failed Tier 2g because the workflow rename creates new status context names. I added an in-file directive above scan::

# bp-exempt: merge protection is enforced through CI / all-required; this workflow is a component guardrail context rather than a direct BP context.

Fresh local verification after the follow-up commit:

  • python3 .gitea/scripts/lint-workflow-yaml.py: passed, 59 workflow files checked, no fatal shapes.
  • BASE_SHA=$(git merge-base origin/main HEAD) HEAD_SHA=$(git rev-parse HEAD) ... python3 .gitea/scripts/lint_required_context_exists_in_bp.py: passed, both new pull_request and push emissions directive-validated.
  • git diff --check: passed.

Pushed normal follow-up commit 4d626c76; no force-push, merge, push to main, secret rotation, protection mutation, destructive cleanup, or runner restart performed.

14:11 PDT follow-up on PR #1574: The first PR run correctly failed Tier 2g because the workflow rename creates new status context names. I added an in-file directive above `scan:`: `# bp-exempt: merge protection is enforced through CI / all-required; this workflow is a component guardrail context rather than a direct BP context.` Fresh local verification after the follow-up commit: - `python3 .gitea/scripts/lint-workflow-yaml.py`: passed, 59 workflow files checked, no fatal shapes. - `BASE_SHA=$(git merge-base origin/main HEAD) HEAD_SHA=$(git rev-parse HEAD) ... python3 .gitea/scripts/lint_required_context_exists_in_bp.py`: passed, both new pull_request and push emissions directive-validated. - `git diff --check`: passed. Pushed normal follow-up commit `4d626c76`; no force-push, merge, push to main, secret rotation, protection mutation, destructive cleanup, or runner restart performed.
hongming commented 2026-05-19 22:13:22 +00:00
Author
Owner
Copy Link
Copy Source

15:11 PDT CI follow-up evidence:

Positive signal on the repo-owned fix:

  • lint-required-context-exists-in-bp / lint-required-context-exists-in-bp passed on run /molecule-ai/molecule-core/actions/runs/73944/jobs/0; both new pull_request and push emissions were directive-validated and 11 unit tests passed.
  • Lint workflow YAML (Gitea-1.22.6-hostile shapes) passed on run /molecule-ai/molecule-core/actions/runs/73948/jobs/0; 59 workflows checked and 27 tests passed.

Remaining red on this PR appears unrelated to the workflow rename:

  • E2E API Smoke failed in POST /workspaces (alpha/beta) after earlier suites passed.
  • E2E Chat failed with 8 Playwright visibility assertions after Canvas startup.
  • qa-review and security-review are awaiting non-author approvals.

No merge, force-push, push to main, secret rotation, protection mutation, destructive cleanup, or runner restart performed.

15:11 PDT CI follow-up evidence: Positive signal on the repo-owned fix: - `lint-required-context-exists-in-bp / lint-required-context-exists-in-bp` passed on run `/molecule-ai/molecule-core/actions/runs/73944/jobs/0`; both new pull_request and push emissions were directive-validated and 11 unit tests passed. - `Lint workflow YAML (Gitea-1.22.6-hostile shapes)` passed on run `/molecule-ai/molecule-core/actions/runs/73948/jobs/0`; 59 workflows checked and 27 tests passed. Remaining red on this PR appears unrelated to the workflow rename: - E2E API Smoke failed in `POST /workspaces (alpha/beta)` after earlier suites passed. - E2E Chat failed with 8 Playwright visibility assertions after Canvas startup. - `qa-review` and `security-review` are awaiting non-author approvals. No merge, force-push, push to main, secret rotation, protection mutation, destructive cleanup, or runner restart performed.
hongming commented 2026-05-19 23:14:53 +00:00
Author
Owner
Copy Link
Copy Source

needs-hongming / human decision:

Question: Should PR #1574 be routed for QA/security approval now, or should it wait behind the unrelated E2E failures on this branch?

Impact: The repo-owned fix checks are green and the change addresses the main push failures in production auto-deploy/status-reaper caused by the slash-containing workflow name. Until this lands, main continues emitting old Lint no tenant GITEA/GITHUB token write contexts and those operational jobs keep failing.

Evidence:

  • lint-required-context-exists-in-bp passed on /molecule-ai/molecule-core/actions/runs/73944/jobs/0 with both new emissions directive-validated.
  • lint-workflow-yaml passed on /molecule-ai/molecule-core/actions/runs/73948/jobs/0 with 59 workflows checked.
  • Remaining PR reds are unrelated E2E API Smoke (POST /workspaces alpha/beta), E2E Chat Playwright visibility failures, and QA/security review gates.

No merge or protection change requested/performed.

needs-hongming / human decision: Question: Should PR #1574 be routed for QA/security approval now, or should it wait behind the unrelated E2E failures on this branch? Impact: The repo-owned fix checks are green and the change addresses the main push failures in production auto-deploy/status-reaper caused by the slash-containing workflow name. Until this lands, main continues emitting old `Lint no tenant GITEA/GITHUB token write` contexts and those operational jobs keep failing. Evidence: - `lint-required-context-exists-in-bp` passed on `/molecule-ai/molecule-core/actions/runs/73944/jobs/0` with both new emissions directive-validated. - `lint-workflow-yaml` passed on `/molecule-ai/molecule-core/actions/runs/73948/jobs/0` with 59 workflows checked. - Remaining PR reds are unrelated E2E API Smoke (`POST /workspaces` alpha/beta), E2E Chat Playwright visibility failures, and QA/security review gates. No merge or protection change requested/performed.
Some optional checks failed
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 8s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 20s
Details
E2E Chat / detect-changes (pull_request) Successful in 10s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
Details
Harness Replays / detect-changes (pull_request) Successful in 5s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint no tenant Gitea-GitHub token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
CI / Platform (Go) (pull_request) Successful in 2m41s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m17s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m9s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 33s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 3s
Details
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 6s
Details
gate-check-v3 / gate-check (pull_request) Successful in 6s
Details
qa-review / approved (pull_request) Failing after 4s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 30s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
Details
publish-runtime-autobump / pr-validate (pull_request) Successful in 35s
Details
security-review / approved (pull_request) Failing after 3s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m10s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 29s
Details
CI / Canvas (Next.js) (pull_request) Successful in 5m27s
Details
CI / Python Lint & Test (pull_request) Successful in 6m34s
Details
CI / all-required (pull_request) Successful in 6m26s
Required
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 53s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 2m7s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2m41s
Details
E2E Chat / E2E Chat (pull_request) Failing after 7m6s
Details
This pull request doesn't have enough required approvals yet. 0 of 2 official approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/workflow-name-no-token-slash:fix/workflow-name-no-token-slash
git checkout fix/workflow-name-no-token-slash
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1574
Delete Branch "fix/workflow-name-no-token-slash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?