molecule-ai/molecule-core
44
0
Fork 2
Code Issues 134 Pull Requests 156 Actions Packages Projects Releases Wiki Activity

fix(org-import): started event emits after YAML parse so name is populated #142

Merged
claude-ceo-assistant merged 1 commits from fix/org-import-started-event-name into main 2026-05-08 23:30:03 +00:00
Conversation 0 Commits 1 Files Changed 1
+13 -6
claude-ceo-assistant commented 2026-05-08 23:25:41 +00:00
Owner
Copy Link
Copy Source

Summary

The org.import.started event was firing immediately after request body bind, before the YAML at body.Dir was loaded. Payload name was "" whenever the caller passed dir (the common path — canvas and all live imports use dir, not inline template). Three started rows already in the local platform's structure_events have empty name.

Follow-up to PR #137; called out as a follow-up in that PR's body.

Fix

Move the started emit (and importStart timestamp) to after the YAML unmarshal / inline-template fallthrough, where tmpl.Name is guaranteed populated.

Bonus side-effect

Pre-parse error returns (invalid body, traversal-rejected dir, file-not-found, YAML expansion fail, YAML unmarshal fail, neither dir nor template provided) no longer emit an orphan started row. Every started is now guaranteed a paired completed/failed — semantically "we couldn't even start an import" doesn't claim it started.

Verification

  • Local Postgres E2E: re-imported molecule-dev-only; new started row in structure_events carries "Molecule AI Dev Team (dev-only)" instead of ""
  • go test ./internal/handlers/... green
  • go build clean
SELECT to_char(created_at,'HH24:MI:SS'), event_type, payload->>'name'
FROM structure_events
WHERE event_type LIKE 'org.import%' ORDER BY created_at DESC LIMIT 4;
--    23:23:52 | org.import.completed | Molecule AI Dev Team (dev-only)
--    23:23:36 | org.import.started   | Molecule AI Dev Team (dev-only)  ← was "" before fix
--    22:01:27 | org.import.completed | Molecule AI Dev Team (dev-only)
--    22:01:11 | org.import.started   |                                   ← old shape

🤖 Generated with Claude Code

## Summary The `org.import.started` event was firing immediately after request body bind, before the YAML at `body.Dir` was loaded. Payload `name` was `""` whenever the caller passed `dir` (the common path — canvas and all live imports use `dir`, not inline `template`). Three started rows already in the local platform's `structure_events` have empty `name`. Follow-up to PR #137; called out as a follow-up in that PR's body. ## Fix Move the started emit (and `importStart` timestamp) to after the YAML unmarshal / inline-template fallthrough, where `tmpl.Name` is guaranteed populated. ## Bonus side-effect Pre-parse error returns (invalid body, traversal-rejected `dir`, file-not-found, YAML expansion fail, YAML unmarshal fail, neither `dir` nor `template` provided) no longer emit an orphan `started` row. Every `started` is now guaranteed a paired `completed`/`failed` — semantically "we couldn't even start an import" doesn't claim it started. ## Verification - [x] Local Postgres E2E: re-imported `molecule-dev-only`; new started row in `structure_events` carries `"Molecule AI Dev Team (dev-only)"` instead of `""` - [x] `go test ./internal/handlers/...` green - [x] `go build` clean ```sql SELECT to_char(created_at,'HH24:MI:SS'), event_type, payload->>'name' FROM structure_events WHERE event_type LIKE 'org.import%' ORDER BY created_at DESC LIMIT 4; -- 23:23:52 | org.import.completed | Molecule AI Dev Team (dev-only) -- 23:23:36 | org.import.started | Molecule AI Dev Team (dev-only) ← was "" before fix -- 22:01:27 | org.import.completed | Molecule AI Dev Team (dev-only) -- 22:01:11 | org.import.started | ← old shape ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude-ceo-assistant added 1 commit 2026-05-08 23:25:41 +00:00
fix(org-import): emit started event after YAML parse so name is populated
CodeQL / Analyze (${{ matrix.language }}) (go) (pull_request) Successful in 1s
Details
CodeQL / Analyze (${{ matrix.language }}) (javascript-typescript) (pull_request) Successful in 1s
Details
CodeQL / Analyze (${{ matrix.language }}) (python) (pull_request) Successful in 1s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 7s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 7s
Details
Harness Replays / detect-changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
CI / Canvas (Next.js) (pull_request) Successful in 4s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Harness Replays / Harness Replays (pull_request) Successful in 59s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m45s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m53s
Details
CI / Platform (Go) (pull_request) Successful in 2m51s
Details
b3041c13d3 
The org.import.started event was firing immediately after request body
bind, before the YAML at body.Dir was loaded. Result: payload.name was
"" whenever the caller passed `dir` (the common path — the canvas and
all live imports use dir, not inline template). Three started rows
already in the local platform's structure_events have empty name.

Fix: move the started emit (and importStart timestamp) to after the
YAML unmarshal / inline-template fallthrough, where tmpl.Name is
guaranteed populated.

Bonus: pre-parse error returns (invalid body, traversal-rejected dir,
file-not-found, YAML expansion fail, YAML unmarshal fail, neither dir
nor template provided) no longer emit an orphan started row — every
started is now guaranteed a paired completed/failed.

Verified live against running platform: re-imported molecule-dev-only,
new started row in structure_events carries
"Molecule AI Dev Team (dev-only)" instead of "".

Tests: full handler suite green (`go test ./internal/handlers/`).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
claude-ceo-assistant merged commit a93c4ce177 into main 2026-05-08 23:30:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#142
Delete Branch "fix/org-import-started-event-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?