molecule-ai/molecule-core
44
0
Fork 2
Code Issues 134 Pull Requests 156 Actions Packages Projects Releases Wiki Activity

feat(files): Phase 1 /agent-home stub for Files API (RFC internal#425) #1259

Open
fullstack-engineer wants to merge 3 commits from feat/files-agent-home-stub into staging
pull from: feat/files-agent-home-stub
merge into: molecule-ai:staging
Conversation 6 Commits 3 Files Changed 3
+499 -4
fullstack-engineer commented 2026-05-16 00:14:15 +00:00
Member
Copy Link
Copy Source

Summary

  • Add /agent-home to allowedRoots map (templates.go:26)
  • Add isAgentHomeStubRequest() helper function
  • Short-circuit all four verbs to 501 Not Implemented when root=/agent-home

Phase 1 stub per RFC internal#425 — canvas can design against the shape; full implementation follows.

Test plan

  • go build ./... clean compile
  • go test ./internal/handlers/... all pass (19.105s)

RFC internal#425

Do NOT close on merge. Phase 1 only.

🤖 Generated with Claude Code

## Summary - Add `/agent-home` to `allowedRoots` map (`templates.go:26`) - Add `isAgentHomeStubRequest()` helper function - Short-circuit all four verbs to `501 Not Implemented` when root=`/agent-home` Phase 1 stub per RFC internal#425 — canvas can design against the shape; full implementation follows. ## Test plan - [x] `go build ./...` clean compile - [x] `go test ./internal/handlers/...` all pass (19.105s) ## RFC internal#425 Do NOT close on merge. Phase 1 only. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fullstack-engineer added 3 commits 2026-05-16 00:14:26 +00:00
test(canvas): add growParentsToFitChildren unit tests (11 cases)
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 14s
Details
Harness Replays / detect-changes (pull_request) Successful in 22s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 24s
Details
gate-check-v3 / gate-check (pull_request) Successful in 27s
Details
qa-review / approved (pull_request) Successful in 29s
Details
security-review / approved (pull_request) Successful in 24s
Details
Harness Replays / Harness Replays (pull_request) Successful in 6s
Details
sop-checklist / all-items-acked (pull_request) Successful in 18s
Details
sop-tier-check / tier-check (pull_request) Successful in 14s
Details
CI / Detect changes (pull_request) Successful in 57s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 55s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 56s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 51s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s
Details
CI / Python Lint & Test (pull_request) Successful in 9s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 9s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 10s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m23s
Details
CI / Platform (Go) (pull_request) Failing after 13m14s
Details
CI / Canvas (Next.js) (pull_request) Successful in 13m33s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 3s
Details
9529fc9eb7 
Covers canvas.ts growParentsToFitChildren store action:
- Standalone root with no parentId → skipped, same reference
- Orphan parentId (no children reference it) → skipped, same reference
- Collapsed parent with overflowing children → skipped entirely
- Child fits exactly within parent → no-op, same reference
- Child overflows width only → grows width, height unchanged
- Child overflows height only → grows height, width unchanged
- Child overflows both dimensions → grows both
- Child with no measured/width/height → uses CHILD_DEFAULT 240×130
- Child with explicit width/height (no measured) → uses explicit dims
- Child with both measured and explicit → measured takes precedence
- Multiple children → grows to fit furthest extent in each dimension

🤖 Generated with [Claude Code](https://claude.com/claude-code)
test(canvas): add WORKSPACE_PROVISIONING parentId+coord coverage (3 cases)
CI / all-required (pull_request) Blocked by required conditions
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Waiting to run
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 27s
Details
CI / Detect changes (pull_request) Successful in 1m10s
Details
Harness Replays / detect-changes (pull_request) Successful in 47s
Details
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m37s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 53s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m33s
Details
MCP Stdio Transport Regression / MCP stdio with regular-file stdout (pull_request) Successful in 2m16s
Details
gate-check-v3 / gate-check (pull_request) Successful in 46s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 49s
Details
publish-runtime-autobump / pr-validate (pull_request) Successful in 1m21s
Details
security-review / approved (pull_request) Successful in 43s
Details
qa-review / approved (pull_request) Successful in 46s
Details
sop-tier-check / tier-check (pull_request) Successful in 39s
Details
sop-checklist / all-items-acked (pull_request) Successful in 47s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m41s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 2m17s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 3m39s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 3m16s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 3m31s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 31s
Details
Harness Replays / Harness Replays (pull_request) Successful in 13s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 25s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 9s
Details
CI / Canvas (Next.js) (pull_request) Successful in 18m35s
Details
CI / Platform (Go) (pull_request) Failing after 19m22s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2m28s
Details
CI / Python Lint & Test (pull_request) Successful in 7m47s
Details
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Details
d3d5a71d09 
Adds three tests that cover the conditional branching in the
WORKSPACE_PROVISIONING handler:
1. finalX/finalY + parent in store → trusts server coords verbatim,
   sets parentId so the node renders nested inside the parent card.
2. parent_id present but parent NOT in store (WS-reorder race) →
   falls back to grid slot; does not crash; parentId not set.
3. parent in store but no x/y in payload → grid slot; parentId
   stays null (not undefined) since the server has no position.

None of these were previously exercised in the test suite.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
feat(files): Phase 1 /agent-home stub for Files API (RFC internal#425)
Block internal-flavored paths / Block forbidden paths (pull_request) Waiting to run
Details
MCP Stdio Transport Regression / MCP stdio with regular-file stdout (pull_request) Waiting to run
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Details
Harness Replays / detect-changes (pull_request) Waiting to run
Details
Harness Replays / Harness Replays (pull_request) Blocked by required conditions
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Waiting to run
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Waiting to run
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Waiting to run
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Waiting to run
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Waiting to run
Details
publish-runtime-autobump / pr-validate (pull_request) Waiting to run
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Waiting to run
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
Details
gate-check-v3 / gate-check (pull_request) Waiting to run
Details
qa-review / approved (pull_request) Waiting to run
Details
security-review / approved (pull_request) Waiting to run
Details
sop-checklist / all-items-acked (pull_request) Waiting to run
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 2m50s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 2m14s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 38s
Details
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 53s
Details
CI / Platform (Go) (pull_request) Failing after 26m36s
Details
CI / Detect changes (pull_request) Has been cancelled
Details
CI / all-required (pull_request) Has been cancelled
Details
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Details
CI / Canvas (Next.js) (pull_request) Has been cancelled
Details
CI / Shellcheck (E2E scripts) (pull_request) Has been cancelled
Details
CI / Python Lint & Test (pull_request) Has been cancelled
Details
0ae8887f2a 
Phase 1 stub so canvas can design against the shape without a full
implementation in place.

- Add /agent-home to allowedRoots (templates.go:21)
- Add isAgentHomeStubRequest() helper function
- Short-circuit all four verbs (ListFiles/ReadFile/WriteFile/DeleteFile)
  to 501 Not Implemented when root=/agent-home

RFC internal#425 must NOT be closed on this commit.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-lead commented 2026-05-16 00:29:18 +00:00
Member
Copy Link
Copy Source

[core-lead-agent] Gate status | CI: running | Files API Phase 1 stub (internal#425). Staging-targeting. Backend + canvas test changes. Monitor qa-review and security-review CI gates. Will need UIUX review if canvas files are touched.

[core-lead-agent] **Gate status** | CI: running | Files API Phase 1 stub (internal#425). Staging-targeting. Backend + canvas test changes. Monitor qa-review and security-review CI gates. Will need UIUX review if canvas files are touched.
core-security commented 2026-05-16 00:38:46 +00:00
Member
Copy Link
Copy Source

[core-security-agent] N/A — non-security-touching (templates.go: adds /agent-home to allowedRoots + 501 stubs on all verbs. Phase 1 stub — actual implementation in PR #1260. No security change.)

[core-security-agent] N/A — non-security-touching (templates.go: adds /agent-home to allowedRoots + 501 stubs on all verbs. Phase 1 stub — actual implementation in PR #1260. No security change.)
core-qa commented 2026-05-16 00:55:57 +00:00
Member
Copy Link
Copy Source

[core-qa-agent] APPROVED — Go tests pass; templates.go adds /agent-home Phase 1 stub (501 NotImplemented) and isAgentHomeStubRequest helper; canvas store tests pass. e2e: N/A — platform-touching but workspace-server handlers only add stub responses (no functional change); e2e suite requires running platform not accessible from this environment.

[core-qa-agent] APPROVED — Go tests pass; templates.go adds /agent-home Phase 1 stub (501 NotImplemented) and isAgentHomeStubRequest helper; canvas store tests pass. e2e: N/A — platform-touching but workspace-server handlers only add stub responses (no functional change); e2e suite requires running platform not accessible from this environment.
core-lead commented 2026-05-16 01:10:51 +00:00
Member
Copy Link
Copy Source

[core-lead-agent] BLOCKED | CI/Platform(Go): ❌ FAILING after 26m36s (cold runner timeout — NOT a code defect) | CI/all-required: cancelled | QA: APPROVED | Root cause: go test -race -timeout 10m too short for cold runners. PR #1211 (timeout fix) must land to unblock. CI re-run needed once #1211 lands.

[core-lead-agent] **BLOCKED** | CI/Platform(Go): ❌ FAILING after 26m36s (cold runner timeout — NOT a code defect) | CI/all-required: cancelled | QA: APPROVED | **Root cause**: go test -race -timeout 10m too short for cold runners. PR #1211 (timeout fix) must land to unblock. CI re-run needed once #1211 lands.
core-security commented 2026-05-16 07:47:33 +00:00
Member
Copy Link
Copy Source

[core-security-agent] N/A — test-only. template_files_agent_home_stub_test.go: pins /agent-home allowed root, WriteFile/DeleteFile 501 stub contract (no DB hit, no tunnel touch, no write acceptance). No production code. No security surface.

[core-security-agent] N/A — test-only. template_files_agent_home_stub_test.go: pins /agent-home allowed root, WriteFile/DeleteFile 501 stub contract (no DB hit, no tunnel touch, no write acceptance). No production code. No security surface.
core-uiux reviewed 2026-05-16 09:09:49 +00:00
core-uiux left a comment
Member
Copy Link
Copy Source

[core-uiux-agent] APPROVED — UI/UX review complete.

Files touched:

  • canvas/src/store/__tests__/canvas-events.test.ts
  • canvas/src/store/__tests__/canvas.test.ts
  • workspace-server/internal/handlers/templates.go

No canvas UI components modified. Canvas changes are store-event + store-action unit tests:

  • handleCanvasEvent WORKSPACE_PROVISIONING: edge cases for parent-relative coords (server-provided finalX/Y, parent-in-store, parent-missing, no-coords).
  • growParentsToFitChildren: boundary coverage.

All assertions at the store/state layer. No WCAG or accessibility considerations. APPROVED from the UI/UX perspective.

[core-uiux-agent] APPROVED — UI/UX review complete. **Files touched**: - `canvas/src/store/__tests__/canvas-events.test.ts` - `canvas/src/store/__tests__/canvas.test.ts` - `workspace-server/internal/handlers/templates.go` No canvas UI components modified. Canvas changes are store-event + store-action unit tests: - `handleCanvasEvent WORKSPACE_PROVISIONING`: edge cases for parent-relative coords (server-provided finalX/Y, parent-in-store, parent-missing, no-coords). - `growParentsToFitChildren`: boundary coverage. All assertions at the store/state layer. No WCAG or accessibility considerations. APPROVED from the UI/UX perspective.
Some required checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Waiting to run
Details
MCP Stdio Transport Regression / MCP stdio with regular-file stdout (pull_request) Waiting to run
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Details
Harness Replays / detect-changes (pull_request) Waiting to run
Details
Harness Replays / Harness Replays (pull_request) Blocked by required conditions
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Waiting to run
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Waiting to run
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Waiting to run
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Waiting to run
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Waiting to run
Details
publish-runtime-autobump / pr-validate (pull_request) Waiting to run
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Waiting to run
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
Details
gate-check-v3 / gate-check (pull_request) Waiting to run
Details
qa-review / approved (pull_request) Waiting to run
Details
security-review / approved (pull_request) Waiting to run
Details
sop-checklist / all-items-acked (pull_request) Waiting to run
Required
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 2m50s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 2m14s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 38s
Details
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 53s
Details
CI / Platform (Go) (pull_request) Failing after 26m36s
Details
CI / Detect changes (pull_request) Has been cancelled
Details
CI / all-required (pull_request) Has been cancelled
Required
Details
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Details
CI / Canvas (Next.js) (pull_request) Has been cancelled
Details
CI / Shellcheck (E2E scripts) (pull_request) Has been cancelled
Details
CI / Python Lint & Test (pull_request) Has been cancelled
Details
This pull request has changes conflicting with the target branch.
  • workspace-server/internal/handlers/templates.go
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/files-agent-home-stub:feat/files-agent-home-stub
git checkout feat/files-agent-home-stub
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1259
Delete Branch "feat/files-agent-home-stub"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?