Compare commits

..

14 Commits

Author SHA1 Message Date
release-manager 4fb0a8af74 Merge main into staging (sync v3 — release manager)
cascade-list-drift-gate / check (pull_request) Successful in 16s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 33s
CI / Detect changes (pull_request) Successful in 54s
E2E API Smoke Test / detect-changes (pull_request) Successful in 52s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 52s
Harness Replays / detect-changes (pull_request) Failing after 43s
Harness Replays / Harness Replays (pull_request) Has been skipped
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 15s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m35s
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m30s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Failing after 2m15s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 2m20s
review-check-tests / review-check.sh regression tests (pull_request) Successful in 20s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 2m31s
publish-runtime-autobump / pr-validate (pull_request) Successful in 59s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m38s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 38s
sop-checklist-gate / gate (pull_request) Successful in 17s
sop-tier-check / tier-check (pull_request) Successful in 29s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 55s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m43s
Runtime Pin Compatibility / PyPI-latest install + import smoke (pull_request) Successful in 2m28s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 30s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 1m43s
CI / Python Lint & Test (pull_request) Failing after 2m12s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
CI / Platform (Go) (pull_request) Failing after 4m1s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 4m23s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2m46s
CI / Canvas (Next.js) (pull_request) Failing after 17m19s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Failing after 7s
Brings 609 main commits into staging. Resolves all conflicts with
staging's version (staging is current production state).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 17:08:32 +00:00
devops-engineer e1bf973d91 Merge pull request 'test(models+handlers): add delivery mode + workspace status coverage' (#868) from fix/issue-860-delivery-mode-tests into staging 2026-05-13 17:05:41 +00:00
devops-engineer 22839034ef Merge pull request 'fix(ci): close burn-in — remove continue-on-error mask from sop-tier-check' (#825) from ci/burn-in-remove-sop-tier-check-coe into main
Block internal-flavored paths / Block forbidden paths (push) Successful in 5s
Harness Replays / detect-changes (push) Successful in 6s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (push) Successful in 8s
cascade-list-drift-gate / check (pull_request) Successful in 10s
E2E API Smoke Test / detect-changes (push) Successful in 21s
E2E Staging Canvas (Playwright) / detect-changes (push) Successful in 22s
CI / Detect changes (push) Successful in 22s
Handlers Postgres Integration / detect-changes (push) Successful in 24s
Secret scan / Scan diff for credential-shaped strings (push) Successful in 13s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 28s
Check migration collisions / Migration version collision check (pull_request) Successful in 25s
Runtime PR-Built Compatibility / detect-changes (push) Successful in 24s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 9s
CI / Detect changes (pull_request) Successful in 25s
E2E API Smoke Test / detect-changes (pull_request) Successful in 24s
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Handlers Postgres Integration / detect-changes (pull_request) Successful in 20s
review-check-tests / review-check.sh regression tests (pull_request) Successful in 11s
Harness Replays / detect-changes (pull_request) Failing after 40s
Harness Replays / Harness Replays (pull_request) Has been skipped
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 16s
publish-runtime-autobump / pr-validate (pull_request) Successful in 37s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
sop-checklist-gate / gate (pull_request) Successful in 8s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (push) Successful in 1m28s
sop-tier-check / tier-check (pull_request) Successful in 10s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (push) Successful in 1m30s
Harness Replays / Harness Replays (push) Successful in 3s
E2E API Smoke Test / E2E API Smoke Test (push) Successful in 6s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 36s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m8s
CI / Platform (Go) (push) Successful in 7s
CI / Shellcheck (E2E scripts) (push) Successful in 4s
CI / Python Lint & Test (push) Successful in 4s
Handlers Postgres Integration / Handlers Postgres Integration (push) Successful in 4s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (push) Successful in 4s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m36s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m38s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 1m43s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Failing after 1m37s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m37s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m12s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 20s
Runtime Pin Compatibility / PyPI-latest install + import smoke (pull_request) Successful in 1m54s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m2s
publish-canvas-image / Build & push canvas image (push) Successful in 4m32s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2m39s
CI / Platform (Go) (pull_request) Failing after 4m19s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 4m12s
publish-workspace-server-image / build-and-push (push) Successful in 7m23s
main-red-watchdog / watchdog (push) Successful in 34s
CI / Python Lint & Test (pull_request) Successful in 7m51s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (push) Successful in 8m27s
CI / Canvas (Next.js) (push) Successful in 15m52s
CI / Canvas (Next.js) (pull_request) Successful in 15m53s
Sweep stale Cloudflare DNS records / Sweep CF orphans (push) Successful in 37s
ci-required-drift / drift (push) Successful in 1m39s
CI / Canvas Deploy Reminder (push) Successful in 3s
CI / all-required (push) Successful in 4s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 5s
Continuous synthetic E2E (staging) / Synthetic E2E against staging (push) Has started running
Sweep stale Cloudflare Tunnels / Sweep CF tunnels (push) Successful in 20s
Sweep stale e2e-* orgs (staging) / Sweep e2e orgs (push) Successful in 10s
Staging SaaS smoke (every 30 min) / Staging SaaS smoke (push) Successful in 4m58s
gate-check-v3 / gate-check (push) Compensated by status-reaper (workflow has no push: trigger; Gitea 1.22.6 hardcoded-suffix bug — see .gitea/scripts/status-reaper.py)
2026-05-13 17:02:51 +00:00
devops-engineer 62b150308c Merge pull request 'test(canvas): add ExternalConnectModal pure-helper coverage — 31 cases' (#847) from feat/canvas-external-connect-modal-coverage into staging
Secret scan / Scan diff for credential-shaped strings (push) Successful in 17s
CI / Detect changes (push) Successful in 58s
CI / Platform (Go) (push) Successful in 7s
CI / Shellcheck (E2E scripts) (push) Successful in 7s
CI / Python Lint & Test (push) Successful in 8s
CI / Canvas (Next.js) (push) Successful in 8m18s
CI / Canvas Deploy Reminder (push) Has been skipped
CI / all-required (push) Successful in 1s
2026-05-13 16:39:05 +00:00
core-be 946e12afaf test(canvas): freeze time in formatTTL tests — eliminate CI timing flake
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 15s
Harness Replays / detect-changes (pull_request) Successful in 16s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 12s
E2E API Smoke Test / detect-changes (pull_request) Successful in 45s
CI / Detect changes (pull_request) Successful in 48s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 51s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 46s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 32s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
gate-check-v3 / gate-check (pull_request) Successful in 13s
qa-review / approved (pull_request) Failing after 10s
security-review / approved (pull_request) Failing after 11s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Harness Replays / Harness Replays (pull_request) Successful in 5s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m33s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m12s
sop-checklist-gate / gate (pull_request) Successful in 14s
sop-tier-check / tier-check (pull_request) Successful in 15s
CI / Platform (Go) (pull_request) Successful in 5s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 6s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s
CI / Python Lint & Test (pull_request) Successful in 4s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m27s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m53s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m59s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 9s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 11m12s
CI / Canvas (Next.js) (pull_request) Successful in 12m15s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 3s
audit-force-merge / audit (pull_request) Successful in 2s
Same fix as applied to fix/stdio-fallback-all-environments (#778).
vi.useFakeTimers()/vi.useRealTimers() pin Date.now() so the flake
(expected '5m', got '4m' on slow runners) cannot occur.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-13 09:33:10 -07:00
core-be ac675237fb Merge branch 'main' into ci/burn-in-remove-sop-tier-check-coe 2026-05-13 09:32:48 -07:00
devops-engineer c451b96db8 Merge pull request 'fix(runtime): accept kimi/kimi-cli as BYO-compute external runtime' (#771) from fix/kimi-external-runtime into main
Block internal-flavored paths / Block forbidden paths (push) Successful in 18s
cascade-list-drift-gate / check (pull_request) Successful in 19s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 32s
CI / Detect changes (push) Successful in 40s
E2E API Smoke Test / detect-changes (push) Successful in 46s
Check migration collisions / Migration version collision check (pull_request) Successful in 52s
CI / Detect changes (pull_request) Successful in 50s
Harness Replays / detect-changes (push) Successful in 16s
E2E API Smoke Test / detect-changes (pull_request) Successful in 47s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 42s
E2E Staging Canvas (Playwright) / detect-changes (push) Successful in 53s
Handlers Postgres Integration / detect-changes (push) Successful in 41s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 15s
Harness Replays / detect-changes (pull_request) Failing after 48s
Harness Replays / Harness Replays (pull_request) Has been skipped
Secret scan / Scan diff for credential-shaped strings (push) Successful in 15s
Runtime PR-Built Compatibility / detect-changes (push) Successful in 33s
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
review-check-tests / review-check.sh regression tests (pull_request) Successful in 18s
publish-runtime-autobump / pr-validate (pull_request) Successful in 45s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m14s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 31s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m30s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Failing after 1m39s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m52s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 2m9s
sop-checklist-gate / gate (pull_request) Successful in 33s
sop-tier-check / tier-check (pull_request) Successful in 28s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 2m5s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 1m0s
CI / Shellcheck (E2E scripts) (push) Successful in 8s
CI / Python Lint & Test (push) Successful in 9s
Harness Replays / Harness Replays (push) Successful in 8s
Runtime Pin Compatibility / PyPI-latest install + import smoke (pull_request) Successful in 1m53s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 27s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m34s
ci-required-drift / drift (push) Successful in 1m32s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (push) Successful in 15s
E2E Staging External Runtime / E2E Staging External Runtime (push) Successful in 5m37s
E2E API Smoke Test / E2E API Smoke Test (push) Successful in 3m7s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3m11s
publish-canvas-image / Build & push canvas image (push) Successful in 6m25s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 3m10s
CI / Platform (Go) (push) Failing after 6m22s
CI / Platform (Go) (pull_request) Failing after 6m18s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 6m11s
Handlers Postgres Integration / Handlers Postgres Integration (push) Failing after 6m8s
publish-workspace-server-image / build-and-push (push) Successful in 10m0s
CI / Python Lint & Test (pull_request) Successful in 8m3s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (push) Successful in 9m34s
CI / Canvas (Next.js) (push) Successful in 15m34s
CI / Canvas (Next.js) (pull_request) Successful in 15m18s
CI / Canvas Deploy Reminder (push) Successful in 5s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (push) Successful in 6s
CI / all-required (pull_request) Successful in 5s
Sweep stale Cloudflare Tunnels / Sweep CF tunnels (push) Successful in 18s
Sweep stale e2e-* orgs (staging) / Sweep e2e orgs (push) Successful in 8s
gitea-merge-queue / queue (push) Successful in 12s
status-reaper / reap (push) Successful in 1m22s
Staging SaaS smoke (every 30 min) / Staging SaaS smoke (push) Successful in 4m49s
Continuous synthetic E2E (staging) / Synthetic E2E against staging (push) Successful in 6m26s
2026-05-13 16:15:54 +00:00
fullstack-engineer e86f3bbda6 test(models+handlers): add delivery mode + workspace status coverage
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s
sop-tier-check / tier-check (pull_request) Successful in 8s
sop-checklist-gate / gate (pull_request) Successful in 8s
CI / Detect changes (pull_request) Successful in 13s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
CI / Canvas (Next.js) (pull_request) Successful in 5s
CI / Python Lint & Test (pull_request) Successful in 6s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / Platform (Go) (pull_request) Failing after 3m2s
CI / all-required (pull_request) Successful in 9s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
audit-force-merge / audit (pull_request) Successful in 4s
Add two test files covering the delivery-mode and workspace-status
enforcement contracts:

- models/workspace_delivery_mode_test.go:
  - IsValidDeliveryMode: true for "push"/"poll", false for all
    other inputs (empty, typos, case variants, trailing space)
  - WorkspaceStatus.String(): returns the underlying string for all 10
    status constants
  - AllWorkspaceStatuses: correct length (10) and membership of all
    named constants, no empty strings

- handlers/workspace_dispatchers_test.go:
  - resolveDeliveryMode: payloadMode wins without DB query, existing
    DB mode returned when present, external runtime defaults to poll,
    self-hosted defaults to push, not-found defaults to push,
    DB errors propagate, empty-string existing mode falls through
    to runtime check

Refs #860
2026-05-13 16:14:09 +00:00
core-be 7f2b218cd3 feat(kimi): Kimi as first-class BYO-compute runtime + delegation retry fix
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 8s
Harness Replays / detect-changes (pull_request) Successful in 14s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
qa-review / approved (pull_request) Failing after 14s
CI / Detect changes (pull_request) Successful in 33s
security-review / approved (pull_request) Failing after 14s
sop-checklist / all-items-acked (pull_request) acked: 7/7
E2E API Smoke Test / detect-changes (pull_request) Successful in 39s
gate-check-v3 / gate-check (pull_request) Successful in 24s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 39s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 39s
sop-checklist-gate / gate (pull_request) Successful in 16s
Harness Replays / Harness Replays (pull_request) Successful in 8s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 40s
sop-tier-check / tier-check (pull_request) Successful in 16s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
CI / Python Lint & Test (pull_request) Successful in 5s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 5s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m11s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m49s
CI / Platform (Go) (pull_request) Failing after 4m13s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 4m10s
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m21s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7m57s
CI / Canvas (Next.js) (pull_request) Successful in 11m53s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 2s
audit-force-merge / audit (pull_request) Successful in 18s
- Add isExternalLikeRuntime() helper for kimi/kimi-cli/external
- Extend runtime_registry, workspace handler, canvas UX for Kimi
- Fix delegation retry: skip retry when response body already received
- Restore a2a_client cache-first path (peer_name KeyError, already on main)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-13 09:01:30 -07:00
devops-engineer 36561cb0f1 Merge pull request 'feat(canvas): mount SearchDialog in desktop + mobile canvas shells' (#837) from design/826-searchdialog-mount-v2 into main
Block internal-flavored paths / Block forbidden paths (push) Successful in 5s
Harness Replays / detect-changes (push) Successful in 12s
cascade-list-drift-gate / check (pull_request) Successful in 12s
Secret scan / Scan diff for credential-shaped strings (push) Successful in 12s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 26s
CI / Detect changes (push) Successful in 30s
E2E API Smoke Test / detect-changes (push) Successful in 31s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 11s
E2E Staging Canvas (Playwright) / detect-changes (push) Successful in 36s
Handlers Postgres Integration / detect-changes (push) Successful in 37s
Check migration collisions / Migration version collision check (pull_request) Successful in 36s
CI / Detect changes (pull_request) Successful in 36s
Runtime PR-Built Compatibility / detect-changes (push) Successful in 35s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 32s
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
E2E API Smoke Test / detect-changes (pull_request) Successful in 34s
review-check-tests / review-check.sh regression tests (pull_request) Successful in 14s
Harness Replays / detect-changes (pull_request) Failing after 43s
Harness Replays / Harness Replays (pull_request) Has been skipped
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 37s
publish-runtime-autobump / pr-validate (pull_request) Successful in 45s
sop-checklist-gate / gate (pull_request) Successful in 24s
sop-tier-check / tier-check (pull_request) Successful in 21s
Harness Replays / Harness Replays (push) Successful in 5s
CI / Platform (Go) (push) Successful in 7s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 54s
CI / Shellcheck (E2E scripts) (push) Successful in 4s
CI / Python Lint & Test (push) Successful in 7s
E2E API Smoke Test / E2E API Smoke Test (push) Successful in 9s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m12s
Handlers Postgres Integration / Handlers Postgres Integration (push) Successful in 6s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m31s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m32s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 29s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 2m11s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 1m58s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m55s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Failing after 1m53s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (push) Successful in 9s
Runtime Pin Compatibility / PyPI-latest install + import smoke (pull_request) Successful in 2m10s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m6s
publish-canvas-image / Build & push canvas image (push) Successful in 5m30s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2m44s
CI / Platform (Go) (pull_request) Failing after 4m37s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 4m23s
publish-workspace-server-image / build-and-push (push) Successful in 8m14s
CI / Python Lint & Test (pull_request) Successful in 7m29s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (push) Successful in 9m56s
CI / Canvas (Next.js) (pull_request) Failing after 13m24s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / Canvas (Next.js) (push) Successful in 13m55s
CI / all-required (pull_request) Failing after 5s
CI / Canvas Deploy Reminder (push) Successful in 6s
CI / all-required (push) Successful in 4s
ci-required-drift / drift (push) Successful in 1m24s
Sweep stale Cloudflare Tunnels / Sweep CF tunnels (push) Successful in 14s
Staging SaaS smoke (every 30 min) / Staging SaaS smoke (push) Successful in 6m30s
main-red-watchdog / watchdog (push) Successful in 1m8s
gate-check-v3 / gate-check (push) Successful in 3m28s
Sweep stale e2e-* orgs (staging) / Sweep e2e orgs (push) Successful in 6s
gitea-merge-queue / queue (push) Successful in 16s
Sweep stale Cloudflare DNS records / Sweep CF orphans (push) Successful in 20s
Continuous synthetic E2E (staging) / Synthetic E2E against staging (push) Successful in 4m43s
status-reaper / reap (push) Successful in 2m35s
2026-05-13 14:13:41 +00:00
core-uiux ac3136bb55 fix(canvas): remove duplicate SearchDialog mount from desktop page.tsx
sop-checklist-gate-verify Token verification test
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 14s
E2E API Smoke Test / detect-changes (pull_request) Successful in 26s
CI / Detect changes (pull_request) Successful in 29s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 20s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 24s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 15s
Harness Replays / detect-changes (pull_request) Successful in 17s
qa-review / approved (pull_request) Failing after 11s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 25s
security-review / approved (pull_request) Failing after 13s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m13s
CI / Platform (Go) (pull_request) Successful in 11s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s
CI / Python Lint & Test (pull_request) Successful in 6s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 7s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 9s
Harness Replays / Harness Replays (pull_request) Successful in 6s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 5s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m16s
sop-tier-check / tier-check (pull_request) Successful in 27s
sop-checklist-gate / gate (pull_request) Failing after 31s
gate-check-v3 / gate-check (pull_request) Successful in 59s
CI / Canvas (Next.js) (pull_request) Successful in 16m49s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 7s
sop-checklist / all-items-acked (pull_request) acked: 7/7
audit-force-merge / audit (pull_request) Successful in 6s
SearchDialog is already rendered inside Canvas.tsx (line 374).
Adding it to page.tsx created a redundant second instance on desktop.
Mobile shell (MobileApp.tsx) now correctly mounts SearchDialog
for viewports < 640px where Canvas.tsx is never rendered.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 12:52:22 +00:00
core-uiux fdec70e714 feat(canvas): mount SearchDialog in desktop + mobile canvas shells
Adds Cmd+K workspace search to both canvas entry points:
- page.tsx: mounts SearchDialog in the desktop shell
- MobileApp.tsx: mounts SearchDialog in the mobile shell

Phase 20.3: closes the "Workspace search (Cmd+K)" requirement.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 12:52:22 +00:00
fullstack-engineer e912df5438 test(canvas): add ExternalConnectModal pure-helper coverage — 31 cases
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 20s
sop-checklist-gate / gate (pull_request) Successful in 21s
sop-tier-check / tier-check (pull_request) Successful in 18s
CI / Detect changes (pull_request) Successful in 45s
CI / Platform (Go) (pull_request) Successful in 6s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
CI / Python Lint & Test (pull_request) Successful in 5s
CI / Canvas (Next.js) (pull_request) Successful in 12m4s
CI / all-required (pull_request) Successful in 9s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
CI / Canvas Deploy Reminder (pull_request) Failing after 12m27s
audit-force-merge / audit (pull_request) Successful in 20s
Extract and unit-test the 8 pure fill helpers and 2 derived functions
from ExternalConnectModal so they are independently verifiable.

Exported: fillPythonSnippet, fillCurlSnippet, fillChannelSnippet,
fillUniversalMcpSnippet, fillHermesSnippet, fillCodexSnippet,
fillOpenClawSnippet, buildFilledSnippets, buildTabOrder.

Issue: #709 follow-up (pure-helper extraction)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 12:43:04 +00:00
core-devops 9a7e461495 fix(ci): close burn-in — remove continue-on-error mask from sop-tier-check tier-check job
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 16s
CI / Detect changes (pull_request) Successful in 1m13s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m15s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m19s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 19s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m22s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
gate-check-v3 / gate-check (pull_request) Successful in 37s
qa-review / approved (pull_request) Failing after 19s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 54s
security-review / approved (pull_request) Failing after 22s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 2m26s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m28s
sop-checklist-gate / gate (pull_request) Successful in 25s
sop-tier-check / tier-check (pull_request) Successful in 23s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m36s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 2m24s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 2m27s
CI / Platform (Go) (pull_request) Successful in 8s
CI / Canvas (Next.js) (pull_request) Successful in 8s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
CI / Python Lint & Test (pull_request) Successful in 5s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 6s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 5s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 5s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 3s
Burn-in window (internal#189 Phase 1) deployed 2026-05-10. The 7-day
window closes 2026-05-17. Remove continue-on-error: true from the
tier-check job so AND-composition is fully enforced.

Changes:
- Remove job-level `continue-on-error: true` and its mc#774 burn-in
  comment (sop-tier-check was one of the 42 bare CoE directives
  annotated in mc#774).
- Step-level `continue-on-error: true` on Install jq and Verify tier
  label remain (documented mc#774 masks, separate from burn-in).
- Update BURN-IN NOTE → BURN-IN CLOSED with reference to mc#774
  protocol for any future mask re-introductions.
- Update SOP_LEGACY_CHECK comment to note burn-in closed.

Refs: internal#189, mc#774, #804

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 09:38:58 +00:00
17 changed files with 747 additions and 288 deletions
@@ -80,6 +80,7 @@ export function CreateWorkspaceButton() {
// isExternal is true the template / model / hermes-provider fields are
// hidden (they're meaningless for BYO-compute agents).
const [isExternal, setIsExternal] = useState(false);
const [externalRuntime, setExternalRuntime] = useState("external");
const [externalConnection, setExternalConnection] =
useState<ExternalConnectionInfo | null>(null);
@@ -223,6 +224,7 @@ export function CreateWorkspaceButton() {
setBudgetLimit("");
setError(null);
setHermesProvider("anthropic");
setExternalRuntime("external");
setHermesApiKey("");
setHermesModel("");
api
@@ -282,7 +284,7 @@ export function CreateWorkspaceButton() {
// Runtime=external flips the backend into awaiting-agent mode:
// no container provisioning, token minted, connection payload
// returned in the response for the modal below.
...(isExternal ? { runtime: "external" } : {}),
...(isExternal ? { runtime: externalRuntime } : {}),
...(!isExternal && isHermes && provider
? {
secrets: { [provider.envVar]: hermesApiKey.trim() },
@@ -382,6 +384,23 @@ export function CreateWorkspaceButton() {
</div>
</label>
{isExternal && (
<div>
<label className="text-[11px] text-ink-mid block mb-1">
External Runtime
</label>
<select
value={externalRuntime}
onChange={(e) => setExternalRuntime(e.target.value)}
className="w-full bg-surface-card/60 border border-line/50 rounded-lg px-3 py-2 text-sm text-ink focus:outline-none focus:border-accent/60 focus:ring-1 focus:ring-accent/20 transition-colors"
>
<option value="external">Generic External</option>
<option value="kimi">Kimi CLI</option>
<option value="kimi-cli">Kimi CLI (alt)</option>
</select>
</div>
)}
{!isExternal && (
<InputField
label="Template"
+105 -69
View File
@@ -18,6 +18,109 @@
import { useCallback, useState } from "react";
import * as Dialog from "@radix-ui/react-dialog";
// ─── Pure fill helpers ────────────────────────────────────────────────────────
// Each snippet is server-stamped with workspace_id + platform_url but leaves
// AUTH_TOKEN as a placeholder. These helpers stamp the real token in so the
// operator's copy-paste is truly ready-to-run. All are pure string ops.
export function fillPythonSnippet(
snippet: string,
authToken: string,
): string {
return snippet.replace(
'AUTH_TOKEN = "<paste from create response>"',
`AUTH_TOKEN = "${authToken}"`,
);
}
export function fillCurlSnippet(
snippet: string,
authToken: string,
): string {
return snippet.replace(
'WORKSPACE_AUTH_TOKEN="<paste from create response>"',
`WORKSPACE_AUTH_TOKEN="${authToken}"`,
);
}
export function fillChannelSnippet(
snippet: string | undefined,
authToken: string,
): string | undefined {
return snippet?.replace(
'MOLECULE_WORKSPACE_TOKENS=<paste auth_token from create response>',
`MOLECULE_WORKSPACE_TOKENS=${authToken}`,
);
}
export function fillUniversalMcpSnippet(
snippet: string | undefined,
authToken: string,
): string | undefined {
return snippet?.replace(
'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
`MOLECULE_WORKSPACE_TOKEN="${authToken}"`,
);
}
export function fillHermesSnippet(
snippet: string | undefined,
authToken: string,
): string | undefined {
return snippet?.replace(
'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
`MOLECULE_WORKSPACE_TOKEN="${authToken}"`,
);
}
export function fillCodexSnippet(
snippet: string | undefined,
authToken: string,
): string | undefined {
return snippet?.replace(
'MOLECULE_WORKSPACE_TOKEN = "<paste from create response>"',
`MOLECULE_WORKSPACE_TOKEN = "${authToken}"`,
);
}
export function fillOpenClawSnippet(
snippet: string | undefined,
authToken: string,
): string | undefined {
return snippet?.replace(
'WORKSPACE_TOKEN="<paste from create response>"',
`WORKSPACE_TOKEN="${authToken}"`,
);
}
/** Build the ordered tab list shown in the modal. Each tab only appears when
* the platform supplies the corresponding snippet. */
export function buildTabOrder(info: ExternalConnectionInfo): Tab[] {
const tabs: Tab[] = [];
const { filledUniversalMcp, filledChannel, filledHermes, filledCodex, filledOpenClaw } = buildFilledSnippets(info);
if (filledUniversalMcp) tabs.push("mcp");
tabs.push("python");
if (filledChannel) tabs.push("claude");
if (filledHermes) tabs.push("hermes");
if (filledCodex) tabs.push("codex");
if (filledOpenClaw) tabs.push("openclaw");
tabs.push("curl", "fields");
return tabs;
}
/** Pre-fill all snippets from an info object. Exposed for testing. */
export function buildFilledSnippets(info: ExternalConnectionInfo) {
return {
filledPython: fillPythonSnippet(info.python_snippet, info.auth_token),
filledCurl: fillCurlSnippet(info.curl_register_template, info.auth_token),
filledChannel: fillChannelSnippet(info.claude_code_channel_snippet, info.auth_token),
filledUniversalMcp: fillUniversalMcpSnippet(info.universal_mcp_snippet, info.auth_token),
filledHermes: fillHermesSnippet(info.hermes_channel_snippet, info.auth_token),
filledCodex: fillCodexSnippet(info.codex_snippet, info.auth_token),
filledOpenClaw: fillOpenClawSnippet(info.openclaw_snippet, info.auth_token),
};
}
type Tab = "python" | "curl" | "claude" | "mcp" | "hermes" | "codex" | "openclaw" | "fields";
export interface ExternalConnectionInfo {
@@ -102,54 +205,7 @@ export function ExternalConnectModal({ info, onClose }: Props) {
if (!info) return null;
// Python snippet is stamped server-side with workspace_id +
// platform_url but leaves AUTH_TOKEN as a "<paste …>" placeholder
// (that's what we're showing in the modal). Fill in the real
// token here so the snippet the operator copies is truly ready-to-run.
const filledPython = info.python_snippet.replace(
'AUTH_TOKEN = "<paste from create response>"',
`AUTH_TOKEN = "${info.auth_token}"`,
);
const filledCurl = info.curl_register_template.replace(
'WORKSPACE_AUTH_TOKEN="<paste from create response>"',
`WORKSPACE_AUTH_TOKEN="${info.auth_token}"`,
);
// The channel snippet asks the operator to paste the auth_token into
// the .env file's MOLECULE_WORKSPACE_TOKENS field. Stamp it server-side
// here so the copy-paste-block is truly ready-to-run.
const filledChannel = info.claude_code_channel_snippet?.replace(
'MOLECULE_WORKSPACE_TOKENS=<paste auth_token from create response>',
`MOLECULE_WORKSPACE_TOKENS=${info.auth_token}`,
);
// Universal MCP snippet uses MOLECULE_WORKSPACE_TOKEN as the env-var
// name passed through to molecule-mcp via `claude mcp add ... -- env
// MOLECULE_WORKSPACE_TOKEN=...`. The placeholder must match the
// template's literal — pre-2026-04-30 polish this looked for
// WORKSPACE_AUTH_TOKEN (carryover from the curl tab), which silently
// skipped the substitution and left "<paste from create response>"
// visible in the operator's clipboard.
const filledUniversalMcp = info.universal_mcp_snippet?.replace(
'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
`MOLECULE_WORKSPACE_TOKEN="${info.auth_token}"`,
);
// Hermes channel snippet uses MOLECULE_WORKSPACE_TOKEN (same env-var
// name as Universal MCP). Stamp the auth_token in so the operator's
// copy-paste is fully ready-to-run.
const filledHermes = info.hermes_channel_snippet?.replace(
'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
`MOLECULE_WORKSPACE_TOKEN="${info.auth_token}"`,
);
// Codex + OpenClaw snippets carry the placeholder inside the
// generated config block (TOML / JSON respectively). Stamp the
// token in so the copy-paste is one less manual edit.
const filledCodex = info.codex_snippet?.replace(
'MOLECULE_WORKSPACE_TOKEN = "<paste from create response>"',
`MOLECULE_WORKSPACE_TOKEN = "${info.auth_token}"`,
);
const filledOpenClaw = info.openclaw_snippet?.replace(
'WORKSPACE_TOKEN="<paste from create response>"',
`WORKSPACE_TOKEN="${info.auth_token}"`,
);
const { filledPython, filledCurl, filledChannel, filledUniversalMcp, filledHermes, filledCodex, filledOpenClaw } = buildFilledSnippets(info);
return (
<Dialog.Root open onOpenChange={(o) => !o && onClose()}>
@@ -171,27 +227,7 @@ export function ExternalConnectModal({ info, onClose }: Props) {
aria-label="Connection snippet format"
className="mt-4 flex gap-1 border-b border-line"
>
{(() => {
// Build the tab order dynamically. Claude Code first
// (when offered) since it's the simplest setup; Python
// SDK second (full register+heartbeat+inbound); Universal
// MCP third (any MCP-aware runtime, outbound-only); curl
// for one-shot register; Fields for raw values.
// Tab order: Universal MCP first (default, runtime-
// agnostic primitives), then runtime-specific channel/
// SDK tabs, then curl + Fields. Each runtime tab only
// appears when the platform supplies the snippet — no
// dead "tab missing snippet" UX.
const tabs: Tab[] = [];
if (filledUniversalMcp) tabs.push("mcp");
tabs.push("python");
if (filledChannel) tabs.push("claude");
if (filledHermes) tabs.push("hermes");
if (filledCodex) tabs.push("codex");
if (filledOpenClaw) tabs.push("openclaw");
tabs.push("curl", "fields");
return tabs;
})().map((t) => (
{buildTabOrder(info).map((t) => (
<button
key={t}
type="button"
+2 -1
View File
@@ -9,6 +9,7 @@ import { Tooltip } from "@/components/Tooltip";
import { STATUS_CONFIG, TIER_CONFIG } from "@/lib/design-tokens";
import { useOrgDeployState } from "@/components/canvas/useOrgDeployState";
import { OrgCancelButton } from "@/components/canvas/OrgCancelButton";
import { isExternalLikeRuntime } from "@/lib/externalRuntimes";
/** Descendant count for the "N sub" badge — children are first-class nodes
* rendered as full cards inside this one via React Flow's native parentId,
@@ -248,7 +249,7 @@ export function WorkspaceNode({ id, data }: NodeProps<Node<WorkspaceNodeData>>)
if (!runtime) return null;
return (
<div className="mb-1 flex items-center gap-1">
{runtime === "external" ? (
{isExternalLikeRuntime(runtime) ? (
<span
className="text-[7px] font-mono px-1.5 py-0.5 rounded-md text-white bg-violet-600 border border-violet-700"
title="Phase 30 remote agent — runs outside this platform's Docker network. Lifecycle managed via heartbeat-based polling, not Docker exec."
@@ -1,237 +1,275 @@
// @vitest-environment jsdom
/**
* Tests for ExternalConnectModal — the modal surfaced after creating a
* runtime="external" workspace. Surfaces workspace_auth_token + ready-to-paste
* snippets so the operator can configure their off-host agent.
*
* Coverage:
* - Renders nothing when info=null
* - Opens dialog when info is provided
* - Default tab: "Universal MCP" when universal_mcp_snippet present, else "Python SDK"
* - Tab switching between all available tabs
* - Snippets show with auth_token replacing placeholders
* - Copy button: calls clipboard API, shows "Copied!", clears after 1.5s
* - Copy failure: shows fallback textarea
* - "I've saved it — close" calls onClose
* - Security warning: one-time token display
* - Fields tab shows raw values
* - Tabs hidden when their snippet is absent
*
* Fake timers: applied per-describe to avoid mixing with waitFor. Tests that
* use waitFor (which needs real timers) run without fake timers. Tests that
* verify setTimeout behavior use vi.useFakeTimers() + act(vi.advanceTimersByTime).
*/
import React from "react";
import { render, screen, fireEvent, cleanup, act, waitFor } from "@testing-library/react";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
'use client';
import { describe, it, expect } from 'vitest';
import {
ExternalConnectModal,
type ExternalConnectionInfo,
} from "../ExternalConnectModal";
fillPythonSnippet,
fillCurlSnippet,
fillChannelSnippet,
fillUniversalMcpSnippet,
fillHermesSnippet,
fillCodexSnippet,
fillOpenClawSnippet,
buildFilledSnippets,
buildTabOrder,
ExternalConnectionInfo,
} from '../ExternalConnectModal';
const defaultInfo: ExternalConnectionInfo = {
workspace_id: "ws-123",
platform_url: "https://app.example.com",
auth_token: "secret-auth-token-abc",
registry_endpoint: "https://app.example.com/api/a2a/register",
heartbeat_endpoint: "https://app.example.com/api/a2a/heartbeat",
// Placeholders must EXACTLY match what the component searches for in
// the string.replace() calls (the component does NOT normalise whitespace).
// Python: 'AUTH_TOKEN = "...' (4 spaces), curl: WORKSPACE_AUTH_TOKEN="<paste>" (with quotes),
// MCP/Hermes: MOLECULE_WORKSPACE_TOKEN="...", Codex: same with 1 space.
curl_register_template:
`curl -X POST https://app.example.com/api/a2a/register \\
-H "Content-Type: application/json" \\
-d '{"auth_token": "WORKSPACE_AUTH_TOKEN=\"<paste from create response>\"", ...}'`,
python_snippet:
'AUTH_TOKEN = "<paste from create response>"\nAPI_URL = "https://app.example.com"',
universal_mcp_snippet:
'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
hermes_channel_snippet:
'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
codex_snippet: 'MOLECULE_WORKSPACE_TOKEN = "<paste from create response>"',
openclaw_snippet: 'WORKSPACE_TOKEN="<paste from create response>"',
};
// ─── fillPythonSnippet ───────────────────────────────────────────────────────
// ─── Clipboard mock helpers ────────────────────────────────────────────────────
describe('fillPythonSnippet', () => {
it('stamps auth_token into the AUTH_TOKEN placeholder', () => {
const input =
'AUTH_TOKEN = "<paste from create response>"\n' +
'PLATFORM_URL = "http://localhost:8080"';
const got = fillPythonSnippet(input, 'tok-abc123');
expect(got).toContain('AUTH_TOKEN = "tok-abc123"');
// Original placeholder is gone
expect(got).not.toContain('<paste from create response>');
});
let clipboardWriteText = vi.fn();
it('leaves other lines untouched', () => {
const input = 'PLATFORM_URL = "http://localhost:8080"\nAUTH_TOKEN = "<paste from create response>"';
const got = fillPythonSnippet(input, 'tok-xyz');
expect(got).toContain('PLATFORM_URL = "http://localhost:8080"');
});
beforeEach(() => {
clipboardWriteText.mockReset().mockResolvedValue(undefined);
Object.defineProperty(navigator, "clipboard", {
value: { writeText: clipboardWriteText },
configurable: true,
writable: true,
it('handles empty token', () => {
const input = 'AUTH_TOKEN = "<paste from create response>"';
const got = fillPythonSnippet(input, '');
expect(got).toContain('AUTH_TOKEN = ""');
});
});
afterEach(() => {
cleanup();
vi.useRealTimers();
});
// ─── fillCurlSnippet ─────────────────────────────────────────────────────────
// ─── Helpers ──────────────────────────────────────────────────────────────────
function renderModal(info: ExternalConnectionInfo | null) {
return render(
<ExternalConnectModal info={info} onClose={vi.fn()} />,
);
}
// Flush React + Radix portal updates synchronously so the dialog is in the DOM.
function renderAndFlush(info: ExternalConnectionInfo | null) {
const result = renderModal(info);
act(() => {});
return result;
}
// ─── Tests ────────────────────────────────────────────────────────────────────
describe("ExternalConnectModal — render conditions", () => {
it("renders nothing when info is null", () => {
renderModal(null);
expect(document.body.textContent).toBe("");
});
it("renders the dialog when info is provided", () => {
renderAndFlush(defaultInfo);
expect(screen.queryByRole("dialog")).toBeTruthy();
});
it("shows the security warning about one-time token display", () => {
renderAndFlush(defaultInfo);
expect(screen.getByText(/only once/i)).toBeTruthy();
describe('fillCurlSnippet', () => {
it('stamps auth_token into WORKSPACE_AUTH_TOKEN placeholder', () => {
const input = 'WORKSPACE_AUTH_TOKEN="<paste from create response>"';
const got = fillCurlSnippet(input, 'tok-curl');
expect(got).toContain('WORKSPACE_AUTH_TOKEN="tok-curl"');
expect(got).not.toContain('<paste from create response>');
});
});
describe("ExternalConnectModal — default tab selection", () => {
it("opens the Universal MCP tab by default when universal_mcp_snippet is present", () => {
renderAndFlush(defaultInfo);
const mcpTab = screen.getByRole("tab", { name: /universal mcp/i });
expect(mcpTab.getAttribute("aria-selected")).toBe("true");
// ─── fillChannelSnippet ─────────────────────────────────────────────────────
describe('fillChannelSnippet', () => {
it('stamps token into MOLECULE_WORKSPACE_TOKENS placeholder', () => {
const input = 'MOLECULE_WORKSPACE_TOKENS=<paste auth_token from create response>';
const got = fillChannelSnippet(input, 'tok-channel');
expect(got).toContain('MOLECULE_WORKSPACE_TOKENS=tok-channel');
});
it("opens the Python SDK tab by default when universal_mcp_snippet is absent", () => {
renderAndFlush({ ...defaultInfo, universal_mcp_snippet: undefined });
const pythonTab = screen.getByRole("tab", { name: /python sdk/i });
expect(pythonTab.getAttribute("aria-selected")).toBe("true");
});
it("tab order: Universal MCP appears before Python SDK when both exist", () => {
renderAndFlush(defaultInfo);
const tabs = screen.getAllByRole("tab");
const mcpIndex = tabs.findIndex((t) => t.textContent?.includes("Universal MCP"));
const pythonIndex = tabs.findIndex((t) => t.textContent?.includes("Python SDK"));
expect(mcpIndex).toBeLessThan(pythonIndex);
it('returns undefined when snippet is undefined', () => {
expect(fillChannelSnippet(undefined, 'tok')).toBeUndefined();
});
});
describe("ExternalConnectModal — tab switching", () => {
it("switches to the Python SDK tab and shows the snippet with stamped token", () => {
renderAndFlush(defaultInfo);
fireEvent.click(screen.getByRole("tab", { name: /python sdk/i }));
const preEl = document.querySelector("pre");
expect(preEl?.textContent).toContain("AUTH_TOKEN");
// The placeholder is replaced with the real auth token
expect(preEl?.textContent).toContain("secret-auth-token-abc");
// ─── fillUniversalMcpSnippet ───────────────────────────────────────────────
describe('fillUniversalMcpSnippet', () => {
it('stamps token with double-quoted value', () => {
const input = 'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"';
const got = fillUniversalMcpSnippet(input, 'tok-mcp');
expect(got).toContain('MOLECULE_WORKSPACE_TOKEN="tok-mcp"');
});
it("switches to the curl tab and shows the snippet with stamped token", () => {
renderAndFlush(defaultInfo);
fireEvent.click(screen.getByRole("tab", { name: /curl/i }));
const preEl = document.querySelector("pre");
expect(preEl?.textContent).toContain("curl");
expect(preEl?.textContent).toContain("secret-auth-token-abc");
});
it("switches to the Fields tab and shows raw values", () => {
renderAndFlush(defaultInfo);
fireEvent.click(screen.getByRole("tab", { name: /fields/i }));
expect(screen.getByText("ws-123")).toBeTruthy();
expect(screen.getByText("https://app.example.com")).toBeTruthy();
expect(screen.getByText("secret-auth-token-abc")).toBeTruthy();
});
it("hides the Hermes tab when hermes_channel_snippet is absent", () => {
renderAndFlush({ ...defaultInfo, hermes_channel_snippet: undefined });
expect(screen.queryByRole("tab", { name: /hermes/i })).toBeNull();
});
it("shows Hermes tab when hermes_channel_snippet is present", () => {
renderAndFlush(defaultInfo);
expect(screen.getByRole("tab", { name: /hermes/i })).toBeTruthy();
it('returns undefined when snippet is undefined', () => {
expect(fillUniversalMcpSnippet(undefined, 'tok')).toBeUndefined();
});
});
describe("ExternalConnectModal — snippet token stamping", () => {
it("stamps the real auth_token into the Python snippet instead of the placeholder", () => {
renderAndFlush(defaultInfo);
fireEvent.click(screen.getByRole("tab", { name: /python sdk/i }));
const preEl = document.querySelector("pre");
expect(preEl?.textContent).not.toContain("<paste from create response>");
expect(preEl?.textContent).toContain("secret-auth-token-abc");
// ─── fillHermesSnippet ─────────────────────────────────────────────────────
describe('fillHermesSnippet', () => {
it('stamps token with double-quoted value', () => {
const input = 'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"';
const got = fillHermesSnippet(input, 'tok-hermes');
expect(got).toContain('MOLECULE_WORKSPACE_TOKEN="tok-hermes"');
});
it("stamps the real auth_token into the curl snippet", () => {
renderAndFlush(defaultInfo);
fireEvent.click(screen.getByRole("tab", { name: /curl/i }));
const preEl = document.querySelector("pre");
// curl template uses WORKSPACE_AUTH_TOKEN placeholder, not the generic one
expect(preEl?.textContent).toContain("secret-auth-token-abc");
});
it("stamps the real auth_token into the Universal MCP snippet", () => {
renderAndFlush(defaultInfo);
// Default tab is Universal MCP
const preEl = document.querySelector("pre");
expect(preEl?.textContent).toContain("secret-auth-token-abc");
expect(preEl?.textContent).not.toContain("<paste from create response>");
it('returns undefined when snippet is undefined', () => {
expect(fillHermesSnippet(undefined, 'tok')).toBeUndefined();
});
});
describe("ExternalConnectModal — copy functionality", () => {
it("calls navigator.clipboard.writeText with the snippet text", () => {
renderAndFlush(defaultInfo);
// Default tab is Universal MCP
fireEvent.click(screen.getByRole("button", { name: /^copy$/i }));
expect(clipboardWriteText).toHaveBeenCalledWith(
expect.stringContaining("secret-auth-token-abc"),
);
// ─── fillCodexSnippet ──────────────────────────────────────────────────────
describe('fillCodexSnippet', () => {
it('uses TOML spacing (space around equals)', () => {
const input = 'MOLECULE_WORKSPACE_TOKEN = "<paste from create response>"';
const got = fillCodexSnippet(input, 'tok-codex');
expect(got).toContain('MOLECULE_WORKSPACE_TOKEN = "tok-codex"');
expect(got).not.toContain('<paste from create response>');
});
it('returns undefined when snippet is undefined', () => {
expect(fillCodexSnippet(undefined, 'tok')).toBeUndefined();
});
});
describe("ExternalConnectModal — close behavior", () => {
it('calls onClose when "I\'ve saved it — close" is clicked', () => {
const onClose = vi.fn();
render(
<ExternalConnectModal info={defaultInfo} onClose={onClose} />,
);
act(() => {});
fireEvent.click(screen.getByRole("button", { name: /i've saved it/i }));
expect(onClose).toHaveBeenCalledTimes(1);
// ─── fillOpenClawSnippet ───────────────────────────────────────────────────
describe('fillOpenClawSnippet', () => {
it('stamps token with WORKSPACE_TOKEN key name', () => {
const input = 'WORKSPACE_TOKEN="<paste from create response>"';
const got = fillOpenClawSnippet(input, 'tok-oc');
expect(got).toContain('WORKSPACE_TOKEN="tok-oc"');
expect(got).not.toContain('<paste from create response>');
});
it('returns undefined when snippet is undefined', () => {
expect(fillOpenClawSnippet(undefined, 'tok')).toBeUndefined();
});
});
describe("ExternalConnectModal — missing optional fields", () => {
it("shows (missing) for absent optional fields in the Fields tab", () => {
// Use empty string so Field renders "(missing)" for registry_endpoint
const minimalInfo: ExternalConnectionInfo = {
workspace_id: "ws-min",
platform_url: "https://min.example.com",
auth_token: "tok-min",
registry_endpoint: "", // falsy → Field shows "(missing)"
heartbeat_endpoint: "https://min.example.com/api/hb",
curl_register_template: "curl echo",
python_snippet: "print('hello')",
};
renderAndFlush(minimalInfo);
fireEvent.click(screen.getByRole("tab", { name: /fields/i }));
expect(screen.getByText("(missing)")).toBeTruthy();
// ─── buildFilledSnippets ────────────────────────────────────────────────────
describe('buildFilledSnippets', () => {
const makeInfo = (overrides: Partial<ExternalConnectionInfo> = {}): ExternalConnectionInfo =>
({
workspace_id: 'ws-1',
platform_url: 'http://localhost:8080',
auth_token: 'tok-test',
registry_endpoint: 'http://localhost:8080/registry/register',
heartbeat_endpoint: 'http://localhost:8080/registry/heartbeat',
python_snippet: 'AUTH_TOKEN = "<paste from create response>"',
curl_register_template: 'WORKSPACE_AUTH_TOKEN="<paste from create response>"',
...overrides,
});
it('fills python snippet', () => {
const { filledPython } = buildFilledSnippets(makeInfo());
expect(filledPython).toContain('tok-test');
});
it("hides the Hermes tab when hermes_channel_snippet is absent", () => {
renderAndFlush({ ...defaultInfo, hermes_channel_snippet: undefined });
expect(screen.queryByRole("tab", { name: /hermes/i })).toBeNull();
it('fills curl snippet', () => {
const { filledCurl } = buildFilledSnippets(makeInfo());
expect(filledCurl).toContain('tok-test');
});
it('fills claude_code_channel_snippet when present', () => {
const info = makeInfo({
claude_code_channel_snippet: 'MOLECULE_WORKSPACE_TOKENS=<paste auth_token from create response>',
});
const { filledChannel } = buildFilledSnippets(info);
expect(filledChannel).toContain('tok-test');
});
it('fills universal_mcp_snippet when present', () => {
const info = makeInfo({
universal_mcp_snippet: 'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
});
const { filledUniversalMcp } = buildFilledSnippets(info);
expect(filledUniversalMcp).toContain('tok-test');
});
it('fills hermes_channel_snippet when present', () => {
const info = makeInfo({
hermes_channel_snippet: 'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
});
const { filledHermes } = buildFilledSnippets(info);
expect(filledHermes).toContain('tok-test');
});
it('fills codex_snippet when present', () => {
const info = makeInfo({
codex_snippet: 'MOLECULE_WORKSPACE_TOKEN = "<paste from create response>"',
});
const { filledCodex } = buildFilledSnippets(info);
expect(filledCodex).toContain('tok-test');
});
it('fills openclaw_snippet when present', () => {
const info = makeInfo({
openclaw_snippet: 'WORKSPACE_TOKEN="<paste from create response>"',
});
const { filledOpenClaw } = buildFilledSnippets(info);
expect(filledOpenClaw).toContain('tok-test');
});
});
// ─── buildTabOrder ──────────────────────────────────────────────────────────
describe('buildTabOrder', () => {
const makeInfo = (overrides: Partial<ExternalConnectionInfo> = {}): ExternalConnectionInfo =>
({
workspace_id: 'ws-1',
platform_url: 'http://localhost:8080',
auth_token: 'tok-test',
registry_endpoint: 'http://localhost:8080/registry/register',
heartbeat_endpoint: 'http://localhost:8080/registry/heartbeat',
python_snippet: 'AUTH_TOKEN = "<paste from create response>"',
curl_register_template: 'WORKSPACE_AUTH_TOKEN="<paste from create response>"',
...overrides,
});
it('python is always present', () => {
const tabs = buildTabOrder(makeInfo());
expect(tabs).toContain('python');
});
it('curl and fields are always present', () => {
const tabs = buildTabOrder(makeInfo());
expect(tabs).toContain('curl');
expect(tabs).toContain('fields');
});
it('mcp first when universal_mcp_snippet is present', () => {
const tabs = buildTabOrder(makeInfo({
universal_mcp_snippet: 'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
}));
expect(tabs[0]).toBe('mcp');
});
it('python first when universal_mcp_snippet is absent', () => {
const tabs = buildTabOrder(makeInfo());
expect(tabs[0]).toBe('python');
});
it('mcp excluded when universal_mcp_snippet is absent', () => {
const tabs = buildTabOrder(makeInfo());
expect(tabs).not.toContain('mcp');
});
it('includes claude when claude_code_channel_snippet is present', () => {
const tabs = buildTabOrder(makeInfo({
claude_code_channel_snippet: 'MOLECULE_WORKSPACE_TOKENS=<paste auth_token from create response>',
}));
expect(tabs).toContain('claude');
});
it('includes hermes when hermes_channel_snippet is present', () => {
const tabs = buildTabOrder(makeInfo({
hermes_channel_snippet: 'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
}));
expect(tabs).toContain('hermes');
});
it('includes codex when codex_snippet is present', () => {
const tabs = buildTabOrder(makeInfo({
codex_snippet: 'MOLECULE_WORKSPACE_TOKEN = "<paste from create response>"',
}));
expect(tabs).toContain('codex');
});
it('includes openclaw when openclaw_snippet is present', () => {
const tabs = buildTabOrder(makeInfo({
openclaw_snippet: 'WORKSPACE_TOKEN="<paste from create response>"',
}));
expect(tabs).toContain('openclaw');
});
it('all optional tabs at once: full house', () => {
const tabs = buildTabOrder(makeInfo({
universal_mcp_snippet: 'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
claude_code_channel_snippet: 'MOLECULE_WORKSPACE_TOKENS=<paste auth_token from create response>',
hermes_channel_snippet: 'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
codex_snippet: 'MOLECULE_WORKSPACE_TOKEN = "<paste from create response>"',
openclaw_snippet: 'WORKSPACE_TOKEN="<paste from create response>"',
}));
expect(tabs).toEqual([
'mcp', 'python', 'claude', 'hermes', 'codex', 'openclaw', 'curl', 'fields',
]);
});
});
@@ -7,7 +7,7 @@
* itself (MemoryInspectorPanel) requires full API + store mocking and
* is exercised by the existing MemoryTab.test.tsx.
*/
import { describe, it, expect } from "vitest";
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
import { isPluginUnavailableError, formatTTL } from "../MemoryInspectorPanel";
// formatRelativeTime is not exported — tested via the component in MemoryTab.test.tsx
@@ -47,6 +47,9 @@ describe("isPluginUnavailableError", () => {
});
describe("formatTTL", () => {
beforeEach(() => { vi.useFakeTimers(); });
afterEach(() => { vi.useRealTimers(); });
it("returns '' for null", () => {
expect(formatTTL(null)).toBe("");
});
+3 -2
View File
@@ -13,6 +13,7 @@ import {
findProviderForModel,
type SelectorValue,
} from "../ProviderModelSelector";
import { isExternalLikeRuntime } from "@/lib/externalRuntimes";
interface Props {
workspaceId: string;
@@ -175,7 +176,7 @@ function deriveProvidersFromModels(models: ModelSpec[]): string[] {
// exactly the point of the platform adaptor. The deep `~/.hermes/
// config.yaml` on the container is a separate runtime-internal file,
// not this one.
const RUNTIMES_WITH_OWN_CONFIG = new Set<string>(["external"]);
const RUNTIMES_WITH_OWN_CONFIG = new Set<string>(["external", "kimi", "kimi-cli"]);
const FALLBACK_RUNTIME_OPTIONS: RuntimeOption[] = [
{ value: "", label: "LangGraph (default)", models: [], providers: [] },
@@ -1003,7 +1004,7 @@ export function ConfigTab({ workspaceId }: Props) {
: "This runtime manages its own config outside the platform template."}
</div>
)}
{!error && config.runtime === "external" && (
{!error && isExternalLikeRuntime(config.runtime) && (
<ExternalConnectionSection workspaceId={workspaceId} />
)}
{success && (
+2 -3
View File
@@ -9,6 +9,7 @@ import { FileEditor } from "./FilesTab/FileEditor";
import { NotAvailablePanel } from "./FilesTab/NotAvailablePanel";
import { useFilesApi } from "./FilesTab/useFilesApi";
import { buildTree } from "./FilesTab/tree";
import { isExternalLikeRuntime } from "@/lib/externalRuntimes";
// Re-exports preserved for external imports (e.g. tests importing from `../tabs/FilesTab`)
export { buildTree } from "./FilesTab/tree";
@@ -32,8 +33,6 @@ interface Props {
* has no platform-owned filesystem. Otherwise the user loses access to
* a real surface (e.g. claude-code SaaS workspaces have files served
* by ListFiles via EIC; they belong on the rendering path, not here). */
const RUNTIMES_WITHOUT_FILES = new Set(["external"]);
export function FilesTab({ workspaceId, data }: Props) {
// Early-return for runtimes whose filesystem is not platform-owned.
// Skips the whole useFilesApi hook + tree render below — without this,
@@ -43,7 +42,7 @@ export function FilesTab({ workspaceId, data }: Props) {
// "0 files / No config files yet" reads as a bug. The placeholder
// makes the absence intentional and points the user at the right
// surface (Chat).
if (data && RUNTIMES_WITHOUT_FILES.has(data.runtime)) {
if (data && isExternalLikeRuntime(data.runtime)) {
return <NotAvailablePanel runtime={data.runtime} />;
}
return <PlatformOwnedFilesTab workspaceId={workspaceId} />;
+2 -3
View File
@@ -13,6 +13,7 @@ interface Props {
}
import { deriveWsBaseUrl } from "@/lib/ws-url";
import { isExternalLikeRuntime } from "@/lib/externalRuntimes";
const WS_URL = deriveWsBaseUrl();
@@ -87,8 +88,6 @@ function NotAvailablePanel({ runtime }: { runtime: string }) {
/** Runtimes that don't expose a TTY. Keep narrow only add a runtime
* here when its provisioner genuinely has no shell endpoint, otherwise
* the user loses access to a real debugging surface. */
const RUNTIMES_WITHOUT_TERMINAL = new Set(["external"]);
export function TerminalTab({ workspaceId, data }: Props) {
// Early-return for runtimes that have no shell. Skips the entire
// xterm + WebSocket dance below — without this, mounting the tab
@@ -96,7 +95,7 @@ export function TerminalTab({ workspaceId, data }: Props) {
// workspace-server (no /ws/terminal/<id> route registered for it),
// and shows "Connection failed" with a Reconnect button — confusing
// because the workspace IS healthy, just doesn't have a TTY.
if (data && RUNTIMES_WITHOUT_TERMINAL.has(data.runtime)) {
if (data && isExternalLikeRuntime(data.runtime)) {
return <NotAvailablePanel runtime={data.runtime} />;
}
+21
View File
@@ -0,0 +1,21 @@
/**
* External-like (BYO-compute) runtime detection.
*
* Mirrors the backend's isExternalLikeRuntime() in
* workspace-server/internal/handlers/runtime_registry.go.
*
* These runtimes have no platform-owned container — the operator installs
* the agent CLI locally and calls /registry/register. They share UX
* behaviour: no Files tab, no Terminal tab, no Docker config, and the
* connection modal shows copy-paste snippets.
*/
const EXTERNAL_LIKE_RUNTIMES = new Set([
"external",
"kimi",
"kimi-cli",
]);
export function isExternalLikeRuntime(runtime: string | undefined): boolean {
return !!runtime && EXTERNAL_LIKE_RUNTIMES.has(runtime);
}
+2
View File
@@ -9,6 +9,8 @@ const RUNTIME_NAMES: Record<string, string> = {
openclaw: "OpenClaw",
crewai: "CrewAI",
autogen: "AutoGen",
kimi: "Kimi",
"kimi-cli": "Kimi CLI",
};
export function runtimeDisplayName(runtime: string): string {
@@ -361,7 +361,7 @@ func (h *DelegationHandler) executeDelegation(ctx context.Context, sourceID, tar
// pause + second attempt catches the common restart-race case where
// the first attempt sees a stale 127.0.0.1:<ephemeral> URL from a
// container that was just recreated.
if proxyErr != nil && isTransientProxyError(proxyErr) {
if proxyErr != nil && isTransientProxyError(proxyErr) && len(respBody) == 0 {
log.Printf("Delegation %s: first attempt failed (%s) — retrying in %s after reactive URL refresh",
delegationID, proxyErr.Error(), delegationRetryDelay)
select {
@@ -78,6 +78,8 @@ var fallbackRuntimes = map[string]struct{}{
"openclaw": {},
"codex": {},
"external": {},
"kimi": {},
"kimi-cli": {},
// mock — virtual workspace with hardcoded canned A2A replies.
// No container, no EC2, no template repo. See mock_runtime.go
// for the full rationale (200-workspace funding-demo org).
@@ -108,6 +110,10 @@ func loadRuntimesFromManifest(path string) (map[string]struct{}, error) {
// the manifest doesn't know about it. Injected here so we
// don't need a special-case in every caller.
"external": {},
// kimi and kimi-cli are BYO-compute meta-runtimes (same shape
// as external). No template repo; injected like external.
"kimi": {},
"kimi-cli": {},
// mock is ALWAYS available for the same reason as external:
// virtual workspace, no template repo, never spawns a
// container. See mock_runtime.go.
@@ -128,6 +134,28 @@ func loadRuntimesFromManifest(path string) (map[string]struct{}, error) {
return out, nil
}
// isExternalLikeRuntime returns true for runtimes that are BYO-compute
// (operator-managed, no platform-owned container or EC2). These runtimes
// share behavior around delivery_mode defaulting, plugin install, restart,
// and discovery.
func isExternalLikeRuntime(runtime string) bool {
switch runtime {
case "external", "kimi", "kimi-cli":
return true
}
return false
}
// normalizeExternalRuntime returns the given runtime label if non-empty,
// otherwise falls back to "external". Used when persisting BYO-compute
// workspaces so we don't store an empty runtime string.
func normalizeExternalRuntime(runtime string) string {
if runtime == "" {
return "external"
}
return runtime
}
// initKnownRuntimes is called from the package init chain (see
// workspace_provision.go var initialization) to replace the
// fallback map with the manifest-derived one. Idempotent —
@@ -33,7 +33,7 @@ func TestLoadRuntimesFromManifest_StripsDefaultSuffix(t *testing.T) {
if err != nil {
t.Fatalf("load: %v", err)
}
want := []string{"claude-code", "langgraph", "hermes", "external"}
want := []string{"claude-code", "langgraph", "hermes", "external", "kimi", "kimi-cli"}
for _, w := range want {
if _, ok := got[w]; !ok {
t.Errorf("want runtime %q in set, missing. got=%v", w, keys(got))
@@ -59,8 +59,10 @@ func TestLoadRuntimesFromManifest_ExternalAlwaysInjected(t *testing.T) {
if err != nil {
t.Fatalf("load: %v", err)
}
if _, ok := got["external"]; !ok {
t.Errorf("external must be injected even when absent from manifest: %v", keys(got))
for _, must := range []string{"external", "kimi", "kimi-cli"} {
if _, ok := got[must]; !ok {
t.Errorf("%s must be injected even when absent from manifest: %v", must, keys(got))
}
}
}
@@ -95,7 +97,7 @@ func TestRealManifestParses(t *testing.T) {
t.Fatalf("real manifest load: %v", err)
}
// Core runtimes we always expect to ship.
for _, must := range []string{"langgraph", "hermes", "claude-code", "external"} {
for _, must := range []string{"langgraph", "hermes", "claude-code", "external", "kimi", "kimi-cli"} {
if _, ok := got[must]; !ok {
t.Errorf("real manifest missing runtime %q — got=%v", must, keys(got))
}
@@ -428,13 +428,16 @@ func (h *WorkspaceHandler) Create(c *gin.Context) {
// implies docker work in flight) so the canvas can render
// a "waiting for external agent to connect" state without
// tripping the provisioning-timeout UX.
if payload.External || payload.Runtime == "external" {
if payload.External || isExternalLikeRuntime(payload.Runtime) {
var connectionToken string
if payload.URL != "" {
// URL already validated by validateAgentURL above (before BeginTx).
// Now persist it: the external URL is set after the workspace row
// commits so that a failed URL UPDATE doesn't roll back the row.
db.DB.ExecContext(ctx, `UPDATE workspaces SET url = $1, status = $2, runtime = 'external', updated_at = now() WHERE id = $3`, payload.URL, models.StatusOnline, id)
// Preserve BYO-compute runtime label (kimi, kimi-cli, external) —
// don't coerce to generic "external" so the canvas can show the
// correct runtime name in the node card.
db.DB.ExecContext(ctx, `UPDATE workspaces SET url = $1, status = $2, runtime = $3, updated_at = now() WHERE id = $4`, payload.URL, models.StatusOnline, normalizeExternalRuntime(payload.Runtime), id)
if err := db.CacheURL(ctx, id, payload.URL); err != nil {
log.Printf("External workspace: failed to cache URL for %s: %v", id, err)
}
@@ -446,7 +449,8 @@ func (h *WorkspaceHandler) Create(c *gin.Context) {
// in awaiting_agent. First POST /registry/register call
// from the external agent (with this token + its URL)
// flips the row to online.
db.DB.ExecContext(ctx, `UPDATE workspaces SET status = $1, runtime = 'external', updated_at = now() WHERE id = $2`, models.StatusAwaitingAgent, id)
// Preserve BYO-compute runtime label (kimi, kimi-cli, external).
db.DB.ExecContext(ctx, `UPDATE workspaces SET status = $1, runtime = $2, updated_at = now() WHERE id = $3`, models.StatusAwaitingAgent, normalizeExternalRuntime(payload.Runtime), id)
tok, tokErr := wsauth.IssueToken(ctx, db.DB, id)
if tokErr != nil {
log.Printf("External workspace %s: token issuance failed: %v", id, tokErr)
@@ -0,0 +1,164 @@
package handlers
import (
"context"
"testing"
"github.com/DATA-DOG/go-sqlmock"
"github.com/Molecule-AI/molecule-monorepo/platform/internal/models"
)
// ==================== resolveDeliveryMode ====================
// Covers workspace_dispatchers.go / registry.go:resolveDeliveryMode
func TestResolveDeliveryMode_PayloadModeWins(t *testing.T) {
mock := setupTestDB(t)
setupTestRedis(t)
broadcaster := newTestBroadcaster()
h := NewRegistryHandler(broadcaster)
ctx := context.Background()
for _, mode := range []string{models.DeliveryModePush, models.DeliveryModePoll} {
got, err := h.resolveDeliveryMode(ctx, "ws-any-id", mode)
if err != nil {
t.Errorf("resolveDeliveryMode(payloadMode=%q) unexpected error: %v", mode, err)
}
if got != mode {
t.Errorf("resolveDeliveryMode(payloadMode=%q) = %q, want %q", mode, got, mode)
}
}
// DB must NOT have been queried when payloadMode is set.
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("DB expectations not met: %v", err)
}
}
func TestResolveDeliveryMode_ExistingDeliveryMode(t *testing.T) {
mock := setupTestDB(t)
setupTestRedis(t)
broadcaster := newTestBroadcaster()
h := NewRegistryHandler(broadcaster)
// Workspace row has existing delivery_mode = "poll"
mock.ExpectQuery("SELECT delivery_mode, runtime FROM workspaces").
WithArgs("ws-poll").
WillReturnRows(sqlmock.NewRows([]string{"delivery_mode", "runtime"}).
AddRow("poll", "langgraph"))
ctx := context.Background()
got, err := h.resolveDeliveryMode(ctx, "ws-poll", "")
if err != nil {
t.Errorf("resolveDeliveryMode() unexpected error: %v", err)
}
if got != models.DeliveryModePoll {
t.Errorf("resolveDeliveryMode() = %q, want %q", got, models.DeliveryModePoll)
}
}
func TestResolveDeliveryMode_ExternalRuntime_DefaultsToPoll(t *testing.T) {
mock := setupTestDB(t)
setupTestRedis(t)
broadcaster := newTestBroadcaster()
h := NewRegistryHandler(broadcaster)
// Row exists but delivery_mode is NULL; runtime = "external"
mock.ExpectQuery("SELECT delivery_mode, runtime FROM workspaces").
WithArgs("ws-external").
WillReturnRows(sqlmock.NewRows([]string{"delivery_mode", "runtime"}).
AddRow(nil, "external"))
ctx := context.Background()
got, err := h.resolveDeliveryMode(ctx, "ws-external", "")
if err != nil {
t.Errorf("resolveDeliveryMode() unexpected error: %v", err)
}
if got != models.DeliveryModePoll {
t.Errorf("resolveDeliveryMode() = %q, want %q (external runtime)", got, models.DeliveryModePoll)
}
}
func TestResolveDeliveryMode_SelfHosted_DefaultsToPush(t *testing.T) {
mock := setupTestDB(t)
setupTestRedis(t)
broadcaster := newTestBroadcaster()
h := NewRegistryHandler(broadcaster)
// Row exists; delivery_mode is NULL; runtime = "langgraph"
mock.ExpectQuery("SELECT delivery_mode, runtime FROM workspaces").
WithArgs("ws-self-hosted").
WillReturnRows(sqlmock.NewRows([]string{"delivery_mode", "runtime"}).
AddRow(nil, "langgraph"))
ctx := context.Background()
got, err := h.resolveDeliveryMode(ctx, "ws-self-hosted", "")
if err != nil {
t.Errorf("resolveDeliveryMode() unexpected error: %v", err)
}
if got != models.DeliveryModePush {
t.Errorf("resolveDeliveryMode() = %q, want %q (self-hosted default)", got, models.DeliveryModePush)
}
}
func TestResolveDeliveryMode_NotFound_DefaultsToPush(t *testing.T) {
mock := setupTestDB(t)
setupTestRedis(t)
broadcaster := newTestBroadcaster()
h := NewRegistryHandler(broadcaster)
// Row not found → sql.ErrNoRows → default push
mock.ExpectQuery("SELECT delivery_mode, runtime FROM workspaces").
WithArgs("ws-nonexistent").
WillReturnError(sql.ErrNoRows)
ctx := context.Background()
got, err := h.resolveDeliveryMode(ctx, "ws-nonexistent", "")
if err != nil {
t.Errorf("resolveDeliveryMode() unexpected error on no-rows: %v", err)
}
if got != models.DeliveryModePush {
t.Errorf("resolveDeliveryMode() = %q, want %q (not-found default)", got, models.DeliveryModePush)
}
}
func TestResolveDeliveryMode_DBError_Propagated(t *testing.T) {
mock := setupTestDB(t)
setupTestRedis(t)
broadcaster := newTestBroadcaster()
h := NewRegistryHandler(broadcaster)
mock.ExpectQuery("SELECT delivery_mode, runtime FROM workspaces").
WithArgs("ws-error").
WillReturnError(context.DeadlineExceeded)
ctx := context.Background()
_, err := h.resolveDeliveryMode(ctx, "ws-error", "")
if err == nil {
t.Errorf("resolveDeliveryMode() expected error, got nil")
}
}
func TestResolveDeliveryMode_ExistingDeliveryModeEmptyString(t *testing.T) {
// When the DB returns an empty (non-NULL) string for delivery_mode,
// it falls through to the runtime check (not the existing.Valid path).
mock := setupTestDB(t)
setupTestRedis(t)
broadcaster := newTestBroadcaster()
h := NewRegistryHandler(broadcaster)
// delivery_mode is explicitly empty string (not NULL), runtime = "langgraph"
// → falls through to runtime check → "push" for non-external
mock.ExpectQuery("SELECT delivery_mode, runtime FROM workspaces").
WithArgs("ws-empty-mode").
WillReturnRows(sqlmock.NewRows([]string{"delivery_mode", "runtime"}).
AddRow("", "langgraph"))
ctx := context.Background()
got, err := h.resolveDeliveryMode(ctx, "ws-empty-mode", "")
if err != nil {
t.Errorf("resolveDeliveryMode() unexpected error: %v", err)
}
if got != models.DeliveryModePush {
t.Errorf("resolveDeliveryMode() = %q, want %q", got, models.DeliveryModePush)
}
}
@@ -559,6 +559,48 @@ func TestWorkspaceCreate_ExternalURL_SSRFSafe(t *testing.T) {
}
}
// TestWorkspaceCreate_KimiRuntime_PreservesLabel asserts that a workspace
// created with runtime="kimi" takes the BYO-compute path (awaiting_agent,
// no Docker provisioning) and preserves the "kimi" label in the DB instead
// of coercing to "external". Regression guard for SOP runtime addition.
func TestWorkspaceCreate_KimiRuntime_PreservesLabel(t *testing.T) {
t.Setenv("MOLECULE_DEPLOY_MODE", "self-hosted")
t.Setenv("MOLECULE_ORG_ID", "")
mock := setupTestDB(t)
setupTestRedis(t)
broadcaster := newTestBroadcaster()
handler := NewWorkspaceHandler(broadcaster, nil, "http://localhost:8080", t.TempDir())
mock.ExpectBegin()
mock.ExpectExec("INSERT INTO workspaces").
WithArgs(sqlmock.AnyArg(), "Kimi Agent", nil, 3, "kimi", sqlmock.AnyArg(), (*string)(nil), nil, "none", (*int64)(nil), models.DefaultMaxConcurrentTasks, "push").
WillReturnResult(sqlmock.NewResult(0, 1))
mock.ExpectCommit()
// Pre-register flow: awaiting_agent + runtime preserved as "kimi"
mock.ExpectExec("UPDATE workspaces SET status").
WithArgs(models.StatusAwaitingAgent, "kimi", sqlmock.AnyArg()).
WillReturnResult(sqlmock.NewResult(0, 1))
// Token issuance (workspace_auth_tokens, not workspace_tokens)
mock.ExpectExec("INSERT INTO workspace_auth_tokens").
WillReturnResult(sqlmock.NewResult(0, 1))
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
body := `{"name":"Kimi Agent","runtime":"kimi","tier":3,"canvas":{"x":100,"y":100}}`
c.Request = httptest.NewRequest("POST", "/workspaces", bytes.NewBufferString(body))
c.Request.Header.Set("Content-Type", "application/json")
handler.Create(c)
if w.Code != http.StatusCreated {
t.Errorf("expected status 201, got %d: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
// TestWorkspaceCreate_ExternalURL_SSRFMetadataBlocked asserts that an external
// workspace created with a cloud-metadata URL is rejected with 400 before any
// DB write. 169.254.0.0/16 is always blocked regardless of mode (SaaS or
@@ -0,0 +1,100 @@
package models
import "testing"
// ==================== IsValidDeliveryMode ====================
func TestIsValidDeliveryMode_Valid(t *testing.T) {
for _, mode := range []string{DeliveryModePush, DeliveryModePoll} {
if !IsValidDeliveryMode(mode) {
t.Errorf("IsValidDeliveryMode(%q) = false, want true", mode)
}
}
}
func TestIsValidDeliveryMode_Invalid(t *testing.T) {
cases := []struct {
val string
want bool
}{
{"", false}, // empty string is not valid — callers must resolve the default
{"pushx", false}, // typo
{"pollx", false}, // typo
{"PUSH", false}, // case-sensitive
{"PUSH ", false}, // trailing space
{"push ", false}, // trailing space
{"hybrid", false}, // non-existent mode
{"poll ", false}, // trailing space
}
for _, tc := range cases {
got := IsValidDeliveryMode(tc.val)
if got != tc.want {
t.Errorf("IsValidDeliveryMode(%q) = %v, want %v", tc.val, got, tc.want)
}
}
}
// ==================== WorkspaceStatus ====================
func TestWorkspaceStatus_String(t *testing.T) {
statuses := []WorkspaceStatus{
StatusProvisioning,
StatusOnline,
StatusOffline,
StatusDegraded,
StatusFailed,
StatusRemoved,
StatusPaused,
StatusHibernated,
StatusHibernating,
StatusAwaitingAgent,
}
for _, s := range statuses {
if got := s.String(); got != string(s) {
t.Errorf("WorkspaceStatus(%q).String() = %q, want %q", s, got, string(s))
}
}
}
func TestAllWorkspaceStatuses_Length(t *testing.T) {
// The const block has 10 statuses; AllWorkspaceStatuses must match.
if got := len(AllWorkspaceStatuses); got != 10 {
t.Errorf("len(AllWorkspaceStatuses) = %d, want 10", got)
}
}
func TestAllWorkspaceStatuses_ContainsAllNamed(t *testing.T) {
// Verify every named const appears in AllWorkspaceStatuses exactly once.
named := []WorkspaceStatus{
StatusProvisioning,
StatusOnline,
StatusOffline,
StatusDegraded,
StatusFailed,
StatusRemoved,
StatusPaused,
StatusHibernated,
StatusHibernating,
StatusAwaitingAgent,
}
set := make(map[WorkspaceStatus]bool, len(AllWorkspaceStatuses))
for _, s := range AllWorkspaceStatuses {
set[s] = true
}
for _, s := range named {
if !set[s] {
t.Errorf("named status %q missing from AllWorkspaceStatuses", s)
}
}
if len(set) != len(named) {
t.Errorf("AllWorkspaceStatuses has %d unique entries, want %d", len(set), len(named))
}
}
func TestAllWorkspaceStatuses_NoEmpty(t *testing.T) {
for _, s := range AllWorkspaceStatuses {
if s == "" {
t.Errorf("AllWorkspaceStatuses contains empty string")
}
}
}