Compare commits

...

4 Commits

Author SHA1 Message Date
core-devops 3eef828173 fix(ci): skip github.ref-gated jobs in ci_job_names (mc#958 mc#959)
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 13s
CI / Detect changes (pull_request) Successful in 45s
E2E API Smoke Test / detect-changes (pull_request) Successful in 52s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 58s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 59s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m19s
qa-review / approved (pull_request) Failing after 22s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 49s
security-review / approved (pull_request) Failing after 21s
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
gate-check-v3 / gate-check (pull_request) Successful in 31s
sop-tier-check / tier-check (pull_request) Successful in 14s
sop-checklist / all-items-acked (pull_request) Successful in 17s
CI / Platform (Go) (pull_request) Successful in 6s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s
CI / Canvas (Next.js) (pull_request) Successful in 7s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Failing after 1m27s
CI / Python Lint & Test (pull_request) Successful in 7s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
audit-force-merge / audit (pull_request) Has been skipped
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 8s
CI / Canvas Deploy Reminder (pull_request) Successful in 4s
CI / all-required (pull_request) Successful in 3s
Adds `github.ref` as a skip condition in ci_job_names(), matching the
existing github.event_name skip. Jobs gated on github.ref (e.g.
canvas-deploy-reminder: only runs on pushes to refs/heads/main) never
execute in a PR context, so flagging them as missing from
all-required.needs: is a false positive that triggers mc#958/mc#959.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-14 12:59:38 +00:00
devops-engineer 927663d5bf Merge pull request 'fix(canvas): TIER_CONFIG legend contrast — WCAG 1.4.3' (#990) from design/tier-legend-contrast-2026-05-14 into main
Block internal-flavored paths / Block forbidden paths (push) Successful in 25s
Secret scan / Scan diff for credential-shaped strings (push) Successful in 22s
Harness Replays / detect-changes (push) Successful in 35s
CI / Detect changes (push) Successful in 46s
E2E Staging Canvas (Playwright) / detect-changes (push) Successful in 46s
E2E API Smoke Test / detect-changes (push) Successful in 49s
Handlers Postgres Integration / detect-changes (push) Successful in 50s
Runtime PR-Built Compatibility / detect-changes (push) Successful in 39s
Harness Replays / Harness Replays (push) Successful in 11s
CI / Platform (Go) (push) Successful in 11s
CI / Shellcheck (E2E scripts) (push) Successful in 10s
CI / Python Lint & Test (push) Successful in 11s
E2E API Smoke Test / E2E API Smoke Test (push) Successful in 13s
publish-canvas-image / Build & push canvas image (push) Successful in 5m35s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (push) Successful in 3m37s
Handlers Postgres Integration / Handlers Postgres Integration (push) Successful in 4m52s
publish-workspace-server-image / build-and-push (push) Successful in 8m59s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 10s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 10s
gate-check-v3 / gate-check (pull_request) Successful in 14s
qa-review / approved (pull_request) Successful in 13s
security-review / approved (pull_request) Successful in 14s
sop-tier-check / tier-check (pull_request) Successful in 15s
sop-checklist / all-items-acked (pull_request) Successful in 17s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m15s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (push) Successful in 8m37s
audit-force-merge / audit (pull_request) Successful in 16s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m39s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m47s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m50s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 1m59s
CI / Canvas (Next.js) (push) Failing after 14m31s
CI / Canvas Deploy Reminder (push) Has been skipped
publish-workspace-server-image / Production auto-deploy (push) Failing after 7m39s
Sweep stale Cloudflare Tunnels / Sweep CF tunnels (push) Successful in 16s
CI / all-required (push) Failing after 5s
Continuous synthetic E2E (staging) / Synthetic E2E against staging (push) Successful in 5m34s
Sweep stale e2e-* orgs (staging) / Sweep e2e orgs (push) Successful in 7s
gitea-merge-queue / queue (push) Successful in 21s
Runtime Pin Compatibility / PyPI-latest install + import smoke (push) Successful in 2m10s
Railway pin audit (drift detection) / Audit Railway env vars for drift-prone pins (push) Compensated by status-reaper (workflow has no push: trigger; Gitea 1.22.6 hardcoded-suffix bug — see .gitea/scripts/status-reaper.py)
status-reaper / reap (push) Successful in 3m1s
Staging SaaS smoke (every 30 min) / Staging SaaS smoke (push) Successful in 8m20s
2026-05-14 12:25:02 +00:00
core-fe a3eee58dbd fix(canvas): TIER_CONFIG legend border contrast — WCAG 1.4.3 AA
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 15s
CI / Detect changes (pull_request) Successful in 38s
E2E API Smoke Test / detect-changes (pull_request) Successful in 40s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 45s
Harness Replays / detect-changes (pull_request) Successful in 15s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 44s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 18s
qa-review / approved (pull_request) Successful in 18s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 49s
gate-check-v3 / gate-check (pull_request) Failing after 33s
security-review / approved (pull_request) Successful in 15s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m22s
sop-checklist / all-items-acked (pull_request) Successful in 21s
audit-force-merge / audit (pull_request) Successful in 20s
sop-tier-check / tier-check (pull_request) Successful in 32s
CI / Platform (Go) (pull_request) Successful in 10s
CI / Python Lint & Test (pull_request) Successful in 7s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s
Harness Replays / Harness Replays (pull_request) Successful in 9s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 8s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 7s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 10m55s
CI / Canvas (Next.js) (pull_request) Failing after 14m31s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Failing after 5s
T3 (violet) and T4 (amber) tier legend border text was using the
same color as the border, yielding:
  - T3: text-violet-600 on violet-500 border ≈ 1.4:1 FAIL
  - T4: text-warm on warm border ≈ 1.7:1 FAIL

Fix: use text-white on both, which gives:
  - T3: text-white on violet-500 border ≈ 4.7:1 PASS AA
  - T4: text-white on warm border ≈ 5.7:1 PASS AA

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-14 12:22:19 +00:00
devops-engineer 9cf997597d Merge pull request 'fix(ci): add explicit 10m timeout to platform-build test step' (#997) from sre/platform-go-timeout-fix into main
CI / Platform (Go) (push) Blocked by required conditions
CI / Canvas (Next.js) (push) Blocked by required conditions
CI / Shellcheck (E2E scripts) (push) Blocked by required conditions
CI / Canvas Deploy Reminder (push) Blocked by required conditions
CI / Python Lint & Test (push) Blocked by required conditions
CI / all-required (push) Blocked by required conditions
E2E API Smoke Test / E2E API Smoke Test (push) Blocked by required conditions
E2E Staging Canvas (Playwright) / Canvas tabs E2E (push) Blocked by required conditions
Handlers Postgres Integration / Handlers Postgres Integration (push) Blocked by required conditions
publish-workspace-server-image / build-and-push (push) Waiting to run
publish-workspace-server-image / Production auto-deploy (push) Blocked by required conditions
Runtime PR-Built Compatibility / detect-changes (push) Waiting to run
Runtime PR-Built Compatibility / PR-built wheel + import smoke (push) Blocked by required conditions
Secret scan / Scan diff for credential-shaped strings (push) Waiting to run
Block internal-flavored paths / Block forbidden paths (pull_request) Waiting to run
CI / Detect changes (pull_request) Waiting to run
E2E API Smoke Test / detect-changes (pull_request) Waiting to run
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Waiting to run
Handlers Postgres Integration / detect-changes (pull_request) Waiting to run
lint-required-no-paths / lint-required-no-paths (pull_request) Waiting to run
Runtime PR-Built Compatibility / detect-changes (pull_request) Waiting to run
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
gate-check-v3 / gate-check (pull_request) Waiting to run
qa-review / approved (pull_request) Waiting to run
security-review / approved (pull_request) Waiting to run
sop-checklist / all-items-acked (pull_request) Waiting to run
sop-tier-check / tier-check (pull_request) Waiting to run
Block internal-flavored paths / Block forbidden paths (push) Successful in 19s
CI / Detect changes (push) Has been cancelled
E2E API Smoke Test / detect-changes (push) Has been cancelled
E2E Staging Canvas (Playwright) / detect-changes (push) Has been cancelled
Handlers Postgres Integration / detect-changes (push) Has been cancelled
Lint curl status-code capture / Scan workflows for curl status-capture pollution (push) Successful in 13s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (push) Successful in 1m28s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (push) Successful in 2m21s
status-reaper / reap (push) Has started running
gitea-merge-queue / queue (push) Successful in 22s
Continuous synthetic E2E (staging) / Synthetic E2E against staging (push) Successful in 4m40s
CI / Platform (Go) (pull_request) Has been cancelled
CI / Canvas (Next.js) (pull_request) Has been cancelled
CI / Shellcheck (E2E scripts) (pull_request) Has been cancelled
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
CI / Python Lint & Test (pull_request) Has been cancelled
CI / all-required (pull_request) Has been cancelled
E2E API Smoke Test / E2E API Smoke Test (pull_request) Has been cancelled
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Has been cancelled
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Has been cancelled
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Has been cancelled
2026-05-14 12:20:48 +00:00
2 changed files with 16 additions and 8 deletions
+14 -6
View File
@@ -13,8 +13,9 @@ Sources:
Three failure classes:
F1 Job in (A) is not under the sentinel's `needs:` — sentinel
doesn't gate it, so a red job on that name can sneak through.
Ignores jobs whose `if:` references `github.event_name` (those
run only on specific events and may be `skipped` legitimately).
Ignores jobs whose `if:` references `github.event_name` or
`github.ref` (those run only on specific events or refs and may
be `skipped` legitimately).
F2 Context in (B) corresponds to no emitter — i.e. there's no job
in ci.yml whose runtime status-name maps to that context.
A stale required-check name is silent: protection demands a
@@ -203,12 +204,17 @@ def ci_jobs_all(ci_doc: dict) -> set[str]:
def ci_job_names(ci_doc: dict) -> set[str]:
"""Set of job keys in ci.yml MINUS the sentinel itself MINUS jobs
whose `if:` gates on `github.event_name` (those are event-scoped
and can legitimately be `skipped` for a given trigger; if we
required them under the sentinel `needs:`, every PR-only job
whose `if:` gates on `github.event_name` or `github.ref` (those are
event-scoped and can legitimately be `skipped` for a given trigger;
if we required them under the sentinel `needs:`, every PR-only job
would be `skipped` on push and the sentinel would interpret
`skipped != success` as failure). RFC §4 spec.
`github.ref` is the companion gate for jobs that run only on direct
pushes to specific branches (e.g. `github.ref == 'refs/heads/main'`).
These never execute in a PR context, so flagging them as missing
from `all-required.needs:` is a false positive (mc#958 / mc#959).
Used for F1 (jobs missing from sentinel needs). NOT used for F1b
(typos in needs) — see `ci_jobs_all` for that."""
jobs = ci_doc.get("jobs")
@@ -221,7 +227,9 @@ def ci_job_names(ci_doc: dict) -> set[str]:
continue
if isinstance(v, dict):
gate = v.get("if")
if isinstance(gate, str) and "github.event_name" in gate:
if isinstance(gate, str) and (
"github.event_name" in gate or "github.ref" in gate
):
continue
names.add(k)
return names
+2 -2
View File
@@ -21,8 +21,8 @@ export function statusDotClass(status: string): string {
export const TIER_CONFIG: Record<number, { label: string; color: string; border: string }> = {
1: { label: "T1", color: "text-ink-mid bg-surface-card border border-line", border: "text-ink-mid border-line" },
2: { label: "T2", color: "text-white bg-accent border border-accent-strong", border: "text-accent border-accent" },
3: { label: "T3", color: "text-white bg-violet-600 border border-violet-700", border: "text-violet-600 border-violet-500" },
4: { label: "T4", color: "text-white bg-warm border border-warm", border: "text-warm border-warm" },
3: { label: "T3", color: "text-white bg-violet-600 border border-violet-700", border: "text-white border-violet-500" },
4: { label: "T4", color: "text-white bg-warm border border-warm", border: "text-white border-warm" },
};
export const COMM_TYPE_LABELS: Record<string, string> = {