fix(canvas/mobile): WCAG 2.4.7 focus-visible + aria-label on MobileCanvas buttons

Adds focus-visible ring + aria-label to the three inline-styled buttons in MobileCanvas.tsx: - Reset zoom: focus-visible ring - Agent node: aria-label="Open {name}" + focus-visible ring (was missing both) - Spawn FAB: focus-visible ring Also adds MobileCanvas to the PR scope; refs #1395. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
fix(canvas/mobile): WCAG 2.4.7 focus-visible rings on all mobile canvas buttons
2026-05-17 18:13:48 +00:00 · 2026-05-17 17:55:45 +00:00 · 2026-05-17 02:52:25 +00:00 · 2026-05-16 18:45:26 -07:00
9 changed files with 26 additions and 1 deletions
@@ -162,6 +162,7 @@ jobs:
            exit 1
          fi
          python -m twine upload \
+            --verbose \
            --repository pypi \
            --username __token__ \
            --password "$PYPI_TOKEN" \
@@ -205,6 +205,7 @@ export function MobileCanvas({
          type="button"
          onClick={resetView}
          aria-label="Reset zoom"
+          className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
          style={{
            position: "absolute",
            right: 14,
@@ -272,6 +273,8 @@ export function MobileCanvas({
            key={l.agent.id}
            type="button"
            onClick={() => onOpen(l.agent.id)}
+            aria-label={`Open ${l.agent.name}`}
+            className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
            style={{
              position: "absolute",
              left: `${l.x}%`,
@@ -376,6 +379,7 @@ export function MobileCanvas({
        type="button"
        onClick={onSpawn}
        aria-label="Spawn new agent"
+        className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-2"
        style={{
          position: "absolute",
          right: 24,
@@ -339,6 +339,7 @@ export function MobileChat({
            type="button"
            onClick={onBack}
            aria-label="Back"
+            className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
            style={{
              width: 36,
              height: 36,
@@ -385,6 +386,7 @@ export function MobileChat({
          <button
            type="button"
            aria-label="More"
+            className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
            style={{
              width: 36,
              height: 36,
@@ -415,6 +417,7 @@ export function MobileChat({
                key={t.id}
                type="button"
                onClick={() => setTab(t.id)}
+                className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
                style={{
                  padding: "4px 0 8px",
                  border: "none",
@@ -478,6 +481,7 @@ export function MobileChat({
              onClick={() => {
                loadInitial();
              }}
+              className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
              style={{
                padding: "6px 14px",
                borderRadius: 14,
@@ -619,6 +623,7 @@ export function MobileChat({
                  type="button"
                  onClick={() => removePendingFile(i)}
                  aria-label={`Remove ${f.name}`}
+                  className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
                  style={{
                    border: "none",
                    background: "transparent",
@@ -659,6 +664,7 @@ export function MobileChat({
            onClick={() => fileInputRef.current?.click()}
            disabled={!reachable || sending || uploading}
            aria-label="Attach"
+            className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
            style={{
              width: 32,
              height: 32,
@@ -719,6 +725,7 @@ export function MobileChat({
            onClick={send}
            disabled={(!draft.trim() && pendingFiles.length === 0) || !reachable || sending || uploading}
            aria-label="Send"
+            className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
            style={{
              width: 36,
              height: 36,
@@ -218,6 +218,7 @@ export function MobileComms({ dark }: { dark: boolean }) {
              key={o.id}
              type="button"
              onClick={() => setFilter(o.id)}
+              className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
              style={{
                display: "inline-flex",
                alignItems: "center",
@@ -83,11 +83,12 @@ export function MobileDetail({
            type="button"
            onClick={onBack}
            aria-label="Back"
+            className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
            style={iconButtonStyle(p, dark)}
          >
            {Icons.back({ size: 18 })}
          </button>
-          <button type="button" aria-label="More" style={iconButtonStyle(p, dark)}>
+          <button type="button" aria-label="More" className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1" style={iconButtonStyle(p, dark)}>
            {Icons.more({ size: 18 })}
          </button>
        </div>
@@ -183,6 +184,7 @@ export function MobileDetail({
              key={t.id}
              type="button"
              onClick={() => setTab(t.id)}
+              className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
              style={{
                padding: "8px 14px",
                borderRadius: 999,
@@ -215,6 +217,7 @@ export function MobileDetail({
          type="button"
          onClick={onChat}
          data-testid="mobile-chat-cta"
+          className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-2"
          style={{
            width: "100%",
            height: 52,
@@ -183,6 +183,7 @@ export function MobileHome({
        type="button"
        onClick={onSpawn}
        aria-label="Spawn new agent"
+        className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-2"
        style={{
          position: "absolute",
          right: 24,
@@ -83,6 +83,7 @@ export function MobileMe({
                  type="button"
                  onClick={() => setAccent(c)}
                  aria-label={`Set accent ${c}`}
+                  className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
                  style={{
                    width: 36,
                    height: 36,
@@ -173,6 +174,7 @@ function SegmentedRow({
            key={o.id}
            type="button"
            onClick={() => onChange(o.id)}
+            className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
            style={{
              flex: 1,
              padding: "10px 8px",
@@ -148,6 +148,7 @@ export function MobileSpawn({ dark, onClose }: { dark: boolean; onClose: () => v
            type="button"
            onClick={onClose}
            aria-label="Close"
+            className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
            style={{
              width: 32,
              height: 32,
@@ -214,6 +215,7 @@ export function MobileSpawn({ dark, onClose }: { dark: boolean; onClose: () => v
                      setTplId(t.id);
                      setTier(tCode);
                    }}
+                    className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
                    style={{
                      background: on
                        ? dark
@@ -330,6 +332,7 @@ export function MobileSpawn({ dark, onClose }: { dark: boolean; onClose: () => v
                key={t}
                type="button"
                onClick={() => setTier(t)}
+                className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
                style={{
                  flex: 1,
                  padding: "10px 8px",
@@ -377,6 +380,7 @@ export function MobileSpawn({ dark, onClose }: { dark: boolean; onClose: () => v
            type="button"
            onClick={handleSpawn}
            disabled={busy || !tplId || templates.length === 0}
+            className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-2"
            style={{
              width: "100%",
              height: 52,
@@ -291,6 +291,7 @@ export function AgentCard({
      data-testid="workspace-card"
      aria-label={`${agent.name}, status: ${agent.status}, tier ${agent.tier}${agent.remote ? ", remote" : ""}`}
      onClick={onClick}
+      className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
      style={{
        display: "block",
        width: "100%",
@@ -444,6 +445,7 @@ export function FilterChips({
            type="button"
            aria-checked={on}
            onClick={() => onChange(o.id)}
+            className="focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
            style={{
              display: "inline-flex",
              alignItems: "center",
Author	SHA1	Message	Date
core-uiux	5aece16017	fix(canvas/mobile): WCAG 2.4.7 focus-visible + aria-label on MobileCanvas buttons audit-force-merge / audit (pull_request) Waiting to run Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7m1s Details Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s Details CI / Detect changes (pull_request) Successful in 5s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 15s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 12s Details E2E Chat / detect-changes (pull_request) Successful in 13s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 12s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s Details Harness Replays / detect-changes (pull_request) Successful in 7s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m6s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 10s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s Details gate-check-v3 / gate-check (pull_request) Successful in 7s Details qa-review / approved (pull_request) Failing after 4s Details security-review / approved (pull_request) Failing after 5s Details sop-tier-check / tier-check (pull_request) Successful in 3s Details CI / Platform (Go) (pull_request) Successful in 6m9s Details sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 5/7 — missing: root-cause, no-backwards-compat — body-unfilled: local-postgres-e2e, staging-smoke, memory-consulted Details sop-checklist / na-declarations (pull_request) N/A: (none) Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s Details CI / Python Lint & Test (pull_request) Successful in 6m40s Details CI / Canvas (Next.js) (pull_request) Successful in 7m26s Details CI / all-required (pull_request) Successful in 6m47s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s Details Harness Replays / Harness Replays (pull_request) Successful in 1s Details E2E Chat / E2E Chat (pull_request) Failing after 4m46s Details Adds focus-visible ring + aria-label to the three inline-styled buttons in MobileCanvas.tsx: - Reset zoom: focus-visible ring - Agent node: aria-label="Open {name}" + focus-visible ring (was missing both) - Spawn FAB: focus-visible ring Also adds MobileCanvas to the PR scope; refs #1395. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-17 18:13:48 +00:00
core-uiux	e99e8d59a5	fix(canvas/mobile): WCAG 2.4.7 focus-visible rings on all mobile canvas buttons CI / Shellcheck (E2E scripts) (pull_request) Successful in 16s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 6s Details E2E Chat / detect-changes (pull_request) Successful in 6s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 5s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s Details Harness Replays / detect-changes (pull_request) Successful in 3s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 59s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 4s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s Details gate-check-v3 / gate-check (pull_request) Successful in 4s Details qa-review / approved (pull_request) Failing after 3s Details security-review / approved (pull_request) Failing after 3s Details CI / Platform (Go) (pull_request) Successful in 6m55s Details CI / Canvas (Next.js) (pull_request) Successful in 7m48s Details Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s Details CI / Detect changes (pull_request) Successful in 6s Details CI / Python Lint & Test (pull_request) Successful in 6m40s Details CI / all-required (pull_request) Successful in 5m24s Details CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions Details E2E Chat / E2E Chat (pull_request) Blocked by required conditions Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Blocked by required conditions Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions Details Harness Replays / Harness Replays (pull_request) Blocked by required conditions Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions Details sop-checklist / all-items-acked (pull_request) Waiting to run Details sop-tier-check / tier-check (pull_request) Waiting to run Details Adds keyboard focus indicators (focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset) to every keyboard-navigable button across the mobile canvas layer. Buttons using inline style props now carry a Tailwind className pair that shows the ring on keyboard focus without affecting mouse/touch users. Components fixed: - MobileChat: Back, More, tab-switch, Retry, Remove file, Attach, Send - MobileHome: Spawn FAB - MobileSpawn: Close, template select, tier select, Spawn agent - MobileMe: Accent swatches, Theme/Density segmented controls - MobileDetail: Back, More, tab-switch, Open chat CTA - MobileComms: Filter chips (All, Errors) - components.tsx: AgentCard, FilterChips Refs #1384 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-17 17:55:45 +00:00
devops-engineer	c3cfbea750	Merge pull request 'ci(publish-runtime): add --verbose to twine upload to surface PyPI 403 reason body' (#1390 ) from ci/twine-verbose-403-reason-body into main CI / all-required (pull_request) Successful in 6m48s Details main-red-watchdog / watchdog (push) Successful in 32s Details Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 8s Details CI / Detect changes (pull_request) Successful in 9s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 16s Details Staging SaaS smoke (every 30 min) / Staging SaaS smoke (push) Successful in 4m19s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 6s Details E2E Chat / detect-changes (pull_request) Successful in 7s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 9s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 6s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s Details gate-check-v3 / gate-check (pull_request) Successful in 6s Details qa-review / approved (pull_request) Failing after 6s Details security-review / approved (pull_request) Failing after 5s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 58s Details gate-check-v3 / gate-check (push) Successful in 1m8s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details gitea-merge-queue / queue (push) Successful in 5s Details status-reaper / reap (push) Successful in 1m16s Details Sweep stale Cloudflare Tunnels / Sweep CF tunnels (push) Successful in 7s Details publish-workspace-server-image / build-and-push (push) Successful in 2m43s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions Details sop-tier-check / tier-check (pull_request) Waiting to run Details Block internal-flavored paths / Block forbidden paths (push) Successful in 5s Details CI / Detect changes (push) Successful in 6s Details CI / Shellcheck (E2E scripts) (push) Successful in 16s Details E2E API Smoke Test / detect-changes (push) Successful in 5s Details E2E Chat / detect-changes (push) Successful in 5s Details Handlers Postgres Integration / detect-changes (push) Successful in 3s Details Lint curl status-code capture / Scan workflows for curl status-capture pollution (push) Successful in 5s Details CI / Platform (Go) (push) Successful in 6m4s Details Runtime PR-Built Compatibility / detect-changes (push) Successful in 4s Details Secret scan / Scan diff for credential-shaped strings (push) Successful in 3s Details Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (push) Successful in 1m7s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions Details E2E Chat / E2E Chat (pull_request) Blocked by required conditions Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Blocked by required conditions Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions Details CI / Canvas (Next.js) (push) Successful in 7m15s Details CI / Python Lint & Test (push) Successful in 6m27s Details CI / all-required (push) Successful in 6m7s Details publish-workspace-server-image / Production auto-deploy (push) Successful in 15m14s Details E2E API Smoke Test / E2E API Smoke Test (push) Successful in 1s Details E2E Chat / E2E Chat (push) Successful in 1s Details Handlers Postgres Integration / Handlers Postgres Integration (push) Successful in 1m8s Details sop-checklist / all-items-acked (pull_request) Waiting to run Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (push) Successful in 1m42s Details CI / Canvas Deploy Reminder (push) Successful in 1s Details lint-bp-context-emit-match / lint-bp-context-emit-match (push) Successful in 1m10s Details MCP Stdio Transport Regression / MCP stdio with regular-file stdout (push) Successful in 46s Details SECRET_PATTERNS drift lint / Detect SECRET_PATTERNS drift (push) Successful in 25s Details Sweep stale Cloudflare DNS records / Sweep CF orphans (push) Successful in 9s Details ci-required-drift / drift (push) Successful in 57s Details E2E Staging SaaS (full lifecycle) / pr-validate (push) Successful in 20s Details E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (push) Successful in 5m42s Details E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (push) Failing after 2m13s Details E2E Staging External Runtime / E2E Staging External Runtime (push) Successful in 5m8s Details E2E Staging Canvas (Playwright) / detect-changes (push) Successful in 5s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (push) Successful in 9m47s Details Sweep stale e2e-* orgs (staging) / Sweep e2e orgs (push) Successful in 15s Details CI / Platform (Go) (pull_request) Successful in 6m28s Details Railway pin audit (drift detection) / Audit Railway env vars for drift-prone pins (push) Compensated by status-reaper (workflow has no push: trigger; Gitea 1.22.6 hardcoded-suffix bug — see .gitea/scripts/status-reaper.py) Details Runtime Pin Compatibility / PyPI-latest install + import smoke (push) Successful in 1m18s Details lint-continue-on-error-tracking / lint-continue-on-error-tracking (push) Successful in 1m5s Details CI / Canvas (Next.js) (pull_request) Successful in 7m51s Details Continuous synthetic E2E (staging) / Synthetic E2E against staging (push) Successful in 5m9s Details CI / Python Lint & Test (pull_request) Successful in 6m46s Details	2026-05-17 02:52:25 +00:00
core-devops	a01d1d8f86	ci(publish-runtime): add --verbose to twine upload to surface PyPI 403 reason body Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s Details cascade-list-drift-gate / check (pull_request) Failing after 2s Details CI / Detect changes (pull_request) Successful in 4s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 9s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 5s Details E2E Chat / detect-changes (pull_request) Successful in 6s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 9s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s Details lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m17s Details Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 5s Details Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 58s Details lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m4s Details CI / Platform (Go) (pull_request) Successful in 4m55s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 52s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 5s Details gate-check-v3 / gate-check (pull_request) Successful in 3s Details qa-review / approved (pull_request) Successful in 3s Details security-review / approved (pull_request) Successful in 3s Details sop-checklist / na-declarations (pull_request) N/A: (none) Details sop-checklist / all-items-acked (pull_request) Successful in 3s Details sop-tier-check / tier-check (pull_request) Successful in 3s Details Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m1s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1s Details E2E Chat / E2E Chat (pull_request) Successful in 2s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s Details CI / Canvas (Next.js) (pull_request) Successful in 6m9s Details CI / Python Lint & Test (pull_request) Successful in 6m39s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details CI / all-required (pull_request) Successful in 6m42s Details audit-force-merge / audit (pull_request) Successful in 5s Details The Publish to PyPI step ran `twine upload` without --verbose. On an HTTP 403, twine's default output prints only the bare status ("Forbidden") and discards PyPI Warehouse's human-readable response body, which carries the actual rejection reason (e.g. project-scoped token mismatch, yanked-name collision, account state). During the internal#469 0.1.1003 publish block the missing reason body made root-cause diagnosis impossible without performing another real upload to the live package. Adding --verbose makes twine log the HTTP request/response metadata and the Warehouse error body in CI. It does NOT echo the credential: the PyPI token is passed via --password and sent only in the Basic-Auth Authorization header, which twine's verbose output does not dump. Minimal change: single added flag on the existing twine upload invocation; no other steps or behavior touched. Refs: internal#469 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-16 18:45:26 -07:00