Compare commits

...

2 Commits

Author SHA1 Message Date
core-uiux e335b7af56 fix(canvas): add focus-visible to secrets-tab add/clear-search buttons
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 2s
CI / Detect changes (pull_request) Successful in 3s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 10s
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
E2E Chat / detect-changes (pull_request) Successful in 4s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 5s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Harness Replays / detect-changes (pull_request) Successful in 4s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 52s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 4s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
qa-review / approved (pull_request) Failing after 3s
security-review / approved (pull_request) Failing after 3s
CI / Platform (Go) (pull_request) Successful in 4m22s
CI / Canvas (Next.js) (pull_request) Successful in 6m23s
CI / Python Lint & Test (pull_request) Successful in 6m30s
CI / all-required (pull_request) Successful in 6m40s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Harness Replays / Harness Replays (pull_request) Successful in 2s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
E2E Chat / E2E Chat (pull_request) Failing after 4m49s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 6m46s
gate-check-v3 / gate-check (pull_request) Successful in 11s
sop-tier-check / tier-check (pull_request) Successful in 6s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 5/7 — missing: root-cause, no-backwards-compat
sop-checklist / na-declarations (pull_request) N/A: (none)
Both .secrets-tab__add-btn and .secrets-tab__clear-search were missing
:focus-visible rules, violating WCAG 2.4.7 (Focus Visible). Keyboard
users tabbing to these buttons would see no visible focus indicator.

Fix: add :focus-visible { outline: var(--focus-ring); outline-offset:
var(--focus-ring-offset); } to both selectors, consistent with the
existing focus-visible pattern used throughout the settings panel.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-17 13:12:12 +00:00
core-uiux a6fe28df21 ci: retry Canvas CI (11th attempt) 2026-05-17 13:12:12 +00:00
+12
View File
@@ -411,6 +411,12 @@
color: #f4f4f5;
}
/* WCAG 2.4.7 — keyboard focus indicator */
.secrets-tab__add-btn:focus-visible {
outline: var(--focus-ring);
outline-offset: var(--focus-ring-offset);
}
/* ── Shared UI ─────────────────────────────────────── */
.key-value-field {
@@ -601,6 +607,12 @@
font-size: 14px;
}
/* WCAG 2.4.7 — keyboard focus indicator */
.secrets-tab__clear-search:focus-visible {
outline: var(--focus-ring);
outline-offset: var(--focus-ring-offset);
}
/* ── Delete confirmation dialog ────────────────────── */
.delete-dialog__overlay {