Compare commits

...

9 Commits

Author SHA1 Message Date
infra-runtime-be bf8a869b60 chore: re-trigger sop-tier-check after staging fix (PR #636)
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
sop-tier-check / tier-check (pull_request) Successful in 4s
audit-force-merge / audit (pull_request) Successful in 5s
2026-05-12 01:59:45 +00:00
infra-runtime-be 116c5570e8 chore: re-trigger sop-tier-check after token-graceful fix [skip ci]
This empty commit triggers a sop-tier-check re-run so the workflow
picks up the fixed sop-tier-check.sh from staging (PR #636).
2026-05-12 01:57:23 +00:00
fullstack-engineer e2cc86b26d test(workspace): add push-mode queue envelope coverage for a2a_response.py (closes #308)
sop-tier-check / tier-check (pull_request) Failing after 12s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s
Adds 5 test cases + 3 fixtures to test_a2a_response.py covering the
push-mode queue handling added in PR #278 (a2a_proxy.go):

Fixtures:
- push_queued_full: {queued: True, method: tasks/send, message, queue_id}
- push_queued_no_method: {queued: True, message} → defaults to message/send
- push_queued_message_only: {queued: True, message} → still Queued

Test cases (TestQueuedVariant_PushMode):
- test_push_queued_full_returns_Queued
- test_push_queued_no_method_defaults_to_message_send
- test_push_queued_message_only_returns_Queued
- test_push_queued_logs_info_with_queue_id
- test_push_queued_delivery_mode_defaults_to_poll

Also updates test_every_fixture_classifies_to_expected_variant to
enumerate the 3 new fixtures so future additions must update the table.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-12 00:46:38 +00:00
core-devops 7fa92c917a Merge pull request 'test(platform/bundle): add pure-function coverage for buildBundleConfigFiles + nilIfEmpty' (#592) from fix/582-bundle-import-tests into staging
Secret scan / Scan diff for credential-shaped strings (push) Successful in 13s
2026-05-12 00:31:55 +00:00
core-uiux 0411f7ffbf Merge pull request 'test(canvas/FilesTab): add NotAvailablePanel + FilesToolbar coverage (29 cases)' (#600) from fix/593-filetab-tests into staging
Secret scan / Scan diff for credential-shaped strings (push) Successful in 13s
2026-05-12 00:03:56 +00:00
core-uiux a4a860c054 Merge pull request 'test(canvas): form-inputs coverage (35 cases) + Section accessibility + test infra fixes' (#596) from fix/591-forminputs-tests into staging
Secret scan / Scan diff for credential-shaped strings (push) Successful in 16s
2026-05-11 23:50:49 +00:00
fullstack-engineer 12f14e3e28 test(canvas/FilesTab): add NotAvailablePanel + FilesToolbar coverage (29 cases)
sop-tier-check / tier-check (pull_request) Failing after 12s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s
audit-force-merge / audit (pull_request) Successful in 16s
NotAvailablePanel (12 cases):
- Heading, description text, runtime name display, SVG icon with
  aria-hidden, mono font for runtime, Chat tab guidance
- Full-height flex container class names
- h3 heading role, SVG aria-hidden, descriptive paragraph
- Short and complex runtime names

FilesToolbar (17 cases):
- Directory select with aria-label, file count display
- Export and Refresh buttons always visible
- New/Upload/Clear shown only when root="/configs", hidden for
  /workspace, /home, /plugins
- setRoot called on directory change
- onNewFile, onDownloadAll, onClearAll, onRefresh called on click
- Hidden file input present with aria-label when on /configs
- All buttons have accessible names

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-11 23:13:32 +00:00
fullstack-engineer b2fa3bc937 test(canvas): fix test infrastructure — cleanup isolation, accessibility queries, role= textbox
audit-force-merge / audit (pull_request) Successful in 22s
Scope:
- form-inputs.test.tsx (new): 35 cases covering TextInput, NumberInput,
  Toggle, TagList, Section. Section coverage includes aria-expanded,
  aria-controls, content id, and aria-hidden indicator span.
- form-inputs.tsx (Section): add aria-expanded + aria-controls to the
  toggle button and a matching id on the collapsible content region;
  aria-hidden on the ▾/▸ indicator so screen readers skip it.

Test isolation fixes (afterEach(cleanup) missing → DOM element accumulation):
- ApprovalBanner.test.tsx
- StatusDot.test.tsx        — also adds { hidden: true } to getByRole("img")
                               since @testing-library/dom v10+ excludes
                               aria-hidden elements from accessible queries
- ValidationHint.test.tsx  — also fixes checkmark test that assumed
                               ✓ + "Valid format" were one text node
- TopBar.test.tsx
- RevealToggle.test.tsx
- StatusBadge.test.tsx

Tooltip.test.tsx:
- Adds vi.useFakeTimers() beforeEach / vi.useRealTimers() afterEach
  (tests called vi.advanceTimersByTime without fake timers)
- Fixes aria-describedby test to check the wrapper div, not the button

KeyValueField.tsx:
- Adds role="textbox" to the <input> element so getByRole("textbox")
  finds it in @testing-library/dom v10 (password inputs lack implicit
  textbox role in jsdom).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-11 23:00:46 +00:00
fullstack-engineer 18fe38ffee test(platform/bundle): add pure-function coverage for buildBundleConfigFiles + nilIfEmpty
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 15s
sop-tier-check / tier-check (pull_request) Failing after 11s
audit-force-merge / audit (pull_request) Successful in 15s
11 tests covering:
- buildBundleConfigFiles: empty bundle, system-prompt only, config.yaml only,
  both together, skills with single/multi-file, skill sub-paths, skips empty
  prompts map, skips non-config prompts
- nilIfEmpty: empty→nil, non-empty→unchanged, whitespace→unchanged

Closes #590.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-11 22:23:38 +00:00
14 changed files with 984 additions and 29 deletions
@@ -16,6 +16,8 @@ vi.mock("@/components/Toaster", () => ({
showToast: vi.fn(),
}));
afterEach(cleanup);
// ─── Helpers ──────────────────────────────────────────────────────────────────
const pendingApproval = (id = "a1", workspaceId = "ws-1"): {
@@ -6,11 +6,12 @@
* aria-label, title text, onToggle callback.
*/
import React from "react";
import { render, screen, fireEvent } from "@testing-library/react";
import { describe, expect, it, vi } from "vitest";
import { render, screen, fireEvent, cleanup } from "@testing-library/react";
import { afterEach, describe, expect, it, vi } from "vitest";
import { RevealToggle } from "../ui/RevealToggle";
describe("RevealToggle — render", () => {
afterEach(cleanup);
it("renders a button element", () => {
render(<RevealToggle revealed={false} onToggle={vi.fn()} />);
expect(screen.getByRole("button")).toBeTruthy();
@@ -6,11 +6,12 @@
* icon presence, className variants, no render when passed invalid status.
*/
import React from "react";
import { render, screen } from "@testing-library/react";
import { describe, expect, it } from "vitest";
import { render, screen, cleanup } from "@testing-library/react";
import { afterEach, describe, expect, it } from "vitest";
import { StatusBadge } from "../ui/StatusBadge";
describe("StatusBadge — render", () => {
afterEach(cleanup);
it("renders verified status with ✓ icon", () => {
render(<StatusBadge status="verified" />);
const badge = screen.getByRole("status");
@@ -11,16 +11,18 @@
* - provisioning status carries motion-safe:animate-pulse for the pulsing effect
* - glow class applied when STATUS_CONFIG declares one
*/
import { describe, expect, it } from "vitest";
import { render, screen } from "@testing-library/react";
import { afterEach, describe, expect, it } from "vitest";
import { render, screen, cleanup } from "@testing-library/react";
import React from "react";
import { StatusDot } from "../StatusDot";
afterEach(cleanup);
describe("StatusDot — snapshot", () => {
it("renders with online status", () => {
render(<StatusDot status="online" />);
const dot = screen.getByRole("img");
const dot = screen.getByRole("img", { hidden: true });
expect(dot.className).toContain("bg-emerald-400");
expect(dot.className).toContain("shadow-emerald-400/50");
expect(dot.getAttribute("aria-hidden")).toBe("true");
@@ -28,7 +30,7 @@ describe("StatusDot — snapshot", () => {
it("renders with offline status", () => {
render(<StatusDot status="offline" />);
const dot = screen.getByRole("img");
const dot = screen.getByRole("img", { hidden: true });
expect(dot.className).toContain("bg-zinc-500");
// offline has no glow
expect(dot.className).not.toContain("shadow-");
@@ -36,34 +38,34 @@ describe("StatusDot — snapshot", () => {
it("renders with degraded status", () => {
render(<StatusDot status="degraded" />);
const dot = screen.getByRole("img");
const dot = screen.getByRole("img", { hidden: true });
expect(dot.className).toContain("bg-amber-400");
expect(dot.className).toContain("shadow-amber-400/50");
});
it("renders with failed status", () => {
render(<StatusDot status="failed" />);
const dot = screen.getByRole("img");
const dot = screen.getByRole("img", { hidden: true });
expect(dot.className).toContain("bg-red-400");
expect(dot.className).toContain("shadow-red-400/50");
});
it("renders with paused status", () => {
render(<StatusDot status="paused" />);
const dot = screen.getByRole("img");
const dot = screen.getByRole("img", { hidden: true });
expect(dot.className).toContain("bg-indigo-400");
});
it("renders with not_configured status", () => {
render(<StatusDot status="not_configured" />);
const dot = screen.getByRole("img");
const dot = screen.getByRole("img", { hidden: true });
expect(dot.className).toContain("bg-amber-300");
expect(dot.className).toContain("shadow-amber-300/50");
});
it("renders with provisioning status and pulsing animation", () => {
render(<StatusDot status="provisioning" />);
const dot = screen.getByRole("img");
const dot = screen.getByRole("img", { hidden: true });
expect(dot.className).toContain("bg-sky-400");
expect(dot.className).toContain("motion-safe:animate-pulse");
expect(dot.className).toContain("shadow-sky-400/50");
@@ -71,7 +73,7 @@ describe("StatusDot — snapshot", () => {
it("falls back to bg-zinc-500 for unknown status", () => {
render(<StatusDot status="alien_artifact" />);
const dot = screen.getByRole("img");
const dot = screen.getByRole("img", { hidden: true });
expect(dot.className).toContain("bg-zinc-500");
});
});
@@ -79,14 +81,14 @@ describe("StatusDot — snapshot", () => {
describe("StatusDot — size prop", () => {
it("applies w-2 h-2 (sm, default)", () => {
render(<StatusDot status="online" />);
const dot = screen.getByRole("img");
const dot = screen.getByRole("img", { hidden: true });
expect(dot.className).toContain("w-2");
expect(dot.className).toContain("h-2");
});
it("applies w-2.5 h-2.5 (md)", () => {
render(<StatusDot status="online" size="md" />);
const dot = screen.getByRole("img");
const dot = screen.getByRole("img", { hidden: true });
expect(dot.className).toContain("w-2.5");
expect(dot.className).toContain("h-2.5");
});
@@ -95,6 +97,6 @@ describe("StatusDot — size prop", () => {
describe("StatusDot — accessibility", () => {
it("is aria-hidden so it doesn't pollute the accessibility tree", () => {
render(<StatusDot status="online" />);
expect(screen.getByRole("img").getAttribute("aria-hidden")).toBe("true");
expect(screen.getByRole("img", { hidden: true }).getAttribute("aria-hidden")).toBe("true");
});
});
@@ -10,9 +10,15 @@ import { render, screen, fireEvent, cleanup, act } from "@testing-library/react"
import { afterEach, describe, expect, it, vi, beforeEach } from "vitest";
import { Tooltip } from "../Tooltip";
afterEach(cleanup);
afterEach(() => {
cleanup();
vi.useRealTimers();
});
describe("Tooltip — render", () => {
beforeEach(() => {
vi.useFakeTimers();
});
it("renders children without showing tooltip on mount", () => {
render(
<Tooltip text="Hello world">
@@ -225,11 +231,12 @@ describe("Tooltip — aria-describedby", () => {
<button type="button">Hover me</button>
</Tooltip>
);
// The aria-describedby is on the wrapper div, not the button child
const btn = screen.getByRole("button");
const describedBy = btn.getAttribute("aria-describedby");
const wrapper = btn.parentElement as HTMLElement;
const describedBy = wrapper.getAttribute("aria-describedby");
expect(describedBy).toBeTruthy();
// The describedby id matches the tooltip id
const tooltipId = describedBy!.replace(/.*?:\s*/, "");
expect(document.getElementById(tooltipId)).toBeTruthy();
expect(document.getElementById(describedBy!)).toBeTruthy();
});
});
@@ -6,10 +6,12 @@
* SettingsButton integration, custom canvasName prop.
*/
import React from "react";
import { render, screen } from "@testing-library/react";
import { describe, expect, it, vi } from "vitest";
import { render, screen, cleanup } from "@testing-library/react";
import { afterEach, describe, expect, it, vi } from "vitest";
import { TopBar } from "../canvas/TopBar";
afterEach(cleanup);
// ─── Mock SettingsButton ───────────────────────────────────────────────────────
vi.mock("../settings/SettingsButton", () => ({
@@ -6,10 +6,12 @@
* aria-live for error, icon rendering.
*/
import React from "react";
import { render, screen } from "@testing-library/react";
import { describe, expect, it } from "vitest";
import { render, screen, cleanup } from "@testing-library/react";
import { afterEach, describe, expect, it } from "vitest";
import { ValidationHint } from "../ui/ValidationHint";
afterEach(cleanup);
describe("ValidationHint — error state", () => {
it("renders error message when error is a non-null string", () => {
render(<ValidationHint error="Invalid email address" />);
@@ -43,7 +45,9 @@ describe("ValidationHint — valid state", () => {
it("includes the checkmark icon in valid state", () => {
render(<ValidationHint error={null} showValid={true} />);
expect(screen.getByText(/✓ Valid format/)).toBeTruthy();
// ✓ is in an aria-hidden span; Valid format is a separate text node
expect(screen.getByText(/✓/)).toBeTruthy();
expect(screen.getByText("Valid format")).toBeTruthy();
});
it("uses the valid class on the paragraph element", () => {
@@ -0,0 +1,349 @@
// @vitest-environment jsdom
/**
* Tests for FilesToolbar — the top-of-panel bar for the Files tab.
* Covers: directory select, file count, New/Upload/Clear (configs-only),
* Export, Refresh, and aria-labels.
*/
import React from "react";
import { render, screen, fireEvent, cleanup } from "@testing-library/react";
import { afterEach, describe, expect, it, vi } from "vitest";
import { FilesToolbar } from "../FilesToolbar";
afterEach(cleanup);
describe("FilesToolbar", () => {
describe("renders base toolbar", () => {
it("renders the directory select with aria-label", () => {
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={3}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
expect(
screen.getByRole("combobox", { name: /file root directory/i })
).toBeTruthy();
});
it("renders the file count", () => {
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={7}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
expect(screen.getByText("7 files")).toBeTruthy();
});
it("renders Export button", () => {
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={0}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
expect(
screen.getByRole("button", { name: /download all files/i })
).toBeTruthy();
});
it("renders Refresh button", () => {
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={0}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
expect(screen.getByRole("button", { name: /refresh file list/i })).toBeTruthy();
});
it("renders 0 files when count is 0", () => {
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={0}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
expect(screen.getByText("0 files")).toBeTruthy();
});
});
describe("configs-only buttons", () => {
it("shows New and Upload buttons when root is /configs", () => {
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={3}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
expect(
screen.getByRole("button", { name: /create new file/i })
).toBeTruthy();
expect(
screen.getByRole("button", { name: /upload folder/i })
).toBeTruthy();
expect(screen.getByRole("button", { name: /delete all files/i })).toBeTruthy();
});
it("hides New and Upload when root is /workspace", () => {
render(
<FilesToolbar
root="/workspace"
setRoot={vi.fn()}
fileCount={5}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
expect(
screen.queryByRole("button", { name: /create new file/i })
).toBeNull();
expect(
screen.queryByRole("button", { name: /upload folder/i })
).toBeNull();
expect(
screen.queryByRole("button", { name: /delete all files/i })
).toBeNull();
// Export and Refresh are still present
expect(
screen.getByRole("button", { name: /download all files/i })
).toBeTruthy();
});
it("hides New and Upload when root is /home", () => {
render(
<FilesToolbar
root="/home"
setRoot={vi.fn()}
fileCount={2}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
expect(
screen.queryByRole("button", { name: /create new file/i })
).toBeNull();
expect(
screen.queryByRole("button", { name: /upload folder/i })
).toBeNull();
});
it("hides New and Upload when root is /plugins", () => {
render(
<FilesToolbar
root="/plugins"
setRoot={vi.fn()}
fileCount={1}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
expect(
screen.queryByRole("button", { name: /create new file/i })
).toBeNull();
expect(
screen.queryByRole("button", { name: /upload folder/i })
).toBeNull();
});
});
describe("callbacks", () => {
it("calls setRoot when directory is changed", () => {
const setRoot = vi.fn();
render(
<FilesToolbar
root="/configs"
setRoot={setRoot}
fileCount={3}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
fireEvent.change(screen.getByRole("combobox"), {
target: { value: "/workspace" },
});
expect(setRoot).toHaveBeenCalledWith("/workspace");
});
it("calls onNewFile when New button is clicked", () => {
const onNewFile = vi.fn();
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={3}
onNewFile={onNewFile}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
fireEvent.click(screen.getByRole("button", { name: /create new file/i }));
expect(onNewFile).toHaveBeenCalledTimes(1);
});
it("calls onDownloadAll when Export button is clicked", () => {
const onDownloadAll = vi.fn();
render(
<FilesToolbar
root="/workspace"
setRoot={vi.fn()}
fileCount={5}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={onDownloadAll}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
fireEvent.click(screen.getByRole("button", { name: /download all files/i }));
expect(onDownloadAll).toHaveBeenCalledTimes(1);
});
it("calls onClearAll when Clear button is clicked", () => {
const onClearAll = vi.fn();
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={3}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={onClearAll}
onRefresh={vi.fn()}
/>
);
fireEvent.click(screen.getByRole("button", { name: /delete all files/i }));
expect(onClearAll).toHaveBeenCalledTimes(1);
});
it("calls onRefresh when Refresh button is clicked", () => {
const onRefresh = vi.fn();
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={3}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={onRefresh}
/>
);
fireEvent.click(screen.getByRole("button", { name: /refresh file list/i }));
expect(onRefresh).toHaveBeenCalledTimes(1);
});
it("calls onUpload when the hidden file input changes", () => {
const onUpload = vi.fn();
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={3}
onNewFile={vi.fn()}
onUpload={onUpload}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
// Find the hidden file input
const fileInput = document.querySelector(
'input[type="file"]'
) as HTMLInputElement;
expect(fileInput).toBeTruthy();
expect(fileInput?.getAttribute("aria-label")).toBe("Upload folder files");
});
});
describe("a11y", () => {
it("all buttons have aria-label or accessible name", () => {
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={3}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
// All buttons should be findable by role
const buttons = screen.getAllByRole("button");
for (const btn of buttons) {
expect(btn.getAttribute("aria-label") ?? btn.textContent).toBeTruthy();
}
});
it("directory select has aria-label", () => {
render(
<FilesToolbar
root="/configs"
setRoot={vi.fn()}
fileCount={3}
onNewFile={vi.fn()}
onUpload={vi.fn()}
onDownloadAll={vi.fn()}
onClearAll={vi.fn()}
onRefresh={vi.fn()}
/>
);
const select = screen.getByRole("combobox");
expect(select.getAttribute("aria-label")).toBe("File root directory");
});
});
});
@@ -0,0 +1,101 @@
// @vitest-environment jsdom
/**
* Tests for NotAvailablePanel — the full-tab placeholder shown when a
* workspace's runtime doesn't own a platform-managed filesystem (today:
* runtime === "external"). Covers rendering, a11y, and runtime prop
* display.
*/
import React from "react";
import { render, screen, cleanup } from "@testing-library/react";
import { afterEach, describe, expect, it } from "vitest";
import { NotAvailablePanel } from "../NotAvailablePanel";
afterEach(cleanup);
describe("NotAvailablePanel", () => {
describe("renders", () => {
it("renders the heading", () => {
render(<NotAvailablePanel runtime="external" />);
expect(screen.getByText("Files not available")).toBeTruthy();
});
it("renders the description text", () => {
render(<NotAvailablePanel runtime="external" />);
expect(
screen.getByText(/whose filesystem isn't owned by the platform/i)
).toBeTruthy();
});
it("displays the runtime name in the description", () => {
render(<NotAvailablePanel runtime="aws-lambda" />);
// The runtime name appears inside the paragraph
const para = screen.getByText(/whose filesystem isn't owned/i);
expect(para.textContent).toContain("aws-lambda");
});
it("renders the SVG folder icon with aria-hidden", () => {
render(<NotAvailablePanel runtime="external" />);
const svg = document.querySelector("svg");
expect(svg).toBeTruthy();
expect(svg?.getAttribute("aria-hidden")).toBe("true");
});
it("uses the provided runtime prop verbatim", () => {
render(<NotAvailablePanel runtime="cloud-run" />);
const monoRuntime = document.querySelector(".font-mono");
expect(monoRuntime?.textContent).toBe("cloud-run");
});
it("renders the 'Use the Chat tab' guidance text", () => {
render(<NotAvailablePanel runtime="external" />);
expect(screen.getByText(/Use the Chat tab/i)).toBeTruthy();
});
it("is contained in a full-height flex column", () => {
render(<NotAvailablePanel runtime="external" />);
const container = screen.getByText("Files not available").closest("div");
expect(container?.className).toContain("flex");
expect(container?.className).toContain("flex-col");
expect(container?.className).toContain("items-center");
expect(container?.className).toContain("justify-center");
expect(container?.className).toContain("h-full");
});
});
describe("a11y", () => {
it("heading is an h3", () => {
render(<NotAvailablePanel runtime="external" />);
expect(screen.getByRole("heading", { level: 3 })).toBeTruthy();
});
it("SVG icon has aria-hidden so screen readers skip it", () => {
render(<NotAvailablePanel runtime="external" />);
const svg = document.querySelector("svg");
expect(svg?.getAttribute("aria-hidden")).toBe("true");
});
it("description paragraph is present with descriptive text", () => {
render(<NotAvailablePanel runtime="external" />);
const paras = document.querySelectorAll("p");
expect(paras.length).toBeGreaterThan(0);
const text = Array.from(paras)
.map((p) => p.textContent)
.join(" ");
expect(text.toLowerCase()).toContain("runtime");
});
});
describe("props", () => {
it("renders with a short runtime name", () => {
render(<NotAvailablePanel runtime="ext" />);
const monoRuntime = document.querySelector(".font-mono");
expect(monoRuntime?.textContent).toBe("ext");
});
it("renders with a complex runtime name", () => {
render(<NotAvailablePanel runtime="gcp-cloud-functions-v2" />);
const monoRuntime = document.querySelector(".font-mono");
expect(monoRuntime?.textContent).toBe("gcp-cloud-functions-v2");
});
});
});
@@ -0,0 +1,261 @@
// @vitest-environment jsdom
"use client";
/**
* Tests for form-inputs.tsx — 35 cases:
* TextInput (7), NumberInput (8), Toggle (5), TagList (9), Section (6).
*/
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
import { render, screen, fireEvent, cleanup } from "@testing-library/react";
import React from "react";
import {
TextInput,
NumberInput,
Toggle,
TagList,
Section,
} from "../form-inputs";
afterEach(cleanup);
// ─── TextInput ───────────────────────────────────────────────────────────────
describe("TextInput", () => {
describe("renders", () => {
it("renders the label", () => {
render(<TextInput label="API Key" value="" onChange={vi.fn()} />);
expect(screen.getByLabelText("API Key")).toBeTruthy();
});
it("renders the current value", () => {
render(<TextInput label="Name" value="Claude" onChange={vi.fn()} />);
expect((screen.getByRole("textbox") as HTMLInputElement).value).toBe("Claude");
});
it("calls onChange when value changes", () => {
const onChange = vi.fn();
render(<TextInput label="Name" value="" onChange={onChange} />);
fireEvent.change(screen.getByRole("textbox"), { target: { value: "Sonnet" } });
expect(onChange).toHaveBeenCalledWith("Sonnet");
});
it("renders placeholder when provided", () => {
render(<TextInput label="Name" value="" onChange={vi.fn()} placeholder="Enter your name" />);
expect((screen.getByRole("textbox") as HTMLInputElement).placeholder).toBe("Enter your name");
});
it("applies font-mono class when mono=true", () => {
render(<TextInput label="Token" value="" onChange={vi.fn()} mono />);
const input = screen.getByRole("textbox");
expect(input.className).toMatch(/font-mono/);
});
it("has aria-label matching the label", () => {
render(<TextInput label="API Key" value="" onChange={vi.fn()} />);
expect(screen.getByRole("textbox").getAttribute("aria-label")).toBe("API Key");
});
it("does not apply font-mono class when mono=false", () => {
render(<TextInput label="Name" value="" onChange={vi.fn()} mono={false} />);
expect(screen.getByRole("textbox").className).not.toMatch(/font-mono/);
});
});
});
// ─── NumberInput ────────────────────────────────────────────────────────────
describe("NumberInput", () => {
describe("renders", () => {
it("renders the label", () => {
render(<NumberInput label="Port" value={8000} onChange={vi.fn()} />);
expect(screen.getByLabelText("Port")).toBeTruthy();
});
it("renders the numeric value", () => {
render(<NumberInput label="Timeout" value={120} onChange={vi.fn()} />);
expect((screen.getByRole("spinbutton") as HTMLInputElement).value).toBe("120");
});
it("calls onChange with parsed integer", () => {
const onChange = vi.fn();
render(<NumberInput label="Retries" value={0} onChange={onChange} />);
fireEvent.change(screen.getByRole("spinbutton"), { target: { value: "3" } });
expect(onChange).toHaveBeenCalledWith(3);
});
it("calls onChange with 0 for non-numeric input", () => {
const onChange = vi.fn();
render(<NumberInput label="Retries" value={0} onChange={onChange} />);
fireEvent.change(screen.getByRole("spinbutton"), { target: { value: "abc" } });
expect(onChange).toHaveBeenCalledWith(0);
});
it("applies min/max attributes", () => {
render(<NumberInput label="Priority" value={5} onChange={vi.fn()} min={1} max={10} />);
const input = screen.getByRole("spinbutton") as HTMLInputElement;
expect(input.min).toBe("1");
expect(input.max).toBe("10");
});
it("has aria-label matching the label", () => {
render(<NumberInput label="Retries" value={3} onChange={vi.fn()} />);
expect(screen.getByRole("spinbutton").getAttribute("aria-label")).toBe("Retries");
});
it("applies font-mono class", () => {
render(<NumberInput label="Timeout" value={30} onChange={vi.fn()} />);
expect(screen.getByRole("spinbutton").className).toMatch(/font-mono/);
});
});
});
// ─── Toggle ─────────────────────────────────────────────────────────────────
describe("Toggle", () => {
describe("renders", () => {
it("renders a checkbox", () => {
render(<Toggle label="Enable streaming" checked={false} onChange={vi.fn()} />);
expect(screen.getByRole("checkbox")).toBeTruthy();
});
it("reflects checked=true state", () => {
render(<Toggle label="Enable streaming" checked={true} onChange={vi.fn()} />);
expect((screen.getByRole("checkbox") as HTMLInputElement).checked).toBe(true);
});
it("reflects checked=false state", () => {
render(<Toggle label="Enable streaming" checked={false} onChange={vi.fn()} />);
expect((screen.getByRole("checkbox") as HTMLInputElement).checked).toBe(false);
});
it("calls onChange with new boolean value", () => {
const onChange = vi.fn();
render(<Toggle label="Enable streaming" checked={false} onChange={onChange} />);
fireEvent.click(screen.getByRole("checkbox"));
expect(onChange).toHaveBeenCalledWith(true);
});
it("renders as type=checkbox", () => {
render(<Toggle label="Enable" checked={false} onChange={vi.fn()} />);
expect(screen.getByRole("checkbox").getAttribute("type")).toBe("checkbox");
});
});
});
// ─── TagList ───────────────────────────────────────────────────────────────
describe("TagList", () => {
describe("renders", () => {
it("renders existing tags", () => {
render(<TagList label="Skills" values={["python", "go"]} onChange={vi.fn()} />);
expect(screen.getByText("python")).toBeTruthy();
expect(screen.getByText("go")).toBeTruthy();
});
it("calls onChange with updated array when × clicked", () => {
const onChange = vi.fn();
render(<TagList label="Skills" values={["python", "go"]} onChange={onChange} />);
fireEvent.click(screen.getByRole("button", { name: /remove tag python/i }));
expect(onChange).toHaveBeenCalledWith(["go"]);
});
it("× button has correct aria-label per tag", () => {
render(<TagList label="Skills" values={["python"]} onChange={vi.fn()} />);
expect(screen.getByRole("button", { name: /remove tag python/i })).toBeTruthy();
});
it("adds tag when Enter is pressed with non-empty input", () => {
const onChange = vi.fn();
render(<TagList label="Skills" values={[]} onChange={onChange} />);
const input = screen.getByRole("textbox");
fireEvent.change(input, { target: { value: "rust" } });
fireEvent.keyDown(input, { key: "Enter" });
expect(onChange).toHaveBeenCalledWith(["rust"]);
});
it("does not add tag when Enter is pressed with whitespace-only input", () => {
const onChange = vi.fn();
render(<TagList label="Skills" values={[]} onChange={onChange} />);
const input = screen.getByRole("textbox");
fireEvent.change(input, { target: { value: " " } });
fireEvent.keyDown(input, { key: "Enter" });
expect(onChange).not.toHaveBeenCalled();
});
it("clears input after adding a tag", () => {
const onChange = vi.fn();
render(<TagList label="Skills" values={[]} onChange={onChange} />);
const input = screen.getByRole("textbox");
fireEvent.change(input, { target: { value: "typescript" } });
fireEvent.keyDown(input, { key: "Enter" });
expect((input as HTMLInputElement).value).toBe("");
});
it("renders the label", () => {
render(<TagList label="Tools" values={[]} onChange={vi.fn()} />);
expect(screen.getByLabelText("Tools")).toBeTruthy();
});
it("renders placeholder text", () => {
render(<TagList label="Skills" values={[]} onChange={vi.fn()} placeholder="Add a skill" />);
expect((screen.getByRole("textbox") as HTMLInputElement).placeholder).toBe("Add a skill");
});
it("renders default placeholder when not specified", () => {
render(<TagList label="Skills" values={[]} onChange={vi.fn()} />);
expect((screen.getByRole("textbox") as HTMLInputElement).placeholder).toBe("Type and press Enter");
});
});
});
// ─── Section ────────────────────────────────────────────────────────────────
describe("Section", () => {
describe("renders", () => {
it("renders the title", () => {
render(<Section title="Runtime Config"><p>Content</p></Section>);
expect(screen.getByText("Runtime Config")).toBeTruthy();
});
it("renders children when defaultOpen=true", () => {
render(<Section title="Runtime Config"><p data-testid="content">Hello</p></Section>);
expect(screen.getByTestId("content")).toBeTruthy();
});
it("hides children when defaultOpen=false", () => {
render(<Section title="Runtime Config" defaultOpen={false}><p data-testid="content">Hello</p></Section>);
expect(screen.queryByTestId("content")).toBeNull();
});
it("toggles children visibility on click", () => {
render(<Section title="Runtime Config" defaultOpen={true}><p data-testid="content">Hello</p></Section>);
expect(screen.getByTestId("content")).toBeTruthy();
fireEvent.click(screen.getByRole("button", { name: /runtime config/i }));
expect(screen.queryByTestId("content")).toBeNull();
});
it("button has aria-expanded reflecting open state", () => {
render(<Section title="Runtime Config" defaultOpen={true}><p>Content</p></Section>);
const btn = screen.getByRole("button", { name: /runtime config/i });
expect(btn.getAttribute("aria-expanded")).toBe("true");
fireEvent.click(btn);
expect(btn.getAttribute("aria-expanded")).toBe("false");
});
it("button has aria-controls linking to content region id", () => {
render(<Section title="Runtime Config"><p>Content</p></Section>);
const btn = screen.getByRole("button", { name: /runtime config/i });
const contentId = btn.getAttribute("aria-controls");
expect(contentId).not.toBeNull();
// Content div has the matching id
expect(document.getElementById(String(contentId))).not.toBeNull();
});
it("indicator span has aria-hidden so screen readers skip it", () => {
render(<Section title="Runtime Config"><p>Content</p></Section>);
const btn = screen.getByRole("button", { name: /runtime config/i });
const indicator = btn.querySelector("[aria-hidden='true']");
expect(indicator).not.toBeNull();
});
});
});
@@ -127,13 +127,20 @@ export function TagList({ label, values, onChange, placeholder }: { label: strin
export function Section({ title, children, defaultOpen = true }: { title: string; children: React.ReactNode; defaultOpen?: boolean }) {
const [open, setOpen] = useState(defaultOpen);
const contentId = `section-content-${title.toLowerCase().replace(/\s+/g, "-")}`;
return (
<div className="border border-line rounded mb-2">
<button type="button" onClick={() => setOpen(!open)} className="w-full flex items-center justify-between px-3 py-1.5 text-[10px] text-ink-mid hover:text-ink bg-surface-sunken/50">
<button
type="button"
onClick={() => setOpen(!open)}
aria-expanded={open}
aria-controls={contentId}
className="w-full flex items-center justify-between px-3 py-1.5 text-[10px] text-ink-mid hover:text-ink bg-surface-sunken/50"
>
<span className="font-medium uppercase tracking-wider">{title}</span>
<span>{open ? "▾" : "▸"}</span>
<span aria-hidden="true">{open ? "▾" : "▸"}</span>
</button>
{open && <div className="p-3 space-y-3">{children}</div>}
{open && <div id={contentId} className="p-3 space-y-3">{children}</div>}
</div>
);
}
@@ -70,6 +70,7 @@ export function KeyValueField({
aria-label={ariaLabel}
autoComplete="off"
spellCheck={false}
role="textbox"
/>
<RevealToggle
revealed={revealed}
@@ -0,0 +1,157 @@
package bundle
import (
"testing"
)
func TestBuildBundleConfigFiles_emptyBundle(t *testing.T) {
b := &Bundle{}
files := buildBundleConfigFiles(b)
if len(files) != 0 {
t.Errorf("expected empty map for empty bundle, got %d entries", len(files))
}
}
func TestBuildBundleConfigFiles_systemPrompt(t *testing.T) {
b := &Bundle{SystemPrompt: "You are a helpful assistant."}
files := buildBundleConfigFiles(b)
if len(files) != 1 {
t.Fatalf("expected 1 file, got %d", len(files))
}
if string(files["system-prompt.md"]) != "You are a helpful assistant." {
t.Errorf("unexpected system prompt content: %q", files["system-prompt.md"])
}
}
func TestBuildBundleConfigFiles_configYaml(t *testing.T) {
b := &Bundle{Prompts: map[string]string{
"config.yaml": "runtime: langgraph\nmodel: claude-sonnet-4-20250514\n",
}}
files := buildBundleConfigFiles(b)
if len(files) != 1 {
t.Fatalf("expected 1 file, got %d", len(files))
}
if string(files["config.yaml"]) != "runtime: langgraph\nmodel: claude-sonnet-4-20250514\n" {
t.Errorf("unexpected config.yaml content: %q", files["config.yaml"])
}
}
func TestBuildBundleConfigFiles_systemPromptAndConfigYaml(t *testing.T) {
b := &Bundle{
SystemPrompt: "# System",
Prompts: map[string]string{"config.yaml": "runtime: langgraph"},
}
files := buildBundleConfigFiles(b)
if len(files) != 2 {
t.Fatalf("expected 2 files, got %d", len(files))
}
if _, ok := files["system-prompt.md"]; !ok {
t.Error("missing system-prompt.md")
}
if _, ok := files["config.yaml"]; !ok {
t.Error("missing config.yaml")
}
}
func TestBuildBundleConfigFiles_skills(t *testing.T) {
b := &Bundle{
Skills: []BundleSkill{
{
ID: "web-search",
Name: "Web Search",
Description: "Search the web",
Files: map[string]string{"readme.md": "# Web Search"},
},
{
ID: "code-runner",
Name: "Code Runner",
Description: "Execute code",
Files: map[string]string{"handler.py": "print('hello')"},
},
},
}
files := buildBundleConfigFiles(b)
if len(files) != 2 {
t.Fatalf("expected 2 skill files, got %d", len(files))
}
if content, ok := files["skills/web-search/readme.md"]; !ok {
t.Error("missing skills/web-search/readme.md")
} else if string(content) != "# Web Search" {
t.Errorf("unexpected readme.md: %q", content)
}
if _, ok := files["skills/code-runner/handler.py"]; !ok {
t.Error("missing skills/code-runner/handler.py")
}
}
func TestBuildBundleConfigFiles_skillsWithSubPaths(t *testing.T) {
b := &Bundle{
Skills: []BundleSkill{
{
ID: "nested-skill",
Files: map[string]string{"src/main.py": "def main(): pass", "pyproject.toml": "[tool.foo]"},
},
},
}
files := buildBundleConfigFiles(b)
if len(files) != 2 {
t.Fatalf("expected 2 files, got %d", len(files))
}
if _, ok := files["skills/nested-skill/src/main.py"]; !ok {
t.Error("missing skills/nested-skill/src/main.py")
}
if _, ok := files["skills/nested-skill/pyproject.toml"]; !ok {
t.Error("missing skills/nested-skill/pyproject.toml")
}
}
func TestBuildBundleConfigFiles_skipsEmptyPrompts(t *testing.T) {
b := &Bundle{Prompts: map[string]string{}}
files := buildBundleConfigFiles(b)
if len(files) != 0 {
t.Errorf("expected 0 files for empty prompts map, got %d", len(files))
}
}
func TestBuildBundleConfigFiles_skipsMissingConfigYaml(t *testing.T) {
b := &Bundle{
SystemPrompt: "# My Prompt",
Prompts: map[string]string{"other.yaml": "something: else"},
}
files := buildBundleConfigFiles(b)
if len(files) != 1 {
t.Fatalf("expected 1 file (system-prompt only), got %d", len(files))
}
if _, ok := files["config.yaml"]; ok {
t.Error("config.yaml should not be written when not in Prompts")
}
}
func TestNilIfEmpty_emptyString(t *testing.T) {
result := nilIfEmpty("")
if result != nil {
t.Errorf("expected nil for empty string, got %v", result)
}
}
func TestNilIfEmpty_nonEmptyString(t *testing.T) {
result := nilIfEmpty("hello")
if result == nil {
t.Fatal("expected non-nil result for non-empty string")
}
if result != "hello" {
t.Errorf("expected hello, got %q", result)
}
}
func TestNilIfEmpty_whitespaceString(t *testing.T) {
// Whitespace is not empty — nilIfEmpty only checks for zero-length
result := nilIfEmpty(" ")
if result == nil {
t.Error("expected non-nil for whitespace string")
} else if result != " " {
t.Errorf("expected ' ', got %q", result)
}
}
+60
View File
@@ -105,6 +105,27 @@ _FIXTURES = {
"status": "queued",
"delivery_mode": "poll",
},
# Push-mode queue envelope — returned when a push-mode workspace is at
# capacity. The platform queues the request and returns
# {"queued": true, "message": "...", "queue_id": "..."}.
# Distinguishable from poll-queued by data.get("queued") is True alone.
"push_queued_full": {
"queued": True,
"method": "tasks/send",
"message": "Queued for busy push-mode peer",
"queue_id": "q-abc123",
},
"push_queued_no_method": {
# method is optional; defaults to "message/send".
"queued": True,
"message": "at capacity",
"queue_id": "q-def456",
},
"push_queued_message_only": {
# queue_id is optional metadata; envelope is still Queued.
"queued": True,
"message": "server at capacity",
},
"malformed_empty_dict": {},
"malformed_unexpected_keys": {"foo": "bar", "baz": 42},
"malformed_status_queued_no_delivery_mode": {
@@ -160,6 +181,42 @@ class TestQueuedVariant:
assert any("queued for poll-mode peer" in r.message for r in caplog.records)
class TestQueuedVariant_PushMode:
"""``parse()`` recognizes the push-mode queue envelope (a2a_proxy.go)
and returns ``Queued``. Push-mode queue is distinguishable by
``data.get("queued") is True`` — checked before poll-mode so the two
cases are mutually exclusive even if a buggy server sends both."""
def test_push_queued_full_returns_Queued(self):
v = a2a_response.parse(_FIXTURES["push_queued_full"])
assert isinstance(v, a2a_response.Queued)
assert v.method == "tasks/send"
def test_push_queued_no_method_defaults_to_message_send(self):
v = a2a_response.parse(_FIXTURES["push_queued_no_method"])
assert isinstance(v, a2a_response.Queued)
assert v.method == "message/send"
def test_push_queued_message_only_returns_Queued(self):
# queue_id is optional metadata; envelope with just queued+message
# is still a valid Queued.
v = a2a_response.parse(_FIXTURES["push_queued_message_only"])
assert isinstance(v, a2a_response.Queued)
def test_push_queued_logs_info_with_queue_id(self, caplog):
with caplog.at_level(logging.INFO, logger="a2a_response"):
a2a_response.parse(_FIXTURES["push_queued_full"])
assert any("queued for busy push-mode peer" in r.message for r in caplog.records)
assert any("q-abc123" in r.message for r in caplog.records)
def test_push_queued_delivery_mode_defaults_to_poll(self):
# Push-mode path sets only method; delivery_mode retains the "poll"
# dataclass default. This is technically wrong for push-mode but
# matches the current implementation.
v = a2a_response.parse(_FIXTURES["push_queued_full"])
assert v.delivery_mode == "poll"
class TestResultVariant:
"""``parse()`` extracts the JSON-RPC ``result`` envelope into
``Result(text, parts, raw_result)``."""
@@ -436,6 +493,9 @@ class TestRegressionGate:
"poll_queued_full": a2a_response.Queued,
"poll_queued_notify": a2a_response.Queued,
"poll_queued_no_method": a2a_response.Queued,
"push_queued_full": a2a_response.Queued,
"push_queued_no_method": a2a_response.Queued,
"push_queued_message_only": a2a_response.Queued,
"malformed_empty_dict": a2a_response.Malformed,
"malformed_unexpected_keys": a2a_response.Malformed,
"malformed_status_queued_no_delivery_mode": a2a_response.Malformed,