Compare commits

..

2 Commits

Author SHA1 Message Date
fullstack-engineer b442797b0f test(handlers): add DB-error tests for SessionSearch and DelegationRecord
CI / Shellcheck (E2E scripts) (pull_request) Blocked by required conditions
CI / all-required (pull_request) Blocked by required conditions
Runtime PR-Built Compatibility / detect-changes (pull_request) Waiting to run
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
gate-check-v3 / gate-check (pull_request) Waiting to run
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 26s
Harness Replays / detect-changes (pull_request) Successful in 27s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 25s
CI / Detect changes (pull_request) Successful in 1m28s
E2E API Smoke Test / detect-changes (pull_request) Successful in 2m24s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 2m27s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m42s
qa-review / approved (pull_request) Successful in 41s
security-review / approved (pull_request) Successful in 36s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 2m2s
sop-checklist / all-items-acked (pull_request) Successful in 31s
sop-tier-check / tier-check (pull_request) Successful in 27s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 3m15s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 3m51s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 3m28s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 4m1s
Harness Replays / Harness Replays (pull_request) Successful in 14s
CI / Python Lint & Test (pull_request) Successful in 13s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m51s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6m20s
CI / Platform (Go) (pull_request) Failing after 20m18s
CI / Canvas (Next.js) (pull_request) Successful in 21m4s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Cherry-pick of PR #1094 (test/delegate-record-db-errors) onto current staging.

- TestSessionSearch_DBError (activity_test.go): verifies SessionSearch returns 500
  when the DB QueryContext returns context.DeadlineExceeded.
- TestDelegationRecord_DBInsertFails (delegation_test.go): verifies Record returns
  500 when the activity_logs INSERT fails (WillReturnError).

Both tests use sqlmock to simulate DB failures and verify the handlers
return the correct HTTP 500 status.

Closes #1152.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-15 10:39:07 +00:00
core-be 80938e82b5 infra(ci): apply full mc#1099 timeout fix to staging
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 26s
CI / Detect changes (pull_request) Successful in 1m28s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m40s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m22s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 19s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 31s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m37s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 2m58s
gate-check-v3 / gate-check (pull_request) Successful in 36s
qa-review / approved (pull_request) Successful in 34s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m25s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m51s
security-review / approved (pull_request) Successful in 26s
sop-tier-check / tier-check (pull_request) Successful in 25s
sop-checklist / all-items-acked (pull_request) Successful in 28s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 2m50s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 3m5s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 3m16s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 12s
CI / Python Lint & Test (pull_request) Successful in 21s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 15s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 16s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 15s
CI / Platform (Go) (pull_request) Failing after 20m10s
CI / Canvas (Next.js) (pull_request) Successful in 20m26s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 5s
Apply all cold-runner CI improvements from hotfix/offsec-015-org-isolation:
- Job-level timeout: 15m → 50m (mc#1099)
- golangci-lint: --timeout 3m → --no-config --timeout 10m (mc#1099)
- Diagnostic: 60s → 600s Go-level, step ceiling 20m (mc#1099)
- Test step: Go-level timeout 10m → 40m, step ceiling 15m → 50m (mc#1099)

Without these, the 10-minute Actions default step ceiling kills the test
step on cold runners before go test -timeout can fire.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-15 10:31:15 +00:00
6 changed files with 86 additions and 1143 deletions
+23 -15
View File
@@ -145,10 +145,11 @@ jobs:
# the diagnostic step with its own continue-on-error: true (line 203).
# Flip confirmed by CI / Platform (Go) status = success on main HEAD 363905d3.
continue-on-error: false
# Job-level ceiling. The go test step below runs with a per-step 10m timeout;
# this cap catches any step that leaks past that. Set well above 10m so
# the per-step timeout is the active constraint.
timeout-minutes: 15
# Job-level ceiling. The go test step below runs with a per-step 20m timeout;
# this cap catches any step that leaks past that. Set well above 20m so
# the per-step timeout is the active constraint. Raised to 50m
# to account for golangci-lint ~10m + test suite ~12m on cold runner (mc#1099).
timeout-minutes: 50
defaults:
run:
working-directory: workspace-server
@@ -172,16 +173,20 @@ jobs:
- if: always()
name: Install golangci-lint
run: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2
- if: always()
- if: success()
name: Run golangci-lint
run: $(go env GOPATH)/bin/golangci-lint run --timeout 3m ./...
- if: always()
name: Diagnostic — per-package verbose 60s
# mc#1099: --no-config bypasses .golangci.yaml ceiling; --timeout 10m
# is now the active constraint instead of the 3m config ceiling.
run: $(go env GOPATH)/bin/golangci-lint run --no-config --timeout 10m ./...
- if: success()
name: Diagnostic — per-package verbose 600s
# mc#1099: step-level ceiling above the 600s Go timeout for cold-runner headroom.
timeout-minutes: 20
run: |
set +e
go test -race -v -timeout 60s ./internal/handlers/... 2>&1 | tee /tmp/test-handlers.log
go test -race -v -timeout 600s ./internal/handlers/... 2>&1 | tee /tmp/test-handlers.log
handlers_exit=$?
go test -race -v -timeout 60s ./internal/pendinguploads/... 2>&1 | tee /tmp/test-pu.log
go test -race -v -timeout 600s ./internal/pendinguploads/... 2>&1 | tee /tmp/test-pu.log
pu_exit=$?
echo "::group::handlers exit=$handlers_exit (last 100 lines)"
tail -100 /tmp/test-handlers.log
@@ -193,11 +198,14 @@ jobs:
continue-on-error: true
- if: always()
name: Run tests with race detection and coverage
# Explicit timeout: cold runner cache causes OOM kills at ~4m39s on the
# full ./... suite with race detection + coverage. A 10m per-step timeout
# lets the suite complete on cold cache (~5-7m) while failing cleanly
# instead of OOM-killing. The job-level timeout (15m) is a backstop.
run: go test -race -timeout 10m -coverprofile=coverage.out ./...
# mc#1099: step-level ceiling above the 40m Go timeout for cold-runner headroom.
# Cold runner: golangci-lint ~10m + test suite ~16-20m = ~26-30m total.
# GitHub Actions default step ceiling is 10m — must override. Set at the
# job-level ceiling (50m) so the Go-level 40m timeout is always the active
# constraint — the suite fails cleanly at 40m instead of step-level killing
# it at 50m. Job-level (50m) is the backstop for the backstop.
timeout-minutes: 50
run: go test -race -timeout 40m -coverprofile=coverage.out ./...
- if: always()
name: Per-file coverage report
@@ -1,408 +0,0 @@
package handlers
import (
"database/sql"
"net/http"
"net/http/httptest"
"testing"
"github.com/DATA-DOG/go-sqlmock"
"github.com/Molecule-AI/molecule-monorepo/platform/internal/db"
"github.com/gin-gonic/gin"
)
// setupQueueStatusHandlerDB creates a sqlmock DB with QueryMatcherEqual for exact SQL string matching.
func setupQueueStatusHandlerDB(t *testing.T) sqlmock.Sqlmock {
t.Helper()
mockDB, mock, err := sqlmock.New(sqlmock.QueryMatcherOption(sqlmock.QueryMatcherEqual))
if err != nil {
t.Fatalf("sqlmock.New: %v", err)
}
prevDB := db.DB
db.DB = mockDB
t.Cleanup(func() { db.DB = prevDB; mockDB.Close() })
return mock
}
// Exact SQL strings used by the production code.
const (
sqlQueueRowAuthFields = `SELECT caller_id, workspace_id FROM a2a_queue WHERE id = $1`
sqlQueueStatusByID = `
SELECT
q.id,
q.workspace_id,
q.status,
q.priority,
q.attempts,
q.last_error,
q.enqueued_at::text,
q.dispatched_at::text,
q.completed_at::text,
q.expires_at::text,
al.response_body::text
FROM a2a_queue q
LEFT JOIN activity_logs al
ON al.method = 'delegate_result'
AND al.target_id = q.workspace_id
AND al.workspace_id = q.caller_id
AND al.response_body->>'delegation_id' = (q.body->'params'->'message'->'metadata'->>'delegation_id')
WHERE q.id = $1`
)
// ── GetA2AQueueStatus HTTP handler tests ──────────────────────────────────────
// TestGetA2AQueueStatus_QueueIDEmpty_Returns400 exercises the handler directly
// (not via router) so we can verify the empty-value branch without relying on
// Gin route-matching behaviour.
func TestGetA2AQueueStatus_QueueIDEmpty_Returns400(t *testing.T) {
gin.SetMode(gin.TestMode)
setupQueueStatusHandlerDB(t)
h := &WorkspaceHandler{}
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"}}
// queue_id param is empty string
c.Params = gin.Params{
{Key: "id", Value: "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"},
{Key: "queue_id", Value: ""},
}
c.Request = httptest.NewRequest(http.MethodGet, "/", nil)
h.GetA2AQueueStatus(c)
if w.Code != http.StatusBadRequest {
t.Errorf("got %d, want 400", w.Code)
}
}
func TestGetA2AQueueStatus_NoIdentity_NoOrgToken_Returns404(t *testing.T) {
gin.SetMode(gin.TestMode)
setupQueueStatusHandlerDB(t)
h := &WorkspaceHandler{}
r := gin.New()
r.GET("/workspaces/:id/a2a/queue/:queue_id", h.GetA2AQueueStatus)
req := httptest.NewRequest(http.MethodGet,
"/workspaces/wsid/a2a/queue/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa", nil)
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
// No identity derivable → 404 (not 401) per existence-non-inference policy.
if w.Code != http.StatusNotFound {
t.Errorf("got %d, want 404", w.Code)
}
}
func TestGetA2AQueueStatus_OrgToken_SkipsCallerCheck(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupQueueStatusHandlerDB(t)
h := &WorkspaceHandler{}
queueID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
wsID := "cccccccc-cccc-cccc-cccc-cccccccccccc"
authRows := sqlmock.NewRows([]string{"caller_id", "workspace_id"}).
AddRow("other-ws", wsID)
mock.ExpectQuery(sqlQueueRowAuthFields).
WithArgs(queueID).
WillReturnRows(authRows)
statusRows := sqlmock.NewRows([]string{
"id", "workspace_id", "status", "priority", "attempts",
"last_error", "enqueued_at", "dispatched_at", "completed_at", "expires_at",
"response_body",
}).AddRow(
queueID, wsID, "queued", 50, 0,
nil, "2026-01-01T00:00:00Z", nil, nil, nil, nil,
)
mock.ExpectQuery(sqlQueueStatusByID).
WithArgs(queueID).
WillReturnRows(statusRows)
r := gin.New()
// Simulate org-token middleware setting org_token_id.
r.GET("/workspaces/:id/a2a/queue/:queue_id", func(c *gin.Context) {
c.Set("org_token_id", "org-admin")
h.GetA2AQueueStatus(c)
})
req := httptest.NewRequest(http.MethodGet, "/workspaces/wsid/a2a/queue/"+queueID, nil)
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestGetA2AQueueStatus_CallerWorkspaceMatchesCallerID_Success(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupQueueStatusHandlerDB(t)
h := &WorkspaceHandler{}
queueID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
callerID := "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
wsID := "cccccccc-cccc-cccc-cccc-cccccccccccc"
authRows := sqlmock.NewRows([]string{"caller_id", "workspace_id"}).
AddRow(callerID, wsID)
mock.ExpectQuery(sqlQueueRowAuthFields).
WithArgs(queueID).
WillReturnRows(authRows)
statusRows := sqlmock.NewRows([]string{
"id", "workspace_id", "status", "priority", "attempts",
"last_error", "enqueued_at", "dispatched_at", "completed_at", "expires_at",
"response_body",
}).AddRow(
queueID, wsID, "completed", 50, 1,
nil, "2026-01-01T00:00:00Z", "2026-01-01T00:01:00Z", "2026-01-01T00:02:00Z",
nil, []byte(`{"text":"result"}`),
)
mock.ExpectQuery(sqlQueueStatusByID).
WithArgs(queueID).
WillReturnRows(statusRows)
r := gin.New()
r.GET("/workspaces/:id/a2a/queue/:queue_id", h.GetA2AQueueStatus)
req := httptest.NewRequest(http.MethodGet,
"/workspaces/"+wsID+"/a2a/queue/"+queueID, nil)
req.Header.Set("X-Workspace-ID", callerID)
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestGetA2AQueueStatus_CallerWorkspaceMatchesWorkspaceID_Success(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupQueueStatusHandlerDB(t)
h := &WorkspaceHandler{}
queueID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
callerID := "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
wsID := "cccccccc-cccc-cccc-cccc-cccccccccccc"
authRows := sqlmock.NewRows([]string{"caller_id", "workspace_id"}).
AddRow(callerID, wsID)
mock.ExpectQuery(sqlQueueRowAuthFields).
WithArgs(queueID).
WillReturnRows(authRows)
statusRows := sqlmock.NewRows([]string{
"id", "workspace_id", "status", "priority", "attempts",
"last_error", "enqueued_at", "dispatched_at", "completed_at", "expires_at",
"response_body",
}).AddRow(
queueID, wsID, "queued", 50, 0,
nil, "2026-01-01T00:00:00Z", nil, nil, nil, nil,
)
mock.ExpectQuery(sqlQueueStatusByID).
WithArgs(queueID).
WillReturnRows(statusRows)
r := gin.New()
r.GET("/workspaces/:id/a2a/queue/:queue_id", h.GetA2AQueueStatus)
req := httptest.NewRequest(http.MethodGet,
"/workspaces/"+wsID+"/a2a/queue/"+queueID, nil)
req.Header.Set("X-Workspace-ID", wsID)
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestGetA2AQueueStatus_QueueNotFound_Returns404(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupQueueStatusHandlerDB(t)
h := &WorkspaceHandler{}
queueID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
callerID := "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
wsID := "cccccccc-cccc-cccc-cccc-cccccccccccc"
mock.ExpectQuery(sqlQueueRowAuthFields).
WithArgs(queueID).
WillReturnError(sql.ErrNoRows)
r := gin.New()
r.GET("/workspaces/:id/a2a/queue/:queue_id", h.GetA2AQueueStatus)
req := httptest.NewRequest(http.MethodGet,
"/workspaces/"+wsID+"/a2a/queue/"+queueID, nil)
req.Header.Set("X-Workspace-ID", callerID)
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusNotFound {
t.Errorf("got %d, want 404: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestGetA2AQueueStatus_QueueAuthFieldsDBError_Returns500(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupQueueStatusHandlerDB(t)
h := &WorkspaceHandler{}
queueID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
callerID := "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
wsID := "cccccccc-cccc-cccc-cccc-cccccccccccc"
mock.ExpectQuery(sqlQueueRowAuthFields).
WithArgs(queueID).
WillReturnError(sql.ErrConnDone)
r := gin.New()
r.GET("/workspaces/:id/a2a/queue/:queue_id", h.GetA2AQueueStatus)
req := httptest.NewRequest(http.MethodGet,
"/workspaces/"+wsID+"/a2a/queue/"+queueID, nil)
req.Header.Set("X-Workspace-ID", callerID)
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusInternalServerError {
t.Errorf("got %d, want 500: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestGetA2AQueueStatus_WrongCallerWorkspace_Returns404(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupQueueStatusHandlerDB(t)
h := &WorkspaceHandler{}
queueID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
callerID := "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
wsID := "cccccccc-cccc-cccc-cccc-cccccccccccc"
wrongCaller := "dddddddd-dddd-dddd-dddd-dddddddddddd"
authRows := sqlmock.NewRows([]string{"caller_id", "workspace_id"}).
AddRow(callerID, wsID)
mock.ExpectQuery(sqlQueueRowAuthFields).
WithArgs(queueID).
WillReturnRows(authRows)
r := gin.New()
r.GET("/workspaces/:id/a2a/queue/:queue_id", h.GetA2AQueueStatus)
req := httptest.NewRequest(http.MethodGet,
"/workspaces/"+wsID+"/a2a/queue/"+queueID, nil)
req.Header.Set("X-Workspace-ID", wrongCaller)
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusNotFound {
t.Errorf("got %d, want 404: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestGetA2AQueueStatus_StatusFetchDBError_Returns500(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupQueueStatusHandlerDB(t)
h := &WorkspaceHandler{}
queueID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
callerID := "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
wsID := "cccccccc-cccc-cccc-cccc-cccccccccccc"
authRows := sqlmock.NewRows([]string{"caller_id", "workspace_id"}).
AddRow(callerID, wsID)
mock.ExpectQuery(sqlQueueRowAuthFields).
WithArgs(queueID).
WillReturnRows(authRows)
mock.ExpectQuery(sqlQueueStatusByID).
WithArgs(queueID).
WillReturnError(sql.ErrConnDone)
r := gin.New()
r.GET("/workspaces/:id/a2a/queue/:queue_id", h.GetA2AQueueStatus)
req := httptest.NewRequest(http.MethodGet,
"/workspaces/"+wsID+"/a2a/queue/"+queueID, nil)
req.Header.Set("X-Workspace-ID", callerID)
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusInternalServerError {
t.Errorf("got %d, want 500: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestGetA2AQueueStatus_FullHappyPath_ReturnsJSON(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupQueueStatusHandlerDB(t)
h := &WorkspaceHandler{}
queueID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
callerID := "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
wsID := "cccccccc-cccc-cccc-cccc-cccccccccccc"
authRows := sqlmock.NewRows([]string{"caller_id", "workspace_id"}).
AddRow(callerID, wsID)
mock.ExpectQuery(sqlQueueRowAuthFields).
WithArgs(queueID).
WillReturnRows(authRows)
respBody := []byte(`{"text":"delegation result"}`)
statusRows := sqlmock.NewRows([]string{
"id", "workspace_id", "status", "priority", "attempts",
"last_error", "enqueued_at", "dispatched_at", "completed_at", "expires_at",
"response_body",
}).AddRow(
queueID, wsID, "completed", 50, 1,
nil, "2026-01-01T00:00:00Z", "2026-01-01T00:01:00Z", "2026-01-01T00:02:00Z",
nil, respBody,
)
mock.ExpectQuery(sqlQueueStatusByID).
WithArgs(queueID).
WillReturnRows(statusRows)
r := gin.New()
r.GET("/workspaces/:id/a2a/queue/:queue_id", h.GetA2AQueueStatus)
req := httptest.NewRequest(http.MethodGet,
"/workspaces/"+wsID+"/a2a/queue/"+queueID, nil)
req.Header.Set("X-Workspace-ID", wsID)
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if w.Body.Len() == 0 {
t.Error("response body is empty")
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
@@ -63,6 +63,33 @@ func TestSessionSearchReturnsActivityAndMemory(t *testing.T) {
}
}
func TestSessionSearch_DBError(t *testing.T) {
mock := setupTestDB(t)
setupTestRedis(t)
broadcaster := newTestBroadcaster()
handler := NewActivityHandler(broadcaster)
// Simulate a DB query failure — handler must return 500.
mock.ExpectQuery("WITH session_items AS").
WithArgs("ws-123", "", 50).
WillReturnError(context.DeadlineExceeded)
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Request = httptest.NewRequest("GET", "/workspaces/ws-123/session-search", nil)
c.Request.Header.Set("Content-Type", "application/json")
c.Params = gin.Params{{Key: "id", Value: "ws-123"}}
handler.SessionSearch(c)
if w.Code != http.StatusInternalServerError {
t.Errorf("expected 500, got %d: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
// ---------- Activity List source filter ----------
func TestActivityList_SourceCanvas(t *testing.T) {
@@ -523,6 +523,42 @@ func TestDelegationRecord_InsertsActivityLogRow(t *testing.T) {
}
}
func TestDelegationRecord_DBInsertFails(t *testing.T) {
mock := setupTestDB(t)
setupTestRedis(t)
broadcaster := newTestBroadcaster()
wh := NewWorkspaceHandler(broadcaster, nil, "http://localhost:8080", t.TempDir())
h := NewDelegationHandler(wh, broadcaster)
// activity_logs INSERT fails — handler must return 500.
mock.ExpectExec("INSERT INTO activity_logs").
WithArgs(
"550e8400-e29b-41d4-a716-446655440000", // workspace_id
"550e8400-e29b-41d4-a716-446655440000", // source_id
"550e8400-e29b-41d4-a716-446655440001", // target_id
sqlmock.AnyArg(), // summary
sqlmock.AnyArg(), // request_body (jsonb)
sqlmock.AnyArg(), // response_body (jsonb)
).
WillReturnError(context.DeadlineExceeded)
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: "550e8400-e29b-41d4-a716-446655440000"}}
body := `{"target_id":"550e8400-e29b-41d4-a716-446655440001","task":"hello","delegation_id":"del-xyz"}`
c.Request = httptest.NewRequest("POST", "/delegations/record", bytes.NewBufferString(body))
c.Request.Header.Set("Content-Type", "application/json")
h.Record(c)
if w.Code != http.StatusInternalServerError {
t.Errorf("expected 500, got %d: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet expectations: %v", err)
}
}
func TestDelegationRecord_RejectsInvalidUUID(t *testing.T) {
setupTestDB(t)
setupTestRedis(t)
@@ -1,317 +0,0 @@
package handlers
import (
"database/sql"
"net/http"
"net/http/httptest"
"testing"
"github.com/DATA-DOG/go-sqlmock"
"github.com/Molecule-AI/molecule-monorepo/platform/internal/db"
"github.com/gin-gonic/gin"
)
// setupAbilitiesDB creates a sqlmock DB with QueryMatcherEqual for exact SQL matching.
func setupAbilitiesDB(t *testing.T) sqlmock.Sqlmock {
t.Helper()
mockDB, mock, err := sqlmock.New(sqlmock.QueryMatcherOption(sqlmock.QueryMatcherEqual))
if err != nil {
t.Fatalf("sqlmock.New: %v", err)
}
prevDB := db.DB
db.DB = mockDB
t.Cleanup(func() { db.DB = prevDB; mockDB.Close() })
return mock
}
// Exact SQL strings used by the production handler.
const (
sqlPatchAbilitiesExists = `SELECT EXISTS(SELECT 1 FROM workspaces WHERE id = $1 AND status != 'removed')`
sqlPatchBroadcastEnabled = `UPDATE workspaces SET broadcast_enabled = $2, updated_at = now() WHERE id = $1`
sqlPatchTalkToUserEnabled = `UPDATE workspaces SET talk_to_user_enabled = $2, updated_at = now() WHERE id = $1`
)
// ── PatchAbilities HTTP handler tests ──────────────────────────────────────────
func TestPatchAbilities_InvalidWorkspaceID_Returns400(t *testing.T) {
gin.SetMode(gin.TestMode)
setupAbilitiesDB(t)
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: "not-a-uuid"}}
c.Request = httptest.NewRequest(http.MethodPatch, "/workspaces/not-a-uuid/abilities", nil)
PatchAbilities(c)
if w.Code != http.StatusBadRequest {
t.Errorf("got %d, want 400", w.Code)
}
}
func TestPatchAbilities_InvalidBody_Returns400(t *testing.T) {
gin.SetMode(gin.TestMode)
setupAbilitiesDB(t)
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"}}
c.Request = httptest.NewRequest(http.MethodPatch,
"/workspaces/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/abilities",
newFakeCloser([]byte("not json")))
c.Request.Header.Set("Content-Type", "application/json")
PatchAbilities(c)
if w.Code != http.StatusBadRequest {
t.Errorf("got %d, want 400", w.Code)
}
}
func TestPatchAbilities_NoAbilityFields_Returns400(t *testing.T) {
gin.SetMode(gin.TestMode)
setupAbilitiesDB(t)
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"}}
c.Request = httptest.NewRequest(http.MethodPatch,
"/workspaces/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/abilities",
newFakeCloser([]byte(`{}`)))
c.Request.Header.Set("Content-Type", "application/json")
PatchAbilities(c)
if w.Code != http.StatusBadRequest {
t.Errorf("got %d, want 400", w.Code)
}
}
func TestPatchAbilities_WorkspaceNotFound_Returns404(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupAbilitiesDB(t)
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlPatchAbilitiesExists).
WithArgs(wsID).
WillReturnError(sql.ErrNoRows)
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: wsID}}
c.Request = httptest.NewRequest(http.MethodPatch, "/workspaces/"+wsID+"/abilities",
newFakeCloser([]byte(`{"broadcast_enabled":true}`)))
c.Request.Header.Set("Content-Type", "application/json")
PatchAbilities(c)
if w.Code != http.StatusNotFound {
t.Errorf("got %d, want 404: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestPatchAbilities_WorkspaceNotFound_ExistsFalse_Returns404(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupAbilitiesDB(t)
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlPatchAbilitiesExists).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(false))
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: wsID}}
c.Request = httptest.NewRequest(http.MethodPatch, "/workspaces/"+wsID+"/abilities",
newFakeCloser([]byte(`{"talk_to_user_enabled":false}`)))
c.Request.Header.Set("Content-Type", "application/json")
PatchAbilities(c)
if w.Code != http.StatusNotFound {
t.Errorf("got %d, want 404: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestPatchAbilities_UpdateBroadcastEnabled_Success(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupAbilitiesDB(t)
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlPatchAbilitiesExists).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(true))
mock.ExpectExec(sqlPatchBroadcastEnabled).
WithArgs(wsID, true).
WillReturnResult(sqlmock.NewResult(0, 1))
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: wsID}}
c.Request = httptest.NewRequest(http.MethodPatch, "/workspaces/"+wsID+"/abilities",
newFakeCloser([]byte(`{"broadcast_enabled":true}`)))
c.Request.Header.Set("Content-Type", "application/json")
PatchAbilities(c)
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestPatchAbilities_UpdateTalkToUserEnabled_Success(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupAbilitiesDB(t)
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlPatchAbilitiesExists).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(true))
mock.ExpectExec(sqlPatchTalkToUserEnabled).
WithArgs(wsID, false).
WillReturnResult(sqlmock.NewResult(0, 1))
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: wsID}}
c.Request = httptest.NewRequest(http.MethodPatch, "/workspaces/"+wsID+"/abilities",
newFakeCloser([]byte(`{"talk_to_user_enabled":false}`)))
c.Request.Header.Set("Content-Type", "application/json")
PatchAbilities(c)
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestPatchAbilities_UpdateBothAbilities_Success(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupAbilitiesDB(t)
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlPatchAbilitiesExists).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(true))
mock.ExpectExec(sqlPatchBroadcastEnabled).
WithArgs(wsID, true).
WillReturnResult(sqlmock.NewResult(0, 1))
mock.ExpectExec(sqlPatchTalkToUserEnabled).
WithArgs(wsID, false).
WillReturnResult(sqlmock.NewResult(0, 1))
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: wsID}}
c.Request = httptest.NewRequest(http.MethodPatch, "/workspaces/"+wsID+"/abilities",
newFakeCloser([]byte(`{"broadcast_enabled":true,"talk_to_user_enabled":false}`)))
c.Request.Header.Set("Content-Type", "application/json")
PatchAbilities(c)
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestPatchAbilities_BroadcastEnabledDBError_Returns500(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupAbilitiesDB(t)
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlPatchAbilitiesExists).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(true))
mock.ExpectExec(sqlPatchBroadcastEnabled).
WithArgs(wsID, true).
WillReturnError(sql.ErrConnDone)
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: wsID}}
c.Request = httptest.NewRequest(http.MethodPatch, "/workspaces/"+wsID+"/abilities",
newFakeCloser([]byte(`{"broadcast_enabled":true}`)))
c.Request.Header.Set("Content-Type", "application/json")
PatchAbilities(c)
if w.Code != http.StatusInternalServerError {
t.Errorf("got %d, want 500: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestPatchAbilities_TalkToUserEnabledDBError_Returns500(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupAbilitiesDB(t)
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlPatchAbilitiesExists).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"exists"}).AddRow(true))
mock.ExpectExec(sqlPatchTalkToUserEnabled).
WithArgs(wsID, true).
WillReturnError(sql.ErrConnDone)
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Params = gin.Params{{Key: "id", Value: wsID}}
c.Request = httptest.NewRequest(http.MethodPatch, "/workspaces/"+wsID+"/abilities",
newFakeCloser([]byte(`{"talk_to_user_enabled":true}`)))
c.Request.Header.Set("Content-Type", "application/json")
PatchAbilities(c)
if w.Code != http.StatusInternalServerError {
t.Errorf("got %d, want 500: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
// ── Helpers ────────────────────────────────────────────────────────────────────
// newFakeCloser wraps a byte slice as an io.ReadCloser for request body injection.
func newFakeCloser(data []byte) *fakeReadCloser {
return &fakeReadCloser{data: data}
}
type fakeReadCloser struct {
data []byte
pos int
}
func (f *fakeReadCloser) Read(p []byte) (n int, err error) {
if f.pos >= len(f.data) {
return 0, nil
}
n = copy(p, f.data[f.pos:])
f.pos += n
return n, nil
}
func (*fakeReadCloser) Close() error { return nil }
@@ -1,403 +0,0 @@
package handlers
import (
"database/sql"
"io"
"net/http"
"net/http/httptest"
"strings"
"testing"
"github.com/DATA-DOG/go-sqlmock"
"github.com/Molecule-AI/molecule-monorepo/platform/internal/db"
"github.com/gin-gonic/gin"
)
// broadcastBody is a convenience that returns an io.ReadCloser wrapping JSON body.
func broadcastBody(body string) io.ReadCloser {
return &broadcastFakeCloser{data: []byte(body)}
}
type broadcastFakeCloser struct {
data []byte
pos int
}
func (f *broadcastFakeCloser) Read(p []byte) (n int, err error) {
if f.pos >= len(f.data) {
return 0, io.EOF
}
n = copy(p, f.data[f.pos:])
f.pos += n
return n, nil
}
func (*broadcastFakeCloser) Close() error { return nil }
// setupBroadcastDB creates a sqlmock DB with QueryMatcherEqual.
func setupBroadcastDB(t *testing.T) sqlmock.Sqlmock {
t.Helper()
mockDB, mock, err := sqlmock.New(sqlmock.QueryMatcherOption(sqlmock.QueryMatcherEqual))
if err != nil {
t.Fatalf("sqlmock.New: %v", err)
}
prevDB := db.DB
db.DB = mockDB
t.Cleanup(func() { db.DB = prevDB; mockDB.Close() })
return mock
}
// Exact SQL strings from the production handler (whitespace must match verbatim).
const (
sqlBroadcastWorkspaceLookup = `SELECT name, broadcast_enabled FROM workspaces WHERE id = $1 AND status != 'removed'`
sqlBroadcastRecipients = `SELECT id FROM workspaces WHERE status != 'removed' AND id != $1`
sqlBroadcastReceiveInsert = `
INSERT INTO activity_logs (workspace_id, activity_type, method, source_id, summary, status)
VALUES ($1, 'broadcast_receive', 'broadcast', $2, $3, 'ok')`
sqlBroadcastSentInsert = `
INSERT INTO activity_logs (workspace_id, activity_type, method, summary, status)
VALUES ($1, 'broadcast_sent', 'broadcast', $2, 'ok')`
)
// ── Broadcast HTTP handler tests ───────────────────────────────────────────────
func TestBroadcast_InvalidWorkspaceID_Returns400(t *testing.T) {
gin.SetMode(gin.TestMode)
setupBroadcastDB(t)
h := NewBroadcastHandler(newTestBroadcaster())
r := gin.New()
r.POST("/workspaces/:id/broadcast", h.Broadcast)
req := httptest.NewRequest(http.MethodPost, "/workspaces/not-a-uuid/broadcast",
broadcastBody(`{"message":"hello"}`))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusBadRequest {
t.Errorf("got %d, want 400: %s", w.Code, w.Body.String())
}
}
func TestBroadcast_MissingMessage_Returns400(t *testing.T) {
gin.SetMode(gin.TestMode)
setupBroadcastDB(t)
h := NewBroadcastHandler(newTestBroadcaster())
r := gin.New()
r.POST("/workspaces/:id/broadcast", h.Broadcast)
req := httptest.NewRequest(http.MethodPost,
"/workspaces/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/broadcast",
broadcastBody(`{}`))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusBadRequest {
t.Errorf("got %d, want 400: %s", w.Code, w.Body.String())
}
}
func TestBroadcast_EmptyMessage_Returns400(t *testing.T) {
gin.SetMode(gin.TestMode)
setupBroadcastDB(t)
h := NewBroadcastHandler(newTestBroadcaster())
r := gin.New()
r.POST("/workspaces/:id/broadcast", h.Broadcast)
req := httptest.NewRequest(http.MethodPost,
"/workspaces/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/broadcast",
broadcastBody(`{"message":""}`))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusBadRequest {
t.Errorf("got %d, want 400: %s", w.Code, w.Body.String())
}
}
func TestBroadcast_WorkspaceNotFound_Returns404(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupBroadcastDB(t)
h := NewBroadcastHandler(newTestBroadcaster())
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlBroadcastWorkspaceLookup).
WithArgs(wsID).
WillReturnError(sql.ErrNoRows)
r := gin.New()
r.POST("/workspaces/:id/broadcast", h.Broadcast)
req := httptest.NewRequest(http.MethodPost, "/workspaces/"+wsID+"/broadcast",
broadcastBody(`{"message":"hello"}`))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusNotFound {
t.Errorf("got %d, want 404: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestBroadcast_BroadcastDisabled_Returns403(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupBroadcastDB(t)
h := NewBroadcastHandler(newTestBroadcaster())
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlBroadcastWorkspaceLookup).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"name", "broadcast_enabled"}).
AddRow("test-workspace", false))
r := gin.New()
r.POST("/workspaces/:id/broadcast", h.Broadcast)
req := httptest.NewRequest(http.MethodPost, "/workspaces/"+wsID+"/broadcast",
broadcastBody(`{"message":"hello"}`))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusForbidden {
t.Errorf("got %d, want 403: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestBroadcast_NoRecipients_Success(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupBroadcastDB(t)
h := NewBroadcastHandler(newTestBroadcaster())
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlBroadcastWorkspaceLookup).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"name", "broadcast_enabled"}).
AddRow("test-workspace", true))
// No recipients (sender is the only non-removed workspace)
mock.ExpectQuery(sqlBroadcastRecipients).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"id"}))
// Sender's own activity log: 2 args (workspaceID, summary)
mock.ExpectExec(sqlBroadcastSentInsert).
WithArgs(wsID, sqlmock.AnyArg()).
WillReturnResult(sqlmock.NewResult(0, 1))
r := gin.New()
r.POST("/workspaces/:id/broadcast", h.Broadcast)
req := httptest.NewRequest(http.MethodPost, "/workspaces/"+wsID+"/broadcast",
broadcastBody(`{"message":"hello everyone"}`))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestBroadcast_WithRecipients_Success_DeliversToAll(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupBroadcastDB(t)
h := NewBroadcastHandler(newTestBroadcaster())
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
recipient1 := "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
recipient2 := "cccccccc-cccc-cccc-cccc-cccccccccccc"
mock.ExpectQuery(sqlBroadcastWorkspaceLookup).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"name", "broadcast_enabled"}).
AddRow("broadcaster-ws", true))
mock.ExpectQuery(sqlBroadcastRecipients).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"id"}).
AddRow(recipient1).
AddRow(recipient2))
// broadcast_receive: 3 args (recipientID, senderID, summary)
mock.ExpectExec(sqlBroadcastReceiveInsert).
WithArgs(recipient1, sqlmock.AnyArg(), sqlmock.AnyArg()).
WillReturnResult(sqlmock.NewResult(0, 1))
mock.ExpectExec(sqlBroadcastReceiveInsert).
WithArgs(recipient2, sqlmock.AnyArg(), sqlmock.AnyArg()).
WillReturnResult(sqlmock.NewResult(0, 1))
// broadcast_sent: 2 args (workspaceID, summary)
mock.ExpectExec(sqlBroadcastSentInsert).
WithArgs(wsID, sqlmock.AnyArg()).
WillReturnResult(sqlmock.NewResult(0, 1))
r := gin.New()
r.POST("/workspaces/:id/broadcast", h.Broadcast)
req := httptest.NewRequest(http.MethodPost, "/workspaces/"+wsID+"/broadcast",
broadcastBody(`{"message":"hello team"}`))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestBroadcast_RecipientInsertError_ContinuesAndSucceeds(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupBroadcastDB(t)
h := NewBroadcastHandler(newTestBroadcaster())
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
recipient1 := "bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb"
recipient2 := "cccccccc-cccc-cccc-cccc-cccccccccccc"
mock.ExpectQuery(sqlBroadcastWorkspaceLookup).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"name", "broadcast_enabled"}).
AddRow("broadcaster-ws", true))
mock.ExpectQuery(sqlBroadcastRecipients).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"id"}).
AddRow(recipient1).
AddRow(recipient2))
// First recipient insert fails — handler logs and continues
mock.ExpectExec(sqlBroadcastReceiveInsert).
WithArgs(recipient1, sqlmock.AnyArg(), sqlmock.AnyArg()).
WillReturnError(sql.ErrConnDone)
// Second recipient succeeds
mock.ExpectExec(sqlBroadcastReceiveInsert).
WithArgs(recipient2, sqlmock.AnyArg(), sqlmock.AnyArg()).
WillReturnResult(sqlmock.NewResult(0, 1))
mock.ExpectExec(sqlBroadcastSentInsert).
WithArgs(wsID, sqlmock.AnyArg()).
WillReturnResult(sqlmock.NewResult(0, 1))
r := gin.New()
r.POST("/workspaces/:id/broadcast", h.Broadcast)
req := httptest.NewRequest(http.MethodPost, "/workspaces/"+wsID+"/broadcast",
broadcastBody(`{"message":"partial delivery"}`))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
func TestBroadcast_SenderActivityLogError_StillReturns200(t *testing.T) {
gin.SetMode(gin.TestMode)
mock := setupBroadcastDB(t)
h := NewBroadcastHandler(newTestBroadcaster())
wsID := "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
mock.ExpectQuery(sqlBroadcastWorkspaceLookup).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"name", "broadcast_enabled"}).
AddRow("broadcaster-ws", true))
mock.ExpectQuery(sqlBroadcastRecipients).
WithArgs(wsID).
WillReturnRows(sqlmock.NewRows([]string{"id"}))
mock.ExpectExec(sqlBroadcastSentInsert).
WithArgs(wsID, sqlmock.AnyArg()).
WillReturnError(sql.ErrConnDone)
r := gin.New()
r.POST("/workspaces/:id/broadcast", h.Broadcast)
req := httptest.NewRequest(http.MethodPost, "/workspaces/"+wsID+"/broadcast",
broadcastBody(`{"message":"hello"}`))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
r.ServeHTTP(w, req)
// Handler logs error but still returns 200
if w.Code != http.StatusOK {
t.Errorf("got %d, want 200: %s", w.Code, w.Body.String())
}
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet sqlmock expectations: %v", err)
}
}
// ── broadcastTruncate pure function tests ─────────────────────────────────────
func TestBroadcastTruncate_UnderLimit(t *testing.T) {
input := "short message"
got := broadcastTruncate(input, 50)
if got != input {
t.Errorf("broadcastTruncate(%q, 50) = %q, want %q", input, got, input)
}
}
func TestBroadcastTruncate_ExactlyAtLimit(t *testing.T) {
input := "exactly fifty char"
got := broadcastTruncate(input, 18)
if got != input {
t.Errorf("broadcastTruncate(%q, 18) = %q, want %q", input, got, input)
}
}
func TestBroadcastTruncate_OverLimit_TruncatesAndAddsEllipsis(t *testing.T) {
// 150 ASCII chars → over 120 rune limit → truncate to 120 + ellipsis
input := strings.Repeat("x", 150)
got := broadcastTruncate(input, 120)
if len([]rune(got)) != 121 { // 120 + 1 ellipsis rune
t.Errorf("len(broadcastTruncate) = %d, want 121 (120 + ellipsis)", len([]rune(got)))
}
if got[:len(got)-len("…")] != strings.Repeat("x", 120) {
t.Errorf("broadcastTruncate did not truncate correctly")
}
}
func TestBroadcastTruncate_UnicodeChars_TreatsAsRunes(t *testing.T) {
// Each emoji is 1 rune but multiple bytes. 50 emojis > 30 limit.
input := strings.Repeat("🎉", 50)
got := broadcastTruncate(input, 30)
if len([]rune(got)) != 31 { // 30 + ellipsis
t.Errorf("len(broadcastTruncate with emoji) = %d, want 31", len([]rune(got)))
}
}
func TestBroadcastTruncate_ZeroLimit_ReturnsEllipsis(t *testing.T) {
got := broadcastTruncate("hello", 0)
if got != "…" {
t.Errorf("broadcastTruncate with max=0 = %q, want …", got)
}
}