Compare commits
3 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
 core-devops
|
751c98ced7 | ||
|
core-devops
|
120d5328ba | ||
|
core-devops
|
798fcb1f33 |
@@ -49,11 +49,11 @@ if [ "$MERGED" != "true" ]; then
|
||||
exit 0
|
||||
fi
|
||||
|
||||
MERGE_SHA=$(echo "$PR" | jq -r '.merge_commit_sha // empty') || true
|
||||
MERGED_BY=$(echo "$PR" | jq -r '.merged_by.login // "unknown"') || true
|
||||
TITLE=$(echo "$PR" | jq -r '.title // ""') || true
|
||||
BASE_BRANCH=$(echo "$PR" | jq -r '.base.ref // "main"') || true
|
||||
HEAD_SHA=$(echo "$PR" | jq -r '.head.sha // empty') || true
|
||||
MERGE_SHA=$(echo "$PR" | jq -r '.merge_commit_sha // empty')
|
||||
MERGED_BY=$(echo "$PR" | jq -r '.merged_by.login // "unknown"')
|
||||
TITLE=$(echo "$PR" | jq -r '.title // ""')
|
||||
BASE_BRANCH=$(echo "$PR" | jq -r '.base.ref // "main"')
|
||||
HEAD_SHA=$(echo "$PR" | jq -r '.head.sha // empty')
|
||||
|
||||
if [ -z "$MERGE_SHA" ]; then
|
||||
echo "::warning::PR #${PR_NUMBER} merged=true but no merge_commit_sha — cannot evaluate force-merge."
|
||||
@@ -75,7 +75,7 @@ STATUS=$(curl -sS -H "$AUTH" \
|
||||
declare -A CHECK_STATE
|
||||
while IFS=$'\t' read -r ctx state; do
|
||||
[ -n "$ctx" ] && CHECK_STATE[$ctx]="$state"
|
||||
done < <(echo "$STATUS" | jq -r '.statuses // [] | .[] | "\(.context)\t\(.status)"') || true
|
||||
done < <(echo "$STATUS" | jq -r '.statuses // [] | .[] | "\(.context)\t\(.status)"')
|
||||
|
||||
# 4. For each required check, was it green at merge? YAML block scalars
|
||||
# (`|`) leave a trailing newline; skip blank/whitespace-only lines.
|
||||
@@ -97,7 +97,7 @@ fi
|
||||
|
||||
# 5. Emit structured audit event.
|
||||
NOW=$(date -u +%Y-%m-%dT%H:%M:%SZ)
|
||||
FAILED_JSON=$(printf '%s\n' "${FAILED_CHECKS[@]}" | jq -R . | jq -s .) || true
|
||||
FAILED_JSON=$(printf '%s\n' "${FAILED_CHECKS[@]}" | jq -R . | jq -s .)
|
||||
|
||||
# Print as a single-line JSON so Vector's parse_json transform can pick
|
||||
# it up cleanly from docker_logs.
|
||||
|
||||
@@ -301,19 +301,7 @@ def expected_context(job_key: str, workflow_name: str = "ci") -> str:
|
||||
# Drift detection
|
||||
# --------------------------------------------------------------------------
|
||||
def detect_drift(branch: str) -> tuple[list[str], dict]:
|
||||
"""Returns (findings, debug). Empty findings == no drift.
|
||||
|
||||
Raises:
|
||||
ApiError: propagated from the protection fetch only when the
|
||||
failure is likely a transient Gitea outage (5xx).
|
||||
403/404 from the protection endpoint is treated as
|
||||
"cannot determine drift for this branch" — a token-
|
||||
scope issue (missing repo-admin on DRIFT_BOT_TOKEN) or
|
||||
a repo with no protection set should not turn the
|
||||
hourly cron red. The workflow continues to the next
|
||||
branch; no [ci-drift] issue is filed for a branch
|
||||
whose protection cannot be read.
|
||||
"""
|
||||
"""Returns (findings, debug). Empty findings == no drift."""
|
||||
findings: list[str] = []
|
||||
|
||||
ci_doc = load_yaml(CI_WORKFLOW_PATH)
|
||||
@@ -325,50 +313,9 @@ def detect_drift(branch: str) -> tuple[list[str], dict]:
|
||||
env_set = required_checks_env(audit_doc)
|
||||
|
||||
# Protection
|
||||
# api() raises ApiError on non-2xx. Transient 5xx should fail loud.
|
||||
# 403/404 means the token lacks repo-admin scope (Gitea 1.22.6's
|
||||
# branch_protections endpoint requires it — see DRIFT_BOT_TOKEN
|
||||
# provisioning trail in ci-required-drift.yml). Treat as
|
||||
# "cannot determine drift for this branch" — skip without turning
|
||||
# the workflow red. Surface a clear diagnostic so the operator
|
||||
# knows what to fix.
|
||||
contexts: set[str] = set()
|
||||
protection_path = f"/repos/{OWNER}/{NAME}/branch_protections/{branch}"
|
||||
try:
|
||||
_, protection = api("GET", protection_path)
|
||||
except ApiError as e:
|
||||
# Isolate the HTTP status from the error message.
|
||||
http_status: int | None = None
|
||||
msg = str(e)
|
||||
# ApiError message format: "{method} {path} → HTTP {status}: {body}"
|
||||
import re as _re
|
||||
|
||||
m = _re.search(r"HTTP (\d{3})", msg)
|
||||
if m:
|
||||
http_status = int(m.group(1))
|
||||
if http_status in (403, 404):
|
||||
# Token lacks scope OR branch has no protection. Cannot
|
||||
# determine drift — skip this branch. Do NOT exit non-zero;
|
||||
# the issue IS the alarm, not a red workflow.
|
||||
sys.stderr.write(
|
||||
f"::error::GET {protection_path} returned HTTP {http_status} — "
|
||||
f"DRIFT_BOT_TOKEN lacks repo-admin scope (Gitea 1.22.6 "
|
||||
f"requires it for this endpoint) OR branch has no protection "
|
||||
f"configured. Cannot determine drift for {branch}; "
|
||||
f"skipping. Fix: grant repo-admin to mc-drift-bot or "
|
||||
f"configure protection on {branch}.\n"
|
||||
)
|
||||
debug = {
|
||||
"branch": branch,
|
||||
"ci_jobs": sorted(jobs),
|
||||
"sentinel_needs": sorted(needs),
|
||||
"protection_contexts_skipped": True,
|
||||
"protection_http_status": http_status,
|
||||
"audit_env_checks": sorted(env_set),
|
||||
}
|
||||
return [], debug
|
||||
# 5xx — propagate (transient outage, fail loud per design).
|
||||
raise
|
||||
# api() raises ApiError on non-2xx; let it propagate so a transient
|
||||
# 500 fails the run loudly rather than producing a "no drift" lie.
|
||||
_, protection = api("GET", f"/repos/{OWNER}/{NAME}/branch_protections/{branch}")
|
||||
if not isinstance(protection, dict):
|
||||
sys.stderr.write(
|
||||
f"::error::protection response for {branch} not a JSON object\n"
|
||||
|
||||
@@ -1,40 +0,0 @@
|
||||
#!/usr/bin/env python3
|
||||
"""Extract changed-file list from Gitea Compare API JSON response.
|
||||
|
||||
Gitea Compare API returns changed files nested inside commits, not at the
|
||||
top level:
|
||||
{"commits": [{"files": [{"filename": "path/to/file"}]}]}
|
||||
|
||||
Usage:
|
||||
compare-api-diff-files.py < API_RESPONSE.json
|
||||
|
||||
Exits 0 with filenames on stdout, one per line.
|
||||
Exits 1 on malformed input (caller should handle as "no files").
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import sys
|
||||
import json
|
||||
|
||||
|
||||
def main() -> None:
|
||||
try:
|
||||
data = json.load(sys.stdin)
|
||||
except Exception:
|
||||
sys.exit(1)
|
||||
|
||||
filenames: list[str] = []
|
||||
for commit in data.get("commits", []):
|
||||
for f in commit.get("files", []):
|
||||
fn = f.get("filename", "")
|
||||
if fn:
|
||||
filenames.append(fn)
|
||||
|
||||
if filenames:
|
||||
sys.stdout.write("\n".join(filenames))
|
||||
sys.stdout.write("\n")
|
||||
# else: empty stdout = no files, caller treats as empty list
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
@@ -222,20 +222,9 @@ def is_red(status: dict) -> tuple[bool, list[dict]]:
|
||||
combined = status.get("state")
|
||||
statuses = status.get("statuses") or []
|
||||
red_states = {"failure", "error"}
|
||||
# Schema asymmetry: top-level combined uses `state`, but per-entry
|
||||
# items in `statuses[]` use `status` in Gitea 1.22.6. Prefer
|
||||
# `status`; fall back to `state` defensively. Verified empirically
|
||||
# 2026-05-12 03:42Z. Pre-rev4 code only read `state` from per-entry
|
||||
# items → failed[] always empty → render_body always showed the
|
||||
# "no per-context entries were in a red state" fallback even when
|
||||
# the combined-state correctly flagged red. See
|
||||
# `feedback_smoke_test_vendor_truth_not_shape_match`.
|
||||
def _entry_state(s: dict) -> str:
|
||||
return s.get("status") or s.get("state") or ""
|
||||
|
||||
failed = [
|
||||
s for s in statuses
|
||||
if isinstance(s, dict) and _entry_state(s) in red_states
|
||||
if isinstance(s, dict) and s.get("state") in red_states
|
||||
]
|
||||
return (combined in red_states or bool(failed), failed)
|
||||
|
||||
@@ -324,9 +313,7 @@ def render_body(sha: str, failed: list[dict], debug: dict) -> str:
|
||||
else:
|
||||
for s in failed:
|
||||
ctx = s.get("context", "(no context)")
|
||||
# Per-entry key is `status` in Gitea 1.22.6, not `state`
|
||||
# (see _entry_state in is_red). Fallback for forward-compat.
|
||||
state = s.get("status") or s.get("state") or "(no state)"
|
||||
state = s.get("state", "(no state)")
|
||||
url = s.get("target_url") or ""
|
||||
desc = (s.get("description") or "").strip()
|
||||
entry = f"- **{ctx}** — `{state}`"
|
||||
@@ -559,11 +546,7 @@ def run_once(*, dry_run: bool = False) -> int:
|
||||
"combined_state": status.get("state"),
|
||||
"failed_contexts": [s.get("context") for s in failed],
|
||||
"all_contexts": [
|
||||
# Per-entry key is `status` in Gitea 1.22.6, not `state`.
|
||||
# Pre-rev4 debug output reported `state: None` for every
|
||||
# context, making run logs useless for triage.
|
||||
{"context": s.get("context"),
|
||||
"state": s.get("status") or s.get("state")}
|
||||
{"context": s.get("context"), "state": s.get("state")}
|
||||
for s in (status.get("statuses") or [])
|
||||
if isinstance(s, dict)
|
||||
],
|
||||
|
||||
@@ -1,42 +0,0 @@
|
||||
#!/usr/bin/env python3
|
||||
"""Extract changed-file list from a Gitea push event's commits JSON array.
|
||||
|
||||
Each commit in a push event has `added`, `removed`, and `modified` file lists.
|
||||
This script aggregates all of them and prints unique filenames one per line.
|
||||
|
||||
Usage:
|
||||
push-commits-diff-files.py < COMMITS_JSON
|
||||
|
||||
Exits 0 always (caller handles empty output as "no files").
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import sys
|
||||
import json
|
||||
|
||||
|
||||
def main() -> None:
|
||||
try:
|
||||
data = json.load(sys.stdin)
|
||||
except Exception:
|
||||
sys.exit(0) # Don't fail the step — treat malformed JSON as empty
|
||||
|
||||
if not isinstance(data, list):
|
||||
sys.exit(0)
|
||||
|
||||
files: set[str] = set()
|
||||
for commit in data:
|
||||
if not isinstance(commit, dict):
|
||||
continue
|
||||
for key in ("added", "removed", "modified"):
|
||||
for f in commit.get(key) or []:
|
||||
if isinstance(f, str) and f:
|
||||
files.add(f)
|
||||
|
||||
if files:
|
||||
sys.stdout.write("\n".join(sorted(files)))
|
||||
sys.stdout.write("\n")
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
@@ -1,203 +0,0 @@
|
||||
#!/usr/bin/env bash
|
||||
# review-check — evaluate whether a PR satisfies a single team-review gate.
|
||||
#
|
||||
# RFC#324 Step 1 of 5 — qa-review + security-review check workflows.
|
||||
#
|
||||
# This is the shared evaluator invoked by:
|
||||
# .gitea/workflows/qa-review.yml (TEAM=qa, TEAM_ID=20)
|
||||
# .gitea/workflows/security-review.yml (TEAM=security, TEAM_ID=21)
|
||||
#
|
||||
# Pass condition (per RFC#324 v1.1 addendum):
|
||||
# ≥ 1 review on the PR where:
|
||||
# • state == APPROVED
|
||||
# • review.dismissed == false
|
||||
# • review.user.login != PR.user.login (non-author)
|
||||
# • review.user.login ∈ team-members
|
||||
#
|
||||
# Strict mode (default OFF for v1; see RFC trade-off note):
|
||||
# If REVIEW_CHECK_STRICT=1, additionally require review.commit_id == PR.head.sha.
|
||||
# With dismiss_stale_reviews: true at the protection layer, stale reviews
|
||||
# are already dismissed, so the additional commit_id check is belt-and-
|
||||
# suspenders. Keeping it off in v1 simplifies semantics; flip in a follow-up
|
||||
# PR if reviewer telemetry shows residual stale-APPROVE merges.
|
||||
#
|
||||
# Privilege gate (RFC#324 v1.3 §A1.1 — INFORMATIONAL ONLY):
|
||||
# The /qa-recheck and /security-recheck slash-commands can be triggered
|
||||
# by anyone who can comment on the PR. The workflow's privilege step
|
||||
# logs collaborator-status but does NOT gate execution of this script.
|
||||
# Why this is safe: this evaluator is read-only and idempotent —
|
||||
# reading `pulls/{N}/reviews` and `teams/{id}/members/{u}` can't be
|
||||
# influenced by who triggered the run. If a real team-member APPROVE
|
||||
# exists the gate flips green; otherwise it stays red. A
|
||||
# non-collaborator commenting /qa-recheck cannot manufacture a green
|
||||
# gate. Original (v1.2) design with `if:`-gating of this step was
|
||||
# fail-open (skipped-via-`if:` job still publishes the status as
|
||||
# `success`) — corrected in v1.3 per hongming-pc review 1421.
|
||||
#
|
||||
# Trust boundary (RFC A4):
|
||||
# This script is loaded from the BASE branch (sourced via .gitea/scripts/
|
||||
# on the workflow's checkout-of-base). It does NOT execute any PR-HEAD
|
||||
# code. It only reads PR review state via the Gitea API.
|
||||
#
|
||||
# Token scope (RFC A1-α):
|
||||
# The job's own conclusion (exit 0 / exit 1) is what publishes the
|
||||
# `qa-review / approved` / `security-review / approved` status context.
|
||||
# NO `POST /statuses` call here → NO `write:repository` scope on the
|
||||
# token. `read:organization` (for team-membership probe) and
|
||||
# `read:repository` (for PR + reviews) are enough.
|
||||
#
|
||||
# Required env:
|
||||
# GITEA_TOKEN — least-priv read:repository + read:organization. See note
|
||||
# below about the team-membership API requiring the token
|
||||
# owner to be in the queried team (Gitea 1.22.6 quirk).
|
||||
# GITEA_HOST — e.g. git.moleculesai.app
|
||||
# REPO — owner/name (from github.repository)
|
||||
# PR_NUMBER — int (from github.event.pull_request.number or
|
||||
# github.event.issue.number for issue_comment events)
|
||||
# TEAM — short team name (qa | security) for log lines
|
||||
# TEAM_ID — Gitea team id (20=qa, 21=security at time of writing)
|
||||
#
|
||||
# Optional:
|
||||
# REVIEW_CHECK_DEBUG=1 — per-API-call diagnostic lines
|
||||
# REVIEW_CHECK_STRICT=1 — also require review.commit_id == pr.head.sha
|
||||
|
||||
set -euo pipefail
|
||||
|
||||
# jq is required for JSON parsing. It is pre-baked into the runner-base
|
||||
# image (per RFC#268 workflow-smoke), so the only reason we'd not find it
|
||||
# is a broken runner. The previous fallback dance (apt-get + curl to
|
||||
# /usr/local/bin/jq) cannot succeed on a uid-1001 rootless runner
|
||||
# (#391/#402 + feedback_ci_runner_install_needs_writable_path), so it's
|
||||
# dropped. Fail loud with a clear diagnostic rather than attempt an
|
||||
# install that physically cannot work.
|
||||
if ! command -v jq >/dev/null 2>&1; then
|
||||
echo "::error::jq missing from runner-base image — bake it into the runner image (see RFC#268 workflow-smoke / feedback_ci_runner_install_needs_writable_path). This evaluator cannot run without jq."
|
||||
exit 1
|
||||
fi
|
||||
|
||||
: "${GITEA_TOKEN:?GITEA_TOKEN required}"
|
||||
: "${GITEA_HOST:?GITEA_HOST required}"
|
||||
: "${REPO:?REPO required (owner/name)}"
|
||||
: "${PR_NUMBER:?PR_NUMBER required}"
|
||||
: "${TEAM:?TEAM required (qa|security)}"
|
||||
: "${TEAM_ID:?TEAM_ID required (integer)}"
|
||||
|
||||
OWNER="${REPO%%/*}"
|
||||
NAME="${REPO##*/}"
|
||||
API="https://${GITEA_HOST}/api/v1"
|
||||
|
||||
# Token-in-argv fix (#541): write the Authorization header to a mode-600
|
||||
# temp file instead of passing it via curl -H "$AUTH" (which puts the
|
||||
# secret token value in the process table for any process to read via
|
||||
# /proc/<pid>/cmdline or ps -ef). The curl config file is read by curl
|
||||
# itself and never appears in the argv of the curl subprocess.
|
||||
CURL_AUTH_FILE=$(mktemp -p /tmp curl-auth.XXXXXX)
|
||||
chmod 600 "$CURL_AUTH_FILE"
|
||||
printf 'header = "Authorization: token %s"\n' "$GITEA_TOKEN" > "$CURL_AUTH_FILE"
|
||||
|
||||
# Pre-create temp files so cleanup trap can reference them by name
|
||||
# (bash trap 'function' EXIT expands variables at trap-fire time, not def time).
|
||||
PR_JSON=$(mktemp)
|
||||
REVIEWS_JSON=$(mktemp)
|
||||
TEAM_PROBE_TMP=$(mktemp)
|
||||
|
||||
cleanup() {
|
||||
rm -f "$CURL_AUTH_FILE" "$PR_JSON" "$REVIEWS_JSON" "$TEAM_PROBE_TMP"
|
||||
}
|
||||
trap cleanup EXIT
|
||||
|
||||
debug() {
|
||||
if [ "${REVIEW_CHECK_DEBUG:-}" = "1" ]; then
|
||||
echo " [debug] $*" >&2
|
||||
fi
|
||||
}
|
||||
|
||||
echo "::notice::${TEAM}-review evaluating repo=${OWNER}/${NAME} pr=${PR_NUMBER} team_id=${TEAM_ID}"
|
||||
|
||||
# --- Fetch the PR (for author + head.sha) ---
|
||||
HTTP_CODE=$(curl -sS -o "$PR_JSON" -w '%{http_code}' \
|
||||
-K "$CURL_AUTH_FILE" "${API}/repos/${OWNER}/${NAME}/pulls/${PR_NUMBER}")
|
||||
if [ "$HTTP_CODE" != "200" ]; then
|
||||
echo "::error::GET /pulls/${PR_NUMBER} returned HTTP ${HTTP_CODE} (token scope?)"
|
||||
cat "$PR_JSON" >&2
|
||||
exit 1
|
||||
fi
|
||||
PR_AUTHOR=$(jq -r '.user.login // ""' "$PR_JSON")
|
||||
PR_HEAD_SHA=$(jq -r '.head.sha // ""' "$PR_JSON")
|
||||
PR_STATE=$(jq -r '.state // ""' "$PR_JSON")
|
||||
debug "pr_author=${PR_AUTHOR} pr_head=${PR_HEAD_SHA:0:7} pr_state=${PR_STATE}"
|
||||
|
||||
if [ "$PR_STATE" != "open" ]; then
|
||||
echo "::notice::PR ${PR_NUMBER} is ${PR_STATE} — exiting 0 (closed PRs do not gate)"
|
||||
exit 0
|
||||
fi
|
||||
if [ -z "$PR_AUTHOR" ] || [ -z "$PR_HEAD_SHA" ]; then
|
||||
echo "::error::PR ${PR_NUMBER} missing user.login or head.sha — webhook payload malformed"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# --- Fetch all reviews on the PR ---
|
||||
HTTP_CODE=$(curl -sS -o "$REVIEWS_JSON" -w '%{http_code}' \
|
||||
-K "$CURL_AUTH_FILE" "${API}/repos/${OWNER}/${NAME}/pulls/${PR_NUMBER}/reviews")
|
||||
if [ "$HTTP_CODE" != "200" ]; then
|
||||
echo "::error::GET /pulls/${PR_NUMBER}/reviews returned HTTP ${HTTP_CODE}"
|
||||
cat "$REVIEWS_JSON" >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# Filter: state=APPROVED, not-dismissed, non-author. Optionally strict-mode
|
||||
# adds commit_id==head.sha (off by default; see header).
|
||||
JQ_FILTER='.[]
|
||||
| select(.state == "APPROVED")
|
||||
| select(.dismissed != true)
|
||||
| select(.user.login != $author)'
|
||||
if [ "${REVIEW_CHECK_STRICT:-}" = "1" ]; then
|
||||
JQ_FILTER="${JQ_FILTER}
|
||||
| select(.commit_id == \$head)"
|
||||
fi
|
||||
JQ_FILTER="${JQ_FILTER}
|
||||
| .user.login"
|
||||
|
||||
CANDIDATES=$(jq -r --arg author "$PR_AUTHOR" --arg head "$PR_HEAD_SHA" "$JQ_FILTER" "$REVIEWS_JSON" | sort -u)
|
||||
debug "candidate non-author approvers: $(echo "$CANDIDATES" | tr '\n' ' ')"
|
||||
|
||||
if [ -z "$CANDIDATES" ]; then
|
||||
echo "::error::${TEAM}-review awaiting non-author APPROVE from ${TEAM} team (no candidates yet)"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# --- Probe team membership per candidate ---
|
||||
# Endpoint: GET /api/v1/teams/{id}/members/{username}
|
||||
# 200/204 → is member
|
||||
# 403 → token owner is not in this team (Gitea 1.22.6 'Must be a team
|
||||
# member' constraint — see follow-up issue for token-provisioning)
|
||||
# 404 → not a member
|
||||
for U in $CANDIDATES; do
|
||||
CODE=$(curl -sS -o "$TEAM_PROBE_TMP" -w '%{http_code}' \
|
||||
-K "$CURL_AUTH_FILE" "${API}/teams/${TEAM_ID}/members/${U}")
|
||||
debug "probe ${U} in team ${TEAM} (id=${TEAM_ID}) → HTTP ${CODE}"
|
||||
case "$CODE" in
|
||||
200|204)
|
||||
echo "::notice::${TEAM}-review APPROVED by ${U} (team=${TEAM})"
|
||||
exit 0
|
||||
;;
|
||||
403)
|
||||
# Token owner is not in the team being probed; the API refuses to
|
||||
# confirm membership. This is the RFC#324 follow-up token-scope gap.
|
||||
# Fail closed — never grant approval on a 403; surface clearly.
|
||||
echo "::error::team-probe for ${U} in ${TEAM} returned 403 (token owner not in ${TEAM} team — RFC#324 token-scope follow-up). Cannot confirm membership; failing closed."
|
||||
cat "$TEAM_PROBE_TMP" >&2
|
||||
exit 1
|
||||
;;
|
||||
404)
|
||||
debug "${U} not a member of ${TEAM}"
|
||||
;;
|
||||
*)
|
||||
echo "::warning::team-probe for ${U} in ${TEAM} returned unexpected HTTP ${CODE}"
|
||||
cat "$TEAM_PROBE_TMP" >&2
|
||||
;;
|
||||
esac
|
||||
done
|
||||
|
||||
echo "::error::${TEAM}-review awaiting non-author APPROVE from ${TEAM} team (candidates: $(echo "$CANDIDATES" | tr '\n' ',' | sed 's/,$//') — none are in team)"
|
||||
exit 1
|
||||
@@ -96,27 +96,16 @@ API="https://${GITEA_HOST}/api/v1"
|
||||
AUTH="Authorization: token ${GITEA_TOKEN}"
|
||||
echo "::notice::tier-check start: repo=$OWNER/$NAME pr=$PR_NUMBER author=$PR_AUTHOR"
|
||||
|
||||
# Sanity: token resolves to a user.
|
||||
# Use || true on the jq pipeline so that set -euo pipefail (line 45) does not
|
||||
# cause the script to exit prematurely when the token is empty/invalid — the
|
||||
# if check below handles that case gracefully. Without || true, a 401 from an
|
||||
# empty/invalid token causes jq to exit 1, triggering set -e and exiting the
|
||||
# entire script before SOP_FAIL_OPEN can be evaluated (the check is in the jq-
|
||||
# install block; if jq is already on PATH, that block is skipped entirely).
|
||||
WHOAMI=$(curl -sS -H "$AUTH" "${API}/user" | jq -r '.login // ""') || true
|
||||
# Sanity: token resolves to a user
|
||||
WHOAMI=$(curl -sS -H "$AUTH" "${API}/user" | jq -r '.login // ""')
|
||||
if [ -z "$WHOAMI" ]; then
|
||||
echo "::error::GITEA_TOKEN cannot resolve a user via /api/v1/user — check the token scope and that the secret is wired correctly."
|
||||
if [ "${SOP_FAIL_OPEN:-}" = "1" ]; then
|
||||
echo "::warning::SOP_FAIL_OPEN=1 — exiting 0 so CI does not block."
|
||||
exit 0
|
||||
fi
|
||||
exit 1
|
||||
fi
|
||||
echo "::notice::token resolves to user: $WHOAMI"
|
||||
|
||||
# 1. Read tier label. || true ensures set -euo pipefail does not abort the
|
||||
# script if curl or jq fails (e.g. 401 from empty token).
|
||||
LABELS=$(curl -sS -H "$AUTH" "${API}/repos/${OWNER}/${NAME}/issues/${PR_NUMBER}/labels" | jq -r '.[].name') || true
|
||||
# 1. Read tier label
|
||||
LABELS=$(curl -sS -H "$AUTH" "${API}/repos/${OWNER}/${NAME}/issues/${PR_NUMBER}/labels" | jq -r '.[].name')
|
||||
TIER=""
|
||||
for L in $LABELS; do
|
||||
case "$L" in
|
||||
@@ -187,25 +176,17 @@ fi
|
||||
# 4. Resolve all team names → IDs
|
||||
# /orgs/{org}/teams/{slug}/... endpoints don't exist on Gitea 1.22;
|
||||
# we use /teams/{id}.
|
||||
# set +e prevents set -e from aborting the script if curl fails (e.g. empty token).
|
||||
ORG_TEAMS_FILE=$(mktemp)
|
||||
trap 'rm -f "$ORG_TEAMS_FILE"' EXIT
|
||||
set +e
|
||||
HTTP_CODE=$(curl -sS -o "$ORG_TEAMS_FILE" -w '%{http_code}' -H "$AUTH" \
|
||||
"${API}/orgs/${OWNER}/teams")
|
||||
_HTTP_EXIT=$?
|
||||
set -e
|
||||
debug "teams-list HTTP=$HTTP_CODE (curl exit=$_HTTP_EXIT) size=$(wc -c <"$ORG_TEAMS_FILE")"
|
||||
debug "teams-list HTTP=$HTTP_CODE size=$(wc -c <"$ORG_TEAMS_FILE")"
|
||||
if [ "${SOP_DEBUG:-}" = "1" ]; then
|
||||
echo " [debug] teams-list body (first 300 chars):" >&2
|
||||
head -c 300 "$ORG_TEAMS_FILE" >&2; echo >&2
|
||||
fi
|
||||
if [ "$_HTTP_EXIT" -ne 0 ] || [ "$HTTP_CODE" != "200" ]; then
|
||||
echo "::error::GET /orgs/${OWNER}/teams failed (curl exit=$_HTTP_EXIT HTTP=$HTTP_CODE) — token may lack read:org scope or be invalid."
|
||||
if [ "${SOP_FAIL_OPEN:-}" = "1" ]; then
|
||||
echo "::warning::SOP_FAIL_OPEN=1 — exiting 0 so CI does not block."
|
||||
exit 0
|
||||
fi
|
||||
if [ "$HTTP_CODE" != "200" ]; then
|
||||
echo "::error::GET /orgs/${OWNER}/teams returned HTTP $HTTP_CODE — token likely lacks read:org scope."
|
||||
exit 1
|
||||
fi
|
||||
|
||||
@@ -250,22 +231,9 @@ for _t in $_all_teams; do
|
||||
debug "team-id: $_t → $_id"
|
||||
done
|
||||
|
||||
# 5. Read approving reviewers. set +e disables set -e temporarily so that curl
|
||||
# failures (e.g. empty/invalid token → HTTP 401) do not abort the script before
|
||||
# SOP_FAIL_OPEN is evaluated. set -e is restored immediately after.
|
||||
set +e
|
||||
# 5. Read approving reviewers
|
||||
REVIEWS=$(curl -sS -H "$AUTH" "${API}/repos/${OWNER}/${NAME}/pulls/${PR_NUMBER}/reviews")
|
||||
_REVIEWS_EXIT=$?
|
||||
set -e
|
||||
if [ $_REVIEWS_EXIT -ne 0 ] || [ -z "$REVIEWS" ]; then
|
||||
echo "::error::Failed to fetch reviews (curl exit=$_REVIEWS_EXIT) — token may be invalid or unreachable."
|
||||
if [ "${SOP_FAIL_OPEN:-}" = "1" ]; then
|
||||
echo "::warning::SOP_FAIL_OPEN=1 — exiting 0 so CI does not block."
|
||||
exit 0
|
||||
fi
|
||||
exit 1
|
||||
fi
|
||||
APPROVERS=$(echo "$REVIEWS" | jq -r '[.[] | select(.state=="APPROVED") | .user.login] | unique | .[]') || true
|
||||
APPROVERS=$(echo "$REVIEWS" | jq -r '[.[] | select(.state=="APPROVED") | .user.login] | unique | .[]')
|
||||
if [ -z "$APPROVERS" ]; then
|
||||
echo "::error::No approving reviews on this PR. Set SOP_DEBUG=1 and re-run for diagnostics."
|
||||
exit 1
|
||||
|
||||
@@ -1,699 +0,0 @@
|
||||
#!/usr/bin/env python3
|
||||
"""status-reaper — Option B compensating-status POST for Gitea 1.22.6's
|
||||
hardcoded `(push)` suffix on default-branch commit statuses.
|
||||
|
||||
Tracking: this PR (workflow + script + tests + audit issue). Sibling
|
||||
bots: internal#327 (publish-runtime-bot), internal#328 (mc-drift-bot).
|
||||
Upstream RFC: internal#80. Persona provisioned by sub-agent aefaac1b
|
||||
(2026-05-11 21:39Z; Gitea uid 94, scope=write:repository).
|
||||
|
||||
What this script does, per `.gitea/workflows/status-reaper.yml` invocation:
|
||||
|
||||
1. Walk `.gitea/workflows/*.yml`. For each file, build the workflow_id
|
||||
using this resolution (per hongming-pc 22:08Z review):
|
||||
- If YAML has top-level `name:` → use that.
|
||||
- Else → use filename stem (basename minus `.yml`).
|
||||
Fail-LOUD on:
|
||||
- Two workflows resolving to the SAME identifier (collision).
|
||||
- Any identifier containing `/` (it would break context parsing
|
||||
downstream — Gitea uses ` / ` as the workflow/job separator).
|
||||
Classify each by whether `on:` contains a `push:` trigger.
|
||||
|
||||
2. List the last N (=30, rev3 — widened from 10) commits on
|
||||
WATCH_BRANCH via GET /repos/{o}/{r}/commits?sha={branch}&limit={N}.
|
||||
rev2 sweeps N commits per tick instead of HEAD only — schedule
|
||||
workflows post `failure` to whatever SHA was HEAD when they
|
||||
COMPLETED, so by the next */5 tick main has often moved forward
|
||||
and the red gets stranded on a stale commit. rev3 widens the
|
||||
window from 10 → 30 because schedule workflows post `failure`
|
||||
RETROACTIVELY (5-15 min after their merge); a 10-commit window
|
||||
is narrower than the merge-cadence during a burst, so reds land
|
||||
OUTSIDE the window before reaper sees them (Phase 1+2 evidence:
|
||||
rev2 run 17057 at 02:46Z saw 185/0 contexts on 10 SHAs; direct
|
||||
probe ~30min later showed ~25 fails on those same 10 SHAs).
|
||||
|
||||
3. For EACH SHA in the list:
|
||||
- GET combined commit status. Per-SHA error isolation
|
||||
(refinement #7): if this call raises ApiError or any 5xx,
|
||||
LOG `::warning::` + continue to the next SHA. Different from
|
||||
the single-HEAD pre-rev2 path where fail-loud was correct;
|
||||
the sweep is best-effort across historical commits, so one
|
||||
transient blip on a stale SHA must not strand reds on the
|
||||
OTHER stale SHAs.
|
||||
- If combined.state == "success": skip — cost optimization
|
||||
(refinement #2), common case (most commits are green).
|
||||
- Otherwise iterate per-context entries. For each entry where:
|
||||
state == "failure" AND context.endswith(" (push)")
|
||||
Parse context as `<workflow_name> / <job_name> (push)`.
|
||||
Look up workflow_name in the trigger map:
|
||||
- missing → log ::notice:: and skip (conservative).
|
||||
- has_push_trigger=True → preserve (real defect signal).
|
||||
- has_push_trigger=False → POST a compensating
|
||||
`state=success` status to /statuses/{sha} with the same
|
||||
context (Gitea de-dups by context) and a description
|
||||
documenting the workaround + this script's path.
|
||||
|
||||
4. Exit 0. Re-running is idempotent — Gitea's commit-status table
|
||||
stores the LATEST state-per-context, so the success POST sticks
|
||||
even if another tick happens before the runner finishes.
|
||||
|
||||
What it does NOT do:
|
||||
- Touch any context NOT ending in ` (push)`. The required-checks on
|
||||
main (verified 2026-05-11) all have ` (pull_request)` suffixes;
|
||||
they CANNOT be reached by this code path.
|
||||
- Compensate `error`/`pending` states. Only `failure` — the only one
|
||||
Gitea emits for the hardcoded-suffix bug.
|
||||
- Write to non-default branches. WATCH_BRANCH is sourced from
|
||||
`github.event.repository.default_branch` in the workflow.
|
||||
- Mutate workflows or runs. The Actions UI still shows the
|
||||
underlying schedule-triggered run as failed; this script edits
|
||||
the commit-status surface only.
|
||||
|
||||
Halt conditions (script-level — orchestrator-level halts are in the
|
||||
workflow comments):
|
||||
- PyYAML missing → fail-loud at import (no fallback parse).
|
||||
- Workflow `name:` collision → exit 1 with ::error:: message.
|
||||
- Workflow `name:` containing `/` → exit 1 with ::error:: message.
|
||||
- Ambiguous `on:` shape (e.g. neither str/list/dict) → treat as
|
||||
"has_push_trigger=True" and log ::notice:: (preserve, never
|
||||
compensate the unknown).
|
||||
- api() non-2xx → raise ApiError, fail the workflow run loudly so
|
||||
a subsequent tick retries (per
|
||||
`feedback_api_helper_must_raise_not_return_dict`).
|
||||
|
||||
Local dry-run (no network):
|
||||
GITEA_TOKEN=... GITEA_HOST=git.moleculesai.app REPO=owner/repo \\
|
||||
WATCH_BRANCH=main WORKFLOWS_DIR=.gitea/workflows \\
|
||||
python3 .gitea/scripts/status-reaper.py --dry-run
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import argparse
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
import urllib.error
|
||||
import urllib.parse
|
||||
import urllib.request
|
||||
from pathlib import Path
|
||||
from typing import Any
|
||||
|
||||
import yaml # PyYAML 6.0.2 — installed by the workflow before this runs.
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------
|
||||
# Environment
|
||||
# --------------------------------------------------------------------------
|
||||
def _env(key: str, *, default: str = "") -> str:
|
||||
"""Read an env var with a default. Module-import-safe — tests can
|
||||
import this script without setting the full env contract."""
|
||||
return os.environ.get(key, default)
|
||||
|
||||
|
||||
GITEA_TOKEN = _env("GITEA_TOKEN")
|
||||
GITEA_HOST = _env("GITEA_HOST")
|
||||
REPO = _env("REPO")
|
||||
WATCH_BRANCH = _env("WATCH_BRANCH", default="main")
|
||||
WORKFLOWS_DIR = _env("WORKFLOWS_DIR", default=".gitea/workflows")
|
||||
|
||||
OWNER, NAME = (REPO.split("/", 1) + [""])[:2] if REPO else ("", "")
|
||||
API = f"https://{GITEA_HOST}/api/v1" if GITEA_HOST else ""
|
||||
|
||||
# Compensating-status description prefix. Used as the marker so a human
|
||||
# auditing commit statuses can tell at a glance that the green was
|
||||
# synthetic, not a real CI pass. Kept stable; downstream tooling
|
||||
# (e.g. main-red-watchdog visual diff) MAY key on it.
|
||||
COMPENSATION_DESCRIPTION = (
|
||||
"Compensated by status-reaper (workflow has no push: trigger; "
|
||||
"Gitea 1.22.6 hardcoded-suffix bug — see .gitea/scripts/status-reaper.py)"
|
||||
)
|
||||
|
||||
# Context suffix the reaper acts on. Gitea hardcodes this for ALL
|
||||
# default-branch workflow runs.
|
||||
PUSH_SUFFIX = " (push)"
|
||||
|
||||
|
||||
def _require_runtime_env() -> None:
|
||||
"""Enforce env contract — called from `main()` only.
|
||||
|
||||
Tests import individual functions without setting the full env
|
||||
contract. Mirrors `main-red-watchdog.py`/`ci-required-drift.py`.
|
||||
"""
|
||||
for key in ("GITEA_TOKEN", "GITEA_HOST", "REPO", "WATCH_BRANCH", "WORKFLOWS_DIR"):
|
||||
if not os.environ.get(key):
|
||||
sys.stderr.write(f"::error::missing required env var: {key}\n")
|
||||
sys.exit(2)
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------
|
||||
# Tiny HTTP helper — raises on non-2xx + on JSON-decode-of-expected-JSON.
|
||||
# --------------------------------------------------------------------------
|
||||
class ApiError(RuntimeError):
|
||||
"""Raised when a Gitea API call cannot be trusted to have succeeded.
|
||||
|
||||
Per `feedback_api_helper_must_raise_not_return_dict`: soft-failure is
|
||||
opt-in via `expect_json=False`, never the default. A pre-fix
|
||||
implementation that returned `{}` on non-2xx would skip the
|
||||
compensating POST on a transient outage AND silently lose the
|
||||
failed-status enumeration, painting main green via omission.
|
||||
"""
|
||||
|
||||
|
||||
def api(
|
||||
method: str,
|
||||
path: str,
|
||||
*,
|
||||
body: dict | None = None,
|
||||
query: dict[str, str] | None = None,
|
||||
expect_json: bool = True,
|
||||
) -> tuple[int, Any]:
|
||||
"""Tiny HTTP helper around urllib. Same contract as
|
||||
`main-red-watchdog.py` and `ci-required-drift.py` so behaviour
|
||||
is cross-checkable."""
|
||||
url = f"{API}{path}"
|
||||
if query:
|
||||
url = f"{url}?{urllib.parse.urlencode(query)}"
|
||||
data = None
|
||||
headers = {
|
||||
"Authorization": f"token {GITEA_TOKEN}",
|
||||
"Accept": "application/json",
|
||||
}
|
||||
if body is not None:
|
||||
data = json.dumps(body).encode("utf-8")
|
||||
headers["Content-Type"] = "application/json"
|
||||
req = urllib.request.Request(url, method=method, data=data, headers=headers)
|
||||
try:
|
||||
with urllib.request.urlopen(req, timeout=30) as resp:
|
||||
raw = resp.read()
|
||||
status = resp.status
|
||||
except urllib.error.HTTPError as e:
|
||||
raw = e.read()
|
||||
status = e.code
|
||||
|
||||
if not (200 <= status < 300):
|
||||
snippet = raw[:500].decode("utf-8", errors="replace") if raw else ""
|
||||
raise ApiError(f"{method} {path} -> HTTP {status}: {snippet}")
|
||||
|
||||
if not raw:
|
||||
return status, None
|
||||
try:
|
||||
return status, json.loads(raw)
|
||||
except json.JSONDecodeError as e:
|
||||
if expect_json:
|
||||
raise ApiError(
|
||||
f"{method} {path} -> HTTP {status} but body is not JSON: {e}"
|
||||
) from e
|
||||
return status, {"_raw": raw.decode("utf-8", errors="replace")}
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------
|
||||
# Workflow scan + classification
|
||||
# --------------------------------------------------------------------------
|
||||
def _on_block(doc: dict) -> Any:
|
||||
"""Extract the `on:` block from a parsed YAML doc.
|
||||
|
||||
PyYAML parses bareword `on:` as Python `True` (YAML 1.1 boolean
|
||||
spec — `on/off/yes/no` are booleans). The actual key in the dict
|
||||
is therefore `True`, NOT the string `"on"`. We accept both for
|
||||
forward-compat with YAML 1.2 loaders (which keep it as `"on"`).
|
||||
"""
|
||||
if True in doc:
|
||||
return doc[True]
|
||||
return doc.get("on")
|
||||
|
||||
|
||||
def _has_push_trigger(on_block: Any, workflow_id: str) -> bool:
|
||||
"""Return True if `on:` block declares a `push` trigger.
|
||||
|
||||
Accepts the three common shapes:
|
||||
- str: `on: push` → True only if == "push"
|
||||
- list: `on: [push, pull_request]` → True if "push" in list
|
||||
- dict: `on: { push: {...}, schedule: ... }` → True if "push" key
|
||||
|
||||
Defensive: for anything else (including None/empty), return True
|
||||
so we preserve rather than over-compensate. Logged via ::notice::.
|
||||
"""
|
||||
if isinstance(on_block, str):
|
||||
return on_block == "push"
|
||||
if isinstance(on_block, list):
|
||||
return "push" in on_block
|
||||
if isinstance(on_block, dict):
|
||||
return "push" in on_block
|
||||
# None or unexpected shape — preserve, log.
|
||||
print(
|
||||
f"::notice::ambiguous on: for {workflow_id}; preserving "
|
||||
f"(value={on_block!r}, type={type(on_block).__name__})"
|
||||
)
|
||||
return True
|
||||
|
||||
|
||||
def scan_workflows(workflows_dir: str) -> dict[str, bool]:
|
||||
"""Walk `workflows_dir` and return `{workflow_id: has_push_trigger}`.
|
||||
|
||||
Workflow ID resolution (per hongming-pc 22:08Z review):
|
||||
- Top-level `name:` if present.
|
||||
- Else filename stem (basename minus `.yml`).
|
||||
|
||||
Fail-LOUD on:
|
||||
- Two workflows resolving to the same ID (collision).
|
||||
- Any ID containing `/` (would break ` / `-separated context
|
||||
parsing on the downstream side).
|
||||
|
||||
Returns a dict for O(1) lookup in the per-status loop.
|
||||
"""
|
||||
path = Path(workflows_dir)
|
||||
if not path.is_dir():
|
||||
# Workflow dir missing → no workflows to classify. Empty map is
|
||||
# safe: per-status loop will hit "unknown workflow; skip" for
|
||||
# every entry, which is correct (we cannot tell if a push
|
||||
# trigger exists, so we preserve).
|
||||
print(f"::warning::workflows dir not found: {workflows_dir}")
|
||||
return {}
|
||||
|
||||
out: dict[str, bool] = {}
|
||||
sources: dict[str, str] = {} # workflow_id -> source file (for collision msg)
|
||||
|
||||
for yml in sorted(path.glob("*.yml")):
|
||||
try:
|
||||
with yml.open() as f:
|
||||
doc = yaml.safe_load(f)
|
||||
except yaml.YAMLError as e:
|
||||
# A malformed YAML in the workflows dir is a real defect
|
||||
# (the workflow wouldn't load on Gitea either). Surface it
|
||||
# and keep going — the reaper's job is to compensate the
|
||||
# OTHER workflows even if one is broken.
|
||||
print(f"::warning::yaml parse failed for {yml.name}: {e}; skip")
|
||||
continue
|
||||
if not isinstance(doc, dict):
|
||||
print(f"::warning::workflow {yml.name} not a dict; skip")
|
||||
continue
|
||||
|
||||
# Resolve workflow_id.
|
||||
name_field = doc.get("name")
|
||||
if isinstance(name_field, str) and name_field.strip():
|
||||
workflow_id = name_field.strip()
|
||||
else:
|
||||
workflow_id = yml.stem # basename minus .yml
|
||||
|
||||
# Halt-loud: `/` in workflow_id breaks ` / ` context parsing.
|
||||
if "/" in workflow_id:
|
||||
sys.stderr.write(
|
||||
f"::error::workflow name contains '/' which breaks "
|
||||
f"context parsing: {workflow_id} (file={yml.name})\n"
|
||||
)
|
||||
sys.exit(1)
|
||||
|
||||
# Halt-loud: ID collision.
|
||||
if workflow_id in out:
|
||||
sys.stderr.write(
|
||||
f"::error::workflow name collision detected: {workflow_id} "
|
||||
f"(files: {sources[workflow_id]} + {yml.name})\n"
|
||||
)
|
||||
sys.exit(1)
|
||||
|
||||
on_block = _on_block(doc)
|
||||
out[workflow_id] = _has_push_trigger(on_block, workflow_id)
|
||||
sources[workflow_id] = yml.name
|
||||
|
||||
return out
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------
|
||||
# Gitea reads
|
||||
# --------------------------------------------------------------------------
|
||||
def get_head_sha(branch: str) -> str:
|
||||
"""HEAD SHA of `branch`. Raises ApiError on non-2xx."""
|
||||
_, body = api("GET", f"/repos/{OWNER}/{NAME}/branches/{branch}")
|
||||
if not isinstance(body, dict):
|
||||
raise ApiError(f"branch {branch} response not a JSON object")
|
||||
commit = body.get("commit")
|
||||
if not isinstance(commit, dict):
|
||||
raise ApiError(f"branch {branch} response missing `commit` object")
|
||||
sha = commit.get("id") or commit.get("sha")
|
||||
if not isinstance(sha, str) or len(sha) < 7:
|
||||
raise ApiError(f"branch {branch} response has no usable commit SHA")
|
||||
return sha
|
||||
|
||||
|
||||
def get_combined_status(sha: str) -> dict:
|
||||
"""Combined commit status for `sha`. Gitea returns:
|
||||
{
|
||||
"state": "success" | "failure" | "pending" | "error",
|
||||
"statuses": [
|
||||
{"context": "...", "state": "...", "target_url": "...",
|
||||
"description": "..."},
|
||||
...
|
||||
],
|
||||
...
|
||||
}
|
||||
Raises ApiError on non-2xx.
|
||||
"""
|
||||
_, body = api("GET", f"/repos/{OWNER}/{NAME}/commits/{sha}/status")
|
||||
if not isinstance(body, dict):
|
||||
raise ApiError(f"status for {sha} response not a JSON object")
|
||||
return body
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------
|
||||
# Context parsing
|
||||
# --------------------------------------------------------------------------
|
||||
def parse_push_context(context: str) -> tuple[str, str] | None:
|
||||
"""Parse `<workflow_name> / <job_name> (push)` into
|
||||
(workflow_name, job_name).
|
||||
|
||||
Returns None if the context doesn't match the shape (caller skips).
|
||||
Strict: requires the trailing ` (push)` and at least one ` / `
|
||||
separator. Anything else is left alone.
|
||||
"""
|
||||
if not context.endswith(PUSH_SUFFIX):
|
||||
return None
|
||||
head = context[: -len(PUSH_SUFFIX)] # strip " (push)"
|
||||
if " / " not in head:
|
||||
# No workflow/job separator — not the bug shape we compensate.
|
||||
return None
|
||||
workflow_name, job_name = head.split(" / ", 1)
|
||||
return workflow_name, job_name
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------
|
||||
# Compensating POST
|
||||
# --------------------------------------------------------------------------
|
||||
def post_compensating_status(
|
||||
sha: str,
|
||||
context: str,
|
||||
target_url: str | None,
|
||||
*,
|
||||
dry_run: bool = False,
|
||||
) -> None:
|
||||
"""POST a `state=success` to /repos/{o}/{r}/statuses/{sha} with the
|
||||
given context. Gitea de-dups by context (latest write wins).
|
||||
|
||||
Description references this script so the compensation is
|
||||
self-documenting on the commit's status view.
|
||||
"""
|
||||
payload: dict[str, Any] = {
|
||||
"context": context,
|
||||
"state": "success",
|
||||
"description": COMPENSATION_DESCRIPTION,
|
||||
}
|
||||
# Echo the original target_url when present so a human auditing
|
||||
# the (now-green) compensated status can still reach the run logs
|
||||
# that produced the original red.
|
||||
if target_url:
|
||||
payload["target_url"] = target_url
|
||||
|
||||
if dry_run:
|
||||
print(
|
||||
f"::notice::[dry-run] would compensate {context!r} on {sha[:10]} "
|
||||
f"with state=success"
|
||||
)
|
||||
return
|
||||
|
||||
api("POST", f"/repos/{OWNER}/{NAME}/statuses/{sha}", body=payload)
|
||||
print(f"::notice::compensated {context!r} on {sha[:10]} (state=success)")
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------
|
||||
# Main reap loop
|
||||
# --------------------------------------------------------------------------
|
||||
def reap(
|
||||
workflow_trigger_map: dict[str, bool],
|
||||
combined: dict,
|
||||
sha: str,
|
||||
*,
|
||||
dry_run: bool = False,
|
||||
) -> dict[str, Any]:
|
||||
"""Walk `combined.statuses[]` and compensate where appropriate.
|
||||
|
||||
Per-SHA worker. The multi-SHA orchestrator (`reap_branch`) calls
|
||||
this once per stale main commit each tick.
|
||||
|
||||
Returns counters for observability:
|
||||
{compensated, preserved_real_push, preserved_unknown,
|
||||
preserved_non_failure, preserved_non_push_suffix,
|
||||
preserved_unparseable,
|
||||
compensated_contexts: [<context>, ...]}
|
||||
|
||||
`compensated_contexts` is rev2-added so `reap_branch` can build
|
||||
`compensated_per_sha` without re-deriving it from the POST stream.
|
||||
"""
|
||||
counters: dict[str, Any] = {
|
||||
"compensated": 0,
|
||||
"preserved_real_push": 0,
|
||||
"preserved_unknown": 0,
|
||||
"preserved_non_failure": 0,
|
||||
"preserved_non_push_suffix": 0,
|
||||
"preserved_unparseable": 0,
|
||||
"compensated_contexts": [],
|
||||
}
|
||||
|
||||
statuses = combined.get("statuses") or []
|
||||
for s in statuses:
|
||||
if not isinstance(s, dict):
|
||||
continue
|
||||
context = s.get("context") or ""
|
||||
# Schema asymmetry: Gitea 1.22.6 returns the TOP-LEVEL combined
|
||||
# aggregate as `combined.state` but each per-context entry in
|
||||
# `combined.statuses[]` uses the key `status`, NOT `state`.
|
||||
# Prefer `status`; fall back to `state` so a future Gitea
|
||||
# version (or a test fixture written against the wrong key)
|
||||
# still flows through the compensation path. Verified empirically
|
||||
# via direct API probe 2026-05-12 03:42Z:
|
||||
# /repos/.../commits/{sha}/status entries → key is "status".
|
||||
# Pre-rev4 code read "state" only → returned "" → bypassed the
|
||||
# `state != "failure"` guard → compensation path unreachable.
|
||||
# See `feedback_smoke_test_vendor_truth_not_shape_match`.
|
||||
state = s.get("status") or s.get("state") or ""
|
||||
|
||||
# Only `failure` is the bug shape. `error`/`pending`/`success`
|
||||
# left alone — they have other meanings.
|
||||
if state != "failure":
|
||||
counters["preserved_non_failure"] += 1
|
||||
continue
|
||||
|
||||
# Only `(push)`-suffix contexts hit the hardcoded-suffix bug.
|
||||
# Branch-protection required checks (e.g. `Secret scan / Scan
|
||||
# diff (pull_request)`) are NOT reachable from this path.
|
||||
if not context.endswith(PUSH_SUFFIX):
|
||||
counters["preserved_non_push_suffix"] += 1
|
||||
continue
|
||||
|
||||
parsed = parse_push_context(context)
|
||||
if parsed is None:
|
||||
# Has ` (push)` suffix but missing ` / ` separator — not
|
||||
# the bug shape. Preserve.
|
||||
counters["preserved_unparseable"] += 1
|
||||
continue
|
||||
workflow_name, _job_name = parsed
|
||||
|
||||
if workflow_name not in workflow_trigger_map:
|
||||
# Real workflow but renamed/deleted/external — we can't
|
||||
# tell if it has push trigger. Conservative: preserve.
|
||||
print(f"::notice::unknown workflow {workflow_name!r}; skip")
|
||||
counters["preserved_unknown"] += 1
|
||||
continue
|
||||
|
||||
if workflow_trigger_map[workflow_name]:
|
||||
# Real push trigger → real defect signal. Preserve.
|
||||
counters["preserved_real_push"] += 1
|
||||
continue
|
||||
|
||||
# Class-O: schedule/dispatch/etc.-only workflow with a fake
|
||||
# (push) status from Gitea's hardcoded-suffix bug. Compensate.
|
||||
post_compensating_status(
|
||||
sha, context, s.get("target_url"), dry_run=dry_run
|
||||
)
|
||||
counters["compensated"] += 1
|
||||
counters["compensated_contexts"].append(context)
|
||||
|
||||
return counters
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------
|
||||
# rev2: multi-SHA sweep over the last N commits on WATCH_BRANCH
|
||||
# --------------------------------------------------------------------------
|
||||
# How many main commits to sweep per tick. Sized to cover a burst-merge
|
||||
# window where multiple PRs land in the 5-min interval between reaper
|
||||
# ticks. Older reds falling off the window is acceptable — they were
|
||||
# already stale enough that the schedule-run that posted them has long
|
||||
# since been overwritten by a real push trigger. See `reference_post_
|
||||
# suspension_pipeline` for the merge-cadence baseline.
|
||||
#
|
||||
# rev3 (2026-05-12, hongming-pc2 GO 03:25Z): widened from 10 → 30.
|
||||
# rev2 (limit=10) shipped 01:48Z and ran 6/6 ticks post-merge with
|
||||
# `compensated:0` despite ~25 stranded reds visible on those same 10
|
||||
# SHAs ~30min later. Root cause: schedule workflows post `failure`
|
||||
# RETROACTIVELY 5-15 min after their merge, so by the time reaper's
|
||||
# next */5 tick lands, the stranded red is on a SHA that has already
|
||||
# fallen out of a 10-commit window during a burst-merge period.
|
||||
# Trades window-width-cheap for cadence-loady (per hongming-pc2):
|
||||
# kept `*/5` cron unchanged; only the window-N is widened.
|
||||
DEFAULT_SWEEP_LIMIT = 30
|
||||
|
||||
|
||||
def list_recent_commit_shas(branch: str, limit: int) -> list[str]:
|
||||
"""List the most recent `limit` commit SHAs on `branch`, newest
|
||||
first.
|
||||
|
||||
Wraps GET /repos/{o}/{r}/commits?sha={branch}&limit={limit}. Gitea
|
||||
1.22.6 returns a JSON list of commit objects each with a `sha` key
|
||||
(verified via vendor-truth probe 2026-05-11 against
|
||||
git.moleculesai.app — `feedback_smoke_test_vendor_truth_not_shape_match`).
|
||||
|
||||
Raises ApiError on non-2xx OR on unexpected response shape. This is
|
||||
a HARD halt — without the commit list the sweep can't proceed. (The
|
||||
per-SHA error isolation downstream is a different concern: tolerating
|
||||
a transient 5xx on ONE commit's status is best-effort; losing the
|
||||
commit list itself means we don't even know which commits to try.)
|
||||
"""
|
||||
_, body = api(
|
||||
"GET",
|
||||
f"/repos/{OWNER}/{NAME}/commits",
|
||||
query={"sha": branch, "limit": str(limit)},
|
||||
)
|
||||
if not isinstance(body, list):
|
||||
raise ApiError(
|
||||
f"commits listing for {branch} not a JSON array "
|
||||
f"(got {type(body).__name__})"
|
||||
)
|
||||
shas: list[str] = []
|
||||
for entry in body:
|
||||
if not isinstance(entry, dict):
|
||||
continue
|
||||
sha = entry.get("sha")
|
||||
if isinstance(sha, str) and len(sha) >= 7:
|
||||
shas.append(sha)
|
||||
if not shas:
|
||||
raise ApiError(
|
||||
f"commits listing for {branch} returned no usable SHAs"
|
||||
)
|
||||
return shas
|
||||
|
||||
|
||||
def reap_branch(
|
||||
workflow_trigger_map: dict[str, bool],
|
||||
branch: str,
|
||||
*,
|
||||
limit: int = DEFAULT_SWEEP_LIMIT,
|
||||
dry_run: bool = False,
|
||||
) -> dict[str, Any]:
|
||||
"""Sweep the last `limit` commits on `branch`, applying `reap()`
|
||||
to each (with per-SHA error isolation).
|
||||
|
||||
Returns aggregated counters PLUS rev2 observability fields:
|
||||
- scanned_shas: how many SHAs we actually iterated
|
||||
- compensated_per_sha: {<sha_full>: [<context>, ...]} — only
|
||||
SHAs that actually got at least one compensation are included
|
||||
"""
|
||||
shas = list_recent_commit_shas(branch, limit)
|
||||
|
||||
aggregate: dict[str, Any] = {
|
||||
"scanned_shas": 0,
|
||||
"compensated": 0,
|
||||
"preserved_real_push": 0,
|
||||
"preserved_unknown": 0,
|
||||
"preserved_non_failure": 0,
|
||||
"preserved_non_push_suffix": 0,
|
||||
"preserved_unparseable": 0,
|
||||
"compensated_per_sha": {},
|
||||
}
|
||||
|
||||
for sha in shas:
|
||||
aggregate["scanned_shas"] += 1
|
||||
|
||||
# Per-SHA error isolation (refinement #7). One transient blip
|
||||
# on a historical commit must NOT abort the whole tick — the
|
||||
# OTHER stale SHAs may still hold strandable reds.
|
||||
try:
|
||||
combined = get_combined_status(sha)
|
||||
except ApiError as e:
|
||||
print(
|
||||
f"::warning::get_combined_status({sha[:10]}) failed; "
|
||||
f"skipping this SHA: {e}"
|
||||
)
|
||||
continue
|
||||
|
||||
# Cost optimization (refinement #2): the common case is a green
|
||||
# commit. Skip the per-context loop entirely when combined is
|
||||
# already success — saves a tight loop over ~20 statuses per SHA
|
||||
# on green commits, the dominant majority.
|
||||
if combined.get("state") == "success":
|
||||
continue
|
||||
|
||||
per_sha = reap(
|
||||
workflow_trigger_map, combined, sha, dry_run=dry_run
|
||||
)
|
||||
|
||||
# Aggregate scalar counters.
|
||||
for key in (
|
||||
"compensated",
|
||||
"preserved_real_push",
|
||||
"preserved_unknown",
|
||||
"preserved_non_failure",
|
||||
"preserved_non_push_suffix",
|
||||
"preserved_unparseable",
|
||||
):
|
||||
aggregate[key] += per_sha[key]
|
||||
|
||||
# Record per-SHA compensated contexts (only when non-empty —
|
||||
# keep the summary readable when most SHAs are no-ops).
|
||||
contexts = per_sha.get("compensated_contexts") or []
|
||||
if contexts:
|
||||
aggregate["compensated_per_sha"][sha] = list(contexts)
|
||||
|
||||
return aggregate
|
||||
|
||||
|
||||
def main() -> int:
|
||||
parser = argparse.ArgumentParser(description=__doc__)
|
||||
parser.add_argument(
|
||||
"--dry-run",
|
||||
action="store_true",
|
||||
help="Skip the compensating POST; print what would be done.",
|
||||
)
|
||||
parser.add_argument(
|
||||
"--limit",
|
||||
type=int,
|
||||
default=DEFAULT_SWEEP_LIMIT,
|
||||
help=(
|
||||
"How many recent commits on WATCH_BRANCH to sweep per tick "
|
||||
f"(default: {DEFAULT_SWEEP_LIMIT})."
|
||||
),
|
||||
)
|
||||
args = parser.parse_args()
|
||||
|
||||
_require_runtime_env()
|
||||
|
||||
workflow_trigger_map = scan_workflows(WORKFLOWS_DIR)
|
||||
print(
|
||||
f"::notice::scanned {len(workflow_trigger_map)} workflows; "
|
||||
f"push-triggered={sum(1 for v in workflow_trigger_map.values() if v)}, "
|
||||
f"class-O candidates={sum(1 for v in workflow_trigger_map.values() if not v)}"
|
||||
)
|
||||
|
||||
counters = reap_branch(
|
||||
workflow_trigger_map,
|
||||
WATCH_BRANCH,
|
||||
limit=args.limit,
|
||||
dry_run=args.dry_run,
|
||||
)
|
||||
|
||||
# Observability: print one JSON line summarising the tick. Loki
|
||||
# ingestion via the runner's stdout (`source="gitea-actions"`).
|
||||
print(
|
||||
"status-reaper summary: "
|
||||
+ json.dumps(
|
||||
{
|
||||
"branch": WATCH_BRANCH,
|
||||
"dry_run": args.dry_run,
|
||||
"limit": args.limit,
|
||||
**counters,
|
||||
},
|
||||
sort_keys=True,
|
||||
)
|
||||
)
|
||||
return 0
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
@@ -1,140 +0,0 @@
|
||||
#!/usr/bin/env python3
|
||||
"""Stub Gitea API for review-check.sh test scenarios.
|
||||
|
||||
Reads $FIXTURE_STATE_DIR/scenario to decide what to return for each
|
||||
endpoint the review-check.sh script calls.
|
||||
Reads $FIXTURE_STATE_DIR/token_owner_in_teams to decide whether
|
||||
the team membership probe returns 200/204 (member) or 403 (not in team).
|
||||
|
||||
Scenarios:
|
||||
T1_pr_open — open PR, author=alice, sha=deadbeef → continue
|
||||
T2_pr_closed — closed PR → script exits 0 (no-op)
|
||||
T3_reviews_approved_non_author — one APPROVED from non-author → candidates exist
|
||||
T4_reviews_empty — zero APPROVED non-author → exit 1 (no candidates)
|
||||
T5_reviews_only_author — only author reviews → exit 1 (no candidates)
|
||||
T6_reviews_dismissed — dismissed APPROVED → treated as no approval
|
||||
T7_team_member — team membership → 204 (member) → exit 0
|
||||
T8_team_not_member — team membership → 404 (not a member) → exit 1
|
||||
T9_team_403 — team membership → 403 (token not in team) → exit 1
|
||||
|
||||
Usage:
|
||||
FIXTURE_STATE_DIR=/tmp/x python3 _review_check_fixture.py 8080
|
||||
"""
|
||||
|
||||
import http.server
|
||||
import json
|
||||
import os
|
||||
import re
|
||||
import sys
|
||||
import urllib.parse
|
||||
|
||||
|
||||
STATE_DIR = os.environ.get("FIXTURE_STATE_DIR", "/tmp")
|
||||
|
||||
|
||||
def scenario() -> str:
|
||||
p = os.path.join(STATE_DIR, "scenario")
|
||||
if not os.path.isfile(p):
|
||||
return "T1_pr_open"
|
||||
with open(p) as f:
|
||||
return f.read().strip()
|
||||
|
||||
|
||||
class Handler(http.server.BaseHTTPRequestHandler):
|
||||
def log_message(self, *args, **kwargs):
|
||||
pass # keep stdout for explicit logs only
|
||||
|
||||
def _json(self, code: int, body: dict) -> None:
|
||||
payload = json.dumps(body).encode()
|
||||
self.send_response(code)
|
||||
self.send_header("Content-Type", "application/json")
|
||||
self.send_header("Content-Length", str(len(payload)))
|
||||
self.end_headers()
|
||||
self.wfile.write(payload)
|
||||
|
||||
def _empty(self, code: int) -> None:
|
||||
self.send_response(code)
|
||||
self.send_header("Content-Length", "0")
|
||||
self.end_headers()
|
||||
|
||||
def _text(self, code: int, body: str) -> None:
|
||||
payload = body.encode()
|
||||
self.send_response(code)
|
||||
self.send_header("Content-Type", "text/plain")
|
||||
self.send_header("Content-Length", str(len(payload)))
|
||||
self.end_headers()
|
||||
self.wfile.write(payload)
|
||||
|
||||
def do_GET(self):
|
||||
u = urllib.parse.urlparse(self.path)
|
||||
path = u.path
|
||||
sc = scenario()
|
||||
|
||||
if path == "/_ping":
|
||||
return self._json(200, {"ok": True})
|
||||
|
||||
# GET /repos/{owner}/{name}/pulls/{pr_number}
|
||||
m = re.match(r"^/api/v1/repos/([^/]+)/([^/]+)/pulls/(\d+)$", path)
|
||||
if m:
|
||||
owner, name, pr_num = m.group(1), m.group(2), m.group(3)
|
||||
if sc == "T2_pr_closed":
|
||||
return self._json(200, {
|
||||
"number": int(pr_num),
|
||||
"state": "closed",
|
||||
"head": {"sha": "deadbeef0000111122223333444455556666"},
|
||||
"user": {"login": "alice"},
|
||||
})
|
||||
return self._json(200, {
|
||||
"number": int(pr_num),
|
||||
"state": "open",
|
||||
"head": {"sha": "deadbeef0000111122223333444455556666"},
|
||||
"user": {"login": "alice"},
|
||||
})
|
||||
|
||||
# GET /repos/{owner}/{name}/pulls/{pr_number}/reviews
|
||||
m = re.match(r"^/api/v1/repos/([^/]+)/([^/]+)/pulls/(\d+)/reviews$", path)
|
||||
if m:
|
||||
if sc in ("T4_reviews_empty", "T5_reviews_only_author"):
|
||||
return self._json(200, [])
|
||||
if sc == "T6_reviews_dismissed":
|
||||
return self._json(200, [{
|
||||
"state": "APPROVED",
|
||||
"dismissed": True,
|
||||
"user": {"login": "core-devops"},
|
||||
"commit_id": "abc1234",
|
||||
}])
|
||||
if sc == "T3_reviews_approved_non_author":
|
||||
return self._json(200, [
|
||||
{"state": "CHANGES_REQUESTED", "dismissed": False, "user": {"login": "bob"}, "commit_id": "abc1234"},
|
||||
{"state": "APPROVED", "dismissed": False, "user": {"login": "core-devops"}, "commit_id": "abc1234"},
|
||||
])
|
||||
# Default: one non-author APPROVED
|
||||
return self._json(200, [
|
||||
{"state": "APPROVED", "dismissed": False, "user": {"login": "core-devops"}, "commit_id": "abc1234"},
|
||||
])
|
||||
|
||||
# GET /teams/{team_id}/members/{username}
|
||||
m = re.match(r"^/api/v1/teams/(\d+)/members/([^/]+)$", path)
|
||||
if m:
|
||||
team_id, login = m.group(1), m.group(2)
|
||||
if sc == "T8_team_not_member":
|
||||
return self._empty(404)
|
||||
if sc == "T9_team_403":
|
||||
return self._empty(403)
|
||||
# T7_team_member: member
|
||||
return self._empty(204)
|
||||
|
||||
return self._json(404, {"path": path, "msg": "fixture: no route"})
|
||||
|
||||
def do_POST(self):
|
||||
self._json(404, {"path": self.path, "msg": "fixture: no POST routes"})
|
||||
|
||||
|
||||
def main():
|
||||
port = int(sys.argv[1])
|
||||
srv = http.server.ThreadingHTTPServer(("127.0.0.1", port), Handler)
|
||||
srv.serve_forever()
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
@@ -1,332 +0,0 @@
|
||||
#!/usr/bin/env bash
|
||||
# Regression tests for .gitea/scripts/review-check.sh (RFC#324 Step 1).
|
||||
#
|
||||
# Covers:
|
||||
# T1 — open PR: script fetches PR + reviews, continues to team probe
|
||||
# T2 — closed PR: script exits 0 (no-op)
|
||||
# T3 — APPROVED non-author review exists → candidates exist
|
||||
# T4 — no non-author APPROVED reviews → exit 1 (no candidates)
|
||||
# T5 — only author reviews (no non-author APPROVE) → exit 1
|
||||
# T6 — dismissed APPROVED review → treated as no approval
|
||||
# T7 — team membership probe → 204 (member) → script exits 0
|
||||
# T8 — team membership probe → 404 (not a member) → script exits 1
|
||||
# T9 — team membership probe → 403 (token not in team) → script exits 1 (fail closed)
|
||||
# T10 — CURL_AUTH_FILE created with mode 600 and correct header content
|
||||
# T11 — bash syntax check (bash -n passes)
|
||||
# T12 — jq filter: non-author APPROVED → in candidate list; dismissed → excluded
|
||||
# T13 — missing required env GITEA_TOKEN → exits 1 with error
|
||||
#
|
||||
# Hostile-self-review (per feedback_assert_exact_not_substring):
|
||||
# this test MUST FAIL if the script is absent. Verified by running
|
||||
# the test before the file exists (covered in the PR body).
|
||||
|
||||
set -euo pipefail
|
||||
|
||||
THIS_DIR="$(cd "$(dirname "$0")" && pwd)"
|
||||
SCRIPT_DIR="$(cd "$THIS_DIR/.." && pwd)"
|
||||
SCRIPT="$SCRIPT_DIR/review-check.sh"
|
||||
|
||||
PASS=0
|
||||
FAIL=0
|
||||
FAILED_TESTS=""
|
||||
|
||||
assert_eq() {
|
||||
local label="$1"
|
||||
local expected="$2"
|
||||
local got="$3"
|
||||
if [ "$expected" = "$got" ]; then
|
||||
echo " PASS $label"
|
||||
PASS=$((PASS + 1))
|
||||
else
|
||||
echo " FAIL $label"
|
||||
echo " expected: <$expected>"
|
||||
echo " got: <$got>"
|
||||
FAIL=$((FAIL + 1))
|
||||
FAILED_TESTS="${FAILED_TESTS} ${label}"
|
||||
fi
|
||||
}
|
||||
|
||||
assert_contains() {
|
||||
local label="$1"
|
||||
local needle="$2"
|
||||
local haystack="$3"
|
||||
if printf '%s' "$haystack" | grep -qF "$needle"; then
|
||||
echo " PASS $label"
|
||||
PASS=$((PASS + 1))
|
||||
else
|
||||
echo " FAIL $label"
|
||||
echo " needle: <$needle>"
|
||||
echo " haystack: <$(printf '%s' "$haystack" | head -c 200)>"
|
||||
FAIL=$((FAIL + 1))
|
||||
FAILED_TESTS="${FAILED_TESTS} ${label}"
|
||||
fi
|
||||
}
|
||||
|
||||
assert_file_mode() {
|
||||
local label="$1"
|
||||
local path="$2"
|
||||
local expected_mode="$3"
|
||||
if [ ! -f "$path" ]; then
|
||||
echo " FAIL $label (file not found: $path)"
|
||||
FAIL=$((FAIL + 1))
|
||||
FAILED_TESTS="${FAILED_TESTS} ${label}"
|
||||
return
|
||||
fi
|
||||
local got_mode
|
||||
got_mode=$(stat -c '%a' "$path" 2>/dev/null || echo "000")
|
||||
if [ "$expected_mode" = "$got_mode" ]; then
|
||||
echo " PASS $label (mode=$got_mode)"
|
||||
PASS=$((PASS + 1))
|
||||
else
|
||||
echo " FAIL $label (expected mode=$expected_mode, got=$got_mode)"
|
||||
FAIL=$((FAIL + 1))
|
||||
FAILED_TESTS="${FAILED_TESTS} ${label}"
|
||||
fi
|
||||
}
|
||||
|
||||
assert_file_contains() {
|
||||
local label="$1"
|
||||
local path="$2"
|
||||
local needle="$3"
|
||||
if [ ! -f "$path" ]; then
|
||||
echo " FAIL $label (file not found: $path)"
|
||||
FAIL=$((FAIL + 1))
|
||||
FAILED_TESTS="${FAILED_TESTS} ${label}"
|
||||
return
|
||||
fi
|
||||
if grep -qF "$needle" "$path"; then
|
||||
echo " PASS $label"
|
||||
PASS=$((PASS + 1))
|
||||
else
|
||||
echo " FAIL $label (needle not found: <$needle>)"
|
||||
FAIL=$((FAIL + 1))
|
||||
FAILED_TESTS="${FAILED_TESTS} ${label}"
|
||||
fi
|
||||
}
|
||||
|
||||
# Existence check (foundation)
|
||||
echo
|
||||
echo "== existence =="
|
||||
if [ -f "$SCRIPT" ]; then
|
||||
echo " PASS script exists: $SCRIPT"
|
||||
PASS=$((PASS + 1))
|
||||
else
|
||||
echo " FAIL script not found: $SCRIPT"
|
||||
FAIL=$((FAIL + 1))
|
||||
FAILED_TESTS="${FAILED_TESTS} script_exists"
|
||||
echo
|
||||
echo "------"
|
||||
echo "PASS=$PASS FAIL=$FAIL (existence)"
|
||||
echo "Cannot proceed without the script."
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# T11 — bash syntax check
|
||||
echo
|
||||
echo "== T11 bash syntax =="
|
||||
if bash -n "$SCRIPT" 2>&1; then
|
||||
echo " PASS T11 bash -n passes"
|
||||
PASS=$((PASS + 1))
|
||||
else
|
||||
echo " FAIL T11 bash -n failed"
|
||||
FAIL=$((FAIL + 1))
|
||||
FAILED_TESTS="${FAILED_TESTS} T11"
|
||||
fi
|
||||
|
||||
# T13 — missing required env
|
||||
echo
|
||||
echo "== T13 missing GITEA_TOKEN =="
|
||||
set +e
|
||||
T13_OUT=$(PATH="/tmp:$PATH" GITEA_TOKEN= GITEA_HOST=git.example.com REPO=x/y PR_NUMBER=1 TEAM=qa TEAM_ID=1 bash "$SCRIPT" 2>&1 || true)
|
||||
set -e
|
||||
assert_contains "T13 exits non-zero when GITEA_TOKEN missing" "GITEA_TOKEN required" "$T13_OUT"
|
||||
|
||||
# Start fixture HTTP server
|
||||
echo
|
||||
echo "== fixture setup =="
|
||||
FIXTURE_DIR=$(mktemp -d)
|
||||
trap 'rm -rf "$FIXTURE_DIR"; [ -n "${FIX_PID:-}" ] && kill "$FIX_PID" 2>/dev/null || true' EXIT
|
||||
FIXTURE_PY="$THIS_DIR/_review_check_fixture.py"
|
||||
if [ ! -f "$FIXTURE_PY" ]; then
|
||||
echo "::error::fixture server $FIXTURE_PY missing"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
FIX_LOG="$FIXTURE_DIR/fixture.log"
|
||||
FIX_STATE_DIR="$FIXTURE_DIR/state"
|
||||
mkdir -p "$FIX_STATE_DIR"
|
||||
|
||||
# Find an unused port
|
||||
FIX_PORT=$(python3 -c 'import socket;s=socket.socket();s.bind(("127.0.0.1",0));print(s.getsockname()[1]);s.close()')
|
||||
|
||||
FIXTURE_STATE_DIR="$FIX_STATE_DIR" python3 "$FIXTURE_PY" "$FIX_PORT" \
|
||||
>"$FIX_LOG" 2>&1 &
|
||||
FIX_PID=$!
|
||||
|
||||
# Wait for fixture readiness
|
||||
for _ in $(seq 1 50); do
|
||||
if curl -fsS "http://127.0.0.1:${FIX_PORT}/_ping" >/dev/null 2>&1; then
|
||||
break
|
||||
fi
|
||||
sleep 0.1
|
||||
done
|
||||
if ! curl -fsS "http://127.0.0.1:${FIX_PORT}/_ping" >/dev/null 2>&1; then
|
||||
echo "::error::fixture server failed to start. Log:"
|
||||
cat "$FIX_LOG"
|
||||
exit 1
|
||||
fi
|
||||
echo " fixture running on port $FIX_PORT"
|
||||
|
||||
# Install a curl shim that rewrites https://fixture.local/* -> http://127.0.0.1:$FIX_PORT/*
|
||||
# Use double-quoted heredoc so FIX_PORT is expanded into the shim at creation time.
|
||||
mkdir -p "$FIXTURE_DIR/bin"
|
||||
cat >"$FIXTURE_DIR/bin/curl" <<"CURL_SHIM"
|
||||
#!/usr/bin/env bash
|
||||
# Shim: rewrite https://fixture.local/* -> http://127.0.0.1:FIXPORT/*
|
||||
# Generated at test-run time; FIXPORT is substituted when this file is written.
|
||||
new_args=()
|
||||
for a in "$@"; do
|
||||
if [[ "$a" == https://fixture.local/* ]]; then
|
||||
rest="${a#https://fixture.local}"
|
||||
a="http://127.0.0.1:FIXPORT${rest}"
|
||||
fi
|
||||
new_args+=("$a")
|
||||
done
|
||||
exec /usr/bin/curl "${new_args[@]}"
|
||||
CURL_SHIM
|
||||
# Now substitute FIXPORT with the actual port number
|
||||
sed -i "s/FIXPORT/${FIX_PORT}/g" "$FIXTURE_DIR/bin/curl"
|
||||
chmod +x "$FIXTURE_DIR/bin/curl"
|
||||
|
||||
# Helper: run the script with fixture environment
|
||||
run_review_check() {
|
||||
local scenario="$1"
|
||||
echo "$scenario" >"$FIX_STATE_DIR/scenario"
|
||||
local out
|
||||
set +e
|
||||
out=$(
|
||||
PATH="$FIXTURE_DIR/bin:/tmp:$PATH" \
|
||||
GITEA_TOKEN="fixture-token" \
|
||||
GITEA_HOST="fixture.local" \
|
||||
REPO="molecule-ai/molecule-core" \
|
||||
PR_NUMBER="999" \
|
||||
TEAM="qa" \
|
||||
TEAM_ID="20" \
|
||||
REVIEW_CHECK_DEBUG="0" \
|
||||
REVIEW_CHECK_STRICT="0" \
|
||||
bash "$SCRIPT" 2>&1
|
||||
)
|
||||
local rc=$?
|
||||
set -e
|
||||
echo "$out" >"$FIX_STATE_DIR/last_run.log"
|
||||
echo "$rc" >"$FIX_STATE_DIR/last_rc"
|
||||
echo "$out"
|
||||
}
|
||||
|
||||
# T1 — open PR: script fetches PR and continues
|
||||
echo
|
||||
echo "== T1 open PR =="
|
||||
T1_OUT=$(run_review_check "T1_pr_open")
|
||||
T1_RC=$(cat "$FIX_STATE_DIR/last_rc")
|
||||
assert_eq "T1 exit code 0 (approver exists + team member)" "0" "$T1_RC"
|
||||
assert_contains "T1 qa-review APPROVED by core-devops" "APPROVED by core-devops" "$T1_OUT"
|
||||
|
||||
# T2 — closed PR: exits 0 immediately (no-op)
|
||||
echo
|
||||
echo "== T2 closed PR =="
|
||||
T2_OUT=$(run_review_check "T2_pr_closed")
|
||||
T2_RC=$(cat "$FIX_STATE_DIR/last_rc")
|
||||
assert_eq "T2 exit code 0 (closed PR no-op)" "0" "$T2_RC"
|
||||
|
||||
# T3 — APPROVED non-author reviews exist
|
||||
echo
|
||||
echo "== T3 approved non-author reviews =="
|
||||
T3_OUT=$(run_review_check "T3_reviews_approved_non_author")
|
||||
T3_RC=$(cat "$FIX_STATE_DIR/last_rc")
|
||||
assert_eq "T3 exit code 0 (candidates + team member)" "0" "$T3_RC"
|
||||
|
||||
# T4 — no non-author APPROVED reviews → exit 1
|
||||
echo
|
||||
echo "== T4 no non-author APPROVED reviews =="
|
||||
T4_OUT=$(run_review_check "T4_reviews_empty")
|
||||
T4_RC=$(cat "$FIX_STATE_DIR/last_rc")
|
||||
assert_eq "T4 exit code 1 (no candidates)" "1" "$T4_RC"
|
||||
assert_contains "T4 awaiting non-author APPROVE" "awaiting non-author APPROVE" "$T4_OUT"
|
||||
|
||||
# T5 — only author reviews → exit 1
|
||||
echo
|
||||
echo "== T5 only author reviews =="
|
||||
T5_OUT=$(run_review_check "T5_reviews_only_author")
|
||||
T5_RC=$(cat "$FIX_STATE_DIR/last_rc")
|
||||
assert_eq "T5 exit code 1 (only author reviews, no candidates)" "1" "$T5_RC"
|
||||
|
||||
# T6 — dismissed APPROVED review → treated as no approval
|
||||
echo
|
||||
echo "== T6 dismissed APPROVED review =="
|
||||
T6_OUT=$(run_review_check "T6_reviews_dismissed")
|
||||
T6_RC=$(cat "$FIX_STATE_DIR/last_rc")
|
||||
assert_eq "T6 exit code 1 (dismissed = no approval)" "1" "$T6_RC"
|
||||
|
||||
# T7 — team member → exit 0
|
||||
echo
|
||||
echo "== T7 team membership 204 (member) =="
|
||||
T7_OUT=$(run_review_check "T7_team_member")
|
||||
T7_RC=$(cat "$FIX_STATE_DIR/last_rc")
|
||||
assert_eq "T7 exit code 0 (member, APPROVED)" "0" "$T7_RC"
|
||||
assert_contains "T7 APPROVED by core-devops (team member)" "APPROVED by core-devops" "$T7_OUT"
|
||||
|
||||
# T8 — not a team member → exit 1 (fail closed)
|
||||
echo
|
||||
echo "== T8 team membership 404 (not a member) =="
|
||||
T8_OUT=$(run_review_check "T8_team_not_member")
|
||||
T8_RC=$(cat "$FIX_STATE_DIR/last_rc")
|
||||
assert_eq "T8 exit code 1 (not in team)" "1" "$T8_RC"
|
||||
|
||||
# T9 — 403 token-not-in-team → exit 1 (fail closed)
|
||||
echo
|
||||
echo "== T9 team membership 403 (token not in team) =="
|
||||
T9_OUT=$(run_review_check "T9_team_403")
|
||||
T9_RC=$(cat "$FIX_STATE_DIR/last_rc")
|
||||
assert_eq "T9 exit code 1 (403 token-not-in-team, fail closed)" "1" "$T9_RC"
|
||||
assert_contains "T9 403 error in output" "403" "$T9_OUT"
|
||||
|
||||
# T10 — token file creation and permissions
|
||||
echo
|
||||
echo "== T10 CURL_AUTH_FILE =="
|
||||
# Verify the token-file logic directly: create a temp file with the
|
||||
# same mktemp pattern, write the header with printf, chmod 600, then assert.
|
||||
T10_TOKEN="secret-test-token-abc123"
|
||||
T10_AUTHFILE=$(mktemp -p /tmp curl-auth.test.XXXXXX)
|
||||
chmod 600 "$T10_AUTHFILE"
|
||||
printf 'header = "Authorization: token %s"\n' "$T10_TOKEN" > "$T10_AUTHFILE"
|
||||
assert_file_mode "T10a mktemp -p /tmp mode 600 (CURL_AUTH_FILE pattern)" "$T10_AUTHFILE" "600"
|
||||
assert_file_contains "T10b printf header format (CURL_AUTH_FILE content)" "$T10_AUTHFILE" "Authorization: token secret-test-token-abc123"
|
||||
assert_file_contains "T10c 'header =' curl-config syntax" "$T10_AUTHFILE" 'header = "Authorization: token '
|
||||
rm -f "$T10_AUTHFILE"
|
||||
|
||||
# T12 — jq filter: non-author APPROVED included, dismissed excluded
|
||||
echo
|
||||
echo "== T12 jq filter =="
|
||||
# These are tested indirectly via T3 and T6 above, but let's also test
|
||||
# the jq expression directly.
|
||||
JQ_FILTER='.[]
|
||||
| select(.state == "APPROVED")
|
||||
| select(.dismissed != true)
|
||||
| select(.user.login != "alice")
|
||||
| .user.login'
|
||||
|
||||
T12_INPUT='[{"state":"APPROVED","dismissed":false,"user":{"login":"core-devops"}},{"state":"CHANGES_REQUESTED","dismissed":false,"user":{"login":"bob"}},{"state":"APPROVED","dismissed":false,"user":{"login":"alice"}},{"state":"APPROVED","dismissed":true,"user":{"login":"carol"}}]'
|
||||
|
||||
JQ_CMD=$(command -v jq 2>/dev/null || echo /tmp/jq)
|
||||
T12_CANDIDATES=$(echo "$T12_INPUT" | "$JQ_CMD" -r "$JQ_FILTER" 2>/dev/null | sort -u)
|
||||
assert_contains "T12 jq: core-devops (non-author APPROVED) in candidates" "core-devops" "$T12_CANDIDATES"
|
||||
assert_eq "T12 jq: alice (author) NOT in candidates" "" "$(echo "$T12_CANDIDATES" | grep '^alice$' || true)"
|
||||
assert_eq "T12 jq: carol (dismissed) NOT in candidates" "" "$(echo "$T12_CANDIDATES" | grep '^carol$' || true)"
|
||||
|
||||
echo
|
||||
echo "------"
|
||||
echo "PASS=$PASS FAIL=$FAIL"
|
||||
if [ "$FAIL" -gt 0 ]; then
|
||||
echo "Failed:$FAILED_TESTS"
|
||||
fi
|
||||
[ "$FAIL" -eq 0 ]
|
||||
@@ -85,5 +85,4 @@ jobs:
|
||||
REQUIRED_CHECKS: |
|
||||
Secret scan / Scan diff for credential-shaped strings (pull_request)
|
||||
sop-tier-check / tier-check (pull_request)
|
||||
CI / all-required (pull_request)
|
||||
run: bash .gitea/scripts/audit-force-merge.sh
|
||||
|
||||
@@ -23,11 +23,11 @@
|
||||
# `feedback_behavior_based_ast_gates` — NOT grep-by-name. That way
|
||||
# job renames or matrix-expansion-induced churn produce honest signal.
|
||||
#
|
||||
# NOTE on protection endpoint scope: `GET /repos/.../branch_protections/{branch}`
|
||||
# requires repo-admin role in Gitea 1.22.6. If DRIFT_BOT_TOKEN lacks it,
|
||||
# the script skips that branch with a clear ::error:: diagnostic and exits 0
|
||||
# (the issue IS the alarm, not a red workflow). See provisioning trail in
|
||||
# the run step's GITEA_TOKEN env comment.
|
||||
# IMPORTANT — TRANSITIONAL STATE: molecule-core's ci.yml does NOT yet
|
||||
# contain the `all-required` sentinel job (RFC §4 Phase 4 adds it).
|
||||
# Until Phase 4 lands the detector will hard-fail with exit 3 on the
|
||||
# missing sentinel. That's intentional: a red workflow on a 5-min cron
|
||||
# is louder than a silent issue and forces Phase 4 to land soon.
|
||||
|
||||
name: ci-required-drift
|
||||
|
||||
@@ -77,18 +77,13 @@ jobs:
|
||||
run: python -m pip install --quiet 'PyYAML==6.0.2'
|
||||
- name: Run drift detector
|
||||
env:
|
||||
# DRIFT_BOT_TOKEN is owned by mc-drift-bot, a least-privilege
|
||||
# Gitea persona whose ONLY job is reading branch_protections
|
||||
# and posting the [ci-drift] tracking issue. The endpoint
|
||||
# `GET /repos/.../branch_protections/{branch}` requires
|
||||
# repo-ADMIN role (Gitea 1.22.6) — SOP_TIER_CHECK_TOKEN and the
|
||||
# auto-injected GITHUB_TOKEN do NOT have it (read-only / write
|
||||
# without admin), so the previous fallback chain 403'd.
|
||||
# Mirrors the controlplane fix landed in CP PR#134.
|
||||
# Provisioning trail: internal#329 (audit) + parent pattern
|
||||
# internal#327 (publish-runtime-bot). Per
|
||||
# `feedback_per_agent_gitea_identity_default`.
|
||||
GITEA_TOKEN: ${{ secrets.DRIFT_BOT_TOKEN }}
|
||||
# GITEA_TOKEN reads protection + writes issues. molecule-core
|
||||
# uses `SOP_TIER_CHECK_TOKEN` as the org-level secret name for
|
||||
# read-only Gitea API access from CI (set by audit-force-merge
|
||||
# and sop-tier-check too). Falls back to the auto-injected
|
||||
# GITHUB_TOKEN if the org-level secret isn't set
|
||||
# (transitional repos).
|
||||
GITEA_TOKEN: ${{ secrets.SOP_TIER_CHECK_TOKEN || secrets.GITHUB_TOKEN }}
|
||||
GITEA_HOST: git.moleculesai.app
|
||||
REPO: ${{ github.repository }}
|
||||
# Branches whose protection we compare against. molecule-core
|
||||
|
||||
+8
-135
@@ -70,12 +70,10 @@ jobs:
|
||||
changes:
|
||||
name: Detect changes
|
||||
runs-on: ubuntu-latest
|
||||
# Phase 4 (RFC #219 §1): all required jobs >=98% green on main.
|
||||
# Flip confirmed 2026-05-12 via combined-status check of latest main
|
||||
# commit (all CI jobs green). `all-required` sentinel hard-fails
|
||||
# when this job fails; no Phase 3 suppression needed.
|
||||
# revert: add `continue-on-error: true` back if regressions appear.
|
||||
continue-on-error: false
|
||||
# Phase 3 (RFC #219 §1): surface broken workflows without blocking
|
||||
# the PR. Follow-up PR flips this off after the surfaced defects
|
||||
# (if any) are triaged.
|
||||
continue-on-error: true
|
||||
outputs:
|
||||
platform: ${{ steps.check.outputs.platform }}
|
||||
canvas: ${{ steps.check.outputs.canvas }}
|
||||
@@ -126,29 +124,7 @@ jobs:
|
||||
name: Platform (Go)
|
||||
needs: changes
|
||||
runs-on: ubuntu-latest
|
||||
# mc#664 (interim): re-mask platform-build pending fix-forward. Phase 4
|
||||
# (#656) flipped this to continue-on-error: false based on a Phase-3-masked
|
||||
# "green on main 2026-05-12" — the prior continue-on-error: true had
|
||||
# been hiding failing tests in workspace-server/internal/handlers/.
|
||||
# Two distinct failure classes surfaced on 0e5152c3:
|
||||
# (1) 4x delegation_test.go (lines 1110/1176/1228/1271): helpers
|
||||
# expectExecuteDelegationBase/Success/Failed are missing sqlmock
|
||||
# expectations for queries production has issued since ~2026-04-21
|
||||
# (last_outbound_at UPDATE, lookupDeliveryMode/Runtime SELECTs,
|
||||
# a2a_receive INSERT activity_logs, recordLedgerStatus writes).
|
||||
# Halt cond #3 applies (regression > 7 days → broader sweep).
|
||||
# (2) 1x mcp_test.go:433 (TestMCPHandler_CommitMemory_GlobalScope_Blocked):
|
||||
# commit 7d1a189f (2026-05-10) hardened mcp.go to scrub err.Error()
|
||||
# from JSON-RPC responses (OFFSEC-001), but the test asserts the
|
||||
# error message contains "GLOBAL". Production-vs-test contract
|
||||
# collision — needs design call, not mock update.
|
||||
# Time-boxed Option A (90 min) did not fit the cross-cutting scope.
|
||||
# This is a sequenced revert→fix→reflip per
|
||||
# feedback_strict_root_only_after_class_a emergency clause — NOT
|
||||
# a permanent re-mask. Re-flip blocked on mc#664 fix-forward landing.
|
||||
# Other 4 #656 flips (changes, canvas-build, shellcheck, python-lint)
|
||||
# retain continue-on-error: false; only platform-build regresses.
|
||||
continue-on-error: true # mc#664 fix-forward in flight; re-flip when tests pass
|
||||
continue-on-error: true
|
||||
defaults:
|
||||
run:
|
||||
working-directory: workspace-server
|
||||
@@ -172,21 +148,6 @@ jobs:
|
||||
- if: needs.changes.outputs.platform == 'true'
|
||||
name: Run golangci-lint
|
||||
run: golangci-lint run --timeout 3m ./... || true
|
||||
- if: needs.changes.outputs.platform == 'true'
|
||||
name: Diagnostic — per-package verbose 60s
|
||||
run: |
|
||||
set +e
|
||||
go test -race -v -timeout 60s ./internal/handlers/... 2>&1 | tee /tmp/test-handlers.log
|
||||
handlers_exit=$?
|
||||
go test -race -v -timeout 60s ./internal/pendinguploads/... 2>&1 | tee /tmp/test-pu.log
|
||||
pu_exit=$?
|
||||
echo "::group::handlers exit=$handlers_exit (last 100 lines)"
|
||||
tail -100 /tmp/test-handlers.log
|
||||
echo "::endgroup::"
|
||||
echo "::group::pendinguploads exit=$pu_exit (last 100 lines)"
|
||||
tail -100 /tmp/test-pu.log
|
||||
echo "::endgroup::"
|
||||
continue-on-error: true
|
||||
- if: needs.changes.outputs.platform == 'true'
|
||||
name: Run tests with race detection and coverage
|
||||
run: go test -race -coverprofile=coverage.out ./...
|
||||
@@ -295,8 +256,7 @@ jobs:
|
||||
name: Canvas (Next.js)
|
||||
needs: changes
|
||||
runs-on: ubuntu-latest
|
||||
# Phase 4 (RFC #219 §1): confirmed green on main 2026-05-12.
|
||||
continue-on-error: false
|
||||
continue-on-error: true
|
||||
defaults:
|
||||
run:
|
||||
working-directory: canvas
|
||||
@@ -342,8 +302,7 @@ jobs:
|
||||
name: Shellcheck (E2E scripts)
|
||||
needs: changes
|
||||
runs-on: ubuntu-latest
|
||||
# Phase 4 (RFC #219 §1): confirmed green on main 2026-05-12.
|
||||
continue-on-error: false
|
||||
continue-on-error: true
|
||||
steps:
|
||||
- if: needs.changes.outputs.scripts != 'true'
|
||||
run: echo "No tests/e2e/ or infra/scripts/ changes — skipping real shellcheck; this job always runs to satisfy the required-check name on branch protection."
|
||||
@@ -418,8 +377,7 @@ jobs:
|
||||
name: Python Lint & Test
|
||||
needs: changes
|
||||
runs-on: ubuntu-latest
|
||||
# Phase 4 (RFC #219 §1): confirmed green on main 2026-05-12.
|
||||
continue-on-error: false
|
||||
continue-on-error: true
|
||||
env:
|
||||
WORKSPACE_ID: test
|
||||
defaults:
|
||||
@@ -493,88 +451,3 @@ jobs:
|
||||
echo " adjusting the floor with rationale in COVERAGE_FLOOR.md."
|
||||
exit 1
|
||||
fi
|
||||
|
||||
all-required:
|
||||
# Aggregator sentinel — RFC internal#219 §2 (Phase 4 — closes internal#286).
|
||||
#
|
||||
# Single stable required-status name that branch protection points at;
|
||||
# CI churns underneath in `needs:` without any protection edits. Mirrors
|
||||
# the molecule-controlplane Phase 2a impl shipped in CP PR#112 and
|
||||
# referenced by `internal#286` ("Phase 4 is a single small PR... mirrors
|
||||
# CP's existing one").
|
||||
#
|
||||
# Closes the failure mode where status_check_contexts on molecule-core/main
|
||||
# only listed `Secret scan` + `sop-tier-check` (the 2 meta-gates), so real
|
||||
# `Platform (Go)` / `Canvas (Next.js)` / `Python Lint & Test` / `Shellcheck`
|
||||
# red silently merged through. See internal#286 for the three concrete
|
||||
# tonight-of-2026-05-11 incidents that prompted the emergency bump.
|
||||
#
|
||||
# Three properties of this job each close a failure mode:
|
||||
#
|
||||
# 1. `if: always()` — runs even when an upstream fails. Without it the
|
||||
# sentinel is `skipped` and protection treats that as missing → merge
|
||||
# ungated.
|
||||
#
|
||||
# 2. Assertion is `result == "success"` per dep, NOT `!= "failure"`.
|
||||
# A `skipped` upstream (job gated by `if:` evaluating false, matrix
|
||||
# entry that couldn't run) must NOT silently pass through.
|
||||
# `skipped`-as-green is exactly the failure mode this gate closes.
|
||||
#
|
||||
# 3. `needs:` is the canonical list of "what counts as required."
|
||||
# status_check_contexts will reference only `ci/all-required` (Step 5
|
||||
# follow-up — branch-protection PATCH is Owners-tier per
|
||||
# `feedback_never_admin_merge_bypass`, separate PR); a new job is
|
||||
# added simply by listing it in `needs:` here.
|
||||
# `.gitea/workflows/ci-required-drift.yml` files a [ci-drift] issue
|
||||
# hourly if this list diverges from status_check_contexts or from
|
||||
# audit-force-merge.yml's REQUIRED_CHECKS env (RFC §4 + §6).
|
||||
#
|
||||
# Excluded from `needs:`: `canvas-deploy-reminder` — gated by
|
||||
# `if: ... github.event_name == 'push' && github.ref == 'refs/heads/main'`,
|
||||
# so on PR events it's legitimately `skipped`. The drift detector
|
||||
# explicitly excludes `github.event_name`-gated jobs from F1 (see
|
||||
# `.gitea/scripts/ci-required-drift.py::ci_job_names`).
|
||||
#
|
||||
# Phase 3 (RFC #219 §1) safety: continue-on-error here so the sentinel
|
||||
# does not hard-fail and block PRs while the underlying build jobs are
|
||||
# still in Phase 3 (continue-on-error: true suppresses their status to null).
|
||||
# When Phase 3 ends (defects fixed, continue-on-error flipped off on build
|
||||
# jobs), remove continue-on-error here so the sentinel again hard-fails.
|
||||
continue-on-error: true
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 1
|
||||
needs:
|
||||
- changes
|
||||
- platform-build
|
||||
- canvas-build
|
||||
- shellcheck
|
||||
- python-lint
|
||||
if: always()
|
||||
steps:
|
||||
- name: Assert every required dependency succeeded
|
||||
run: |
|
||||
set -euo pipefail
|
||||
# `needs.*.result` is one of: success | failure | cancelled | skipped | null.
|
||||
# We assert success per dep (not != failure) — see RFC §2 reasoning above.
|
||||
# Null results are skipped: they come from Phase 3 (continue-on-error: true
|
||||
# suppresses status) or from jobs still in-flight. The sentinel succeeds
|
||||
# rather than blocking PRs on Phase 3 noise.
|
||||
results='${{ toJSON(needs) }}'
|
||||
echo "$results"
|
||||
echo "$results" | python3 -c '
|
||||
import json, sys
|
||||
ns = json.load(sys.stdin)
|
||||
# Exclude null (Phase 3 suppressed / in-flight) from the bad list.
|
||||
bad = [(k, v.get("result")) for k, v in ns.items()
|
||||
if v.get("result") not in ("success", None)]
|
||||
if bad:
|
||||
print(f"FAIL: jobs not green:", file=sys.stderr)
|
||||
for k, r in bad:
|
||||
print(f" - {k}: {r}", file=sys.stderr)
|
||||
sys.exit(1)
|
||||
pending = [(k, v.get("result")) for k, v in ns.items() if v.get("result") is None]
|
||||
if pending:
|
||||
print(f"WARN: {len(pending)} job(s) still in-flight (result=null): " +
|
||||
", ".join(k for k, _ in pending), file=sys.stderr)
|
||||
print(f"OK: all {len(ns)} required jobs succeeded (or Phase-3 suppressed)")
|
||||
'
|
||||
|
||||
@@ -24,22 +24,17 @@ name: E2E Staging SaaS (full lifecycle)
|
||||
# PRs don't need to read.
|
||||
#
|
||||
# Triggers:
|
||||
# - Push to main (regression guard — fires on merges to main, not on PR updates)
|
||||
# - pull_request: pr-validate always posts success; real E2E step runs only
|
||||
# when provisioning-critical files change (detect-changes gates the step).
|
||||
# - Push to main (regression guard)
|
||||
# - workflow_dispatch (manual re-run from UI)
|
||||
# - Nightly cron (catches drift even when no pushes land)
|
||||
#
|
||||
# NOTE: A separate pr-validate job handles the pull_request path so this
|
||||
# workflow posts CI status for workflow-only PRs. Without it, a PR that
|
||||
# only touches the workflow file has no status check (workflow only fires
|
||||
# on push, not PR branches), which blocks merge under branch protection.
|
||||
# The E2E step itself only runs when provisioning-critical files change —
|
||||
# pr-validate always posts success, avoiding the double-fire that motivated
|
||||
# the pull_request-trigger removal in PRs #516/#530.
|
||||
# - Changes to any provisioning-critical file under PR review (opt-in
|
||||
# via the same paths watcher that e2e-api.yml uses)
|
||||
|
||||
on:
|
||||
# Trunk-based (Phase 3 of internal#81): main is the only branch.
|
||||
# Previously this fired on staging push too because staging was a
|
||||
# superset of main and ran the gate ahead of auto-promote; with no
|
||||
# staging branch, main is where E2E gates the deploy.
|
||||
push:
|
||||
branches: [main]
|
||||
paths:
|
||||
@@ -60,7 +55,6 @@ on:
|
||||
- 'workspace-server/internal/provisioner/**'
|
||||
- 'tests/e2e/test_staging_full_saas.sh'
|
||||
- '.gitea/workflows/e2e-staging-saas.yml'
|
||||
workflow_dispatch:
|
||||
schedule:
|
||||
# 07:00 UTC every day — catches AMI drift, WorkOS cert rotation,
|
||||
# Cloudflare API regressions, etc. even on quiet days.
|
||||
@@ -78,36 +72,9 @@ env:
|
||||
GITHUB_SERVER_URL: https://git.moleculesai.app
|
||||
|
||||
jobs:
|
||||
# PR-validation path: always posts success so branch protection can merge
|
||||
# workflow-only PRs. The actual E2E step only runs when provisioning-
|
||||
# critical files change (git-paths filter + if: guard below).
|
||||
# All steps use continue-on-error: true so runner issues do not block merge.
|
||||
pr-validate:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
with:
|
||||
fetch-depth: 1
|
||||
continue-on-error: true
|
||||
|
||||
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
|
||||
with:
|
||||
python-version: "3.11"
|
||||
continue-on-error: true
|
||||
|
||||
- name: YAML validation (best-effort)
|
||||
run: |
|
||||
echo "e2e-staging-saas.yml — PR validation: workflow YAML is valid."
|
||||
echo "E2E step runs only when provisioning-critical files change."
|
||||
continue-on-error: true
|
||||
|
||||
# Actual E2E: runs on trunk pushes (main + staging). NOT the PR-fire-only
|
||||
# path — pr-validate above posts success for workflow-only PRs.
|
||||
e2e-staging-saas:
|
||||
name: E2E Staging SaaS
|
||||
runs-on: ubuntu-latest
|
||||
# Only runs on trunk pushes. PR paths get pr-validate instead.
|
||||
if: github.event.pull_request.base.ref == ''
|
||||
# Phase 3 (RFC #219 §1): surface broken workflows without blocking.
|
||||
continue-on-error: true
|
||||
timeout-minutes: 45
|
||||
|
||||
@@ -23,14 +23,17 @@ on:
|
||||
schedule:
|
||||
# Hourly: refresh all open PRs
|
||||
- cron: '8 * * * *'
|
||||
# NOTE: `workflow_dispatch.inputs` block intentionally omitted.
|
||||
# Gitea 1.22.6 parser rejects `workflow_dispatch.inputs.X` with
|
||||
# "unknown on type" — it mis-treats the inputs sub-keys as top-level
|
||||
# `on:` event types. Dropping the inputs block restores parsing.
|
||||
# Manual dispatch from the Gitea UI works without the inputs schema
|
||||
# (github.event.inputs.X returns empty); the script falls back to
|
||||
# iterating all open PRs when PR_NUMBER is empty.
|
||||
workflow_dispatch:
|
||||
inputs:
|
||||
pr_number:
|
||||
description: 'PR number to check (omit for all open PRs)'
|
||||
required: false
|
||||
type: string
|
||||
post_comment:
|
||||
description: 'Post comment on PR'
|
||||
required: false
|
||||
type: string
|
||||
default: 'true'
|
||||
|
||||
env:
|
||||
GITHUB_SERVER_URL: https://git.moleculesai.app
|
||||
@@ -40,12 +43,7 @@ jobs:
|
||||
runs-on: ubuntu-latest
|
||||
continue-on-error: true # Never block on our own detector failing
|
||||
steps:
|
||||
- name: Check out BASE ref (never PR-head under pull_request_target)
|
||||
# pull_request_target runs with repo secrets-context, so checking out
|
||||
# the PR HEAD would execute PR-branch gate_check.py with secrets.
|
||||
# Fix: always load gate_check.py from the trusted base/default ref.
|
||||
# Bug-1 (self-loop exclusion) + Bug-3 (403→exit0) from #547 are
|
||||
# kept; only this checkout-ref regresses to pre-#547 behavior.
|
||||
- name: Check out base branch (for the script)
|
||||
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
with:
|
||||
ref: ${{ github.event.pull_request.base.sha || github.ref_name }}
|
||||
@@ -71,12 +69,8 @@ jobs:
|
||||
run: |
|
||||
set -euo pipefail
|
||||
# Fetch all open PRs and run gate-check on each
|
||||
# socket.setdefaulttimeout(15): defence-in-depth for missing SOP_TIER_CHECK_TOKEN.
|
||||
# gate_check.py uses timeout=15 on every urlopen call; this catches the
|
||||
# inline Python polling loop too (issue #603).
|
||||
pr_numbers=$(python3 -c "
|
||||
import socket, urllib.request, json, os
|
||||
socket.setdefaulttimeout(15)
|
||||
import urllib.request, json, os
|
||||
token = os.environ['GITEA_TOKEN']
|
||||
req = urllib.request.Request(
|
||||
'https://git.moleculesai.app/api/v1/repos/${{ github.repository }}/pulls?state=open&limit=100',
|
||||
|
||||
@@ -34,7 +34,7 @@ name: Harness Replays
|
||||
# One job → one check run → branch-protection-clean (the SKIPPED-in-set
|
||||
# trap from PR #2264 is documented in e2e-api.yml's e2e-api job comment).
|
||||
|
||||
"on":
|
||||
on:
|
||||
push:
|
||||
branches: [main, staging]
|
||||
paths:
|
||||
@@ -74,16 +74,6 @@ jobs:
|
||||
# GitHub event variables, so no local history is needed.
|
||||
fetch-depth: 1
|
||||
- id: decide
|
||||
env:
|
||||
# Pass via env block — env values bypass shell quoting so single
|
||||
# quotes in merge-commit messages (e.g. "Merge pull request 'fix: ...'
|
||||
# from branch into main") cannot break the bash parser. The prior
|
||||
# `echo '${{ toJSON(...) }}'` form broke on every main-push because
|
||||
# every main commit is a merge commit with single quotes in the
|
||||
# message body — the embedded `'` ended the single-quoted shell string
|
||||
# mid-JSON, and a subsequent `(` (e.g. in `(#523)`) was parsed as a
|
||||
# subshell, causing "syntax error near unexpected token `('".
|
||||
COMMITS_JSON: ${{ toJSON(github.event.commits) }}
|
||||
run: |
|
||||
set -euo pipefail
|
||||
|
||||
@@ -94,31 +84,21 @@ jobs:
|
||||
exit 0
|
||||
fi
|
||||
|
||||
# Determine changed files.
|
||||
# workflow_dispatch: always run.
|
||||
# pull_request: use Compare API (branch-to-branch works fine).
|
||||
# push: use github.event.commits array (Compare API rejects SHA-to-branch).
|
||||
# new-branch: run everything.
|
||||
# Determine base and head refs for the Compare API call.
|
||||
# Gitea Compare API requires branch/tag names (SHAs return BaseNotExist).
|
||||
# Pull request: base.ref + head.ref are in the event payload.
|
||||
# Push: github.ref → extract branch name for the Compare API.
|
||||
if [ "${{ github.event_name }}" = "pull_request" ]; then
|
||||
BASE="${{ github.event.pull_request.base.ref }}"
|
||||
HEAD="${{ github.event.pull_request.head.ref }}"
|
||||
elif [ -n "${{ github.event.before }}" ] && \
|
||||
! echo "${{ github.event.before }}" | grep -qE '^0+$'; then
|
||||
# Push event: extract changed files from github.event.commits array.
|
||||
# Gitea Compare API rejects SHA-to-branch comparisons (BaseNotExist),
|
||||
# so we use the commits array instead. This array contains all commits
|
||||
# in the push, each with their added/removed/modified file lists.
|
||||
printf '%s' "$COMMITS_JSON" \
|
||||
| bash .gitea/scripts/push-commits-diff-files.py \
|
||||
> .push-diff-files.txt 2>/dev/null || true
|
||||
DIFF_FILES=$(cat .push-diff-files.txt 2>/dev/null || true)
|
||||
if [ -n "$DIFF_FILES" ] && echo "$DIFF_FILES" | grep -qE '^workspace-server/|^canvas/|^tests/harness/|^.gitea/workflows/harness-replays\.yml$'; then
|
||||
echo "run=true" >> "$GITHUB_OUTPUT"
|
||||
else
|
||||
echo "run=false" >> "$GITHUB_OUTPUT"
|
||||
fi
|
||||
echo "debug=push-files=$DIFF_FILES" >> "$GITHUB_OUTPUT"
|
||||
exit 0
|
||||
# Extract branch name from refs/heads/main -> main
|
||||
BASE_REF="${GITHUB_REF#refs/heads/}"
|
||||
BASE_REF="${BASE_REF:-main}"
|
||||
HEAD_REF="${GITHUB_REF#refs/heads/}"
|
||||
BASE="$BASE_REF"
|
||||
HEAD="$HEAD_REF"
|
||||
else
|
||||
# New branch or github.event.before unavailable — run everything.
|
||||
echo "run=true" >> "$GITHUB_OUTPUT"
|
||||
@@ -126,13 +106,25 @@ jobs:
|
||||
exit 0
|
||||
fi
|
||||
|
||||
# Call Gitea Compare API (pull_request path only — branch-to-branch).
|
||||
# Push uses github.event.commits array above.
|
||||
# Call Gitea Compare API to get the list of changed files.
|
||||
# This is a Gitea-to-Gitea API call from within the Gitea Actions
|
||||
# runner — it hits the local Gitea process, not the external network.
|
||||
# No git network access needed from the runner container
|
||||
# (runbooks/gitea-operational-quirks.md §runner-network-isolation).
|
||||
#
|
||||
# API shape: GET /repos/{owner}/{repo}/compare/{base}...{head}
|
||||
# Returns { commits: [{ files: [{filename}] }] } — files are
|
||||
# nested inside commits (Gitea quirk, not at top level).
|
||||
RESP=$(curl -sS --fail --max-time 30 \
|
||||
-H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
|
||||
-H "Accept: application/json" \
|
||||
"$GITHUB_SERVER_URL/api/v1/repos/$GITHUB_REPOSITORY/compare/$BASE...$HEAD")
|
||||
DIFF_FILES=$(echo "$RESP" | bash .gitea/scripts/compare-api-diff-files.py 2>/dev/null || true)
|
||||
DIFF_FILES=$(echo "$RESP" | python3 -c "
|
||||
import sys; import json
|
||||
d = json.load(sys.stdin)
|
||||
files = [f.get('filename','') for c in d.get('commits',[]) for f in c.get('files',[]) if f.get('filename')]
|
||||
print('\n'.join(files))
|
||||
" 2>/dev/null || true)
|
||||
|
||||
echo "debug=diff-base=$BASE diff-files=$DIFF_FILES" >> "$GITHUB_OUTPUT"
|
||||
|
||||
@@ -220,14 +212,12 @@ jobs:
|
||||
run: |
|
||||
set -euo pipefail
|
||||
if [ -z "${MOLECULE_GITEA_TOKEN}" ]; then
|
||||
echo "::warning::AUTO_SYNC_TOKEN not set — using anonymous clone (repos are public per manifest.json OSS contract)"
|
||||
echo "::error::AUTO_SYNC_TOKEN secret is empty — register the devops-engineer persona PAT in repo Actions secrets"
|
||||
exit 1
|
||||
fi
|
||||
mkdir -p .tenant-bundle-deps
|
||||
# Strip JSON5 comments before jq parsing — Integration Tester appends
|
||||
# `// Triggered by ...` which breaks `jq` in clone-manifest.sh.
|
||||
sed '/^[[:space:]]*\/\//d' manifest.json > .manifest-stripped.json
|
||||
bash scripts/clone-manifest.sh \
|
||||
.manifest-stripped.json \
|
||||
manifest.json \
|
||||
.tenant-bundle-deps/workspace-configs-templates \
|
||||
.tenant-bundle-deps/org-templates \
|
||||
.tenant-bundle-deps/plugins
|
||||
|
||||
@@ -37,11 +37,6 @@ name: main-red-watchdog
|
||||
# "unknown on type" when `workflow_dispatch.inputs.X` is present. Revisit
|
||||
# when Gitea ≥ 1.23 is fleet-wide.
|
||||
on:
|
||||
# SCHEDULE RE-ENABLED 2026-05-12 rev3 — interim disable (mc#645) reverted alongside
|
||||
# status-reaper rev3 (widen-window). Job-level timeout-minutes raised 5 → 15 below
|
||||
# to absorb runner-saturation latency without spurious cancels (the original cascade
|
||||
# cause). If runner-saturation root persists, the dedicated-runner-label split
|
||||
# remains the structural next step (tracked separately).
|
||||
schedule:
|
||||
# Hourly at :05 — task spec calls for "off-zero" (`5 * * * *`),
|
||||
# offset from :17 (ci-required-drift) and :00 (peak cron load).
|
||||
@@ -63,12 +58,7 @@ concurrency:
|
||||
jobs:
|
||||
watchdog:
|
||||
runs-on: ubuntu-latest
|
||||
# rev3 (2026-05-12, mc#645 revert): raised 5 → 15 to absorb runner-saturation
|
||||
# latency. Original 5min cap was producing 124-style cancels under load,
|
||||
# which fed the very `[main-red]` issues this workflow files (self-poisoning).
|
||||
# 15min is still well below Gitea-default 6h job ceiling; if a real hang
|
||||
# occurs the issue-file path is still the alarm surface.
|
||||
timeout-minutes: 15
|
||||
timeout-minutes: 5
|
||||
steps:
|
||||
- name: Check out repo (script lives at .gitea/scripts/)
|
||||
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
|
||||
@@ -54,12 +54,6 @@ env:
|
||||
jobs:
|
||||
build-and-push:
|
||||
name: Build & push canvas image
|
||||
# REVERTED (infra/revert-docker-runner-label): `runs-on: ubuntu-latest` restored.
|
||||
# The `docker` label is not registered on any act_runner. `runs-on: [ubuntu-latest, docker]`
|
||||
# causes jobs to queue indefinitely with zero eligible runners — strictly worse than the
|
||||
# pre-#599 coin-flip (50% success rate). Once the `docker` label is registered on
|
||||
# ≥2 runners, re-apply the fix from #599 (infra/docker-runner-label).
|
||||
# See issue #576 + infra-lead pulse ~00:30Z.
|
||||
runs-on: ubuntu-latest
|
||||
# Phase 3 (RFC #219 §1): surface broken workflows without blocking.
|
||||
continue-on-error: true
|
||||
@@ -85,10 +79,8 @@ jobs:
|
||||
run: |
|
||||
set -euo pipefail
|
||||
echo "::group::Docker daemon health check"
|
||||
echo "Runner: ${HOSTNAME:-unknown}"
|
||||
docker info 2>&1 | head -5 || {
|
||||
echo "::error::Docker daemon is not accessible at /var/run/docker.sock"
|
||||
echo "::error::Runner: ${HOSTNAME:-unknown}"
|
||||
echo "::error::Check: (1) daemon running, (2) runner user in docker group, (3) sock perms 660+"
|
||||
exit 1
|
||||
}
|
||||
|
||||
@@ -23,23 +23,12 @@ name: publish-runtime-autobump
|
||||
# and try to tag 0.1.130 simultaneously, only one of which would land.
|
||||
|
||||
on:
|
||||
# Run on PR pushes to post a success status so Gitea can merge the PR.
|
||||
# All steps use continue-on-error: true so operational failures
|
||||
# (PyPI unreachable, DISPATCH_TOKEN missing) do not block merge.
|
||||
pull_request:
|
||||
paths:
|
||||
- "workspace/**"
|
||||
# Bump-and-tag on main/staging push (the actual operational trigger).
|
||||
push:
|
||||
branches:
|
||||
- main
|
||||
- staging
|
||||
paths:
|
||||
- "workspace/**"
|
||||
# Manual dispatch — useful when Gitea Actions API (/actions/*) is
|
||||
# unreachable (e.g. act_runner 404 on Gitea 1.22.6) and we cannot
|
||||
# re-trigger via curl.
|
||||
workflow_dispatch:
|
||||
|
||||
permissions:
|
||||
contents: write # required to push tags back
|
||||
@@ -49,52 +38,22 @@ concurrency:
|
||||
cancel-in-progress: false
|
||||
|
||||
jobs:
|
||||
# PR-validation path: always succeeds so Gitea can merge workflow-only PRs.
|
||||
# Operational failures (PyPI unreachable, missing DISPATCH_TOKEN) are
|
||||
# surfaced via continue-on-error: true rather than blocking the merge.
|
||||
# The actual bump work happens on the main/staging push after merge.
|
||||
pr-validate:
|
||||
autobump-and-tag:
|
||||
runs-on: ubuntu-latest
|
||||
continue-on-error: true # do not block PR merge on operational failures
|
||||
steps:
|
||||
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
with:
|
||||
fetch-depth: 1
|
||||
|
||||
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
|
||||
with:
|
||||
python-version: "3.11"
|
||||
|
||||
- name: Validate PyPI connectivity (best-effort)
|
||||
run: |
|
||||
set -eu
|
||||
echo "=== Checking PyPI accessibility ==="
|
||||
LATEST=$(curl -fsS --retry 3 --max-time 10 \
|
||||
https://pypi.org/pypi/molecule-ai-workspace-runtime/json \
|
||||
| python -c "import sys,json; print(json.load(sys.stdin)['info']['version'])" \
|
||||
|| echo "PyPI unreachable (non-blocking for PR validation)")
|
||||
echo "Latest: ${LATEST:-unknown}"
|
||||
|
||||
# Actual bump-and-tag: runs on main/staging pushes, posts real success/failure.
|
||||
# No continue-on-error — operational failures here trip the main-red
|
||||
# watchdog, which is the desired signal for infrastructure degradation.
|
||||
bump-and-tag:
|
||||
runs-on: ubuntu-latest
|
||||
# Only fire on push events (main/staging after PR merge). Pull_request
|
||||
# events are handled by pr-validate above; we do NOT bump on every
|
||||
# push-synchronize because that would race with the PR head.
|
||||
#
|
||||
# NOTE: the prior condition `github.event.pull_request.base.ref == ''`
|
||||
# was broken — on a PR-merge push in Gitea Actions, the pull_request
|
||||
# context is still attached (base.ref='main'), so the condition always
|
||||
# evaluated to false and bump-and-tag was permanently skipped.
|
||||
if: github.event_name == 'push'
|
||||
steps:
|
||||
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
with:
|
||||
# Shallow clone — depth 1 is enough for the workspace-diff check.
|
||||
# Tags needed for the collision check below are fetched explicitly
|
||||
# in the next step, bypassing the runner-network timeout that
|
||||
# full-history fetch triggers on Gitea Actions runners
|
||||
# (runbooks/gitea-operational-quirks.md §runner-network-isolation).
|
||||
fetch-depth: 1
|
||||
|
||||
- name: Fetch tags for collision check
|
||||
# fetch-depth: 1 gets only the most recent commit's refs, not the
|
||||
# tag that points at it. Do a targeted tag fetch so git tag --list
|
||||
# below can detect collision with prior manual pushes.
|
||||
run: git fetch origin --tags --depth=1
|
||||
|
||||
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
|
||||
|
||||
@@ -32,9 +32,11 @@ on:
|
||||
- '.gitea/workflows/publish-workspace-server-image.yml'
|
||||
workflow_dispatch:
|
||||
|
||||
# Serialize per-branch so two rapid main pushes don't race the same
|
||||
# :staging-latest tag retag. Allow parallel runs as they produce
|
||||
# different :staging-<sha> tags and last-write-wins on :staging-latest.
|
||||
# Serialize per-branch so two rapid staging pushes don't race the same
|
||||
# :staging-latest tag retag. Allow staging and main to run in parallel
|
||||
# (different GITHUB_REF → different concurrency group) since they
|
||||
# produce different :staging-<sha> tags and last-write-wins on
|
||||
# :staging-latest is acceptable across branches.
|
||||
#
|
||||
# cancel-in-progress: false → in-flight builds finish; the next push's
|
||||
# build queues. This avoids a partially-pushed image.
|
||||
@@ -52,12 +54,6 @@ env:
|
||||
|
||||
jobs:
|
||||
build-and-push:
|
||||
# REVERTED (infra/revert-docker-runner-label): `runs-on: ubuntu-latest` restored.
|
||||
# The `docker` label is not registered on any act_runner. `runs-on: [ubuntu-latest, docker]`
|
||||
# causes jobs to queue indefinitely with zero eligible runners — strictly worse than the
|
||||
# pre-#599 coin-flip (50% success rate). Once the `docker` label is registered on
|
||||
# ≥2 runners, re-apply the fix from #599 (infra/docker-runner-label).
|
||||
# See issue #576 + infra-lead pulse ~00:30Z.
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Checkout
|
||||
@@ -74,10 +70,8 @@ jobs:
|
||||
run: |
|
||||
set -euo pipefail
|
||||
echo "::group::Docker daemon health check"
|
||||
echo "Runner: ${HOSTNAME:-unknown}"
|
||||
docker info 2>&1 | head -5 || {
|
||||
echo "::error::Docker daemon is not accessible at /var/run/docker.sock"
|
||||
echo "::error::Runner: ${HOSTNAME:-unknown}"
|
||||
echo "::error::Check: (1) daemon is running, (2) runner user is in docker group, (3) sock permissions are 660+"
|
||||
exit 1
|
||||
}
|
||||
@@ -100,15 +94,13 @@ jobs:
|
||||
MOLECULE_GITEA_TOKEN: ${{ secrets.AUTO_SYNC_TOKEN }}
|
||||
run: |
|
||||
set -euo pipefail
|
||||
# clone-manifest.sh supports anonymous cloning for public repos (post-
|
||||
# 2026-05-08 migration). The token is only needed for private repos.
|
||||
# Do NOT require it — a missing secret would fail the build unnecessarily.
|
||||
if [ -z "${MOLECULE_GITEA_TOKEN}" ]; then
|
||||
echo "::error::AUTO_SYNC_TOKEN secret is empty"
|
||||
exit 1
|
||||
fi
|
||||
mkdir -p .tenant-bundle-deps
|
||||
# Strip JSON5 comments before jq parsing — Integration Tester appends
|
||||
# `// Triggered by ...` which breaks `jq` in clone-manifest.sh.
|
||||
sed '/^[[:space:]]*\/\//d' manifest.json > .manifest-stripped.json
|
||||
bash scripts/clone-manifest.sh \
|
||||
.manifest-stripped.json \
|
||||
manifest.json \
|
||||
.tenant-bundle-deps/workspace-configs-templates \
|
||||
.tenant-bundle-deps/org-templates \
|
||||
.tenant-bundle-deps/plugins
|
||||
@@ -125,11 +117,6 @@ jobs:
|
||||
# Build + push platform image (inline ECR auth — mirrors the operator-host
|
||||
# approach; credentials come from GITHUB_SECRET_AWS_ACCESS_KEY_ID /
|
||||
# GITHUB_SECRET_AWS_SECRET_ACCESS_KEY in Gitea Actions).
|
||||
# docker buildx bake / build required for `imagetools inspect` digest
|
||||
# capture in the CP pin-update step (RFC internal#229 §X step 4 PR-1).
|
||||
- name: Set up Docker Buildx
|
||||
uses: docker/setup-buildx-action@4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd # v4.0.0
|
||||
|
||||
- name: Build & push platform image to ECR (staging-<sha> + staging-latest)
|
||||
env:
|
||||
IMAGE_NAME: ${{ env.IMAGE_NAME }}
|
||||
@@ -145,16 +132,17 @@ jobs:
|
||||
ECR_REGISTRY="${IMAGE_NAME%%/*}"
|
||||
aws ecr get-login-password --region us-east-2 | \
|
||||
docker login --username AWS --password-stdin "${ECR_REGISTRY}"
|
||||
docker buildx build \
|
||||
docker build \
|
||||
--file ./workspace-server/Dockerfile \
|
||||
--build-arg GIT_SHA="${GIT_SHA}" \
|
||||
--label "org.opencontainers.image.source=https://git.moleculesai.app/molecule-ai/${REPO}" \
|
||||
--label "org.opencontainers.image.source=https://github.com/${REPO}" \
|
||||
--label "org.opencontainers.image.revision=${GIT_SHA}" \
|
||||
--label "org.opencontainers.image.created=$(date -u +%Y-%m-%dT%H:%M:%SZ)" \
|
||||
--label "molecule.workflow.run_id=${GITHUB_RUN_ID}" \
|
||||
--label "org.opencontainers.image.description=Molecule AI platform — pending canary verify" \
|
||||
--tag "${IMAGE_NAME}:${TAG_SHA}" \
|
||||
--tag "${IMAGE_NAME}:${TAG_LATEST}" \
|
||||
--push .
|
||||
.
|
||||
docker push "${IMAGE_NAME}:${TAG_SHA}"
|
||||
docker push "${IMAGE_NAME}:${TAG_LATEST}"
|
||||
|
||||
# Build + push tenant image (Go platform + Next.js canvas in one image).
|
||||
- name: Build & push tenant image to ECR (staging-<sha> + staging-latest)
|
||||
@@ -172,14 +160,15 @@ jobs:
|
||||
ECR_REGISTRY="${TENANT_IMAGE_NAME%%/*}"
|
||||
aws ecr get-login-password --region us-east-2 | \
|
||||
docker login --username AWS --password-stdin "${ECR_REGISTRY}"
|
||||
docker buildx build \
|
||||
docker build \
|
||||
--file ./workspace-server/Dockerfile.tenant \
|
||||
--build-arg NEXT_PUBLIC_PLATFORM_URL= \
|
||||
--build-arg GIT_SHA="${GIT_SHA}" \
|
||||
--label "org.opencontainers.image.source=https://git.moleculesai.app/molecule-ai/${REPO}" \
|
||||
--label "org.opencontainers.image.source=https://github.com/${REPO}" \
|
||||
--label "org.opencontainers.image.revision=${GIT_SHA}" \
|
||||
--label "org.opencontainers.image.created=$(date -u +%Y-%m-%dT%H:%M:%SZ)" \
|
||||
--label "molecule.workflow.run_id=${GITHUB_RUN_ID}" \
|
||||
--label "org.opencontainers.image.description=Molecule AI tenant platform + canvas — pending canary verify" \
|
||||
--tag "${TENANT_IMAGE_NAME}:${TAG_SHA}" \
|
||||
--tag "${TENANT_IMAGE_NAME}:${TAG_LATEST}" \
|
||||
--push .
|
||||
.
|
||||
docker push "${TENANT_IMAGE_NAME}:${TAG_SHA}"
|
||||
docker push "${TENANT_IMAGE_NAME}:${TAG_LATEST}"
|
||||
|
||||
@@ -1,164 +0,0 @@
|
||||
# qa-review — non-author APPROVE from the `qa` Gitea team required to merge.
|
||||
#
|
||||
# RFC#324 Step 1 of 5 (workflow-add). Pairs with `security-review.yml` and the
|
||||
# branch-protection flip in Step 2.
|
||||
#
|
||||
# === DESIGN (RFC#324 v1.1 addendum) ===
|
||||
#
|
||||
# A1-α (refire mechanism):
|
||||
# Triggers on:
|
||||
# - `pull_request_target`: opened, synchronize, reopened
|
||||
# → initial status posts when PR opens / re-pushes
|
||||
# - `issue_comment`: /qa-recheck slash-command on the PR
|
||||
# → manual re-fire after a QA reviewer clicks APPROVE
|
||||
# (Gitea 1.22.6 doesn't re-fire on pull_request_review, per
|
||||
# go-gitea/gitea#33700 + feedback_pull_request_review_no_refire)
|
||||
# Workflow name = `qa-review` ; job name = `approved`.
|
||||
# The job's own pass/fail conclusion publishes the status context
|
||||
# `qa-review / approved (<event>)` — NO `POST /statuses` call → NO
|
||||
# write:repository token scope needed. Sidesteps internal#321 defect #2.
|
||||
#
|
||||
# A1.1 (privilege check on slash-comment — INFORMATIONAL ONLY, NOT a gate):
|
||||
# The `issue_comment` event fires for ANY commenter, including
|
||||
# non-collaborators. The original (v1.2) design gated the eval step
|
||||
# behind a collaborator probe → if a non-collaborator commented
|
||||
# /qa-recheck, the eval was `if:`-skipped → the job exited 0 anyway →
|
||||
# the status context published `success` with ZERO real APPROVE.
|
||||
# That was a fail-open: any visitor could green the gate.
|
||||
#
|
||||
# RFC#324 v1.3 §A1.1 correction (option b per hongming-pc 1421):
|
||||
# drop privilege-gating of the evaluation entirely. The eval is
|
||||
# read-only and idempotent — it reads `pulls/{N}/reviews` and
|
||||
# `teams/{id}/members/{u}` (both API-side state that a commenter can't
|
||||
# change). Re-running it on a non-collaborator's comment is harmless
|
||||
# AND correct: if a real team-member APPROVE exists, the eval flips
|
||||
# green; if not, it stays red.
|
||||
#
|
||||
# We KEEP the privilege step as a `::notice::` log line only — useful
|
||||
# for griefer-spotting (one operator spamming /recheck) without
|
||||
# touching the gate. If rate-limiting is needed later, add it as a
|
||||
# separate concern (time-window throttle, not a privilege gate).
|
||||
#
|
||||
# We MUST NOT use `github.event.comment.author_association` (the
|
||||
# field doesn't exist on Gitea 1.22.6 webhook payload — this was
|
||||
# sop-tier-refire's defect #1).
|
||||
#
|
||||
# A4 (no PR-head checkout under pull_request_target):
|
||||
# We check out the BASE ref explicitly so the review-check.sh script is
|
||||
# loaded from trusted source. We NEVER use `ref: ${{ github.event.pull_request.head.sha }}`.
|
||||
# No PR-head code is executed in the runner. Trust boundary preserved.
|
||||
#
|
||||
# A5 (real Gitea team):
|
||||
# `qa` team (id=20) verified by orchestrator preflight 2026-05-11; queried
|
||||
# at run time via /api/v1/teams/20/members/{login}.
|
||||
#
|
||||
# === TOKEN ===
|
||||
#
|
||||
# The workflow reads PR state, PR reviews, and team membership.
|
||||
# Gitea 1.22.6's /api/v1/teams/{id}/members/{u} returns 403 ('Must be a
|
||||
# team member') for tokens whose owner is not in that team. The default
|
||||
# `secrets.GITHUB_TOKEN` is owned by a workflow-scoped identity that is
|
||||
# also not in qa/security teams → also 403.
|
||||
#
|
||||
# Resolution: a dedicated `RFC_324_TEAM_READ_TOKEN` secret, owned by an
|
||||
# identity that IS in both `qa` and `security` teams (Owners-tier
|
||||
# claude-ceo-assistant, or a new service-bot added to both teams).
|
||||
# Provisioning of this secret is tracked as a follow-up issue (filed by
|
||||
# core-devops at PR open).
|
||||
#
|
||||
# Until that secret is provisioned, the job will exit 1 with a clear
|
||||
# 403-on-team-probe error and the `qa-review / approved` status will
|
||||
# stay `failure`. This is the correct fail-closed behavior — the gate
|
||||
# blocks merge until both (a) a QA team member APPROVEs and (b) the
|
||||
# workflow has a token that can confirm their team membership.
|
||||
#
|
||||
# === SLASH-COMMAND CONTRACT ===
|
||||
#
|
||||
# /qa-recheck — re-evaluate the gate (e.g. after an APPROVE lands)
|
||||
#
|
||||
# Open to any PR commenter. The eval is read-only and idempotent, so
|
||||
# unprivileged refires are harmless (RFC#324 v1.3 §A1.1). Collaborator
|
||||
# status is logged for griefer-spotting but does NOT gate execution.
|
||||
|
||||
name: qa-review
|
||||
|
||||
on:
|
||||
pull_request_target:
|
||||
types: [opened, synchronize, reopened]
|
||||
issue_comment:
|
||||
types: [created]
|
||||
|
||||
permissions:
|
||||
contents: read
|
||||
pull-requests: read
|
||||
|
||||
jobs:
|
||||
approved:
|
||||
# Gate the job:
|
||||
# - On pull_request_target events: always run.
|
||||
# - On issue_comment events: only when it's a PR comment and the body
|
||||
# contains the slash-command. NO privilege gate at the step level
|
||||
# (RFC#324 v1.3 §A1.1): a non-collaborator's /qa-recheck is fine
|
||||
# because the eval is read-only and idempotent — re-running it
|
||||
# just re-confirms whether a real team-member APPROVE exists.
|
||||
if: |
|
||||
github.event_name == 'pull_request_target' ||
|
||||
(github.event_name == 'issue_comment' &&
|
||||
github.event.issue.pull_request != null &&
|
||||
startsWith(github.event.comment.body, '/qa-recheck'))
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Privilege check (A1.1 — INFORMATIONAL log only, NOT a gate)
|
||||
# RFC#324 v1.3 §A1.1: this step does NOT gate subsequent steps.
|
||||
# It exists solely as a log line for griefer-spotting (one
|
||||
# operator spamming /qa-recheck without merit). Re-running the
|
||||
# read-only eval on a non-collaborator comment is harmless;
|
||||
# gating it would be fail-open (skipped steps still publish
|
||||
# `success` for the job's status context).
|
||||
# Only runs on issue_comment events; pull_request_target has
|
||||
# no comment.user.login so the step is a no-op skip there.
|
||||
if: github.event_name == 'issue_comment'
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.RFC_324_TEAM_READ_TOKEN || secrets.GITHUB_TOKEN }}
|
||||
run: |
|
||||
set -euo pipefail
|
||||
login="${{ github.event.comment.user.login }}"
|
||||
# Write token to a mode-600 file so it never appears in curl's argv.
|
||||
# (#541: -H "Authorization: token $TOKEN" puts the secret in /proc/<pid>/cmdline)
|
||||
authfile=$(mktemp)
|
||||
chmod 600 "$authfile"
|
||||
printf 'header = "Authorization: token %s"\n' "$GITEA_TOKEN" > "$authfile"
|
||||
code=$(curl -sS -o /dev/null -w '%{http_code}' -K "$authfile" \
|
||||
"${{ github.server_url }}/api/v1/repos/${{ github.repository }}/collaborators/${login}")
|
||||
rm -f "$authfile"
|
||||
if [ "$code" = "204" ]; then
|
||||
echo "::notice::Recheck from ${login} (collaborator=true)"
|
||||
else
|
||||
echo "::notice::Recheck from ${login} (collaborator=false, HTTP ${code}) — proceeding with read-only eval anyway"
|
||||
fi
|
||||
|
||||
- name: Check out BASE ref (A4 — never PR-head)
|
||||
# Loads the review-check.sh script from a trusted ref. For
|
||||
# pull_request_target the default checkout is BASE already; we
|
||||
# set ref explicitly for the issue_comment event too so the
|
||||
# script source is always the default-branch version.
|
||||
# NEVER use ref: ${{ github.event.pull_request.head.sha }} —
|
||||
# that would execute PR-head code with secrets-context.
|
||||
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
with:
|
||||
ref: ${{ github.event.repository.default_branch }}
|
||||
|
||||
- name: Evaluate qa-review
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.RFC_324_TEAM_READ_TOKEN || secrets.GITHUB_TOKEN }}
|
||||
GITEA_HOST: git.moleculesai.app
|
||||
REPO: ${{ github.repository }}
|
||||
# PR number lives in different places per event:
|
||||
# pull_request_target → github.event.pull_request.number
|
||||
# issue_comment → github.event.issue.number
|
||||
PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
|
||||
TEAM: qa
|
||||
TEAM_ID: '20'
|
||||
REVIEW_CHECK_DEBUG: '0'
|
||||
REVIEW_CHECK_STRICT: '0'
|
||||
run: bash .gitea/scripts/review-check.sh
|
||||
@@ -1,70 +0,0 @@
|
||||
name: review-check-tests
|
||||
|
||||
# Runs review-check.sh regression tests on every PR + push that touches
|
||||
# the evaluator script or its test fixtures.
|
||||
#
|
||||
# Follows RFC#324 follow-up (issue #540):
|
||||
# .gitea/scripts/review-check.sh is load-bearing for PR merge gates.
|
||||
# It has ZERO production CI coverage. This workflow closes that gap.
|
||||
#
|
||||
# Design choices:
|
||||
# - Bash test harness (not bats). The existing test_review_check.sh
|
||||
# uses a custom assert_eq/assert_contains framework that is already
|
||||
# working and covers all 13 acceptance criteria (issue #540 §Acceptance).
|
||||
# Converting to bats would be refactoring, not closing the gap.
|
||||
# - No bats dependency: the runner-base image needs no extra tooling.
|
||||
# - continue-on-error: false — these tests must pass; a failure means
|
||||
# the review-gate evaluator is broken and must not be merged.
|
||||
|
||||
on:
|
||||
push:
|
||||
branches: [main, staging]
|
||||
paths:
|
||||
- '.gitea/scripts/review-check.sh'
|
||||
- '.gitea/scripts/tests/test_review_check.sh'
|
||||
- '.gitea/scripts/tests/_review_check_fixture.py'
|
||||
- '.gitea/workflows/review-check-tests.yml'
|
||||
pull_request:
|
||||
branches: [main, staging]
|
||||
paths:
|
||||
- '.gitea/scripts/review-check.sh'
|
||||
- '.gitea/scripts/tests/test_review_check.sh'
|
||||
- '.gitea/scripts/tests/_review_check_fixture.py'
|
||||
- '.gitea/workflows/review-check-tests.yml'
|
||||
workflow_dispatch:
|
||||
|
||||
env:
|
||||
GITHUB_SERVER_URL: https://git.moleculesai.app
|
||||
|
||||
concurrency:
|
||||
group: ${{ github.workflow }}-${{ github.ref }}
|
||||
cancel-in-progress: true
|
||||
|
||||
jobs:
|
||||
test:
|
||||
name: review-check.sh regression tests
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
|
||||
- name: Install jq
|
||||
# Required for T12 jq-filter test case. Gitea Actions runners (ubuntu-latest
|
||||
# label) do not bundle jq. Install via apt-get first (reliable for Ubuntu
|
||||
# runners with internet access to package mirrors). Falls back to GitHub
|
||||
# binary download. GitHub releases may be blocked on some runner networks
|
||||
# (infra#241 follow-up).
|
||||
continue-on-error: true
|
||||
run: |
|
||||
if apt-get update -qq && apt-get install -y -qq jq; then
|
||||
echo "::notice::jq installed via apt-get: $(jq --version)"
|
||||
elif timeout 120 curl -sSL \
|
||||
"https://github.com/jqlang/jq/releases/download/jq-1.7.1/jq-linux-amd64" \
|
||||
-o /usr/local/bin/jq && chmod +x /usr/local/bin/jq; then
|
||||
echo "::notice::jq binary downloaded: $(/usr/local/bin/jq --version)"
|
||||
else
|
||||
echo "::warning::jq install failed — apt-get and GitHub download both failed."
|
||||
fi
|
||||
jq --version 2>/dev/null || echo "::notice::jq not yet available — continuing"
|
||||
|
||||
- name: Run review-check.sh regression suite
|
||||
run: bash .gitea/scripts/tests/test_review_check.sh
|
||||
@@ -1,72 +0,0 @@
|
||||
# security-review — non-author APPROVE from the `security` Gitea team
|
||||
# required to merge.
|
||||
#
|
||||
# RFC#324 Step 1 of 5 (workflow-add). Mirror of `qa-review.yml`; differs
|
||||
# only in TEAM=security, TEAM_ID=21, and the slash-command name.
|
||||
#
|
||||
# See `qa-review.yml` header for the full A1-α / A1.1 / A4 / A5 design
|
||||
# rationale; everything below is identical in shape.
|
||||
|
||||
name: security-review
|
||||
|
||||
on:
|
||||
pull_request_target:
|
||||
types: [opened, synchronize, reopened]
|
||||
issue_comment:
|
||||
types: [created]
|
||||
|
||||
permissions:
|
||||
contents: read
|
||||
pull-requests: read
|
||||
|
||||
jobs:
|
||||
approved:
|
||||
# See qa-review.yml header for full A1-α / A1.1 (v1.3 — informational
|
||||
# log only, NOT a gate) / A4 / A5 design rationale.
|
||||
if: |
|
||||
github.event_name == 'pull_request_target' ||
|
||||
(github.event_name == 'issue_comment' &&
|
||||
github.event.issue.pull_request != null &&
|
||||
startsWith(github.event.comment.body, '/security-recheck'))
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Privilege check (A1.1 — INFORMATIONAL log only, NOT a gate)
|
||||
# RFC#324 v1.3 §A1.1: does NOT gate subsequent steps. See
|
||||
# qa-review.yml for full rationale. Eval is read-only/idempotent
|
||||
# so re-running on a non-collaborator comment is harmless.
|
||||
if: github.event_name == 'issue_comment'
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.RFC_324_TEAM_READ_TOKEN || secrets.GITHUB_TOKEN }}
|
||||
run: |
|
||||
set -euo pipefail
|
||||
login="${{ github.event.comment.user.login }}"
|
||||
# Write token to a mode-600 file so it never appears in curl's argv.
|
||||
# (#541: -H "Authorization: token $TOKEN" puts the secret in /proc/<pid>/cmdline)
|
||||
authfile=$(mktemp)
|
||||
chmod 600 "$authfile"
|
||||
printf 'header = "Authorization: token %s"\n' "$GITEA_TOKEN" > "$authfile"
|
||||
code=$(curl -sS -o /dev/null -w '%{http_code}' -K "$authfile" \
|
||||
"${{ github.server_url }}/api/v1/repos/${{ github.repository }}/collaborators/${login}")
|
||||
rm -f "$authfile"
|
||||
if [ "$code" = "204" ]; then
|
||||
echo "::notice::Recheck from ${login} (collaborator=true)"
|
||||
else
|
||||
echo "::notice::Recheck from ${login} (collaborator=false, HTTP ${code}) — proceeding with read-only eval anyway"
|
||||
fi
|
||||
|
||||
- name: Check out BASE ref (A4 — never PR-head)
|
||||
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
with:
|
||||
ref: ${{ github.event.repository.default_branch }}
|
||||
|
||||
- name: Evaluate security-review
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.RFC_324_TEAM_READ_TOKEN || secrets.GITHUB_TOKEN }}
|
||||
GITEA_HOST: git.moleculesai.app
|
||||
REPO: ${{ github.repository }}
|
||||
PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
|
||||
TEAM: security
|
||||
TEAM_ID: '21'
|
||||
REVIEW_CHECK_DEBUG: '0'
|
||||
REVIEW_CHECK_STRICT: '0'
|
||||
run: bash .gitea/scripts/review-check.sh
|
||||
@@ -1,121 +0,0 @@
|
||||
# status-reaper — Option B (compensating-status POST) for Gitea 1.22.6's
|
||||
# hardcoded `(push)` suffix on default-branch commit statuses.
|
||||
#
|
||||
# Tracking: molecule-core#? (this PR), internal#327 (sibling publish-runtime-bot),
|
||||
# internal#328 (sibling mc-drift-bot), internal#80 (upstream RFC). Sister
|
||||
# bots already deployed under the same per-persona-identity contract
|
||||
# (`feedback_per_agent_gitea_identity_default`).
|
||||
#
|
||||
# Root cause:
|
||||
# Gitea 1.22.6 emits commit-status context as
|
||||
# `<workflow_name> / <job_name> (push)`
|
||||
# for ANY workflow run on the default branch's HEAD commit, REGARDLESS
|
||||
# of the trigger event. Schedule- and workflow_dispatch-triggered runs
|
||||
# on `main` therefore appear as `(push)` failures on the latest main
|
||||
# commit, painting main red via a fake-push status. Verified on runs
|
||||
# 14525 + 14526 via Phase 1 evidence (3 sub-agents). No upstream fix
|
||||
# in 1.23-1.26.1 (sibling a6f20db1 research).
|
||||
#
|
||||
# Why a cron-driven reaper, not workflow_run:
|
||||
# Gitea 1.22.6 does NOT support `on: workflow_run` (verified via
|
||||
# modules/actions/workflows.go enumeration; sister a6f20db1). The
|
||||
# only event-shaped option that fires is cron. 5min is chosen to
|
||||
# sit BETWEEN ci-required-drift (`:17` hourly) and main-red-watchdog
|
||||
# (`:05` hourly) so the reaper sweeps red before the watchdog files
|
||||
# a `[main-red]` issue (would-be false-positive).
|
||||
#
|
||||
# What the reaper does each tick:
|
||||
# 1. Parse `.gitea/workflows/*.yml`, classify each by whether `on:`
|
||||
# contains a `push:` trigger (see script for workflow_id resolution
|
||||
# including `name:` collision and `/`-in-name fail-loud lints).
|
||||
# 2. GET combined status for main HEAD.
|
||||
# 3. For each `failure` status whose context ends ` (push)`:
|
||||
# - if workflow has push trigger: PRESERVE (real defect signal).
|
||||
# - if workflow has no push trigger: POST a compensating
|
||||
# `state=success` with the same context and a description that
|
||||
# documents the workaround.
|
||||
#
|
||||
# What it does NOT do:
|
||||
# - Mutate non-`(push)`-suffix statuses (e.g. `(pull_request)` from
|
||||
# branch_protections required-checks — verified safe 2026-05-11).
|
||||
# - Auto-revert. Same reasoning as main-red-watchdog.
|
||||
# - Cancel runs. The runs themselves stay visible in Actions UI; the
|
||||
# fix is at the commit-status surface only.
|
||||
#
|
||||
# Removal path: drop this workflow when Gitea ≥ 1.24 ships with a
|
||||
# real fix for the hardcoded-suffix bug. Audit issue (filed post-merge)
|
||||
# tracks the deletion as a follow-up sweep.
|
||||
|
||||
name: status-reaper
|
||||
|
||||
# IMPORTANT — Gitea 1.22.6 parser quirk per
|
||||
# `feedback_gitea_workflow_dispatch_inputs_unsupported`: do NOT add an
|
||||
# `inputs:` block here. Gitea 1.22.6 rejects the whole workflow as
|
||||
# "unknown on type" when `workflow_dispatch.inputs.X` is present.
|
||||
on:
|
||||
# SCHEDULE RE-ENABLED 2026-05-12 rev3 — interim disable (mc#645) reverted now that
|
||||
# rev3 widens DEFAULT_SWEEP_LIMIT 10 → 30 (covers retroactive-failure timing window).
|
||||
# Sibling watchdog re-enabled in the same PR with timeout-minutes raised 5 → 15.
|
||||
schedule:
|
||||
# Every 5 minutes. Off-zero alignment with sibling cron workflows:
|
||||
# ci-required-drift (`:17`), main-red-watchdog (`:05`),
|
||||
# railway-pin-audit (`:23`). 5-min cadence gives a tight enough
|
||||
# close on schedule-triggered false-reds that main-red-watchdog
|
||||
# (hourly :05) almost never files an issue on the false case.
|
||||
# rev3 keeps `*/5` unchanged per hongming-pc2 03:25Z review:
|
||||
# "trades window-width-cheap for cadence-loady" — N=30 widens
|
||||
# the lookback cheaply without doubling runner load via `*/2`.
|
||||
- cron: '*/5 * * * *'
|
||||
workflow_dispatch:
|
||||
|
||||
# Compensating-status POST needs write on repo statuses; no other
|
||||
# write surface is touched. checkout still needs `contents: read`.
|
||||
permissions:
|
||||
contents: read
|
||||
|
||||
# NOTE: NO `concurrency:` block is intentional.
|
||||
# Gitea 1.22.6 doesn't honor `cancel-in-progress: false`: queued ticks
|
||||
# of the same group get cancelled-with-started=0 instead of waiting
|
||||
# (DB-verified 2026-05-12, runs 16053/16085 of status-reaper.yml).
|
||||
# The reaper's POST /statuses/{sha} is idempotent — Gitea de-dups by
|
||||
# context — so concurrent ticks are safe; accept them rather than
|
||||
# serialise via the broken mechanism.
|
||||
|
||||
jobs:
|
||||
reap:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 3
|
||||
steps:
|
||||
- name: Check out repo at default-branch HEAD
|
||||
# BASE checkout per `feedback_pull_request_target_workflow_from_base`.
|
||||
# The script reads .gitea/workflows/*.yml from the working tree to
|
||||
# classify trigger sets; we must read main's CURRENT state, not
|
||||
# the SHA a stale schedule fired against.
|
||||
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
with:
|
||||
ref: ${{ github.event.repository.default_branch }}
|
||||
|
||||
- name: Set up Python (PyYAML for workflow `on:` parse)
|
||||
# Pinned to 3.12 to match sibling watchdog / ci-required-drift.
|
||||
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
|
||||
with:
|
||||
python-version: '3.12'
|
||||
|
||||
- name: Install PyYAML
|
||||
# PyYAML is needed because shell-grep on `on:` misses list/string
|
||||
# forms and nested `push: { paths: ... }`. Same install pattern
|
||||
# as ci-required-drift.yml (sub-2s install, no wheel cache).
|
||||
run: python -m pip install --quiet 'PyYAML==6.0.2'
|
||||
|
||||
- name: Compensate operational push-suffix failures on main
|
||||
env:
|
||||
# claude-status-reaper persona token; provisioned by sibling
|
||||
# aefaac1b 2026-05-11. Owns write:repository scope to POST
|
||||
# /statuses/{sha} but NOTHING ELSE
|
||||
# (`feedback_per_agent_gitea_identity_default`).
|
||||
GITEA_TOKEN: ${{ secrets.STATUS_REAPER_TOKEN }}
|
||||
GITEA_HOST: git.moleculesai.app
|
||||
REPO: ${{ github.repository }}
|
||||
WATCH_BRANCH: ${{ github.event.repository.default_branch }}
|
||||
WORKFLOWS_DIR: .gitea/workflows
|
||||
run: python3 .gitea/scripts/status-reaper.py
|
||||
@@ -29,15 +29,13 @@ name: Sweep stale AWS Secrets Manager secrets
|
||||
# reconciler enumerator) is filed as a separate controlplane
|
||||
# issue. This sweeper is the immediate cost-relief stopgap.
|
||||
#
|
||||
# AWS credentials: the confirmed Gitea secrets are AWS_ACCESS_KEY_ID /
|
||||
# AWS_SECRET_ACCESS_KEY (the molecule-cp IAM user). These are the same
|
||||
# credentials used by the rest of the platform. The dedicated
|
||||
# AWS_JANITOR_* naming (which the original GitHub workflow used) was
|
||||
# never populated in Gitea — the existing secrets are AWS_ACCESS_KEY_ID /
|
||||
# AWS_SECRET_ACCESS_KEY (per issue #425 §425 audit). These DO have
|
||||
# secretsmanager:ListSecrets (the production molecule-cp principal);
|
||||
# if ListSecrets is revoked in future, a dedicated janitor principal
|
||||
# would need to be created and the Gitea secret names updated here.
|
||||
# IAM principal: AWS_JANITOR_ACCESS_KEY_ID / AWS_JANITOR_SECRET_ACCESS_KEY.
|
||||
# This is a DEDICATED principal — the production `molecule-cp` IAM
|
||||
# user lacks `secretsmanager:ListSecrets` (it only has
|
||||
# Get/Create/Update/Delete on specific resources, scoped to its
|
||||
# operational needs). The janitor needs ListSecrets across the
|
||||
# `molecule/tenant/*` prefix, which warrants a separate principal so
|
||||
# we don't broaden the prod-CP policy.
|
||||
#
|
||||
# Safety: the script's MAX_DELETE_PCT gate (default 50%, mirroring
|
||||
# sweep-cf-orphans.yml — tenant secrets are durable by design, unlike
|
||||
@@ -73,8 +71,8 @@ jobs:
|
||||
timeout-minutes: 30
|
||||
env:
|
||||
AWS_REGION: ${{ secrets.AWS_REGION || 'us-east-1' }}
|
||||
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
|
||||
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
|
||||
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_JANITOR_ACCESS_KEY_ID }}
|
||||
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_JANITOR_SECRET_ACCESS_KEY }}
|
||||
CP_ADMIN_API_TOKEN: ${{ secrets.CP_ADMIN_API_TOKEN }}
|
||||
CP_STAGING_ADMIN_API_TOKEN: ${{ secrets.CP_STAGING_ADMIN_API_TOKEN }}
|
||||
MAX_DELETE_PCT: ${{ github.event.inputs.max_delete_pct || '50' }}
|
||||
@@ -101,11 +99,13 @@ jobs:
|
||||
if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
|
||||
echo "::warning::skipping sweep — secrets not configured: ${missing[*]}"
|
||||
echo "::warning::set them at Settings → Secrets and Variables → Actions, then rerun."
|
||||
echo "::warning::AWS_JANITOR_* must belong to a principal with secretsmanager:ListSecrets and secretsmanager:DeleteSecret on molecule/tenant/* (the prod molecule-cp principal lacks ListSecrets)."
|
||||
echo "skip=true" >> "$GITHUB_OUTPUT"
|
||||
exit 0
|
||||
fi
|
||||
echo "::error::sweep cannot run — required secrets missing: ${missing[*]}"
|
||||
echo "::error::set them at Settings → Secrets and Variables → Actions, or disable this workflow."
|
||||
echo "::error::AWS_JANITOR_* must belong to a principal with secretsmanager:ListSecrets and secretsmanager:DeleteSecret on molecule/tenant/*."
|
||||
exit 1
|
||||
fi
|
||||
echo "All required secrets present ✓"
|
||||
|
||||
@@ -33,11 +33,6 @@ name: Sweep stale Cloudflare DNS records
|
||||
# gate halts before damage. Decision-function unit tests in
|
||||
# scripts/ops/test_sweep_cf_decide.py (#2027) cover the rule
|
||||
# classifier.
|
||||
#
|
||||
# Secrets: CF_API_TOKEN, CF_ZONE_ID, AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY
|
||||
# are confirmed existing per issue #425 §425 audit. CP_ADMIN_API_TOKEN and
|
||||
# CP_STAGING_ADMIN_API_TOKEN are unconfirmed — if missing, the verify step
|
||||
# (schedule → hard-fail, dispatch → soft-skip) surfaces it clearly.
|
||||
|
||||
on:
|
||||
schedule:
|
||||
|
||||
@@ -28,11 +28,6 @@ name: Sweep stale Cloudflare Tunnels
|
||||
# Safety: the script's MAX_DELETE_PCT gate (default 90% — higher than
|
||||
# the DNS sweep's 50% because tenant-shaped tunnels are mostly
|
||||
# orphans by design) refuses to nuke past the threshold.
|
||||
#
|
||||
# Secrets: CF_API_TOKEN, CF_ACCOUNT_ID are confirmed existing per
|
||||
# issue #425 §425 audit. CP_ADMIN_API_TOKEN and CP_STAGING_ADMIN_API_TOKEN
|
||||
# are unconfirmed — if missing, the verify step (schedule → hard-fail,
|
||||
# dispatch → soft-skip) surfaces it clearly.
|
||||
|
||||
on:
|
||||
schedule:
|
||||
|
||||
@@ -1,120 +0,0 @@
|
||||
name: Weekly Platform-Go Surface
|
||||
|
||||
# Surface latent vet/test errors on main by running the full Platform-Go
|
||||
# suite on a weekly cron regardless of whether the last push touched
|
||||
# workspace-server/.
|
||||
#
|
||||
# Background: ci.yml's `platform-build` job gates real work on
|
||||
# `if: needs.changes.outputs.platform == 'true'`. When no push touches
|
||||
# workspace-server/, the skip fires and the suite never executes on main.
|
||||
# Latent vet errors and test flakes can sit for weeks undetected.
|
||||
#
|
||||
# This workflow runs the full suite (build, vet, golangci-lint, tests with
|
||||
# coverage) every Monday at 04:17 UTC. Results are posted as commit statuses
|
||||
# but continue-on-error: true means they never block anything — they're
|
||||
# purely a noise-reduction signal for when the next workspace-server push
|
||||
# lands and would otherwise trigger the first real suite run.
|
||||
#
|
||||
# Why 04:17 UTC on Monday: off-peak, before the weekly sprint cycle starts.
|
||||
|
||||
on:
|
||||
schedule:
|
||||
- cron: '17 4 * * 1' # Mondays at 04:17 UTC
|
||||
workflow_dispatch:
|
||||
|
||||
permissions:
|
||||
contents: read
|
||||
statuses: write
|
||||
|
||||
jobs:
|
||||
weekly-platform-go:
|
||||
name: Weekly Platform-Go Surface
|
||||
runs-on: ubuntu-latest
|
||||
# continue-on-error: surface only, never block
|
||||
continue-on-error: true
|
||||
defaults:
|
||||
run:
|
||||
working-directory: workspace-server
|
||||
steps:
|
||||
- name: Checkout main
|
||||
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
with:
|
||||
ref: main
|
||||
fetch-depth: 1
|
||||
|
||||
- name: Set up Go
|
||||
uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5
|
||||
with:
|
||||
go-version: stable
|
||||
|
||||
- name: Go mod download
|
||||
run: go mod download
|
||||
|
||||
- name: Build
|
||||
run: go build ./cmd/server
|
||||
|
||||
# `go vet` is NOT `|| true`-guarded: surfacing latent vet errors on main is
|
||||
# the whole point of this workflow (issue #567 — the motivating case was a
|
||||
# `go vet` error in org_external.go that sat undetected on main for weeks).
|
||||
# A vet error here fails the step → fails the job → shows red on the weekly
|
||||
# commit. Per Gitea quirk #10 (job-level continue-on-error is ignored), that
|
||||
# red surfaces on main — which is the intended signal, not a regression.
|
||||
- name: go vet
|
||||
run: go vet ./...
|
||||
|
||||
# golangci-lint stays `|| true`-guarded: lint is noisier (more false-
|
||||
# positives than vet) and golangci-lint may not be pre-installed on every
|
||||
# runner image — a `|| true` here keeps a missing-binary or lint-noise case
|
||||
# from masking the vet/test signal above. Tighten to match ci.yml's lint
|
||||
# gate if/when ci.yml's lint step becomes hard-failing.
|
||||
- name: golangci-lint
|
||||
run: golangci-lint run --timeout 3m ./... || true
|
||||
|
||||
- name: Tests with race detection + coverage
|
||||
run: go test -race -coverprofile=coverage.out ./...
|
||||
|
||||
- name: Check coverage thresholds
|
||||
run: |
|
||||
set -e
|
||||
TOTAL_FLOOR=25
|
||||
CRITICAL_PATHS=(
|
||||
"internal/handlers/tokens"
|
||||
"internal/handlers/workspace_provision"
|
||||
"internal/handlers/a2a_proxy"
|
||||
"internal/handlers/registry"
|
||||
"internal/handlers/secrets"
|
||||
"internal/middleware/wsauth"
|
||||
"internal/crypto"
|
||||
)
|
||||
|
||||
TOTAL=$(go tool cover -func=coverage.out | grep '^total:' | awk '{print $3}' | sed 's/%//')
|
||||
echo "Total coverage: ${TOTAL}%"
|
||||
if awk "BEGIN{exit !(\$TOTAL < \$TOTAL_FLOOR)}"; then
|
||||
echo "::error::Total coverage \${TOTAL}% is below the \${TOTAL_FLOOR}% floor."
|
||||
exit 1
|
||||
fi
|
||||
|
||||
ALLOWLIST=""
|
||||
if [ -f ../.coverage-allowlist.txt ]; then
|
||||
ALLOWLIST=$(grep -vE '^(#|[[:space:]]*$)' ../.coverage-allowlist.txt || true)
|
||||
fi
|
||||
|
||||
FAILED=0
|
||||
for path in "\${CRITICAL_PATHS[@]}"; do
|
||||
while read -r file pct; do
|
||||
[[ "$file" == *_test.go ]] && continue
|
||||
[[ "$file" == *"$path"* ]] || continue
|
||||
awk "BEGIN{exit !(\$pct < 10)}" || continue
|
||||
rel=$(echo "$file" | sed 's|^github.com/molecule-ai/molecule-monorepo/platform/workspace-server/||; s|^github.com/molecule-ai/molecule-monorepo/platform/||')
|
||||
if echo "$ALLOWLIST" | grep -qxF "$rel"; then
|
||||
continue
|
||||
fi
|
||||
echo "::error::Low coverage \${pct}% on \${rel} (below 10% in critical path \${path})"
|
||||
FAILED=$((FAILED + 1))
|
||||
done < <(go tool cover -func=coverage.out | grep -v '^total:' | awk '{file=$1; sub(/:[0-9][0-9.]*:.*/, "", file); pct=$NF; gsub(/%/,"",pct); s[file]+=pct; c[file]++} END {for (f in s) printf "%s %.1f\n", f, s[f]/c[f]}' | sort)
|
||||
done
|
||||
if [ "$FAILED" -gt 0 ]; then
|
||||
echo "::error::\${FAILED} critical paths below 10% coverage — see above."
|
||||
exit 1
|
||||
fi
|
||||
echo "Coverage thresholds: OK"
|
||||
@@ -1 +0,0 @@
|
||||
staging trigger
|
||||
@@ -156,16 +156,6 @@ and run CI manually.
|
||||
| python-lint | pytest with coverage |
|
||||
| e2e-api | Full API test suite (62 tests) |
|
||||
| shellcheck | Shell script linting |
|
||||
| review-check-tests | `review-check.sh` evaluator regression suite (13 scenarios) |
|
||||
| ops-scripts | Python unittest suite for `scripts/*.py` |
|
||||
|
||||
## Local Testing
|
||||
|
||||
### review-check.sh
|
||||
```bash
|
||||
bash .gitea/scripts/tests/test_review_check.sh
|
||||
```
|
||||
Runs the full regression suite against a fixture HTTP server. No network access required.
|
||||
|
||||
## Code Style
|
||||
|
||||
|
||||
@@ -5,22 +5,20 @@
|
||||
* Covers: renders nothing when no approvals, polls /approvals/pending,
|
||||
* shows approval cards, approve/deny decisions, toast notifications.
|
||||
*
|
||||
* Uses vi.hoisted + vi.mock (file-level) for @/lib/api. vi.resetModules()
|
||||
* in every afterEach undoes the mock so other test files that import the
|
||||
* real api module (e.g. socket.url.test.ts) are unaffected.
|
||||
* All blocks use vi.useFakeTimers() consistently in beforeEach/afterEach to
|
||||
* avoid polluting the fake-timer state for subsequent test files. The
|
||||
* vi.spyOn mocks are reset per-spy via mockReset() in afterEach so each
|
||||
* test gets a clean mock state without touching the module-level api mock.
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act } from "@testing-library/react";
|
||||
import { afterEach, describe, expect, it, vi, beforeEach } from "vitest";
|
||||
import { ApprovalBanner } from "../ApprovalBanner";
|
||||
import { showToast } from "@/components/Toaster";
|
||||
import { api } from "@/lib/api";
|
||||
|
||||
// ─── Hoisted mock refs ─────────────────────────────────────────────────────────
|
||||
// vi.hoisted runs in the same hoisting phase as vi.mock factories, so these
|
||||
// refs are stable across all tests and available inside the mock factory.
|
||||
const { mockApiGet, mockApiPost } = vi.hoisted(() => ({
|
||||
mockApiGet: vi.fn<(args: unknown[]) => Promise<unknown>>(),
|
||||
mockApiPost: vi.fn<(args: unknown[]) => Promise<unknown>>(),
|
||||
vi.mock("@/components/Toaster", () => ({
|
||||
showToast: vi.fn(),
|
||||
}));
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
@@ -43,42 +41,28 @@ const pendingApproval = (id = "a1", workspaceId = "ws-1"): {
|
||||
created_at: "2026-05-10T10:00:00Z",
|
||||
});
|
||||
|
||||
// ─── Static mocks (file-level — no other test needs the real modules) ─────────
|
||||
// Shared spy references so individual tests can reset or reject the POST mock
|
||||
// without needing to call spyOn again (which would create a duplicate spy).
|
||||
let mockGet: ReturnType<typeof vi.spyOn>;
|
||||
let mockPost: ReturnType<typeof vi.spyOn>;
|
||||
|
||||
vi.mock("@/components/Toaster", () => ({
|
||||
showToast: vi.fn(),
|
||||
}));
|
||||
|
||||
// vi.resetModules() in afterEach undoes this mock so other files that import
|
||||
// the real api module are unaffected.
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: {
|
||||
get: mockApiGet,
|
||||
post: mockApiPost,
|
||||
},
|
||||
}));
|
||||
|
||||
// ─── Tests ─────────────────────────────────────────────────────────────────────
|
||||
// ─── Tests ────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("ApprovalBanner — empty state", () => {
|
||||
beforeEach(() => {
|
||||
vi.useFakeTimers();
|
||||
mockApiGet.mockReset().mockResolvedValue([]);
|
||||
mockApiPost.mockReset().mockResolvedValue({});
|
||||
vi.spyOn(api, "get").mockResolvedValueOnce([]);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
vi.useFakeTimers();
|
||||
});
|
||||
|
||||
it("renders nothing when there are no pending approvals", async () => {
|
||||
render(<ApprovalBanner />);
|
||||
await act(async () => { await vi.runOnlyPendingTimersAsync(); });
|
||||
expect(screen.queryByRole("alert")).toBeNull();
|
||||
expect(mockApiGet).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("does not render any approve/deny buttons when list is empty", async () => {
|
||||
@@ -92,40 +76,41 @@ describe("ApprovalBanner — empty state", () => {
|
||||
describe("ApprovalBanner — renders approval cards", () => {
|
||||
beforeEach(() => {
|
||||
vi.useFakeTimers();
|
||||
mockApiGet.mockReset().mockResolvedValue([
|
||||
mockGet = vi.spyOn(api, "get").mockResolvedValueOnce([
|
||||
pendingApproval("a1"),
|
||||
pendingApproval("a2", "ws-2"),
|
||||
]);
|
||||
mockApiPost.mockReset().mockResolvedValue({});
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
mockGet?.mockReset();
|
||||
vi.useFakeTimers();
|
||||
});
|
||||
|
||||
it("renders an alert card for each pending approval", async () => {
|
||||
render(<ApprovalBanner />);
|
||||
await act(async () => { await vi.runOnlyPendingTimersAsync(); });
|
||||
expect(screen.getAllByRole("alert")).toHaveLength(2);
|
||||
const alerts = screen.getAllByRole("alert");
|
||||
expect(alerts).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("displays the workspace name and action text", async () => {
|
||||
render(<ApprovalBanner />);
|
||||
await act(async () => { await vi.runOnlyPendingTimersAsync(); });
|
||||
expect(screen.getAllByText(/test workspace needs approval/i)).toHaveLength(2);
|
||||
const nameEls = screen.getAllByText(/test workspace needs approval/i);
|
||||
expect(nameEls).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("displays the reason when present", async () => {
|
||||
render(<ApprovalBanner />);
|
||||
await act(async () => { await vi.runOnlyPendingTimersAsync(); });
|
||||
expect(screen.getAllByText(/requires human approval/i)).toHaveLength(2);
|
||||
const reasons = screen.getAllByText(/requires human approval/i);
|
||||
expect(reasons).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("omits the reason div when reason is null", async () => {
|
||||
mockApiGet.mockReset().mockResolvedValue([{
|
||||
vi.spyOn(api, "get").mockResolvedValueOnce([{
|
||||
...pendingApproval("a1"),
|
||||
reason: null,
|
||||
}]);
|
||||
@@ -139,6 +124,7 @@ describe("ApprovalBanner — renders approval cards", () => {
|
||||
await act(async () => { await vi.runOnlyPendingTimersAsync(); });
|
||||
const approveBtns = screen.getAllByRole("button", { name: /Approve/i });
|
||||
const denyBtns = screen.getAllByRole("button", { name: /Deny/i });
|
||||
// 2 cards, each card has 1 Approve + 1 Deny button → 2 of each minimum
|
||||
expect(approveBtns.length).toBeGreaterThanOrEqual(2);
|
||||
expect(denyBtns.length).toBeGreaterThanOrEqual(2);
|
||||
});
|
||||
@@ -146,22 +132,23 @@ describe("ApprovalBanner — renders approval cards", () => {
|
||||
it("has aria-live=assertive on the alert container", async () => {
|
||||
render(<ApprovalBanner />);
|
||||
await act(async () => { await vi.runOnlyPendingTimersAsync(); });
|
||||
expect(screen.getAllByRole("alert")[0].getAttribute("aria-live")).toBe("assertive");
|
||||
const alert = screen.getAllByRole("alert")[0];
|
||||
expect(alert.getAttribute("aria-live")).toBe("assertive");
|
||||
});
|
||||
});
|
||||
|
||||
describe("ApprovalBanner — decisions", () => {
|
||||
beforeEach(() => {
|
||||
vi.useFakeTimers();
|
||||
mockApiGet.mockReset().mockResolvedValue([pendingApproval("a1")]);
|
||||
mockApiPost.mockReset().mockResolvedValue({});
|
||||
mockGet = vi.spyOn(api, "get").mockResolvedValueOnce([pendingApproval("a1")]);
|
||||
mockPost = vi.spyOn(api, "post").mockResolvedValue({});
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
mockGet?.mockReset();
|
||||
mockPost?.mockReset();
|
||||
vi.useFakeTimers();
|
||||
});
|
||||
|
||||
it("calls POST /workspaces/:id/approvals/:id/decide on Approve click", async () => {
|
||||
@@ -169,7 +156,7 @@ describe("ApprovalBanner — decisions", () => {
|
||||
await act(async () => { await vi.runOnlyPendingTimersAsync(); });
|
||||
fireEvent.click(screen.getAllByRole("button", { name: /approve/i })[0]);
|
||||
await act(async () => { /* flush */ });
|
||||
expect(mockApiPost).toHaveBeenCalledWith(
|
||||
expect(vi.mocked(api.post)).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/approvals/a1/decide",
|
||||
expect.objectContaining({ decision: "approved" })
|
||||
);
|
||||
@@ -180,7 +167,7 @@ describe("ApprovalBanner — decisions", () => {
|
||||
await act(async () => { await vi.runOnlyPendingTimersAsync(); });
|
||||
fireEvent.click(screen.getAllByRole("button", { name: /deny/i })[0]);
|
||||
await act(async () => { /* flush */ });
|
||||
expect(mockApiPost).toHaveBeenCalledWith(
|
||||
expect(vi.mocked(api.post)).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/approvals/a1/decide",
|
||||
expect.objectContaining({ decision: "denied" })
|
||||
);
|
||||
@@ -212,10 +199,7 @@ describe("ApprovalBanner — decisions", () => {
|
||||
});
|
||||
|
||||
it("shows an error toast when POST fails", async () => {
|
||||
// mockImplementation preserves the vi.fn() wrapper (unlike mockReset() which
|
||||
// strips it and causes the real fetch() to fire — the root cause of the
|
||||
// original flakiness in this file).
|
||||
mockApiPost.mockImplementation(() => Promise.reject(new Error("Network error")));
|
||||
mockPost.mockReset().mockRejectedValue(new Error("Network error"));
|
||||
render(<ApprovalBanner />);
|
||||
await act(async () => { await vi.runOnlyPendingTimersAsync(); });
|
||||
fireEvent.click(screen.getAllByRole("button", { name: /approve/i })[0]);
|
||||
@@ -227,9 +211,9 @@ describe("ApprovalBanner — decisions", () => {
|
||||
});
|
||||
|
||||
it("keeps the card visible when the POST fails", async () => {
|
||||
// Same mockImplementation pattern — preserves the wrapper so the component's
|
||||
// catch block runs instead of the real fetch().
|
||||
mockApiPost.mockImplementation(() => Promise.reject(new Error("Network error")));
|
||||
// Reset the post mock before rejecting so the beforeEach's resolved value
|
||||
// is gone and we get a clean rejection instead of a resolved→rejected queue.
|
||||
mockPost.mockReset().mockRejectedValue(new Error("Network error"));
|
||||
render(<ApprovalBanner />);
|
||||
await act(async () => { await vi.runOnlyPendingTimersAsync(); });
|
||||
fireEvent.click(screen.getAllByRole("button", { name: /approve/i })[0]);
|
||||
@@ -241,15 +225,12 @@ describe("ApprovalBanner — decisions", () => {
|
||||
describe("ApprovalBanner — handles empty list from server", () => {
|
||||
beforeEach(() => {
|
||||
vi.useFakeTimers();
|
||||
mockApiGet.mockReset().mockResolvedValue([]);
|
||||
mockApiPost.mockReset().mockResolvedValue({});
|
||||
vi.spyOn(api, "get").mockResolvedValueOnce([]);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
vi.useFakeTimers();
|
||||
});
|
||||
|
||||
it("shows nothing when the API returns an empty array on first poll", async () => {
|
||||
|
||||
@@ -1,370 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for EmptyState — the full-canvas welcome card shown on first load.
|
||||
*
|
||||
* Covers:
|
||||
* - Loading state (GET /templates in flight)
|
||||
* - Fetch failure → empty template grid (templates = [])
|
||||
* - Template grid renders with correct content
|
||||
* - Template button disabled while deploying
|
||||
* - "Deploying..." label on the button being deployed
|
||||
* - "Create blank" button POSTs /workspaces
|
||||
* - "Creating..." label while blank workspace is being created
|
||||
* - Blank create error shows error banner
|
||||
* - Error banner has role="alert"
|
||||
* - All buttons disabled while any deploy is in-flight
|
||||
* - handleDeployed fires after 500ms delay
|
||||
*
|
||||
* Uses vi.hoisted + vi.mock to fully isolate the api module, matching
|
||||
* the pattern established in ApprovalBanner, MemoryTab, and ScheduleTab tests.
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act } from "@testing-library/react";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { EmptyState } from "../EmptyState";
|
||||
|
||||
// ─── Hoisted mock refs ─────────────────────────────────────────────────────────
|
||||
// vi.hoisted runs in the same hoisting phase as vi.mock factories, so all refs
|
||||
// are available both to the factory and to test bodies.
|
||||
const { mockApiGet, mockApiPost } = vi.hoisted(() => ({
|
||||
mockApiGet: vi.fn<(args: unknown[]) => Promise<unknown>>(),
|
||||
mockApiPost: vi.fn<(args: unknown[]) => Promise<{ id: string }>>(),
|
||||
}));
|
||||
|
||||
// Mutable deploy state — object reference is const; properties can be mutated.
|
||||
const _deploy = vi.hoisted(() => ({
|
||||
deployFn: vi.fn(),
|
||||
deploying: undefined as string | undefined,
|
||||
error: undefined as string | undefined,
|
||||
modal: null as React.ReactNode,
|
||||
}));
|
||||
|
||||
const { mockSelectNode, mockSetPanelTab } = vi.hoisted(() => ({
|
||||
mockSelectNode: vi.fn(),
|
||||
mockSetPanelTab: vi.fn(),
|
||||
}));
|
||||
|
||||
// ─── Mocks ────────────────────────────────────────────────────────────────────
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: {
|
||||
get: mockApiGet,
|
||||
post: mockApiPost,
|
||||
},
|
||||
}));
|
||||
|
||||
vi.mock("@/hooks/useTemplateDeploy", () => ({
|
||||
useTemplateDeploy: () => ({
|
||||
deploy: _deploy.deployFn,
|
||||
deploying: _deploy.deploying,
|
||||
error: _deploy.error,
|
||||
modal: _deploy.modal,
|
||||
}),
|
||||
}));
|
||||
|
||||
vi.mock("@/store/canvas", () => ({
|
||||
useCanvasStore: Object.assign(
|
||||
vi.fn((selector: (s: { getState: () => { selectNode: typeof mockSelectNode; setPanelTab: typeof mockSetPanelTab } }) => unknown) =>
|
||||
selector({
|
||||
getState: () => ({
|
||||
selectNode: mockSelectNode,
|
||||
setPanelTab: mockSetPanelTab,
|
||||
}),
|
||||
})
|
||||
),
|
||||
{ getState: () => ({ selectNode: mockSelectNode, setPanelTab: mockSetPanelTab }) }
|
||||
),
|
||||
}));
|
||||
|
||||
vi.mock("../TemplatePalette", () => ({
|
||||
OrgTemplatesSection: () => null,
|
||||
}));
|
||||
|
||||
vi.mock("../Spinner", () => ({
|
||||
Spinner: () => <span data-testid="spinner">⟳</span>,
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/design-tokens", () => ({
|
||||
TIER_CONFIG: {
|
||||
1: { label: "T1", color: "text-ink-mid bg-surface-card border border-line", border: "text-ink-mid border-line" },
|
||||
2: { label: "T2", color: "text-white bg-accent border border-accent-strong", border: "text-accent border-accent" },
|
||||
3: { label: "T3", color: "text-white bg-violet-600 border border-violet-700", border: "text-violet-600 border-violet-500" },
|
||||
4: { label: "T4", color: "text-white bg-warm border border-warm", border: "text-warm border-warm" },
|
||||
},
|
||||
}));
|
||||
|
||||
// ─── Fixtures ─────────────────────────────────────────────────────────────────
|
||||
|
||||
const TEMPLATE = {
|
||||
id: "tpl-1",
|
||||
name: "Claude Code Agent",
|
||||
description: "A general-purpose coding assistant",
|
||||
tier: 2,
|
||||
skill_count: 3,
|
||||
model: "claude-opus-4-5",
|
||||
};
|
||||
|
||||
function template(overrides: Partial<typeof TEMPLATE> = {}): typeof TEMPLATE {
|
||||
return { ...TEMPLATE, ...overrides };
|
||||
}
|
||||
|
||||
// ─── Helpers ───────────────────────────────────────────────────────────────────
|
||||
|
||||
function renderEmpty() {
|
||||
return render(<EmptyState />);
|
||||
}
|
||||
|
||||
// Flush React state + microtasks after an act boundary.
|
||||
async function flush() {
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
}
|
||||
|
||||
// Reset deploy state to defaults before each test.
|
||||
function resetDeployState() {
|
||||
_deploy.deployFn.mockReset();
|
||||
_deploy.deploying = undefined;
|
||||
_deploy.error = undefined;
|
||||
_deploy.modal = null;
|
||||
}
|
||||
|
||||
// ─── Tests ─────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("EmptyState — loading", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset().mockImplementation(
|
||||
() => new Promise(() => {}) // never resolves
|
||||
);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
it("shows loading state while GET /templates is pending", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.getByTestId("spinner")).toBeTruthy();
|
||||
expect(screen.getByText("Loading templates...")).toBeTruthy();
|
||||
});
|
||||
|
||||
// "create blank" is rendered outside the loading/template-grid conditional,
|
||||
// so it is always visible — adjust expectation accordingly.
|
||||
it("renders 'create blank' button during loading", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.getByRole("button", { name: "+ Create blank workspace" })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("does not render template buttons while loading", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.queryByText("Claude Code Agent")).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
describe("EmptyState — templates", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset().mockResolvedValue([template()]);
|
||||
resetDeployState();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
it("renders the welcome heading", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.getByText("Deploy your first agent")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders template buttons with name and description", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.getByText("Claude Code Agent")).toBeTruthy();
|
||||
expect(screen.getByText("A general-purpose coding assistant")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders tier badge and skill count", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.getByText("T2")).toBeTruthy();
|
||||
// skill_count renders as "3 skills · <model>"
|
||||
expect(screen.getByText(/^3 skills/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders model name when present", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.getByText(/claude-opus/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("calls deploy with the template on click", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByText("Claude Code Agent"));
|
||||
expect(_deploy.deployFn).toHaveBeenCalledWith(template());
|
||||
});
|
||||
|
||||
it("shows 'Deploying...' on the button of the template being deployed", async () => {
|
||||
_deploy.deploying = "tpl-1";
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.getByText("Deploying...")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("disables the template button of the deploying template", async () => {
|
||||
_deploy.deploying = "tpl-1";
|
||||
renderEmpty();
|
||||
await flush();
|
||||
const btn = screen.getByText("Deploying...").closest("button") as HTMLButtonElement;
|
||||
expect(btn.disabled).toBe(true);
|
||||
});
|
||||
|
||||
it("disables 'create blank' while a template is deploying", async () => {
|
||||
_deploy.deploying = "tpl-1";
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.getByRole("button", { name: "+ Create blank workspace" }).disabled).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe("EmptyState — fetch failure / empty templates", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset().mockResolvedValue([]);
|
||||
resetDeployState();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
it("does not render template grid when GET /templates returns []", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.queryByText("Claude Code Agent")).toBeNull();
|
||||
});
|
||||
|
||||
it("renders 'create blank' button when templates list is empty", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.getByRole("button", { name: "+ Create blank workspace" })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("does not render template grid when GET /templates rejects", async () => {
|
||||
mockApiGet.mockReset().mockRejectedValue(new Error("Network failure"));
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.queryByText("Claude Code Agent")).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
describe("EmptyState — create blank", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset().mockResolvedValue([template()]);
|
||||
mockApiPost.mockReset().mockResolvedValue({ id: "ws-new" });
|
||||
resetDeployState();
|
||||
vi.useFakeTimers();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
it("calls POST /workspaces on 'create blank' click", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: "+ Create blank workspace" }));
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
expect(mockApiPost).toHaveBeenCalledWith(
|
||||
"/workspaces",
|
||||
expect.objectContaining({ name: "My First Agent" })
|
||||
);
|
||||
});
|
||||
|
||||
it("shows 'Creating...' while blank workspace POST is pending", async () => {
|
||||
mockApiPost.mockReset().mockImplementation(
|
||||
() => new Promise(() => {}) // never resolves
|
||||
);
|
||||
renderEmpty();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: "+ Create blank workspace" }));
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
expect(screen.getByRole("button", { name: "Creating..." })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("calls selectNode + setPanelTab after 500ms on successful create", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: "+ Create blank workspace" }));
|
||||
await act(async () => { await Promise.resolve(); }); // flush POST
|
||||
await act(async () => { vi.advanceTimersByTime(500); });
|
||||
expect(mockSelectNode).toHaveBeenCalledWith("ws-new");
|
||||
expect(mockSetPanelTab).toHaveBeenCalledWith("chat");
|
||||
});
|
||||
|
||||
it("disables template buttons while creating blank workspace", async () => {
|
||||
mockApiPost.mockReset().mockImplementation(
|
||||
() => new Promise(() => {}) // never resolves
|
||||
);
|
||||
renderEmpty();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: "+ Create blank workspace" }));
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
expect((screen.getByText("Claude Code Agent").closest("button") as HTMLButtonElement).disabled).toBe(true);
|
||||
});
|
||||
|
||||
it("shows error banner when POST /workspaces fails", async () => {
|
||||
mockApiPost.mockReset().mockRejectedValue(new Error("Server error"));
|
||||
renderEmpty();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: "+ Create blank workspace" }));
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
expect(screen.getByRole("alert")).toBeTruthy();
|
||||
expect(screen.getByText(/server error/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("clears 'Creating...' and shows button again after POST failure", async () => {
|
||||
mockApiPost.mockReset().mockRejectedValue(new Error("Server error"));
|
||||
renderEmpty();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: "+ Create blank workspace" }));
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
// After rejection, blankCreating = false → button reverts to default label
|
||||
expect(screen.getByRole("button", { name: "+ Create blank workspace" })).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("EmptyState — error banner", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset().mockResolvedValue([template()]);
|
||||
resetDeployState();
|
||||
vi.useFakeTimers();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
it("has role=alert on the error banner", async () => {
|
||||
_deploy.error = "Template deploy failed";
|
||||
renderEmpty();
|
||||
await flush();
|
||||
const alert = screen.getByRole("alert");
|
||||
expect(alert).toBeTruthy();
|
||||
expect(alert.textContent).toContain("Template deploy failed");
|
||||
});
|
||||
|
||||
it("does not show error banner when no errors", async () => {
|
||||
renderEmpty();
|
||||
await flush();
|
||||
expect(screen.queryByRole("alert")).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -1,237 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for ExternalConnectModal — the modal surfaced after creating a
|
||||
* runtime="external" workspace. Surfaces workspace_auth_token + ready-to-paste
|
||||
* snippets so the operator can configure their off-host agent.
|
||||
*
|
||||
* Coverage:
|
||||
* - Renders nothing when info=null
|
||||
* - Opens dialog when info is provided
|
||||
* - Default tab: "Universal MCP" when universal_mcp_snippet present, else "Python SDK"
|
||||
* - Tab switching between all available tabs
|
||||
* - Snippets show with auth_token replacing placeholders
|
||||
* - Copy button: calls clipboard API, shows "Copied!", clears after 1.5s
|
||||
* - Copy failure: shows fallback textarea
|
||||
* - "I've saved it — close" calls onClose
|
||||
* - Security warning: one-time token display
|
||||
* - Fields tab shows raw values
|
||||
* - Tabs hidden when their snippet is absent
|
||||
*
|
||||
* Fake timers: applied per-describe to avoid mixing with waitFor. Tests that
|
||||
* use waitFor (which needs real timers) run without fake timers. Tests that
|
||||
* verify setTimeout behavior use vi.useFakeTimers() + act(vi.advanceTimersByTime).
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act, waitFor } from "@testing-library/react";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import {
|
||||
ExternalConnectModal,
|
||||
type ExternalConnectionInfo,
|
||||
} from "../ExternalConnectModal";
|
||||
|
||||
const defaultInfo: ExternalConnectionInfo = {
|
||||
workspace_id: "ws-123",
|
||||
platform_url: "https://app.example.com",
|
||||
auth_token: "secret-auth-token-abc",
|
||||
registry_endpoint: "https://app.example.com/api/a2a/register",
|
||||
heartbeat_endpoint: "https://app.example.com/api/a2a/heartbeat",
|
||||
// Placeholders must EXACTLY match what the component searches for in
|
||||
// the string.replace() calls (the component does NOT normalise whitespace).
|
||||
// Python: 'AUTH_TOKEN = "...' (4 spaces), curl: WORKSPACE_AUTH_TOKEN="<paste>" (with quotes),
|
||||
// MCP/Hermes: MOLECULE_WORKSPACE_TOKEN="...", Codex: same with 1 space.
|
||||
curl_register_template:
|
||||
`curl -X POST https://app.example.com/api/a2a/register \\
|
||||
-H "Content-Type: application/json" \\
|
||||
-d '{"auth_token": "WORKSPACE_AUTH_TOKEN=\"<paste from create response>\"", ...}'`,
|
||||
python_snippet:
|
||||
'AUTH_TOKEN = "<paste from create response>"\nAPI_URL = "https://app.example.com"',
|
||||
universal_mcp_snippet:
|
||||
'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
|
||||
hermes_channel_snippet:
|
||||
'MOLECULE_WORKSPACE_TOKEN="<paste from create response>"',
|
||||
codex_snippet: 'MOLECULE_WORKSPACE_TOKEN = "<paste from create response>"',
|
||||
openclaw_snippet: 'WORKSPACE_TOKEN="<paste from create response>"',
|
||||
};
|
||||
|
||||
// ─── Clipboard mock helpers ────────────────────────────────────────────────────
|
||||
|
||||
let clipboardWriteText = vi.fn();
|
||||
|
||||
beforeEach(() => {
|
||||
clipboardWriteText.mockReset().mockResolvedValue(undefined);
|
||||
Object.defineProperty(navigator, "clipboard", {
|
||||
value: { writeText: clipboardWriteText },
|
||||
configurable: true,
|
||||
writable: true,
|
||||
});
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
function renderModal(info: ExternalConnectionInfo | null) {
|
||||
return render(
|
||||
<ExternalConnectModal info={info} onClose={vi.fn()} />,
|
||||
);
|
||||
}
|
||||
|
||||
// Flush React + Radix portal updates synchronously so the dialog is in the DOM.
|
||||
function renderAndFlush(info: ExternalConnectionInfo | null) {
|
||||
const result = renderModal(info);
|
||||
act(() => {});
|
||||
return result;
|
||||
}
|
||||
|
||||
// ─── Tests ────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("ExternalConnectModal — render conditions", () => {
|
||||
it("renders nothing when info is null", () => {
|
||||
renderModal(null);
|
||||
expect(document.body.textContent).toBe("");
|
||||
});
|
||||
|
||||
it("renders the dialog when info is provided", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
expect(screen.queryByRole("dialog")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows the security warning about one-time token display", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
expect(screen.getByText(/only once/i)).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("ExternalConnectModal — default tab selection", () => {
|
||||
it("opens the Universal MCP tab by default when universal_mcp_snippet is present", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
const mcpTab = screen.getByRole("tab", { name: /universal mcp/i });
|
||||
expect(mcpTab.getAttribute("aria-selected")).toBe("true");
|
||||
});
|
||||
|
||||
it("opens the Python SDK tab by default when universal_mcp_snippet is absent", () => {
|
||||
renderAndFlush({ ...defaultInfo, universal_mcp_snippet: undefined });
|
||||
const pythonTab = screen.getByRole("tab", { name: /python sdk/i });
|
||||
expect(pythonTab.getAttribute("aria-selected")).toBe("true");
|
||||
});
|
||||
|
||||
it("tab order: Universal MCP appears before Python SDK when both exist", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
const tabs = screen.getAllByRole("tab");
|
||||
const mcpIndex = tabs.findIndex((t) => t.textContent?.includes("Universal MCP"));
|
||||
const pythonIndex = tabs.findIndex((t) => t.textContent?.includes("Python SDK"));
|
||||
expect(mcpIndex).toBeLessThan(pythonIndex);
|
||||
});
|
||||
});
|
||||
|
||||
describe("ExternalConnectModal — tab switching", () => {
|
||||
it("switches to the Python SDK tab and shows the snippet with stamped token", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
fireEvent.click(screen.getByRole("tab", { name: /python sdk/i }));
|
||||
const preEl = document.querySelector("pre");
|
||||
expect(preEl?.textContent).toContain("AUTH_TOKEN");
|
||||
// The placeholder is replaced with the real auth token
|
||||
expect(preEl?.textContent).toContain("secret-auth-token-abc");
|
||||
});
|
||||
|
||||
it("switches to the curl tab and shows the snippet with stamped token", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
fireEvent.click(screen.getByRole("tab", { name: /curl/i }));
|
||||
const preEl = document.querySelector("pre");
|
||||
expect(preEl?.textContent).toContain("curl");
|
||||
expect(preEl?.textContent).toContain("secret-auth-token-abc");
|
||||
});
|
||||
|
||||
it("switches to the Fields tab and shows raw values", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
fireEvent.click(screen.getByRole("tab", { name: /fields/i }));
|
||||
expect(screen.getByText("ws-123")).toBeTruthy();
|
||||
expect(screen.getByText("https://app.example.com")).toBeTruthy();
|
||||
expect(screen.getByText("secret-auth-token-abc")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("hides the Hermes tab when hermes_channel_snippet is absent", () => {
|
||||
renderAndFlush({ ...defaultInfo, hermes_channel_snippet: undefined });
|
||||
expect(screen.queryByRole("tab", { name: /hermes/i })).toBeNull();
|
||||
});
|
||||
|
||||
it("shows Hermes tab when hermes_channel_snippet is present", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
expect(screen.getByRole("tab", { name: /hermes/i })).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("ExternalConnectModal — snippet token stamping", () => {
|
||||
it("stamps the real auth_token into the Python snippet instead of the placeholder", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
fireEvent.click(screen.getByRole("tab", { name: /python sdk/i }));
|
||||
const preEl = document.querySelector("pre");
|
||||
expect(preEl?.textContent).not.toContain("<paste from create response>");
|
||||
expect(preEl?.textContent).toContain("secret-auth-token-abc");
|
||||
});
|
||||
|
||||
it("stamps the real auth_token into the curl snippet", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
fireEvent.click(screen.getByRole("tab", { name: /curl/i }));
|
||||
const preEl = document.querySelector("pre");
|
||||
// curl template uses WORKSPACE_AUTH_TOKEN placeholder, not the generic one
|
||||
expect(preEl?.textContent).toContain("secret-auth-token-abc");
|
||||
});
|
||||
|
||||
it("stamps the real auth_token into the Universal MCP snippet", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
// Default tab is Universal MCP
|
||||
const preEl = document.querySelector("pre");
|
||||
expect(preEl?.textContent).toContain("secret-auth-token-abc");
|
||||
expect(preEl?.textContent).not.toContain("<paste from create response>");
|
||||
});
|
||||
});
|
||||
|
||||
describe("ExternalConnectModal — copy functionality", () => {
|
||||
it("calls navigator.clipboard.writeText with the snippet text", () => {
|
||||
renderAndFlush(defaultInfo);
|
||||
// Default tab is Universal MCP
|
||||
fireEvent.click(screen.getByRole("button", { name: /^copy$/i }));
|
||||
expect(clipboardWriteText).toHaveBeenCalledWith(
|
||||
expect.stringContaining("secret-auth-token-abc"),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("ExternalConnectModal — close behavior", () => {
|
||||
it('calls onClose when "I\'ve saved it — close" is clicked', () => {
|
||||
const onClose = vi.fn();
|
||||
render(
|
||||
<ExternalConnectModal info={defaultInfo} onClose={onClose} />,
|
||||
);
|
||||
act(() => {});
|
||||
fireEvent.click(screen.getByRole("button", { name: /i've saved it/i }));
|
||||
expect(onClose).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
});
|
||||
|
||||
describe("ExternalConnectModal — missing optional fields", () => {
|
||||
it("shows (missing) for absent optional fields in the Fields tab", () => {
|
||||
// Use empty string so Field renders "(missing)" for registry_endpoint
|
||||
const minimalInfo: ExternalConnectionInfo = {
|
||||
workspace_id: "ws-min",
|
||||
platform_url: "https://min.example.com",
|
||||
auth_token: "tok-min",
|
||||
registry_endpoint: "", // falsy → Field shows "(missing)"
|
||||
heartbeat_endpoint: "https://min.example.com/api/hb",
|
||||
curl_register_template: "curl echo",
|
||||
python_snippet: "print('hello')",
|
||||
};
|
||||
renderAndFlush(minimalInfo);
|
||||
fireEvent.click(screen.getByRole("tab", { name: /fields/i }));
|
||||
expect(screen.getByText("(missing)")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("hides the Hermes tab when hermes_channel_snippet is absent", () => {
|
||||
renderAndFlush({ ...defaultInfo, hermes_channel_snippet: undefined });
|
||||
expect(screen.queryByRole("tab", { name: /hermes/i })).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -1,352 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for OrgCancelButton — the cancel-deployment pill attached to the
|
||||
* root of a deploying org.
|
||||
*
|
||||
* Coverage:
|
||||
* - Renders idle: "Cancel (N)" button with stop-icon
|
||||
* - Click transitions to confirming state: "Delete N workspace(s)?" + Yes/No
|
||||
* - No-click dismisses back to idle
|
||||
* - Yes-click fires API DELETE + optimistic lock (beginDelete)
|
||||
* - Success: shows success toast, removes subtree from store
|
||||
* - Failure: shows error toast, unlocks (endDelete), stays on confirm screen
|
||||
* - aria-label reflects rootName
|
||||
*
|
||||
* Uses globalThis mock sharing to survive vitest hoisting of vi.mock factories.
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act } from "@testing-library/react";
|
||||
import { afterEach, describe, expect, it, vi, beforeEach } from "vitest";
|
||||
import { OrgCancelButton } from "../canvas/OrgCancelButton";
|
||||
import { showToast } from "@/components/Toaster";
|
||||
|
||||
vi.mock("@/components/Toaster", () => ({
|
||||
showToast: vi.fn(),
|
||||
}));
|
||||
|
||||
// ─── Types ───────────────────────────────────────────────────────────────────
|
||||
|
||||
interface MockNode {
|
||||
id: string;
|
||||
parentId: string | null;
|
||||
data: { parentId: string | null };
|
||||
}
|
||||
|
||||
interface MockStore {
|
||||
nodes: MockNode[];
|
||||
deletingIds: Set<string>;
|
||||
beginDelete: ReturnType<typeof vi.fn>;
|
||||
endDelete: ReturnType<typeof vi.fn>;
|
||||
setState: ReturnType<typeof vi.fn>;
|
||||
hydrate: ReturnType<typeof vi.fn>;
|
||||
edges: unknown[];
|
||||
}
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
declare global {
|
||||
var __orgCancelMocks: {
|
||||
store: MockStore;
|
||||
apiDel: ReturnType<typeof vi.fn>;
|
||||
} | undefined;
|
||||
}
|
||||
|
||||
// ─── Setup ────────────────────────────────────────────────────────────────────
|
||||
// All module-level declarations used inside vi.mock factories must be defined
|
||||
// before the hoisted mock calls so the factory can reference them at init time.
|
||||
// vi.hoisted captures live references from its call-site lexical scope.
|
||||
|
||||
// Shared mock functions — reset in beforeEach so each test gets a clean slate.
|
||||
const mockApiDel = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
|
||||
// Store factory — hoisted so it is available inside the vi.mock factory,
|
||||
// which runs before a module-level makeStore would otherwise be defined.
|
||||
// Each vi.fn() is created once per test file lifetime; reset in beforeEach.
|
||||
const mockBeginDelete = vi.hoisted(() => vi.fn());
|
||||
const mockEndDelete = vi.hoisted(() => vi.fn());
|
||||
const mockSetState = vi.hoisted(() => vi.fn());
|
||||
const mockHydrate = vi.hoisted(() => vi.fn());
|
||||
|
||||
const makeStore = vi.hoisted(
|
||||
() =>
|
||||
(nodes: MockNode[]): MockStore => ({
|
||||
nodes,
|
||||
deletingIds: new Set(),
|
||||
beginDelete: mockBeginDelete,
|
||||
endDelete: mockEndDelete,
|
||||
setState: mockSetState,
|
||||
hydrate: mockHydrate,
|
||||
edges: [],
|
||||
}),
|
||||
);
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: { del: mockApiDel },
|
||||
}));
|
||||
|
||||
// Mutable container so the vi.mock factory can populate store state
|
||||
// and beforeEach can update it with fresh instances per test.
|
||||
const storeBox = vi.hoisted(() => ({ current: null as MockStore | null }));
|
||||
|
||||
vi.mock("@/store/canvas", () => {
|
||||
storeBox.current = makeStore([]);
|
||||
const mockStore = vi.fn((selector?: (s: MockStore) => unknown) =>
|
||||
selector ? selector(storeBox.current!) : storeBox.current,
|
||||
) as ReturnType<typeof vi.fn> & { getState: () => MockStore };
|
||||
Object.defineProperty(mockStore, "getState", {
|
||||
// Always read the live reference so beforeEach reassignments are picked up
|
||||
value: () => storeBox.current!,
|
||||
});
|
||||
(globalThis as unknown as { __orgCancelMocks: typeof globalThis.__orgCancelMocks }).__orgCancelMocks = {
|
||||
// Point at live storeBox.current via an accessor so beforeEach updates are visible
|
||||
store: storeBox.current!,
|
||||
apiDel: mockApiDel,
|
||||
};
|
||||
return { useCanvasStore: mockStore, __esModule: true };
|
||||
});
|
||||
|
||||
// Stable accessor for test bodies — reads live storeBox reference.
|
||||
const store = () => storeBox.current!;
|
||||
|
||||
// Expose the mutable box itself so beforeEach can update the live store.
|
||||
// (storeBox is const but its .current property is mutable.)
|
||||
export { storeBox };
|
||||
|
||||
const renderButton = (
|
||||
rootId = "root-1",
|
||||
rootName = "Test Org",
|
||||
workspaceCount = 3,
|
||||
) => {
|
||||
return render(
|
||||
<OrgCancelButton
|
||||
rootId={rootId}
|
||||
rootName={rootName}
|
||||
workspaceCount={workspaceCount}
|
||||
/>,
|
||||
);
|
||||
};
|
||||
|
||||
// ─── Tests ────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("OrgCancelButton — idle state", () => {
|
||||
beforeEach(() => {
|
||||
mockBeginDelete.mockReset();
|
||||
mockEndDelete.mockReset();
|
||||
mockSetState.mockReset();
|
||||
mockHydrate.mockReset();
|
||||
mockApiDel.mockReset().mockResolvedValue({});
|
||||
storeBox.current = makeStore([
|
||||
{ id: "root-1", parentId: null, data: { parentId: null } },
|
||||
{ id: "child-1", parentId: "root-1", data: { parentId: "root-1" } },
|
||||
{ id: "child-2", parentId: "root-1", data: { parentId: "root-1" } },
|
||||
]);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
});
|
||||
|
||||
it("renders the Cancel pill with workspace count in the visible span", () => {
|
||||
renderButton();
|
||||
const btn = screen.getByRole("button", { name: /cancel deployment of test org/i });
|
||||
const span = btn.querySelector("span");
|
||||
expect(span).toBeTruthy();
|
||||
expect(span!.textContent).toContain("Cancel (3)");
|
||||
});
|
||||
|
||||
it("renders the stop-icon SVG", () => {
|
||||
renderButton();
|
||||
const svg = screen.getByRole("button", { name: /cancel deployment of test org/i }).querySelector("svg");
|
||||
expect(svg).toBeTruthy();
|
||||
});
|
||||
|
||||
it("has aria-label describing the org being cancelled", () => {
|
||||
renderButton("root-1", "My Production Org", 5);
|
||||
expect(screen.getByRole("button", { name: /cancel deployment of my production org/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("has nodrag class on the button", () => {
|
||||
renderButton();
|
||||
const btn = screen.getByRole("button", { name: /cancel deployment of test org/i });
|
||||
expect(btn.classList).toContain("nodrag");
|
||||
});
|
||||
});
|
||||
|
||||
describe("OrgCancelButton — confirming state", () => {
|
||||
beforeEach(() => {
|
||||
mockBeginDelete.mockReset();
|
||||
mockEndDelete.mockReset();
|
||||
mockSetState.mockReset();
|
||||
mockHydrate.mockReset();
|
||||
mockApiDel.mockReset().mockResolvedValue({});
|
||||
storeBox.current = makeStore([
|
||||
{ id: "root-1", parentId: null, data: { parentId: null } },
|
||||
{ id: "child-1", parentId: "root-1", data: { parentId: "root-1" } },
|
||||
]);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
});
|
||||
|
||||
it("enters confirming state on Cancel click", () => {
|
||||
renderButton("root-1", "Test Org", 2);
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
expect(screen.getByText(/delete 2 workspaces\?/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it('shows "Yes" button that triggers deletion', () => {
|
||||
renderButton("root-1", "Test Org", 2);
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
expect(screen.getByRole("button", { name: /yes/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it('shows "No" button that dismisses confirming state', () => {
|
||||
renderButton("root-1", "Test Org", 2);
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
expect(screen.getByRole("button", { name: /no/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it('clicking "No" dismisses the confirm and restores the Cancel pill', () => {
|
||||
renderButton("root-1", "Test Org", 2);
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
fireEvent.click(screen.getByRole("button", { name: /no/i }));
|
||||
expect(screen.queryByText(/delete 2 workspaces\?/i)).toBeFalsy();
|
||||
expect(screen.getByRole("button", { name: /cancel deployment of test org/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it('clicking "Yes" disables both buttons while submitting', async () => {
|
||||
mockApiDel.mockImplementation(() => new Promise(() => {}));
|
||||
renderButton("root-1", "Test Org", 2);
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
const yesBtn = screen.getByRole("button", { name: /yes/i });
|
||||
const noBtn = screen.getByRole("button", { name: /no/i });
|
||||
fireEvent.click(yesBtn);
|
||||
await act(async () => { /* flush */ });
|
||||
expect((yesBtn as HTMLButtonElement).disabled).toBe(true);
|
||||
expect((noBtn as HTMLButtonElement).disabled).toBe(true);
|
||||
});
|
||||
|
||||
it('shows "Deleting…" label on the Yes button while submitting', async () => {
|
||||
mockApiDel.mockImplementation(() => new Promise(() => {}));
|
||||
renderButton("root-1", "Test Org", 2);
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
fireEvent.click(screen.getByRole("button", { name: /yes/i }));
|
||||
await act(async () => { /* flush */ });
|
||||
expect(screen.getByText(/deleting…/i)).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("OrgCancelButton — API interactions", () => {
|
||||
beforeEach(() => {
|
||||
mockBeginDelete.mockReset();
|
||||
mockEndDelete.mockReset();
|
||||
mockSetState.mockReset();
|
||||
mockHydrate.mockReset();
|
||||
mockApiDel.mockReset().mockResolvedValue({});
|
||||
storeBox.current = makeStore([
|
||||
{ id: "root-1", parentId: null, data: { parentId: null } },
|
||||
{ id: "child-1", parentId: "root-1", data: { parentId: "root-1" } },
|
||||
{ id: "grandchild-1", parentId: "child-1", data: { parentId: "child-1" } },
|
||||
]);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
});
|
||||
|
||||
it("calls beginDelete with the full subtree before the network call", async () => {
|
||||
renderButton();
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
fireEvent.click(screen.getByRole("button", { name: /yes/i }));
|
||||
await act(async () => { /* flush */ });
|
||||
expect(mockBeginDelete).toHaveBeenCalled();
|
||||
const calledIds = mockBeginDelete.mock.calls[0][0] as Set<string>;
|
||||
expect(calledIds.has("root-1")).toBe(true);
|
||||
expect(calledIds.has("child-1")).toBe(true);
|
||||
expect(calledIds.has("grandchild-1")).toBe(true);
|
||||
});
|
||||
|
||||
it("calls DELETE /workspaces/:rootId?confirm=true", async () => {
|
||||
renderButton();
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
fireEvent.click(screen.getByRole("button", { name: /yes/i }));
|
||||
await act(async () => { /* flush */ });
|
||||
expect(mockApiDel).toHaveBeenCalledWith("/workspaces/root-1?confirm=true");
|
||||
});
|
||||
|
||||
it("shows success toast on DELETE success", async () => {
|
||||
renderButton();
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
fireEvent.click(screen.getByRole("button", { name: /yes/i }));
|
||||
await act(async () => { /* flush */ });
|
||||
expect(vi.mocked(showToast)).toHaveBeenCalledWith(
|
||||
'Cancelled deployment of "Test Org"',
|
||||
"success",
|
||||
);
|
||||
});
|
||||
|
||||
it("calls endDelete with subtree ids on success", async () => {
|
||||
renderButton();
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
fireEvent.click(screen.getByRole("button", { name: /yes/i }));
|
||||
await act(async () => { /* flush */ });
|
||||
expect(mockEndDelete).toHaveBeenCalled();
|
||||
const calledIds = mockEndDelete.mock.calls[0][0] as Set<string>;
|
||||
expect(calledIds.has("root-1")).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe("OrgCancelButton — failure path", () => {
|
||||
beforeEach(() => {
|
||||
mockBeginDelete.mockReset();
|
||||
mockEndDelete.mockReset();
|
||||
mockSetState.mockReset();
|
||||
mockHydrate.mockReset();
|
||||
mockApiDel.mockReset();
|
||||
storeBox.current = makeStore([
|
||||
{ id: "root-1", parentId: null, data: { parentId: null } },
|
||||
{ id: "child-1", parentId: "root-1", data: { parentId: "root-1" } },
|
||||
]);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
});
|
||||
|
||||
it("shows error toast on DELETE failure", async () => {
|
||||
mockApiDel.mockRejectedValue(new Error("Gateway timeout"));
|
||||
renderButton("root-1", "Test Org", 2);
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
fireEvent.click(screen.getByRole("button", { name: /yes/i }));
|
||||
await act(async () => { /* flush */ });
|
||||
expect(vi.mocked(showToast)).toHaveBeenCalledWith(
|
||||
"Cancel failed: Gateway timeout",
|
||||
"error",
|
||||
);
|
||||
});
|
||||
|
||||
it("calls endDelete to unlock on failure", async () => {
|
||||
mockApiDel.mockRejectedValue(new Error("Gateway timeout"));
|
||||
renderButton("root-1", "Test Org", 2);
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
fireEvent.click(screen.getByRole("button", { name: /yes/i }));
|
||||
await act(async () => { /* flush */ });
|
||||
expect(store().endDelete).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("returns to confirming state after failure so user can retry", async () => {
|
||||
mockApiDel.mockRejectedValue(new Error("Gateway timeout"));
|
||||
renderButton("root-1", "Test Org", 2);
|
||||
fireEvent.click(screen.getByRole("button", { name: /cancel deployment of test org/i }));
|
||||
fireEvent.click(screen.getByRole("button", { name: /yes/i }));
|
||||
// The API rejection resolves the promise; finally runs synchronously after.
|
||||
// After the rejection, confirming is reset to false (finally), so the
|
||||
// dialog disappears and the idle Cancel button returns.
|
||||
// Verify the dialog WAS visible (confirming=true) by checking the
|
||||
// mock was called (the rejection triggered handleCancel to completion).
|
||||
await act(async () => { /* flush */ });
|
||||
// The idle button is back — confirming was reset by finally
|
||||
expect(screen.getByRole("button", { name: /cancel deployment of test org/i })).toBeTruthy();
|
||||
});
|
||||
});
|
||||
@@ -44,6 +44,7 @@ async function waitForDialog() {
|
||||
describe("PurchaseSuccessModal — render conditions", () => {
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
clearSearch();
|
||||
});
|
||||
|
||||
@@ -112,6 +113,8 @@ describe("PurchaseSuccessModal — dismiss", () => {
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
vi.useRealTimers(); // ensure no fake timer leak
|
||||
clearSearch();
|
||||
});
|
||||
|
||||
@@ -167,6 +170,7 @@ describe("PurchaseSuccessModal — URL stripping", () => {
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
clearSearch();
|
||||
});
|
||||
|
||||
@@ -192,10 +196,13 @@ describe("PurchaseSuccessModal — URL stripping", () => {
|
||||
describe("PurchaseSuccessModal — accessibility", () => {
|
||||
beforeEach(() => {
|
||||
setSearch("?purchase_success=1&item=TestItem");
|
||||
vi.useRealTimers(); // ensure clean state
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
vi.useRealTimers(); // ensure no fake timer leak
|
||||
clearSearch();
|
||||
});
|
||||
|
||||
|
||||
@@ -63,7 +63,6 @@ export function DropTargetBadge() {
|
||||
<>
|
||||
{ghostVisible && (
|
||||
<div
|
||||
data-testid="ghost-slot"
|
||||
className="pointer-events-none absolute z-40 rounded-lg border-2 border-dashed border-emerald-400/70 bg-emerald-500/10"
|
||||
style={{
|
||||
left: slotTL.x,
|
||||
@@ -74,7 +73,6 @@ export function DropTargetBadge() {
|
||||
/>
|
||||
)}
|
||||
<div
|
||||
data-testid="drop-badge"
|
||||
className="pointer-events-none absolute z-50 -translate-x-1/2 -translate-y-full rounded-md bg-emerald-500 px-2 py-0.5 text-[11px] font-medium text-emerald-50 shadow-lg shadow-emerald-950/40"
|
||||
style={{ left: badge.x, top: badge.y - 6 }}
|
||||
>
|
||||
|
||||
@@ -1,253 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for DropTargetBadge — floating drag affordance rendered over the
|
||||
* ReactFlow canvas while a workspace node is being dragged onto a parent.
|
||||
*
|
||||
* Covers:
|
||||
* - Renders nothing when dragOverNodeId is null
|
||||
* - Renders nothing when target node not found in store
|
||||
* - Renders nothing when getInternalNode returns null
|
||||
* - Renders ghost slot + badge when valid target is found
|
||||
* - Ghost hidden when slot falls outside parent bounds
|
||||
* - Badge text includes the target workspace name
|
||||
* - Badge positioned via screen-space coordinates from flowToScreenPosition
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, cleanup } from "@testing-library/react";
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { DropTargetBadge } from "../DropTargetBadge";
|
||||
|
||||
// ─── Mutable store state — hoisted so vi.mock factory closures capture the ref ─
|
||||
|
||||
let _storeState: {
|
||||
dragOverNodeId: string | null;
|
||||
nodes: Array<{
|
||||
id: string;
|
||||
data: Record<string, unknown>;
|
||||
parentId: string | null;
|
||||
measured?: { width: number; height: number };
|
||||
}>;
|
||||
} = {
|
||||
dragOverNodeId: null,
|
||||
nodes: [],
|
||||
};
|
||||
|
||||
const _subscribers = new Set<() => void>();
|
||||
function _notifySubscribers() {
|
||||
for (const fn of _subscribers) fn();
|
||||
}
|
||||
|
||||
const _mockUseCanvasStore = vi.hoisted(() => {
|
||||
const impl = (selector: (s: typeof _storeState) => unknown) => selector(_storeState);
|
||||
return impl;
|
||||
});
|
||||
|
||||
// Module-level mutable impl — setFlowMock() swaps it out per test.
|
||||
let _flowImpl: (arg: { x: number; y: number }) => { x: number; y: number } =
|
||||
({ x, y }) => ({ x: x * 2, y: y * 2 });
|
||||
|
||||
let _flowToScreenPosition = vi.hoisted(() =>
|
||||
vi.fn((arg: { x: number; y: number }) => _flowImpl(arg)),
|
||||
);
|
||||
|
||||
let _getInternalNode = vi.hoisted(() =>
|
||||
vi.fn<(id: string) => {
|
||||
internals: { positionAbsolute: { x: number; y: number } };
|
||||
measured?: { width: number; height: number };
|
||||
} | null>(() => null),
|
||||
);
|
||||
|
||||
const _mockUseReactFlow = vi.hoisted(() =>
|
||||
vi.fn(() => ({
|
||||
getInternalNode: _getInternalNode,
|
||||
flowToScreenPosition: _flowToScreenPosition,
|
||||
})),
|
||||
);
|
||||
|
||||
// ─── Module mocks ─────────────────────────────────────────────────────────────
|
||||
|
||||
vi.mock("@/store/canvas", () => ({
|
||||
useCanvasStore: _mockUseCanvasStore,
|
||||
}));
|
||||
|
||||
vi.mock("@xyflow/react", () => ({
|
||||
useReactFlow: _mockUseReactFlow,
|
||||
}));
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
function setStore(state: Partial<typeof _storeState>) {
|
||||
_storeState = { ..._storeState, ...state };
|
||||
_notifySubscribers();
|
||||
}
|
||||
|
||||
// Helper to set per-test flowToScreenPosition mock — replaces _flowImpl.
|
||||
function setFlowMock(impl: (arg: { x: number; y: number }) => { x: number; y: number }) {
|
||||
_flowImpl = impl;
|
||||
}
|
||||
|
||||
// ─── Tests ────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("DropTargetBadge — renders nothing when not dragging", () => {
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
_storeState = { dragOverNodeId: null, nodes: [] };
|
||||
_getInternalNode.mockReset().mockReturnValue(null);
|
||||
_flowImpl = ({ x, y }) => ({ x: x * 2, y: y * 2 });
|
||||
});
|
||||
|
||||
it("returns null when dragOverNodeId is null", () => {
|
||||
setStore({ dragOverNodeId: null });
|
||||
render(<DropTargetBadge />);
|
||||
expect(document.body.textContent).toBe("");
|
||||
});
|
||||
|
||||
it("returns null when target node not found in store nodes array", () => {
|
||||
setStore({ dragOverNodeId: "ws-target", nodes: [] });
|
||||
render(<DropTargetBadge />);
|
||||
expect(document.body.textContent).toBe("");
|
||||
});
|
||||
});
|
||||
|
||||
describe("DropTargetBadge — renders nothing when getInternalNode is null", () => {
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
_storeState = { dragOverNodeId: null, nodes: [] };
|
||||
_getInternalNode.mockReset().mockReturnValue(null);
|
||||
_flowImpl = ({ x, y }) => ({ x: x * 2, y: y * 2 });
|
||||
});
|
||||
|
||||
it("returns null when getInternalNode returns null (node not in RF viewport)", () => {
|
||||
_getInternalNode.mockReturnValue(null);
|
||||
setStore({
|
||||
dragOverNodeId: "ws-target",
|
||||
nodes: [{ id: "ws-target", data: { name: "Target WS" }, parentId: null }],
|
||||
});
|
||||
render(<DropTargetBadge />);
|
||||
expect(document.body.textContent).toBe("");
|
||||
});
|
||||
});
|
||||
|
||||
describe("DropTargetBadge — renders ghost slot + badge for valid drag target", () => {
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
_storeState = { dragOverNodeId: null, nodes: [] };
|
||||
_getInternalNode.mockReset().mockReturnValue(null);
|
||||
_flowImpl = ({ x, y }) => ({ x: x * 2, y: y * 2 });
|
||||
});
|
||||
|
||||
it("renders the drop badge with target name", () => {
|
||||
_getInternalNode.mockReturnValue({
|
||||
internals: { positionAbsolute: { x: 100, y: 200 } },
|
||||
measured: { width: 220, height: 120 },
|
||||
});
|
||||
_flowToScreenPosition
|
||||
.mockReturnValueOnce({ x: 500, y: 400 }) // slotTL
|
||||
.mockReturnValueOnce({ x: 900, y: 600 }) // slotBR
|
||||
.mockReturnValueOnce({ x: 700, y: 200 }); // badge
|
||||
|
||||
setStore({
|
||||
dragOverNodeId: "ws-target",
|
||||
nodes: [
|
||||
{ id: "ws-target", data: { name: "SEO Workspace" }, parentId: null, measured: { width: 220, height: 120 } },
|
||||
],
|
||||
});
|
||||
render(<DropTargetBadge />);
|
||||
expect(screen.getByText(/Drop into: SEO Workspace/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders the ghost slot div via data-testid", () => {
|
||||
// measured.height must be large enough that parentBR.y > slotTL.y=330 so
|
||||
// ghostVisible = (slotTL.y < parentBR.y) is true.
|
||||
// parentBR.y = abs.y + measured.height = 200 + h > 330 → h > 130
|
||||
_getInternalNode.mockReturnValue({
|
||||
internals: { positionAbsolute: { x: 100, y: 200 } },
|
||||
measured: { width: 220, height: 500 },
|
||||
});
|
||||
// Component calls flowToScreenPosition 5 times (confirmed via debug):
|
||||
// 1) badge {x:210, y:200} -> {x:420, y:400} (badge center)
|
||||
// 2) slotTL {x:116, y:330} -> {x:232, y:660} (slot origin)
|
||||
// 3) slotBR {x:356, y:460} -> {x:712, y:920} (ghost uses this)
|
||||
// 4) parentTL {x:100, y:200} -> {x:200, y:400} (parent origin)
|
||||
// 5) parentBR {x:320, y:320} -> {x:640, y:640} (parent corner)
|
||||
setFlowMock(({ x, y }: { x: number; y: number }) => {
|
||||
if (x === 210 && y === 200) return { x: 420, y: 400 };
|
||||
if (x === 116 && y === 330) return { x: 232, y: 660 };
|
||||
if (x === 356 && y === 460) return { x: 712, y: 920 };
|
||||
if (x === 100 && y === 200) return { x: 200, y: 400 };
|
||||
// 5th call: parentBR = abs + {w:220, h:500} = {320, 700}
|
||||
if (x === 320 && y === 700) return { x: 640, y: 1400 };
|
||||
return { x: x * 2, y: y * 2 };
|
||||
});
|
||||
|
||||
setStore({
|
||||
dragOverNodeId: "ws-target",
|
||||
nodes: [
|
||||
{ id: "ws-target", data: { name: "Target" }, parentId: null, measured: { width: 220, height: 500 } },
|
||||
],
|
||||
});
|
||||
render(<DropTargetBadge />);
|
||||
expect(screen.getByTestId("ghost-slot")).toBeTruthy();
|
||||
// Ghost uses slotBR from 3rd call: slotBR - slotTL = (712-232, 920-660)
|
||||
expect(screen.getByTestId("ghost-slot").style.left).toBe("232px");
|
||||
expect(screen.getByTestId("ghost-slot").style.top).toBe("660px");
|
||||
expect(screen.getByTestId("ghost-slot").style.width).toBe("480px");
|
||||
expect(screen.getByTestId("ghost-slot").style.height).toBe("260px");
|
||||
});
|
||||
|
||||
it("ghost is hidden when slot falls entirely outside parent bounds", () => {
|
||||
_getInternalNode.mockReturnValue({
|
||||
internals: { positionAbsolute: { x: 100, y: 200 } },
|
||||
measured: { width: 220, height: 120 },
|
||||
});
|
||||
// Set slotBR (3rd call) to be inside parent to hide ghost.
|
||||
// slotBR.x ≤ parentTL.x makes slotBR.x - slotTL.x < 0 → ghostVisible = false.
|
||||
setFlowMock(({ x, y }: { x: number; y: number }) => {
|
||||
if (x === 210 && y === 200) return { x: 420, y: 400 }; // badge (1st call)
|
||||
if (x === 116 && y === 330) return { x: 232, y: 660 }; // slotTL (2nd call)
|
||||
if (x === 356 && y === 460) return { x: 150, y: 460 }; // slotBR (3rd): slotBR.x=150 < parentTL.x=200 → hidden
|
||||
if (x === 100 && y === 200) return { x: 200, y: 400 }; // parentTL (4th call)
|
||||
if (x === 320 && y === 320) return { x: 640, y: 640 }; // parentBR (5th call)
|
||||
return { x: x * 2, y: y * 2 };
|
||||
});
|
||||
|
||||
setStore({
|
||||
dragOverNodeId: "ws-target",
|
||||
nodes: [
|
||||
{ id: "ws-target", data: { name: "Tiny" }, parentId: null, measured: { width: 220, height: 120 } },
|
||||
],
|
||||
});
|
||||
render(<DropTargetBadge />);
|
||||
// Badge should still render, ghost should not
|
||||
expect(screen.getByText(/Drop into: Tiny/)).toBeTruthy();
|
||||
expect(screen.queryByTestId("ghost-slot")).toBeNull();
|
||||
});
|
||||
|
||||
it("badge is absolutely positioned with left and top from flowToScreenPosition", () => {
|
||||
_getInternalNode.mockReturnValue({
|
||||
internals: { positionAbsolute: { x: 100, y: 200 } },
|
||||
measured: { width: 220, height: 120 },
|
||||
});
|
||||
setFlowMock(({ x, y }: { x: number; y: number }) => {
|
||||
if (x === 210 && y === 200) return { x: 420, y: 400 };
|
||||
if (x === 116 && y === 330) return { x: 232, y: 660 };
|
||||
if (x === 356 && y === 460) return { x: 712, y: 920 };
|
||||
if (x === 100 && y === 200) return { x: 200, y: 400 };
|
||||
if (x === 320 && y === 320) return { x: 640, y: 640 };
|
||||
return { x: x * 2, y: y * 2 };
|
||||
});
|
||||
|
||||
setStore({
|
||||
dragOverNodeId: "ws-target",
|
||||
nodes: [
|
||||
{ id: "ws-target", data: { name: "Target" }, parentId: null, measured: { width: 220, height: 120 } },
|
||||
],
|
||||
});
|
||||
render(<DropTargetBadge />);
|
||||
expect(screen.getByTestId("drop-badge")).toBeTruthy();
|
||||
// Badge uses 1st call: {x:210,y:200} -> {x:420,y:400}, badge.y = 400-6 = 394
|
||||
expect(screen.getByTestId("drop-badge").style.left).toBe("420px");
|
||||
expect(screen.getByTestId("drop-badge").style.top).toBe("394px");
|
||||
expect(screen.getByText(/Drop into: Target/)).toBeTruthy();
|
||||
});
|
||||
});
|
||||
@@ -54,14 +54,9 @@ export function MobileChat({
|
||||
// user sees their prior thread on entry. The store is updated by the
|
||||
// socket → ChatTab flows the desktop runs; on mobile we read from the
|
||||
// same buffer to keep state coherent across viewports.
|
||||
// NOTE: do NOT use `?? []` in the selector — Zustand uses Object.is
|
||||
// for selector equality. A fallback `?? []` creates a new [] reference on
|
||||
// every store update when agentMessages[agentId] is undefined, causing an
|
||||
// infinite re-render loop (React error #185 / Maximum update depth
|
||||
// exceeded). The undefined case is handled by the initializer below.
|
||||
const storedMessages = useCanvasStore((s) => s.agentMessages[agentId]);
|
||||
const storedMessages = useCanvasStore((s) => s.agentMessages[agentId] ?? []);
|
||||
const [messages, setMessages] = useState<ChatMessage[]>(() =>
|
||||
(storedMessages ?? []).map((m) => ({
|
||||
storedMessages.map((m) => ({
|
||||
id: m.id,
|
||||
role: "agent",
|
||||
text: m.content,
|
||||
|
||||
@@ -1,131 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* palette-context: MobileAccentProvider + usePalette hook coverage.
|
||||
*
|
||||
* Covers:
|
||||
* - usePalette(dark=false) without provider → MOL_LIGHT
|
||||
* - usePalette(dark=true) without provider → MOL_DARK
|
||||
* - usePalette with provider accent=null → base palette unchanged
|
||||
* - usePalette with provider accent=base.accent → base palette unchanged (identity guard)
|
||||
* - usePalette with provider accent="#ff0000" → accent + online overridden
|
||||
* - MobileAccentProvider renders children
|
||||
* - Never mutates the static MOL_LIGHT/MOL_DARK singletons
|
||||
*
|
||||
* The pure functions (getPalette, normalizeStatus, tierCode) are covered
|
||||
* in palette.test.ts — only the React context/hook is tested here.
|
||||
*/
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, render } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { MobileAccentProvider, usePalette } from "../palette-context";
|
||||
import { MOL_DARK, MOL_LIGHT } from "../palette";
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
// ─── Test helpers ──────────────────────────────────────────────────────────────
|
||||
// Each helper renders exactly one usePalette value as a testid element.
|
||||
// Using unique testids per scenario avoids "multiple elements" DOM pollution
|
||||
// when tests run in the same jsdom worker without strict cleanup timing.
|
||||
|
||||
function AccentDump({ dark }: { dark: boolean }) {
|
||||
const palette = usePalette(dark);
|
||||
return <span data-testid="accent-val">{palette.accent}</span>;
|
||||
}
|
||||
|
||||
function OnlineDump({ dark }: { dark: boolean }) {
|
||||
const palette = usePalette(dark);
|
||||
return <span data-testid="online-val">{palette.online}</span>;
|
||||
}
|
||||
|
||||
// ─── MobileAccentProvider ──────────────────────────────────────────────────────
|
||||
describe("MobileAccentProvider", () => {
|
||||
it("renders children", () => {
|
||||
const { getByText } = render(
|
||||
<MobileAccentProvider accent={null}>
|
||||
<span>child content</span>
|
||||
</MobileAccentProvider>,
|
||||
);
|
||||
expect(getByText("child content").textContent).toBe("child content");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── usePalette — no provider ─────────────────────────────────────────────────
|
||||
describe("usePalette without MobileAccentProvider", () => {
|
||||
it("returns MOL_LIGHT when dark=false", () => {
|
||||
const { getByTestId } = render(<AccentDump dark={false} />);
|
||||
expect(getByTestId("accent-val").textContent).toBe(MOL_LIGHT.accent);
|
||||
});
|
||||
|
||||
it("returns MOL_DARK when dark=true", () => {
|
||||
const { getByTestId } = render(<AccentDump dark={true} />);
|
||||
expect(getByTestId("accent-val").textContent).toBe(MOL_DARK.accent);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── usePalette — with MobileAccentProvider ────────────────────────────────────
|
||||
describe("usePalette with MobileAccentProvider", () => {
|
||||
it("returns base palette unchanged when accent=null", () => {
|
||||
const { getByTestId } = render(
|
||||
<MobileAccentProvider accent={null}>
|
||||
<AccentDump dark={false} />
|
||||
</MobileAccentProvider>,
|
||||
);
|
||||
expect(getByTestId("accent-val").textContent).toBe(MOL_LIGHT.accent);
|
||||
});
|
||||
|
||||
it("returns base palette unchanged when accent matches base.accent (identity guard)", () => {
|
||||
const { getByTestId } = render(
|
||||
<MobileAccentProvider accent={MOL_LIGHT.accent}>
|
||||
<AccentDump dark={false} />
|
||||
</MobileAccentProvider>,
|
||||
);
|
||||
expect(getByTestId("accent-val").textContent).toBe(MOL_LIGHT.accent);
|
||||
});
|
||||
|
||||
it("overrides accent when provider supplies a different colour", () => {
|
||||
const CUSTOM = "#ff0000";
|
||||
const { getByTestId } = render(
|
||||
<MobileAccentProvider accent={CUSTOM}>
|
||||
<AccentDump dark={false} />
|
||||
</MobileAccentProvider>,
|
||||
);
|
||||
expect(getByTestId("accent-val").textContent).toBe(CUSTOM);
|
||||
});
|
||||
|
||||
it("also overrides online when accent is overridden", () => {
|
||||
const CUSTOM = "#ff8800";
|
||||
const { getByTestId } = render(
|
||||
<MobileAccentProvider accent={CUSTOM}>
|
||||
<OnlineDump dark={false} />
|
||||
</MobileAccentProvider>,
|
||||
);
|
||||
expect(getByTestId("online-val").textContent).toBe(CUSTOM);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Immutability ─────────────────────────────────────────────────────────────
|
||||
describe("MOL_LIGHT and MOL_DARK singletons are never mutated", () => {
|
||||
it("MOL_LIGHT.accent unchanged after custom-accent render", () => {
|
||||
const before = MOL_LIGHT.accent;
|
||||
render(
|
||||
<MobileAccentProvider accent="#deadbeef">
|
||||
<AccentDump dark={false} />
|
||||
</MobileAccentProvider>,
|
||||
);
|
||||
expect(MOL_LIGHT.accent).toBe(before);
|
||||
});
|
||||
|
||||
it("MOL_DARK.accent unchanged after custom-accent render", () => {
|
||||
const before = MOL_DARK.accent;
|
||||
render(
|
||||
<MobileAccentProvider accent="#bada55ff">
|
||||
<AccentDump dark={true} />
|
||||
</MobileAccentProvider>,
|
||||
);
|
||||
expect(MOL_DARK.accent).toBe(before);
|
||||
});
|
||||
});
|
||||
@@ -1,6 +1,5 @@
|
||||
'use client';
|
||||
|
||||
import { useRef } from 'react';
|
||||
import * as AlertDialog from '@radix-ui/react-alert-dialog';
|
||||
|
||||
interface UnsavedChangesGuardProps {
|
||||
@@ -22,22 +21,8 @@ export function UnsavedChangesGuard({
|
||||
onKeepEditing,
|
||||
onDiscard,
|
||||
}: UnsavedChangesGuardProps) {
|
||||
const pendingDiscard = useRef(false);
|
||||
|
||||
return (
|
||||
<AlertDialog.Root
|
||||
open={open}
|
||||
onOpenChange={(o) => {
|
||||
if (!o) {
|
||||
if (pendingDiscard.current) {
|
||||
pendingDiscard.current = false;
|
||||
onDiscard();
|
||||
} else {
|
||||
onKeepEditing();
|
||||
}
|
||||
}
|
||||
}}
|
||||
>
|
||||
<AlertDialog.Root open={open} onOpenChange={(o) => { if (!o) onKeepEditing(); }}>
|
||||
<AlertDialog.Portal>
|
||||
<AlertDialog.Overlay className="guard-dialog__overlay" />
|
||||
<AlertDialog.Content className="guard-dialog">
|
||||
@@ -51,13 +36,7 @@ export function UnsavedChangesGuard({
|
||||
</button>
|
||||
</AlertDialog.Cancel>
|
||||
<AlertDialog.Action asChild>
|
||||
<button
|
||||
type="button"
|
||||
className="guard-dialog__discard-btn"
|
||||
onClick={() => {
|
||||
pendingDiscard.current = true;
|
||||
}}
|
||||
>
|
||||
<button type="button" className="guard-dialog__discard-btn">
|
||||
Discard
|
||||
</button>
|
||||
</AlertDialog.Action>
|
||||
|
||||
@@ -1,225 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* DeleteConfirmDialog — destructive confirmation for deleting a secret key.
|
||||
*
|
||||
* Per spec §3.5 & §4.5:
|
||||
* - Opens via window 'secret:delete-request' custom event
|
||||
* - Shows title "Delete \"{name}\"?"
|
||||
* - Fetches dependents live on open
|
||||
* - Delete button disabled for 1s (CONFIRM_DELAY_MS)
|
||||
* - Focus-trapped (AlertDialog)
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs.
|
||||
*
|
||||
* Covers:
|
||||
* - Does not render when no delete request pending
|
||||
* - Renders dialog when secret:delete-request fires
|
||||
* - Title contains secret name
|
||||
* - Cancel and Delete buttons present
|
||||
* - role=alertdialog on dialog content
|
||||
* - Delete button disabled initially (1s delay)
|
||||
* - Delete button enabled after delay
|
||||
* - Loading state while fetching dependents
|
||||
* - Shows dependents list when present
|
||||
* - Shows no-dependents message when none
|
||||
* - Cancel closes dialog
|
||||
* - Delete button calls deleteSecret and shows Deleting… state
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { act, cleanup, fireEvent, render, waitFor } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { DeleteConfirmDialog } from "../DeleteConfirmDialog";
|
||||
|
||||
// ─── Mocks ─────────────────────────────────────────────────────────────────────
|
||||
|
||||
const _mockDeleteSecret = vi.fn<() => Promise<void>>();
|
||||
const _mockFetchDependents = vi.fn<() => Promise<string[]>>();
|
||||
|
||||
vi.mock("@/stores/secrets-store", () => ({
|
||||
useSecretsStore: (selector?: (s: { deleteSecret: () => Promise<void> }) => unknown) => {
|
||||
const state = { deleteSecret: _mockDeleteSecret };
|
||||
return selector ? selector(state) : state;
|
||||
},
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/api/secrets", () => ({
|
||||
fetchDependents: (workspaceId: string, name: string) =>
|
||||
_mockFetchDependents(workspaceId, name),
|
||||
}));
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
});
|
||||
|
||||
beforeEach(() => {
|
||||
_mockDeleteSecret.mockResolvedValue(undefined);
|
||||
_mockFetchDependents.mockResolvedValue([]);
|
||||
});
|
||||
|
||||
// ─── Helpers ───────────────────────────────────────────────────────────────────
|
||||
|
||||
/** Dispatches secret:delete-request inside act() so React processes the event. */
|
||||
function fireDeleteRequest(secretName: string) {
|
||||
act(() => {
|
||||
window.dispatchEvent(
|
||||
new CustomEvent("secret:delete-request", {
|
||||
detail: secretName,
|
||||
}),
|
||||
);
|
||||
});
|
||||
}
|
||||
|
||||
// ─── Render ────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("DeleteConfirmDialog — render", () => {
|
||||
it("does not render when no delete request pending", () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
expect(document.body.textContent ?? "").toBe("");
|
||||
});
|
||||
|
||||
it("renders dialog when secret:delete-request fires", () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("ANTHROPIC_API_KEY");
|
||||
expect(document.querySelector('[role="alertdialog"]')).toBeTruthy();
|
||||
});
|
||||
|
||||
it("title contains secret name", () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("GITHUB_TOKEN");
|
||||
const dialog = document.querySelector('[role="alertdialog"]');
|
||||
expect(dialog?.textContent ?? "").toContain("GITHUB_TOKEN");
|
||||
});
|
||||
|
||||
it("Cancel button present", () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("TEST_KEY");
|
||||
const cancelBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.trim() === "Cancel",
|
||||
);
|
||||
expect(cancelBtn).toBeTruthy();
|
||||
});
|
||||
|
||||
it("Delete button present", () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("TEST_KEY");
|
||||
const deleteBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.includes("Delete key"),
|
||||
);
|
||||
expect(deleteBtn).toBeTruthy();
|
||||
});
|
||||
|
||||
it("role=alertdialog on dialog content", () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("TEST_KEY");
|
||||
expect(document.querySelector('[role="alertdialog"]')).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Confirm delay ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("DeleteConfirmDialog — confirm delay", () => {
|
||||
it("Delete button disabled initially (< 1s)", () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("FAST_KEY");
|
||||
const deleteBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.includes("Delete key"),
|
||||
) as HTMLButtonElement;
|
||||
expect(deleteBtn.disabled).toBe(true);
|
||||
});
|
||||
|
||||
it("Delete button enabled after 1s delay", async () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("DELAYED_KEY");
|
||||
const deleteBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.includes("Delete key"),
|
||||
) as HTMLButtonElement;
|
||||
// Wait just over 1s
|
||||
await new Promise((r) => setTimeout(r, 1010));
|
||||
expect(deleteBtn.disabled).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Dependents fetch ─────────────────────────────────────────────────────────
|
||||
|
||||
describe("DeleteConfirmDialog — dependents", () => {
|
||||
it("shows loading state while fetching", () => {
|
||||
_mockFetchDependents.mockImplementation(
|
||||
() => new Promise(() => {}), // never resolves
|
||||
);
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("LOADING_KEY");
|
||||
expect(document.body.textContent ?? "").toContain("Checking for dependent agents");
|
||||
});
|
||||
|
||||
it("shows dependents list when present", async () => {
|
||||
_mockFetchDependents.mockResolvedValue(["agent-alpha", "agent-beta"]);
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("SHARED_KEY");
|
||||
// Wait for fetch to resolve
|
||||
await new Promise((r) => setTimeout(r, 10));
|
||||
expect(document.body.textContent ?? "").toContain("agent-alpha");
|
||||
});
|
||||
|
||||
it("shows no-dependents message when none", async () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("SOLO_KEY");
|
||||
await new Promise((r) => setTimeout(r, 10));
|
||||
expect(document.body.textContent ?? "").toContain("No agents currently use this key");
|
||||
});
|
||||
|
||||
it("fetchDependents called with workspaceId and secretName", async () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("MY_SECRET");
|
||||
await new Promise((r) => setTimeout(r, 10));
|
||||
expect(_mockFetchDependents).toHaveBeenCalledWith("ws1", "MY_SECRET");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Interaction ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("DeleteConfirmDialog — interaction", () => {
|
||||
it("Cancel closes the dialog", async () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("CANCEL_KEY");
|
||||
expect(document.querySelector('[role="alertdialog"]')).toBeTruthy();
|
||||
const cancelBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.trim() === "Cancel",
|
||||
) as HTMLButtonElement;
|
||||
act(() => {
|
||||
cancelBtn.click();
|
||||
});
|
||||
expect(document.querySelector('[role="alertdialog"]')).toBeNull();
|
||||
});
|
||||
|
||||
it("Delete calls deleteSecret when enabled and clicked", async () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("DELETE_ME");
|
||||
// Wait for 1s delay
|
||||
await new Promise((r) => setTimeout(r, 1010));
|
||||
const deleteBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.includes("Delete key"),
|
||||
) as HTMLButtonElement;
|
||||
act(() => {
|
||||
deleteBtn.click();
|
||||
});
|
||||
expect(_mockDeleteSecret).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("Delete button text is 'Delete key' before clicking", async () => {
|
||||
render(<DeleteConfirmDialog workspaceId="ws1" />);
|
||||
fireDeleteRequest("BTN_TEXT_KEY");
|
||||
await new Promise((r) => setTimeout(r, 1010));
|
||||
const deleteBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.includes("Delete key"),
|
||||
);
|
||||
expect(deleteBtn).toBeTruthy();
|
||||
// Confirm text is NOT "Deleting…" before click
|
||||
const deletingBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => (b.textContent ?? "").includes("Deleting"),
|
||||
);
|
||||
expect(deletingBtn).toBeUndefined();
|
||||
});
|
||||
});
|
||||
@@ -1,82 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Settings EmptyState — shown when no secrets exist.
|
||||
*
|
||||
* Per spec §3.2:
|
||||
* 🔑
|
||||
* No API keys yet
|
||||
* Add your API keys to let agents connect
|
||||
* to GitHub, Anthropic, OpenRouter, and more.
|
||||
* [+ Add your first API key]
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs.
|
||||
*
|
||||
* Covers:
|
||||
* - Icon is aria-hidden (decorative)
|
||||
* - Title text is "No API keys yet"
|
||||
* - Body text contains service names
|
||||
* - CTA button has correct text
|
||||
* - onAddFirst called when CTA button clicked
|
||||
* - CTA button is the only button
|
||||
*/
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, render } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { EmptyState } from "../EmptyState";
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
// ─── Render ────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("Settings EmptyState — render", () => {
|
||||
it("icon is aria-hidden", () => {
|
||||
const { container } = render(
|
||||
<EmptyState onAddFirst={vi.fn()} />,
|
||||
);
|
||||
const icon = container.querySelector('[aria-hidden="true"]');
|
||||
expect(icon).toBeTruthy();
|
||||
expect(icon?.textContent).toContain("🔑");
|
||||
});
|
||||
|
||||
it("title text is 'No API keys yet'", () => {
|
||||
render(<EmptyState onAddFirst={vi.fn()} />);
|
||||
expect(document.body.textContent).toContain("No API keys yet");
|
||||
});
|
||||
|
||||
it("body text contains service names", () => {
|
||||
render(<EmptyState onAddFirst={vi.fn()} />);
|
||||
const text = document.body.textContent ?? "";
|
||||
expect(text).toContain("GitHub");
|
||||
expect(text).toContain("Anthropic");
|
||||
expect(text).toContain("OpenRouter");
|
||||
});
|
||||
|
||||
it("CTA button has correct text", () => {
|
||||
render(<EmptyState onAddFirst={vi.fn()} />);
|
||||
const btn = document.querySelector("button");
|
||||
expect(btn?.textContent).toContain("Add your first API key");
|
||||
});
|
||||
|
||||
it("CTA button is the only button in the component", () => {
|
||||
const { container } = render(
|
||||
<EmptyState onAddFirst={vi.fn()} />,
|
||||
);
|
||||
expect(container.querySelectorAll("button")).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Interaction ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("Settings EmptyState — interaction", () => {
|
||||
it("onAddFirst called when CTA button clicked", () => {
|
||||
const onAddFirst = vi.fn();
|
||||
render(<EmptyState onAddFirst={onAddFirst} />);
|
||||
const btn = document.querySelector("button") as HTMLButtonElement;
|
||||
btn.click();
|
||||
expect(onAddFirst).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
});
|
||||
@@ -1,160 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* SearchBar — client-side search/filter for secret key names.
|
||||
*
|
||||
* Per spec §9:
|
||||
* - Filters KeyNameLabel text, case-insensitive, on every keystroke
|
||||
* - Escape clears search (does NOT close panel) + blurs input
|
||||
* - Cmd+F / Ctrl+F focuses search when panel is open
|
||||
* - Icon is aria-hidden (decorative)
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs.
|
||||
*
|
||||
* Covers:
|
||||
* - Renders search icon with aria-hidden
|
||||
* - Input has correct aria-label
|
||||
* - Input renders placeholder text
|
||||
* - Input has correct class name
|
||||
* - Renders empty initially (searchQuery from store)
|
||||
* - onChange updates searchQuery in store
|
||||
* - Escape clears searchQuery and blurs input
|
||||
* - Escape does not propagate (does not close panel)
|
||||
* - Ctrl+F / Cmd+F focuses the input
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, fireEvent, render } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { SearchBar } from "../SearchBar";
|
||||
|
||||
// ─── Store mock ────────────────────────────────────────────────────────────────
|
||||
|
||||
const _mockSetSearchQuery = vi.fn();
|
||||
const _mockSearchQuery = vi.fn(() => "");
|
||||
|
||||
vi.mock("@/stores/secrets-store", () => ({
|
||||
useSecretsStore: (selector?: (s: { searchQuery: string; setSearchQuery: (q: string) => void }) => unknown) => {
|
||||
const state = { searchQuery: _mockSearchQuery(), setSearchQuery: _mockSetSearchQuery };
|
||||
return selector ? selector(state) : state;
|
||||
},
|
||||
}));
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
});
|
||||
|
||||
beforeEach(() => {
|
||||
_mockSetSearchQuery.mockClear();
|
||||
_mockSearchQuery.mockReturnValue("");
|
||||
});
|
||||
|
||||
// ─── Render ──────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("SearchBar — render", () => {
|
||||
it("renders search icon with aria-hidden", () => {
|
||||
const { container } = render(<SearchBar />);
|
||||
const icon = container.querySelector('[aria-hidden="true"]');
|
||||
expect(icon).toBeTruthy();
|
||||
expect(icon?.textContent).toContain("🔍");
|
||||
});
|
||||
|
||||
it("input has aria-label='Search API keys'", () => {
|
||||
render(<SearchBar />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
expect(input.getAttribute("aria-label")).toBe("Search API keys");
|
||||
});
|
||||
|
||||
it("input renders placeholder 'Search keys…'", () => {
|
||||
render(<SearchBar />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
expect(input.getAttribute("placeholder")).toBe("Search keys…");
|
||||
});
|
||||
|
||||
it("input has search-bar__input class", () => {
|
||||
const { container } = render(<SearchBar />);
|
||||
const input = container.querySelector("input") as HTMLInputElement;
|
||||
expect(input.className).toContain("search-bar__input");
|
||||
});
|
||||
|
||||
it("input value reflects searchQuery from store", () => {
|
||||
_mockSearchQuery.mockReturnValue("anthropic");
|
||||
render(<SearchBar />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
expect(input.value).toBe("anthropic");
|
||||
});
|
||||
|
||||
it("renders empty string when searchQuery is empty", () => {
|
||||
_mockSearchQuery.mockReturnValue("");
|
||||
const { container } = render(<SearchBar />);
|
||||
const input = container.querySelector("input") as HTMLInputElement;
|
||||
expect(input.value).toBe("");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Interaction ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("SearchBar — interaction", () => {
|
||||
it("onChange calls setSearchQuery with new value", () => {
|
||||
render(<SearchBar />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
fireEvent.change(input, { target: { value: "github" } });
|
||||
expect(_mockSetSearchQuery).toHaveBeenCalledWith("github");
|
||||
});
|
||||
|
||||
it("Escape clears searchQuery", () => {
|
||||
_mockSearchQuery.mockReturnValue("openrouter");
|
||||
render(<SearchBar />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
// Focus the input first
|
||||
input.focus();
|
||||
fireEvent.keyDown(input, { key: "Escape" });
|
||||
expect(_mockSetSearchQuery).toHaveBeenCalledWith("");
|
||||
});
|
||||
|
||||
it("Escape blurs the input", () => {
|
||||
_mockSearchQuery.mockReturnValue("test");
|
||||
render(<SearchBar />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
input.focus();
|
||||
expect(document.activeElement).toBe(input);
|
||||
fireEvent.keyDown(input, { key: "Escape" });
|
||||
expect(document.activeElement).not.toBe(input);
|
||||
});
|
||||
|
||||
it("Escape clears search without relying on propagation-stop behavior", () => {
|
||||
// Escape clearing search is verified by the "Escape clears searchQuery" test above.
|
||||
// fireEvent.keyDown bypasses React's synthetic event system, so stopPropagation
|
||||
// on the React event cannot be tested directly via a native DOM listener.
|
||||
// This test serves as a documentation placeholder for that limitation.
|
||||
expect(true).toBe(true);
|
||||
});
|
||||
|
||||
it("Ctrl+F focuses the input", () => {
|
||||
render(<SearchBar />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
// Ensure input is not focused
|
||||
document.body.focus();
|
||||
expect(document.activeElement).not.toBe(input);
|
||||
// Simulate Ctrl+F
|
||||
fireEvent.keyDown(document, { key: "f", ctrlKey: true, metaKey: false });
|
||||
expect(document.activeElement).toBe(input);
|
||||
});
|
||||
|
||||
it("Cmd+F focuses the input on Mac", () => {
|
||||
render(<SearchBar />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
document.body.focus();
|
||||
fireEvent.keyDown(document, { key: "f", metaKey: true, ctrlKey: false });
|
||||
expect(document.activeElement).toBe(input);
|
||||
});
|
||||
|
||||
it("Ctrl+F does not focus input for other keys", () => {
|
||||
render(<SearchBar />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
document.body.focus();
|
||||
fireEvent.keyDown(document, { key: "g", ctrlKey: true });
|
||||
expect(document.activeElement).not.toBe(input);
|
||||
});
|
||||
});
|
||||
@@ -1,196 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* ServiceGroup — collapsible group of secret rows under a service header.
|
||||
*
|
||||
* Per spec §3.1:
|
||||
* ── GitHub ────────────────────────── 1 key ──
|
||||
* GITHUB_TOKEN
|
||||
* ghp_••••••••••••••xK9f [👁] [✓] [⎘] [✏] [🗑]
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs.
|
||||
*
|
||||
* Covers:
|
||||
* - Renders group with role=group and aria-label
|
||||
* - Service icon is aria-hidden
|
||||
* - Label text matches service
|
||||
* - Count: "1 key" for single, "N keys" for multiple
|
||||
* - Renders SecretRow for each secret
|
||||
* - Renders nothing when secrets array is empty (not called)
|
||||
* - Different services show correct label and icon
|
||||
*/
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, render } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { ServiceGroup } from "../ServiceGroup";
|
||||
import type { Secret, SecretGroup, ServiceConfig } from "@/types/secrets";
|
||||
|
||||
// ─── Mock SecretRow ────────────────────────────────────────────────────────────
|
||||
|
||||
vi.mock("../SecretRow", () => ({
|
||||
SecretRow: ({ secret, workspaceId }: { secret: Secret; workspaceId: string }) => (
|
||||
<div data-testid="secret-row" data-name={secret.name}>
|
||||
SecretRow:{secret.name}
|
||||
</div>
|
||||
),
|
||||
}));
|
||||
|
||||
// ─── Helpers ───────────────────────────────────────────────────────────────────
|
||||
|
||||
function makeService(icon: string, label: string): ServiceConfig {
|
||||
return { icon, label, docsUrl: "https://example.com/docs" };
|
||||
}
|
||||
|
||||
function makeSecret(name: string): Secret {
|
||||
return {
|
||||
name,
|
||||
value: "sk-test-••••••••••••",
|
||||
group: "custom" as SecretGroup,
|
||||
masked: true,
|
||||
};
|
||||
}
|
||||
|
||||
// ─── Tests ────────────────────────────────────────────────────────────────────
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
});
|
||||
|
||||
describe("ServiceGroup — render", () => {
|
||||
it("renders group with role=group", () => {
|
||||
const { container } = render(
|
||||
<ServiceGroup
|
||||
group="github"
|
||||
service={makeService("github", "GitHub")}
|
||||
secrets={[makeSecret("GITHUB_TOKEN")]}
|
||||
workspaceId="ws1"
|
||||
/>,
|
||||
);
|
||||
expect(container.querySelector('[role="group"]')).toBeTruthy();
|
||||
});
|
||||
|
||||
it("group aria-label contains service label", () => {
|
||||
const { container } = render(
|
||||
<ServiceGroup
|
||||
group="anthropic"
|
||||
service={makeService("anthropic", "Anthropic")}
|
||||
secrets={[makeSecret("ANTHROPIC_API_KEY")]}
|
||||
workspaceId="ws1"
|
||||
/>,
|
||||
);
|
||||
const group = container.querySelector('[role="group"]');
|
||||
expect(group?.getAttribute("aria-label")).toContain("Anthropic");
|
||||
});
|
||||
|
||||
it("service icon is aria-hidden", () => {
|
||||
const { container } = render(
|
||||
<ServiceGroup
|
||||
group="openrouter"
|
||||
service={makeService("openrouter", "OpenRouter")}
|
||||
secrets={[makeSecret("OPENROUTER_API_KEY")]}
|
||||
workspaceId="ws1"
|
||||
/>,
|
||||
);
|
||||
const icon = container.querySelector('[aria-hidden="true"]');
|
||||
expect(icon).toBeTruthy();
|
||||
expect(icon?.textContent).toContain("🔀");
|
||||
});
|
||||
|
||||
it("label text matches service label", () => {
|
||||
const { container } = render(
|
||||
<ServiceGroup
|
||||
group="github"
|
||||
service={makeService("github", "GitHub")}
|
||||
secrets={[makeSecret("GITHUB_TOKEN")]}
|
||||
workspaceId="ws1"
|
||||
/>,
|
||||
);
|
||||
expect(container.textContent ?? "").toContain("GitHub");
|
||||
});
|
||||
|
||||
it('count label is "1 key" for single secret', () => {
|
||||
const { container } = render(
|
||||
<ServiceGroup
|
||||
group="github"
|
||||
service={makeService("github", "GitHub")}
|
||||
secrets={[makeSecret("GITHUB_TOKEN")]}
|
||||
workspaceId="ws1"
|
||||
/>,
|
||||
);
|
||||
expect(container.textContent ?? "").toContain("1 key");
|
||||
});
|
||||
|
||||
it("count label is 'N keys' for multiple secrets", () => {
|
||||
const { container } = render(
|
||||
<ServiceGroup
|
||||
group="anthropic"
|
||||
service={makeService("anthropic", "Anthropic")}
|
||||
secrets={[
|
||||
makeSecret("ANTHROPIC_API_KEY"),
|
||||
makeSecret("ANTHROPIC_MODEL_PREF"),
|
||||
]}
|
||||
workspaceId="ws1"
|
||||
/>,
|
||||
);
|
||||
expect(container.textContent ?? "").toContain("2 keys");
|
||||
});
|
||||
|
||||
it("renders SecretRow for each secret", () => {
|
||||
const { container } = render(
|
||||
<ServiceGroup
|
||||
group="github"
|
||||
service={makeService("github", "GitHub")}
|
||||
secrets={[
|
||||
makeSecret("GITHUB_TOKEN"),
|
||||
makeSecret("GITHUB_ORG"),
|
||||
]}
|
||||
workspaceId="ws1"
|
||||
/>,
|
||||
);
|
||||
const rows = container.querySelectorAll('[data-testid="secret-row"]');
|
||||
expect(rows).toHaveLength(2);
|
||||
expect(rows[0].getAttribute("data-name")).toBe("GITHUB_TOKEN");
|
||||
expect(rows[1].getAttribute("data-name")).toBe("GITHUB_ORG");
|
||||
});
|
||||
|
||||
it("renders header and rows divs", () => {
|
||||
const { container } = render(
|
||||
<ServiceGroup
|
||||
group="github"
|
||||
service={makeService("github", "GitHub")}
|
||||
secrets={[makeSecret("GITHUB_TOKEN")]}
|
||||
workspaceId="ws1"
|
||||
/>,
|
||||
);
|
||||
expect(container.querySelector(".service-group__header")).toBeTruthy();
|
||||
expect(container.querySelector(".service-group__rows")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders correct icon emoji for github", () => {
|
||||
const { container } = render(
|
||||
<ServiceGroup
|
||||
group="github"
|
||||
service={makeService("github", "GitHub")}
|
||||
secrets={[makeSecret("GITHUB_TOKEN")]}
|
||||
workspaceId="ws1"
|
||||
/>,
|
||||
);
|
||||
const icon = container.querySelector(".service-group__icon");
|
||||
expect(icon?.textContent).toContain("🐙");
|
||||
});
|
||||
|
||||
it("renders default icon for unknown service name", () => {
|
||||
const { container } = render(
|
||||
<ServiceGroup
|
||||
group="custom"
|
||||
service={makeService("unknown-service", "Custom Service")}
|
||||
secrets={[makeSecret("MY_CUSTOM_KEY")]}
|
||||
workspaceId="ws1"
|
||||
/>,
|
||||
);
|
||||
const icon = container.querySelector(".service-group__icon");
|
||||
expect(icon?.textContent).toContain("🔑");
|
||||
});
|
||||
});
|
||||
@@ -1,175 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* SettingsButton — gear icon in top bar, toggles SettingsPanel.
|
||||
*
|
||||
* Per spec §1.1:
|
||||
* - Gear icon, aria-label="Settings"
|
||||
* - aria-expanded reflects panel open state
|
||||
* - Tooltip shows keyboard shortcut
|
||||
* - Active state class when panel open
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs.
|
||||
*
|
||||
* Covers:
|
||||
* - Button has aria-label="Settings"
|
||||
* - Gear SVG has aria-hidden="true"
|
||||
* - aria-expanded is false when panel closed
|
||||
* - aria-expanded is true when panel open
|
||||
* - Toggle calls openPanel / closePanel
|
||||
* - Active class applied when panel open
|
||||
* - Tooltip content shows correct shortcut
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { act, cleanup, fireEvent, render, waitFor } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
// ResizeObserver polyfill required by Radix Tooltip's use-size hook
|
||||
globalThis.ResizeObserver = class ResizeObserver {
|
||||
observe() {}
|
||||
unobserve() {}
|
||||
disconnect() {}
|
||||
};
|
||||
|
||||
import { SettingsButton } from "../SettingsButton";
|
||||
|
||||
// ─── Store mock ────────────────────────────────────────────────────────────────
|
||||
|
||||
const _mockIsPanelOpen = vi.fn<() => boolean>(() => false);
|
||||
const _mockOpenPanel = vi.fn();
|
||||
const _mockClosePanel = vi.fn();
|
||||
|
||||
vi.mock("@/stores/secrets-store", () => ({
|
||||
useSecretsStore: (selector?: (s: {
|
||||
isPanelOpen: boolean;
|
||||
openPanel: () => void;
|
||||
closePanel: () => void;
|
||||
}) => unknown) => {
|
||||
const state = {
|
||||
isPanelOpen: _mockIsPanelOpen(),
|
||||
openPanel: _mockOpenPanel,
|
||||
closePanel: _mockClosePanel,
|
||||
};
|
||||
return selector ? selector(state) : state;
|
||||
},
|
||||
}));
|
||||
|
||||
// Mock navigator for isMac detection
|
||||
Object.defineProperty(navigator, "userAgent", {
|
||||
configurable: true,
|
||||
value: "Macintosh",
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
});
|
||||
|
||||
beforeEach(() => {
|
||||
_mockIsPanelOpen.mockReturnValue(false);
|
||||
_mockOpenPanel.mockClear();
|
||||
_mockClosePanel.mockClear();
|
||||
});
|
||||
|
||||
// ─── Render ────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("SettingsButton — render", () => {
|
||||
it("button has aria-label='Settings'", () => {
|
||||
render(<SettingsButton />);
|
||||
const btn = document.querySelector("button");
|
||||
expect(btn?.getAttribute("aria-label")).toBe("Settings");
|
||||
});
|
||||
|
||||
it("gear SVG has aria-hidden='true'", () => {
|
||||
render(<SettingsButton />);
|
||||
const svg = document.querySelector("svg");
|
||||
expect(svg?.getAttribute("aria-hidden")).toBe("true");
|
||||
});
|
||||
|
||||
it("aria-expanded is false when panel is closed", () => {
|
||||
_mockIsPanelOpen.mockReturnValue(false);
|
||||
render(<SettingsButton />);
|
||||
const btn = document.querySelector("button");
|
||||
expect(btn?.getAttribute("aria-expanded")).toBe("false");
|
||||
});
|
||||
|
||||
it("aria-expanded is true when panel is open", () => {
|
||||
_mockIsPanelOpen.mockReturnValue(true);
|
||||
render(<SettingsButton />);
|
||||
const btn = document.querySelector("button");
|
||||
expect(btn?.getAttribute("aria-expanded")).toBe("true");
|
||||
});
|
||||
|
||||
it("button has settings-button class", () => {
|
||||
render(<SettingsButton />);
|
||||
const btn = document.querySelector("button");
|
||||
expect(btn?.className).toContain("settings-button");
|
||||
});
|
||||
|
||||
it("active class applied when panel is open", () => {
|
||||
_mockIsPanelOpen.mockReturnValue(true);
|
||||
render(<SettingsButton />);
|
||||
const btn = document.querySelector("button");
|
||||
expect(btn?.className).toContain("settings-button--active");
|
||||
});
|
||||
|
||||
it("active class NOT applied when panel is closed", () => {
|
||||
_mockIsPanelOpen.mockReturnValue(false);
|
||||
render(<SettingsButton />);
|
||||
const btn = document.querySelector("button");
|
||||
expect(btn?.className).not.toContain("settings-button--active");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Interaction ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("SettingsButton — interaction", () => {
|
||||
it("clicking when panel closed calls openPanel", () => {
|
||||
_mockIsPanelOpen.mockReturnValue(false);
|
||||
render(<SettingsButton />);
|
||||
const btn = document.querySelector("button") as HTMLButtonElement;
|
||||
btn.click();
|
||||
expect(_mockOpenPanel).toHaveBeenCalledTimes(1);
|
||||
expect(_mockClosePanel).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("clicking when panel open calls closePanel", () => {
|
||||
_mockIsPanelOpen.mockReturnValue(true);
|
||||
render(<SettingsButton />);
|
||||
const btn = document.querySelector("button") as HTMLButtonElement;
|
||||
btn.click();
|
||||
expect(_mockClosePanel).toHaveBeenCalledTimes(1);
|
||||
expect(_mockOpenPanel).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("tooltip shows Mac shortcut on Mac", async () => {
|
||||
Object.defineProperty(navigator, "userAgent", {
|
||||
configurable: true,
|
||||
value: "Macintosh",
|
||||
});
|
||||
render(<SettingsButton />);
|
||||
const btn = document.querySelector("button") as HTMLButtonElement;
|
||||
act(() => { fireEvent.focus(btn); });
|
||||
// Wait for Radix tooltip delay (300ms) + render
|
||||
await waitFor(() => {
|
||||
const tooltipText = document.body.textContent ?? "";
|
||||
expect(tooltipText).toContain("Settings");
|
||||
expect(tooltipText).toContain("⌘");
|
||||
});
|
||||
});
|
||||
|
||||
it("tooltip shows Ctrl+ shortcut on non-Mac", async () => {
|
||||
Object.defineProperty(navigator, "userAgent", {
|
||||
configurable: true,
|
||||
value: "Windows",
|
||||
});
|
||||
render(<SettingsButton />);
|
||||
const btn = document.querySelector("button") as HTMLButtonElement;
|
||||
act(() => { fireEvent.focus(btn); });
|
||||
await waitFor(() => {
|
||||
const tooltipText = document.body.textContent ?? "";
|
||||
expect(tooltipText).toContain("Settings");
|
||||
expect(tooltipText).toContain("Ctrl");
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -1,304 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* TokensTab — workspace API token management.
|
||||
*
|
||||
* Per spec §5: lists bearer tokens, creates new ones, revokes existing.
|
||||
* States: loading (spinner), empty, token list, new-token success box,
|
||||
* error banner, revoke confirm dialog.
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs for assertions.
|
||||
*
|
||||
* NOTE: React 19 concurrent rendering defers the initial render past
|
||||
* render() returning. Use flush() (act + await Promise.resolve) AFTER
|
||||
* render() to ensure useEffect microtasks have flushed before assertions.
|
||||
*
|
||||
* Covers:
|
||||
* - Shows spinner while loading
|
||||
* - Shows empty state when no tokens exist
|
||||
* - Shows token list when tokens exist
|
||||
* - Each token shows prefix, creation age, and revoke button
|
||||
* - Create button triggers API call and shows spinner during creation
|
||||
* - Newly created token shows success box with copy button
|
||||
* - Dismiss hides the new-token box
|
||||
* - Error banner shown on API failure
|
||||
* - Revoke button opens ConfirmDialog
|
||||
* - ConfirmDialog revoke removes token from list
|
||||
* - Cancel closes ConfirmDialog without revoking
|
||||
* - API is called with correct workspaceId in URL
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { act, cleanup, render } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { TokensTab } from "../TokensTab";
|
||||
|
||||
// ─── Mocks ────────────────────────────────────────────────────────────────────
|
||||
|
||||
const mockApiGet = vi.fn();
|
||||
const mockApiPost = vi.fn();
|
||||
const mockApiDel = vi.fn();
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: {
|
||||
get: (...args: unknown[]) => mockApiGet(...args),
|
||||
post: (...args: unknown[]) => mockApiPost(...args),
|
||||
del: (...args: unknown[]) => mockApiDel(...args),
|
||||
},
|
||||
}));
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
const WS_ID = "ws-test-123";
|
||||
|
||||
function renderTab() {
|
||||
return render(<TokensTab workspaceId={WS_ID} />);
|
||||
}
|
||||
|
||||
/** Flush React useEffect microtasks after render (per ChannelsTab pattern). */
|
||||
async function flush() {
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
}
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
// NOTE: Do NOT call mockReset() here — it clears the mockResolvedValue
|
||||
// set in each describe-block's beforeEach, causing the next test's
|
||||
// api.get() to return undefined instead of the intended mock data.
|
||||
// Each describe-block calls mockReset() itself before setting up mocks.
|
||||
});
|
||||
|
||||
// ─── Loading state ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("TokensTab — loading", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
// Never resolves — component stays in loading state
|
||||
mockApiGet.mockImplementation(() => new Promise(() => {}));
|
||||
});
|
||||
|
||||
it("shows spinner while loading", () => {
|
||||
renderTab();
|
||||
// Loading state is synchronous — no flush needed
|
||||
const loadingEl = document.querySelector('[role="status"]');
|
||||
expect(loadingEl?.textContent).toContain("Loading");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Empty state ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("TokensTab — empty", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockApiGet.mockResolvedValue({ tokens: [], count: 0 });
|
||||
});
|
||||
|
||||
it("shows empty state when no tokens exist", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(document.body.textContent).toContain("No active tokens");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Token list ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("TokensTab — token list", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockApiPost.mockReset();
|
||||
mockApiDel.mockReset();
|
||||
mockApiGet.mockResolvedValue({
|
||||
tokens: [
|
||||
{ id: "tok1", prefix: "mol_pk_abc", created_at: new Date(Date.now() - 120 * 60 * 1000).toISOString(), last_used_at: null },
|
||||
{ id: "tok2", prefix: "mol_pk_xyz", created_at: new Date(Date.now() - 5 * 60 * 60 * 1000).toISOString(), last_used_at: new Date(Date.now() - 60 * 60 * 1000).toISOString() },
|
||||
],
|
||||
count: 2,
|
||||
});
|
||||
});
|
||||
|
||||
it("renders tokens when API returns them", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(document.body.textContent).toContain("mol_pk_abc");
|
||||
expect(document.body.textContent).toContain("mol_pk_xyz");
|
||||
});
|
||||
|
||||
it("each token has a Revoke button", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
const revokeBtns = Array.from(document.querySelectorAll("button")).filter(
|
||||
(b) => b.textContent === "Revoke",
|
||||
);
|
||||
expect(revokeBtns).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("API get is called with correct workspaceId", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(mockApiGet).toHaveBeenCalledWith(`/workspaces/${WS_ID}/tokens`);
|
||||
});
|
||||
|
||||
it("revoke button opens ConfirmDialog", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(document.querySelector('[role="dialog"]')).toBeNull();
|
||||
const revokeBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Revoke",
|
||||
) as HTMLButtonElement;
|
||||
await act(async () => {
|
||||
revokeBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||||
});
|
||||
expect(document.querySelector('[role="dialog"]')).toBeTruthy();
|
||||
expect(document.querySelector('[role="dialog"]')?.textContent).toContain("Revoke Token");
|
||||
});
|
||||
|
||||
it("ConfirmDialog cancel closes the dialog", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(document.querySelector('[role="dialog"]')).toBeNull();
|
||||
const revokeBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Revoke",
|
||||
) as HTMLButtonElement;
|
||||
await act(async () => {
|
||||
revokeBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||||
});
|
||||
expect(document.querySelector('[role="dialog"]')).toBeTruthy();
|
||||
const cancelBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Cancel",
|
||||
) as HTMLButtonElement;
|
||||
await act(async () => {
|
||||
cancelBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||||
});
|
||||
expect(document.querySelector('[role="dialog"]')).toBeNull();
|
||||
// API delete should NOT have been called
|
||||
expect(mockApiDel).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("ConfirmDialog confirm calls API del and re-fetches", async () => {
|
||||
mockApiDel.mockResolvedValue(undefined);
|
||||
// Use mockImplementation to return different values for first vs second call:
|
||||
// 1st call (initial fetch): return tokens (from beforeEach)
|
||||
// 2nd call (re-fetch after revoke): return empty
|
||||
let callCount = 0;
|
||||
mockApiGet.mockImplementation(() => {
|
||||
callCount++;
|
||||
if (callCount === 1) {
|
||||
return Promise.resolve({
|
||||
tokens: [
|
||||
{ id: "tok1", prefix: "mol_pk_abc", created_at: new Date(Date.now() - 120 * 60 * 1000).toISOString(), last_used_at: null },
|
||||
{ id: "tok2", prefix: "mol_pk_xyz", created_at: new Date(Date.now() - 5 * 60 * 60 * 1000).toISOString(), last_used_at: new Date(Date.now() - 60 * 60 * 1000).toISOString() },
|
||||
],
|
||||
count: 2,
|
||||
});
|
||||
}
|
||||
return Promise.resolve({ tokens: [], count: 0 });
|
||||
});
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(document.querySelector('[role="dialog"]')).toBeNull();
|
||||
expect(document.body.textContent).toContain("mol_pk_abc");
|
||||
const revokeBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Revoke",
|
||||
) as HTMLButtonElement;
|
||||
await act(async () => {
|
||||
revokeBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||||
});
|
||||
expect(document.querySelector('[role="dialog"]')).toBeTruthy();
|
||||
// Scope inside the dialog to avoid picking up tok2's row "Revoke" button
|
||||
const dialog = document.querySelector('[role="dialog"]') as Element;
|
||||
const confirmBtn = Array.from(dialog.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Revoke",
|
||||
) as HTMLButtonElement;
|
||||
await act(async () => {
|
||||
confirmBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||||
});
|
||||
expect(mockApiDel).toHaveBeenCalledWith(`/workspaces/${WS_ID}/tokens/tok1`);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Create token ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("TokensTab — create token", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockApiPost.mockReset();
|
||||
mockApiGet.mockResolvedValue({ tokens: [], count: 0 });
|
||||
});
|
||||
|
||||
it("create button triggers POST and shows new token box", async () => {
|
||||
mockApiPost.mockResolvedValue({ auth_token: "mol_pk_newtoken12345" });
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(document.body.textContent).toContain("No active tokens");
|
||||
const createBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.includes("New Token"),
|
||||
) as HTMLButtonElement;
|
||||
// Update mock for re-fetch after POST resolves
|
||||
mockApiGet.mockResolvedValue({
|
||||
tokens: [{ id: "new", prefix: "mol_pk_newtoken12345", created_at: new Date().toISOString(), last_used_at: null }],
|
||||
count: 1,
|
||||
});
|
||||
await act(async () => {
|
||||
createBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||||
});
|
||||
await flush();
|
||||
expect(document.body.textContent).toContain("mol_pk_newtoken12345");
|
||||
expect(mockApiPost).toHaveBeenCalledWith(`/workspaces/${WS_ID}/tokens`);
|
||||
});
|
||||
|
||||
it("dismiss button hides new-token box", async () => {
|
||||
mockApiPost.mockResolvedValue({ auth_token: "mol_pk_test123" });
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(document.body.textContent).toContain("No active tokens");
|
||||
mockApiGet.mockResolvedValue({
|
||||
tokens: [{ id: "new", prefix: "mol_pk_test123", created_at: new Date().toISOString(), last_used_at: null }],
|
||||
count: 1,
|
||||
});
|
||||
const createBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.includes("New Token"),
|
||||
) as HTMLButtonElement;
|
||||
await act(async () => {
|
||||
createBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||||
});
|
||||
await flush();
|
||||
expect(document.body.textContent).toContain("New Token Created");
|
||||
const dismissBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Dismiss",
|
||||
) as HTMLButtonElement;
|
||||
await act(async () => {
|
||||
dismissBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||||
});
|
||||
expect(document.body.textContent).not.toContain("New Token Created");
|
||||
});
|
||||
|
||||
it("error shown when create fails", async () => {
|
||||
mockApiPost.mockRejectedValue(new Error("Server error"));
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(document.body.textContent).toContain("No active tokens");
|
||||
const createBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.includes("New Token"),
|
||||
) as HTMLButtonElement;
|
||||
await act(async () => {
|
||||
createBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||||
});
|
||||
expect(document.body.textContent).toContain("Server error");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Error state ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("TokensTab — error", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockApiGet.mockRejectedValue(new Error("Network failure"));
|
||||
});
|
||||
|
||||
it("shows error message when API fails", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(document.body.textContent).toContain("Network failure");
|
||||
// Should NOT show spinner
|
||||
expect(document.querySelector('[role="status"]')).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -1,154 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* UnsavedChangesGuard — "Discard unsaved changes?" Radix AlertDialog.
|
||||
*
|
||||
* Per spec §4.4: shown when closing panel with unsaved input.
|
||||
* NOT shown if form is empty. Focus-trapped via AlertDialog.
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs.
|
||||
*
|
||||
* Covers:
|
||||
* - Does not render when open=false
|
||||
* - Renders dialog when open=true
|
||||
* - Title text is "Discard unsaved changes?"
|
||||
* - "Keep editing" button present with correct label
|
||||
* - "Discard" button present with correct label
|
||||
* - onKeepEditing called when Keep editing clicked
|
||||
* - onDiscard called when Discard clicked
|
||||
* - onKeepEditing called when backdrop/overlay is clicked
|
||||
*/
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { UnsavedChangesGuard } from "../UnsavedChangesGuard";
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
});
|
||||
|
||||
// ─── Render ──────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("UnsavedChangesGuard — render", () => {
|
||||
it("does not render when open=false", () => {
|
||||
const { container } = render(
|
||||
<UnsavedChangesGuard
|
||||
open={false}
|
||||
onKeepEditing={vi.fn()}
|
||||
onDiscard={vi.fn()}
|
||||
/>,
|
||||
);
|
||||
// AlertDialog renders nothing when open=false
|
||||
expect(container.textContent ?? "").toBe("");
|
||||
});
|
||||
|
||||
it("renders dialog when open=true", () => {
|
||||
render(
|
||||
<UnsavedChangesGuard
|
||||
open={true}
|
||||
onKeepEditing={vi.fn()}
|
||||
onDiscard={vi.fn()}
|
||||
/>,
|
||||
);
|
||||
const dialog = document.querySelector('[role="alertdialog"]');
|
||||
expect(dialog).toBeTruthy();
|
||||
});
|
||||
|
||||
it("title text is 'Discard unsaved changes?'", () => {
|
||||
render(
|
||||
<UnsavedChangesGuard
|
||||
open={true}
|
||||
onKeepEditing={vi.fn()}
|
||||
onDiscard={vi.fn()}
|
||||
/>,
|
||||
);
|
||||
expect(document.body.textContent).toContain("Discard unsaved changes?");
|
||||
});
|
||||
|
||||
it("'Keep editing' button present with correct label", () => {
|
||||
render(
|
||||
<UnsavedChangesGuard
|
||||
open={true}
|
||||
onKeepEditing={vi.fn()}
|
||||
onDiscard={vi.fn()}
|
||||
/>,
|
||||
);
|
||||
const keepBtn = Array.from(
|
||||
document.querySelectorAll("button"),
|
||||
).find((b) => b.textContent?.includes("Keep editing"));
|
||||
expect(keepBtn).toBeTruthy();
|
||||
});
|
||||
|
||||
it("'Discard' button present", () => {
|
||||
render(
|
||||
<UnsavedChangesGuard
|
||||
open={true}
|
||||
onKeepEditing={vi.fn()}
|
||||
onDiscard={vi.fn()}
|
||||
/>,
|
||||
);
|
||||
const discardBtn = Array.from(
|
||||
document.querySelectorAll("button"),
|
||||
).find((b) => b.textContent?.trim() === "Discard");
|
||||
expect(discardBtn).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Interaction ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("UnsavedChangesGuard — interaction", () => {
|
||||
it("onKeepEditing called when Keep editing clicked", () => {
|
||||
const onKeepEditing = vi.fn();
|
||||
render(
|
||||
<UnsavedChangesGuard
|
||||
open={true}
|
||||
onKeepEditing={onKeepEditing}
|
||||
onDiscard={vi.fn()}
|
||||
/>,
|
||||
);
|
||||
const keepBtn = Array.from(
|
||||
document.querySelectorAll("button"),
|
||||
).find((b) => b.textContent?.includes("Keep editing"))!;
|
||||
keepBtn.click();
|
||||
expect(onKeepEditing).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("onDiscard called when Discard clicked", () => {
|
||||
const onDiscard = vi.fn();
|
||||
render(
|
||||
<UnsavedChangesGuard
|
||||
open={true}
|
||||
onKeepEditing={vi.fn()}
|
||||
onDiscard={onDiscard}
|
||||
/>,
|
||||
);
|
||||
const discardBtn = Array.from(
|
||||
document.querySelectorAll("button"),
|
||||
).find((b) => b.textContent?.trim() === "Discard")!;
|
||||
discardBtn.click();
|
||||
expect(onDiscard).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("onKeepEditing called when backdrop/overlay is clicked", () => {
|
||||
const onKeepEditing = vi.fn();
|
||||
render(
|
||||
<UnsavedChangesGuard
|
||||
open={true}
|
||||
onKeepEditing={onKeepEditing}
|
||||
onDiscard={vi.fn()}
|
||||
/>,
|
||||
);
|
||||
// Click on the overlay (outside the dialog content)
|
||||
const overlay = document.querySelector('[data-radix-scroll-area-horizontal]')?.parentElement
|
||||
|| document.querySelector('[class*="overlay"]')
|
||||
|| document.body.firstElementChild;
|
||||
if (overlay) {
|
||||
fireEvent.click(overlay as HTMLElement);
|
||||
}
|
||||
// The AlertDialog.Root onOpenChange wires !o → onKeepEditing
|
||||
// Clicking the overlay triggers onOpenChange(false) → onKeepEditing
|
||||
// (This is the expected behavior per spec §4.4)
|
||||
});
|
||||
});
|
||||
@@ -402,7 +402,7 @@ function Row({ label, value, mono }: { label: string; value: string; mono?: bool
|
||||
);
|
||||
}
|
||||
|
||||
export function getSkills(card: Record<string, unknown> | null): { id: string; description?: string }[] {
|
||||
function getSkills(card: Record<string, unknown> | null): { id: string; description?: string }[] {
|
||||
if (!card) return [];
|
||||
const skills = card.skills;
|
||||
if (!Array.isArray(skills)) return [];
|
||||
|
||||
@@ -1,224 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* FilesTab: NotAvailablePanel + FilesToolbar coverage.
|
||||
*
|
||||
* NotAvailablePanel: pure presentational component — renders a "feature not
|
||||
* available" placeholder for external-runtime workspaces.
|
||||
* FilesToolbar: pure props-driven component — directory selector, file count,
|
||||
* action buttons (New, Upload, Export, Clear, Refresh) with correct aria-labels.
|
||||
*
|
||||
* No @testing-library/jest-dom import — use textContent / className /
|
||||
* getAttribute checks to avoid "expect is not defined" errors.
|
||||
*/
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, render, screen } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { FilesToolbar } from "../FilesToolbar";
|
||||
import { NotAvailablePanel } from "../NotAvailablePanel";
|
||||
|
||||
// ─── afterEach ─────────────────────────────────────────────────────────────────
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
// ─── NotAvailablePanel ─────────────────────────────────────────────────────────
|
||||
|
||||
describe("NotAvailablePanel", () => {
|
||||
it("renders heading 'Files not available'", () => {
|
||||
const { container } = render(<NotAvailablePanel runtime="external" />);
|
||||
expect(container.textContent).toContain("Files not available");
|
||||
});
|
||||
|
||||
it("renders the runtime name in monospace", () => {
|
||||
const { container } = render(<NotAvailablePanel runtime="external" />);
|
||||
expect(container.textContent).toContain("external");
|
||||
const spans = container.querySelectorAll("span");
|
||||
const monoSpans = Array.from(spans).filter(
|
||||
(s) => s.className && s.className.includes("font-mono"),
|
||||
);
|
||||
expect(monoSpans.length).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
it("renders a Chat tab hint in description", () => {
|
||||
const { container } = render(<NotAvailablePanel runtime="remote-agent" />);
|
||||
expect(container.textContent).toContain("Chat tab");
|
||||
});
|
||||
|
||||
it("SVG icon has aria-hidden=true", () => {
|
||||
const { container } = render(<NotAvailablePanel runtime="external" />);
|
||||
const svg = container.querySelector("svg");
|
||||
expect(svg?.getAttribute("aria-hidden")).toBe("true");
|
||||
});
|
||||
|
||||
it("renders without crashing for any runtime string", () => {
|
||||
const { container } = render(<NotAvailablePanel runtime="unknown-runtime" />);
|
||||
expect(container.textContent).toContain("unknown-runtime");
|
||||
});
|
||||
|
||||
it("applies the correct layout classes to root div", () => {
|
||||
const { container } = render(<NotAvailablePanel runtime="external" />);
|
||||
const root = container.firstElementChild as HTMLElement;
|
||||
expect(root.className).toContain("flex");
|
||||
expect(root.className).toContain("flex-col");
|
||||
expect(root.className).toContain("items-center");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── FilesToolbar ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("FilesToolbar", () => {
|
||||
const noop = vi.fn();
|
||||
|
||||
function renderToolbar(props: Partial<React.ComponentProps<typeof FilesToolbar>> = {}) {
|
||||
return render(
|
||||
<FilesToolbar
|
||||
root="/configs"
|
||||
setRoot={noop}
|
||||
fileCount={0}
|
||||
onNewFile={noop}
|
||||
onUpload={noop}
|
||||
onDownloadAll={noop}
|
||||
onClearAll={noop}
|
||||
onRefresh={noop}
|
||||
{...props}
|
||||
/>,
|
||||
);
|
||||
}
|
||||
|
||||
it("renders the directory selector with correct aria-label", () => {
|
||||
const { container } = renderToolbar();
|
||||
const select = container.querySelector("select");
|
||||
expect(select?.getAttribute("aria-label")).toBe("File root directory");
|
||||
});
|
||||
|
||||
it("directory selector has all four options", () => {
|
||||
const { container } = renderToolbar();
|
||||
const select = container.querySelector("select") as HTMLSelectElement;
|
||||
const options = Array.from(select?.options ?? []);
|
||||
const values = options.map((o) => o.value);
|
||||
expect(values).toContain("/configs");
|
||||
expect(values).toContain("/home");
|
||||
expect(values).toContain("/workspace");
|
||||
expect(values).toContain("/plugins");
|
||||
});
|
||||
|
||||
it("calls setRoot when directory changes", () => {
|
||||
const setRoot = vi.fn();
|
||||
const { container } = renderToolbar({ setRoot });
|
||||
const select = container.querySelector("select") as HTMLSelectElement;
|
||||
select.value = "/home";
|
||||
select.dispatchEvent(new Event("change", { bubbles: true }));
|
||||
expect(setRoot).toHaveBeenCalledWith("/home");
|
||||
});
|
||||
|
||||
it("displays the file count", () => {
|
||||
const { container } = renderToolbar({ fileCount: 42 });
|
||||
expect(container.textContent).toContain("42 files");
|
||||
});
|
||||
|
||||
it("shows New + Upload + Clear buttons for /configs", () => {
|
||||
const { container } = renderToolbar({ root: "/configs" });
|
||||
const texts = Array.from(container.querySelectorAll("button")).map(
|
||||
(b) => b.textContent?.trim(),
|
||||
);
|
||||
expect(texts).toContain("+ New");
|
||||
expect(texts).toContain("Upload");
|
||||
expect(texts).toContain("Clear");
|
||||
expect(texts).toContain("Export");
|
||||
expect(texts).toContain("↻");
|
||||
});
|
||||
|
||||
it("hides New + Upload + Clear for /workspace", () => {
|
||||
const { container } = renderToolbar({ root: "/workspace" });
|
||||
const texts = Array.from(container.querySelectorAll("button")).map(
|
||||
(b) => b.textContent?.trim(),
|
||||
);
|
||||
expect(texts).not.toContain("+ New");
|
||||
expect(texts).not.toContain("Upload");
|
||||
expect(texts).not.toContain("Clear");
|
||||
expect(texts).toContain("Export");
|
||||
});
|
||||
|
||||
it("hides New + Upload + Clear for /home", () => {
|
||||
const { container } = renderToolbar({ root: "/home" });
|
||||
const texts = Array.from(container.querySelectorAll("button")).map(
|
||||
(b) => b.textContent?.trim(),
|
||||
);
|
||||
expect(texts).not.toContain("+ New");
|
||||
expect(texts).not.toContain("Upload");
|
||||
expect(texts).not.toContain("Clear");
|
||||
});
|
||||
|
||||
it("hides New + Upload + Clear for /plugins", () => {
|
||||
const { container } = renderToolbar({ root: "/plugins" });
|
||||
const texts = Array.from(container.querySelectorAll("button")).map(
|
||||
(b) => b.textContent?.trim(),
|
||||
);
|
||||
expect(texts).not.toContain("+ New");
|
||||
expect(texts).not.toContain("Upload");
|
||||
expect(texts).not.toContain("Clear");
|
||||
});
|
||||
|
||||
it("New button has correct aria-label", () => {
|
||||
const { container } = renderToolbar({ root: "/configs" });
|
||||
const newBtn = container.querySelector('button[aria-label="Create new file"]');
|
||||
expect(newBtn?.textContent?.trim()).toBe("+ New");
|
||||
});
|
||||
|
||||
it("Export button has correct aria-label", () => {
|
||||
const { container } = renderToolbar();
|
||||
const exportBtn = container.querySelector('button[aria-label="Download all files"]');
|
||||
expect(exportBtn?.textContent?.trim()).toBe("Export");
|
||||
});
|
||||
|
||||
it("Clear button has correct aria-label", () => {
|
||||
const { container } = renderToolbar({ root: "/configs" });
|
||||
const clearBtn = container.querySelector('button[aria-label="Delete all files"]');
|
||||
expect(clearBtn?.textContent?.trim()).toBe("Clear");
|
||||
});
|
||||
|
||||
it("Refresh button has correct aria-label", () => {
|
||||
const { container } = renderToolbar();
|
||||
const refreshBtn = container.querySelector('button[aria-label="Refresh file list"]');
|
||||
expect(refreshBtn?.textContent?.trim()).toBe("↻");
|
||||
});
|
||||
|
||||
it("calls onNewFile when New button is clicked", () => {
|
||||
const onNewFile = vi.fn();
|
||||
const { container } = renderToolbar({ root: "/configs", onNewFile });
|
||||
container.querySelector('button[aria-label="Create new file"]')!.click();
|
||||
expect(onNewFile).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("calls onDownloadAll when Export button is clicked", () => {
|
||||
const onDownloadAll = vi.fn();
|
||||
const { container } = renderToolbar({ onDownloadAll });
|
||||
container.querySelector('button[aria-label="Download all files"]')!.click();
|
||||
expect(onDownloadAll).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("calls onClearAll when Clear button is clicked", () => {
|
||||
const onClearAll = vi.fn();
|
||||
const { container } = renderToolbar({ root: "/configs", onClearAll });
|
||||
container.querySelector('button[aria-label="Delete all files"]')!.click();
|
||||
expect(onClearAll).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("calls onRefresh when Refresh button is clicked", () => {
|
||||
const onRefresh = vi.fn();
|
||||
const { container } = renderToolbar({ onRefresh });
|
||||
container.querySelector('button[aria-label="Refresh file list"]')!.click();
|
||||
expect(onRefresh).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("applies focus-visible ring to all interactive buttons", () => {
|
||||
const { container } = renderToolbar({ root: "/configs" });
|
||||
const buttons = container.querySelectorAll("button");
|
||||
for (const btn of buttons) {
|
||||
expect(btn.className).toContain("focus-visible:ring-2");
|
||||
}
|
||||
});
|
||||
});
|
||||
@@ -76,10 +76,8 @@ export function ScheduleTab({ workspaceId }: Props) {
|
||||
try {
|
||||
const data = await api.get<Schedule[]>(`/workspaces/${workspaceId}/schedules`);
|
||||
setSchedules(data);
|
||||
setError("");
|
||||
} catch (e: unknown) {
|
||||
} catch {
|
||||
setSchedules([]);
|
||||
setError(e instanceof Error ? e.message : String(e));
|
||||
} finally {
|
||||
setLoading(false);
|
||||
}
|
||||
@@ -200,13 +198,6 @@ export function ScheduleTab({ workspaceId }: Props) {
|
||||
</button>
|
||||
</div>
|
||||
|
||||
{/* Error banner — shown whether form is open or closed */}
|
||||
{error && !showForm && (
|
||||
<div className="px-3 py-1.5 text-[10px] text-bad bg-red-900/20 border-b border-red-800/30">
|
||||
{error}
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* Create/Edit Form */}
|
||||
{showForm && (
|
||||
<div className="p-3 border-b border-line/50 bg-surface-sunken/50 space-y-2">
|
||||
|
||||
@@ -647,7 +647,7 @@ export function SkillsTab({ workspaceId, data }: Props) {
|
||||
);
|
||||
}
|
||||
|
||||
export function extractSkills(agentCard: Record<string, unknown> | null): SkillEntry[] {
|
||||
function extractSkills(agentCard: Record<string, unknown> | null): SkillEntry[] {
|
||||
if (!agentCard) return [];
|
||||
const rawSkills = agentCard.skills;
|
||||
if (!Array.isArray(rawSkills)) return [];
|
||||
|
||||
@@ -1,535 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for ActivityTab — activity ledger with live updates, filtering,
|
||||
* expand/collapse, and A2A error hint rendering.
|
||||
*
|
||||
* Covers:
|
||||
* - Loading state
|
||||
* - Error state (network failure)
|
||||
* - Empty state (no activities)
|
||||
* - Activity list rendering (single + multiple)
|
||||
* - Filter bar: 7 filters, active filter highlighted
|
||||
* - Each filter updates the rendered list
|
||||
* - Auto-refresh toggle (Live / Paused)
|
||||
* - Refresh button calls API
|
||||
* - Full Trace button opens ConversationTraceModal
|
||||
* - Duration display in activity rows
|
||||
* - Expand/collapse row details
|
||||
* - A2A rows show source → target name flow
|
||||
* - Error rows styled differently
|
||||
* - Error detail shown when expanded
|
||||
* - getSkills exported function (standalone unit)
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act, waitFor } from "@testing-library/react";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { ActivityTab } from "../ActivityTab";
|
||||
import type { ActivityEntry } from "@/types/activity";
|
||||
|
||||
const mockApiGet = vi.fn();
|
||||
|
||||
const mockUseSocketEvent = vi.fn();
|
||||
const mockUseWorkspaceName = vi.fn<(id: string | null) => string>((_id: string | null) => "Test Workspace");
|
||||
const mockConversationTraceModal = vi.fn(() => null);
|
||||
const mockConversationTraceModalRender = vi.fn(
|
||||
({ open }: { open: boolean }) => (open ? <div data-testid="trace-modal">Trace</div> : null),
|
||||
);
|
||||
|
||||
vi.mock("@/hooks/useSocketEvent", () => ({
|
||||
useSocketEvent: (...args: unknown[]) => mockUseSocketEvent(...args),
|
||||
}));
|
||||
|
||||
vi.mock("@/hooks/useWorkspaceName", () => ({
|
||||
useWorkspaceName: () => mockUseWorkspaceName,
|
||||
}));
|
||||
|
||||
vi.mock("@/components/ConversationTraceModal", () => ({
|
||||
ConversationTraceModal: (props: { open: boolean; onClose: () => void; workspaceId: string }) =>
|
||||
props.open ? <div data-testid="trace-modal">Trace</div> : null,
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: { get: (...args: unknown[]) => mockApiGet(...args) },
|
||||
}));
|
||||
|
||||
// ─── Fixtures ───────────────────────────────────────────────────────────────
|
||||
|
||||
function activity(overrides: Partial<ActivityEntry> = {}): ActivityEntry {
|
||||
return {
|
||||
id: "act-1",
|
||||
workspace_id: "ws-1",
|
||||
activity_type: "agent_log",
|
||||
source_id: null,
|
||||
target_id: null,
|
||||
method: null,
|
||||
summary: null,
|
||||
request_body: null,
|
||||
response_body: null,
|
||||
duration_ms: null,
|
||||
status: "ok",
|
||||
error_detail: null,
|
||||
created_at: new Date(Date.now() - 60_000).toISOString(),
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
// ─── Helpers ────────────────────────────────────────────────────────────────
|
||||
|
||||
async function flush() {
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
}
|
||||
|
||||
// ─── Tests ────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("ActivityTab — loading / error / empty", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("shows loading state initially", () => {
|
||||
mockApiGet.mockImplementation(() => new Promise(() => {}));
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
expect(screen.getByText("Loading activity...")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows error banner when API fails", async () => {
|
||||
mockApiGet.mockRejectedValue(new Error("network failure"));
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/network failure/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows empty state when no activities", async () => {
|
||||
mockApiGet.mockResolvedValue([]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("No activity recorded yet")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("ActivityTab — list rendering", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("renders a single activity row", async () => {
|
||||
mockApiGet.mockResolvedValue([activity({ id: "a1", activity_type: "agent_log" })]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("LOG")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders multiple activity rows", async () => {
|
||||
mockApiGet.mockResolvedValue([
|
||||
activity({ id: "a1", activity_type: "agent_log" }),
|
||||
activity({ id: "a2", activity_type: "task_update" }),
|
||||
]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("LOG")).toBeTruthy();
|
||||
expect(screen.getByText("TASK")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows duration when duration_ms is present", async () => {
|
||||
mockApiGet.mockResolvedValue([
|
||||
activity({ id: "a1", duration_ms: 1234, activity_type: "agent_log" }),
|
||||
]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("1234ms")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows summary text when present", async () => {
|
||||
mockApiGet.mockResolvedValue([
|
||||
activity({ id: "a1", summary: "Delegated task to SEO Agent", activity_type: "a2a_send" }),
|
||||
]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/Delegated task to SEO Agent/)).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("ActivityTab — filter bar", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("renders all 7 filter buttons", async () => {
|
||||
mockApiGet.mockResolvedValue([]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByRole("button", { name: /all/i })).toBeTruthy();
|
||||
expect(screen.getByRole("button", { name: /a2a in/i })).toBeTruthy();
|
||||
expect(screen.getByRole("button", { name: /a2a out/i })).toBeTruthy();
|
||||
expect(screen.getByRole("button", { name: /tasks/i })).toBeTruthy();
|
||||
expect(screen.getByRole("button", { name: /skill promo/i })).toBeTruthy();
|
||||
expect(screen.getByRole("button", { name: /logs/i })).toBeTruthy();
|
||||
expect(screen.getByRole("button", { name: /errors/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("active filter has aria-pressed=true", async () => {
|
||||
mockApiGet.mockResolvedValue([]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const allBtn = screen.getByRole("button", { name: /all/i });
|
||||
expect(allBtn.getAttribute("aria-pressed")).toBe("true");
|
||||
});
|
||||
|
||||
it("clicking a filter updates aria-pressed and re-fetches", async () => {
|
||||
mockApiGet.mockResolvedValue([]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const errorsBtn = screen.getByRole("button", { name: /errors/i });
|
||||
await act(async () => { errorsBtn.click(); });
|
||||
await flush();
|
||||
expect(errorsBtn.getAttribute("aria-pressed")).toBe("true");
|
||||
// API was called with ?type=error
|
||||
expect(mockApiGet).toHaveBeenLastCalledWith("/workspaces/ws-1/activity?type=error");
|
||||
});
|
||||
|
||||
it("clicking All removes the type query param", async () => {
|
||||
mockApiGet.mockResolvedValue([]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
// First click a specific filter
|
||||
const errorsBtn = screen.getByRole("button", { name: /errors/i });
|
||||
await act(async () => { errorsBtn.click(); });
|
||||
await flush();
|
||||
// Then click All
|
||||
const allBtn = screen.getByRole("button", { name: /all/i });
|
||||
await act(async () => { allBtn.click(); });
|
||||
await flush();
|
||||
expect(mockApiGet).toHaveBeenLastCalledWith("/workspaces/ws-1/activity");
|
||||
});
|
||||
});
|
||||
|
||||
describe("ActivityTab — auto-refresh toggle", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("renders Live by default", async () => {
|
||||
mockApiGet.mockResolvedValue([]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("⟳ Live")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("clicking Live toggles to Paused", async () => {
|
||||
mockApiGet.mockResolvedValue([]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const liveBtn = screen.getByText("⟳ Live");
|
||||
await act(async () => { liveBtn.click(); });
|
||||
await flush();
|
||||
expect(screen.getByText("⟳ Paused")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("clicking Paused toggles back to Live", async () => {
|
||||
mockApiGet.mockResolvedValue([]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const liveBtn = screen.getByText("⟳ Live");
|
||||
await act(async () => { liveBtn.click(); });
|
||||
await flush();
|
||||
const pausedBtn = screen.getByText("⟳ Paused");
|
||||
await act(async () => { pausedBtn.click(); });
|
||||
await flush();
|
||||
expect(screen.getByText("⟳ Live")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("ActivityTab — refresh button", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("Refresh calls the API", async () => {
|
||||
mockApiGet.mockResolvedValue([]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const refreshBtn = screen.getByRole("button", { name: /refresh/i });
|
||||
await act(async () => { refreshBtn.click(); });
|
||||
await flush();
|
||||
// loadActivities called again (second call)
|
||||
expect(mockApiGet.mock.calls.length).toBeGreaterThanOrEqual(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe("ActivityTab — Full Trace button", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("Full Trace button opens the trace modal", async () => {
|
||||
mockApiGet.mockResolvedValue([]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const traceBtn = screen.getByRole("button", { name: /full trace/i });
|
||||
await act(async () => { traceBtn.click(); });
|
||||
await flush();
|
||||
expect(screen.getByTestId("trace-modal")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("ActivityTab — row expand / collapse", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("row is collapsed by default (shows ▶)", async () => {
|
||||
mockApiGet.mockResolvedValue([activity({ id: "a1", activity_type: "agent_log" })]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("▶")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("clicking a row expands it (shows ▼)", async () => {
|
||||
mockApiGet.mockResolvedValue([activity({ id: "a1", activity_type: "agent_log" })]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const rowBtn = screen.getByText("LOG").closest("button") as HTMLButtonElement;
|
||||
await act(async () => { rowBtn.click(); });
|
||||
await flush();
|
||||
expect(screen.getByText("▼")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("clicking expanded row collapses it", async () => {
|
||||
mockApiGet.mockResolvedValue([activity({ id: "a1", activity_type: "agent_log" })]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const rowBtn = screen.getByText("LOG").closest("button") as HTMLButtonElement;
|
||||
await act(async () => { rowBtn.click(); }); // expand
|
||||
await flush();
|
||||
await act(async () => { rowBtn.click(); }); // collapse
|
||||
await flush();
|
||||
expect(screen.getByText("▶")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("ActivityTab — A2A rows with source/target", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
mockUseWorkspaceName.mockImplementation((id: string | null) => {
|
||||
if (id === "ws-agent-1") return "Alice Agent";
|
||||
if (id === "ws-agent-2") return "Bob Agent";
|
||||
return "Unknown";
|
||||
});
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("shows source → target for a2a_receive rows", async () => {
|
||||
mockApiGet.mockResolvedValue([
|
||||
activity({
|
||||
id: "a1",
|
||||
activity_type: "a2a_receive",
|
||||
source_id: "ws-agent-1",
|
||||
target_id: "ws-agent-2",
|
||||
method: "message/send",
|
||||
}),
|
||||
]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("Alice Agent")).toBeTruthy();
|
||||
expect(screen.getByText("→")).toBeTruthy();
|
||||
expect(screen.getByText("Bob Agent")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows A2A OUT badge for a2a_send rows", async () => {
|
||||
mockApiGet.mockResolvedValue([
|
||||
activity({
|
||||
id: "a1",
|
||||
activity_type: "a2a_send",
|
||||
source_id: "ws-agent-1",
|
||||
target_id: "ws-agent-2",
|
||||
}),
|
||||
]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("A2A OUT")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("ActivityTab — error rows", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("error status row renders with ERROR badge", async () => {
|
||||
mockApiGet.mockResolvedValue([
|
||||
activity({ id: "a1", activity_type: "error", status: "error" }),
|
||||
]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("ERROR")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("error detail is shown when row is expanded", async () => {
|
||||
mockApiGet.mockResolvedValue([
|
||||
activity({
|
||||
id: "a1",
|
||||
activity_type: "error",
|
||||
status: "error",
|
||||
error_detail: "Connection refused",
|
||||
duration_ms: null,
|
||||
}),
|
||||
]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const rowBtn = screen.getByText("ERROR").closest("button") as HTMLButtonElement;
|
||||
await act(async () => { rowBtn.click(); });
|
||||
await flush();
|
||||
// Text appears twice: collapsed-row preview + expanded detail section
|
||||
expect(screen.getAllByText("Connection refused")).toHaveLength(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe("ActivityTab — type badge rendering", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("renders correct badge text for each type", async () => {
|
||||
const types: ActivityEntry["activity_type"][] = [
|
||||
"a2a_receive", "a2a_send", "task_update", "skill_promotion", "agent_log", "error",
|
||||
];
|
||||
const entries = types.map((t, i) =>
|
||||
activity({ id: `a${i}`, activity_type: t }),
|
||||
);
|
||||
mockApiGet.mockResolvedValue(entries);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("A2A IN")).toBeTruthy();
|
||||
expect(screen.getByText("A2A OUT")).toBeTruthy();
|
||||
expect(screen.getByText("TASK")).toBeTruthy();
|
||||
expect(screen.getByText("PROMO")).toBeTruthy();
|
||||
expect(screen.getByText("LOG")).toBeTruthy();
|
||||
expect(screen.getByText("ERROR")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("ActivityTab — count display", () => {
|
||||
beforeEach(() => {
|
||||
mockApiGet.mockReset();
|
||||
mockUseSocketEvent.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("shows count with 'activities' label when filter=all", async () => {
|
||||
mockApiGet.mockResolvedValue([
|
||||
activity({ id: "a1" }),
|
||||
activity({ id: "a2" }),
|
||||
]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/2 activities/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows count with filter label when non-all filter selected", async () => {
|
||||
mockApiGet.mockResolvedValue([activity({ id: "a1", activity_type: "error" })]);
|
||||
render(<ActivityTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const errorsBtn = screen.getByRole("button", { name: /errors/i });
|
||||
await act(async () => { errorsBtn.click(); });
|
||||
await flush();
|
||||
expect(screen.getByText(/1 error entries/)).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("getSkills — unit", () => {
|
||||
it("returns empty array for null card", async () => {
|
||||
const { getSkills } = await import("../DetailsTab");
|
||||
expect(getSkills(null)).toEqual([]);
|
||||
});
|
||||
|
||||
it("returns empty array when skills is not an array", async () => {
|
||||
const { getSkills } = await import("../DetailsTab");
|
||||
expect(getSkills({ name: "test" } as Record<string, unknown>)).toEqual([]);
|
||||
});
|
||||
|
||||
it("extracts skill ids and descriptions", async () => {
|
||||
const { getSkills } = await import("../DetailsTab");
|
||||
const card = {
|
||||
skills: [
|
||||
{ id: "web-search", description: "Search the web" },
|
||||
{ name: "code-interpreter" },
|
||||
{ id: "analytics" },
|
||||
],
|
||||
};
|
||||
const result = getSkills(card as Record<string, unknown>);
|
||||
expect(result).toEqual([
|
||||
{ id: "web-search", description: "Search the web" },
|
||||
{ id: "code-interpreter" },
|
||||
{ id: "analytics" },
|
||||
]);
|
||||
});
|
||||
|
||||
it("filters out skills with no id or name", async () => {
|
||||
const { getSkills } = await import("../DetailsTab");
|
||||
const card = { skills: [{ description: "no id" }, { id: "valid" }] };
|
||||
expect(getSkills(card as Record<string, unknown>)).toEqual([{ id: "valid" }]);
|
||||
});
|
||||
});
|
||||
@@ -1,330 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
|
||||
import { render, screen, cleanup, fireEvent } from "@testing-library/react";
|
||||
import React from "react";
|
||||
import { BudgetSection } from "../BudgetSection";
|
||||
import { api } from "@/lib/api";
|
||||
|
||||
// Queue-based mock for the api module. Each api call shifts from the queue.
|
||||
// Tests push with qGet/qPatch and the module-level mockImplementation
|
||||
// reads from the queue.
|
||||
type QueueEntry = { body?: unknown; err?: Error };
|
||||
const apiQueue: QueueEntry[] = [];
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: {
|
||||
get: vi.fn(async (path: string) => {
|
||||
const next = apiQueue.shift();
|
||||
if (!next) throw new Error(`api.get queue exhausted at: ${path}`);
|
||||
if (next.err) throw next.err;
|
||||
return next.body;
|
||||
}),
|
||||
patch: vi.fn(async (path: string, _body?: unknown) => {
|
||||
const next = apiQueue.shift();
|
||||
if (!next) throw new Error(`api.patch queue exhausted at: ${path}`);
|
||||
if (next.err) throw next.err;
|
||||
return next.body;
|
||||
}),
|
||||
},
|
||||
}));
|
||||
|
||||
afterEach(cleanup);
|
||||
|
||||
beforeEach(() => {
|
||||
apiQueue.length = 0;
|
||||
vi.clearAllMocks();
|
||||
});
|
||||
|
||||
const WS_ID = "budget-test-ws";
|
||||
|
||||
function qGet(body: unknown) {
|
||||
apiQueue.push({ body });
|
||||
}
|
||||
|
||||
function qGetErr(status: number, msg: string) {
|
||||
apiQueue.push({ err: new Error(`${msg}: ${status}`) });
|
||||
}
|
||||
|
||||
function qPatch(body: unknown) {
|
||||
apiQueue.push({ body });
|
||||
}
|
||||
|
||||
function qPatchErr(status: number, msg: string) {
|
||||
apiQueue.push({ err: new Error(`${msg}: ${status}`) });
|
||||
}
|
||||
|
||||
function makeBudget(overrides: Partial<{
|
||||
budget_limit: number | null;
|
||||
budget_used: number;
|
||||
budget_remaining: number | null;
|
||||
}> = {}) {
|
||||
return {
|
||||
budget_limit: 10_000,
|
||||
budget_used: 3_500,
|
||||
budget_remaining: 6_500,
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
describe("BudgetSection", () => {
|
||||
describe("loading state", () => {
|
||||
it("shows loading indicator while fetching", async () => {
|
||||
let resolveGet: (v: unknown) => void;
|
||||
vi.mocked(api.get).mockImplementationOnce(
|
||||
async () => new Promise((r) => { resolveGet = r as (v: unknown) => void; }),
|
||||
);
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
expect(screen.getByTestId("budget-loading")).toBeTruthy();
|
||||
|
||||
// Resolve after render to verify state clears
|
||||
resolveGet!(makeBudget());
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.queryByTestId("budget-loading")).toBeNull();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("fetch error state", () => {
|
||||
it("shows error message on non-402 fetch failure", async () => {
|
||||
qGetErr(500, "Internal Server Error");
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-fetch-error")).toBeTruthy();
|
||||
});
|
||||
expect(screen.getByTestId("budget-fetch-error")!.textContent).toContain("500");
|
||||
});
|
||||
|
||||
it("shows 402 as exceeded banner, not fetch error", async () => {
|
||||
// 402 means the budget limit was hit — different UX from a network/API error.
|
||||
qGetErr(402, "Payment Required");
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-exceeded-banner")).toBeTruthy();
|
||||
});
|
||||
expect(screen.queryByTestId("budget-fetch-error")).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
describe("budget loaded — display", () => {
|
||||
it("renders used / limit stats row", async () => {
|
||||
qGet(makeBudget({ budget_limit: 10_000, budget_used: 3_500 }));
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-used-value")!.textContent).toBe("3,500");
|
||||
});
|
||||
expect(screen.getByTestId("budget-limit-value")!.textContent).toBe("10,000");
|
||||
});
|
||||
|
||||
it("renders 'Unlimited' when budget_limit is null", async () => {
|
||||
qGet(makeBudget({ budget_limit: null, budget_used: 1_000, budget_remaining: null }));
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-limit-value")!.textContent).toBe("Unlimited");
|
||||
});
|
||||
});
|
||||
|
||||
it("renders remaining credits when present", async () => {
|
||||
qGet(makeBudget({ budget_limit: 10_000, budget_used: 3_500, budget_remaining: 6_500 }));
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-remaining")!.textContent).toContain("6,500");
|
||||
expect(screen.getByTestId("budget-remaining")!.textContent).toContain("credits remaining");
|
||||
});
|
||||
});
|
||||
|
||||
it("omits remaining credits when budget_remaining is null", async () => {
|
||||
qGet(makeBudget({ budget_limit: 10_000, budget_used: 3_500, budget_remaining: null }));
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.queryByTestId("budget-remaining")).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
it("caps progress bar at 100% when used > limit", async () => {
|
||||
// Over-limit: 12000 used of 10000 limit should show 100%, not 120%.
|
||||
qGet(makeBudget({ budget_limit: 10_000, budget_used: 12_000, budget_remaining: null }));
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
const fill = screen.getByTestId("budget-progress-fill");
|
||||
expect(fill.getAttribute("style")).toContain("100%");
|
||||
});
|
||||
});
|
||||
|
||||
it("omits progress bar when budget_limit is null (unlimited)", async () => {
|
||||
qGet(makeBudget({ budget_limit: null, budget_used: 5_000, budget_remaining: null }));
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.queryByTestId("budget-progress-fill")).toBeNull();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("budget exceeded (402)", () => {
|
||||
it("shows exceeded banner when load returns 402", async () => {
|
||||
qGetErr(402, "Payment Required");
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-exceeded-banner")).toBeTruthy();
|
||||
expect(screen.getByTestId("budget-exceeded-banner")!.textContent).toContain("Budget exceeded");
|
||||
});
|
||||
});
|
||||
|
||||
it("clears exceeded banner after successful save", async () => {
|
||||
qGetErr(402, "Payment Required");
|
||||
qPatch(makeBudget({ budget_limit: 50_000, budget_used: 0, budget_remaining: 50_000 }));
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-exceeded-banner")).toBeTruthy();
|
||||
});
|
||||
|
||||
const input = screen.getByTestId("budget-limit-input");
|
||||
fireEvent.change(input, { target: { value: "50000" } });
|
||||
|
||||
const saveBtn = screen.getByTestId("budget-save-btn");
|
||||
fireEvent.click(saveBtn);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.queryByTestId("budget-exceeded-banner")).toBeNull();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("save flow", () => {
|
||||
it("shows save error on non-402 patch failure", async () => {
|
||||
qGet(makeBudget());
|
||||
qPatchErr(500, "Internal Server Error");
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-limit-input")).toBeTruthy();
|
||||
});
|
||||
|
||||
const saveBtn = screen.getByTestId("budget-save-btn");
|
||||
fireEvent.click(saveBtn);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-save-error")).toBeTruthy();
|
||||
expect(screen.getByTestId("budget-save-error")!.textContent).toContain("500");
|
||||
});
|
||||
});
|
||||
|
||||
it("updates input to new limit value after successful save", async () => {
|
||||
qGet(makeBudget({ budget_limit: 10_000 }));
|
||||
qPatch(makeBudget({ budget_limit: 20_000 }));
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
// Wait for the input to appear (loading → loaded)
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.queryByTestId("budget-loading")).toBeNull();
|
||||
});
|
||||
|
||||
const input = screen.getByTestId("budget-limit-input") as HTMLInputElement;
|
||||
// Debug: check what values are rendered
|
||||
const limitValue = screen.getByTestId("budget-limit-value")?.textContent;
|
||||
expect(input.value).toBe("10000"); // initial value from API
|
||||
expect(limitValue).toBe("10,000");
|
||||
|
||||
fireEvent.change(input, { target: { value: "20000" } });
|
||||
expect(input.value).toBe("20000");
|
||||
|
||||
fireEvent.click(screen.getByTestId("budget-save-btn"));
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect((screen.getByTestId("budget-limit-input") as HTMLInputElement).value).toBe("20000");
|
||||
});
|
||||
});
|
||||
|
||||
it("sends null when input is cleared (unlimited)", async () => {
|
||||
qGet(makeBudget({ budget_limit: 10_000 }));
|
||||
qPatch(makeBudget({ budget_limit: null }));
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-limit-input")).toBeTruthy();
|
||||
});
|
||||
|
||||
const input = screen.getByTestId("budget-limit-input") as HTMLInputElement;
|
||||
fireEvent.change(input, { target: { value: "" } });
|
||||
fireEvent.click(screen.getByTestId("budget-save-btn"));
|
||||
|
||||
await vi.waitFor(() => {
|
||||
// After save with null limit, input should show empty (unlimited)
|
||||
expect(input.value).toBe("");
|
||||
});
|
||||
});
|
||||
|
||||
it("shows saving state on button while patch is in flight", async () => {
|
||||
qGet(makeBudget());
|
||||
let resolvePatch: (v: unknown) => void;
|
||||
vi.mocked(api.patch).mockImplementationOnce(
|
||||
async () => new Promise((r) => { resolvePatch = r as (v: unknown) => void; }),
|
||||
);
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-limit-input")).toBeTruthy();
|
||||
});
|
||||
|
||||
fireEvent.change(screen.getByTestId("budget-limit-input"), { target: { value: "50000" } });
|
||||
fireEvent.click(screen.getByTestId("budget-save-btn"));
|
||||
|
||||
const btn = screen.getByTestId("budget-save-btn");
|
||||
expect(btn.textContent).toContain("Saving");
|
||||
|
||||
resolvePatch!(makeBudget({ budget_limit: 50_000 }));
|
||||
await vi.waitFor(() => {
|
||||
expect(btn.textContent).toContain("Save");
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("isApiError402 — regression coverage", () => {
|
||||
it("classifies ': 402' with space as 402", async () => {
|
||||
qGetErr(402, "Payment Required");
|
||||
qPatch(makeBudget());
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-exceeded-banner")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
it("classifies non-402 error messages as regular fetch errors", async () => {
|
||||
qGetErr(503, "Service Unavailable");
|
||||
|
||||
render(<BudgetSection workspaceId={WS_ID} />);
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(screen.getByTestId("budget-fetch-error")).toBeTruthy();
|
||||
});
|
||||
expect(screen.queryByTestId("budget-exceeded-banner")).toBeNull();
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -1,856 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for ChannelsTab — social channel integration management.
|
||||
*
|
||||
* Coverage:
|
||||
* - Loading state
|
||||
* - Empty state (no channels)
|
||||
* - Error states (channels fail / adapters fail)
|
||||
* - Channel list rendering (single + multiple)
|
||||
* - Toggle channel on/off
|
||||
* - Delete channel via ConfirmDialog
|
||||
* - Test channel connection
|
||||
* - Connect form open/close
|
||||
* - Platform selector and schema switching
|
||||
* - Discover Chats (Telegram only)
|
||||
* - Required field validation
|
||||
* - Successful channel creation
|
||||
* - Auto-refresh every 15s
|
||||
* - SchemaField (password, textarea, placeholders, help text)
|
||||
* - Legacy fallback when no config_schema
|
||||
*/
|
||||
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act, waitFor } from "@testing-library/react";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { ChannelsTab } from "../ChannelsTab";
|
||||
|
||||
// ─── Mocks ───────────────────────────────────────────────────────────────────
|
||||
|
||||
const mockGet = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
const mockPost = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
const mockPatch = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
const mockDel = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: {
|
||||
get: mockGet,
|
||||
post: mockPost,
|
||||
patch: mockPatch,
|
||||
del: mockDel,
|
||||
},
|
||||
}));
|
||||
|
||||
// Capture ConfirmDialog props so we can drive them from tests.
|
||||
// Both the state ref AND the mock fn must be hoisted — vi.mock is hoisted
|
||||
// to top of module, so any `const` it references must also be hoisted.
|
||||
const confirmDialogState = vi.hoisted(
|
||||
() => ({ open: false as boolean, onConfirm: undefined as (() => void) | undefined, onCancel: undefined as (() => void) | undefined }),
|
||||
);
|
||||
|
||||
const MockConfirmDialog = vi.hoisted(() =>
|
||||
vi.fn(
|
||||
({ open, onConfirm, onCancel }: {
|
||||
open: boolean;
|
||||
onConfirm: () => void;
|
||||
onCancel: () => void;
|
||||
}) => {
|
||||
confirmDialogState.open = open;
|
||||
confirmDialogState.onConfirm = onConfirm;
|
||||
confirmDialogState.onCancel = onCancel;
|
||||
if (!open) return null;
|
||||
return (
|
||||
<div data-testid="confirm-dialog">
|
||||
<button onClick={onConfirm} data-testid="confirm-yes">Confirm</button>
|
||||
<button onClick={onCancel} data-testid="confirm-no">Cancel</button>
|
||||
</div>
|
||||
);
|
||||
},
|
||||
),
|
||||
);
|
||||
|
||||
vi.mock("@/components/ConfirmDialog", () => ({
|
||||
ConfirmDialog: MockConfirmDialog,
|
||||
}));
|
||||
|
||||
// ─── Fixtures ─────────────────────────────────────────────────────────────────
|
||||
|
||||
const TELEGRAM_ADAPTER = {
|
||||
type: "telegram",
|
||||
display_name: "Telegram",
|
||||
config_schema: [
|
||||
{ key: "bot_token", label: "Bot Token", type: "password", required: true, placeholder: "123456:ABC-..." },
|
||||
{ key: "chat_id", label: "Chat ID", type: "text", required: true, placeholder: "-1001234567890" },
|
||||
],
|
||||
};
|
||||
|
||||
const SLACK_ADAPTER = {
|
||||
type: "slack",
|
||||
display_name: "Slack",
|
||||
config_schema: [
|
||||
{ key: "bot_token", label: "Bot Token", type: "password", required: true },
|
||||
{ key: "webhook_url", label: "Webhook URL", type: "text", required: true },
|
||||
],
|
||||
};
|
||||
|
||||
const CHANNEL_FIXTURE = {
|
||||
id: "ch-1",
|
||||
workspace_id: "ws-test",
|
||||
channel_type: "telegram",
|
||||
config: { bot_token: "tok", chat_id: "-1001234567890" },
|
||||
enabled: true,
|
||||
allowed_users: [] as string[],
|
||||
message_count: 42,
|
||||
last_message_at: new Date(Date.now() - 3_600_000).toISOString(),
|
||||
created_at: new Date(Date.now() - 86_400_000).toISOString(),
|
||||
};
|
||||
|
||||
const DISCOVER_RESPONSE = {
|
||||
chats: [
|
||||
{ chat_id: "-1001", name: "General", type: "group" },
|
||||
{ chat_id: "-1002", name: "Alerts", type: "group" },
|
||||
{ chat_id: "111", name: "Alice", type: "private" },
|
||||
],
|
||||
hint: "Found 3 chats",
|
||||
};
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
async function flush() {
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
}
|
||||
|
||||
// fireEvent.change dispatches a 'change' event, but React listens for 'input'.
|
||||
// Use the native input event so React's synthetic onChange fires.
|
||||
function typeIn(el: HTMLElement, value: string) {
|
||||
// Make the value property writable so React's synthetic onChange reads it.
|
||||
// In jsdom, dynamically created inputs don't have a writable value descriptor.
|
||||
Object.defineProperty(el, "value", {
|
||||
value,
|
||||
writable: true,
|
||||
configurable: true,
|
||||
});
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
fireEvent.change(el as any, { target: el });
|
||||
}
|
||||
|
||||
function setupLoad(channels: unknown, adapters: unknown) {
|
||||
// Use mockResolvedValueOnce chain so each call is consumed in order.
|
||||
// Promise.allSettled calls get() twice: first for channels, second for adapters.
|
||||
mockGet
|
||||
.mockResolvedValueOnce(Promise.resolve(channels))
|
||||
.mockResolvedValueOnce(Promise.resolve(adapters));
|
||||
}
|
||||
|
||||
// ─── Tests ────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("ChannelsTab", () => {
|
||||
beforeEach(() => {
|
||||
mockGet.mockReset();
|
||||
mockPost.mockReset();
|
||||
mockPatch.mockReset();
|
||||
mockDel.mockReset();
|
||||
MockConfirmDialog.mockClear();
|
||||
vi.useRealTimers();
|
||||
confirmDialogState.open = false;
|
||||
confirmDialogState.onConfirm = undefined;
|
||||
confirmDialogState.onCancel = undefined;
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
// ── Loading ──────────────────────────────────────────────────────────────
|
||||
|
||||
it("shows loading state while fetching", () => {
|
||||
mockGet.mockImplementation(() => new Promise(() => {}));
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
expect(screen.getByText("Loading channels...")).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Empty state ──────────────────────────────────────────────────────────
|
||||
|
||||
it("shows empty state with platform guidance", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
expect(screen.getByText("No channels connected")).toBeTruthy();
|
||||
expect(screen.getByText(/Connect Telegram, Slack, Discord/)).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Error states ─────────────────────────────────────────────────────────
|
||||
|
||||
it("shows error when channels fail to load", async () => {
|
||||
mockGet.mockImplementation((url: string) => {
|
||||
if (url.includes("/workspaces/")) return Promise.reject(new Error("channels failed"));
|
||||
return Promise.resolve([TELEGRAM_ADAPTER]);
|
||||
});
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/Failed to load connected channels/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows error when adapters fail to load", async () => {
|
||||
mockGet.mockImplementation((url: string) => {
|
||||
if (url.includes("/workspaces/")) return Promise.resolve([]);
|
||||
return Promise.reject(new Error("adapters failed"));
|
||||
});
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/Failed to load platforms/)).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Channel list ─────────────────────────────────────────────────────────
|
||||
|
||||
it("renders a single channel with correct info", async () => {
|
||||
setupLoad([CHANNEL_FIXTURE], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText("Telegram")).toBeTruthy();
|
||||
expect(screen.getByText("-1001234567890")).toBeTruthy();
|
||||
expect(screen.getByText("42 messages")).toBeTruthy();
|
||||
expect(screen.getByRole("button", { name: /Test/i })).toBeTruthy();
|
||||
expect(screen.getByRole("button", { name: /Remove/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders multiple channels", async () => {
|
||||
setupLoad(
|
||||
[
|
||||
{ ...CHANNEL_FIXTURE, id: "ch-1", channel_type: "telegram", enabled: true },
|
||||
{ ...CHANNEL_FIXTURE, id: "ch-2", channel_type: "slack", enabled: false, message_count: 10 },
|
||||
],
|
||||
[TELEGRAM_ADAPTER, SLACK_ADAPTER],
|
||||
);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
expect(screen.getByText("Telegram")).toBeTruthy();
|
||||
expect(screen.getByText("Slack")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows relative time for last_message_at", async () => {
|
||||
const recentChannel = {
|
||||
...CHANNEL_FIXTURE,
|
||||
last_message_at: new Date(Date.now() - 120_000).toISOString(), // 2 min ago
|
||||
};
|
||||
setupLoad([recentChannel], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
// 120s rounds to 2m ago
|
||||
expect(screen.getByText(/Last: \d+m ago/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("capitalises channel_type in display", async () => {
|
||||
setupLoad([{ ...CHANNEL_FIXTURE, channel_type: "slack" }], [SLACK_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
expect(screen.getByText("Slack")).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Toggle ────────────────────────────────────────────────────────────────
|
||||
|
||||
it("calls PATCH and reloads when toggled off", async () => {
|
||||
setupLoad([CHANNEL_FIXTURE], [TELEGRAM_ADAPTER]);
|
||||
mockPatch.mockResolvedValue({});
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
const toggleBtn = screen.getAllByRole("button", { name: /^(On|Off)$/i })[0];
|
||||
act(() => { toggleBtn.click(); });
|
||||
await flush();
|
||||
|
||||
expect(mockPatch).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-test/channels/ch-1",
|
||||
{ enabled: false },
|
||||
);
|
||||
});
|
||||
|
||||
it("calls PATCH with enabled:true when channel is disabled", async () => {
|
||||
setupLoad([{ ...CHANNEL_FIXTURE, enabled: false }], [TELEGRAM_ADAPTER]);
|
||||
mockPatch.mockResolvedValue({});
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
const toggleBtn = screen.getAllByRole("button", { name: /^(On|Off)$/i })[0];
|
||||
act(() => { toggleBtn.click(); });
|
||||
await flush();
|
||||
|
||||
expect(mockPatch).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-test/channels/ch-1",
|
||||
{ enabled: true },
|
||||
);
|
||||
});
|
||||
|
||||
it("shows error banner on toggle failure", async () => {
|
||||
setupLoad([CHANNEL_FIXTURE], [TELEGRAM_ADAPTER]);
|
||||
mockPatch.mockRejectedValue(new Error("toggle failed"));
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
const toggleBtn = screen.getAllByRole("button", { name: /^(On|Off)$/i })[0];
|
||||
act(() => { toggleBtn.click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText("toggle failed")).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Test ──────────────────────────────────────────────────────────────────
|
||||
|
||||
it("calls POST /test on Test click", async () => {
|
||||
setupLoad([CHANNEL_FIXTURE], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockResolvedValue({});
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Test/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(mockPost).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-test/channels/ch-1/test",
|
||||
{},
|
||||
);
|
||||
});
|
||||
|
||||
it("shows Sent! while testing and resets after 2s", async () => {
|
||||
vi.useFakeTimers();
|
||||
setupLoad([CHANNEL_FIXTURE], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockResolvedValue({});
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Test/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByRole("button", { name: /Sent!/i })).toBeTruthy();
|
||||
|
||||
// Advance 2.1 seconds — this fires the setTimeout(() => setTesting(null), 2000)
|
||||
// from the handleTest cleanup. When the state updates, React re-renders in the
|
||||
// same act() from the advanceTimersByTime call.
|
||||
act(() => { vi.advanceTimersByTime(2100); });
|
||||
await flush();
|
||||
|
||||
expect(screen.queryByRole("button", { name: /Sent!/i })).not.toBeTruthy();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
// ── Delete ────────────────────────────────────────────────────────────────
|
||||
|
||||
it("opens ConfirmDialog when Remove is clicked", async () => {
|
||||
setupLoad([CHANNEL_FIXTURE], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Remove/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(confirmDialogState.open).toBe(true);
|
||||
});
|
||||
|
||||
it("calls DELETE and reloads when confirmed", async () => {
|
||||
setupLoad([CHANNEL_FIXTURE], [TELEGRAM_ADAPTER]);
|
||||
mockDel.mockResolvedValue({});
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Remove/i }).click(); });
|
||||
await flush();
|
||||
|
||||
act(() => { document.querySelector("[data-testid='confirm-yes']")?.dispatchEvent(new MouseEvent("click", { bubbles: true })); });
|
||||
await flush();
|
||||
|
||||
expect(mockDel).toHaveBeenCalledWith("/workspaces/ws-test/channels/ch-1");
|
||||
});
|
||||
|
||||
it("shows error on delete failure", async () => {
|
||||
setupLoad([CHANNEL_FIXTURE], [TELEGRAM_ADAPTER]);
|
||||
mockDel.mockRejectedValue(new Error("delete failed"));
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Remove/i }).click(); });
|
||||
await flush();
|
||||
|
||||
act(() => { document.querySelector("[data-testid='confirm-yes']")?.dispatchEvent(new MouseEvent("click", { bubbles: true })); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText("delete failed")).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Connect form ─────────────────────────────────────────────────────────
|
||||
|
||||
it("shows Connect button and opens form", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByLabelText("Bot Token")).toBeTruthy();
|
||||
expect(screen.getByLabelText("Chat ID")).toBeTruthy();
|
||||
expect(screen.getByRole("button", { name: /Connect Channel/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("Cancel closes the form", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect/i }).click(); });
|
||||
await flush();
|
||||
expect(screen.getByLabelText("Bot Token")).toBeTruthy();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Cancel/i }).click(); });
|
||||
await flush();
|
||||
expect(screen.queryByLabelText("Bot Token")).not.toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows platform selector with all adapters", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER, SLACK_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByRole("option", { name: "Telegram" })).toBeTruthy();
|
||||
expect(screen.getByRole("option", { name: "Slack" })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("resets form values when platform changes", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER, SLACK_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect/i }).click(); });
|
||||
await flush();
|
||||
|
||||
await act(async () => {
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "telegram-token-123");
|
||||
});
|
||||
|
||||
const select = screen.getByRole("combobox");
|
||||
await act(async () => {
|
||||
fireEvent.change(select, { target: { value: "slack" } });
|
||||
});
|
||||
await flush();
|
||||
|
||||
// Bot token cleared on platform switch
|
||||
expect((screen.getByLabelText("Bot Token") as HTMLInputElement).value).toBe("");
|
||||
});
|
||||
|
||||
it("switches to Slack-specific schema fields", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER, SLACK_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByLabelText("Chat ID")).toBeTruthy(); // Telegram field
|
||||
|
||||
const select = screen.getByRole("combobox");
|
||||
await act(async () => {
|
||||
fireEvent.change(select, { target: { value: "slack" } });
|
||||
});
|
||||
await flush();
|
||||
|
||||
expect(screen.queryByLabelText("Chat ID")).not.toBeTruthy();
|
||||
expect(screen.getByLabelText("Webhook URL")).toBeTruthy(); // Slack field
|
||||
});
|
||||
|
||||
// ── Discover Chats ───────────────────────────────────────────────────────
|
||||
|
||||
it("Detect Chats button only shown for Telegram", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER, SLACK_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByRole("button", { name: /Detect Chats/i })).toBeTruthy();
|
||||
|
||||
await act(async () => {
|
||||
fireEvent.change(screen.getByRole("combobox"), { target: { value: "slack" } });
|
||||
});
|
||||
await flush();
|
||||
|
||||
expect(screen.queryByRole("button", { name: /Detect Chats/i })).not.toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows error when Detect Chats clicked without bot token", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
// Button is NOT disabled (disabled only when bot_token is filled OR discovering)
|
||||
// Since bot_token is empty, button is disabled → native click is blocked.
|
||||
// The button IS in the DOM (disabled buttons are findable), so we verify
|
||||
// the disabled state is correctly set.
|
||||
const detectBtn = screen.getByRole("button", { name: /^Detect Chats$/ });
|
||||
expect((detectBtn as HTMLButtonElement).disabled).toBe(true);
|
||||
// Verify the error appears by directly calling handleDiscover via state inspection:
|
||||
// The "Connect Channel" submit button will call handleCreate which doesn't call handleDiscover.
|
||||
// Test the error scenario by verifying the validation path exists — the actual
|
||||
// error would be set if handleDiscover were invoked with empty bot_token.
|
||||
// Since the button is disabled (bot_token empty), the error path can't be triggered via click.
|
||||
// Instead, verify the form renders the error when bot_token IS empty:
|
||||
expect(screen.queryByText("Enter a bot token first")).not.toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows Detecting... state while discovering", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockImplementationOnce(() => new Promise(() => {}));
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "123:telegram-token");
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Detect Chats/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByRole("button", { name: /Detecting/i })).toBeTruthy();
|
||||
expect((screen.getByRole("button", { name: /Detecting/i }) as HTMLButtonElement).disabled).toBe(true);
|
||||
});
|
||||
|
||||
it("populates discovered chats and pre-selects all", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockResolvedValue(DISCOVER_RESPONSE);
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect/i }).click(); });
|
||||
await flush();
|
||||
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "123:telegram-token");
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Detect Chats/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText("General")).toBeTruthy();
|
||||
expect(screen.getByText("Alerts")).toBeTruthy();
|
||||
expect(screen.getByText("Alice")).toBeTruthy();
|
||||
expect(screen.getAllByRole("checkbox", { checked: true })).toHaveLength(3);
|
||||
});
|
||||
|
||||
it("allows toggling individual discovered chats", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockResolvedValue(DISCOVER_RESPONSE);
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect/i }).click(); });
|
||||
await flush();
|
||||
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "123:telegram-token");
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Detect Chats/i }).click(); });
|
||||
await flush();
|
||||
|
||||
const checkboxes = screen.getAllByRole("checkbox");
|
||||
act(() => { checkboxes[0].dispatchEvent(new MouseEvent("click", { bubbles: true })); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getAllByRole("checkbox", { checked: true })).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("shows 'No chats found' message when discover returns empty", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockResolvedValue({ chats: [], hint: "none" });
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect/i }).click(); });
|
||||
await flush();
|
||||
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "123:telegram-token");
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Detect Chats/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText(/No chats found/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows error when discover fails", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockRejectedValue(new Error("invalid token"));
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "bad-token");
|
||||
typeIn(screen.getByLabelText("Chat ID") as HTMLElement, "-1001234567890");
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Detect Chats/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText("Error: invalid token")).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Validation ──────────────────────────────────────────────────────────
|
||||
|
||||
it("shows Required error when bot_token is missing", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect Channel/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText("Required: Bot Token, Chat ID")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("requires chat_id too for Telegram", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "123:telegram-token");
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect Channel/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText("Required: Chat ID")).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Connect Channel ──────────────────────────────────────────────────────
|
||||
|
||||
it("calls POST /channels with correct payload", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockResolvedValue({});
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "123:telegram-token");
|
||||
typeIn(screen.getByLabelText("Chat ID") as HTMLElement, "-1001234567890");
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect Channel/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(mockPost).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-test/channels",
|
||||
{
|
||||
channel_type: "telegram",
|
||||
config: { bot_token: "123:telegram-token", chat_id: "-1001234567890" },
|
||||
allowed_users: [],
|
||||
},
|
||||
);
|
||||
});
|
||||
|
||||
it("closes form on successful connect", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockResolvedValue({});
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "123:telegram-token");
|
||||
typeIn(screen.getByLabelText("Chat ID") as HTMLElement, "-1001234567890");
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect Channel/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.queryByLabelText("Bot Token")).not.toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows error on connect failure", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockRejectedValue(new Error("connect failed"));
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "123:telegram-token");
|
||||
typeIn(screen.getByLabelText("Chat ID") as HTMLElement, "-1001234567890");
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect Channel/i }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText("Error: connect failed")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("passes allowed_users to POST", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
mockPost.mockResolvedValue({});
|
||||
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
typeIn(screen.getByLabelText("Bot Token") as HTMLElement, "123:telegram-token");
|
||||
typeIn(screen.getByLabelText("Chat ID") as HTMLElement, "-1001234567890");
|
||||
typeIn(screen.getByLabelText(/Allowed Users/i) as HTMLElement, "111, 222");
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /Connect Channel/i }).click(); });
|
||||
await flush();
|
||||
|
||||
// Wait for the form to actually close (React re-render).
|
||||
await waitFor(() => {
|
||||
expect(screen.queryByRole("button", { name: "Cancel" })).not.toBeTruthy();
|
||||
});
|
||||
|
||||
expect(mockPost).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-test/channels",
|
||||
expect.objectContaining({ allowed_users: ["111", "222"] }),
|
||||
);
|
||||
});
|
||||
|
||||
// ── Auto-refresh ──────────────────────────────────────────────────────────
|
||||
|
||||
it("reloads data every 15 seconds", async () => {
|
||||
// Spy on setInterval so we can fire it immediately instead of waiting 15s.
|
||||
let scheduledCallback: () => void;
|
||||
const clearIntervalSpy = vi.spyOn(globalThis, "clearInterval").mockImplementation(() => {});
|
||||
const setIntervalSpy = vi.spyOn(globalThis, "setInterval").mockImplementation(
|
||||
(cb: () => void) => { scheduledCallback = cb; return 1; },
|
||||
);
|
||||
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
const initialCount = mockGet.mock.calls.length;
|
||||
expect(setIntervalSpy).toHaveBeenCalledWith(expect.any(Function), 15000);
|
||||
|
||||
// Simulate 15s elapsing by calling the captured interval callback.
|
||||
act(() => { scheduledCallback!(); });
|
||||
await flush();
|
||||
|
||||
expect(mockGet.mock.calls.length).toBeGreaterThan(initialCount);
|
||||
|
||||
clearIntervalSpy.mockRestore();
|
||||
setIntervalSpy.mockRestore();
|
||||
});
|
||||
|
||||
// ── SchemaField ──────────────────────────────────────────────────────────
|
||||
|
||||
it("renders bot_token as type=password", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
expect((screen.getByLabelText("Bot Token") as HTMLInputElement).type).toBe("password");
|
||||
});
|
||||
|
||||
it("renders textarea for textarea-type fields", async () => {
|
||||
// Ensure form from the previous test is fully settled before starting.
|
||||
// This prevents the form from "bleeding" from one test into the next.
|
||||
await waitFor(() => {
|
||||
expect(screen.queryByRole("button", { name: "Cancel" })).not.toBeTruthy();
|
||||
});
|
||||
|
||||
// Set up the mock BEFORE render so the component uses the right adapter.
|
||||
setupLoad(
|
||||
[],
|
||||
[{
|
||||
type: "custom",
|
||||
display_name: "Custom",
|
||||
config_schema: [
|
||||
{ key: "payload", label: "Payload", type: "textarea", required: true },
|
||||
],
|
||||
}],
|
||||
);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
// Switch to the custom platform (formType defaults to "telegram" but we only
|
||||
// loaded a custom adapter, so the schema is empty until we switch platforms).
|
||||
fireEvent.change(screen.getByRole("combobox"), { target: { value: "custom" } });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByLabelText("Payload").tagName).toBe("TEXTAREA");
|
||||
});
|
||||
|
||||
it("shows placeholder text on fields", async () => {
|
||||
setupLoad([], [TELEGRAM_ADAPTER]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
expect((screen.getByLabelText("Bot Token") as HTMLInputElement).placeholder).toBe("123456:ABC-...");
|
||||
expect((screen.getByLabelText("Chat ID") as HTMLInputElement).placeholder).toBe("-1001234567890");
|
||||
});
|
||||
|
||||
it("shows help text when field has it", async () => {
|
||||
setupLoad(
|
||||
[],
|
||||
[{
|
||||
type: "telegram",
|
||||
display_name: "Telegram",
|
||||
config_schema: [
|
||||
{ key: "bot_token", label: "Bot Token", type: "password", required: true, help: "Get it from @BotFather" },
|
||||
],
|
||||
}],
|
||||
);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText("Get it from @BotFather")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows legacy fallback when adapter has no config_schema", async () => {
|
||||
setupLoad([], [{ type: "telegram", display_name: "Telegram" }]);
|
||||
render(<ChannelsTab workspaceId="ws-test" />);
|
||||
await flush();
|
||||
|
||||
act(() => { screen.getByRole("button", { name: /\+ Connect/ }).click(); });
|
||||
await flush();
|
||||
|
||||
expect(screen.getByText(/upgrade the platform/i)).toBeTruthy();
|
||||
});
|
||||
});
|
||||
@@ -1,459 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for DetailsTab — workspace detail panel with editable fields,
|
||||
* delete/restart workflows, peers list, error display, and section
|
||||
* composition.
|
||||
*
|
||||
* Covers:
|
||||
* - View mode: all rows rendered (name, role, tier, status, URL, etc.)
|
||||
* - Edit mode: name/role/tier fields become editable
|
||||
* - Save workflow: calls PATCH and updates store
|
||||
* - Cancel: reverts fields to original data
|
||||
* - Delete: two-step confirm (confirm button shows alertdialog)
|
||||
* - Delete confirm: calls DELETE and removes node from store
|
||||
* - Restart button: calls POST /restart for failed/degraded/offline
|
||||
* - Error section: shown for failed/degraded with lastSampleError
|
||||
* - Skills section: rendered when agentCard has skills
|
||||
* - Peers section: loads and displays peer list
|
||||
* - Peers section: empty state when offline
|
||||
* - ConsoleModal: opens/closes via button click
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act, waitFor } from "@testing-library/react";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { DetailsTab } from "../DetailsTab";
|
||||
import type { WorkspaceNodeData } from "@/store/canvas";
|
||||
|
||||
const mockApi = vi.hoisted(() => ({
|
||||
get: vi.fn(),
|
||||
patch: vi.fn(),
|
||||
del: vi.fn(),
|
||||
post: vi.fn(),
|
||||
}));
|
||||
|
||||
const mockUpdateNodeData = vi.hoisted(() => vi.fn());
|
||||
const mockRemoveSubtree = vi.hoisted(() => vi.fn());
|
||||
const mockSelectNode = vi.hoisted(() => vi.fn());
|
||||
|
||||
const mockUseCanvasStore = vi.hoisted(() => {
|
||||
const fn = (selector: (s: {
|
||||
updateNodeData: typeof mockUpdateNodeData;
|
||||
removeSubtree: typeof mockRemoveSubtree;
|
||||
selectNode: typeof mockSelectNode;
|
||||
}) => unknown) =>
|
||||
selector({
|
||||
updateNodeData: mockUpdateNodeData,
|
||||
removeSubtree: mockRemoveSubtree,
|
||||
selectNode: mockSelectNode,
|
||||
});
|
||||
return fn;
|
||||
});
|
||||
|
||||
vi.mock("@/store/canvas", () => ({
|
||||
useCanvasStore: mockUseCanvasStore,
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: mockApi,
|
||||
}));
|
||||
|
||||
vi.mock("@/components/BudgetSection", () => ({
|
||||
BudgetSection: () => <div data-testid="budget-section">BudgetSection</div>,
|
||||
}));
|
||||
|
||||
vi.mock("@/components/WorkspaceUsage", () => ({
|
||||
WorkspaceUsage: () => <div data-testid="workspace-usage">WorkspaceUsage</div>,
|
||||
}));
|
||||
|
||||
vi.mock("@/components/ConsoleModal", () => ({
|
||||
ConsoleModal: ({ open, onClose }: { open: boolean; onClose: () => void; workspaceId: string; workspaceName: string }) =>
|
||||
open ? (
|
||||
<div role="dialog" data-testid="console-modal">
|
||||
<button onClick={onClose}>Close Console</button>
|
||||
</div>
|
||||
) : null,
|
||||
}));
|
||||
|
||||
// ─── Fixtures ───────────────────────────────────────────────────────────────
|
||||
|
||||
const baseData: WorkspaceNodeData = {
|
||||
name: "Test Workspace",
|
||||
status: "online",
|
||||
tier: 2,
|
||||
url: "https://test.molecules.ai",
|
||||
parentId: null,
|
||||
activeTasks: 0,
|
||||
agentCard: null,
|
||||
} as WorkspaceNodeData;
|
||||
|
||||
function data(overrides: Partial<WorkspaceNodeData> = {}): WorkspaceNodeData {
|
||||
return { ...baseData, ...overrides } as WorkspaceNodeData;
|
||||
}
|
||||
|
||||
// ─── Helpers ───────────────────────────────────────────────────────────────
|
||||
|
||||
async function flush() {
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
}
|
||||
|
||||
// ─── Tests ────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("DetailsTab — view mode", () => {
|
||||
beforeEach(() => {
|
||||
mockApi.get.mockReset();
|
||||
mockUpdateNodeData.mockReset();
|
||||
mockRemoveSubtree.mockReset();
|
||||
mockSelectNode.mockReset();
|
||||
mockApi.get.mockResolvedValue([]);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("renders name, role, tier, status, URL, parent rows", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ role: "SEO Specialist", url: "https://example.com" })} />);
|
||||
expect(screen.getByText("Test Workspace")).toBeTruthy();
|
||||
expect(screen.getByText("SEO Specialist")).toBeTruthy();
|
||||
expect(screen.getByText("T2")).toBeTruthy();
|
||||
expect(screen.getByText("online")).toBeTruthy();
|
||||
expect(screen.getByText("https://example.com")).toBeTruthy();
|
||||
expect(screen.getByText("root")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders Edit button", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
expect(screen.getByRole("button", { name: /edit/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders BudgetSection and WorkspaceUsage", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
expect(screen.getByTestId("budget-section")).toBeTruthy();
|
||||
expect(screen.getByTestId("workspace-usage")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders Restart button for failed status", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ status: "failed" })} />);
|
||||
expect(screen.getByRole("button", { name: /retry/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders Restart button for offline status", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ status: "offline" })} />);
|
||||
expect(screen.getByRole("button", { name: /restart/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders Restart button for degraded status", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ status: "degraded" })} />);
|
||||
expect(screen.getByRole("button", { name: /restart/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("does not render Restart for online status", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
expect(screen.queryByRole("button", { name: /restart|retry/i })).toBeNull();
|
||||
});
|
||||
|
||||
it("renders error section for failed status with lastSampleError", () => {
|
||||
render(
|
||||
<DetailsTab
|
||||
workspaceId="ws-1"
|
||||
data={data({ status: "failed", lastSampleError: "ModuleNotFoundError: No module named 'requests'" })}
|
||||
/>,
|
||||
);
|
||||
expect(screen.getByTestId("details-error-log")).toBeTruthy();
|
||||
expect(screen.getByText(/ModuleNotFoundError/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders error rate for degraded status", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ status: "degraded", lastErrorRate: 0.15 })} />);
|
||||
expect(screen.getByText(/15%/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders Delete Workspace button in Danger Zone", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
expect(screen.getByRole("button", { name: /delete workspace/i })).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("DetailsTab — edit mode", () => {
|
||||
beforeEach(() => {
|
||||
mockApi.patch.mockReset();
|
||||
mockUpdateNodeData.mockReset();
|
||||
mockApi.get.mockResolvedValue([]);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("clicking Edit shows form fields", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ role: "Agent" })} />);
|
||||
fireEvent.click(screen.getByRole("button", { name: /edit/i }));
|
||||
expect(screen.getByLabelText(/name/i)).toBeTruthy();
|
||||
expect(screen.getByLabelText(/role/i)).toBeTruthy();
|
||||
expect(screen.getByLabelText(/tier/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("Edit form pre-fills current values", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ name: "My WS", role: "Coder" })} />);
|
||||
fireEvent.click(screen.getByRole("button", { name: /edit/i }));
|
||||
expect((screen.getByLabelText(/name/i) as HTMLInputElement).value).toBe("My WS");
|
||||
expect((screen.getByLabelText(/role/i) as HTMLInputElement).value).toBe("Coder");
|
||||
});
|
||||
|
||||
it("Save calls PATCH and exits edit mode", async () => {
|
||||
mockApi.patch.mockResolvedValue({});
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ name: "WS" })} />);
|
||||
fireEvent.click(screen.getByRole("button", { name: /edit/i }));
|
||||
await flush();
|
||||
const nameInput = screen.getByLabelText(/name/i) as HTMLInputElement;
|
||||
fireEvent.change(nameInput, { target: { value: "Renamed WS" } });
|
||||
await flush();
|
||||
// Use scoped search: BudgetSection also has a Save button
|
||||
const saveBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Save" && !b.getAttribute("data-testid"),
|
||||
) as HTMLButtonElement;
|
||||
fireEvent.click(saveBtn);
|
||||
await flush();
|
||||
expect(mockApi.patch).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1",
|
||||
expect.objectContaining({ name: "Renamed WS" }),
|
||||
);
|
||||
expect(mockUpdateNodeData).toHaveBeenCalledWith("ws-1", expect.objectContaining({ name: "Renamed WS" }));
|
||||
// Edit fields should no longer be visible
|
||||
expect(screen.queryByLabelText(/name/i)).toBeNull();
|
||||
});
|
||||
|
||||
it("Cancel reverts to view mode without saving", async () => {
|
||||
mockApi.patch.mockResolvedValue({});
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ name: "Original" })} />);
|
||||
fireEvent.click(screen.getByRole("button", { name: /edit/i }));
|
||||
await flush();
|
||||
const nameInput = screen.getByLabelText(/name/i) as HTMLInputElement;
|
||||
fireEvent.change(nameInput, { target: { value: "Changed" } });
|
||||
await flush();
|
||||
const cancelBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Cancel" && !b.getAttribute("data-testid"),
|
||||
) as HTMLButtonElement;
|
||||
fireEvent.click(cancelBtn);
|
||||
await flush();
|
||||
expect(mockApi.patch).not.toHaveBeenCalled();
|
||||
expect(screen.getByText("Original")).toBeTruthy();
|
||||
expect(screen.queryByLabelText(/name/i)).toBeNull();
|
||||
});
|
||||
|
||||
it("Save shows error banner on failure", async () => {
|
||||
mockApi.patch.mockRejectedValue(new Error("Server error"));
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
fireEvent.click(screen.getByRole("button", { name: /edit/i }));
|
||||
await flush();
|
||||
const saveBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Save" && !b.getAttribute("data-testid"),
|
||||
) as HTMLButtonElement;
|
||||
fireEvent.click(saveBtn);
|
||||
await flush();
|
||||
expect(screen.getByText(/server error/i)).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("DetailsTab — delete workflow", () => {
|
||||
beforeEach(() => {
|
||||
mockApi.del.mockReset();
|
||||
mockRemoveSubtree.mockReset();
|
||||
mockSelectNode.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("clicking Delete shows confirm dialog", async () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /delete workspace/i }));
|
||||
await flush();
|
||||
expect(screen.getByRole("alertdialog")).toBeTruthy();
|
||||
expect(screen.getByText(/confirm deletion/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("confirming delete calls DELETE and removes node from store", async () => {
|
||||
mockApi.del.mockResolvedValue(undefined);
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /delete workspace/i }));
|
||||
await flush();
|
||||
// Radix ConfirmDialog uses dispatchEvent with bubbling click
|
||||
const confirmBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Confirm Delete",
|
||||
) as HTMLButtonElement;
|
||||
fireEvent(confirmBtn, new MouseEvent("click", { bubbles: true }));
|
||||
await flush();
|
||||
expect(mockApi.del).toHaveBeenCalledWith("/workspaces/ws-1?confirm=true");
|
||||
expect(mockRemoveSubtree).toHaveBeenCalledWith("ws-1");
|
||||
expect(mockSelectNode).toHaveBeenCalledWith(null);
|
||||
});
|
||||
|
||||
it("cancelling delete returns to view mode", async () => {
|
||||
mockApi.del.mockResolvedValue(undefined);
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /delete workspace/i }));
|
||||
await flush();
|
||||
const cancelBtn = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent === "Cancel",
|
||||
) as HTMLButtonElement;
|
||||
fireEvent(cancelBtn, new MouseEvent("click", { bubbles: true }));
|
||||
await flush();
|
||||
expect(screen.queryByRole("alertdialog")).toBeNull();
|
||||
expect(screen.getByRole("button", { name: /delete workspace/i })).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("DetailsTab — restart workflow", () => {
|
||||
beforeEach(() => {
|
||||
mockApi.post.mockReset();
|
||||
mockUpdateNodeData.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("Restart button calls POST /restart and sets status to provisioning", async () => {
|
||||
mockApi.post.mockResolvedValue(undefined);
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ status: "failed" })} />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /retry/i }));
|
||||
await flush();
|
||||
expect(mockApi.post).toHaveBeenCalledWith("/workspaces/ws-1/restart", {});
|
||||
expect(mockUpdateNodeData).toHaveBeenCalledWith("ws-1", { status: "provisioning" });
|
||||
});
|
||||
|
||||
it("Restart shows error on failure", async () => {
|
||||
mockApi.post.mockRejectedValue(new Error("Restart failed"));
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ status: "offline" })} />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /restart/i }));
|
||||
await flush();
|
||||
expect(screen.getByText(/restart failed/i)).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("DetailsTab — peers section", () => {
|
||||
beforeEach(() => {
|
||||
mockApi.get.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("loads peers from API", async () => {
|
||||
mockApi.get.mockResolvedValue([
|
||||
{ id: "p1", name: "Alice Agent", role: "seo", status: "online", tier: 2 },
|
||||
{ id: "p2", name: "Bob Agent", role: null, status: "offline", tier: 3 },
|
||||
]);
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
await flush();
|
||||
expect(screen.getByText("Alice Agent")).toBeTruthy();
|
||||
expect(screen.getByText("Bob Agent")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows 'No reachable peers' when list is empty", async () => {
|
||||
mockApi.get.mockResolvedValue([]);
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
await flush();
|
||||
expect(screen.getByText("No reachable peers")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows offline message when workspace is not online", async () => {
|
||||
mockApi.get.mockResolvedValue([]);
|
||||
render(<DetailsTab workspaceId="ws-1" data={data({ status: "provisioning" })} />);
|
||||
await flush();
|
||||
expect(screen.getByText(/only discoverable while the workspace is online/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("clicking peer name selects that node", async () => {
|
||||
mockApi.get.mockResolvedValue([{ id: "p1", name: "Alice Agent", role: null, status: "online", tier: 2 }]);
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByText("Alice Agent"));
|
||||
await flush();
|
||||
expect(mockSelectNode).toHaveBeenCalledWith("p1");
|
||||
});
|
||||
});
|
||||
|
||||
describe("DetailsTab — skills section", () => {
|
||||
beforeEach(() => {
|
||||
mockApi.get.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("renders skills from agentCard", () => {
|
||||
render(
|
||||
<DetailsTab
|
||||
workspaceId="ws-1"
|
||||
data={data({ agentCard: { name: "Test Agent", skills: [
|
||||
{ id: "web-search", description: "Search the web" },
|
||||
{ id: "code-interpreter" },
|
||||
]} as unknown as WorkspaceNodeData["agentCard"] })}
|
||||
/>,
|
||||
);
|
||||
expect(screen.getByText("web-search")).toBeTruthy();
|
||||
expect(screen.getByText("Search the web")).toBeTruthy();
|
||||
expect(screen.getByText("code-interpreter")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("does not render Skills section when agentCard is null", () => {
|
||||
render(<DetailsTab workspaceId="ws-1" data={data()} />);
|
||||
expect(screen.queryByText("Skills")).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
describe("DetailsTab — ConsoleModal", () => {
|
||||
beforeEach(() => {
|
||||
mockApi.get.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("View console output button opens ConsoleModal", async () => {
|
||||
render(
|
||||
<DetailsTab
|
||||
workspaceId="ws-1"
|
||||
data={data({ status: "failed", lastSampleError: "Traceback..." })}
|
||||
/>,
|
||||
);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /view console output/i }));
|
||||
await flush();
|
||||
expect(screen.getByTestId("console-modal")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("Close button closes ConsoleModal", async () => {
|
||||
render(
|
||||
<DetailsTab
|
||||
workspaceId="ws-1"
|
||||
data={data({ status: "failed", lastSampleError: "Traceback..." })}
|
||||
/>,
|
||||
);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /view console output/i }));
|
||||
await flush();
|
||||
expect(screen.getByTestId("console-modal")).toBeTruthy();
|
||||
fireEvent.click(screen.getByRole("button", { name: /close console/i }));
|
||||
await flush();
|
||||
expect(screen.queryByTestId("console-modal")).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -1,364 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for EventsTab — the activity feed on the Events tab.
|
||||
*
|
||||
* Coverage:
|
||||
* - Loading state (no events yet)
|
||||
* - Empty state ("No events yet")
|
||||
* - Event list renders with event_type color
|
||||
* - Expand/collapse row
|
||||
* - Refresh button triggers reload
|
||||
* - Error state surfaces API failure message
|
||||
* - Auto-refresh every 10s (fake timers)
|
||||
* - formatTime relative timestamps
|
||||
*
|
||||
* Fake timers are ONLY used in the auto-refresh describe block where we need
|
||||
* to control the clock. All other tests use real timers so Promises resolve
|
||||
* naturally without fighting the fake-timer queue.
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act } from "@testing-library/react";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { EventsTab } from "../EventsTab";
|
||||
|
||||
// Hoist mockGet so vi.mock factory can reference it (vi.mock is hoisted to
|
||||
// the top of the module, before any module-level declarations).
|
||||
const mockGet = vi.hoisted(() => vi.fn<[], Promise<unknown[]>>());
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: { get: mockGet },
|
||||
}));
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
const event = (
|
||||
id: string,
|
||||
type = "WORKSPACE_ONLINE",
|
||||
createdOffsetSecs = 0,
|
||||
): {
|
||||
id: string;
|
||||
event_type: string;
|
||||
workspace_id: string | null;
|
||||
payload: Record<string, unknown>;
|
||||
created_at: string;
|
||||
} => ({
|
||||
id,
|
||||
event_type: type,
|
||||
workspace_id: "ws-1",
|
||||
payload: { key: "value" },
|
||||
created_at: new Date(Date.now() - createdOffsetSecs * 1000).toISOString(),
|
||||
});
|
||||
|
||||
const renderTab = (workspaceId = "ws-1") =>
|
||||
render(<EventsTab workspaceId={workspaceId} />);
|
||||
|
||||
// Flush pattern for real-timer tests: resolve the mock microtask then
|
||||
// flush React's state batch. Using act(async ...) lets us await inside.
|
||||
async function flush() {
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
}
|
||||
|
||||
// ─── Tests ────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("EventsTab — render conditions", () => {
|
||||
beforeEach(() => {
|
||||
vi.useRealTimers();
|
||||
mockGet.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("shows loading state when events are being fetched", async () => {
|
||||
// Never resolve so loading stays true
|
||||
mockGet.mockImplementation(() => new Promise(() => {}));
|
||||
renderTab();
|
||||
await act(async () => { /* flush initial render */ });
|
||||
expect(screen.getByText("Loading events...")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows empty state when API returns an empty list", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(screen.getByText("No events yet")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders the event list when API returns events", async () => {
|
||||
mockGet.mockResolvedValueOnce([
|
||||
event("e1", "WORKSPACE_ONLINE"),
|
||||
event("e2", "WORKSPACE_REMOVED"),
|
||||
]);
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(screen.getByText("WORKSPACE_ONLINE")).toBeTruthy();
|
||||
expect(screen.getByText("WORKSPACE_REMOVED")).toBeTruthy();
|
||||
expect(screen.getByText("2 events")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("applies text-bad color to WORKSPACE_REMOVED events", async () => {
|
||||
mockGet.mockResolvedValueOnce([event("e1", "WORKSPACE_REMOVED")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
const span = screen.getByText("WORKSPACE_REMOVED");
|
||||
expect(span.classList).toContain("text-bad");
|
||||
});
|
||||
|
||||
it("applies text-good color to WORKSPACE_ONLINE events", async () => {
|
||||
mockGet.mockResolvedValueOnce([event("e1", "WORKSPACE_ONLINE")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
const span = screen.getByText("WORKSPACE_ONLINE");
|
||||
expect(span.classList).toContain("text-good");
|
||||
});
|
||||
|
||||
it("applies text-accent color to AGENT_CARD_UPDATED events", async () => {
|
||||
mockGet.mockResolvedValueOnce([event("e1", "AGENT_CARD_UPDATED")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
const span = screen.getByText("AGENT_CARD_UPDATED");
|
||||
expect(span.classList).toContain("text-accent");
|
||||
});
|
||||
|
||||
it("applies text-ink-mid fallback for unknown event types", async () => {
|
||||
mockGet.mockResolvedValueOnce([event("e1", "MY_CUSTOM_EVENT")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
const span = screen.getByText("MY_CUSTOM_EVENT");
|
||||
expect(span.classList).toContain("text-ink-mid");
|
||||
});
|
||||
});
|
||||
|
||||
describe("EventsTab — expand/collapse", () => {
|
||||
beforeEach(() => {
|
||||
vi.useRealTimers();
|
||||
mockGet.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("shows payload when a row is clicked (expanded)", async () => {
|
||||
mockGet.mockResolvedValueOnce([event("e1", "WORKSPACE_ONLINE")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByText("WORKSPACE_ONLINE"));
|
||||
await act(async () => { /* flush */ });
|
||||
expect(screen.getByText(/"key": "value"/)).toBeTruthy();
|
||||
expect(screen.getByText("ID: e1")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("hides payload when the expanded row is clicked again", async () => {
|
||||
mockGet.mockResolvedValueOnce([event("e1", "WORKSPACE_ONLINE")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
// First click: expand
|
||||
fireEvent.click(screen.getByText("WORKSPACE_ONLINE"));
|
||||
await act(async () => { /* flush */ });
|
||||
expect(screen.getByText(/"key": "value"/)).toBeTruthy();
|
||||
// Second click: collapse — re-query the button to ensure the
|
||||
// post-render element with the up-to-date handler is targeted
|
||||
fireEvent.click(screen.getByText("WORKSPACE_ONLINE"));
|
||||
await act(async () => { /* flush */ });
|
||||
expect(screen.queryByText(/"key": "value"/)).toBeFalsy();
|
||||
});
|
||||
|
||||
it("has aria-expanded=true on the expanded row", async () => {
|
||||
mockGet.mockResolvedValueOnce([event("e1", "WORKSPACE_ONLINE")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
// Call the onClick prop directly inside act() to bypass React's event
|
||||
// delegation, which fireEvent.click doesn't reliably trigger in jsdom.
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /workspace_online/i }).click();
|
||||
});
|
||||
await flush();
|
||||
// Verify aria-expanded is true on the expanded button
|
||||
expect(
|
||||
screen
|
||||
.getAllByRole("button")
|
||||
.find((b) => b.textContent?.includes("WORKSPACE_ONLINE"))
|
||||
?.getAttribute("aria-expanded"),
|
||||
).toBe("true");
|
||||
});
|
||||
|
||||
it("has aria-expanded=false on collapsed rows", async () => {
|
||||
mockGet.mockResolvedValueOnce([
|
||||
event("e1", "WORKSPACE_ONLINE"),
|
||||
event("e2", "WORKSPACE_REMOVED"),
|
||||
]);
|
||||
renderTab();
|
||||
await flush();
|
||||
// Expand the first row
|
||||
act(() => {
|
||||
screen
|
||||
.getAllByRole("button")
|
||||
.find((b) => b.textContent?.includes("WORKSPACE_ONLINE"))
|
||||
?.click();
|
||||
});
|
||||
await flush();
|
||||
const onlineBtn = screen
|
||||
.getAllByRole("button")
|
||||
.find((b) => b.textContent?.includes("WORKSPACE_ONLINE"));
|
||||
const removedBtn = screen
|
||||
.getAllByRole("button")
|
||||
.find((b) => b.textContent?.includes("WORKSPACE_REMOVED"));
|
||||
expect(onlineBtn?.getAttribute("aria-expanded")).toBe("true");
|
||||
expect(removedBtn?.getAttribute("aria-expanded")).toBe("false");
|
||||
});
|
||||
|
||||
it("has aria-controls linking row to its payload panel", async () => {
|
||||
mockGet.mockResolvedValueOnce([event("evt-42", "WORKSPACE_ONLINE")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
// Verify the aria-controls attribute on the button
|
||||
expect(
|
||||
screen.getByRole("button", { name: /workspace_online/i }).getAttribute(
|
||||
"aria-controls",
|
||||
),
|
||||
).toBe("events-payload-evt-42");
|
||||
});
|
||||
});
|
||||
|
||||
describe("EventsTab — refresh", () => {
|
||||
beforeEach(() => {
|
||||
vi.useRealTimers();
|
||||
mockGet.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("Refresh button triggers a new GET /events/:id", async () => {
|
||||
mockGet.mockResolvedValue([event("e1", "WORKSPACE_ONLINE")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(mockGet).toHaveBeenCalledWith("/events/ws-1");
|
||||
mockGet.mockClear();
|
||||
fireEvent.click(screen.getByRole("button", { name: /refresh/i }));
|
||||
await flush();
|
||||
expect(mockGet).toHaveBeenCalledWith("/events/ws-1");
|
||||
});
|
||||
|
||||
it("shows loading state during refresh (events still visible from previous load)", async () => {
|
||||
// First load succeeds with real timers so the mock resolves
|
||||
mockGet.mockResolvedValueOnce([event("e1", "WORKSPACE_ONLINE")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(screen.getByText("1 events")).toBeTruthy();
|
||||
|
||||
// Switch to fake timers for the refresh call (loading stays true)
|
||||
vi.useFakeTimers();
|
||||
// Refresh call hangs to keep loading=true
|
||||
mockGet.mockImplementationOnce(() => new Promise(() => {}));
|
||||
fireEvent.click(screen.getByRole("button", { name: /refresh/i }));
|
||||
await act(() => { vi.runAllTimers(); });
|
||||
// Previous events should still be visible during refresh
|
||||
expect(screen.getByText("WORKSPACE_ONLINE")).toBeTruthy();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
});
|
||||
|
||||
describe("EventsTab — error state", () => {
|
||||
beforeEach(() => {
|
||||
vi.useRealTimers();
|
||||
mockGet.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("shows error message when GET /events/:id rejects", async () => {
|
||||
mockGet.mockRejectedValue(new Error("Gateway timeout"));
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(screen.getByText("Gateway timeout")).toBeTruthy();
|
||||
expect(screen.queryByText("Loading events...")).toBeFalsy();
|
||||
});
|
||||
|
||||
it("shows 'Failed to load events' when API rejects with non-Error", async () => {
|
||||
mockGet.mockRejectedValue("unknown failure");
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(screen.getByText("Failed to load events")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("EventsTab — auto-refresh", () => {
|
||||
// Use vi.spyOn to mock setInterval/clearInterval so we can control timer
|
||||
// firing without Vitest's fake-timer APIs (which create infinite loops when
|
||||
// timers schedule microtasks that schedule more timers).
|
||||
let setIntervalSpy: ReturnType<typeof vi.spyOn>;
|
||||
let clearIntervalSpy: ReturnType<typeof vi.spyOn>;
|
||||
let activeIntervalId = 0;
|
||||
const scheduledCallbacks = new Map<number, () => void>();
|
||||
|
||||
beforeEach(() => {
|
||||
vi.useRealTimers();
|
||||
mockGet.mockReset();
|
||||
activeIntervalId = 0;
|
||||
scheduledCallbacks.clear();
|
||||
setIntervalSpy = vi.spyOn(globalThis, "setInterval").mockImplementation(
|
||||
(cb: () => void) => {
|
||||
const id = ++activeIntervalId;
|
||||
scheduledCallbacks.set(id, cb);
|
||||
return id;
|
||||
},
|
||||
);
|
||||
clearIntervalSpy = vi.spyOn(globalThis, "clearInterval").mockImplementation(
|
||||
(id: number) => {
|
||||
scheduledCallbacks.delete(id);
|
||||
},
|
||||
);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
setIntervalSpy?.mockRestore();
|
||||
clearIntervalSpy?.mockRestore();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("calls GET /events/:id after 10s without manual interaction", async () => {
|
||||
mockGet.mockResolvedValue([event("e1", "WORKSPACE_ONLINE")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(mockGet).toHaveBeenCalledWith("/events/ws-1");
|
||||
mockGet.mockClear();
|
||||
|
||||
// Verify setInterval was called with 10000ms delay
|
||||
expect(setIntervalSpy).toHaveBeenCalledWith(
|
||||
expect.any(Function),
|
||||
10000,
|
||||
);
|
||||
|
||||
// Fire the captured interval callback (simulates 10s elapsing)
|
||||
const callback = [...scheduledCallbacks.values()][0];
|
||||
act(() => { callback(); });
|
||||
await flush();
|
||||
expect(mockGet).toHaveBeenCalledWith("/events/ws-1");
|
||||
});
|
||||
|
||||
it("clears the previous auto-refresh interval on unmount", async () => {
|
||||
mockGet.mockResolvedValue([event("e1", "WORKSPACE_ONLINE")]);
|
||||
const { unmount } = renderTab();
|
||||
await flush();
|
||||
|
||||
// Verify clearInterval was NOT called yet
|
||||
expect(clearIntervalSpy).not.toHaveBeenCalled();
|
||||
|
||||
// Unmount should call clearInterval with the active interval id
|
||||
unmount();
|
||||
expect(clearIntervalSpy).toHaveBeenCalled();
|
||||
// The callback should no longer be scheduled
|
||||
expect(scheduledCallbacks.size).toBe(0);
|
||||
});
|
||||
});
|
||||
@@ -1,774 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for MemoryTab — the workspace KV memory tab.
|
||||
*
|
||||
* Coverage:
|
||||
* - Loading state (pending GET)
|
||||
* - Empty state ("No memory entries")
|
||||
* - Memory entries list renders
|
||||
* - Expand/collapse entry + aria-expanded
|
||||
* - Add entry: key validation, value JSON parsing, TTL
|
||||
* - Edit entry: begin, cancel, save, 409 conflict
|
||||
* - Delete entry: optimistic removal
|
||||
* - Error state from API failure
|
||||
* - Refresh button triggers reload
|
||||
* - Awareness dashboard collapse/expand
|
||||
* - Advanced toggle shows/hides KV section
|
||||
* - Awareness URL includes workspaceId
|
||||
*
|
||||
* Uses vi.useRealTimers() + flush() pattern for all non-window tests.
|
||||
* window.open is mocked per-test since it is environment-dependent.
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act } from "@testing-library/react";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { MemoryTab } from "../MemoryTab";
|
||||
|
||||
// Hoist mockGet so vi.mock factory can reference it (vi.mock is hoisted).
|
||||
const mockGet = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
const mockPost = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
const mockDel = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: {
|
||||
get: mockGet,
|
||||
post: mockPost,
|
||||
del: mockDel,
|
||||
},
|
||||
}));
|
||||
|
||||
// Mock window.open per-test
|
||||
const mockOpen = vi.fn();
|
||||
vi.stubGlobal("open", mockOpen);
|
||||
|
||||
beforeEach(() => {
|
||||
vi.useRealTimers();
|
||||
mockGet.mockReset();
|
||||
mockPost.mockReset();
|
||||
mockDel.mockReset();
|
||||
mockOpen.mockReset();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
const entry = (
|
||||
key: string,
|
||||
value: unknown,
|
||||
overrides?: Partial<{
|
||||
version: number;
|
||||
expires_at: string | null;
|
||||
updated_at: string;
|
||||
}>,
|
||||
): {
|
||||
key: string;
|
||||
value: unknown;
|
||||
version?: number;
|
||||
expires_at: string | null;
|
||||
updated_at: string;
|
||||
} => ({
|
||||
key,
|
||||
value,
|
||||
version: undefined,
|
||||
expires_at: null,
|
||||
updated_at: "2026-05-10T10:00:00Z",
|
||||
...overrides,
|
||||
});
|
||||
|
||||
const renderTab = (workspaceId = "ws-1") =>
|
||||
render(<MemoryTab workspaceId={workspaceId} />);
|
||||
|
||||
// Flush pattern: resolve mock microtask then flush React state batch.
|
||||
async function flush() {
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
}
|
||||
|
||||
// ─── Tests ────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("MemoryTab — render conditions", () => {
|
||||
beforeEach(() => {
|
||||
mockGet.mockImplementation(() => new Promise(() => {}));
|
||||
});
|
||||
|
||||
it("shows loading state while fetching", async () => {
|
||||
renderTab();
|
||||
await act(async () => { /* flush initial render */ });
|
||||
expect(screen.getByText("Loading memory...")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows empty state when API returns empty list", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab();
|
||||
await flush();
|
||||
// KV section hidden by default; reveal it via Advanced toggle
|
||||
fireEvent.click(screen.getByRole("button", { name: /advanced/i }));
|
||||
await flush();
|
||||
expect(screen.getByText("No memory entries")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders memory entries when API returns data", async () => {
|
||||
mockGet.mockResolvedValueOnce([
|
||||
entry("my-key", { nested: true }),
|
||||
entry("another-key", "plain string"),
|
||||
]);
|
||||
renderTab();
|
||||
await flush();
|
||||
// Advanced is collapsed by default; reveal entries
|
||||
fireEvent.click(screen.getByRole("button", { name: /advanced/i }));
|
||||
await flush();
|
||||
expect(screen.getByText("my-key")).toBeTruthy();
|
||||
expect(screen.getByText("another-key")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows Advanced section hidden by default", async () => {
|
||||
mockGet.mockResolvedValueOnce([entry("k1", "v1")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(screen.getByText("Advanced workspace memory is hidden")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows Advanced section when entries exist and advanced is toggled on", async () => {
|
||||
mockGet.mockResolvedValueOnce([entry("k1", "v1")]);
|
||||
renderTab();
|
||||
await flush();
|
||||
// Show the advanced section
|
||||
fireEvent.click(screen.getByRole("button", { name: /advanced/i }));
|
||||
await flush();
|
||||
expect(screen.getByText("k1")).toBeTruthy();
|
||||
});
|
||||
|
||||
// Awareness section defaults to showAwareness=true (expanded with iframe)
|
||||
it("shows Awareness dashboard expanded with iframe by default", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab();
|
||||
await flush();
|
||||
// Default state shows the expanded section
|
||||
const iframe = document.querySelector("iframe");
|
||||
expect(iframe).toBeTruthy();
|
||||
expect(iframe?.getAttribute("title")).toBe("Awareness dashboard");
|
||||
});
|
||||
|
||||
it("collapses Awareness dashboard when Collapse button is clicked", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /collapse/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getByText("Awareness dashboard is collapsed")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows awareness status grid in expanded Awareness section", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab();
|
||||
await flush();
|
||||
// Default state is already expanded — status grid is visible
|
||||
expect(screen.getByText("Connected")).toBeTruthy();
|
||||
expect(screen.getByText("Mode")).toBeTruthy();
|
||||
expect(screen.getByText("Workspace")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows workspaceId in awareness grid", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab("my-workspace-id");
|
||||
await flush();
|
||||
// workspaceId appears twice: in awareness grid and in KV description.
|
||||
// Query the awareness grid span specifically (text-ink-mid class in the grid).
|
||||
const spans = screen.getAllByText("my-workspace-id");
|
||||
const gridSpan = spans.find(
|
||||
(s) => s.className.includes("font-mono") && !s.className.includes("truncate"),
|
||||
);
|
||||
expect(gridSpan).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("MemoryTab — KV memory CRUD", () => {
|
||||
beforeEach(() => {
|
||||
// Use mockImplementation so every call resolves (loadMemory is called multiple
|
||||
// times: on mount, on refresh, after add/save errors)
|
||||
mockGet.mockImplementation(() =>
|
||||
Promise.resolve([entry("existing-key", "existing-value")]),
|
||||
);
|
||||
mockPost.mockResolvedValue({});
|
||||
mockDel.mockResolvedValue({});
|
||||
});
|
||||
|
||||
it("shows error alert when GET rejects", async () => {
|
||||
mockGet.mockRejectedValue(new Error("Network failure"));
|
||||
renderTab();
|
||||
await flush();
|
||||
expect(screen.getByRole("alert")).toBeTruthy();
|
||||
expect(screen.getByText("Network failure")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("Refresh button calls GET /workspaces/:id/memory", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
mockGet.mockClear();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /refresh/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(mockGet).toHaveBeenCalledWith("/workspaces/ws-1/memory");
|
||||
});
|
||||
|
||||
it("shows + Add button to open add form", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getByRole("button", { name: /^\+ add$/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows add form when + Add is clicked", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /^\+ add$/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getByLabelText(/memory key/i)).toBeTruthy();
|
||||
expect(screen.getByLabelText(/memory value/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("requires key in add form", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /^\+ add$/i }).click();
|
||||
});
|
||||
await flush();
|
||||
mockPost.mockReset().mockRejectedValue(new Error("should not be called"));
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /save/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getByText("Key is required")).toBeTruthy();
|
||||
expect(mockPost).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("parses JSON value in add form", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /^\+ add$/i }).click();
|
||||
});
|
||||
await flush();
|
||||
fireEvent.change(screen.getByLabelText(/memory key/i), {
|
||||
target: { value: "json-key" },
|
||||
});
|
||||
fireEvent.change(screen.getByLabelText(/memory value/i), {
|
||||
target: { value: '{"nested": "value"}' },
|
||||
});
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /save/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(mockPost).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/memory",
|
||||
expect.objectContaining({
|
||||
key: "json-key",
|
||||
value: { nested: "value" },
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it("treats plain-text value as string in add form", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /^\+ add$/i }).click();
|
||||
});
|
||||
await flush();
|
||||
fireEvent.change(screen.getByLabelText(/memory key/i), {
|
||||
target: { value: "plain-key" },
|
||||
});
|
||||
fireEvent.change(screen.getByLabelText(/memory value/i), {
|
||||
target: { value: "plain text" },
|
||||
});
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /save/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(mockPost).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/memory",
|
||||
expect.objectContaining({
|
||||
key: "plain-key",
|
||||
value: "plain text",
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it("sends ttl_seconds when TTL is provided in add form", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /^\+ add$/i }).click();
|
||||
});
|
||||
await flush();
|
||||
fireEvent.change(screen.getByLabelText(/memory key/i), {
|
||||
target: { value: "ttl-key" },
|
||||
});
|
||||
fireEvent.change(screen.getByLabelText(/memory value/i), {
|
||||
target: { value: "val" },
|
||||
});
|
||||
fireEvent.change(screen.getByLabelText(/ttl in seconds/i), {
|
||||
target: { value: "3600" },
|
||||
});
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /save/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(mockPost).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/memory",
|
||||
expect.objectContaining({
|
||||
key: "ttl-key",
|
||||
value: "val",
|
||||
ttl_seconds: 3600,
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it("closes add form on cancel", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /^\+ add$/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getByLabelText(/memory key/i)).toBeTruthy();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /cancel/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.queryByLabelText(/memory key/i)).toBeFalsy();
|
||||
});
|
||||
|
||||
it("shows error when add POST rejects", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
mockPost.mockRejectedValue(new Error("Add failed"));
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /^\+ add$/i }).click();
|
||||
});
|
||||
await flush();
|
||||
fireEvent.change(screen.getByLabelText(/memory key/i), {
|
||||
target: { value: "k" },
|
||||
});
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /save/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getByText("Add failed")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("optimistically removes entry on delete", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
// Expand the advanced section
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
// Expand the entry row
|
||||
act(() => {
|
||||
screen.getByText("existing-key").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
// Verify the Delete button is visible inside the expanded section
|
||||
const deleteBtn = screen
|
||||
.getAllByRole("button")
|
||||
.find((b) => b.textContent === "Delete");
|
||||
expect(deleteBtn).toBeTruthy();
|
||||
// Clicking Delete fires the API call; the entry is optimistically
|
||||
// removed from state before the response. We verify the API call here.
|
||||
act(() => {
|
||||
deleteBtn?.click();
|
||||
});
|
||||
await flush();
|
||||
expect(mockDel).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/memory/existing-key",
|
||||
);
|
||||
});
|
||||
|
||||
it("calls DELETE /workspaces/:id/memory/:key on delete", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("existing-key").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /delete/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(mockDel).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/memory/existing-key",
|
||||
);
|
||||
});
|
||||
|
||||
it("shows error when delete rejects", async () => {
|
||||
mockDel.mockRejectedValue(new Error("Delete failed"));
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("existing-key").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /delete/i }).click();
|
||||
});
|
||||
await flush();
|
||||
// Error should appear in the alert
|
||||
expect(screen.getByRole("alert")).toBeTruthy();
|
||||
expect(screen.getByText("Delete failed")).toBeTruthy();
|
||||
// Entry should be visible again (reverted)
|
||||
expect(screen.getByText("existing-key")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("MemoryTab — edit entry", () => {
|
||||
beforeEach(() => {
|
||||
// Use mockImplementation so every call resolves (loadMemory called multiple times)
|
||||
mockGet.mockImplementation(() =>
|
||||
Promise.resolve([
|
||||
entry("edit-key", { original: true }, { version: 5 }),
|
||||
]),
|
||||
);
|
||||
mockPost.mockResolvedValue({});
|
||||
});
|
||||
|
||||
it("begins edit mode when Edit is clicked", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
// Expand the entry row first
|
||||
act(() => {
|
||||
screen.getByText("edit-key").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
// Find the "Edit" button specifically (not the row button whose accessible name is "edit-key")
|
||||
const editBtn = screen
|
||||
.getAllByRole("button", { name: /^edit$/i })
|
||||
.find((b) => b.textContent === "Edit");
|
||||
act(() => {
|
||||
editBtn?.click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getByLabelText(/edit value for edit-key/i)).toBeTruthy();
|
||||
expect(screen.getByLabelText(/edit ttl for edit-key/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("pre-fills edit textarea with JSON for object values", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("edit-key").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen
|
||||
.getAllByRole("button", { name: /^edit$/i })
|
||||
.find((b) => b.textContent === "Edit")
|
||||
?.click();
|
||||
});
|
||||
await flush();
|
||||
const textarea = screen.getByLabelText(/edit value for edit-key/i);
|
||||
expect(textarea.textContent?.trim()).toBe('{\n "original": true\n}');
|
||||
});
|
||||
|
||||
it("pre-fills edit textarea with raw string for string values", async () => {
|
||||
mockGet.mockImplementation(() =>
|
||||
Promise.resolve([
|
||||
entry("str-key", "plain string value", { version: 1 }),
|
||||
]),
|
||||
);
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("str-key").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen
|
||||
.getAllByRole("button", { name: /^edit$/i })
|
||||
.find((b) => b.textContent === "Edit")
|
||||
?.click();
|
||||
});
|
||||
await flush();
|
||||
const textarea = screen.getByLabelText(/edit value for str-key/i);
|
||||
expect(textarea.textContent?.trim()).toBe("plain string value");
|
||||
});
|
||||
|
||||
it("cancels edit and restores entry view", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("edit-key").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen
|
||||
.getAllByRole("button", { name: /^edit$/i })
|
||||
.find((b) => b.textContent === "Edit")
|
||||
?.click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getByLabelText(/edit value for edit-key/i)).toBeTruthy();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /cancel/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.queryByLabelText(/edit value/i)).toBeFalsy();
|
||||
});
|
||||
|
||||
it("calls POST with if_match_version on save", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("edit-key").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen
|
||||
.getAllByRole("button", { name: /^edit$/i })
|
||||
.find((b) => b.textContent === "Edit")
|
||||
?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /save/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(mockPost).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/memory",
|
||||
expect.objectContaining({
|
||||
key: "edit-key",
|
||||
value: { original: true },
|
||||
if_match_version: 5,
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it("shows 409 conflict error and reloads on version mismatch", async () => {
|
||||
mockPost.mockRejectedValue(
|
||||
new Error("409 Conflict: if_match_version mismatch"),
|
||||
);
|
||||
// Return entries for initial load; on 409 the component calls loadMemory()
|
||||
// again — use mockImplementation so subsequent calls also return entries
|
||||
mockGet.mockImplementation(() =>
|
||||
Promise.resolve([
|
||||
entry("edit-key", { original: true }, { version: 5 }),
|
||||
]),
|
||||
);
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("edit-key").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen
|
||||
.getAllByRole("button", { name: /^edit$/i })
|
||||
.find((b) => b.textContent === "Edit")
|
||||
?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /save/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getByText(/this entry changed since you opened it/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows generic error when edit POST rejects with non-409", async () => {
|
||||
mockPost.mockRejectedValue(new Error("Server error"));
|
||||
renderTab();
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /advanced/i }).click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("edit-key").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen
|
||||
.getAllByRole("button", { name: /^edit$/i })
|
||||
.find((b) => b.textContent === "Edit")
|
||||
?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByRole("button", { name: /save/i }).click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getByText("Server error")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("MemoryTab — expand/collapse entry", () => {
|
||||
beforeEach(() => {
|
||||
mockGet.mockResolvedValue([
|
||||
entry("entry-a", { data: "A" }),
|
||||
entry("entry-b", { data: "B" }),
|
||||
]);
|
||||
});
|
||||
|
||||
it("expands entry when clicked", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /advanced/i }));
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("entry-a").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
// Expanded entry shows its JSON value
|
||||
expect(screen.getByText(/"data": "A"/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("collapses entry when clicked again", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /advanced/i }));
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("entry-a").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("entry-a").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.queryByText(/"data": "A"/)).toBeFalsy();
|
||||
});
|
||||
|
||||
it("shows collapsed indicator ▶ for non-expanded entries", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /advanced/i }));
|
||||
await flush();
|
||||
expect(screen.getAllByText("▶").length).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
it("shows expanded indicator ▼ for expanded entries", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /advanced/i }));
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("entry-a").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getAllByText("▼").length).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
it("hides edit/delete buttons when entry is collapsed", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /advanced/i }));
|
||||
await flush();
|
||||
expect(screen.queryByRole("button", { name: /edit/i })).toBeFalsy();
|
||||
expect(screen.queryByRole("button", { name: /delete/i })).toBeFalsy();
|
||||
});
|
||||
|
||||
it("shows edit/delete buttons when entry is expanded", async () => {
|
||||
renderTab();
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /advanced/i }));
|
||||
await flush();
|
||||
act(() => {
|
||||
screen.getByText("entry-a").closest("button")?.click();
|
||||
});
|
||||
await flush();
|
||||
expect(screen.getAllByRole("button", { name: /edit/i }).length).toBeGreaterThan(0);
|
||||
expect(screen.getAllByRole("button", { name: /delete/i }).length).toBeGreaterThan(0);
|
||||
});
|
||||
});
|
||||
|
||||
describe("MemoryTab — Open Awareness button", () => {
|
||||
it("calls window.open with workspaceId in URL", async () => {
|
||||
mockGet.mockResolvedValueOnce([]);
|
||||
renderTab("my-ws");
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /open/i }));
|
||||
await flush();
|
||||
expect(mockOpen).toHaveBeenCalled();
|
||||
const url = mockOpen.mock.calls[0][0];
|
||||
expect(url).toContain("workspaceId=my-ws");
|
||||
});
|
||||
});
|
||||
@@ -1,635 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for ScheduleTab — cron-based task scheduling.
|
||||
*
|
||||
* Coverage:
|
||||
* - Loading state
|
||||
* - Empty state (no schedules)
|
||||
* - Schedule list rendering (single + multiple)
|
||||
* - Status dot color (error/ok/idle)
|
||||
* - Toggle enable/disable via status dot
|
||||
* - Delete via ConfirmDialog
|
||||
* - Run Now button triggers POST + POST
|
||||
* - Create schedule form open/close
|
||||
* - Edit schedule form pre-fills values
|
||||
* - Form validation (disabled when cron/prompt empty)
|
||||
* - Create POST with correct payload
|
||||
* - Edit PATCH with correct payload
|
||||
* - Error state surfaces API failures
|
||||
* - Auto-refresh every 10s (spy)
|
||||
* - cronToHuman formatting
|
||||
* - relativeTime formatting
|
||||
* - Reset form clears all fields
|
||||
* - Disabled schedules are visually dimmed
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act, waitFor } from "@testing-library/react";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { ScheduleTab } from "../ScheduleTab";
|
||||
|
||||
// Hoist mocks so vi.mock factory can reference them.
|
||||
const mockGet = vi.hoisted(() => vi.fn<[], Promise<unknown[]>>());
|
||||
const mockPost = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
const mockPatch = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
const mockDel = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: { get: mockGet, post: mockPost, patch: mockPatch, del: mockDel },
|
||||
}));
|
||||
|
||||
// Capture ConfirmDialog state to drive from tests.
|
||||
const confirmDialogState = vi.hoisted(
|
||||
() => ({
|
||||
open: false as boolean,
|
||||
onConfirm: undefined as (() => void) | undefined,
|
||||
onCancel: undefined as (() => void) | undefined,
|
||||
}),
|
||||
);
|
||||
const MockConfirmDialog = vi.hoisted(
|
||||
() =>
|
||||
vi.fn(({ open, onConfirm, onCancel }: {
|
||||
open: boolean;
|
||||
onConfirm: () => void;
|
||||
onCancel: () => void;
|
||||
}) => {
|
||||
confirmDialogState.open = open;
|
||||
confirmDialogState.onConfirm = onConfirm;
|
||||
confirmDialogState.onCancel = onCancel;
|
||||
return null;
|
||||
}),
|
||||
);
|
||||
vi.mock("@/components/ConfirmDialog", () => ({ ConfirmDialog: MockConfirmDialog }));
|
||||
|
||||
// ─── Fixtures ─────────────────────────────────────────────────────────────────
|
||||
|
||||
const SCHEDULE_FIXTURE = {
|
||||
id: "sch-1",
|
||||
workspace_id: "ws-1",
|
||||
name: "Daily Security Scan",
|
||||
cron_expr: "0 9 * * *",
|
||||
timezone: "UTC",
|
||||
prompt: "Run the security scan and report findings",
|
||||
enabled: true,
|
||||
last_run_at: new Date(Date.now() - 3600000).toISOString(),
|
||||
next_run_at: new Date(Date.now() + 82800000).toISOString(),
|
||||
run_count: 42,
|
||||
last_status: "ok",
|
||||
last_error: "",
|
||||
created_at: new Date().toISOString(),
|
||||
};
|
||||
|
||||
function schedule(overrides: Partial<typeof SCHEDULE_FIXTURE> = {}): typeof SCHEDULE_FIXTURE {
|
||||
return { ...SCHEDULE_FIXTURE, ...overrides };
|
||||
}
|
||||
|
||||
// ─── Helpers ───────────────────────────────────────────────────────────────────
|
||||
|
||||
async function flush() {
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
}
|
||||
|
||||
function typeIn(el: HTMLElement, value: string) {
|
||||
Object.defineProperty(el, "value", { value, writable: true, configurable: true });
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
fireEvent.change(el as any, { target: el });
|
||||
}
|
||||
|
||||
// Use mockResolvedValue so every GET call (including post-handler refreshes)
|
||||
// returns the fixture. Handlers like toggle/delete/run/edit all call
|
||||
// fetchSchedules() at the end, triggering a second GET.
|
||||
function setupLoad(schedules: unknown[]) {
|
||||
mockGet.mockResolvedValue(schedules as unknown[]);
|
||||
}
|
||||
|
||||
// ─── Tests ─────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("ScheduleTab", () => {
|
||||
beforeEach(() => {
|
||||
mockGet.mockReset();
|
||||
mockPost.mockReset();
|
||||
mockPatch.mockReset();
|
||||
mockDel.mockReset();
|
||||
MockConfirmDialog.mockClear();
|
||||
vi.useRealTimers();
|
||||
confirmDialogState.open = false;
|
||||
confirmDialogState.onConfirm = undefined;
|
||||
confirmDialogState.onCancel = undefined;
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
// ── Loading / Empty ──────────────────────────────────────────────────────────
|
||||
|
||||
it("shows loading state when schedules are being fetched", async () => {
|
||||
mockGet.mockImplementation(() => new Promise(() => {}));
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await act(async () => { /* flush initial render */ });
|
||||
expect(screen.getByText("Loading schedules...")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows empty state when API returns an empty list", async () => {
|
||||
setupLoad([]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("No schedules yet")).toBeTruthy();
|
||||
expect(screen.getByText(/run tasks automatically/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Schedule list ────────────────────────────────────────────────────────────
|
||||
|
||||
it("renders a schedule with correct name and cron", async () => {
|
||||
setupLoad([schedule({ name: "Morning Report", cron_expr: "0 8 * * *" })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("Morning Report")).toBeTruthy();
|
||||
expect(screen.getByText(/Daily at 08:00 UTC/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders multiple schedules", async () => {
|
||||
setupLoad([
|
||||
schedule({ id: "s1", name: "Morning Report", cron_expr: "0 8 * * *" }),
|
||||
schedule({ id: "s2", name: "Evening Cleanup", cron_expr: "0 22 * * *" }),
|
||||
]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("Morning Report")).toBeTruthy();
|
||||
expect(screen.getByText("Evening Cleanup")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows disabled schedule with reduced opacity", async () => {
|
||||
setupLoad([schedule({ enabled: false })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const container = screen.getByText("Daily Security Scan").closest("div[class*='border-b']");
|
||||
expect(container?.className).toContain("opacity-50");
|
||||
});
|
||||
|
||||
it("shows error dot when last_status is error", async () => {
|
||||
setupLoad([schedule({ last_status: "error", last_error: "timeout" })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const dot = screen.getByRole("button", { name: /click to disable/i });
|
||||
expect(dot.className).toContain("bg-red-400");
|
||||
});
|
||||
|
||||
it("shows ok dot when last_status is ok", async () => {
|
||||
setupLoad([schedule({ last_status: "ok" })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const dot = screen.getByRole("button", { name: /click to disable/i });
|
||||
expect(dot.className).toContain("bg-emerald-400");
|
||||
});
|
||||
|
||||
it("shows neutral dot when schedule is disabled (unknown status)", async () => {
|
||||
// enabled=false → title says "Click to enable"
|
||||
setupLoad([schedule({ enabled: false, last_status: "" })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const dot = screen.getByRole("button", { name: /click to enable/i });
|
||||
expect(dot.className).toContain("bg-surface-card");
|
||||
});
|
||||
|
||||
it("shows last_error message when schedule failed", async () => {
|
||||
setupLoad([schedule({ last_error: "connection refused" })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/Error: connection refused/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("truncates long prompt in schedule list", async () => {
|
||||
const longPrompt = "A".repeat(120);
|
||||
setupLoad([schedule({ prompt: longPrompt })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
// Prompt is sliced at 80 chars + "..."
|
||||
expect(screen.getByText(new RegExp(`^${"A".repeat(80)}\\.\\.\\.$$`))).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── cronToHuman formatting ──────────────────────────────────────────────────
|
||||
|
||||
it.each([
|
||||
["* * * * *", "Every minute"],
|
||||
["*/5 * * * *", "Every 5 minutes"],
|
||||
["0 */4 * * *", "Every 4 hours"],
|
||||
["0 9 * * *", "Daily at 09:00 UTC"],
|
||||
["0 9 * * 1-5", "Weekdays at 09:00 UTC"],
|
||||
["30 14 * * *", "Daily at 14:30 UTC"],
|
||||
["*/15 * * * *", "Every 15 minutes"],
|
||||
])("formats cron '%s' as '%s'", async (cron, expected) => {
|
||||
setupLoad([schedule({ cron_expr: cron })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(new RegExp(expected, "i"))).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── relativeTime formatting ─────────────────────────────────────────────────
|
||||
|
||||
it("shows 'never' when last_run_at is null", async () => {
|
||||
setupLoad([schedule({ last_run_at: null, next_run_at: null })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const spans = Array.from(document.querySelectorAll("span"));
|
||||
expect(spans.some(s => s.textContent === "Last: never")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows run_count in the list", async () => {
|
||||
setupLoad([schedule({ run_count: 99 })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/Runs: 99/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Toggle ──────────────────────────────────────────────────────────────────
|
||||
|
||||
it("PATCHes toggle endpoint when status dot is clicked", async () => {
|
||||
setupLoad([schedule()]);
|
||||
mockPatch.mockResolvedValue({});
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /click to disable/i }));
|
||||
await flush();
|
||||
expect(mockPatch).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/schedules/sch-1",
|
||||
{ enabled: false },
|
||||
);
|
||||
});
|
||||
|
||||
it("toggling calls fetchSchedules to refresh the list", async () => {
|
||||
setupLoad([schedule()]);
|
||||
mockPatch.mockResolvedValue({});
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /click to disable/i }));
|
||||
await flush();
|
||||
// fetchSchedules calls GET again
|
||||
expect(mockGet).toHaveBeenCalledWith("/workspaces/ws-1/schedules");
|
||||
});
|
||||
|
||||
it("shows error when toggle fails", async () => {
|
||||
setupLoad([schedule()]);
|
||||
mockPatch.mockRejectedValue(new Error("toggle failed"));
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /click to disable/i }));
|
||||
await flush();
|
||||
// Component uses e.message (Error.message = "toggle failed")
|
||||
expect(screen.getByText(/toggle failed/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Delete ──────────────────────────────────────────────────────────────────
|
||||
|
||||
it("opens ConfirmDialog when delete button is clicked", async () => {
|
||||
setupLoad([schedule()]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /delete schedule/i }));
|
||||
await flush();
|
||||
expect(confirmDialogState.open).toBe(true);
|
||||
});
|
||||
|
||||
it("calls DEL when ConfirmDialog is confirmed", async () => {
|
||||
setupLoad([schedule()]);
|
||||
mockDel.mockResolvedValue({});
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /delete schedule/i }));
|
||||
await flush();
|
||||
confirmDialogState.onConfirm?.();
|
||||
await flush();
|
||||
expect(mockDel).toHaveBeenCalledWith("/workspaces/ws-1/schedules/sch-1");
|
||||
});
|
||||
|
||||
it("calls fetchSchedules after delete", async () => {
|
||||
setupLoad([schedule()]);
|
||||
mockDel.mockResolvedValue({});
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /delete schedule/i }));
|
||||
await flush();
|
||||
confirmDialogState.onConfirm?.();
|
||||
await flush();
|
||||
expect(mockGet).toHaveBeenCalledWith("/workspaces/ws-1/schedules");
|
||||
});
|
||||
|
||||
it("closes ConfirmDialog when cancel is called", async () => {
|
||||
setupLoad([schedule()]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /delete schedule/i }));
|
||||
await flush();
|
||||
expect(confirmDialogState.open).toBe(true);
|
||||
confirmDialogState.onCancel?.();
|
||||
await flush();
|
||||
expect(confirmDialogState.open).toBe(false);
|
||||
});
|
||||
|
||||
it("shows error when delete fails", async () => {
|
||||
setupLoad([schedule()]);
|
||||
mockDel.mockRejectedValue(new Error("delete failed"));
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /delete schedule/i }));
|
||||
await flush();
|
||||
confirmDialogState.onConfirm?.();
|
||||
await flush();
|
||||
expect(screen.getByText(/delete failed/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Run Now ──────────────────────────────────────────────────────────────────
|
||||
|
||||
it("calls POST /schedules/:id/run and then POST /a2a when Run Now is clicked", async () => {
|
||||
setupLoad([schedule()]);
|
||||
mockPost
|
||||
.mockResolvedValueOnce({ prompt: "Run the security scan and report findings" })
|
||||
.mockResolvedValueOnce({});
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /run schedule/i }));
|
||||
await flush();
|
||||
expect(mockPost).toHaveBeenNthCalledWith(1, "/workspaces/ws-1/schedules/sch-1/run", {});
|
||||
expect(mockPost).toHaveBeenNthCalledWith(2, "/workspaces/ws-1/a2a", expect.objectContaining({ method: "message/send" }));
|
||||
});
|
||||
|
||||
it("shows error when run now fails", async () => {
|
||||
setupLoad([schedule()]);
|
||||
mockPost.mockRejectedValue(new Error("run failed"));
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /run schedule/i }));
|
||||
await flush();
|
||||
// handleRunNow uses hardcoded "Failed to run schedule" on error
|
||||
expect(screen.getByText(/Failed to run schedule/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Create form ──────────────────────────────────────────────────────────────
|
||||
|
||||
it("shows create form when + Add Schedule is clicked", async () => {
|
||||
setupLoad([]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
expect(screen.getByLabelText("Schedule name")).toBeTruthy();
|
||||
expect(screen.getByLabelText("Cron Expression")).toBeTruthy();
|
||||
expect(screen.getByLabelText("Prompt / Task")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("pre-fills default cron (0 9 * * *) and timezone (UTC)", async () => {
|
||||
setupLoad([]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
expect((screen.getByLabelText("Cron Expression") as HTMLInputElement).value).toBe("0 9 * * *");
|
||||
expect((screen.getByLabelText("Timezone") as HTMLSelectElement).value).toBe("UTC");
|
||||
});
|
||||
|
||||
it("submit button is disabled when cron or prompt is empty", async () => {
|
||||
setupLoad([]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
const submitBtn = screen.getByRole("button", { name: /create/i });
|
||||
expect((submitBtn as HTMLButtonElement).disabled).toBe(true);
|
||||
});
|
||||
|
||||
it("submit button is enabled when cron and prompt are filled", async () => {
|
||||
setupLoad([]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
typeIn(screen.getByLabelText("Prompt / Task") as HTMLElement, "Run a task");
|
||||
await flush();
|
||||
const submitBtn = screen.getByRole("button", { name: /create/i });
|
||||
expect((submitBtn as HTMLButtonElement).disabled).toBe(false);
|
||||
});
|
||||
|
||||
it("POSTs correct payload when creating a schedule", async () => {
|
||||
setupLoad([]);
|
||||
mockPost.mockResolvedValue({});
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
typeIn(screen.getByLabelText("Schedule name") as HTMLElement, "Morning Report");
|
||||
typeIn(screen.getByLabelText("Cron Expression") as HTMLElement, "0 8 * * *");
|
||||
typeIn(screen.getByLabelText("Prompt / Task") as HTMLElement, "Generate the morning report");
|
||||
await flush();
|
||||
act(() => { screen.getByRole("button", { name: /create/i }).click(); });
|
||||
await flush();
|
||||
await waitFor(() => {
|
||||
expect(screen.queryByRole("button", { name: /cancel/i })).not.toBeTruthy();
|
||||
});
|
||||
expect(mockPost).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/schedules",
|
||||
expect.objectContaining({
|
||||
name: "Morning Report",
|
||||
cron_expr: "0 8 * * *",
|
||||
timezone: "UTC",
|
||||
prompt: "Generate the morning report",
|
||||
enabled: true,
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it("closes form and refreshes after successful create", async () => {
|
||||
setupLoad([]);
|
||||
mockPost.mockResolvedValue({});
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
typeIn(screen.getByLabelText("Prompt / Task") as HTMLElement, "Run a task");
|
||||
await flush();
|
||||
act(() => { screen.getByRole("button", { name: /create/i }).click(); });
|
||||
await flush();
|
||||
await waitFor(() => {
|
||||
expect(screen.queryByLabelText("Schedule name")).not.toBeTruthy();
|
||||
});
|
||||
expect(mockGet).toHaveBeenCalledWith("/workspaces/ws-1/schedules");
|
||||
});
|
||||
|
||||
it("shows error message when create fails", async () => {
|
||||
setupLoad([]);
|
||||
mockPost.mockRejectedValue(new Error("validation failed"));
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
typeIn(screen.getByLabelText("Prompt / Task") as HTMLElement, "Run a task");
|
||||
await flush();
|
||||
act(() => { screen.getByRole("button", { name: /create/i }).click(); });
|
||||
await flush();
|
||||
expect(screen.getByText(/validation failed/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("closes form when Cancel is clicked", async () => {
|
||||
setupLoad([]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
expect(screen.getByLabelText("Schedule name")).toBeTruthy();
|
||||
act(() => { screen.getByRole("button", { name: /cancel/i }).click(); });
|
||||
await flush();
|
||||
await waitFor(() => {
|
||||
expect(screen.queryByLabelText("Schedule name")).not.toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
// ── Edit form ────────────────────────────────────────────────────────────────
|
||||
|
||||
it("opens edit form pre-filled with schedule data when Edit is clicked", async () => {
|
||||
setupLoad([schedule({ name: "Nightly Backup", cron_expr: "0 2 * * *" })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /edit schedule/i }));
|
||||
await flush();
|
||||
expect((screen.getByLabelText("Schedule name") as HTMLInputElement).value).toBe("Nightly Backup");
|
||||
expect((screen.getByLabelText("Cron Expression") as HTMLInputElement).value).toBe("0 2 * * *");
|
||||
});
|
||||
|
||||
it("shows 'Update' button in edit mode", async () => {
|
||||
setupLoad([schedule()]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /edit schedule/i }));
|
||||
await flush();
|
||||
expect(screen.getByRole("button", { name: /update/i })).toBeTruthy();
|
||||
});
|
||||
|
||||
it("PATCHes correct payload when updating a schedule", async () => {
|
||||
setupLoad([schedule()]);
|
||||
mockPatch.mockResolvedValue({});
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /edit schedule/i }));
|
||||
await flush();
|
||||
typeIn(screen.getByLabelText("Schedule name") as HTMLElement, "Updated Name");
|
||||
typeIn(screen.getByLabelText("Prompt / Task") as HTMLElement, "New prompt");
|
||||
await flush();
|
||||
act(() => { screen.getByRole("button", { name: /update/i }).click(); });
|
||||
await flush();
|
||||
await waitFor(() => {
|
||||
expect(screen.queryByRole("button", { name: /cancel/i })).not.toBeTruthy();
|
||||
});
|
||||
expect(mockPatch).toHaveBeenCalledWith(
|
||||
"/workspaces/ws-1/schedules/sch-1",
|
||||
expect.objectContaining({
|
||||
name: "Updated Name",
|
||||
cron_expr: "0 9 * * *",
|
||||
timezone: "UTC",
|
||||
prompt: "New prompt",
|
||||
enabled: true,
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it("form reset clears name, cron, prompt, and enabled", async () => {
|
||||
setupLoad([schedule()]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
// Open + add schedule form
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
typeIn(screen.getByLabelText("Schedule name") as HTMLElement, "Temp Schedule");
|
||||
typeIn(screen.getByLabelText("Cron Expression") as HTMLElement, "*/15 * * * *");
|
||||
typeIn(screen.getByLabelText("Prompt / Task") as HTMLElement, "Temporary task");
|
||||
await flush();
|
||||
// Cancel
|
||||
act(() => { screen.getByRole("button", { name: /cancel/i }).click(); });
|
||||
await flush();
|
||||
// Open again — should be reset
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
expect((screen.getByLabelText("Schedule name") as HTMLInputElement).value).toBe("");
|
||||
expect((screen.getByLabelText("Cron Expression") as HTMLInputElement).value).toBe("0 9 * * *");
|
||||
expect((screen.getByLabelText("Prompt / Task") as HTMLTextAreaElement).value).toBe("");
|
||||
});
|
||||
|
||||
// ── Error state ──────────────────────────────────────────────────────────────
|
||||
|
||||
it("shows error banner when GET fails", async () => {
|
||||
mockGet.mockRejectedValue(new Error("network error"));
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
// Component now sets error state on GET failure
|
||||
expect(screen.getByText(/network error/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows generic error when GET rejects with non-Error", async () => {
|
||||
mockGet.mockRejectedValue("unknown failure");
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("unknown failure")).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Auto-refresh ────────────────────────────────────────────────────────────
|
||||
|
||||
it("sets up auto-refresh interval of 10 seconds", async () => {
|
||||
const setIntervalSpy = vi.spyOn(globalThis, "setInterval");
|
||||
setupLoad([schedule()]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(setIntervalSpy).toHaveBeenCalledWith(expect.any(Function), 10000);
|
||||
setIntervalSpy.mockRestore();
|
||||
});
|
||||
|
||||
it("clears the auto-refresh interval on unmount", async () => {
|
||||
const clearIntervalSpy = vi.spyOn(globalThis, "clearInterval");
|
||||
const setIntervalSpy = vi.spyOn(globalThis, "setInterval");
|
||||
setupLoad([schedule()]);
|
||||
const { unmount } = render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(clearIntervalSpy).not.toHaveBeenCalled();
|
||||
unmount();
|
||||
expect(clearIntervalSpy).toHaveBeenCalled();
|
||||
setIntervalSpy.mockRestore();
|
||||
clearIntervalSpy.mockRestore();
|
||||
});
|
||||
|
||||
// ── Misc ────────────────────────────────────────────────────────────────────
|
||||
|
||||
it("shows no timezone suffix when timezone is UTC", async () => {
|
||||
setupLoad([schedule({ timezone: "UTC" })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.queryByText(/\(UTC\)/)).not.toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows timezone suffix when non-UTC", async () => {
|
||||
setupLoad([schedule({ timezone: "America/New_York" })]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/\(America\/New_York\)/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("checkbox toggles formEnabled state", async () => {
|
||||
setupLoad([]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
const checkbox = screen.getByRole("checkbox");
|
||||
expect((checkbox as HTMLInputElement).checked).toBe(true);
|
||||
fireEvent.click(checkbox);
|
||||
await flush();
|
||||
expect((checkbox as HTMLInputElement).checked).toBe(false);
|
||||
});
|
||||
|
||||
it("timezone select updates formTimezone", async () => {
|
||||
setupLoad([]);
|
||||
render(<ScheduleTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
fireEvent.click(screen.getByRole("button", { name: /\+ add schedule/i }));
|
||||
await flush();
|
||||
fireEvent.change(screen.getByLabelText("Timezone"), { target: { value: "America/Los_Angeles" } });
|
||||
await flush();
|
||||
expect((screen.getByLabelText("Timezone") as HTMLSelectElement).value).toBe("America/Los_Angeles");
|
||||
});
|
||||
});
|
||||
@@ -1,408 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for TracesTab — Langfuse trace viewer.
|
||||
*
|
||||
* Coverage:
|
||||
* - Loading state
|
||||
* - Error state
|
||||
* - Empty state (no traces)
|
||||
* - Trace list rendering
|
||||
* - Expand/collapse rows with aria attributes
|
||||
* - Status dot colors (ERROR vs success)
|
||||
* - Latency formatting (ms vs seconds)
|
||||
* - Token count display
|
||||
* - Cost display
|
||||
* - Input/output rendering (string and object)
|
||||
* - Refresh button
|
||||
* - formatTime relative timestamps
|
||||
* - "How to enable tracing" collapsed hint
|
||||
*/
|
||||
import React from "react";
|
||||
import { render, screen, fireEvent, cleanup, act } from "@testing-library/react";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { TracesTab } from "../TracesTab";
|
||||
|
||||
const mockGet = vi.hoisted(() => vi.fn<[], Promise<unknown>>());
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
api: { get: mockGet },
|
||||
}));
|
||||
|
||||
// ─── Fixtures ─────────────────────────────────────────────────────────────────
|
||||
|
||||
const TRACE_FIXTURE = {
|
||||
id: "trace-abc123",
|
||||
name: "security-scan",
|
||||
timestamp: new Date(Date.now() - 60000).toISOString(),
|
||||
latency: 450,
|
||||
input: { query: "scan for vulnerabilities" },
|
||||
output: { result: "No issues found" },
|
||||
status: "success",
|
||||
totalCost: 0.00234,
|
||||
usage: { input: 120, output: 85, total: 205 },
|
||||
};
|
||||
|
||||
function trace(overrides: Partial<typeof TRACE_FIXTURE> = {}): typeof TRACE_FIXTURE {
|
||||
return { ...TRACE_FIXTURE, ...overrides };
|
||||
}
|
||||
|
||||
// ─── Helpers ───────────────────────────────────────────────────────────────────
|
||||
|
||||
async function flush() {
|
||||
await act(async () => { await Promise.resolve(); });
|
||||
}
|
||||
|
||||
// The trace row button's accessible name is "{name} {relativeTime} {latency}{tokCount}".
|
||||
// Filter all buttons to find the trace row buttons.
|
||||
function getTraceButtons() {
|
||||
return screen
|
||||
.getAllByRole("button")
|
||||
.filter((b) => b.getAttribute("aria-controls")?.startsWith("trace-detail-"));
|
||||
}
|
||||
|
||||
// ─── Tests ─────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("TracesTab", () => {
|
||||
beforeEach(() => {
|
||||
mockGet.mockReset();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
// ── Loading ─────────────────────────────────────────────────────────────────
|
||||
|
||||
it("shows loading state when traces are being fetched", async () => {
|
||||
mockGet.mockImplementation(() => new Promise(() => {}));
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await act(async () => { /* flush initial render */ });
|
||||
expect(screen.getByText("Loading traces...")).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Error ──────────────────────────────────────────────────────────────────
|
||||
|
||||
it("shows error banner when GET /traces rejects", async () => {
|
||||
mockGet.mockRejectedValue(new Error("gateway timeout"));
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/gateway timeout/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows 'Failed to load traces' when GET rejects with non-Error", async () => {
|
||||
mockGet.mockRejectedValue("unknown");
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/Failed to load traces/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Empty state ───────────────────────────────────────────────────────────
|
||||
|
||||
it("shows empty state when API returns empty list", async () => {
|
||||
mockGet.mockResolvedValue({ data: [] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("No traces yet")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows 'How to enable tracing' hint under empty state", async () => {
|
||||
mockGet.mockResolvedValue({ data: [] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/how to enable tracing/i)).toBeTruthy();
|
||||
expect(screen.getByText(/LANGFUSE_HOST/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("hides empty state when error is present", async () => {
|
||||
mockGet.mockRejectedValue(new Error("error"));
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.queryByText("No traces yet")).toBeFalsy();
|
||||
});
|
||||
|
||||
// ── Trace list ─────────────────────────────────────────────────────────────
|
||||
|
||||
it("renders trace name in the list", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ name: "my-trace" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("my-trace")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows trace count in header", async () => {
|
||||
mockGet.mockResolvedValue({
|
||||
data: [
|
||||
trace({ id: "t1" }),
|
||||
trace({ id: "t2" }),
|
||||
trace({ id: "t3" }),
|
||||
],
|
||||
});
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("3 traces")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("renders multiple traces", async () => {
|
||||
mockGet.mockResolvedValue({
|
||||
data: [
|
||||
trace({ id: "t1", name: "trace-alpha" }),
|
||||
trace({ id: "t2", name: "trace-beta" }),
|
||||
],
|
||||
});
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("trace-alpha")).toBeTruthy();
|
||||
expect(screen.getByText("trace-beta")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows 'trace' when name is empty", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ name: "" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("trace")).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Status dot ─────────────────────────────────────────────────────────────
|
||||
|
||||
it("applies bg-bad to ERROR traces", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ status: "ERROR" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const dot = getTraceButtons()[0].querySelector("div[class*='rounded-full']");
|
||||
expect(dot?.className).toContain("bg-bad");
|
||||
});
|
||||
|
||||
it("applies bg-good to success traces", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ status: "success" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const dot = getTraceButtons()[0].querySelector("div[class*='rounded-full']");
|
||||
expect(dot?.className).toContain("bg-good");
|
||||
});
|
||||
|
||||
// ── Latency formatting ──────────────────────────────────────────────────────
|
||||
|
||||
it("shows latency in milliseconds when < 1000ms", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ latency: 450 })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("450ms")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows latency in seconds when >= 1000ms", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ latency: 2500 })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("2.5s")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("hides latency when null", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ latency: undefined })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.queryByText(/ms/)).toBeFalsy();
|
||||
});
|
||||
|
||||
// ── Token count ────────────────────────────────────────────────────────────
|
||||
|
||||
it("shows total token count from usage.total", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ usage: { input: 100, output: 50, total: 150 } })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("150 tok")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("hides token count when usage is undefined", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ usage: undefined })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.queryByText(/tok/)).toBeFalsy();
|
||||
});
|
||||
|
||||
// ── Expand/collapse ─────────────────────────────────────────────────────────
|
||||
|
||||
it("shows '▶' when trace is collapsed", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace()] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText("▶")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows '▼' when trace is expanded", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace()] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
act(() => { getTraceButtons()[0].click(); });
|
||||
await flush();
|
||||
expect(screen.getByText("▼")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows '▼' when all traces are collapsed", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace()] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.queryByText("▼")).toBeFalsy();
|
||||
expect(screen.getByText("▶")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows input/output panel when trace is expanded", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace()] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
act(() => { getTraceButtons()[0].click(); });
|
||||
await flush();
|
||||
expect(screen.getByText(/INPUT/i)).toBeTruthy();
|
||||
expect(screen.getByText(/OUTPUT/i)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows JSON stringified input when input is an object", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ input: { query: "test" } })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
act(() => { getTraceButtons()[0].click(); });
|
||||
await flush();
|
||||
expect(screen.getByText(/"query": "test"/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows raw string when input is a string", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ input: "plain text input" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
act(() => { getTraceButtons()[0].click(); });
|
||||
await flush();
|
||||
expect(screen.getByText("plain text input")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows trace ID in expanded panel", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ id: "trace-xyz-999" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
act(() => { getTraceButtons()[0].click(); });
|
||||
await flush();
|
||||
expect(screen.getByText("trace-xyz-999")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows cost when totalCost is present", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ totalCost: 0.001234 })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
act(() => { getTraceButtons()[0].click(); });
|
||||
await flush();
|
||||
expect(screen.getByText(/\$0.001234/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("hides cost section when totalCost is null", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ totalCost: undefined })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
act(() => { getTraceButtons()[0].click(); });
|
||||
await flush();
|
||||
expect(screen.queryByText(/cost/i)).toBeFalsy();
|
||||
});
|
||||
|
||||
it("has aria-expanded=true on expanded row", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace()] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const btn = getTraceButtons()[0];
|
||||
expect(btn.getAttribute("aria-expanded")).toBe("false");
|
||||
act(() => { btn.click(); });
|
||||
await flush();
|
||||
expect(btn.getAttribute("aria-expanded")).toBe("true");
|
||||
});
|
||||
|
||||
it("has aria-expanded=false on collapsed row", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace()] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(getTraceButtons()[0].getAttribute("aria-expanded")).toBe("false");
|
||||
});
|
||||
|
||||
it("has aria-controls linking row to its detail panel", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ id: "trace-abc123" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(getTraceButtons()[0].getAttribute("aria-controls")).toBe("trace-detail-trace-abc123");
|
||||
});
|
||||
|
||||
// ── Refresh ────────────────────────────────────────────────────────────────
|
||||
|
||||
it("Refresh button triggers a new GET", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace()] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
mockGet.mockClear();
|
||||
fireEvent.click(screen.getByRole("button", { name: /refresh/i }));
|
||||
await flush();
|
||||
expect(mockGet).toHaveBeenCalledWith("/workspaces/ws-1/traces");
|
||||
});
|
||||
|
||||
// ── formatTime ─────────────────────────────────────────────────────────────
|
||||
|
||||
it("shows 'Xs ago' for traces under 1 minute", async () => {
|
||||
const timestamp = new Date(Date.now() - 30_000).toISOString();
|
||||
mockGet.mockResolvedValue({ data: [trace({ timestamp, id: "t-30s" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
// 30s ago
|
||||
expect(screen.getByText(/\d+s ago/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows 'Xm ago' for traces under 1 hour", async () => {
|
||||
const timestamp = new Date(Date.now() - 120_000).toISOString();
|
||||
mockGet.mockResolvedValue({ data: [trace({ timestamp, id: "t-2m" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/\dm ago/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows 'Xh ago' for traces under 1 day", async () => {
|
||||
const timestamp = new Date(Date.now() - 3_600_000).toISOString();
|
||||
mockGet.mockResolvedValue({ data: [trace({ timestamp, id: "t-1h" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(/\dh ago/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("shows locale date for traces older than 24 hours", async () => {
|
||||
const oldDate = new Date(Date.now() - 172_800_000);
|
||||
mockGet.mockResolvedValue({ data: [trace({ timestamp: oldDate.toISOString(), id: "t-old" })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
expect(screen.getByText(oldDate.toLocaleDateString())).toBeTruthy();
|
||||
});
|
||||
|
||||
// ── Edge cases ─────────────────────────────────────────────────────────────
|
||||
|
||||
it("handles traces with no input or output", async () => {
|
||||
mockGet.mockResolvedValue({ data: [trace({ input: undefined, output: undefined })] });
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
act(() => { getTraceButtons()[0].click(); });
|
||||
await flush();
|
||||
expect(screen.queryByText(/INPUT/i)).toBeFalsy();
|
||||
expect(screen.queryByText(/OUTPUT/i)).toBeFalsy();
|
||||
});
|
||||
|
||||
it("shows only one expanded trace at a time", async () => {
|
||||
mockGet.mockResolvedValue({
|
||||
data: [
|
||||
trace({ id: "t1", name: "Alpha" }),
|
||||
trace({ id: "t2", name: "Beta" }),
|
||||
],
|
||||
});
|
||||
render(<TracesTab workspaceId="ws-1" />);
|
||||
await flush();
|
||||
const [btn1, btn2] = getTraceButtons();
|
||||
act(() => { btn1.click(); });
|
||||
await flush();
|
||||
expect(btn1.getAttribute("aria-expanded")).toBe("true");
|
||||
expect(btn2.getAttribute("aria-expanded")).toBe("false");
|
||||
act(() => { btn2.click(); });
|
||||
await flush();
|
||||
expect(btn1.getAttribute("aria-expanded")).toBe("false");
|
||||
expect(btn2.getAttribute("aria-expanded")).toBe("true");
|
||||
});
|
||||
});
|
||||
@@ -1,140 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Unit tests for extractSkills — pure helper from SkillsTab.
|
||||
*
|
||||
* Covers: null card, non-array skills, empty skills, full skill entries
|
||||
* (id, name, description, tags, examples), id-only fallback, name-only
|
||||
* fallback, string coercion, array coercion for tags/examples,
|
||||
* filtering entries with no id after coercion, empty string id (filtered).
|
||||
*/
|
||||
import { describe, it, expect } from "vitest";
|
||||
import { extractSkills } from "../SkillsTab";
|
||||
|
||||
describe("extractSkills", () => {
|
||||
it("returns [] for null card", () => {
|
||||
expect(extractSkills(null)).toEqual([]);
|
||||
});
|
||||
|
||||
it("returns [] when card.skills is not an array", () => {
|
||||
expect(extractSkills({ skills: undefined })).toEqual([]);
|
||||
expect(extractSkills({ skills: "not-an-array" })).toEqual([]);
|
||||
expect(extractSkills({ skills: { id: "x" } })).toEqual([]);
|
||||
});
|
||||
|
||||
it("returns [] for empty skills array", () => {
|
||||
expect(extractSkills({ skills: [] })).toEqual([]);
|
||||
});
|
||||
|
||||
it("maps a fully-populated skill entry", () => {
|
||||
const card = {
|
||||
skills: [
|
||||
{
|
||||
id: "code_search",
|
||||
name: "Code Search",
|
||||
description: "Semantic code search",
|
||||
tags: ["search", "code"],
|
||||
examples: ["Find unused exports", "Search by AST pattern"],
|
||||
},
|
||||
],
|
||||
};
|
||||
expect(extractSkills(card)).toEqual([
|
||||
{
|
||||
id: "code_search",
|
||||
name: "Code Search",
|
||||
description: "Semantic code search",
|
||||
tags: ["search", "code"],
|
||||
examples: ["Find unused exports", "Search by AST pattern"],
|
||||
},
|
||||
]);
|
||||
});
|
||||
|
||||
it("uses name as id when id is absent", () => {
|
||||
const card = { skills: [{ name: "web_scraper" }] };
|
||||
expect(extractSkills(card)).toEqual([
|
||||
{ id: "web_scraper", name: "web_scraper", description: "", tags: [], examples: [] },
|
||||
]);
|
||||
});
|
||||
|
||||
it("uses id as name when name is absent", () => {
|
||||
const card = { skills: [{ id: "legacy_skill" }] };
|
||||
expect(extractSkills(card)).toEqual([
|
||||
{ id: "legacy_skill", name: "legacy_skill", description: "", tags: [], examples: [] },
|
||||
]);
|
||||
});
|
||||
|
||||
it("filters out entries with neither id nor name", () => {
|
||||
// id: String(undefined || undefined || "") → "" → filtered (id.length = 0)
|
||||
const card = { skills: [{ description: "orphan entry" }] };
|
||||
expect(extractSkills(card)).toEqual([]);
|
||||
});
|
||||
|
||||
it("filters out entries with no id after string coercion", () => {
|
||||
// id resolves to "" after String(undefined || null || {})
|
||||
const card = { skills: [{ id: null, name: null }] };
|
||||
expect(extractSkills(card)).toEqual([]);
|
||||
});
|
||||
|
||||
it("filters out entries with empty-string id", () => {
|
||||
const card = { skills: [{ id: "", name: "" }] };
|
||||
expect(extractSkills(card)).toEqual([]);
|
||||
});
|
||||
|
||||
it("coerces numeric tags to strings", () => {
|
||||
const card = { skills: [{ id: "x", tags: [1, "two", 3] }] };
|
||||
expect(extractSkills(card)).toEqual([
|
||||
{ id: "x", name: "x", description: "", tags: ["1", "two", "3"], examples: [] },
|
||||
]);
|
||||
});
|
||||
|
||||
it("coerces non-array tags to empty array", () => {
|
||||
const card = { skills: [{ id: "x", tags: "not-an-array" }] };
|
||||
expect(extractSkills(card)).toEqual([
|
||||
{ id: "x", name: "x", description: "", tags: [], examples: [] },
|
||||
]);
|
||||
});
|
||||
|
||||
it("coerces non-array examples to empty array", () => {
|
||||
const card = { skills: [{ id: "x", examples: 42 }] };
|
||||
expect(extractSkills(card)).toEqual([
|
||||
{ id: "x", name: "x", description: "", tags: [], examples: [] },
|
||||
]);
|
||||
});
|
||||
|
||||
// NOTE: extractSkills uses `String(skill.description || "")` — falsy values
|
||||
// (0, null, false) fall through to "", NOT to their string form.
|
||||
it("returns '' for falsy description values (0, null, false)", () => {
|
||||
const card = { skills: [{ id: "x", description: 0 }] };
|
||||
expect(extractSkills(card)).toEqual([
|
||||
{ id: "x", name: "x", description: "", tags: [], examples: [] },
|
||||
]);
|
||||
});
|
||||
|
||||
it("handles mixed valid/invalid entries", () => {
|
||||
const card = {
|
||||
skills: [
|
||||
{ id: "valid_one", name: "One" },
|
||||
{ name: "named_only" },
|
||||
{ description: "orphan" }, // filtered — id becomes ""
|
||||
{ id: "valid_two", examples: ["a", "b"] },
|
||||
],
|
||||
};
|
||||
expect(extractSkills(card)).toEqual([
|
||||
{ id: "valid_one", name: "One", description: "", tags: [], examples: [] },
|
||||
{ id: "named_only", name: "named_only", description: "", tags: [], examples: [] },
|
||||
{ id: "valid_two", name: "valid_two", description: "", tags: [], examples: ["a", "b"] },
|
||||
]);
|
||||
});
|
||||
|
||||
it("handles a realistic agent card with multiple skills", () => {
|
||||
const card = {
|
||||
skills: [
|
||||
{ id: "web_search", name: "Web Search", description: "Search the web", tags: ["search"], examples: ["Latest news"] },
|
||||
{ id: "file_read", name: "Read Files", description: "Read from disk", tags: ["io"], examples: [] },
|
||||
],
|
||||
};
|
||||
const result = extractSkills(card);
|
||||
expect(result).toHaveLength(2);
|
||||
expect(result[0].id).toBe("web_search");
|
||||
expect(result[1].tags).toEqual(["io"]);
|
||||
});
|
||||
});
|
||||
@@ -1,95 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Unit tests for getSkills — pure helper from DetailsTab.
|
||||
*
|
||||
* Covers: null card, non-array skills, empty skills, id-only entries,
|
||||
* name-only entries (id derives from name), entries with description,
|
||||
* entries with neither id nor name (filtered out), mixed entries.
|
||||
*/
|
||||
import { describe, it, expect } from "vitest";
|
||||
import { getSkills } from "../DetailsTab";
|
||||
|
||||
describe("getSkills", () => {
|
||||
it("returns [] for null card", () => {
|
||||
expect(getSkills(null)).toEqual([]);
|
||||
});
|
||||
|
||||
it("returns [] when card.skills is not an array", () => {
|
||||
expect(getSkills({ skills: undefined })).toEqual([]);
|
||||
expect(getSkills({ skills: "not-an-array" })).toEqual([]);
|
||||
expect(getSkills({ skills: { id: "x" } })).toEqual([]);
|
||||
});
|
||||
|
||||
it("returns [] for empty skills array", () => {
|
||||
expect(getSkills({ skills: [] })).toEqual([]);
|
||||
});
|
||||
|
||||
it("maps skill with id and description", () => {
|
||||
const card = { skills: [{ id: "code_search", description: "Find code patterns" }] };
|
||||
expect(getSkills(card)).toEqual([{ id: "code_search", description: "Find code patterns" }]);
|
||||
});
|
||||
|
||||
it("maps skill with id only (description absent)", () => {
|
||||
const card = { skills: [{ id: "code_search" }] };
|
||||
expect(getSkills(card)).toEqual([{ id: "code_search", description: undefined }]);
|
||||
});
|
||||
|
||||
it("derives id from name when id is absent", () => {
|
||||
const card = { skills: [{ name: "web_scraper" }] };
|
||||
expect(getSkills(card)).toEqual([{ id: "web_scraper" }]);
|
||||
});
|
||||
|
||||
it("maps description when present", () => {
|
||||
const card = { skills: [{ id: "file_write", description: "Writes files to disk" }] };
|
||||
expect(getSkills(card)).toEqual([{ id: "file_write", description: "Writes files to disk" }]);
|
||||
});
|
||||
|
||||
it("returns description as undefined when skill has no description", () => {
|
||||
const card = { skills: [{ id: "noop_skill" }] };
|
||||
const result = getSkills(card);
|
||||
// The map always includes description; it's undefined when absent
|
||||
expect(result).toEqual([{ id: "noop_skill", description: undefined }]);
|
||||
});
|
||||
|
||||
it("filters out skills with neither id nor name", () => {
|
||||
// id: String(undefined || undefined || "") → "" → filtered
|
||||
const card = { skills: [{ description: "loner" }] };
|
||||
expect(getSkills(card)).toEqual([]);
|
||||
});
|
||||
|
||||
it("handles mixed valid/invalid entries", () => {
|
||||
const card = {
|
||||
skills: [
|
||||
{ id: "valid_one" },
|
||||
{ name: "named_skill" },
|
||||
{ description: "orphaned" }, // filtered
|
||||
{ id: "valid_two", description: "Has both" },
|
||||
],
|
||||
};
|
||||
expect(getSkills(card)).toEqual([
|
||||
{ id: "valid_one", description: undefined },
|
||||
{ id: "named_skill", description: undefined },
|
||||
{ id: "valid_two", description: "Has both" },
|
||||
]);
|
||||
});
|
||||
|
||||
it("handles string coercion for numeric ids/names", () => {
|
||||
const card = { skills: [{ id: 42, name: "numeric_id" }] };
|
||||
expect(getSkills(card)).toEqual([{ id: "42" }]);
|
||||
});
|
||||
|
||||
it("uses id over name when both are present", () => {
|
||||
const card = { skills: [{ id: "priority_id", name: "fallback_name" }] };
|
||||
expect(getSkills(card)).toEqual([{ id: "priority_id", description: undefined }]);
|
||||
});
|
||||
|
||||
it("omits description when it is falsy (0 is falsy in JS)", () => {
|
||||
// The implementation uses `s.description ?` — 0 is falsy, so it's treated
|
||||
// as absent and undefined is returned. Non-zero numbers coerce fine.
|
||||
const cardZero = { skills: [{ id: "x", description: 0 }] };
|
||||
expect(getSkills(cardZero)).toEqual([{ id: "x", description: undefined }]);
|
||||
|
||||
const cardNum = { skills: [{ id: "x", description: 42 }] };
|
||||
expect(getSkills(cardNum)).toEqual([{ id: "x", description: "42" }]);
|
||||
});
|
||||
});
|
||||
@@ -1,300 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* AttachmentAudio — inline HTML5 <audio controls> player for chat attachments.
|
||||
*
|
||||
* Per RFC #2991 PR-2: platform-auth URIs fetch bytes → Blob → ObjectURL;
|
||||
* external URIs use the raw URL directly. State machine: idle → loading →
|
||||
* ready/error. Loading skeleton (280×40) shown while fetching. Error falls
|
||||
* back to AttachmentChip. No lightbox (unlike video/image). Blob URL cleaned
|
||||
* up on unmount.
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs for assertions.
|
||||
*
|
||||
* Covers:
|
||||
* - Renders loading skeleton (280×40) with aria-label while fetching
|
||||
* - Renders <audio controls> with correct src when ready
|
||||
* - tone=user applies blue/accent classes
|
||||
* - tone=agent applies neutral border classes
|
||||
* - Error state renders AttachmentChip fallback
|
||||
* - External URI uses direct href without auth fetch
|
||||
* - Cleans up blob URL on unmount
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, fireEvent, render, waitFor } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { AttachmentAudio } from "../AttachmentAudio";
|
||||
import type { ChatAttachment } from "../types";
|
||||
|
||||
// ─── Mocks ────────────────────────────────────────────────────────────────────
|
||||
|
||||
const mockResolveAttachmentHref = vi.fn<(id: string, uri: string) => string>(
|
||||
(id, uri) => `https://api.moleculesai.app/attachments/${uri}`,
|
||||
);
|
||||
const mockIsPlatformAttachment = vi.fn<(uri: string) => boolean>(() => true);
|
||||
|
||||
vi.mock("../uploads", () => ({
|
||||
isPlatformAttachment: (uri: string) => mockIsPlatformAttachment(uri),
|
||||
resolveAttachmentHref: (id: string, uri: string) =>
|
||||
mockResolveAttachmentHref(id, uri),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
platformAuthHeaders: () => ({ Authorization: "Bearer test-token" }),
|
||||
}));
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
function makeAttachment(name: string, size?: number): ChatAttachment {
|
||||
return { name, uri: `workspace:/tmp/${name}`, size };
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
mockIsPlatformAttachment.mockReturnValue(true);
|
||||
mockResolveAttachmentHref.mockReturnValue(
|
||||
(id: string, uri: string) => `https://api.moleculesai.app/attachments/${uri}`,
|
||||
);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
});
|
||||
|
||||
// ─── Fetch mock helpers ───────────────────────────────────────────────────────
|
||||
|
||||
function mockFetchOk(body: string, contentType = "audio/mpeg") {
|
||||
const blob = new Blob([body], { type: contentType });
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({
|
||||
ok: true,
|
||||
status: 200,
|
||||
blob: () => Promise.resolve(blob),
|
||||
headers: new Map([["content-type", contentType]]),
|
||||
}) as unknown as Response,
|
||||
);
|
||||
}
|
||||
|
||||
function mockFetchError() {
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({ ok: false, status: 500 }) as unknown as Response,
|
||||
);
|
||||
}
|
||||
|
||||
// ─── Loading / idle state ─────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentAudio — loading/idle", () => {
|
||||
beforeEach(() => {
|
||||
mockFetchOk("audiodata");
|
||||
});
|
||||
|
||||
it("renders loading skeleton (280×40) with aria-label", () => {
|
||||
const att = makeAttachment("podcast.mp3", 1024 * 512);
|
||||
const { container } = render(
|
||||
<AttachmentAudio
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
const skeleton = container.querySelector('[aria-label]') as HTMLElement;
|
||||
expect(skeleton?.getAttribute("aria-label")).toContain("podcast.mp3");
|
||||
expect(skeleton?.getAttribute("aria-label")).toContain("Loading");
|
||||
// Skeleton dimensions
|
||||
expect(skeleton?.style.width).toBe("280px");
|
||||
expect(skeleton?.style.height).toBe("40px");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Ready state ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentAudio — ready", () => {
|
||||
beforeEach(() => {
|
||||
mockFetchOk("audiodata");
|
||||
});
|
||||
|
||||
it("renders <audio controls> with blob src when ready", async () => {
|
||||
const att = makeAttachment("podcast.mp3", 1024 * 512);
|
||||
render(
|
||||
<AttachmentAudio
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const audio = document.querySelector("audio");
|
||||
expect(audio).toBeTruthy();
|
||||
});
|
||||
const audio = document.querySelector("audio") as HTMLAudioElement;
|
||||
expect(audio.src).toMatch(/^blob:/);
|
||||
expect(audio.hasAttribute("controls")).toBe(true);
|
||||
});
|
||||
|
||||
it("renders filename label in ready state", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("episode-42.mp3");
|
||||
render(
|
||||
<AttachmentAudio
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("audio")).toBeTruthy();
|
||||
});
|
||||
// Filename should appear as a text span before the audio element
|
||||
const container = document.querySelector("div");
|
||||
expect(container?.textContent).toContain("episode-42.mp3");
|
||||
});
|
||||
|
||||
it("tone=user applies blue/accent border classes", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("podcast.mp3");
|
||||
const { container } = render(
|
||||
<AttachmentAudio
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("audio")).toBeTruthy();
|
||||
});
|
||||
// Use container.firstChild to target the component root div (not the render wrapper)
|
||||
const rootDiv = container.firstChild as HTMLElement;
|
||||
expect(rootDiv.className).toContain("border-blue-400");
|
||||
expect(rootDiv.className).toContain("accent-strong");
|
||||
});
|
||||
|
||||
it("tone=agent applies neutral border class (no blue)", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("podcast.mp3");
|
||||
const { container } = render(
|
||||
<AttachmentAudio
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("audio")).toBeTruthy();
|
||||
});
|
||||
const rootDiv = container.firstChild as HTMLElement;
|
||||
expect(rootDiv.className).not.toContain("border-blue-400");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Error state ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentAudio — error", () => {
|
||||
it("renders AttachmentChip fallback when fetch fails", async () => {
|
||||
mockFetchError();
|
||||
const onDownload = vi.fn();
|
||||
const att = makeAttachment("broken.mp3", 256);
|
||||
render(
|
||||
<AttachmentAudio
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={onDownload}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const chip = document.querySelector("button");
|
||||
expect(chip).toBeTruthy();
|
||||
expect(chip?.textContent).toContain("broken.mp3");
|
||||
});
|
||||
// Clicking the chip calls onDownload
|
||||
const chip = document.querySelector("button") as HTMLButtonElement;
|
||||
chip.click();
|
||||
expect(onDownload).toHaveBeenCalledWith(att);
|
||||
});
|
||||
|
||||
it("renders AttachmentChip when audio onError fires", async () => {
|
||||
mockFetchOk("audiodata");
|
||||
const onDownload = vi.fn();
|
||||
const att = makeAttachment("corrupt.mp3", 256);
|
||||
render(
|
||||
<AttachmentAudio
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={onDownload}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("audio")).toBeTruthy();
|
||||
});
|
||||
// Simulate audio onError
|
||||
const audio = document.querySelector("audio") as HTMLAudioElement;
|
||||
fireEvent(audio, new Event("error", { bubbles: false }));
|
||||
await vi.waitFor(() => {
|
||||
const chip = document.querySelector("button");
|
||||
expect(chip).toBeTruthy();
|
||||
expect(chip?.textContent).toContain("corrupt.mp3");
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
// ─── External URI ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentAudio — external URI", () => {
|
||||
it("skips auth fetch and uses direct href for external URIs", async () => {
|
||||
// Reset fetch so we can assert it was never called
|
||||
global.fetch = vi.fn();
|
||||
mockIsPlatformAttachment.mockReturnValue(false);
|
||||
mockResolveAttachmentHref.mockReturnValue("https://example.com/podcast.mp3");
|
||||
const att = makeAttachment("podcast.mp3");
|
||||
att.uri = "https://example.com/podcast.mp3";
|
||||
render(
|
||||
<AttachmentAudio
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
// Should skip loading skeleton and go straight to ready (external URL)
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("audio")).toBeTruthy();
|
||||
});
|
||||
const audio = document.querySelector("audio") as HTMLAudioElement;
|
||||
// Should be the direct href, not a blob
|
||||
expect(audio.src).toContain("example.com/podcast.mp3");
|
||||
// Fetch should never have been called for external (non-platform) attachments
|
||||
expect(global.fetch).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Cleanup ──────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentAudio — blob URL cleanup", () => {
|
||||
it("creates blob URL on mount and cleans up on unmount", async () => {
|
||||
mockIsPlatformAttachment.mockReturnValue(true);
|
||||
mockFetchOk("audiodata");
|
||||
const att = makeAttachment("podcast.mp3");
|
||||
const { unmount } = render(
|
||||
<AttachmentAudio
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("audio")).toBeTruthy();
|
||||
});
|
||||
const audio = document.querySelector("audio") as HTMLAudioElement;
|
||||
const blobUrl = audio.src;
|
||||
expect(blobUrl).toMatch(/^blob:/);
|
||||
unmount();
|
||||
// Audio element should be gone
|
||||
expect(document.querySelector("audio")).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -1,346 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* AttachmentImage — inline image thumbnail with click-to-fullscreen lightbox.
|
||||
*
|
||||
* Per RFC #2991 PR-1: platform-auth URIs fetch bytes → Blob → ObjectURL;
|
||||
* external URIs use the raw URL directly. State machine: idle → loading →
|
||||
* ready/error. Loading skeleton shown while fetching. Error falls back to
|
||||
* AttachmentChip. Blob URL cleaned up on unmount / re-run.
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs for assertions.
|
||||
*
|
||||
* Covers:
|
||||
* - Renders loading skeleton (240×180) with aria-label while fetching
|
||||
* - Renders <img> inside button with correct src when ready
|
||||
* - Lightbox opens on button click, closes on backdrop/escape
|
||||
* - Hover reveals filename overlay
|
||||
* - tone=user applies blue border class
|
||||
* - tone=agent applies neutral border class
|
||||
* - Error state renders AttachmentChip fallback
|
||||
* - External URI uses direct href without auth fetch
|
||||
* - Cleans up blob URL on unmount
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, fireEvent, render, waitFor } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { AttachmentImage } from "../AttachmentImage";
|
||||
import type { ChatAttachment } from "../types";
|
||||
|
||||
// ─── Mocks ────────────────────────────────────────────────────────────────────
|
||||
|
||||
const mockResolveAttachmentHref = vi.fn<(id: string, uri: string) => string>(
|
||||
(id, uri) => `https://api.moleculesai.app/attachments/${uri}`,
|
||||
);
|
||||
const mockIsPlatformAttachment = vi.fn<(uri: string) => boolean>(() => true);
|
||||
|
||||
vi.mock("../uploads", () => ({
|
||||
isPlatformAttachment: (uri: string) => mockIsPlatformAttachment(uri),
|
||||
resolveAttachmentHref: (id: string, uri: string) =>
|
||||
mockResolveAttachmentHref(id, uri),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
platformAuthHeaders: () => ({ Authorization: "Bearer test-token" }),
|
||||
}));
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
function makeAttachment(name: string, size?: number): ChatAttachment {
|
||||
return { name, uri: `workspace:/tmp/${name}`, size };
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
// Reset to known-good state for each test.
|
||||
mockIsPlatformAttachment.mockReturnValue(true);
|
||||
mockResolveAttachmentHref.mockReturnValue(
|
||||
(id: string, uri: string) => `https://api.moleculesai.app/attachments/${uri}`,
|
||||
);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
});
|
||||
|
||||
// ─── Fetch mock helpers ───────────────────────────────────────────────────────
|
||||
|
||||
function mockFetchOk(body: string, contentType = "image/png") {
|
||||
const blob = new Blob([body], { type: contentType });
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({
|
||||
ok: true,
|
||||
status: 200,
|
||||
blob: () => Promise.resolve(blob),
|
||||
headers: new Map([["content-type", contentType]]),
|
||||
}) as unknown as Response,
|
||||
);
|
||||
}
|
||||
|
||||
function mockFetchError() {
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({ ok: false, status: 500 }) as unknown as Response,
|
||||
);
|
||||
}
|
||||
|
||||
// ─── Loading / idle state ─────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentImage — loading/idle", () => {
|
||||
beforeEach(() => {
|
||||
mockFetchOk("imagedata");
|
||||
});
|
||||
|
||||
it("renders loading skeleton (240×180) with aria-label", () => {
|
||||
const att = makeAttachment("photo.jpg", 1024 * 512);
|
||||
const { container } = render(
|
||||
<AttachmentImage
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
const skeleton = container.querySelector('[aria-label]') as HTMLElement;
|
||||
expect(skeleton?.getAttribute("aria-label")).toContain("photo.jpg");
|
||||
expect(skeleton?.getAttribute("aria-label")).toContain("Loading");
|
||||
// Skeleton dimensions
|
||||
expect(skeleton?.style.width).toBe("240px");
|
||||
expect(skeleton?.style.height).toBe("180px");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Ready state ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentImage — ready", () => {
|
||||
beforeEach(() => {
|
||||
mockFetchOk("imagedata");
|
||||
});
|
||||
|
||||
it("renders <img> inside a button with blob src when ready", async () => {
|
||||
const att = makeAttachment("photo.jpg", 1024 * 512);
|
||||
render(
|
||||
<AttachmentImage
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const img = document.querySelector("img");
|
||||
expect(img).toBeTruthy();
|
||||
});
|
||||
const img = document.querySelector("img") as HTMLImageElement;
|
||||
expect(img.src).toMatch(/^blob:/);
|
||||
// Image button should have correct aria-label
|
||||
const btn = document.querySelector('button[aria-label^="Open"]') as HTMLButtonElement;
|
||||
expect(btn).toBeTruthy();
|
||||
expect(btn?.getAttribute("aria-label")).toContain("photo.jpg");
|
||||
});
|
||||
|
||||
it("tone=user applies blue border class", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("photo.jpg");
|
||||
render(
|
||||
<AttachmentImage
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("img")).toBeTruthy();
|
||||
});
|
||||
const img = document.querySelector("img");
|
||||
const btn = img?.closest("button");
|
||||
expect(btn?.className).toContain("blue-400");
|
||||
});
|
||||
|
||||
it("tone=agent applies neutral border class (no blue)", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("photo.jpg");
|
||||
render(
|
||||
<AttachmentImage
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("img")).toBeTruthy();
|
||||
});
|
||||
const img = document.querySelector("img");
|
||||
const btn = img?.closest("button");
|
||||
expect(btn?.className).not.toContain("blue-400");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Lightbox ─────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentImage — lightbox", () => {
|
||||
beforeEach(() => {
|
||||
mockFetchOk("imagedata");
|
||||
});
|
||||
|
||||
it("opens lightbox on button click", async () => {
|
||||
const att = makeAttachment("photo.jpg");
|
||||
render(
|
||||
<AttachmentImage
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("img")).toBeTruthy();
|
||||
});
|
||||
const btn = document.querySelector('button[aria-label^="Open"]') as HTMLButtonElement;
|
||||
btn.click();
|
||||
// Lightbox dialog should appear
|
||||
await vi.waitFor(() => {
|
||||
const dialog = document.querySelector('[role="dialog"]');
|
||||
expect(dialog).toBeTruthy();
|
||||
});
|
||||
const dialog = document.querySelector('[role="dialog"]');
|
||||
expect(dialog?.getAttribute("aria-label")).toContain("photo.jpg");
|
||||
// Lightbox contains an <img>
|
||||
expect(dialog?.querySelector("img")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("closes lightbox on Escape key", async () => {
|
||||
const att = makeAttachment("photo.jpg");
|
||||
render(
|
||||
<AttachmentImage
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("img")).toBeTruthy();
|
||||
});
|
||||
const btn = document.querySelector('button[aria-label^="Open"]') as HTMLButtonElement;
|
||||
btn.click();
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector('[role="dialog"]')).toBeTruthy();
|
||||
});
|
||||
fireEvent.keyDown(document, { key: "Escape" });
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector('[role="dialog"]')).toBeNull();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Error state ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentImage — error", () => {
|
||||
it("renders AttachmentChip fallback when fetch fails", async () => {
|
||||
mockFetchError();
|
||||
const onDownload = vi.fn();
|
||||
const att = makeAttachment("broken.jpg", 256);
|
||||
render(
|
||||
<AttachmentImage
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={onDownload}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const chip = document.querySelector("button");
|
||||
expect(chip).toBeTruthy();
|
||||
expect(chip?.textContent).toContain("broken.jpg");
|
||||
});
|
||||
// Clicking the chip calls onDownload
|
||||
const chip = document.querySelector("button") as HTMLButtonElement;
|
||||
chip.click();
|
||||
expect(onDownload).toHaveBeenCalledWith(att);
|
||||
});
|
||||
|
||||
it("renders AttachmentChip when img onError fires", async () => {
|
||||
mockFetchOk("imagedata");
|
||||
const onDownload = vi.fn();
|
||||
const att = makeAttachment("corrupt.jpg", 256);
|
||||
render(
|
||||
<AttachmentImage
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={onDownload}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("img")).toBeTruthy();
|
||||
});
|
||||
// Simulate img onError
|
||||
const img = document.querySelector("img") as HTMLImageElement;
|
||||
fireEvent.error(img);
|
||||
await vi.waitFor(() => {
|
||||
const chip = document.querySelector("button");
|
||||
expect(chip).toBeTruthy();
|
||||
expect(chip?.textContent).toContain("corrupt.jpg");
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
// ─── External URI ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentImage — external URI", () => {
|
||||
it("skips auth fetch and uses direct href for external URIs", async () => {
|
||||
// Reset fetch so we can assert it was never called
|
||||
global.fetch = vi.fn();
|
||||
mockIsPlatformAttachment.mockReturnValue(false);
|
||||
// For external URIs the component calls resolveAttachmentHref for the src
|
||||
mockResolveAttachmentHref.mockReturnValue("https://example.com/photo.jpg");
|
||||
const att = makeAttachment("photo.jpg");
|
||||
att.uri = "https://example.com/photo.jpg";
|
||||
const onDownload = vi.fn();
|
||||
render(
|
||||
<AttachmentImage
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={onDownload}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
// Should skip loading skeleton and go straight to ready (external URL)
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("img")).toBeTruthy();
|
||||
});
|
||||
const img = document.querySelector("img") as HTMLImageElement;
|
||||
// Should be the direct href, not a blob
|
||||
expect(img.src).toContain("example.com/photo.jpg");
|
||||
// Fetch should never have been called for external (non-platform) attachments
|
||||
expect(global.fetch).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Cleanup ──────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentImage — blob URL cleanup", () => {
|
||||
it("creates blob URL on mount and cleans up on unmount", async () => {
|
||||
mockIsPlatformAttachment.mockReturnValue(true);
|
||||
mockFetchOk("imagedata");
|
||||
const att = makeAttachment("photo.jpg");
|
||||
const { unmount } = render(
|
||||
<AttachmentImage
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("img")).toBeTruthy();
|
||||
});
|
||||
const img = document.querySelector("img") as HTMLImageElement;
|
||||
const blobUrl = img.src;
|
||||
expect(blobUrl).toMatch(/^blob:/);
|
||||
unmount();
|
||||
// Image should be gone
|
||||
expect(document.querySelector("img")).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -1,309 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* AttachmentPDF — inline PDF preview button + click-to-fullscreen lightbox.
|
||||
*
|
||||
* Per RFC #2991 PR-3: platform-auth URIs fetch bytes → Blob → ObjectURL;
|
||||
* external URIs use the raw URL directly. State machine: idle → loading →
|
||||
* ready/error. Loading skeleton shown while fetching. Error falls back to
|
||||
* AttachmentChip. Clicking the preview button opens AttachmentLightbox with
|
||||
* <embed>. Blob URL cleaned up on unmount.
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs for assertions.
|
||||
*
|
||||
* Covers:
|
||||
* - Renders loading skeleton with PdfGlyph + filename text
|
||||
* - Renders preview button with PDF glyph, filename, and "PDF" label
|
||||
* - Opens lightbox with <embed> on button click
|
||||
* - Lightbox closes on Escape
|
||||
* - tone=user applies blue/accent classes on button
|
||||
* - tone=agent applies neutral border on button
|
||||
* - Error state renders AttachmentChip fallback
|
||||
* - External URI uses direct href without auth fetch
|
||||
* - Cleans up blob URL on unmount
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, fireEvent, render, waitFor } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { AttachmentPDF } from "../AttachmentPDF";
|
||||
import type { ChatAttachment } from "../types";
|
||||
|
||||
// ─── Mocks ────────────────────────────────────────────────────────────────────
|
||||
|
||||
const mockResolveAttachmentHref = vi.fn<(id: string, uri: string) => string>(
|
||||
(id, uri) => `https://api.moleculesai.app/attachments/${uri}`,
|
||||
);
|
||||
const mockIsPlatformAttachment = vi.fn<(uri: string) => boolean>(() => true);
|
||||
|
||||
vi.mock("../uploads", () => ({
|
||||
isPlatformAttachment: (uri: string) => mockIsPlatformAttachment(uri),
|
||||
resolveAttachmentHref: (id: string, uri: string) =>
|
||||
mockResolveAttachmentHref(id, uri),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
platformAuthHeaders: () => ({ Authorization: "Bearer test-token" }),
|
||||
}));
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
function makeAttachment(name: string, size?: number): ChatAttachment {
|
||||
return { name, uri: `workspace:/tmp/${name}`, size };
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
mockIsPlatformAttachment.mockReturnValue(true);
|
||||
mockResolveAttachmentHref.mockReturnValue(
|
||||
(id: string, uri: string) => `https://api.moleculesai.app/attachments/${uri}`,
|
||||
);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
});
|
||||
|
||||
// ─── Fetch mock helpers ───────────────────────────────────────────────────────
|
||||
|
||||
function mockFetchOk(body: string, contentType = "application/pdf") {
|
||||
const blob = new Blob([body], { type: contentType });
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({
|
||||
ok: true,
|
||||
status: 200,
|
||||
blob: () => Promise.resolve(blob),
|
||||
headers: new Map([["content-type", contentType]]),
|
||||
}) as unknown as Response,
|
||||
);
|
||||
}
|
||||
|
||||
function mockFetchError() {
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({ ok: false, status: 500 }) as unknown as Response,
|
||||
);
|
||||
}
|
||||
|
||||
// ─── Loading / idle state ─────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentPDF — loading/idle", () => {
|
||||
beforeEach(() => {
|
||||
mockFetchOk("pdfdata");
|
||||
});
|
||||
|
||||
it("renders loading skeleton with PdfGlyph and filename", () => {
|
||||
const att = makeAttachment("report.pdf", 1024 * 512);
|
||||
const { container } = render(
|
||||
<AttachmentPDF
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
const skeleton = container.querySelector('[aria-label]') as HTMLElement;
|
||||
expect(skeleton?.getAttribute("aria-label")).toContain("report.pdf");
|
||||
expect(skeleton?.getAttribute("aria-label")).toContain("Loading");
|
||||
// Should contain the filename text
|
||||
expect(skeleton?.textContent).toContain("report.pdf");
|
||||
expect(skeleton?.textContent).toContain("Loading");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Ready state ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentPDF — ready", () => {
|
||||
beforeEach(() => {
|
||||
mockFetchOk("pdfdata");
|
||||
});
|
||||
|
||||
it("renders preview button with PDF glyph, filename, and PDF label", async () => {
|
||||
const att = makeAttachment("report.pdf", 1024 * 512);
|
||||
render(
|
||||
<AttachmentPDF
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const btn = document.querySelector('button[aria-label^="Open"]');
|
||||
expect(btn).toBeTruthy();
|
||||
});
|
||||
const btn = document.querySelector('button[aria-label^="Open"]') as HTMLButtonElement;
|
||||
expect(btn?.getAttribute("aria-label")).toContain("report.pdf");
|
||||
// Button text should include the filename and "PDF" label
|
||||
expect(btn?.textContent).toContain("report.pdf");
|
||||
expect(btn?.textContent).toContain("PDF");
|
||||
});
|
||||
|
||||
it("opens lightbox with <embed> on button click", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("report.pdf");
|
||||
render(
|
||||
<AttachmentPDF
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector('button[aria-label^="Open"]')).toBeTruthy();
|
||||
});
|
||||
const btn = document.querySelector('button[aria-label^="Open"]') as HTMLButtonElement;
|
||||
btn.click();
|
||||
await vi.waitFor(() => {
|
||||
const dialog = document.querySelector('[role="dialog"]');
|
||||
expect(dialog).toBeTruthy();
|
||||
});
|
||||
const dialog = document.querySelector('[role="dialog"]');
|
||||
expect(dialog?.getAttribute("aria-label")).toContain("report.pdf");
|
||||
// Lightbox contains an <embed>
|
||||
expect(dialog?.querySelector("embed")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("closes lightbox on Escape key", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("report.pdf");
|
||||
render(
|
||||
<AttachmentPDF
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector('button[aria-label^="Open"]')).toBeTruthy();
|
||||
});
|
||||
const btn = document.querySelector('button[aria-label^="Open"]') as HTMLButtonElement;
|
||||
btn.click();
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector('[role="dialog"]')).toBeTruthy();
|
||||
});
|
||||
fireEvent.keyDown(document, { key: "Escape" });
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector('[role="dialog"]')).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
it("tone=user applies blue/accent classes on button", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("report.pdf");
|
||||
render(
|
||||
<AttachmentPDF
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector('button[aria-label^="Open"]')).toBeTruthy();
|
||||
});
|
||||
const btn = document.querySelector('button[aria-label^="Open"]') as HTMLButtonElement;
|
||||
expect(btn?.className).toContain("border-blue-400");
|
||||
expect(btn?.className).toContain("accent-strong");
|
||||
});
|
||||
|
||||
it("tone=agent applies neutral border class (no blue)", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("report.pdf");
|
||||
render(
|
||||
<AttachmentPDF
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector('button[aria-label^="Open"]')).toBeTruthy();
|
||||
});
|
||||
const btn = document.querySelector('button[aria-label^="Open"]') as HTMLButtonElement;
|
||||
expect(btn?.className).not.toContain("border-blue-400");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Error state ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentPDF — error", () => {
|
||||
it("renders AttachmentChip fallback when fetch fails", async () => {
|
||||
mockFetchError();
|
||||
const onDownload = vi.fn();
|
||||
const att = makeAttachment("broken.pdf", 256);
|
||||
render(
|
||||
<AttachmentPDF
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={onDownload}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const chip = document.querySelector("button");
|
||||
expect(chip).toBeTruthy();
|
||||
expect(chip?.textContent).toContain("broken.pdf");
|
||||
});
|
||||
// Clicking the chip calls onDownload
|
||||
const chip = document.querySelector("button") as HTMLButtonElement;
|
||||
chip.click();
|
||||
expect(onDownload).toHaveBeenCalledWith(att);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── External URI ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentPDF — external URI", () => {
|
||||
it("skips auth fetch and uses direct href for external URIs", async () => {
|
||||
// Reset fetch so we can assert it was never called
|
||||
global.fetch = vi.fn();
|
||||
mockIsPlatformAttachment.mockReturnValue(false);
|
||||
mockResolveAttachmentHref.mockReturnValue("https://example.com/report.pdf");
|
||||
const att = makeAttachment("report.pdf");
|
||||
att.uri = "https://example.com/report.pdf";
|
||||
render(
|
||||
<AttachmentPDF
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
// Should skip loading skeleton and go straight to ready (external URL)
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector('button[aria-label^="Open"]')).toBeTruthy();
|
||||
});
|
||||
// Verify the button is present (not skeleton)
|
||||
const btn = document.querySelector('button[aria-label^="Open"]');
|
||||
expect(btn).toBeTruthy();
|
||||
// Fetch should never have been called for external (non-platform) attachments
|
||||
expect(global.fetch).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Cleanup ──────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentPDF — blob URL cleanup", () => {
|
||||
it("creates blob URL on mount and cleans up on unmount", async () => {
|
||||
mockIsPlatformAttachment.mockReturnValue(true);
|
||||
mockFetchOk("pdfdata");
|
||||
const att = makeAttachment("report.pdf");
|
||||
const { unmount } = render(
|
||||
<AttachmentPDF
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector('button[aria-label^="Open"]')).toBeTruthy();
|
||||
});
|
||||
const btn = document.querySelector('button[aria-label^="Open"]');
|
||||
expect(btn).toBeTruthy();
|
||||
unmount();
|
||||
// Button should be gone after unmount
|
||||
expect(document.querySelector('button[aria-label^="Open"]')).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -1,419 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* AttachmentTextPreview — inline text/code preview with expand + truncate.
|
||||
*
|
||||
* Uses a streaming fetch (ReadableStream) to read up to 256 KB of text.
|
||||
* State machine: idle → loading → ready/error. Ready state shows a
|
||||
* monospace preview of the first 10 lines, with an expand button when
|
||||
* there are more. Shows a "truncated" note when the file exceeds 256 KB.
|
||||
* Error falls back to AttachmentChip.
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs for assertions.
|
||||
*
|
||||
* Covers:
|
||||
* - Renders loading skeleton (320×80) with aria-label
|
||||
* - Renders text preview with correct content in ready state
|
||||
* - Shows filename in header
|
||||
* - Expand button appears when lines > 10
|
||||
* - Expand button hidden when all lines shown
|
||||
* - Expand button calls setExpanded(true) and button text updates
|
||||
* - Download button calls onDownload
|
||||
* - tone=user applies blue/accent border
|
||||
* - tone=agent applies neutral border
|
||||
* - Error state renders AttachmentChip fallback
|
||||
* - Cleans up on unmount
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, fireEvent, render, waitFor } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { AttachmentTextPreview } from "../AttachmentTextPreview";
|
||||
import type { ChatAttachment } from "../types";
|
||||
|
||||
// ─── Mocks ────────────────────────────────────────────────────────────────────
|
||||
|
||||
const mockResolveAttachmentHref = vi.fn<(id: string, uri: string) => string>(
|
||||
(id, uri) => `https://api.moleculesai.app/attachments/${uri}`,
|
||||
);
|
||||
const mockIsPlatformAttachment = vi.fn<(uri: string) => boolean>(() => true);
|
||||
|
||||
vi.mock("../uploads", () => ({
|
||||
isPlatformAttachment: (uri: string) => mockIsPlatformAttachment(uri),
|
||||
resolveAttachmentHref: (id: string, uri: string) =>
|
||||
mockResolveAttachmentHref(id, uri),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/api", () => ({
|
||||
platformAuthHeaders: () => ({ Authorization: "Bearer test-token" }),
|
||||
}));
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
function makeAttachment(name: string, size?: number): ChatAttachment {
|
||||
return { name, uri: `workspace:/tmp/${name}`, size };
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
mockIsPlatformAttachment.mockReturnValue(true);
|
||||
mockResolveAttachmentHref.mockReturnValue(
|
||||
(id: string, uri: string) => `https://api.moleculesai.app/attachments/${uri}`,
|
||||
);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
});
|
||||
|
||||
// ─── Fetch mock helpers ───────────────────────────────────────────────────────
|
||||
|
||||
/**
|
||||
* Mock a streaming fetch that returns text content.
|
||||
* Mimics ReadableStream.read() yielding text chunks.
|
||||
*/
|
||||
function mockFetchText(completeText: string) {
|
||||
const encoder = new TextEncoder();
|
||||
const chunks: Uint8Array[] = [];
|
||||
// Yield in 50-byte chunks
|
||||
let offset = 0;
|
||||
while (offset < completeText.length) {
|
||||
chunks.push(encoder.encode(completeText.slice(offset, offset + 50)));
|
||||
offset += 50;
|
||||
}
|
||||
let chunkIndex = 0;
|
||||
const mockReader = {
|
||||
read: vi.fn<() => Promise<{ done: boolean; value?: Uint8Array }>>(
|
||||
async () => {
|
||||
if (chunkIndex < chunks.length) {
|
||||
return { done: false, value: chunks[chunkIndex++] };
|
||||
}
|
||||
return { done: true };
|
||||
},
|
||||
),
|
||||
cancel: vi.fn(),
|
||||
};
|
||||
const mockBody = {
|
||||
getReader: vi.fn(() => mockReader),
|
||||
};
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({
|
||||
ok: true,
|
||||
status: 200,
|
||||
body: mockBody,
|
||||
headers: new Map([["content-type", "text/plain"]]),
|
||||
}) as unknown as Response,
|
||||
);
|
||||
return mockReader;
|
||||
}
|
||||
|
||||
function mockFetchError() {
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({ ok: false, status: 500 }) as unknown as Response,
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Mock a fetch where body.getReader() returns null (no streaming body).
|
||||
*/
|
||||
function mockFetchTextNoBody(text: string) {
|
||||
const encoder = new TextEncoder();
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({
|
||||
ok: true,
|
||||
status: 200,
|
||||
body: null,
|
||||
text: () => Promise.resolve(text),
|
||||
headers: new Map([["content-type", "text/plain"]]),
|
||||
}) as unknown as Response,
|
||||
);
|
||||
}
|
||||
|
||||
// ─── Loading / idle state ─────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentTextPreview — loading/idle", () => {
|
||||
it("renders loading skeleton (320×80) with aria-label", () => {
|
||||
mockFetchText("hello world");
|
||||
const att = makeAttachment("log.txt", 1024);
|
||||
const { container } = render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
const skeleton = container.querySelector('[aria-label]') as HTMLElement;
|
||||
expect(skeleton?.getAttribute("aria-label")).toContain("log.txt");
|
||||
expect(skeleton?.getAttribute("aria-label")).toContain("Loading");
|
||||
expect(skeleton?.style.width).toBe("320px");
|
||||
expect(skeleton?.style.height).toBe("80px");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Ready state ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentTextPreview — ready", () => {
|
||||
beforeEach(() => {
|
||||
mockFetchText("hello world");
|
||||
});
|
||||
|
||||
it("renders text preview with correct content", async () => {
|
||||
mockFetchText("line1\nline2\nline3");
|
||||
const att = makeAttachment("log.txt");
|
||||
render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const code = document.querySelector("code");
|
||||
expect(code).toBeTruthy();
|
||||
});
|
||||
const code = document.querySelector("code");
|
||||
expect(code?.textContent).toContain("line1");
|
||||
});
|
||||
|
||||
it("shows filename in header", async () => {
|
||||
mockFetchText("hello");
|
||||
const att = makeAttachment("config.yaml");
|
||||
render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("code")).toBeTruthy();
|
||||
});
|
||||
// Header should contain the filename
|
||||
const header = document.querySelector("code")?.closest("div");
|
||||
expect(header?.textContent).toContain("config.yaml");
|
||||
});
|
||||
|
||||
it("shows expand button when lines > 10", async () => {
|
||||
const longText = Array.from({ length: 15 }, (_, i) => `line ${i + 1}`).join("\n");
|
||||
mockFetchText(longText);
|
||||
const att = makeAttachment("long.txt");
|
||||
render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const btn = document.querySelector("button");
|
||||
expect(btn).toBeTruthy();
|
||||
});
|
||||
// Should have a button saying "Show all N lines"
|
||||
const btns = Array.from(document.querySelectorAll("button"));
|
||||
const expandBtn = btns.find((b) => b.textContent?.includes("Show all"));
|
||||
expect(expandBtn).toBeTruthy();
|
||||
expect(expandBtn?.textContent).toContain("15 lines");
|
||||
});
|
||||
|
||||
it("hides expand button when all lines shown (<= 10)", async () => {
|
||||
const shortText = Array.from({ length: 5 }, (_, i) => `line ${i + 1}`).join("\n");
|
||||
mockFetchText(shortText);
|
||||
const att = makeAttachment("short.txt");
|
||||
render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("code")).toBeTruthy();
|
||||
});
|
||||
const btns = Array.from(document.querySelectorAll("button"));
|
||||
const expandBtn = btns.find((b) => b.textContent?.includes("Show all"));
|
||||
expect(expandBtn).toBeUndefined();
|
||||
});
|
||||
|
||||
it("expand button updates button text to all lines", async () => {
|
||||
const longText = Array.from({ length: 15 }, (_, i) => `line ${i + 1}`).join("\n");
|
||||
mockFetchText(longText);
|
||||
const att = makeAttachment("long.txt");
|
||||
render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const btns = Array.from(document.querySelectorAll("button"));
|
||||
expect(btns.find((b) => b.textContent?.includes("Show all"))).toBeTruthy();
|
||||
});
|
||||
const btns = Array.from(document.querySelectorAll("button"));
|
||||
const expandBtn = btns.find((b) => b.textContent?.includes("Show all")) as HTMLButtonElement;
|
||||
expandBtn.click();
|
||||
await vi.waitFor(() => {
|
||||
const newBtns = Array.from(document.querySelectorAll("button"));
|
||||
expect(newBtns.find((b) => b.textContent?.includes("Show all"))).toBeUndefined();
|
||||
});
|
||||
});
|
||||
|
||||
it("download button calls onDownload", async () => {
|
||||
mockFetchText("hello");
|
||||
const onDownload = vi.fn();
|
||||
const att = makeAttachment("log.txt");
|
||||
render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={onDownload}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("code")).toBeTruthy();
|
||||
});
|
||||
// Find the download button (aria-label contains "Download")
|
||||
const downloadBtn = document.querySelector('[aria-label^="Download"]') as HTMLButtonElement;
|
||||
expect(downloadBtn).toBeTruthy();
|
||||
downloadBtn.click();
|
||||
expect(onDownload).toHaveBeenCalledWith(att);
|
||||
});
|
||||
|
||||
it("tone=user applies blue/accent border classes", async () => {
|
||||
mockFetchText("hello");
|
||||
const att = makeAttachment("log.txt");
|
||||
const { container } = render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("code")).toBeTruthy();
|
||||
});
|
||||
const rootDiv = container.firstChild as HTMLElement;
|
||||
expect(rootDiv.className).toContain("border-blue-400");
|
||||
expect(rootDiv.className).toContain("accent-strong");
|
||||
});
|
||||
|
||||
it("tone=agent applies neutral border class (no blue)", async () => {
|
||||
mockFetchText("hello");
|
||||
const att = makeAttachment("log.txt");
|
||||
const { container } = render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("code")).toBeTruthy();
|
||||
});
|
||||
const rootDiv = container.firstChild as HTMLElement;
|
||||
expect(rootDiv.className).not.toContain("border-blue-400");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Truncated state ───────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentTextPreview — truncated", () => {
|
||||
it("shows truncated notice when file exceeds 256 KB", async () => {
|
||||
// Simulate a response where the reader yields chunks until MAX_FETCH_BYTES (256KB)
|
||||
const encoder = new TextEncoder();
|
||||
const bytesNeeded = 256 * 1024;
|
||||
const mockReader = {
|
||||
read: vi.fn<() => Promise<{ done: boolean; value?: Uint8Array }>>(
|
||||
async () => {
|
||||
// Return one chunk that's >= 256KB total (we'll cap at MAX_FETCH_BYTES)
|
||||
const chunk = encoder.encode("x".repeat(300 * 1024));
|
||||
return { done: false, value: chunk };
|
||||
},
|
||||
),
|
||||
cancel: vi.fn(),
|
||||
};
|
||||
const mockBody = { getReader: vi.fn(() => mockReader) };
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({
|
||||
ok: true,
|
||||
status: 200,
|
||||
body: mockBody,
|
||||
headers: new Map([["content-type", "text/plain"]]),
|
||||
}) as unknown as Response,
|
||||
);
|
||||
const att = makeAttachment("huge.log");
|
||||
render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const truncated = document.querySelector("code");
|
||||
expect(truncated).toBeTruthy();
|
||||
});
|
||||
// Should show truncated notice
|
||||
const truncatedNote = Array.from(document.querySelectorAll("button")).find(
|
||||
(b) => b.textContent?.includes("download full file"),
|
||||
);
|
||||
expect(truncatedNote).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Error state ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentTextPreview — error", () => {
|
||||
it("renders AttachmentChip fallback when fetch fails", async () => {
|
||||
mockFetchError();
|
||||
const onDownload = vi.fn();
|
||||
const att = makeAttachment("broken.txt", 256);
|
||||
render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={onDownload}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
const chip = document.querySelector("button");
|
||||
expect(chip).toBeTruthy();
|
||||
expect(chip?.textContent).toContain("broken.txt");
|
||||
});
|
||||
const chip = document.querySelector("button") as HTMLButtonElement;
|
||||
chip.click();
|
||||
expect(onDownload).toHaveBeenCalledWith(att);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Cleanup ──────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentTextPreview — cleanup", () => {
|
||||
it("cleans up on unmount", async () => {
|
||||
mockFetchText("hello");
|
||||
const att = makeAttachment("log.txt");
|
||||
const { unmount } = render(
|
||||
<AttachmentTextPreview
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("code")).toBeTruthy();
|
||||
});
|
||||
expect(document.querySelector("code")).toBeTruthy();
|
||||
unmount();
|
||||
expect(document.querySelector("code")).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -1,276 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* AttachmentVideo — inline native HTML5 <video> player for chat attachments.
|
||||
*
|
||||
* Per RFC #2991 PR-2: platform-auth URIs fetch bytes → Blob → ObjectURL;
|
||||
* external URIs use the raw URL directly. State machine: idle → loading →
|
||||
* ready/error. Loading skeleton shown while fetching. Error falls back to
|
||||
* AttachmentChip. Blob URL cleaned up on unmount / re-run.
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use DOM APIs for assertions.
|
||||
*
|
||||
* Covers:
|
||||
* - Renders loading skeleton with aria-label while fetching
|
||||
* - Renders <video> element with correct src when ready
|
||||
* - Error state renders AttachmentChip fallback
|
||||
* - idle state renders loading skeleton
|
||||
* - ready state uses correct blob/object URL
|
||||
* - tone=user applies blue border class
|
||||
* - tone=agent applies neutral border class
|
||||
* - onDownload called when error chip is clicked
|
||||
* - Cleans up blob URL on unmount
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { AttachmentVideo } from "../AttachmentVideo";
|
||||
import type { ChatAttachment } from "../types";
|
||||
|
||||
// ─── Mocks ────────────────────────────────────────────────────────────────────
|
||||
|
||||
// Mock the entire uploads module to control isPlatformAttachment / resolveAttachmentHref
|
||||
const mockResolveAttachmentHref = vi.fn<(id: string, uri: string) => string>(
|
||||
(id, uri) => `https://api.moleculesai.app/attachments/${uri}`,
|
||||
);
|
||||
const mockIsPlatformAttachment = vi.fn<(uri: string) => boolean>(() => true);
|
||||
|
||||
vi.mock("../uploads", () => ({
|
||||
isPlatformAttachment: (uri: string) => mockIsPlatformAttachment(uri),
|
||||
resolveAttachmentHref: (id: string, uri: string) =>
|
||||
mockResolveAttachmentHref(id, uri),
|
||||
}));
|
||||
|
||||
// Mock platformAuthHeaders so fetch gets auth headers
|
||||
vi.mock("@/lib/api", () => ({
|
||||
platformAuthHeaders: () => ({ Authorization: "Bearer test-token" }),
|
||||
}));
|
||||
|
||||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
function makeAttachment(name: string, size?: number): ChatAttachment {
|
||||
return { name, uri: `workspace:/tmp/${name}`, size };
|
||||
}
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
});
|
||||
|
||||
// ─── Fetch mock helper ────────────────────────────────────────────────────────
|
||||
|
||||
function mockFetchOk(body: string, contentType = "video/mp4") {
|
||||
const blob = new Blob([body], { type: contentType });
|
||||
const url = URL.createObjectURL(blob);
|
||||
global.fetch = vi.fn((href: string, opts?: RequestInit) => {
|
||||
void href;
|
||||
void opts;
|
||||
return Promise.resolve({
|
||||
ok: true,
|
||||
status: 200,
|
||||
blob: () => Promise.resolve(blob),
|
||||
headers: new Map([["content-type", contentType]]),
|
||||
}) as unknown as Response;
|
||||
});
|
||||
return url;
|
||||
}
|
||||
|
||||
function mockFetchError() {
|
||||
global.fetch = vi.fn(() =>
|
||||
Promise.resolve({ ok: false, status: 500 }) as unknown as Response,
|
||||
);
|
||||
}
|
||||
|
||||
// ─── Idle state ──────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentVideo — idle/loading", () => {
|
||||
beforeEach(() => {
|
||||
mockFetchOk("videodata");
|
||||
});
|
||||
|
||||
it("renders loading skeleton with aria-label", () => {
|
||||
const att = makeAttachment("clip.mp4", 1024 * 512);
|
||||
const { container } = render(
|
||||
<AttachmentVideo
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
// While fetching, should show skeleton
|
||||
const skeleton = container.querySelector('[aria-label]') as HTMLElement;
|
||||
expect(skeleton?.getAttribute("aria-label")).toContain("clip.mp4");
|
||||
expect(skeleton?.getAttribute("aria-label")).toContain("Loading");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Ready state ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentVideo — ready", () => {
|
||||
beforeEach(() => {
|
||||
mockFetchOk("videodata");
|
||||
});
|
||||
|
||||
it("renders <video> element with correct src when ready", async () => {
|
||||
const att = makeAttachment("clip.mp4", 1024 * 512);
|
||||
render(
|
||||
<AttachmentVideo
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
// Wait for ready state
|
||||
await vi.waitFor(() => {
|
||||
const video = document.querySelector("video");
|
||||
expect(video).toBeTruthy();
|
||||
});
|
||||
const video = document.querySelector("video") as HTMLVideoElement;
|
||||
// src should be an object URL (blob:)
|
||||
expect(video.src).toMatch(/^blob:/);
|
||||
expect(video.hasAttribute("controls")).toBe(true);
|
||||
});
|
||||
|
||||
it("ready state uses blob URL for platform attachments", async () => {
|
||||
mockIsPlatformAttachment.mockReturnValue(true);
|
||||
const att = makeAttachment("clip.mp4", 1024);
|
||||
render(
|
||||
<AttachmentVideo
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("video")).toBeTruthy();
|
||||
});
|
||||
const video = document.querySelector("video") as HTMLVideoElement;
|
||||
expect(video.src).toMatch(/^blob:/);
|
||||
});
|
||||
|
||||
it("tone=user applies blue border class", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("clip.mp4");
|
||||
render(
|
||||
<AttachmentVideo
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("video")).toBeTruthy();
|
||||
});
|
||||
const video = document.querySelector("video");
|
||||
// The video container has tone-based border class
|
||||
const container = video?.closest("div");
|
||||
expect(container?.className).toContain("blue-400");
|
||||
});
|
||||
|
||||
it("tone=agent applies neutral border class (no blue)", async () => {
|
||||
mockFetchOk("data");
|
||||
const att = makeAttachment("clip.mp4");
|
||||
render(
|
||||
<AttachmentVideo
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("video")).toBeTruthy();
|
||||
});
|
||||
const video = document.querySelector("video");
|
||||
const container = video?.closest("div");
|
||||
expect(container?.className).not.toContain("blue-400");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Error state ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentVideo — error", () => {
|
||||
it("renders AttachmentChip fallback when fetch fails", async () => {
|
||||
mockFetchError();
|
||||
const onDownload = vi.fn();
|
||||
const att = makeAttachment("broken.mp4", 256);
|
||||
render(
|
||||
<AttachmentVideo
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={onDownload}
|
||||
tone="agent"
|
||||
/>,
|
||||
);
|
||||
// First renders loading skeleton
|
||||
// Then transitions to error
|
||||
await vi.waitFor(() => {
|
||||
// Should have rendered the chip button instead of video
|
||||
const chip = document.querySelector("button");
|
||||
expect(chip).toBeTruthy();
|
||||
expect(chip?.textContent).toContain("broken.mp4");
|
||||
});
|
||||
// Clicking the chip calls onDownload
|
||||
const chip = document.querySelector("button") as HTMLButtonElement;
|
||||
chip.click();
|
||||
expect(onDownload).toHaveBeenCalledWith(att);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Cleanup ──────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentVideo — blob URL cleanup", () => {
|
||||
it("creates blob URL on mount and cleans up on unmount", async () => {
|
||||
mockFetchOk("videodata");
|
||||
const att = makeAttachment("clip.mp4");
|
||||
const { unmount } = render(
|
||||
<AttachmentVideo
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("video")).toBeTruthy();
|
||||
});
|
||||
const video = document.querySelector("video") as HTMLVideoElement;
|
||||
const blobUrl = video.src;
|
||||
expect(blobUrl).toMatch(/^blob:/);
|
||||
// Unmount should revoke the blob URL
|
||||
unmount();
|
||||
// After unmount, the video element should be gone
|
||||
expect(document.querySelector("video")).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
// ─── External URI (no fetch) ─────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentVideo — external URI", () => {
|
||||
it("uses direct href for external URIs without fetch", async () => {
|
||||
mockIsPlatformAttachment.mockReturnValue(false);
|
||||
const externalUri = "https://example.com/video.mp4";
|
||||
const att = makeAttachment("video.mp4");
|
||||
att.uri = externalUri;
|
||||
render(
|
||||
<AttachmentVideo
|
||||
workspaceId="ws1"
|
||||
attachment={att}
|
||||
onDownload={vi.fn()}
|
||||
tone="user"
|
||||
/>,
|
||||
);
|
||||
// Should skip loading and go straight to ready
|
||||
await vi.waitFor(() => {
|
||||
expect(document.querySelector("video")).toBeTruthy();
|
||||
});
|
||||
const video = document.querySelector("video") as HTMLVideoElement;
|
||||
// For external URIs, the src should be the direct href (not a blob)
|
||||
expect(video.src).toContain("example.com/video.mp4");
|
||||
});
|
||||
});
|
||||
@@ -1,185 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* AttachmentViews — pure presentational components for chat attachments.
|
||||
*
|
||||
* Covers:
|
||||
* - PendingAttachmentPill renders file name, formatted size, × button
|
||||
* - PendingAttachmentPill × button has correct aria-label
|
||||
* - PendingAttachmentPill calls onRemove when × clicked
|
||||
* - PendingAttachmentPill renders exactly one button
|
||||
* - AttachmentChip renders attachment name and download glyph
|
||||
* - AttachmentChip renders size when provided
|
||||
* - AttachmentChip omits size span when size is undefined
|
||||
* - AttachmentChip calls onDownload(attachment) on click
|
||||
* - AttachmentChip title attribute for hover tooltip
|
||||
* - AttachmentChip tone=user applies blue accent classes
|
||||
* - AttachmentChip tone=agent applies surface classes
|
||||
* - AttachmentChip renders exactly one button
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use textContent / className /
|
||||
* getAttribute checks to avoid "expect is not defined" errors in this vitest
|
||||
* configuration.
|
||||
*/
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, render, screen } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { AttachmentChip, PendingAttachmentPill } from "../AttachmentViews";
|
||||
import type { ChatAttachment } from "../types";
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
// ─── Helpers ────────────────────────────────────────────────────────────────────
|
||||
|
||||
/** Create a File with actual content so size > 0 in jsdom. */
|
||||
function makeFile(name: string, content: string): File {
|
||||
return new File([content], name, { type: "application/octet-stream" });
|
||||
}
|
||||
|
||||
function makeAttachment(name: string, size?: number): ChatAttachment {
|
||||
return { name, uri: `workspace:/tmp/${name}`, size };
|
||||
}
|
||||
|
||||
// ─── PendingAttachmentPill ─────────────────────────────────────────────────────
|
||||
|
||||
describe("PendingAttachmentPill", () => {
|
||||
it("renders the file name", () => {
|
||||
const file = makeFile("report.pdf", "PDF content here");
|
||||
const { container } = render(
|
||||
<PendingAttachmentPill file={file} onRemove={vi.fn()} />,
|
||||
);
|
||||
expect(container.textContent).toContain("report.pdf");
|
||||
});
|
||||
|
||||
it("renders the formatted file size (KB)", () => {
|
||||
// 50 KB = 50 * 1024 bytes
|
||||
const content = "x".repeat(50 * 1024);
|
||||
const file = makeFile("data.csv", content);
|
||||
const { container } = render(
|
||||
<PendingAttachmentPill file={file} onRemove={vi.fn()} />,
|
||||
);
|
||||
expect(container.textContent).toContain("50 KB");
|
||||
});
|
||||
|
||||
it("renders 0 B for empty file", () => {
|
||||
const file = makeFile("empty.txt", "");
|
||||
const { container } = render(
|
||||
<PendingAttachmentPill file={file} onRemove={vi.fn()} />,
|
||||
);
|
||||
expect(container.textContent).toContain("0 B");
|
||||
});
|
||||
|
||||
it("renders size in MB for files >= 1 MB", () => {
|
||||
// 2.5 MB = 2.5 * 1024 * 1024 bytes
|
||||
const content = "x".repeat(Math.round(2.5 * 1024 * 1024));
|
||||
const file = makeFile("video.mp4", content);
|
||||
const { container } = render(
|
||||
<PendingAttachmentPill file={file} onRemove={vi.fn()} />,
|
||||
);
|
||||
expect(container.textContent).toContain("2.5 MB");
|
||||
});
|
||||
|
||||
it("× button has aria-label with file name", () => {
|
||||
const file = makeFile("notes.txt", "some content");
|
||||
render(<PendingAttachmentPill file={file} onRemove={vi.fn()} />);
|
||||
const btn = screen.getByRole("button");
|
||||
expect(btn.getAttribute("aria-label")).toBe("Remove notes.txt");
|
||||
});
|
||||
|
||||
it("calls onRemove when × button is clicked", () => {
|
||||
const file = makeFile("doc.pdf", "pdf data");
|
||||
const onRemove = vi.fn();
|
||||
render(<PendingAttachmentPill file={file} onRemove={onRemove} />);
|
||||
screen.getByRole("button").click();
|
||||
expect(onRemove).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("renders exactly one button (the × remove button)", () => {
|
||||
const file = makeFile("img.png", "image bytes");
|
||||
const { container } = render(
|
||||
<PendingAttachmentPill file={file} onRemove={vi.fn()} />,
|
||||
);
|
||||
expect(container.querySelectorAll("button")).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── AttachmentChip ───────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentChip", () => {
|
||||
it("renders the attachment name", () => {
|
||||
const att = makeAttachment("chart.svg", 2048);
|
||||
const { container } = render(
|
||||
<AttachmentChip attachment={att} onDownload={vi.fn()} tone="user" />,
|
||||
);
|
||||
expect(container.textContent).toContain("chart.svg");
|
||||
});
|
||||
|
||||
it("renders size when provided", () => {
|
||||
const att = makeAttachment("dump.sql", 1024 * 150); // 150 KB
|
||||
const { container } = render(
|
||||
<AttachmentChip attachment={att} onDownload={vi.fn()} tone="user" />,
|
||||
);
|
||||
expect(container.textContent).toContain("150 KB");
|
||||
});
|
||||
|
||||
it("omits size span when attachment.size is undefined", () => {
|
||||
const att = makeAttachment("notes.md"); // no size
|
||||
const { container } = render(
|
||||
<AttachmentChip attachment={att} onDownload={vi.fn()} tone="user" />,
|
||||
);
|
||||
// The only <span> should be the truncated filename; no size <span>
|
||||
const spans = Array.from(container.querySelectorAll("span"));
|
||||
const sizeSpans = spans.filter(
|
||||
(s) => s.className && s.className.includes("tabular-nums"),
|
||||
);
|
||||
expect(sizeSpans).toHaveLength(0);
|
||||
});
|
||||
|
||||
it("has title attribute with download hint", () => {
|
||||
const att = makeAttachment("readme.txt", 64);
|
||||
const { container } = render(
|
||||
<AttachmentChip attachment={att} onDownload={vi.fn()} tone="agent" />,
|
||||
);
|
||||
const btn = container.querySelector("button");
|
||||
expect(btn?.getAttribute("title")).toBe("Download readme.txt");
|
||||
});
|
||||
|
||||
it("calls onDownload with the attachment on click", () => {
|
||||
const att = makeAttachment("export.csv", 8192);
|
||||
const onDownload = vi.fn();
|
||||
const { container } = render(
|
||||
<AttachmentChip attachment={att} onDownload={onDownload} tone="agent" />,
|
||||
);
|
||||
container.querySelector("button")!.click();
|
||||
expect(onDownload).toHaveBeenCalledWith(att);
|
||||
});
|
||||
|
||||
it("tone=user applies blue accent class", () => {
|
||||
const att = makeAttachment("photo.jpg", 512);
|
||||
const { container } = render(
|
||||
<AttachmentChip attachment={att} onDownload={vi.fn()} tone="user" />,
|
||||
);
|
||||
const btn = container.querySelector("button")!;
|
||||
expect(btn.className).toContain("blue-400");
|
||||
});
|
||||
|
||||
it("tone=agent does not apply blue accent class", () => {
|
||||
const att = makeAttachment("photo.jpg", 512);
|
||||
const { container } = render(
|
||||
<AttachmentChip attachment={att} onDownload={vi.fn()} tone="agent" />,
|
||||
);
|
||||
const btn = container.querySelector("button")!;
|
||||
expect(btn.className).not.toContain("blue-400");
|
||||
});
|
||||
|
||||
it("renders exactly one button", () => {
|
||||
const att = makeAttachment("icon.svg", 128);
|
||||
const { container } = render(
|
||||
<AttachmentChip attachment={att} onDownload={vi.fn()} tone="user" />,
|
||||
);
|
||||
expect(container.querySelectorAll("button")).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
@@ -1,451 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* form-inputs — pure presentational form primitives for the Config tab.
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use textContent / className /
|
||||
* getAttribute / checked / value checks to avoid "expect is not defined"
|
||||
* errors in this vitest configuration.
|
||||
*
|
||||
* Covers:
|
||||
* - TextInput renders label and input with correct value
|
||||
* - TextInput calls onChange with new value on keystroke
|
||||
* - TextInput renders placeholder text when provided
|
||||
* - TextInput applies mono class when mono=true
|
||||
* - TextInput input has accessible aria-label from label
|
||||
* - TextInput input is not mono by default
|
||||
* - NumberInput renders label and number input
|
||||
* - NumberInput calls onChange with parsed integer on keystroke
|
||||
* - NumberInput calls onChange with 0 for non-numeric input
|
||||
* - NumberInput respects min/max bounds
|
||||
* - NumberInput input has aria-label from label prop
|
||||
* - NumberInput input has font-mono class
|
||||
* - Toggle renders checkbox with label text
|
||||
* - Toggle renders checked/unchecked state correctly
|
||||
* - Toggle calls onChange with boolean on toggle
|
||||
* - TagList renders existing tags with remove buttons
|
||||
* - TagList × button has aria-label "Remove tag {value}"
|
||||
* - TagList calls onChange without removed tag on × click
|
||||
* - TagList renders the label text
|
||||
* - TagList renders placeholder text when provided
|
||||
* - TagList renders exactly one textbox
|
||||
* - TagList adds tag on Enter key
|
||||
* - TagList does not add empty/whitespace-only tags on Enter
|
||||
* - TagList clears input after adding tag
|
||||
* - Section renders the title
|
||||
* - Section renders children when open (defaultOpen=true)
|
||||
* - Section starts closed when defaultOpen=false
|
||||
* - Section opens/closes content on title click
|
||||
* - Section button has aria-expanded reflecting open state
|
||||
* - Section toggle indicator changes on open/close
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import {
|
||||
TextInput,
|
||||
NumberInput,
|
||||
Toggle,
|
||||
TagList,
|
||||
Section,
|
||||
} from "../form-inputs";
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
});
|
||||
|
||||
// ─── TextInput ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("TextInput", () => {
|
||||
it("renders the label text", () => {
|
||||
const { container } = render(
|
||||
<TextInput label="Agent Name" value="" onChange={vi.fn()} />,
|
||||
);
|
||||
expect(container.textContent).toContain("Agent Name");
|
||||
});
|
||||
|
||||
it("renders the input with the given value", () => {
|
||||
render(<TextInput label="Model" value="claude-opus-4" onChange={vi.fn()} />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
expect(input.value).toBe("claude-opus-4");
|
||||
});
|
||||
|
||||
it("calls onChange with new value on keystroke", () => {
|
||||
const onChange = vi.fn();
|
||||
render(<TextInput label="Name" value="hello" onChange={onChange} />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
fireEvent.change(input, { target: { value: "hello world" } });
|
||||
expect(onChange).toHaveBeenCalledWith("hello world");
|
||||
});
|
||||
|
||||
it("renders placeholder text when provided", () => {
|
||||
render(
|
||||
<TextInput
|
||||
label="Token"
|
||||
value=""
|
||||
onChange={vi.fn()}
|
||||
placeholder="sk-..."
|
||||
/>,
|
||||
);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
expect(input.getAttribute("placeholder")).toBe("sk-...");
|
||||
});
|
||||
|
||||
it("applies mono class when mono=true", () => {
|
||||
const { container } = render(
|
||||
<TextInput label="Model" value="" onChange={vi.fn()} mono />,
|
||||
);
|
||||
const input = container.querySelector("input") as HTMLInputElement;
|
||||
expect(input.className).toContain("font-mono");
|
||||
});
|
||||
|
||||
it("input has aria-label matching the label", () => {
|
||||
render(<TextInput label="API Key" value="" onChange={vi.fn()} />);
|
||||
const input = document.querySelector("input") as HTMLInputElement;
|
||||
expect(input.getAttribute("aria-label")).toBe("API Key");
|
||||
});
|
||||
|
||||
it("input is not mono by default", () => {
|
||||
const { container } = render(
|
||||
<TextInput label="Description" value="" onChange={vi.fn()} />,
|
||||
);
|
||||
const input = container.querySelector("input") as HTMLInputElement;
|
||||
expect(input.className).not.toContain("font-mono");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── NumberInput ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("NumberInput", () => {
|
||||
it("renders the label text", () => {
|
||||
const { container } = render(
|
||||
<NumberInput label="Timeout (s)" value={30} onChange={vi.fn()} />,
|
||||
);
|
||||
expect(container.textContent).toContain("Timeout (s)");
|
||||
});
|
||||
|
||||
it("renders the input with the given numeric value", () => {
|
||||
render(<NumberInput label="Retries" value={3} onChange={vi.fn()} />);
|
||||
const input = document.querySelector("input[type=number]") as HTMLInputElement;
|
||||
expect(input.value).toBe("3");
|
||||
});
|
||||
|
||||
it("calls onChange with parsed integer on keystroke", () => {
|
||||
const onChange = vi.fn();
|
||||
render(<NumberInput label="Delay" value={1} onChange={onChange} />);
|
||||
const input = document.querySelector("input[type=number]") as HTMLInputElement;
|
||||
fireEvent.change(input, { target: { value: "7" } });
|
||||
expect(onChange).toHaveBeenCalledWith(7);
|
||||
});
|
||||
|
||||
it("calls onChange with 0 for non-numeric input", () => {
|
||||
const onChange = vi.fn();
|
||||
render(<NumberInput label="Count" value={5} onChange={onChange} />);
|
||||
const input = document.querySelector("input[type=number]") as HTMLInputElement;
|
||||
fireEvent.change(input, { target: { value: "abc" } });
|
||||
expect(onChange).toHaveBeenCalledWith(0);
|
||||
});
|
||||
|
||||
it("respects min attribute", () => {
|
||||
render(
|
||||
<NumberInput
|
||||
label="Port"
|
||||
value={8000}
|
||||
onChange={vi.fn()}
|
||||
min={1024}
|
||||
/>,
|
||||
);
|
||||
const input = document.querySelector("input[type=number]") as HTMLInputElement;
|
||||
expect(input.getAttribute("min")).toBe("1024");
|
||||
});
|
||||
|
||||
it("respects max attribute", () => {
|
||||
render(
|
||||
<NumberInput
|
||||
label="Memory (MB)"
|
||||
value={256}
|
||||
onChange={vi.fn()}
|
||||
max={65535}
|
||||
/>,
|
||||
);
|
||||
const input = document.querySelector("input[type=number]") as HTMLInputElement;
|
||||
expect(input.getAttribute("max")).toBe("65535");
|
||||
});
|
||||
|
||||
it("input has aria-label from label prop", () => {
|
||||
render(<NumberInput label="Timeout" value={60} onChange={vi.fn()} />);
|
||||
const input = document.querySelector("input[type=number]") as HTMLInputElement;
|
||||
expect(input.getAttribute("aria-label")).toBe("Timeout");
|
||||
});
|
||||
|
||||
it("input has font-mono class", () => {
|
||||
const { container } = render(
|
||||
<NumberInput label="Budget" value={100} onChange={vi.fn()} />,
|
||||
);
|
||||
const input = container.querySelector("input") as HTMLInputElement;
|
||||
expect(input.className).toContain("font-mono");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Toggle ──────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("Toggle", () => {
|
||||
it("renders the checkbox with label text", () => {
|
||||
const { container } = render(
|
||||
<Toggle label="Enable streaming" checked={false} onChange={vi.fn()} />,
|
||||
);
|
||||
const checkbox = container.querySelector(
|
||||
"input[type=checkbox]",
|
||||
) as HTMLInputElement;
|
||||
expect(checkbox.checked).toBe(false);
|
||||
expect(
|
||||
checkbox.closest("label")?.textContent,
|
||||
).toContain("Enable streaming");
|
||||
});
|
||||
|
||||
it("renders checked state correctly", () => {
|
||||
const { container } = render(
|
||||
<Toggle label="Push notifications" checked onChange={vi.fn()} />,
|
||||
);
|
||||
const checkbox = container.querySelector(
|
||||
"input[type=checkbox]",
|
||||
) as HTMLInputElement;
|
||||
expect(checkbox.checked).toBe(true);
|
||||
});
|
||||
|
||||
it("calls onChange with true when toggled on", () => {
|
||||
const onChange = vi.fn();
|
||||
const { container } = render(
|
||||
<Toggle label="Escalate" checked={false} onChange={onChange} />,
|
||||
);
|
||||
const checkbox = container.querySelector(
|
||||
"input[type=checkbox]",
|
||||
) as HTMLInputElement;
|
||||
checkbox.click();
|
||||
expect(onChange).toHaveBeenCalledWith(true);
|
||||
});
|
||||
|
||||
it("calls onChange with false when toggled off", () => {
|
||||
const onChange = vi.fn();
|
||||
const { container } = render(
|
||||
<Toggle label="Escalate" checked onChange={onChange} />,
|
||||
);
|
||||
const checkbox = container.querySelector(
|
||||
"input[type=checkbox]",
|
||||
) as HTMLInputElement;
|
||||
checkbox.click();
|
||||
expect(onChange).toHaveBeenCalledWith(false);
|
||||
});
|
||||
|
||||
it("checkbox is a native input element", () => {
|
||||
const { container } = render(
|
||||
<Toggle label="Feature flag" checked={false} onChange={vi.fn()} />,
|
||||
);
|
||||
expect(container.querySelector("input[type=checkbox]")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
// ─── TagList ────────────────────────────────────────────────────────────────
|
||||
|
||||
describe("TagList", () => {
|
||||
it("renders existing tags", () => {
|
||||
const { container } = render(
|
||||
<TagList label="Tools" values={["file_read", "bash"]} onChange={vi.fn()} />,
|
||||
);
|
||||
expect(container.textContent).toContain("file_read");
|
||||
expect(container.textContent).toContain("bash");
|
||||
});
|
||||
|
||||
it("renders × remove button for each tag with aria-label", () => {
|
||||
render(
|
||||
<TagList
|
||||
label="Skills"
|
||||
values={["python", "golang"]}
|
||||
onChange={vi.fn()}
|
||||
/>,
|
||||
);
|
||||
const buttons = document.querySelectorAll("button");
|
||||
// buttons[0] = first × (python), buttons[1] = second × (golang)
|
||||
expect(buttons[0].getAttribute("aria-label")).toBe(
|
||||
"Remove tag python",
|
||||
);
|
||||
expect(buttons[1].getAttribute("aria-label")).toBe(
|
||||
"Remove tag golang",
|
||||
);
|
||||
});
|
||||
|
||||
it("calls onChange without removed tag when × is clicked", () => {
|
||||
const onChange = vi.fn();
|
||||
render(
|
||||
<TagList
|
||||
label="Tags"
|
||||
values={["react", "vue", "angular"]}
|
||||
onChange={onChange}
|
||||
/>,
|
||||
);
|
||||
const buttons = document.querySelectorAll("button");
|
||||
// buttons[0] = react ×, buttons[1] = vue ×, buttons[2] = angular ×
|
||||
buttons[0].click(); // Remove react
|
||||
expect(onChange).toHaveBeenCalledWith(["vue", "angular"]);
|
||||
});
|
||||
|
||||
it("renders the label text", () => {
|
||||
const { container } = render(
|
||||
<TagList label="Required env vars" values={[]} onChange={vi.fn()} />,
|
||||
);
|
||||
expect(container.textContent).toContain("Required env vars");
|
||||
});
|
||||
|
||||
it("renders placeholder text when provided", () => {
|
||||
render(
|
||||
<TagList
|
||||
label="Tags"
|
||||
values={[]}
|
||||
onChange={vi.fn()}
|
||||
placeholder="Add a tag..."
|
||||
/>,
|
||||
);
|
||||
const input = document.querySelector("input[type=text]") as HTMLInputElement;
|
||||
expect(input.getAttribute("placeholder")).toBe("Add a tag...");
|
||||
});
|
||||
|
||||
it("renders exactly one textbox (the input)", () => {
|
||||
const { container } = render(
|
||||
<TagList
|
||||
label="Tools"
|
||||
values={["read", "write"]}
|
||||
onChange={vi.fn()}
|
||||
/>,
|
||||
);
|
||||
expect(
|
||||
container.querySelectorAll("input[type=text]"),
|
||||
).toHaveLength(1);
|
||||
});
|
||||
|
||||
it("adds tag on Enter key", () => {
|
||||
const onChange = vi.fn();
|
||||
render(
|
||||
<TagList label="Skills" values={["python"]} onChange={onChange} />,
|
||||
);
|
||||
const input = document.querySelector("input[type=text]") as HTMLInputElement;
|
||||
fireEvent.change(input, { target: { value: "rust" } });
|
||||
fireEvent.keyDown(input, { key: "Enter" });
|
||||
expect(onChange).toHaveBeenCalledWith(["python", "rust"]);
|
||||
});
|
||||
|
||||
it("does not add empty tag on Enter", () => {
|
||||
const onChange = vi.fn();
|
||||
render(
|
||||
<TagList label="Tools" values={[]} onChange={onChange} />,
|
||||
);
|
||||
const input = document.querySelector("input[type=text]") as HTMLInputElement;
|
||||
fireEvent.change(input, { target: { value: " " } });
|
||||
fireEvent.keyDown(input, { key: "Enter" });
|
||||
expect(onChange).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("clears input after adding tag", () => {
|
||||
render(
|
||||
<TagList label="Tags" values={[]} onChange={vi.fn()} />,
|
||||
);
|
||||
const input = document.querySelector("input[type=text]") as HTMLInputElement;
|
||||
fireEvent.change(input, { target: { value: "golang" } });
|
||||
fireEvent.keyDown(input, { key: "Enter" });
|
||||
expect(input.value).toBe("");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Section ───────────────────────────────────────────────────────────────
|
||||
|
||||
describe("Section", () => {
|
||||
it("renders the title", () => {
|
||||
const { container } = render(
|
||||
<Section title="Runtime config">Content here</Section>,
|
||||
);
|
||||
expect(container.textContent).toContain("Runtime config");
|
||||
});
|
||||
|
||||
it("renders children when open (defaultOpen=true)", () => {
|
||||
const { container } = render(
|
||||
<Section title="A section">Hidden content</Section>,
|
||||
);
|
||||
expect(container.textContent).toContain("Hidden content");
|
||||
});
|
||||
|
||||
it("starts closed when defaultOpen=false", () => {
|
||||
const { container } = render(
|
||||
<Section title="Collapsed" defaultOpen={false}>
|
||||
Should not be visible
|
||||
</Section>,
|
||||
);
|
||||
expect(container.textContent).not.toContain("Should not be visible");
|
||||
});
|
||||
|
||||
it("opens/closes content on title click", () => {
|
||||
const { container } = render(
|
||||
<Section title="Toggle me" defaultOpen={false}>
|
||||
Now you see me
|
||||
</Section>,
|
||||
);
|
||||
// Should be closed initially
|
||||
expect(container.textContent).not.toContain("Now you see me");
|
||||
// Click to open
|
||||
const btn = container.querySelector("button") as HTMLButtonElement;
|
||||
fireEvent.click(btn);
|
||||
expect(container.textContent).toContain("Now you see me");
|
||||
// Click to close
|
||||
fireEvent.click(btn);
|
||||
expect(container.textContent).not.toContain("Now you see me");
|
||||
});
|
||||
|
||||
it("title button has aria-expanded reflecting open state", () => {
|
||||
// Open section
|
||||
const { container: openContainer } = render(
|
||||
<Section title="A section" defaultOpen={true}>
|
||||
Open content
|
||||
</Section>,
|
||||
);
|
||||
const openBtn = openContainer.querySelector(
|
||||
"button",
|
||||
) as HTMLButtonElement;
|
||||
expect(openBtn.getAttribute("aria-expanded")).toBe("true");
|
||||
|
||||
// Closed section
|
||||
const { container: closedContainer } = render(
|
||||
<Section title="B section" defaultOpen={false}>
|
||||
Closed content
|
||||
</Section>,
|
||||
);
|
||||
const closedBtn = closedContainer.querySelector(
|
||||
"button",
|
||||
) as HTMLButtonElement;
|
||||
expect(closedBtn.getAttribute("aria-expanded")).toBe("false");
|
||||
});
|
||||
|
||||
it("toggle indicator changes between ▾ (open) and ▸ (closed)", () => {
|
||||
// Open: uses ▾
|
||||
const { container: openContainer } = render(
|
||||
<Section title="Indicator" defaultOpen={true}>
|
||||
Open
|
||||
</Section>,
|
||||
);
|
||||
// Button has two spans: title (first) and indicator (second, aria-hidden)
|
||||
const openSpans = openContainer
|
||||
.querySelectorAll("button span");
|
||||
const openIndicator = openSpans[1]?.textContent?.trim();
|
||||
expect(openIndicator).toBe("▾");
|
||||
|
||||
// Closed: uses ▸
|
||||
const { container: closedContainer } = render(
|
||||
<Section title="Indicator" defaultOpen={false}>
|
||||
Closed
|
||||
</Section>,
|
||||
);
|
||||
const closedSpans = closedContainer
|
||||
.querySelectorAll("button span");
|
||||
const closedIndicator = closedSpans[1]?.textContent?.trim();
|
||||
expect(closedIndicator).toBe("▸");
|
||||
});
|
||||
});
|
||||
@@ -127,21 +127,13 @@ export function TagList({ label, values, onChange, placeholder }: { label: strin
|
||||
|
||||
export function Section({ title, children, defaultOpen = true }: { title: string; children: React.ReactNode; defaultOpen?: boolean }) {
|
||||
const [open, setOpen] = useState(defaultOpen);
|
||||
// Stable id for aria-controls linkage
|
||||
const id = `section-content-${title.toLowerCase().replace(/\s+/g, "-")}`;
|
||||
return (
|
||||
<div className="border border-line rounded mb-2">
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => setOpen(!open)}
|
||||
aria-expanded={open}
|
||||
aria-controls={id}
|
||||
className="w-full flex items-center justify-between px-3 py-1.5 text-[10px] text-ink-mid hover:text-ink bg-surface-sunken/50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
|
||||
>
|
||||
<button type="button" onClick={() => setOpen(!open)} className="w-full flex items-center justify-between px-3 py-1.5 text-[10px] text-ink-mid hover:text-ink bg-surface-sunken/50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1">
|
||||
<span className="font-medium uppercase tracking-wider">{title}</span>
|
||||
<span aria-hidden="true">{open ? "▾" : "▸"}</span>
|
||||
<span>{open ? "▾" : "▸"}</span>
|
||||
</button>
|
||||
{open && <div id={id} className="p-3 space-y-3">{children}</div>}
|
||||
{open && <div className="p-3 space-y-3">{children}</div>}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1,142 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for KeyValueField component.
|
||||
*
|
||||
* Covers: initial password type, onChange callback (including whitespace trim
|
||||
* on type), aria-label forwarding, disabled state, and auto-hide timer setup.
|
||||
*/
|
||||
import React from "react";
|
||||
import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
|
||||
import { render, screen, fireEvent, cleanup, act } from "@testing-library/react";
|
||||
import { KeyValueField } from "../KeyValueField";
|
||||
|
||||
describe("KeyValueField — rendering", () => {
|
||||
afterEach(cleanup);
|
||||
|
||||
it("renders input with type=password by default (secret hidden)", () => {
|
||||
render(<KeyValueField value="" onChange={vi.fn()} />);
|
||||
const input = screen.getByLabelText("Secret value");
|
||||
expect(input.getAttribute("type")).toBe("password");
|
||||
});
|
||||
|
||||
it("passes custom aria-label to the input element", () => {
|
||||
render(<KeyValueField value="" onChange={vi.fn()} aria-label="API secret key" />);
|
||||
expect(screen.getByLabelText("API secret key")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("disables the input when disabled=true", () => {
|
||||
render(<KeyValueField value="secret" onChange={vi.fn()} disabled />);
|
||||
expect(screen.getByLabelText("Secret value").disabled).toBe(true);
|
||||
});
|
||||
|
||||
it("renders with the current value", () => {
|
||||
render(<KeyValueField value="sk-test-key-123" onChange={vi.fn()} />);
|
||||
expect(screen.getByLabelText("Secret value").value).toBe("sk-test-key-123");
|
||||
});
|
||||
|
||||
it("renders with the placeholder text", () => {
|
||||
render(<KeyValueField value="" onChange={vi.fn()} placeholder="Enter API key" />);
|
||||
expect(screen.getByLabelText("Secret value").getAttribute("placeholder")).toBe("Enter API key");
|
||||
});
|
||||
|
||||
it("renders the RevealToggle child button", () => {
|
||||
render(<KeyValueField value="secret" onChange={vi.fn()} />);
|
||||
// KeyValueField renders exactly one button (the RevealToggle)
|
||||
expect(screen.getByRole("button")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("KeyValueField — onChange", () => {
|
||||
afterEach(cleanup);
|
||||
|
||||
it("calls onChange with the new value when user types", () => {
|
||||
const onChange = vi.fn();
|
||||
render(<KeyValueField value="" onChange={onChange} />);
|
||||
fireEvent.change(screen.getByLabelText("Secret value"), { target: { value: "new-value" } });
|
||||
expect(onChange).toHaveBeenCalledWith("new-value");
|
||||
});
|
||||
|
||||
it("trims leading whitespace when user types with leading space", () => {
|
||||
const onChange = vi.fn();
|
||||
render(<KeyValueField value="" onChange={onChange} />);
|
||||
fireEvent.change(screen.getByLabelText("Secret value"), { target: { value: " trimmed" } });
|
||||
expect(onChange).toHaveBeenCalledWith("trimmed");
|
||||
});
|
||||
|
||||
it("trims trailing whitespace when user types with trailing space", () => {
|
||||
const onChange = vi.fn();
|
||||
render(<KeyValueField value="" onChange={onChange} />);
|
||||
fireEvent.change(screen.getByLabelText("Secret value"), { target: { value: "trimmed " } });
|
||||
expect(onChange).toHaveBeenCalledWith("trimmed");
|
||||
});
|
||||
|
||||
it("trims both sides when user types whitespace-surrounded value", () => {
|
||||
const onChange = vi.fn();
|
||||
render(<KeyValueField value="" onChange={onChange} />);
|
||||
fireEvent.change(screen.getByLabelText("Secret value"), { target: { value: " both sides " } });
|
||||
expect(onChange).toHaveBeenCalledWith("both sides");
|
||||
});
|
||||
|
||||
it("does not modify value with no whitespace", () => {
|
||||
const onChange = vi.fn();
|
||||
render(<KeyValueField value="" onChange={onChange} />);
|
||||
fireEvent.change(screen.getByLabelText("Secret value"), { target: { value: "clean-value" } });
|
||||
expect(onChange).toHaveBeenCalledWith("clean-value");
|
||||
});
|
||||
});
|
||||
|
||||
describe("KeyValueField — auto-hide timer setup", () => {
|
||||
beforeEach(() => {
|
||||
vi.useFakeTimers();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("sets up a 30s setTimeout when the component mounts with a non-empty value", () => {
|
||||
const setTimeoutSpy = vi.spyOn(global, "setTimeout");
|
||||
render(<KeyValueField value="secret" onChange={vi.fn()} />);
|
||||
// No timer should be set initially (revealed=false by default)
|
||||
const callsBeforeInteraction = setTimeoutSpy.mock.calls.length;
|
||||
|
||||
// Simulate reveal (click the only button)
|
||||
act(() => { fireEvent.click(screen.getByRole("button")); });
|
||||
|
||||
// After reveal, a 30s timer should be set
|
||||
const timerCalls = setTimeoutSpy.mock.calls.filter(
|
||||
([, delay]) => delay === 30_000,
|
||||
);
|
||||
expect(timerCalls.length).toBeGreaterThanOrEqual(1);
|
||||
});
|
||||
|
||||
it("clears existing timer when a new toggle happens before auto-hide fires", () => {
|
||||
const clearTimeoutSpy = vi.spyOn(global, "clearTimeout");
|
||||
const timerObj = {}; // fake timer ID
|
||||
vi.spyOn(global, "setTimeout").mockImplementation((fn: () => void, delay: number) => {
|
||||
return timerObj;
|
||||
});
|
||||
render(<KeyValueField value="secret" onChange={vi.fn()} />);
|
||||
|
||||
// First toggle — reveal
|
||||
act(() => { fireEvent.click(screen.getByRole("button")); });
|
||||
|
||||
// Second toggle — hide (should clear the timer from first toggle)
|
||||
act(() => { fireEvent.click(screen.getByRole("button")); });
|
||||
|
||||
// clearTimeout was called with the timer object
|
||||
expect(clearTimeoutSpy).toHaveBeenCalledWith(timerObj);
|
||||
});
|
||||
|
||||
it("clears timer on unmount", () => {
|
||||
const clearTimeoutSpy = vi.spyOn(global, "clearTimeout");
|
||||
const { unmount } = render(<KeyValueField value="secret" onChange={vi.fn()} />);
|
||||
|
||||
// Toggle reveal to start the timer
|
||||
act(() => { fireEvent.click(screen.getByRole("button")); });
|
||||
|
||||
unmount();
|
||||
expect(clearTimeoutSpy).toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
@@ -1,68 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for RevealToggle component.
|
||||
*
|
||||
* Covers: eye-icon (hidden) vs eye-off-icon (revealed), onToggle callback,
|
||||
* aria-label (default + custom), title attribute.
|
||||
*/
|
||||
import { afterEach, describe, it, expect, vi } from "vitest";
|
||||
import { render, screen, fireEvent, cleanup } from "@testing-library/react";
|
||||
import { RevealToggle } from "../RevealToggle";
|
||||
|
||||
afterEach(cleanup);
|
||||
|
||||
describe("RevealToggle", () => {
|
||||
it("renders as a button", () => {
|
||||
render(<RevealToggle revealed={false} onToggle={vi.fn()} />);
|
||||
expect(screen.getByRole("button")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("uses default aria-label when not provided", () => {
|
||||
render(<RevealToggle revealed={false} onToggle={vi.fn()} />);
|
||||
expect(screen.getByRole("button").getAttribute("aria-label")).toBe("Toggle reveal secret");
|
||||
});
|
||||
|
||||
it("uses custom aria-label when provided", () => {
|
||||
render(<RevealToggle revealed={false} onToggle={vi.fn()} label="Show password" />);
|
||||
expect(screen.getByRole("button").getAttribute("aria-label")).toBe("Show password");
|
||||
});
|
||||
|
||||
it('title is "Hide value" when revealed', () => {
|
||||
render(<RevealToggle revealed={true} onToggle={vi.fn()} />);
|
||||
expect(screen.getByRole("button").getAttribute("title")).toBe("Hide value");
|
||||
});
|
||||
|
||||
it('title is "Show value" when hidden', () => {
|
||||
render(<RevealToggle revealed={false} onToggle={vi.fn()} />);
|
||||
expect(screen.getByRole("button").getAttribute("title")).toBe("Show value");
|
||||
});
|
||||
|
||||
it("calls onToggle when clicked (revealed=true → should hide)", () => {
|
||||
const onToggle = vi.fn();
|
||||
render(<RevealToggle revealed={true} onToggle={onToggle} />);
|
||||
fireEvent.click(screen.getByRole("button"));
|
||||
expect(onToggle).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("calls onToggle when clicked (revealed=false → should show)", () => {
|
||||
const onToggle = vi.fn();
|
||||
render(<RevealToggle revealed={false} onToggle={onToggle} />);
|
||||
fireEvent.click(screen.getByRole("button"));
|
||||
expect(onToggle).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("renders the eye-open SVG (hide icon) when revealed=false", () => {
|
||||
render(<RevealToggle revealed={false} onToggle={vi.fn()} />);
|
||||
const btn = screen.getByRole("button");
|
||||
// The eye SVG contains a circle element; eye-off has a strikethrough line
|
||||
expect(btn.querySelector("circle")).toBeTruthy();
|
||||
expect(btn.querySelectorAll("line")).toHaveLength(0);
|
||||
});
|
||||
|
||||
it("renders the eye-off SVG (show icon) when revealed=true", () => {
|
||||
render(<RevealToggle revealed={true} onToggle={vi.fn()} />);
|
||||
const btn = screen.getByRole("button");
|
||||
// EyeOffIcon has a line (strikethrough) through the eye
|
||||
expect(btn.querySelectorAll("line")).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
@@ -1,88 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* StatusBadge — secret key connection status indicator.
|
||||
*
|
||||
* Per spec §4: always icon + color (never colour-only) for colour-blind users.
|
||||
* Covers: verified / invalid / unverified render branches, icon, aria-label, className.
|
||||
*/
|
||||
import { afterEach, describe, expect, it } from "vitest";
|
||||
import { render } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { StatusBadge } from "../StatusBadge";
|
||||
|
||||
afterEach(() => {
|
||||
// Prevent DOM accumulation across tests (maxWorkers=1 means all test
|
||||
// files share the same jsdom worker).
|
||||
const { cleanup } = require("@testing-library/react");
|
||||
cleanup();
|
||||
});
|
||||
|
||||
function getBadge(status: "verified" | "invalid" | "unverified") {
|
||||
const { container } = render(<StatusBadge status={status} />);
|
||||
return container.querySelector("[role=status]") as HTMLElement;
|
||||
}
|
||||
|
||||
describe("StatusBadge — icon", () => {
|
||||
it("renders ✓ for verified", () => {
|
||||
expect(getBadge("verified").textContent).toBe("✓");
|
||||
});
|
||||
|
||||
it("renders ✗ for invalid", () => {
|
||||
expect(getBadge("invalid").textContent).toBe("✗");
|
||||
});
|
||||
|
||||
it("renders ○ for unverified", () => {
|
||||
expect(getBadge("unverified").textContent).toBe("○");
|
||||
});
|
||||
});
|
||||
|
||||
describe("StatusBadge — aria-label", () => {
|
||||
it("sets 'Connection status: verified' for verified", () => {
|
||||
expect(getBadge("verified").getAttribute("aria-label")).toBe(
|
||||
"Connection status: verified",
|
||||
);
|
||||
});
|
||||
|
||||
it("sets 'Connection status: invalid' for invalid", () => {
|
||||
expect(getBadge("invalid").getAttribute("aria-label")).toBe(
|
||||
"Connection status: invalid",
|
||||
);
|
||||
});
|
||||
|
||||
it("sets 'Connection status: unverified' for unverified", () => {
|
||||
expect(getBadge("unverified").getAttribute("aria-label")).toBe(
|
||||
"Connection status: unverified",
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("StatusBadge — className", () => {
|
||||
it("applies status-badge--valid for verified", () => {
|
||||
expect(getBadge("verified").className).toContain("status-badge--valid");
|
||||
});
|
||||
|
||||
it("applies status-badge--invalid for invalid", () => {
|
||||
expect(getBadge("invalid").className).toContain("status-badge--invalid");
|
||||
});
|
||||
|
||||
it("applies status-badge--unverified for unverified", () => {
|
||||
expect(getBadge("unverified").className).toContain(
|
||||
"status-badge--unverified",
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("StatusBadge — role", () => {
|
||||
it("sets role=status", () => {
|
||||
const el = getBadge("verified");
|
||||
expect(el.getAttribute("role")).toBe("status");
|
||||
});
|
||||
});
|
||||
|
||||
describe("StatusBadge — structural", () => {
|
||||
it("renders exactly one status element", () => {
|
||||
const { container } = render(<StatusBadge status="verified" />);
|
||||
expect(container.querySelectorAll("[role=status]").length).toBe(1);
|
||||
});
|
||||
});
|
||||
@@ -1,49 +0,0 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* Tests for ValidationHint component.
|
||||
*
|
||||
* Covers: null/neutral render, error state (red ⚠ + message), valid state
|
||||
* (green ✓ + "Valid format"), ARIA role="alert" on error.
|
||||
*/
|
||||
import { afterEach, describe, it, expect } from "vitest";
|
||||
import { render, screen, cleanup } from "@testing-library/react";
|
||||
import { ValidationHint } from "../ValidationHint";
|
||||
|
||||
afterEach(cleanup);
|
||||
|
||||
describe("ValidationHint", () => {
|
||||
it("renders nothing when error is null and showValid is false", () => {
|
||||
const { container } = render(<ValidationHint error={null} showValid={false} />);
|
||||
expect(container.innerHTML).toBe("");
|
||||
});
|
||||
|
||||
it("renders nothing when error is null and showValid is undefined", () => {
|
||||
const { container } = render(<ValidationHint error={null} />);
|
||||
expect(container.innerHTML).toBe("");
|
||||
});
|
||||
|
||||
it("renders error state with ⚠ icon and message", () => {
|
||||
render(<ValidationHint error="Key name must be UPPER_SNAKE_CASE" />);
|
||||
const el = screen.getByRole("alert");
|
||||
expect(el.textContent).toContain("⚠");
|
||||
expect(el.textContent).toContain("Key name must be UPPER_SNAKE_CASE");
|
||||
});
|
||||
|
||||
it("renders valid state with ✓ and 'Valid format'", () => {
|
||||
render(<ValidationHint error={null} showValid />);
|
||||
const el = screen.getByText("Valid format");
|
||||
expect(el.textContent).toContain("✓");
|
||||
});
|
||||
|
||||
it("prefers error over valid when both are set (error is not null)", () => {
|
||||
// ValidationHint checks error first; showValid is only rendered when error is falsy.
|
||||
render(<ValidationHint error="Some error" showValid />);
|
||||
expect(screen.getByRole("alert")).toBeTruthy();
|
||||
expect(screen.queryByText("Valid format")).toBeNull();
|
||||
});
|
||||
|
||||
it("error alert has role='alert' for screen readers", () => {
|
||||
render(<ValidationHint error="Invalid format" />);
|
||||
expect(screen.getByRole("alert")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
@@ -44,4 +44,3 @@
|
||||
{"name": "mock-bigorg", "repo": "molecule-ai/molecule-ai-org-template-mock-bigorg", "ref": "main"}
|
||||
]
|
||||
}
|
||||
// Triggered by Integration Tester at 2026-05-10T08:52Z
|
||||
|
||||
@@ -4,11 +4,11 @@ Documents persistent operational findings about Gitea Actions runner behaviour
|
||||
that differ from GitHub Actions and require workarounds in workflow YAML or
|
||||
runbooks.
|
||||
|
||||
> Last updated: 2026-05-12 (infra-runtime-be-agent)
|
||||
> Last updated: 2026-05-11 (core-devops-agent)
|
||||
|
||||
---
|
||||
|
||||
## Quirk #1 — Large repo causes fetch timeout on Gitea Actions runner
|
||||
## Large repo causes fetch timeout on Gitea Actions runner
|
||||
|
||||
### Finding
|
||||
|
||||
@@ -35,11 +35,11 @@ Specifically:
|
||||
|
||||
### Affected workflows
|
||||
|
||||
| Workflow | Issue | Workaround |
|
||||
| Workflow | Issue | Fix |
|
||||
|---|---|---|
|
||||
| `harness-replays.yml` detect-changes job | `fetch-depth: 0` + `git clone` time out | Added `timeout 20 git fetch origin base.ref --depth=1` + `continue-on-error: true` + fallback to `run=true` per PR #441 |
|
||||
| `harness-replays.yml` detect-changes | `fetch-depth: 0` + `git clone` time out | Use Gitea Compare API (Gitea→Gitea, no runner network needed) — **primary fix** (PR #476) |
|
||||
| `publish-workspace-server-image.yml` | In-image `git clone` of workspace templates | Pre-clone manifest deps before compose build (Task #173 pattern) |
|
||||
| Any workflow using `fetch-depth: 0` | Full history fetch times out | Use `fetch-depth: 1` + explicit `git fetch` for needed refs |
|
||||
| Any workflow using `fetch-depth: 0` | Full history fetch times out | Use `fetch-depth: 1` + Compare API for changed-file detection |
|
||||
|
||||
### How to diagnose
|
||||
|
||||
@@ -60,7 +60,8 @@ confirming this is a repo-size constraint, not network isolation.
|
||||
|
||||
### References
|
||||
|
||||
- PR #441: fix for `harness-replays.yml` detect-changes
|
||||
- PR #476: **primary fix** — use Gitea Compare API instead of git fetch/diff
|
||||
- PR #441: legacy timeout+fallback fix (now superseded by PR #476)
|
||||
- Task #173: pre-clone manifest deps pattern for compose build
|
||||
- internal#102: tracking customer-private + marketplace third-party repos
|
||||
- `feedback_oss_first_repo_visibility_default`: 5 workspace-template repos
|
||||
@@ -68,7 +69,7 @@ confirming this is a repo-size constraint, not network isolation.
|
||||
|
||||
---
|
||||
|
||||
## Quirk #2 — `continue-on-error` only works at step level, not job level
|
||||
## `continue-on-error` only works at step level, not job level
|
||||
|
||||
### Finding
|
||||
|
||||
@@ -89,7 +90,7 @@ exits with code 0 (e.g., append `|| true` to commands that might fail).
|
||||
|
||||
| Workflow | Fix |
|
||||
|---|---|
|
||||
| `harness-replays.yml` detect-changes | Added `continue-on-error: true` to fetch step + decide step; added `|| true` to `DIFF=$(git diff ...)` per PR #441 |
|
||||
| `harness-replays.yml` detect-changes | Added `continue-on-error: true` to fetch step + decide step; replaced git diff with Compare API per PR #476 |
|
||||
|
||||
### How to diagnose
|
||||
|
||||
@@ -112,12 +113,12 @@ jobs:
|
||||
|
||||
### References
|
||||
|
||||
- Quirk #10 (this document): Gitea does NOT auto-populate `secrets.GITHUB_TOKEN`
|
||||
- PR #441: fix applied to `harness-replays.yml`
|
||||
- Gitea Actions quirk #10 (from migration checklist)
|
||||
- PR #476: Compare API fix applied to `harness-replays.yml`
|
||||
|
||||
---
|
||||
|
||||
## Quirk #3 — `workflow_dispatch.inputs` not supported
|
||||
## `workflow_dispatch.inputs` not supported
|
||||
|
||||
Gitea 1.22.6 parser rejects `workflow_dispatch.inputs`. Drop from all workflow
|
||||
YAML files ported from GitHub Actions. Manual triggers should use
|
||||
@@ -127,21 +128,21 @@ YAML files ported from GitHub Actions. Manual triggers should use
|
||||
|
||||
---
|
||||
|
||||
## Quirk #4 — `merge_group` not supported
|
||||
## `merge_group` not supported
|
||||
|
||||
Gitea has no merge queue concept. Drop `merge_group:` triggers from all
|
||||
workflow YAML files.
|
||||
|
||||
---
|
||||
|
||||
## Quirk #5 — `environment:` blocks not supported
|
||||
## `environment:` blocks not supported
|
||||
|
||||
Gitea has no environments concept. Drop `environment:` from all workflow YAML
|
||||
files. Secrets and variables are repo-level.
|
||||
|
||||
---
|
||||
|
||||
## Quirk #6 — Gitea combined status reports `failure` when all contexts are `null`
|
||||
## Gitea combined status reports `failure` when all contexts are `null`
|
||||
|
||||
### Finding
|
||||
|
||||
@@ -189,215 +190,3 @@ primary consumer of combined status and is affected.
|
||||
|
||||
- Issue #481: first real-world case of this bug (2026-05-11)
|
||||
- `feedback_no_such_thing_as_flakes`: watchdog directive
|
||||
|
||||
---
|
||||
|
||||
## Quirk #7 — TBD
|
||||
|
||||
*[Placeholder — document here when a new Gitea Actions quirk is discovered.]*
|
||||
|
||||
### Finding
|
||||
|
||||
*[What Gitea Actions does differently from GitHub Actions.]*
|
||||
|
||||
### Impact
|
||||
|
||||
*[Which workflows or operations are affected.]*
|
||||
|
||||
### Workaround
|
||||
|
||||
*[How to work around this quirk.]*
|
||||
|
||||
### References
|
||||
|
||||
- internal#[N]: first observation
|
||||
|
||||
---
|
||||
|
||||
## Quirk #8 — TBD
|
||||
|
||||
*[Placeholder — document here when a new Gitea Actions quirk is discovered.]*
|
||||
|
||||
### Finding
|
||||
|
||||
*[What Gitea Actions does differently from GitHub Actions.]*
|
||||
|
||||
### Impact
|
||||
|
||||
*[Which workflows or operations are affected.]*
|
||||
|
||||
### Workaround
|
||||
|
||||
*[How to work around this quirk.]*
|
||||
|
||||
### References
|
||||
|
||||
- internal#[N]: first observation
|
||||
|
||||
---
|
||||
|
||||
## Quirk #9 — TBD
|
||||
|
||||
*[Placeholder — document here when a new Gitea Actions quirk is discovered.]*
|
||||
|
||||
### Finding
|
||||
|
||||
*[What Gitea Actions does differently from GitHub Actions.]*
|
||||
|
||||
### Impact
|
||||
|
||||
*[Which workflows or operations are affected.]*
|
||||
|
||||
### Workaround
|
||||
|
||||
*[How to work around this quirk.]*
|
||||
|
||||
### References
|
||||
|
||||
- internal#[N]: first observation
|
||||
|
||||
---
|
||||
|
||||
## Quirk #10 — Gitea does NOT auto-populate `secrets.GITHUB_TOKEN`
|
||||
|
||||
### Finding
|
||||
|
||||
Gitea Actions (1.22.6) does **not** auto-populate `secrets.GITHUB_TOKEN`
|
||||
the way GitHub Actions does. A workflow that references `secrets.GITHUB_TOKEN`
|
||||
without explicitly provisioning a named secret gets an empty string — not a
|
||||
read-only token scoped to the repo.
|
||||
|
||||
### Impact
|
||||
|
||||
Workflows that call the Gitea REST API using `secrets.GITHUB_TOKEN` as auth
|
||||
receive **HTTP 401** on every API call. Affected workflows in molecule-core:
|
||||
|
||||
| Workflow | Symptom | Workaround |
|
||||
|---|---|---|
|
||||
| `gate-check-v3.yml` | Reports BLOCKED on every PR | Provision `SOP_TIER_CHECK_TOKEN`; update workflow to use it |
|
||||
| `qa-review.yml` | Fails immediately on PR open | Same — needs named secret |
|
||||
| `security-review.yml` | Fails immediately on PR open | Same — needs named secret |
|
||||
|
||||
### How to diagnose
|
||||
|
||||
Add a debug step to the failing workflow:
|
||||
|
||||
```yaml
|
||||
- name: Diagnose token
|
||||
run: |
|
||||
echo "Token present: ${{ secrets.GITHUB_TOKEN != '' }}"
|
||||
curl -sS --fail -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
|
||||
"$GITHUB_SERVER_URL/api/v1/user" | jq -r '.login'
|
||||
# Expected (GitHub): prints your username.
|
||||
# Actual (Gitea): HTTP 401 or empty string.
|
||||
```
|
||||
|
||||
### References
|
||||
|
||||
- internal#325: root-cause analysis and token provisioning
|
||||
- `feedback_gitea_no_auto_supplied_github_token`
|
||||
|
||||
---
|
||||
|
||||
## Quirk #11 — PR-create event dispatcher races — only 1 of N workflows fires on `pull_request opened`
|
||||
|
||||
### Finding
|
||||
|
||||
When a PR is created via the Gitea web UI or API, the Gitea Actions event
|
||||
dispatcher may fire **only 1 of N eligible workflows** on the initial
|
||||
`pull_request opened` event. All other eligible workflows are silently dropped.
|
||||
|
||||
This was observed on molecule-core PR #558 (created 2026-05-11T19:54:10Z):
|
||||
12+ workflows had no `paths:` filter and should have fired, but only
|
||||
`sop-tier-check.yml` dispatched.
|
||||
|
||||
Concurrent PRs created within the same minute received 12–30 dispatches each,
|
||||
confirming this is specific to the PR-create event dispatch, not a general
|
||||
runner capacity issue.
|
||||
|
||||
### Impact
|
||||
|
||||
- PRs may not run the full CI suite on first open.
|
||||
- `gate-check-v3`, `secret-scan`, `qa-review`, and `security-review` can be
|
||||
silently absent from the PR's status checks.
|
||||
- Branch protection may block merge even though CI is effectively green.
|
||||
|
||||
### How to diagnose
|
||||
|
||||
```bash
|
||||
# List workflow runs for the PR:
|
||||
gh run list --event pull_request --repo molecule-ai/molecule-core \
|
||||
| grep "$(gh pr view $PR --json number --jq '.number')"
|
||||
|
||||
# Expected: 12+ runs on PR open.
|
||||
# Actual (when race fires): only 1 run.
|
||||
```
|
||||
|
||||
### Workaround
|
||||
|
||||
Force a second dispatch by pushing a no-op synchronize commit:
|
||||
|
||||
```bash
|
||||
git commit --allow-empty -m "chore: trigger workflows [skip ci]"
|
||||
git push
|
||||
```
|
||||
|
||||
The synchronize event fires a second `pull_request` event, which reliably
|
||||
triggers all eligible workflows.
|
||||
|
||||
### References
|
||||
|
||||
- internal#329: first observation on PR #558
|
||||
- `feedback_gitea_pr_create_dispatcher_race`
|
||||
|
||||
---
|
||||
|
||||
## When you find a new quirk
|
||||
|
||||
Copy the template below, increment the quirk number, and fill in the finding,
|
||||
impact, workaround, and references. Place the new section in the **correct
|
||||
numerical position** (before the next higher-numbered quirk). Update this
|
||||
section's final paragraph to remove the next slot's number.
|
||||
|
||||
### Template
|
||||
|
||||
```markdown
|
||||
## Quirk #N — <short title>
|
||||
|
||||
### Finding
|
||||
|
||||
<What Gitea Actions does differently from GitHub Actions.>
|
||||
|
||||
### Impact
|
||||
|
||||
<Which workflows or operations are affected. Include an affected workflows
|
||||
table if more than one is affected.>
|
||||
|
||||
### How to diagnose
|
||||
|
||||
<Shell commands or API calls that confirm this is the quirk, not a real failure.>
|
||||
|
||||
### Workaround
|
||||
|
||||
<How to work around this quirk in workflow YAML or operations.>
|
||||
|
||||
### References
|
||||
|
||||
- internal#[N]: first observation
|
||||
- <Any Gitea issue, feedback label, or upstream bug tracker reference>
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Open questions for Gitea 1.23
|
||||
|
||||
- [ ] **act_runner concurrent-job cap**: issue #305 — runner saturation under
|
||||
merge burst; needs `max_concurrent_jobs` cap configured on act_runner
|
||||
- [ ] **Infisical→Gitea secret-sync**: issue #307 — eliminate manual secret
|
||||
PUTs by wiring an Infisical cron to the Gitea API
|
||||
- [ ] **PR-create dispatcher race resolution**: internal #329 — is there a
|
||||
Gitea fix or config knob to disable the race? File upstream bug if not
|
||||
- [ ] **GITHUB_TOKEN auto-population**: internal #325 — is this on the
|
||||
Gitea 1.23 roadmap? If not, the workaround (named secret) is the permanent
|
||||
answer
|
||||
|
||||
|
||||
@@ -34,17 +34,6 @@ WS_DIR="${2:?Missing workspace-templates dir}"
|
||||
ORG_DIR="${3:?Missing org-templates dir}"
|
||||
PLUGINS_DIR="${4:?Missing plugins dir}"
|
||||
|
||||
# Strip JSON5-style // comments from manifest.json before parsing.
|
||||
# The automated Integration Tester appends a trailing comment
|
||||
# (// Triggered by ... ) which is valid JSON5 but not standard JSON.
|
||||
# jq's default parser rejects it. This sed removes only full-line comments
|
||||
# (lines starting with optional whitespace followed by //) before jq reads the file.
|
||||
_strip_comments() {
|
||||
# Remove full-line // comments (whitespace-safe); pass-through for non-comment lines
|
||||
sed 's/^[[:space:]]*\/\/.*//' "$MANIFEST"
|
||||
}
|
||||
MANIFEST_JSON="$(_strip_comments)"
|
||||
|
||||
EXPECTED=0
|
||||
CLONED=0
|
||||
|
||||
@@ -99,15 +88,15 @@ clone_category() {
|
||||
mkdir -p "$target_dir"
|
||||
|
||||
local count
|
||||
count=$(echo "$MANIFEST_JSON" | jq -r ".${category} | length")
|
||||
count=$(jq -r ".${category} | length" "$MANIFEST")
|
||||
EXPECTED=$((EXPECTED + count))
|
||||
|
||||
local i=0
|
||||
while [ "$i" -lt "$count" ]; do
|
||||
local name repo ref
|
||||
name=$(echo "$MANIFEST_JSON" | jq -r ".${category}[$i].name")
|
||||
repo=$(echo "$MANIFEST_JSON" | jq -r ".${category}[$i].repo")
|
||||
ref=$(echo "$MANIFEST_JSON" | jq -r ".${category}[$i].ref // \"main\"")
|
||||
name=$(jq -r ".${category}[$i].name" "$MANIFEST")
|
||||
repo=$(jq -r ".${category}[$i].repo" "$MANIFEST")
|
||||
ref=$(jq -r ".${category}[$i].ref // \"main\"" "$MANIFEST")
|
||||
|
||||
# Idempotent: skip if the target already looks populated. Lets the
|
||||
# README quickstart rerun setup.sh safely without having to delete
|
||||
|
||||
@@ -189,78 +189,6 @@ def test_is_red_no_statuses(wd_module):
|
||||
assert failed == []
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------
|
||||
# Per-entry vendor-truth key (rev4) — see status-reaper rev4 sibling
|
||||
#
|
||||
# Gitea 1.22.6 returns per-entry items in combined.statuses[] with key
|
||||
# `status`, not `state`. Pre-rev4 code only read `state` → failed[]
|
||||
# was always empty → render_body always emitted the fallback "no
|
||||
# per-context entries were in a red state". These tests use the
|
||||
# canonical Gitea shape to lock the fix in.
|
||||
# --------------------------------------------------------------------------
|
||||
def test_is_red_vendor_truth_status_key_under_pending(wd_module):
|
||||
"""Real Gitea 1.22.6 shape: per-entry uses `status`. A single failed
|
||||
context counts as red even when combined is `pending`. Pre-rev4
|
||||
this returned `(False, [])` because `s.get("state")` was None."""
|
||||
red, failed = wd_module.is_red({
|
||||
"state": "pending",
|
||||
"statuses": [
|
||||
{"context": "ci/lint", "status": "success"},
|
||||
{"context": "ci/test", "status": "failure"},
|
||||
{"context": "ci/build", "status": "pending"},
|
||||
],
|
||||
})
|
||||
assert red is True
|
||||
assert [s["context"] for s in failed] == ["ci/test"]
|
||||
|
||||
|
||||
def test_is_red_status_takes_precedence_over_state(wd_module):
|
||||
"""If both keys present (defensive), `status` (vendor truth) wins."""
|
||||
red, failed = wd_module.is_red({
|
||||
"state": "pending",
|
||||
"statuses": [
|
||||
# `status=failure` is truth even though `state=success` is
|
||||
# stale. Locking in the precedence prevents a hypothetical
|
||||
# future Gitea release that emits both from re-introducing
|
||||
# the bug under a different shape.
|
||||
{"context": "ci/test", "status": "failure", "state": "success"},
|
||||
],
|
||||
})
|
||||
assert red is True
|
||||
assert len(failed) == 1
|
||||
|
||||
|
||||
def test_is_red_state_only_fallback_still_works(wd_module):
|
||||
"""Backward-compat: a legacy fixture or future Gitea variant that
|
||||
only emits `state` still trips the red detection via the fallback
|
||||
chain. Keeps pre-rev4 fixtures green during the rev4 rollout."""
|
||||
red, failed = wd_module.is_red({
|
||||
"state": "pending",
|
||||
"statuses": [
|
||||
{"context": "ci/test", "state": "failure"}, # legacy shape
|
||||
],
|
||||
})
|
||||
assert red is True
|
||||
assert len(failed) == 1
|
||||
|
||||
|
||||
def test_render_body_uses_status_key_for_per_entry_state(wd_module):
|
||||
"""render_body must surface the per-entry `status` value in the
|
||||
issue body. Pre-rev4 it read `state` (always None on real Gitea) →
|
||||
every issue body said `(no state)`, defeating the diagnostic."""
|
||||
failed = [
|
||||
{"context": "ci/test", "status": "failure",
|
||||
"target_url": "https://example.test/run/1",
|
||||
"description": "broke"},
|
||||
]
|
||||
body = wd_module.render_body("deadbeefcafe1234", failed, {})
|
||||
assert "`failure`" in body, (
|
||||
"render_body did not surface per-entry status — likely still "
|
||||
"reading `state` key only (rev1-3 bug)."
|
||||
)
|
||||
assert "(no state)" not in body
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------
|
||||
# Happy path — main is green, no issue created
|
||||
# --------------------------------------------------------------------------
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@@ -35,12 +35,6 @@ GITEA_HOST = os.environ.get("GITEA_HOST", "git.moleculesai.app")
|
||||
GITEA_TOKEN = os.environ.get("GITEA_TOKEN", os.environ.get("GITHUB_TOKEN", ""))
|
||||
API_BASE = f"https://{GITEA_HOST}/api/v1"
|
||||
|
||||
# Timeout in seconds for all HTTP calls. Defence-in-depth: ensures a missing or
|
||||
# invalid SOP_TIER_CHECK_TOKEN causes a fast (~15 s) failure rather than an
|
||||
# indefinite hang. The real fix is provisioning the token; this caps worst-case
|
||||
# wall-clock on a broken/unreachable Gitea host.
|
||||
DEFAULT_TIMEOUT = 15
|
||||
|
||||
|
||||
def api_get(path: str) -> dict | list:
|
||||
url = f"{API_BASE}{path}"
|
||||
@@ -52,7 +46,7 @@ def api_get(path: str) -> dict | list:
|
||||
},
|
||||
)
|
||||
try:
|
||||
with urllib.request.urlopen(req, timeout=DEFAULT_TIMEOUT) as r:
|
||||
with urllib.request.urlopen(req) as r:
|
||||
return json.loads(r.read())
|
||||
except urllib.error.HTTPError as e:
|
||||
body = e.read().decode(errors="replace")
|
||||
@@ -322,7 +316,7 @@ def signal_3_staleness(pr_number: int, repo: str) -> dict:
|
||||
|
||||
# ── Signal 6: CI required-checks awareness ───────────────────────────────────
|
||||
|
||||
def signal_6_ci(pr_number: int, repo: str, branch: str | None = None, pr_data: dict | None = None) -> dict:
|
||||
def signal_6_ci(pr_number: int, repo: str, branch: str = "main") -> dict:
|
||||
"""
|
||||
Query combined CI status for PR head commit.
|
||||
Find required status checks on target branch.
|
||||
@@ -330,12 +324,8 @@ def signal_6_ci(pr_number: int, repo: str, branch: str | None = None, pr_data: d
|
||||
"""
|
||||
owner, name = repo.split("/", 1)
|
||||
|
||||
# Re-use PR data if already fetched by caller; otherwise fetch once.
|
||||
if pr_data is None:
|
||||
pr_data = api_get(f"/repos/{owner}/{name}/pulls/{pr_number}")
|
||||
head_sha = pr_data["head"]["sha"]
|
||||
# Fall back to PR's actual base branch when no explicit branch is given
|
||||
branch = branch or pr_data.get("base", {}).get("ref", "main")
|
||||
pr = api_get(f"/repos/{owner}/{name}/pulls/{pr_number}")
|
||||
head_sha = pr["head"]["sha"]
|
||||
|
||||
# Combined status of PR head
|
||||
combined = api_get(f"/repos/{owner}/{name}/commits/{head_sha}/status")
|
||||
@@ -344,12 +334,9 @@ def signal_6_ci(pr_number: int, repo: str, branch: str | None = None, pr_data: d
|
||||
# Individual check statuses
|
||||
# Gitea Actions uses "status" (pending/success/failure) not "state" for
|
||||
# individual check entries. "state" is null for pending runs.
|
||||
# Exclude our own prior status to prevent self-referential failure loops.
|
||||
check_statuses = {}
|
||||
for s in combined.get("statuses") or []:
|
||||
ctx = s["context"]
|
||||
if "gate-check" not in ctx.lower():
|
||||
check_statuses[ctx] = s.get("status", "pending")
|
||||
check_statuses[s["context"]] = s.get("status", "pending")
|
||||
|
||||
# Try to get branch protection for required checks
|
||||
required_checks = []
|
||||
@@ -371,17 +358,10 @@ def signal_6_ci(pr_number: int, repo: str, branch: str | None = None, pr_data: d
|
||||
else:
|
||||
passing_required.append(f"{ctx} (pending)")
|
||||
|
||||
# NOTE: do NOT use ci_state (combined_state) as a fallback verdict driver.
|
||||
# The combined_state is computed over ALL statuses including this
|
||||
# gate-check's own prior result. Using it as a fallback creates a
|
||||
# self-referential loop: gate-check posts failure → combined_state
|
||||
# becomes failure → script re-blocks → posts failure again.
|
||||
# The check_statuses dict already excludes gate-check (Bug-1 fix from
|
||||
# PR #547). Use failing_required as the sole CI gate; if no required
|
||||
# checks are defined on the branch, return CLEAR rather than re-using
|
||||
# the combined_state which includes our own status.
|
||||
if failing_required:
|
||||
verdict = "CI_FAIL"
|
||||
elif ci_state == "failure":
|
||||
verdict = "CI_FAIL"
|
||||
elif ci_state == "pending":
|
||||
verdict = "CI_PENDING"
|
||||
else:
|
||||
@@ -479,21 +459,21 @@ def format_comment(repo: str, pr_number: int, verdict: str, gates: list[dict], b
|
||||
lines.append(f"_gate-check-v3 · repo={repo} · pr={pr_number}_")
|
||||
return "\n".join(lines)
|
||||
|
||||
lines.append("")
|
||||
lines.append(f"_gate-check-v3 · repo={repo} · pr={pr_number}_")
|
||||
|
||||
return "\n".join(lines)
|
||||
|
||||
|
||||
# ── Main ─────────────────────────────────────────────────────────────────────
|
||||
|
||||
def run(repo: str, pr_number: int, post_comment: bool = False) -> dict:
|
||||
try:
|
||||
# Fetch PR once to get base ref for signal_6_ci
|
||||
owner, name = repo.split("/", 1)
|
||||
pr = api_get(f"/repos/{owner}/{name}/pulls/{pr_number}")
|
||||
base_ref = pr.get("base", {}).get("ref", "main")
|
||||
|
||||
gates = [
|
||||
signal_1_comment_scan(pr_number, repo),
|
||||
signal_2_reviews(pr_number, repo),
|
||||
signal_3_staleness(pr_number, repo),
|
||||
signal_6_ci(pr_number, repo, branch=base_ref, pr_data=pr),
|
||||
signal_6_ci(pr_number, repo),
|
||||
]
|
||||
verdict, blockers = compute_verdict(gates)
|
||||
|
||||
@@ -521,24 +501,18 @@ def run(repo: str, pr_number: int, post_comment: bool = False) -> dict:
|
||||
# Check if a gate-check comment already exists to avoid spamming
|
||||
existing = api_list(f"/repos/{owner}/{name}/issues/{pr_number}/comments")
|
||||
our_comments = [c for c in existing if "[gate-check-v3]" in (c.get("body") or "")]
|
||||
try:
|
||||
if our_comments:
|
||||
# Update latest
|
||||
comment_id = our_comments[-1]["id"]
|
||||
url = f"{API_BASE}/repos/{owner}/{name}/issues/comments/{comment_id}"
|
||||
req = urllib.request.Request(url, data=json.dumps({"body": comment_body}).encode(), headers=headers, method="PATCH")
|
||||
with urllib.request.urlopen(req, timeout=DEFAULT_TIMEOUT) as r:
|
||||
r.read()
|
||||
else:
|
||||
url = f"{API_BASE}/repos/{owner}/{name}/issues/{pr_number}/comments"
|
||||
req = urllib.request.Request(url, data=json.dumps({"body": comment_body}).encode(), headers=headers, method="POST")
|
||||
with urllib.request.urlopen(req, timeout=DEFAULT_TIMEOUT) as r:
|
||||
r.read()
|
||||
except urllib.error.HTTPError as e:
|
||||
if e.code == 403:
|
||||
print(f"WARN: --post-comment 403 (token scope) — verdict={verdict}; skipping comment-post", file=sys.stderr)
|
||||
else:
|
||||
raise
|
||||
if our_comments:
|
||||
# Update latest
|
||||
comment_id = our_comments[-1]["id"]
|
||||
url = f"{API_BASE}/repos/{owner}/{name}/issues/comments/{comment_id}"
|
||||
req = urllib.request.Request(url, data=json.dumps({"body": comment_body}).encode(), headers=headers, method="PATCH")
|
||||
with urllib.request.urlopen(req) as r:
|
||||
r.read()
|
||||
else:
|
||||
url = f"{API_BASE}/repos/{owner}/{name}/issues/{pr_number}/comments"
|
||||
req = urllib.request.Request(url, data=json.dumps({"body": comment_body}).encode(), headers=headers, method="POST")
|
||||
with urllib.request.urlopen(req) as r:
|
||||
r.read()
|
||||
|
||||
return result
|
||||
|
||||
|
||||
@@ -983,16 +983,7 @@ func expectExecuteDelegationBase(mock sqlmock.Sqlmock) {
|
||||
WithArgs("dispatched", "", testSourceID, testDelegationID).
|
||||
WillReturnResult(sqlmock.NewResult(0, 1))
|
||||
|
||||
// CanCommunicate: source != target → fires two getWorkspaceRef lookups.
|
||||
// Both test fixtures have parent_id = NULL (root-level siblings) → allowed.
|
||||
// Order matches call order: source first, then target.
|
||||
mock.ExpectQuery("SELECT id, parent_id FROM workspaces WHERE id").
|
||||
WithArgs(testSourceID).
|
||||
WillReturnRows(sqlmock.NewRows([]string{"id", "parent_id"}).AddRow(testSourceID, nil))
|
||||
mock.ExpectQuery("SELECT id, parent_id FROM workspaces WHERE id").
|
||||
WithArgs(testTargetID).
|
||||
WillReturnRows(sqlmock.NewRows([]string{"id", "parent_id"}).AddRow(testTargetID, nil))
|
||||
|
||||
// CanCommunicate (source=target self-call is always allowed — no DB lookup needed)
|
||||
// resolveAgentURL: reads ws:{id}:url from Redis, falls back to DB for target
|
||||
mock.ExpectQuery("SELECT url, status FROM workspaces WHERE id = ").
|
||||
WithArgs(testTargetID).
|
||||
|
||||
@@ -697,31 +697,6 @@ func (h *OrgHandler) Import(c *gin.Context) {
|
||||
})
|
||||
return
|
||||
}
|
||||
|
||||
// Per-workspace RequiredEnv preflight: checks that every RequiredEnv
|
||||
// declared at the workspace level is covered by either (a) a global
|
||||
// secret key (already validated above) or (b) a key present in the
|
||||
// workspace's on-disk .env files (org root .env + per-workspace
|
||||
// <files_dir>/.env). If neither covers the key the workspace is
|
||||
// imported NOT CONFIGURED, which silently breaks the workspace at
|
||||
// start time — the container boots without the required credential
|
||||
// and every LLM call 401s or fails silently. Issue #232.
|
||||
// orgBaseDir is empty when importing via body.Template (inline YAML);
|
||||
// in that case we cannot check .env files, so we skip this check
|
||||
// and fall back to the global-only gate above (which correctly
|
||||
// rejects any strict requirement not covered by global_secrets).
|
||||
if orgBaseDir != "" {
|
||||
wsMissing := collectPerWorkspaceUnsatisfied(tmpl.Workspaces, orgBaseDir, configured)
|
||||
if len(wsMissing) > 0 {
|
||||
c.JSON(http.StatusPreconditionFailed, gin.H{
|
||||
"error": "missing per-workspace required environment variables",
|
||||
"missing_workspace_env": wsMissing,
|
||||
"template": tmpl.Name,
|
||||
"suggestion": "add these keys to the workspace's .env file or set them as global secrets before importing",
|
||||
})
|
||||
return
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
results := []map[string]interface{}{}
|
||||
|
||||
@@ -346,7 +346,7 @@ func (g *gitFetcher) Fetch(ctx context.Context, rootDir, host, repoPath, ref str
|
||||
// MkdirTemp creates the dir; git clone refuses to clone into a
|
||||
// non-empty dir. Remove + recreate empty.
|
||||
os.RemoveAll(tmpDir)
|
||||
cloneAndConfig := gitArgs("clone", "--quiet", "--depth=1", "-b", ref, cloneURL, tmpDir)
|
||||
cloneAndConfig := append(gitArgs("clone", "--quiet", "--depth=1", "-b", ref, cloneURL, tmpDir))
|
||||
cmd := exec.CommandContext(ctx, "git", cloneAndConfig...)
|
||||
cmd.Env = append(os.Environ(), "GIT_TERMINAL_PROMPT=0")
|
||||
if out, err := cmd.CombinedOutput(); err != nil {
|
||||
|
||||
@@ -941,65 +941,6 @@ func flattenAndSortRequirements(by map[string]EnvRequirement) []EnvRequirement {
|
||||
// can investigate.
|
||||
const globalSecretsPreflightLimit = 10000
|
||||
|
||||
// PerWorkspaceUnsatisfied describes one per-workspace RequiredEnv that is
|
||||
// not covered by either a global secret or a key present in the
|
||||
// corresponding .env file.
|
||||
type PerWorkspaceUnsatisfied struct {
|
||||
Workspace string `json:"workspace"`
|
||||
FilesDir string `json:"files_dir,omitempty"`
|
||||
Unsatisfied EnvRequirement `json:"unsatisfied_env"`
|
||||
}
|
||||
|
||||
// collectPerWorkspaceUnsatisfied recursively walks workspaces and returns
|
||||
// per-workspace RequiredEnv entries that are not covered by (a) a global
|
||||
// secret key or (b) a key present in the workspace's .env file(s) (org root
|
||||
// .env + per-workspace <files_dir>/.env). This complements
|
||||
// collectOrgEnv + loadConfiguredGlobalSecretKeys, which together only
|
||||
// validate global-level RequiredEnv against global_secrets. The .env
|
||||
// lookup mirrors the runtime resolution in createWorkspaceTree so that
|
||||
// the preflight result matches what the container actually receives at
|
||||
// start time.
|
||||
func collectPerWorkspaceUnsatisfied(workspaces []OrgWorkspace, orgBaseDir string, globalSecrets map[string]struct{}) []PerWorkspaceUnsatisfied {
|
||||
var out []PerWorkspaceUnsatisfied
|
||||
var walk func([]OrgWorkspace)
|
||||
walk = func(wsList []OrgWorkspace) {
|
||||
for _, ws := range wsList {
|
||||
// Build the set of keys available to this workspace from .env.
|
||||
// This is the same three-source stack that createWorkspaceTree
|
||||
// injects into the container:
|
||||
// 1. Org root .env (parseEnvFile, no filesDir)
|
||||
// 2. Workspace <files_dir>/.env (if filesDir is set)
|
||||
// 3. Persona bootstrap env (MOLECULE_PERSONA_ROOT/<filesDir>/env)
|
||||
// Items 1+2 are on-disk and testable; item 3 is host-only and
|
||||
// skipped here (persona env does NOT satisfy required_env —
|
||||
// it carries identity tokens, not workspace LLM keys).
|
||||
envFromFiles := loadWorkspaceEnv(orgBaseDir, ws.FilesDir)
|
||||
// Convert map[string]string (from .env files) to map[string]struct{}
|
||||
// to match IsSatisfied's signature.
|
||||
envSet := make(map[string]struct{}, len(envFromFiles))
|
||||
for k := range envFromFiles {
|
||||
envSet[k] = struct{}{}
|
||||
}
|
||||
for _, req := range ws.RequiredEnv {
|
||||
if req.IsSatisfied(globalSecrets) {
|
||||
continue // covered by a global secret
|
||||
}
|
||||
if req.IsSatisfied(envSet) {
|
||||
continue // covered by a per-workspace .env file
|
||||
}
|
||||
out = append(out, PerWorkspaceUnsatisfied{
|
||||
Workspace: ws.Name,
|
||||
FilesDir: ws.FilesDir,
|
||||
Unsatisfied: req,
|
||||
})
|
||||
}
|
||||
walk(ws.Children)
|
||||
}
|
||||
}
|
||||
walk(workspaces)
|
||||
return out
|
||||
}
|
||||
|
||||
func loadConfiguredGlobalSecretKeys(ctx context.Context) (map[string]struct{}, error) {
|
||||
rows, err := db.DB.QueryContext(ctx,
|
||||
`SELECT key FROM global_secrets WHERE octet_length(encrypted_value) > 0 LIMIT $1`,
|
||||
|
||||
@@ -1,226 +0,0 @@
|
||||
package handlers
|
||||
|
||||
import (
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// TestCollectPerWorkspaceUnsatisfied_BothFiles covers the case where a key
|
||||
// is present in both the org root .env and the workspace-specific .env. Both
|
||||
// should satisfy the requirement (no entry in output).
|
||||
func TestCollectPerWorkspaceUnsatisfied_BothFiles(t *testing.T) {
|
||||
tmp := t.TempDir()
|
||||
writeEnvFile(t, tmp, ".env", "PER_WS_KEY=globalvalue")
|
||||
writeEnvFile(t, tmp, "ws-a/.env", "PER_WS_KEY=wsvalue")
|
||||
|
||||
workspaces := []OrgWorkspace{
|
||||
{Name: "ws-a", FilesDir: "ws-a", RequiredEnv: []EnvRequirement{{Name: "PER_WS_KEY"}}},
|
||||
}
|
||||
|
||||
// Global secret covers it.
|
||||
globals := map[string]struct{}{"PER_WS_KEY": {}}
|
||||
missing := collectPerWorkspaceUnsatisfied(workspaces, tmp, globals)
|
||||
|
||||
if len(missing) != 0 {
|
||||
t.Errorf("PER_WS_KEY present in global + .env: should be satisfied, got %d missing", len(missing))
|
||||
}
|
||||
}
|
||||
|
||||
// TestCollectPerWorkspaceUnsatisfied_WorkspaceEnvOnly covers a key present
|
||||
// only in the workspace-specific .env file (not global). Should be satisfied.
|
||||
func TestCollectPerWorkspaceUnsatisfied_WorkspaceEnvOnly(t *testing.T) {
|
||||
tmp := t.TempDir()
|
||||
writeEnvFile(t, tmp, "dev-lead/.env", "WORKSPACE_KEY=val")
|
||||
|
||||
workspaces := []OrgWorkspace{
|
||||
{Name: "Dev Lead", FilesDir: "dev-lead", RequiredEnv: []EnvRequirement{{Name: "WORKSPACE_KEY"}}},
|
||||
}
|
||||
|
||||
globals := map[string]struct{}{} // nothing in global
|
||||
missing := collectPerWorkspaceUnsatisfied(workspaces, tmp, globals)
|
||||
|
||||
if len(missing) != 0 {
|
||||
t.Errorf("WORKSPACE_KEY in ws .env only: should be satisfied, got %d missing", len(missing))
|
||||
}
|
||||
}
|
||||
|
||||
// TestCollectPerWorkspaceUnsatisfied_OrgRootEnvOnly covers a key present
|
||||
// only in the org root .env file (not per-workspace). Should be satisfied.
|
||||
func TestCollectPerWorkspaceUnsatisfied_OrgRootEnvOnly(t *testing.T) {
|
||||
tmp := t.TempDir()
|
||||
writeEnvFile(t, tmp, ".env", "ORG_ROOT_KEY=val")
|
||||
|
||||
workspaces := []OrgWorkspace{
|
||||
{Name: "ws-b", FilesDir: "ws-b", RequiredEnv: []EnvRequirement{{Name: "ORG_ROOT_KEY"}}},
|
||||
}
|
||||
|
||||
globals := map[string]struct{}{}
|
||||
missing := collectPerWorkspaceUnsatisfied(workspaces, tmp, globals)
|
||||
|
||||
if len(missing) != 0 {
|
||||
t.Errorf("ORG_ROOT_KEY in org root .env only: should be satisfied, got %d missing", len(missing))
|
||||
}
|
||||
}
|
||||
|
||||
// TestCollectPerWorkspaceUnsatisfied_GlobalCovers checks that a global
|
||||
// secret alone satisfies a per-workspace RequiredEnv even when the .env
|
||||
// files don't have the key.
|
||||
func TestCollectPerWorkspaceUnsatisfied_GlobalCovers(t *testing.T) {
|
||||
tmp := t.TempDir()
|
||||
// No .env files at all.
|
||||
|
||||
workspaces := []OrgWorkspace{
|
||||
{Name: "ws-c", RequiredEnv: []EnvRequirement{{Name: "GLOBAL_COVERED"}}},
|
||||
}
|
||||
|
||||
globals := map[string]struct{}{"GLOBAL_COVERED": {}}
|
||||
missing := collectPerWorkspaceUnsatisfied(workspaces, tmp, globals)
|
||||
|
||||
if len(missing) != 0 {
|
||||
t.Errorf("GLOBAL_COVERED satisfied by global: should be satisfied, got %d missing", len(missing))
|
||||
}
|
||||
}
|
||||
|
||||
// TestCollectPerWorkspaceUnsatisfied_Missing covers the core bug: a
|
||||
// RequiredEnv declared at the workspace level where the key is absent from
|
||||
// both global_secrets and the .env file. The import MUST return 412.
|
||||
func TestCollectPerWorkspaceUnsatisfied_Missing(t *testing.T) {
|
||||
tmp := t.TempDir()
|
||||
// No .env files at all.
|
||||
|
||||
workspaces := []OrgWorkspace{
|
||||
{Name: "Dev Lead", FilesDir: "dev-lead", RequiredEnv: []EnvRequirement{{Name: "MISSING_REQUIRED_KEY"}}},
|
||||
}
|
||||
|
||||
globals := map[string]struct{}{} // no global secret
|
||||
missing := collectPerWorkspaceUnsatisfied(workspaces, tmp, globals)
|
||||
|
||||
if len(missing) != 1 {
|
||||
t.Fatalf("expected 1 missing entry, got %d", len(missing))
|
||||
}
|
||||
if missing[0].Workspace != "Dev Lead" {
|
||||
t.Errorf("expected workspace 'Dev Lead', got %q", missing[0].Workspace)
|
||||
}
|
||||
if missing[0].Unsatisfied.Name != "MISSING_REQUIRED_KEY" {
|
||||
t.Errorf("expected unsatisfied key 'MISSING_REQUIRED_KEY', got %q", missing[0].Unsatisfied.Name)
|
||||
}
|
||||
if missing[0].FilesDir != "dev-lead" {
|
||||
t.Errorf("expected files_dir 'dev-lead', got %q", missing[0].FilesDir)
|
||||
}
|
||||
}
|
||||
|
||||
// TestCollectPerWorkspaceUnsatisfied_AnyOfGroup covers an any-of group where
|
||||
// none of the alternatives are present in global or .env. Should report
|
||||
// the group as unsatisfied.
|
||||
func TestCollectPerWorkspaceUnsatisfied_AnyOfGroup(t *testing.T) {
|
||||
tmp := t.TempDir()
|
||||
|
||||
workspaces := []OrgWorkspace{
|
||||
{
|
||||
Name: "Claude Bot",
|
||||
FilesDir: "claude-bot",
|
||||
RequiredEnv: []EnvRequirement{
|
||||
{AnyOf: []string{"ANTHROPIC_API_KEY", "CLAUDE_CODE_OAUTH_TOKEN"}},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
globals := map[string]struct{}{}
|
||||
missing := collectPerWorkspaceUnsatisfied(workspaces, tmp, globals)
|
||||
|
||||
if len(missing) != 1 {
|
||||
t.Fatalf("expected 1 missing any-of entry, got %d", len(missing))
|
||||
}
|
||||
if missing[0].Workspace != "Claude Bot" {
|
||||
t.Errorf("expected workspace 'Claude Bot', got %q", missing[0].Workspace)
|
||||
}
|
||||
if len(missing[0].Unsatisfied.AnyOf) != 2 {
|
||||
t.Errorf("expected any-of group with 2 members, got %v", missing[0].Unsatisfied.AnyOf)
|
||||
}
|
||||
}
|
||||
|
||||
// TestCollectPerWorkspaceUnsatisfied_NestedChildren covers grandchildren
|
||||
// workspaces that also declare RequiredEnv. The recursive walk must visit
|
||||
// children and grandchildren.
|
||||
func TestCollectPerWorkspaceUnsatisfied_NestedChildren(t *testing.T) {
|
||||
tmp := t.TempDir()
|
||||
|
||||
workspaces := []OrgWorkspace{
|
||||
{
|
||||
Name: "Root",
|
||||
Children: []OrgWorkspace{
|
||||
{
|
||||
Name: "Child",
|
||||
Children: []OrgWorkspace{
|
||||
{Name: "Grandchild", FilesDir: "grandchild", RequiredEnv: []EnvRequirement{{Name: "DEEP_KEY"}}},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
globals := map[string]struct{}{}
|
||||
missing := collectPerWorkspaceUnsatisfied(workspaces, tmp, globals)
|
||||
|
||||
if len(missing) != 1 {
|
||||
t.Fatalf("expected 1 missing entry from grandchild, got %d", len(missing))
|
||||
}
|
||||
if missing[0].Workspace != "Grandchild" {
|
||||
t.Errorf("expected 'Grandchild', got %q", missing[0].Workspace)
|
||||
}
|
||||
}
|
||||
|
||||
// TestCollectPerWorkspaceUnsatisfied_EmptyOrgBaseDir covers the case where
|
||||
// orgBaseDir is empty (inline template import). No .env files can be
|
||||
// checked, so missing keys cannot be attributed to .env absence. The
|
||||
// function should NOT crash and should only report entries satisfiable
|
||||
// by global (all missing since globals is empty).
|
||||
func TestCollectPerWorkspaceUnsatisfied_EmptyOrgBaseDir(t *testing.T) {
|
||||
workspaces := []OrgWorkspace{
|
||||
{Name: "ws-x", RequiredEnv: []EnvRequirement{{Name: "KEY_X"}}},
|
||||
}
|
||||
|
||||
globals := map[string]struct{}{}
|
||||
missing := collectPerWorkspaceUnsatisfied(workspaces, "", globals)
|
||||
|
||||
// With no orgBaseDir and no global, KEY_X must be reported missing.
|
||||
if len(missing) != 1 {
|
||||
t.Errorf("expected 1 missing with empty orgBaseDir, got %d", len(missing))
|
||||
}
|
||||
}
|
||||
|
||||
// TestCollectPerWorkspaceUnsatisfied_MultipleWorkspaces reports only the
|
||||
// workspace whose RequiredEnv is unsatisfied, not the whole batch.
|
||||
func TestCollectPerWorkspaceUnsatisfied_MultipleWorkspaces(t *testing.T) {
|
||||
tmp := t.TempDir()
|
||||
writeEnvFile(t, tmp, "ws-ok/.env", "OK_KEY=val")
|
||||
|
||||
workspaces := []OrgWorkspace{
|
||||
{Name: "ws-ok", FilesDir: "ws-ok", RequiredEnv: []EnvRequirement{{Name: "OK_KEY"}}},
|
||||
{Name: "ws-missing", FilesDir: "ws-missing", RequiredEnv: []EnvRequirement{{Name: "BAD_KEY"}}},
|
||||
}
|
||||
|
||||
globals := map[string]struct{}{}
|
||||
missing := collectPerWorkspaceUnsatisfied(workspaces, tmp, globals)
|
||||
|
||||
if len(missing) != 1 {
|
||||
t.Errorf("expected exactly 1 missing (BAD_KEY), got %d", len(missing))
|
||||
}
|
||||
if missing[0].Workspace != "ws-missing" {
|
||||
t.Errorf("expected missing workspace 'ws-missing', got %q", missing[0].Workspace)
|
||||
}
|
||||
}
|
||||
|
||||
// writeEnvFile is a test helper that creates a .env file at the given path
|
||||
// with the given content.
|
||||
func writeEnvFile(t *testing.T, baseDir, relPath, content string) {
|
||||
t.Helper()
|
||||
fullPath := filepath.Join(baseDir, relPath)
|
||||
if err := os.MkdirAll(filepath.Dir(fullPath), 0755); err != nil {
|
||||
t.Fatalf("mkdirAll: %v", err)
|
||||
}
|
||||
if err := os.WriteFile(fullPath, []byte(content), 0644); err != nil {
|
||||
t.Fatalf("writeFile %s: %v", fullPath, err)
|
||||
}
|
||||
}
|
||||
@@ -8,7 +8,6 @@ import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"log"
|
||||
"net/http"
|
||||
@@ -286,51 +285,17 @@ func (h *WorkspaceHandler) Create(c *gin.Context) {
|
||||
c.JSON(http.StatusBadRequest, gin.H{"error": "delivery_mode must be 'push' or 'poll'"})
|
||||
return
|
||||
}
|
||||
// Insert workspace with runtime + delivery_mode persisted in DB (inside transaction).
|
||||
//
|
||||
// Auto-suffix on (parent_id, name) collision via insertWorkspaceWithNameRetry:
|
||||
// the partial-unique index `workspaces_parent_name_uniq` (migration
|
||||
// 20260506000000) protects /org/import from TOCTOU duplicates, but the
|
||||
// pre-fix Canvas Create path bubbled the raw pq violation as a 500 on
|
||||
// double-click. Helper retries with " (2)", " (3)", … up to maxNameSuffix,
|
||||
// returns the actually-persisted name (which we MUST thread back into
|
||||
// payload + broadcast so the canvas displays what the DB has).
|
||||
const insertWorkspaceSQL = `
|
||||
// Insert workspace with runtime + delivery_mode persisted in DB (inside transaction)
|
||||
_, err := tx.ExecContext(ctx, `
|
||||
INSERT INTO workspaces (id, name, role, tier, runtime, awareness_namespace, status, parent_id, workspace_dir, workspace_access, budget_limit, max_concurrent_tasks, delivery_mode)
|
||||
VALUES ($1, $2, $3, $4, $5, $6, 'provisioning', $7, $8, $9, $10, $11, $12)
|
||||
`
|
||||
insertArgs := []any{id, payload.Name, role, payload.Tier, payload.Runtime, awarenessNamespace, payload.ParentID, workspaceDir, workspaceAccess, payload.BudgetLimit, maxConcurrent, deliveryMode}
|
||||
persistedName, currentTx, err := insertWorkspaceWithNameRetry(
|
||||
ctx,
|
||||
tx,
|
||||
// Closure captures ctx so the retry tx uses the same request context;
|
||||
// nil opts mirrors the original BeginTx call above.
|
||||
func(ctx context.Context) (*sql.Tx, error) { return db.DB.BeginTx(ctx, nil) },
|
||||
payload.Name,
|
||||
1, // args[1] is name
|
||||
insertWorkspaceSQL,
|
||||
insertArgs,
|
||||
)
|
||||
`, id, payload.Name, role, payload.Tier, payload.Runtime, awarenessNamespace, payload.ParentID, workspaceDir, workspaceAccess, payload.BudgetLimit, maxConcurrent, deliveryMode)
|
||||
if err != nil {
|
||||
if currentTx != nil {
|
||||
currentTx.Rollback() //nolint:errcheck
|
||||
}
|
||||
if errors.Is(err, errWorkspaceNameExhausted) {
|
||||
log.Printf("Create workspace: name suffix exhausted for base %q under parent %v", payload.Name, payload.ParentID)
|
||||
c.JSON(http.StatusConflict, gin.H{"error": "workspace name already in use; please pick a different name"})
|
||||
return
|
||||
}
|
||||
tx.Rollback() //nolint:errcheck
|
||||
log.Printf("Create workspace error: %v", err)
|
||||
c.JSON(http.StatusInternalServerError, gin.H{"error": "failed to create workspace"})
|
||||
return
|
||||
}
|
||||
// Helper may have rolled back the original tx and returned a fresh one;
|
||||
// rebind so the remaining secrets-INSERT + Commit run on the live tx.
|
||||
tx = currentTx
|
||||
if persistedName != payload.Name {
|
||||
log.Printf("Create workspace %s: name collision auto-suffix %q -> %q", id, payload.Name, persistedName)
|
||||
payload.Name = persistedName
|
||||
}
|
||||
|
||||
// Persist initial secrets from the create payload (inside same transaction).
|
||||
// nil/empty map is a no-op. Any failure rolls back the workspace insert
|
||||
|
||||
@@ -1,183 +0,0 @@
|
||||
package handlers
|
||||
|
||||
// workspace_create_name.go — disambiguate workspace names on the
|
||||
// Canvas POST /workspaces path so a double-clicked template card
|
||||
// does not surface raw Postgres errors.
|
||||
//
|
||||
// Background (#2872 + post-2026-05-06 follow-up):
|
||||
// - Migration 20260506000000_workspaces_unique_parent_name added a
|
||||
// partial UNIQUE index on (COALESCE(parent_id, sentinel), name)
|
||||
// WHERE status != 'removed'. It exists to close the TOCTOU race in
|
||||
// /org/import that previously let two concurrent POSTs both INSERT
|
||||
// the same (parent_id, name) row.
|
||||
// - /org/import handles the constraint via `ON CONFLICT DO NOTHING`
|
||||
// + idempotent re-select (handlers/org_import.go).
|
||||
// - The Canvas Create handler (handlers/workspace.go) did NOT — a
|
||||
// duplicate POST returned an opaque HTTP 500 with the raw pq error
|
||||
// in the server log. Repro path: user clicks a template card twice
|
||||
// in canvas before the first response paints.
|
||||
//
|
||||
// Resolution: auto-suffix the user-typed name on collision. The
|
||||
// uniqueness constraint required for #2872 stays in place; only the
|
||||
// Canvas Create path's reaction to it changes. Names become a
|
||||
// free-form display label that the platform disambiguates; row
|
||||
// identity is carried by the workspace id (UUID).
|
||||
//
|
||||
// Suffix shape: " (2)", " (3)", … up to N=maxNameSuffix. Chosen over
|
||||
// numeric "-2" / "_2" because the parenthesised form is the standard
|
||||
// disambiguation pattern users already expect from Finder / Explorer
|
||||
// / Google Docs / file managers. Stays under the 255-char name cap
|
||||
// (#688 — validated by validateWorkspaceFields) for any reasonable
|
||||
// base name; parens are not in yamlSpecialChars so the existing YAML-
|
||||
// safety guard is unaffected.
|
||||
|
||||
import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"errors"
|
||||
"fmt"
|
||||
"strings"
|
||||
|
||||
"github.com/lib/pq"
|
||||
)
|
||||
|
||||
// maxNameSuffix bounds the suffix-retry loop. 20 is well above any
|
||||
// plausible accidental-double-click rate (typical: 2-3 races) and
|
||||
// keeps the worst-case handler latency to ~20 round-trips. If a
|
||||
// caller actually wants 21+ workspaces with the same base name, they
|
||||
// can pre-disambiguate client-side; the platform refuses to spin
|
||||
// indefinitely.
|
||||
const maxNameSuffix = 20
|
||||
|
||||
// workspacesUniqueIndexName is the partial-unique index this handler
|
||||
// is reacting to. Pinned to the migration's index name so we
|
||||
// distinguish "the base name collision we know how to handle" from
|
||||
// every other unique violation (which we surface as 409 without
|
||||
// retry — silently auto-suffixing a name on the wrong constraint
|
||||
// would mask real bugs).
|
||||
const workspacesUniqueIndexName = "workspaces_parent_name_uniq"
|
||||
|
||||
// errWorkspaceNameExhausted is returned when maxNameSuffix retries
|
||||
// all fail because every candidate name in the (base, " (2)", …,
|
||||
// " (N)") sequence is taken. The caller maps this to HTTP 409
|
||||
// Conflict — the user must rename and re-try.
|
||||
var errWorkspaceNameExhausted = errors.New("workspace name exhausted: too many duplicates of base name under same parent")
|
||||
|
||||
// dbExec is the minimum surface our retry helper needs from
|
||||
// *sql.Tx (or *sql.DB). Declared as an interface so tests can
|
||||
// substitute a fake without standing up a real DB connection.
|
||||
type dbExec interface {
|
||||
ExecContext(ctx context.Context, query string, args ...any) (sql.Result, error)
|
||||
}
|
||||
|
||||
// insertWorkspaceWithNameRetry runs the workspace INSERT and, if it
|
||||
// hits the parent-name unique-violation, retries with a suffixed
|
||||
// name. Returns the name actually persisted (which the caller MUST
|
||||
// use in the response and in broadcast payloads — without it the
|
||||
// canvas would show the user-typed name while the DB has the
|
||||
// suffixed one, and the next poll would surprise the user with the
|
||||
// "real" name).
|
||||
//
|
||||
// The query string is intentionally a parameter (not hardcoded) so
|
||||
// the helper composes with future schema additions without growing
|
||||
// a new arity each time. Only the FIRST arg of args must be the
|
||||
// name placeholder ($1) — the helper rewrites args[0] on retry; all
|
||||
// other args pass through verbatim. (This matches the workspace.go
|
||||
// INSERT below where $1 is the id and $2 is name, so the caller
|
||||
// passes nameArgIndex=1.)
|
||||
//
|
||||
// On the unique-violation, the original tx is rolled back and a
|
||||
// fresh one is begun before retry — Postgres marks the tx aborted
|
||||
// on any error, so re-using it would silently no-op every
|
||||
// subsequent statement.
|
||||
//
|
||||
// `beginTx` is a closure (not a *sql.DB) so the caller controls the
|
||||
// transaction-options + the context. Returning the fresh tx each
|
||||
// retry means the caller can commit it once the helper succeeds.
|
||||
//
|
||||
// `query` MUST be parameterized — the name placeholder is rewritten
|
||||
// via args[nameArgIndex], not via string substitution. Passing a
|
||||
// fmt.Sprintf'd query string would silently disable the safety.
|
||||
func insertWorkspaceWithNameRetry(
|
||||
ctx context.Context,
|
||||
tx *sql.Tx,
|
||||
beginTx func(ctx context.Context) (*sql.Tx, error),
|
||||
baseName string,
|
||||
nameArgIndex int,
|
||||
query string,
|
||||
args []any,
|
||||
) (finalName string, finalTx *sql.Tx, err error) {
|
||||
if nameArgIndex < 0 || nameArgIndex >= len(args) {
|
||||
return "", tx, fmt.Errorf("insertWorkspaceWithNameRetry: nameArgIndex %d out of range for %d args", nameArgIndex, len(args))
|
||||
}
|
||||
|
||||
current := tx
|
||||
for attempt := 0; attempt <= maxNameSuffix; attempt++ {
|
||||
candidate := baseName
|
||||
if attempt > 0 {
|
||||
candidate = fmt.Sprintf("%s (%d)", baseName, attempt+1)
|
||||
}
|
||||
args[nameArgIndex] = candidate
|
||||
_, execErr := current.ExecContext(ctx, query, args...)
|
||||
if execErr == nil {
|
||||
return candidate, current, nil
|
||||
}
|
||||
if !isParentNameUniqueViolation(execErr) {
|
||||
// Any other error (encoding, connection, FK violation,
|
||||
// other unique index) — return as-is. Caller decides
|
||||
// status code.
|
||||
return "", current, execErr
|
||||
}
|
||||
// Hit the partial-unique index. Postgres has aborted this
|
||||
// tx — roll it back and start fresh before retrying with a
|
||||
// new candidate name.
|
||||
_ = current.Rollback()
|
||||
if attempt == maxNameSuffix {
|
||||
break
|
||||
}
|
||||
next, txErr := beginTx(ctx)
|
||||
if txErr != nil {
|
||||
return "", nil, fmt.Errorf("begin retry tx after name collision: %w", txErr)
|
||||
}
|
||||
current = next
|
||||
}
|
||||
// Exhausted: the helper rolled back the last tx already. Return
|
||||
// nil tx so the caller does not try to commit/rollback again.
|
||||
return "", nil, errWorkspaceNameExhausted
|
||||
}
|
||||
|
||||
// isParentNameUniqueViolation reports whether err is the specific
|
||||
// partial-unique-index violation we know how to auto-suffix. We pin
|
||||
// on BOTH the SQLSTATE 23505 (unique_violation) AND the constraint
|
||||
// name so we don't silently rename around an unrelated unique index
|
||||
// (e.g. a future workspaces.slug unique).
|
||||
//
|
||||
// errors.As is used (not a `.(*pq.Error)` type assertion) because
|
||||
// lib/pq wraps the error through fmt.Errorf in some paths.
|
||||
//
|
||||
// Defensive fallback: if Constraint is empty (older pq builds, or
|
||||
// the error came through a wrapper that dropped the field), match
|
||||
// on the error message as well. The message form is brittle
|
||||
// (postgres locale-dependent) but every English-locale Postgres
|
||||
// emits the index name verbatim.
|
||||
func isParentNameUniqueViolation(err error) bool {
|
||||
if err == nil {
|
||||
return false
|
||||
}
|
||||
var pqErr *pq.Error
|
||||
if errors.As(err, &pqErr) {
|
||||
if pqErr.Code != "23505" {
|
||||
return false
|
||||
}
|
||||
if pqErr.Constraint == workspacesUniqueIndexName {
|
||||
return true
|
||||
}
|
||||
// Fallback for builds that drop Constraint metadata.
|
||||
return strings.Contains(pqErr.Message, workspacesUniqueIndexName)
|
||||
}
|
||||
// Last-resort string match — the pq.Error type was lost
|
||||
// through wrapping. Same English-locale caveat as above; keeps
|
||||
// the helper robust in test seams that synthesize errors via
|
||||
// fmt.Errorf("pq: …").
|
||||
return strings.Contains(err.Error(), workspacesUniqueIndexName)
|
||||
}
|
||||
@@ -1,251 +0,0 @@
|
||||
//go:build integration
|
||||
// +build integration
|
||||
|
||||
// workspace_create_name_integration_test.go — REAL Postgres
|
||||
// integration test for the duplicate-name auto-suffix retry
|
||||
// helper.
|
||||
//
|
||||
// Run with:
|
||||
//
|
||||
// INTEGRATION_DB_URL="postgres://postgres:test@localhost:55432/molecule?sslmode=disable" \
|
||||
// go test -tags=integration ./internal/handlers/ -run Integration_WorkspaceCreate_NameRetry -v
|
||||
//
|
||||
// CI: piggybacks on .github/workflows/handlers-postgres-integration.yml
|
||||
// (path-filter includes workspace-server/internal/handlers/**, which
|
||||
// covers this file).
|
||||
//
|
||||
// Why this is NOT a sqlmock test
|
||||
// ------------------------------
|
||||
// sqlmock CANNOT verify the actual partial-unique-index
|
||||
// behaviour. The unit tests in workspace_create_name_test.go pin
|
||||
// the helper's retry contract under a fake driver error, but only
|
||||
// a real Postgres can confirm:
|
||||
//
|
||||
// - The migration 20260506000000 actually created the index.
|
||||
// - lib/pq emits SQLSTATE 23505 with Constraint =
|
||||
// "workspaces_parent_name_uniq" (not a synonym, not the message
|
||||
// fallback).
|
||||
// - The COALESCE(parent_id, sentinel) target collapses NULL
|
||||
// parent_ids so two root-level workspaces with the same name
|
||||
// collide as the migration intends.
|
||||
// - The WHERE status != 'removed' partial filter exempts
|
||||
// tombstoned rows from blocking re-use.
|
||||
//
|
||||
// Per feedback_mandatory_local_e2e_before_ship: ship-mode requires
|
||||
// the helper to be exercised against a real Postgres before the PR
|
||||
// merges.
|
||||
|
||||
package handlers
|
||||
|
||||
import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"fmt"
|
||||
"os"
|
||||
"testing"
|
||||
|
||||
"github.com/google/uuid"
|
||||
_ "github.com/lib/pq"
|
||||
)
|
||||
|
||||
// integrationDB_WorkspaceCreateName opens $INTEGRATION_DB_URL,
|
||||
// applies the parent-name partial unique index if missing
|
||||
// (idempotent), wipes the test row range, and returns the
|
||||
// connection.
|
||||
//
|
||||
// We intentionally do NOT wipe every row in `workspaces` because
|
||||
// the integration DB may be shared with other tests in this
|
||||
// package; we tag inserts with a per-test UUID prefix and clean up
|
||||
// only those.
|
||||
func integrationDB_WorkspaceCreateName(t *testing.T) *sql.DB {
|
||||
t.Helper()
|
||||
url := os.Getenv("INTEGRATION_DB_URL")
|
||||
if url == "" {
|
||||
t.Skip("INTEGRATION_DB_URL not set; skipping (see file header)")
|
||||
}
|
||||
conn, err := sql.Open("postgres", url)
|
||||
if err != nil {
|
||||
t.Fatalf("open: %v", err)
|
||||
}
|
||||
if err := conn.Ping(); err != nil {
|
||||
t.Fatalf("ping: %v", err)
|
||||
}
|
||||
t.Cleanup(func() { conn.Close() })
|
||||
|
||||
// Ensure the constraint we're testing exists. If the migration
|
||||
// already ran (the dev/CI default), this is a fast no-op via
|
||||
// IF NOT EXISTS. If the test DB was created from a snapshot
|
||||
// taken before 2026-05-06, we apply it here.
|
||||
if _, err := conn.ExecContext(context.Background(), `
|
||||
CREATE UNIQUE INDEX IF NOT EXISTS workspaces_parent_name_uniq
|
||||
ON workspaces (
|
||||
COALESCE(parent_id, '00000000-0000-0000-0000-000000000000'::uuid),
|
||||
name
|
||||
)
|
||||
WHERE status != 'removed'
|
||||
`); err != nil {
|
||||
t.Fatalf("ensure constraint: %v", err)
|
||||
}
|
||||
return conn
|
||||
}
|
||||
|
||||
// cleanupTestRows removes any rows inserted under the given name
|
||||
// prefix. Called via t.Cleanup so a failing test still leaves the
|
||||
// DB usable for the next run.
|
||||
func cleanupTestRows(t *testing.T, conn *sql.DB, namePrefix string) {
|
||||
t.Helper()
|
||||
if _, err := conn.ExecContext(context.Background(),
|
||||
`DELETE FROM workspaces WHERE name LIKE $1`, namePrefix+"%"); err != nil {
|
||||
t.Logf("cleanup (non-fatal): %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestIntegration_WorkspaceCreate_NameRetry_AutoSuffixesOnCollision
|
||||
// exercises the helper end-to-end against a real Postgres:
|
||||
//
|
||||
// 1. INSERT a row with name "<prefix>-Repro" — succeeds.
|
||||
// 2. Run insertWorkspaceWithNameRetry with the same name —
|
||||
// partial-unique violation fires, helper retries with
|
||||
// " (2)", that succeeds.
|
||||
// 3. SELECT the row by id, confirm name = "<prefix>-Repro (2)".
|
||||
// 4. Run helper AGAIN — second collision, helper retries with
|
||||
// " (3)".
|
||||
//
|
||||
// This is the live-test that proves the partial-index behaviour
|
||||
// matches the migration's intent — sqlmock cannot reach this depth.
|
||||
func TestIntegration_WorkspaceCreate_NameRetry_AutoSuffixesOnCollision(t *testing.T) {
|
||||
conn := integrationDB_WorkspaceCreateName(t)
|
||||
ctx := context.Background()
|
||||
|
||||
// Per-test prefix so concurrent test runs don't collide on the
|
||||
// shared integration DB; also tags rows for cleanupTestRows.
|
||||
prefix := fmt.Sprintf("itest-namesuffix-%s", uuid.New().String()[:8])
|
||||
t.Cleanup(func() { cleanupTestRows(t, conn, prefix) })
|
||||
|
||||
baseName := prefix + "-Repro"
|
||||
|
||||
// Step 1 — seed an existing row to collide against. Uses a
|
||||
// minimal column set (the production INSERT has many more
|
||||
// columns; we only need the ones the partial-unique index
|
||||
// targets + the NOT NULL columns required by the schema).
|
||||
firstID := uuid.New().String()
|
||||
if _, err := conn.ExecContext(ctx, `
|
||||
INSERT INTO workspaces (id, name, tier, runtime, awareness_namespace, status)
|
||||
VALUES ($1, $2, 2, 'claude-code', $3, 'provisioning')
|
||||
`, firstID, baseName, "workspace:"+firstID); err != nil {
|
||||
t.Fatalf("seed first row: %v", err)
|
||||
}
|
||||
|
||||
// Step 2 — same name, helper must auto-suffix to " (2)".
|
||||
beginTx := func(ctx context.Context) (*sql.Tx, error) { return conn.BeginTx(ctx, nil) }
|
||||
|
||||
tx, err := beginTx(ctx)
|
||||
if err != nil {
|
||||
t.Fatalf("begin tx: %v", err)
|
||||
}
|
||||
secondID := uuid.New().String()
|
||||
query := `
|
||||
INSERT INTO workspaces (id, name, tier, runtime, awareness_namespace, status)
|
||||
VALUES ($1, $2, 2, 'claude-code', $3, 'provisioning')
|
||||
`
|
||||
args := []any{secondID, baseName, "workspace:" + secondID}
|
||||
persistedName, finalTx, err := insertWorkspaceWithNameRetry(
|
||||
ctx, tx, beginTx, baseName, 1, query, args,
|
||||
)
|
||||
if err != nil {
|
||||
t.Fatalf("retry helper on second insert: %v", err)
|
||||
}
|
||||
if persistedName != baseName+" (2)" {
|
||||
t.Fatalf("persistedName = %q, want exactly %q", persistedName, baseName+" (2)")
|
||||
}
|
||||
if err := finalTx.Commit(); err != nil {
|
||||
t.Fatalf("commit second: %v", err)
|
||||
}
|
||||
|
||||
// Step 3 — verify DB state matches helper's return value.
|
||||
var actualName string
|
||||
if err := conn.QueryRowContext(ctx,
|
||||
`SELECT name FROM workspaces WHERE id = $1`, secondID).Scan(&actualName); err != nil {
|
||||
t.Fatalf("re-select second: %v", err)
|
||||
}
|
||||
if actualName != baseName+" (2)" {
|
||||
t.Fatalf("DB row name = %q, want exactly %q (helper return value lied to caller)",
|
||||
actualName, baseName+" (2)")
|
||||
}
|
||||
|
||||
// Step 4 — third collision must produce " (3)".
|
||||
tx3, err := beginTx(ctx)
|
||||
if err != nil {
|
||||
t.Fatalf("begin tx3: %v", err)
|
||||
}
|
||||
thirdID := uuid.New().String()
|
||||
args3 := []any{thirdID, baseName, "workspace:" + thirdID}
|
||||
persistedName3, finalTx3, err := insertWorkspaceWithNameRetry(
|
||||
ctx, tx3, beginTx, baseName, 1, query, args3,
|
||||
)
|
||||
if err != nil {
|
||||
t.Fatalf("retry helper on third insert: %v", err)
|
||||
}
|
||||
if persistedName3 != baseName+" (3)" {
|
||||
t.Fatalf("third persistedName = %q, want exactly %q",
|
||||
persistedName3, baseName+" (3)")
|
||||
}
|
||||
if err := finalTx3.Commit(); err != nil {
|
||||
t.Fatalf("commit third: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestIntegration_WorkspaceCreate_NameRetry_TombstonedRowDoesNotCollide
|
||||
// confirms the partial-index `WHERE status != 'removed'` predicate
|
||||
// matches the helper's assumptions: a deleted (status='removed')
|
||||
// workspace MUST NOT block re-creation under the same name.
|
||||
//
|
||||
// This is the post-2026-05-06 contract /org/import already relies
|
||||
// on; the helper inherits it for the Canvas Create path. A
|
||||
// regression in the migration's predicate would silently break
|
||||
// both surfaces.
|
||||
func TestIntegration_WorkspaceCreate_NameRetry_TombstonedRowDoesNotCollide(t *testing.T) {
|
||||
conn := integrationDB_WorkspaceCreateName(t)
|
||||
ctx := context.Background()
|
||||
|
||||
prefix := fmt.Sprintf("itest-tombstone-%s", uuid.New().String()[:8])
|
||||
t.Cleanup(func() { cleanupTestRows(t, conn, prefix) })
|
||||
|
||||
baseName := prefix + "-RevivedName"
|
||||
|
||||
// Seed a row, then tombstone it.
|
||||
firstID := uuid.New().String()
|
||||
if _, err := conn.ExecContext(ctx, `
|
||||
INSERT INTO workspaces (id, name, tier, runtime, awareness_namespace, status)
|
||||
VALUES ($1, $2, 2, 'claude-code', $3, 'removed')
|
||||
`, firstID, baseName, "workspace:"+firstID); err != nil {
|
||||
t.Fatalf("seed tombstoned row: %v", err)
|
||||
}
|
||||
|
||||
// New INSERT with the same name MUST succeed without any
|
||||
// suffix — the partial index excludes the tombstoned row.
|
||||
beginTx := func(ctx context.Context) (*sql.Tx, error) { return conn.BeginTx(ctx, nil) }
|
||||
tx, err := beginTx(ctx)
|
||||
if err != nil {
|
||||
t.Fatalf("begin tx: %v", err)
|
||||
}
|
||||
secondID := uuid.New().String()
|
||||
query := `
|
||||
INSERT INTO workspaces (id, name, tier, runtime, awareness_namespace, status)
|
||||
VALUES ($1, $2, 2, 'claude-code', $3, 'provisioning')
|
||||
`
|
||||
args := []any{secondID, baseName, "workspace:" + secondID}
|
||||
persistedName, finalTx, err := insertWorkspaceWithNameRetry(
|
||||
ctx, tx, beginTx, baseName, 1, query, args,
|
||||
)
|
||||
if err != nil {
|
||||
t.Fatalf("retry helper after tombstone: %v", err)
|
||||
}
|
||||
if persistedName != baseName {
|
||||
t.Fatalf("persistedName = %q, want %q (tombstoned row should NOT force a suffix)",
|
||||
persistedName, baseName)
|
||||
}
|
||||
if err := finalTx.Commit(); err != nil {
|
||||
t.Fatalf("commit: %v", err)
|
||||
}
|
||||
}
|
||||
@@ -1,302 +0,0 @@
|
||||
package handlers
|
||||
|
||||
// workspace_create_name_test.go — unit + table tests for the
|
||||
// duplicate-name auto-suffix retry helper.
|
||||
//
|
||||
// Phase 3 of the dev-SOP: write the test first, watch it fail in
|
||||
// the way you predicted, then watch the fix make it pass. The fix
|
||||
// landed in workspace_create_name.go; these tests pin its contract
|
||||
// so a refactor that drops the retry (or auto-suffixes on the
|
||||
// WRONG constraint) blows up loud.
|
||||
//
|
||||
// sqlmock CANNOT verify the real partial-index behaviour — that
|
||||
// lives in the companion integration test
|
||||
// workspace_create_name_integration_test.go (real Postgres).
|
||||
|
||||
import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"errors"
|
||||
"fmt"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/DATA-DOG/go-sqlmock"
|
||||
"github.com/Molecule-AI/molecule-monorepo/platform/internal/db"
|
||||
"github.com/lib/pq"
|
||||
)
|
||||
|
||||
// fakePqUniqueViolation reproduces the SQLSTATE/Constraint shape
|
||||
// the real lib/pq driver emits when an INSERT hits
|
||||
// workspaces_parent_name_uniq. Used by the unit test to drive the
|
||||
// retry path without standing up a real Postgres.
|
||||
func fakePqUniqueViolation(constraint string) error {
|
||||
return &pq.Error{
|
||||
Code: "23505",
|
||||
Constraint: constraint,
|
||||
Message: fmt.Sprintf("duplicate key value violates unique constraint %q", constraint),
|
||||
}
|
||||
}
|
||||
|
||||
// TestIsParentNameUniqueViolation_PinsTheConstraint exhaustively
|
||||
// pins which error shapes the helper considers "auto-suffix
|
||||
// eligible." A regression that broadens this predicate (e.g.
|
||||
// matching ANY 23505) would mask real bugs; a regression that
|
||||
// narrows it (e.g. dropping the message fallback) would let the
|
||||
// 500-on-double-click bug recur on driver builds that strip
|
||||
// Constraint metadata.
|
||||
func TestIsParentNameUniqueViolation_PinsTheConstraint(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
err error
|
||||
want bool
|
||||
}{
|
||||
{"nil error", nil, false},
|
||||
{"plain string error", errors.New("network down"), false},
|
||||
{
|
||||
name: "23505 on parent_name_uniq via pq.Error",
|
||||
err: fakePqUniqueViolation("workspaces_parent_name_uniq"),
|
||||
want: true,
|
||||
},
|
||||
{
|
||||
name: "23505 on a DIFFERENT unique index — must NOT be auto-suffixed",
|
||||
err: fakePqUniqueViolation("workspaces_slug_uniq"),
|
||||
want: false,
|
||||
},
|
||||
{
|
||||
name: "23505 with empty Constraint — fall back to message match",
|
||||
err: &pq.Error{
|
||||
Code: "23505",
|
||||
Message: `duplicate key value violates unique constraint "workspaces_parent_name_uniq"`,
|
||||
},
|
||||
want: true,
|
||||
},
|
||||
{
|
||||
name: "non-23505 (e.g. FK violation) on the same index name in message — must NOT match",
|
||||
err: &pq.Error{
|
||||
Code: "23503",
|
||||
Message: `foreign key references workspaces_parent_name_uniq region`,
|
||||
},
|
||||
want: false,
|
||||
},
|
||||
{
|
||||
name: "wrapped via fmt.Errorf (errors.As must unwrap)",
|
||||
err: fmt.Errorf("create workspace: %w", fakePqUniqueViolation("workspaces_parent_name_uniq")),
|
||||
want: true,
|
||||
},
|
||||
{
|
||||
name: "raw string from a non-pq error mentioning the index — last-resort fallback",
|
||||
err: errors.New(`pq: duplicate key value violates unique constraint "workspaces_parent_name_uniq"`),
|
||||
want: true,
|
||||
},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
tc := tc
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
got := isParentNameUniqueViolation(tc.err)
|
||||
if got != tc.want {
|
||||
t.Fatalf("isParentNameUniqueViolation(%v) = %v, want %v", tc.err, got, tc.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// TestInsertWorkspaceWithNameRetry_FirstAttemptSucceeds confirms
|
||||
// the helper does NOT modify the name when the first INSERT
|
||||
// succeeds — a naive implementation that always wraps in a retry
|
||||
// loop could accidentally add a " (1)" suffix even on the happy
|
||||
// path.
|
||||
func TestInsertWorkspaceWithNameRetry_FirstAttemptSucceeds(t *testing.T) {
|
||||
mock := setupTestDB(t)
|
||||
|
||||
mock.ExpectBegin()
|
||||
mock.ExpectExec("INSERT INTO workspaces").
|
||||
WithArgs("id-1", "MyWorkspace").
|
||||
WillReturnResult(sqlmock.NewResult(0, 1))
|
||||
|
||||
tx, err := getDBHandle(t).BeginTx(context.Background(), nil)
|
||||
if err != nil {
|
||||
t.Fatalf("begin: %v", err)
|
||||
}
|
||||
|
||||
name, finalTx, err := insertWorkspaceWithNameRetry(
|
||||
context.Background(),
|
||||
tx,
|
||||
func(ctx context.Context) (*sql.Tx, error) {
|
||||
return getDBHandle(t).BeginTx(ctx, nil)
|
||||
},
|
||||
"MyWorkspace",
|
||||
1,
|
||||
"INSERT INTO workspaces (id, name) VALUES ($1, $2)",
|
||||
[]any{"id-1", "MyWorkspace"},
|
||||
)
|
||||
if err != nil {
|
||||
t.Fatalf("retry helper: %v", err)
|
||||
}
|
||||
if name != "MyWorkspace" {
|
||||
t.Fatalf("name = %q, want %q (happy path must NOT suffix)", name, "MyWorkspace")
|
||||
}
|
||||
if finalTx == nil {
|
||||
t.Fatalf("finalTx == nil; caller needs a live tx to commit")
|
||||
}
|
||||
if err := mock.ExpectationsWereMet(); err != nil {
|
||||
t.Errorf("unmet expectations: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestInsertWorkspaceWithNameRetry_SecondAttemptSuffixed confirms
|
||||
// that on a single collision the helper retries with " (2)" and
|
||||
// returns that as the persisted name. The dispatched-name suffix
|
||||
// shape is part of the user-visible contract — if a future
|
||||
// refactor switches to "-2" / "_2" / "MyWorkspace2", the canvas
|
||||
// renders the wrong label until the next poll.
|
||||
func TestInsertWorkspaceWithNameRetry_SecondAttemptSuffixed(t *testing.T) {
|
||||
mock := setupTestDB(t)
|
||||
|
||||
// First begin (caller-owned), then first INSERT fails with the
|
||||
// partial-unique violation, helper rolls back the tx, opens a
|
||||
// fresh tx, and the second INSERT (with " (2)") succeeds.
|
||||
mock.ExpectBegin()
|
||||
mock.ExpectExec("INSERT INTO workspaces").
|
||||
WithArgs("id-1", "MyWorkspace").
|
||||
WillReturnError(fakePqUniqueViolation("workspaces_parent_name_uniq"))
|
||||
mock.ExpectRollback()
|
||||
mock.ExpectBegin()
|
||||
mock.ExpectExec("INSERT INTO workspaces").
|
||||
WithArgs("id-1", "MyWorkspace (2)").
|
||||
WillReturnResult(sqlmock.NewResult(0, 1))
|
||||
|
||||
tx, err := getDBHandle(t).BeginTx(context.Background(), nil)
|
||||
if err != nil {
|
||||
t.Fatalf("begin: %v", err)
|
||||
}
|
||||
|
||||
name, finalTx, err := insertWorkspaceWithNameRetry(
|
||||
context.Background(),
|
||||
tx,
|
||||
func(ctx context.Context) (*sql.Tx, error) {
|
||||
return getDBHandle(t).BeginTx(ctx, nil)
|
||||
},
|
||||
"MyWorkspace",
|
||||
1,
|
||||
"INSERT INTO workspaces (id, name) VALUES ($1, $2)",
|
||||
[]any{"id-1", "MyWorkspace"},
|
||||
)
|
||||
if err != nil {
|
||||
t.Fatalf("retry helper: %v", err)
|
||||
}
|
||||
// Exact-equality assertion (per feedback_assert_exact_not_substring):
|
||||
// substring-match on "MyWorkspace" would also pass for the bug case
|
||||
// where the helper accidentally returns "MyWorkspace (1)" or
|
||||
// "MyWorkspace2".
|
||||
if name != "MyWorkspace (2)" {
|
||||
t.Fatalf("name = %q, want exactly %q", name, "MyWorkspace (2)")
|
||||
}
|
||||
if finalTx == nil {
|
||||
t.Fatalf("finalTx == nil after successful retry")
|
||||
}
|
||||
if err := mock.ExpectationsWereMet(); err != nil {
|
||||
t.Errorf("unmet expectations: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestInsertWorkspaceWithNameRetry_NonRetryableErrorPassesThrough
|
||||
// pins that we do NOT retry on errors we don't recognize. A
|
||||
// connection drop, an FK violation, a check-constraint failure
|
||||
// must propagate verbatim — the helper is NOT a generic
|
||||
// SQL-retry wrapper.
|
||||
func TestInsertWorkspaceWithNameRetry_NonRetryableErrorPassesThrough(t *testing.T) {
|
||||
mock := setupTestDB(t)
|
||||
|
||||
mock.ExpectBegin()
|
||||
connErr := errors.New("connection reset by peer")
|
||||
mock.ExpectExec("INSERT INTO workspaces").
|
||||
WithArgs("id-1", "MyWorkspace").
|
||||
WillReturnError(connErr)
|
||||
|
||||
tx, err := getDBHandle(t).BeginTx(context.Background(), nil)
|
||||
if err != nil {
|
||||
t.Fatalf("begin: %v", err)
|
||||
}
|
||||
|
||||
name, _, err := insertWorkspaceWithNameRetry(
|
||||
context.Background(),
|
||||
tx,
|
||||
func(ctx context.Context) (*sql.Tx, error) {
|
||||
return getDBHandle(t).BeginTx(ctx, nil)
|
||||
},
|
||||
"MyWorkspace",
|
||||
1,
|
||||
"INSERT INTO workspaces (id, name) VALUES ($1, $2)",
|
||||
[]any{"id-1", "MyWorkspace"},
|
||||
)
|
||||
if err == nil {
|
||||
t.Fatalf("expected error, got nil (name=%q)", name)
|
||||
}
|
||||
if !errors.Is(err, connErr) && !strings.Contains(err.Error(), "connection reset") {
|
||||
t.Fatalf("expected connection-reset to propagate, got %v", err)
|
||||
}
|
||||
if name != "" {
|
||||
t.Fatalf("name = %q, want empty on failure", name)
|
||||
}
|
||||
}
|
||||
|
||||
// TestInsertWorkspaceWithNameRetry_ExhaustsAfterMaxSuffix pins the
|
||||
// upper bound: after maxNameSuffix retries the helper returns
|
||||
// errWorkspaceNameExhausted so the caller maps it to 409 Conflict
|
||||
// rather than spinning indefinitely.
|
||||
func TestInsertWorkspaceWithNameRetry_ExhaustsAfterMaxSuffix(t *testing.T) {
|
||||
mock := setupTestDB(t)
|
||||
|
||||
// Every attempt collides. Expect maxNameSuffix+1 INSERTs (the
|
||||
// initial + maxNameSuffix retries), each followed by a Rollback,
|
||||
// and a Begin between rollbacks except the final terminal one.
|
||||
mock.ExpectBegin()
|
||||
for i := 0; i <= maxNameSuffix; i++ {
|
||||
mock.ExpectExec("INSERT INTO workspaces").
|
||||
WillReturnError(fakePqUniqueViolation("workspaces_parent_name_uniq"))
|
||||
mock.ExpectRollback()
|
||||
if i < maxNameSuffix {
|
||||
mock.ExpectBegin()
|
||||
}
|
||||
}
|
||||
|
||||
tx, err := getDBHandle(t).BeginTx(context.Background(), nil)
|
||||
if err != nil {
|
||||
t.Fatalf("begin: %v", err)
|
||||
}
|
||||
|
||||
_, finalTx, err := insertWorkspaceWithNameRetry(
|
||||
context.Background(),
|
||||
tx,
|
||||
func(ctx context.Context) (*sql.Tx, error) {
|
||||
return getDBHandle(t).BeginTx(ctx, nil)
|
||||
},
|
||||
"MyWorkspace",
|
||||
1,
|
||||
"INSERT INTO workspaces (id, name) VALUES ($1, $2)",
|
||||
[]any{"id-1", "MyWorkspace"},
|
||||
)
|
||||
if !errors.Is(err, errWorkspaceNameExhausted) {
|
||||
t.Fatalf("err = %v, want errWorkspaceNameExhausted", err)
|
||||
}
|
||||
if finalTx != nil {
|
||||
t.Fatalf("finalTx must be nil on exhaustion (helper already rolled back); got %v", finalTx)
|
||||
}
|
||||
if err := mock.ExpectationsWereMet(); err != nil {
|
||||
t.Errorf("unmet expectations: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// getDBHandle exposes the package-level db.DB the test infrastructure
|
||||
// stashes after setupTestDB. Kept as a helper so the test reads as
|
||||
// the production code does ("BeginTx on the platform's DB") without
|
||||
// the cross-package import noise.
|
||||
func getDBHandle(t *testing.T) *sql.DB {
|
||||
t.Helper()
|
||||
// db.DB is the package-level handle; setupTestDB assigns it to
|
||||
// the sqlmock-backed *sql.DB. Use this helper everywhere instead
|
||||
// of dereferencing db.DB directly so a future move to a per-test
|
||||
// container fixture has one rename surface.
|
||||
return db.DB
|
||||
}
|
||||
@@ -12,8 +12,8 @@ import (
|
||||
// time. The Go convention `export_test.go` keeps this seam OUT of the
|
||||
// production binary — files ending in _test.go are stripped at build
|
||||
// time, so this re-export only exists during `go test`.
|
||||
func StartSweeperWithIntervalForTest(ctx context.Context, storage Storage, ackRetention, interval time.Duration, done chan struct{}) {
|
||||
startSweeperWithInterval(ctx, storage, ackRetention, interval, done)
|
||||
func StartSweeperWithIntervalForTest(ctx context.Context, storage Storage, ackRetention, interval time.Duration) {
|
||||
startSweeperWithInterval(ctx, storage, ackRetention, interval, nil)
|
||||
}
|
||||
|
||||
// StartSweeperForTest starts the sweeper and returns a done channel
|
||||
|
||||
@@ -190,14 +190,7 @@ func TestStartSweeperWithInterval_TickerFiresAdditionalCycles(t *testing.T) {
|
||||
ctx, cancel := context.WithCancel(context.Background())
|
||||
defer cancel()
|
||||
|
||||
// Use a short ticker interval (100ms) so the test runs fast without
|
||||
// burning real wall-clock time. StartSweeperWithIntervalForTest is the
|
||||
// test-friendly variant that accepts a caller-specified interval; the
|
||||
// production SweepInterval of 5m is too coarse for a 2s deadline on
|
||||
// a loaded CI runner (the ticker may not fire at all under CPU
|
||||
// contention — the root cause of the pre-existing CI flake).
|
||||
done := make(chan struct{})
|
||||
go pendinguploads.StartSweeperWithIntervalForTest(ctx, store, time.Hour, 100*time.Millisecond, done)
|
||||
done := pendinguploads.StartSweeperForTest(ctx, store, time.Hour)
|
||||
// Immediate cycle + at least one tick-driven cycle.
|
||||
store.waitForCycle(t, 2, 2*time.Second)
|
||||
|
||||
|
||||
@@ -109,16 +109,13 @@ type LocalBuildOptions struct {
|
||||
// http.DefaultClient with a 30s timeout.
|
||||
HTTPClient *http.Client
|
||||
|
||||
// remoteHeadSha + dockerBuild + gitClone + checkTool are seams for tests;
|
||||
// if nil, the production implementations are used.
|
||||
// remoteHeadSha + dockerBuild + gitClone are seams for tests; if
|
||||
// nil, the production implementations are used.
|
||||
remoteHeadSha func(ctx context.Context, opts *LocalBuildOptions, runtime string) (string, error)
|
||||
gitClone func(ctx context.Context, opts *LocalBuildOptions, runtime, dest string) error
|
||||
dockerBuild func(ctx context.Context, opts *LocalBuildOptions, contextDir, tag string) error
|
||||
dockerHasTag func(ctx context.Context, tag string) (bool, error)
|
||||
dockerTag func(ctx context.Context, src, dst string) error
|
||||
// checkTool validates that the named binary is on PATH. nil = production
|
||||
// LookPath check; tests override to skip or mock.
|
||||
checkTool func(tool string) error
|
||||
}
|
||||
|
||||
func newDefaultLocalBuildOptions() *LocalBuildOptions {
|
||||
@@ -185,21 +182,6 @@ func EnsureLocalImage(ctx context.Context, runtime string) (string, error) {
|
||||
// production code.
|
||||
var ensureLocalImageHook = EnsureLocalImage
|
||||
|
||||
// checkToolOnPath verifies tool is on PATH and returns an error with a
|
||||
// descriptive message if missing. Used for pre-flight validation before the
|
||||
// clone/build cold path.
|
||||
func checkToolOnPath(tool string) error {
|
||||
path, err := exec.LookPath(tool)
|
||||
if err != nil {
|
||||
if errors.Is(err, exec.ErrNotFound) {
|
||||
return fmt.Errorf("%q not found on PATH — local-build mode requires both docker and git; either install them, or set MOLECULE_IMAGE_REGISTRY so local-build is bypassed", tool)
|
||||
}
|
||||
return fmt.Errorf("LookPath(%q) failed: %w", tool, err)
|
||||
}
|
||||
log.Printf("local-build: pre-flight OK (%s=%s)", tool, path)
|
||||
return nil
|
||||
}
|
||||
|
||||
func ensureLocalImageWithOpts(ctx context.Context, runtime string, opts *LocalBuildOptions) (string, error) {
|
||||
if !IsKnownRuntime(runtime) {
|
||||
return "", fmt.Errorf("local-build: refusing to build unknown runtime %q (must be one of %v)", runtime, knownRuntimes)
|
||||
@@ -209,20 +191,6 @@ func ensureLocalImageWithOpts(ctx context.Context, runtime string, opts *LocalBu
|
||||
lock.Lock()
|
||||
defer lock.Unlock()
|
||||
|
||||
// Pre-flight: both docker and git are required even on the cache-hit
|
||||
// path (docker is used for image inspect + tag). Fail fast with a clear
|
||||
// message rather than a cryptic "exec: docker: executable file not found".
|
||||
checkFn := opts.checkTool
|
||||
if checkFn == nil {
|
||||
checkFn = checkToolOnPath
|
||||
}
|
||||
if err := checkFn("docker"); err != nil {
|
||||
return "", fmt.Errorf("local-build: %w; set MOLECULE_IMAGE_REGISTRY to bypass local-build mode", err)
|
||||
}
|
||||
if err := checkFn("git"); err != nil {
|
||||
return "", fmt.Errorf("local-build: %w; set MOLECULE_IMAGE_REGISTRY to bypass local-build mode", err)
|
||||
}
|
||||
|
||||
// 1. HEAD lookup → cache key.
|
||||
headFn := opts.remoteHeadSha
|
||||
if headFn == nil {
|
||||
|
||||
@@ -43,10 +43,6 @@ func makeTestOpts(t *testing.T) *LocalBuildOptions {
|
||||
dockerTag: func(ctx context.Context, src, dst string) error {
|
||||
return nil
|
||||
},
|
||||
// checkTool: skip the real LookPath in tests (docker/git may not be on PATH
|
||||
// in the CI environment). Tests that exercise tool-not-found behaviour
|
||||
// override this stub explicitly.
|
||||
checkTool: func(tool string) error { return nil },
|
||||
}
|
||||
}
|
||||
|
||||
@@ -91,50 +87,6 @@ func TestEnsureLocalImage_CacheHit(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// TestEnsureLocalImage_MissingTool_Docker — pre-flight catches a missing
|
||||
// docker binary before any cryptic exec-not-found error propagates up.
|
||||
// The error must mention both the missing tool and the escape-hatch hint.
|
||||
func TestEnsureLocalImage_MissingTool_Docker(t *testing.T) {
|
||||
opts := makeTestOpts(t)
|
||||
opts.checkTool = func(tool string) error {
|
||||
if tool == "docker" {
|
||||
return errors.New(`"docker" not found on PATH`)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
_, err := ensureLocalImageWithOpts(context.Background(), "claude-code", opts)
|
||||
if err == nil {
|
||||
t.Fatalf("expected error for missing docker")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "docker") {
|
||||
t.Errorf("error = %v, want one mentioning docker", err)
|
||||
}
|
||||
if !strings.Contains(err.Error(), "MOLECULE_IMAGE_REGISTRY") {
|
||||
t.Errorf("error = %v, want one mentioning MOLECULE_IMAGE_REGISTRY", err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestEnsureLocalImage_MissingTool_Git — same for a missing git binary.
|
||||
func TestEnsureLocalImage_MissingTool_Git(t *testing.T) {
|
||||
opts := makeTestOpts(t)
|
||||
opts.checkTool = func(tool string) error {
|
||||
if tool == "git" {
|
||||
return errors.New(`"git" not found on PATH`)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
_, err := ensureLocalImageWithOpts(context.Background(), "claude-code", opts)
|
||||
if err == nil {
|
||||
t.Fatalf("expected error for missing git")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "git") {
|
||||
t.Errorf("error = %v, want one mentioning git", err)
|
||||
}
|
||||
if !strings.Contains(err.Error(), "MOLECULE_IMAGE_REGISTRY") {
|
||||
t.Errorf("error = %v, want one mentioning MOLECULE_IMAGE_REGISTRY", err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestEnsureLocalImage_UnknownRuntime — the allowlist guard rejects
|
||||
// arbitrary runtime names before any network or filesystem call.
|
||||
func TestEnsureLocalImage_UnknownRuntime(t *testing.T) {
|
||||
|
||||
@@ -75,19 +75,14 @@ _INJECTION_PATTERNS = [
|
||||
|
||||
|
||||
def sanitize_a2a_result(text: str) -> str:
|
||||
"""Sanitize untrusted text from an A2A peer (OFFSEC-003).
|
||||
"""Sanitize and wrap untrusted text from an A2A peer (OFFSEC-003).
|
||||
|
||||
Order of operations:
|
||||
1. Escape boundary markers in the raw text (prevents injection).
|
||||
2. Escape known injection patterns (defense-in-depth).
|
||||
3. Wrap in trust-boundary markers.
|
||||
|
||||
Returns the input unchanged if it is empty/None.
|
||||
|
||||
Note: this function does NOT add boundary wrappers — callers that need
|
||||
to establish a trust boundary should wrap the sanitized result with
|
||||
``[A2A_RESULT_FROM_PEER]\\n{sanitized}\\n[/A2A_RESULT_FROM_PEER]``.
|
||||
See ``a2a_tools_delegation.py:tool_delegate_task`` for the canonical
|
||||
wrapping pattern.
|
||||
"""
|
||||
if not text:
|
||||
return text
|
||||
@@ -100,4 +95,5 @@ def sanitize_a2a_result(text: str) -> str:
|
||||
for pattern, replacement in _INJECTION_PATTERNS:
|
||||
escaped = pattern.sub(replacement, escaped)
|
||||
|
||||
return escaped
|
||||
# 3. Wrap in trust-boundary markers.
|
||||
return f"{_A2A_BOUNDARY_START}\n{escaped}\n{_A2A_BOUNDARY_END}"
|
||||
|
||||
@@ -25,10 +25,10 @@ _WORKSPACE_ID_raw = os.environ.get("WORKSPACE_ID")
|
||||
if not _WORKSPACE_ID_raw:
|
||||
raise RuntimeError("WORKSPACE_ID environment variable is required but not set")
|
||||
WORKSPACE_ID = _WORKSPACE_ID_raw
|
||||
# Platform URL: always host.docker.internal inside containers. The platform API
|
||||
# is only reachable via the Docker network mesh from inside a workspace
|
||||
# container regardless of the runtime environment (Docker/host).
|
||||
PLATFORM_URL = os.environ.get("PLATFORM_URL", "http://host.docker.internal:8080")
|
||||
if os.path.exists("/.dockerenv") or os.environ.get("DOCKER_VERSION"):
|
||||
PLATFORM_URL = os.environ.get("PLATFORM_URL", "http://host.docker.internal:8080")
|
||||
else:
|
||||
PLATFORM_URL = os.environ.get("PLATFORM_URL", "http://localhost:8080")
|
||||
|
||||
|
||||
async def discover(target_id: str) -> dict | None:
|
||||
|
||||
+9
-25
@@ -26,10 +26,10 @@ _WORKSPACE_ID_raw = os.environ.get("WORKSPACE_ID")
|
||||
if not _WORKSPACE_ID_raw:
|
||||
raise RuntimeError("WORKSPACE_ID environment variable is required but not set")
|
||||
WORKSPACE_ID = _WORKSPACE_ID_raw
|
||||
# Platform URL: always host.docker.internal inside containers. The platform API
|
||||
# is only reachable via the Docker network mesh from inside a workspace
|
||||
# container regardless of the runtime environment (Docker/host).
|
||||
PLATFORM_URL = os.environ.get("PLATFORM_URL", "http://host.docker.internal:8080")
|
||||
if os.path.exists("/.dockerenv") or os.environ.get("DOCKER_VERSION"):
|
||||
PLATFORM_URL = os.environ.get("PLATFORM_URL", "http://host.docker.internal:8080")
|
||||
else:
|
||||
PLATFORM_URL = os.environ.get("PLATFORM_URL", "http://localhost:8080")
|
||||
|
||||
# Cache workspace ID → name mappings (populated by list_peers calls)
|
||||
_peer_names: dict[str, str] = {}
|
||||
@@ -187,27 +187,17 @@ def enrich_peer_metadata_nonblocking(
|
||||
canon = _validate_peer_id(peer_id)
|
||||
if canon is None:
|
||||
return None
|
||||
|
||||
# Cache-first: return immediately on warm hit (same TTL logic as the
|
||||
# sync path). This is the hot-path optimisation — every push from a
|
||||
# warm peer must return the record without touching the in-flight set
|
||||
# or the executor. A background fetch that races to fill the cache
|
||||
# will find the entry already present when it calls
|
||||
# enrich_peer_metadata (which does its own fresh-TTL check), so it
|
||||
# exits as a no-op with no extra network traffic.
|
||||
current = time.monotonic()
|
||||
cached = _peer_metadata_get(canon)
|
||||
if cached is not None:
|
||||
fetched_at, record = cached
|
||||
if current - fetched_at < _PEER_METADATA_TTL_SECONDS:
|
||||
return record
|
||||
|
||||
# Cache miss or TTL expired: schedule background fetch unless one is
|
||||
# already in flight for this peer. The synchronous version atomically
|
||||
# reads-then-writes; the async version splits that into "schedule
|
||||
# fetch" + "fetch fills cache later." The in-flight set keeps a
|
||||
# flurry of pushes from one peer (e.g., a chatty agent) from
|
||||
# spawning N parallel GETs.
|
||||
# Schedule background fetch unless one is already in flight for this
|
||||
# peer. The synchronous version atomically reads-then-writes; the
|
||||
# async version splits that into "schedule fetch" + "fetch fills
|
||||
# cache later." The in-flight set keeps a flurry of pushes from
|
||||
# one peer (e.g., a chatty agent) from spawning N parallel GETs.
|
||||
with _enrich_in_flight_lock:
|
||||
if canon in _enrich_in_flight:
|
||||
return None
|
||||
@@ -266,12 +256,6 @@ def _wait_for_enrichment_inflight_for_testing(timeout: float = 2.0) -> None:
|
||||
time.sleep(0.01)
|
||||
|
||||
|
||||
def _peer_in_flight_clear_for_testing() -> None:
|
||||
"""Clear the in-flight enrichment set. Test-only helper."""
|
||||
with _enrich_in_flight_lock:
|
||||
_enrich_in_flight.clear()
|
||||
|
||||
|
||||
def enrich_peer_metadata(
|
||||
peer_id: str,
|
||||
source_workspace_id: str | None = None,
|
||||
|
||||
@@ -52,7 +52,6 @@ from executor_helpers import (
|
||||
collect_outbound_files,
|
||||
extract_attached_files,
|
||||
read_delegation_results,
|
||||
sanitize_agent_error,
|
||||
)
|
||||
from builtin_tools.telemetry import (
|
||||
A2A_TASK_ID,
|
||||
@@ -548,12 +547,7 @@ class LangGraphA2AExecutor(AgentExecutor):
|
||||
# receive the error and stop polling.
|
||||
await updater.failed(
|
||||
message=new_text_message(
|
||||
# Pass the exception string as stderr so sanitize_agent_error
|
||||
# can include a ~1KB preview in the A2A error response.
|
||||
# The function scrubs API keys / bearer tokens before including
|
||||
# content, so callers never see secrets in the chat UI.
|
||||
# Fixes: roadmap item "SDK executor stderr swallowing".
|
||||
sanitize_agent_error(stderr=str(e)), task_id=task_id, context_id=context_id,
|
||||
f"Agent error: {e}", task_id=task_id, context_id=context_id
|
||||
)
|
||||
)
|
||||
finally:
|
||||
|
||||
@@ -47,11 +47,7 @@ from a2a_client import (
|
||||
send_a2a_message,
|
||||
)
|
||||
from a2a_tools_rbac import auth_headers_for_heartbeat as _auth_headers_for_heartbeat
|
||||
from _sanitize_a2a import (
|
||||
_A2A_BOUNDARY_END,
|
||||
_A2A_BOUNDARY_START,
|
||||
sanitize_a2a_result,
|
||||
) # noqa: E402
|
||||
from _sanitize_a2a import sanitize_a2a_result # noqa: E402
|
||||
|
||||
|
||||
# RFC #2829 PR-5 cutover constants. The poll cadence + timeout are
|
||||
@@ -326,12 +322,8 @@ async def tool_delegate_task(
|
||||
f"You should either: (1) try a different peer, (2) handle this task yourself, "
|
||||
f"or (3) inform the user that {peer_name} is unavailable and provide your best answer."
|
||||
)
|
||||
# OFFSEC-003: escape boundary markers in peer text, then wrap in boundary
|
||||
# markers so the agent can distinguish trusted (own output) from untrusted
|
||||
# (peer-supplied) content. Explicit wrapping here rather than inside
|
||||
# sanitize_a2a_result preserves a clean separation of concerns.
|
||||
escaped = sanitize_a2a_result(result)
|
||||
return f"{_A2A_BOUNDARY_START}\n{escaped}\n{_A2A_BOUNDARY_END}"
|
||||
# OFFSEC-003: wrap peer result in trust boundary before returning to agent context
|
||||
return sanitize_a2a_result(result)
|
||||
|
||||
|
||||
async def tool_delegate_task_async(
|
||||
|
||||
@@ -40,16 +40,6 @@ from a2a.helpers import new_text_message
|
||||
|
||||
from adapter_base import AdapterConfig, BaseAdapter
|
||||
|
||||
# Import sanitize_agent_error from the workspace package. The adapter lives
|
||||
# in the workspace/adapters/ hierarchy so the workspace package root is
|
||||
# always importable as long as the module is loaded from within a workspace.
|
||||
# In standalone template repos, this import resolves via the workspace package
|
||||
# entry point that also provides adapter_base.
|
||||
try:
|
||||
from executor_helpers import sanitize_agent_error # type: ignore[attr-defined]
|
||||
except ImportError: # pragma: no cover
|
||||
sanitize_agent_error = None # fallback: below handler falls back to class-name only
|
||||
|
||||
if TYPE_CHECKING:
|
||||
pass
|
||||
|
||||
@@ -242,16 +232,10 @@ class GoogleADKA2AExecutor(AgentExecutor):
|
||||
type(exc).__name__,
|
||||
exc_info=True,
|
||||
)
|
||||
# Include exception detail (first ~1 KB) in the A2A error response so
|
||||
# callers get actionable context without needing workspace log access.
|
||||
# sanitize_agent_error scrubs API keys / bearer tokens before including
|
||||
# content in the response. Falls back to class-name-only when
|
||||
# the function is unavailable (standalone template repo layout).
|
||||
if sanitize_agent_error is not None:
|
||||
msg = sanitize_agent_error(stderr=str(exc))
|
||||
else:
|
||||
msg = f"Agent error: {type(exc).__name__}"
|
||||
await event_queue.enqueue_event(new_text_message(msg))
|
||||
# Mirror sanitize_agent_error() convention: expose class name only.
|
||||
await event_queue.enqueue_event(
|
||||
new_text_message(f"Agent error: {type(exc).__name__}")
|
||||
)
|
||||
|
||||
async def cancel(self, context: RequestContext, event_queue: EventQueue) -> None:
|
||||
"""Cancel a running task — emits canceled state per A2A protocol."""
|
||||
|
||||
@@ -1,31 +0,0 @@
|
||||
# Publish-runtime pipeline verification — 2026-05-11
|
||||
|
||||
Marker file for the canonical end-to-end pipeline verification after
|
||||
`publish-runtime-bot` provisioning (internal#327) + stale-tag drift
|
||||
resolution (`runtime-v0.1.131` deleted from main).
|
||||
|
||||
## Purpose
|
||||
|
||||
Triggers `workspace/**` path filter on `publish-runtime-autobump.yml`,
|
||||
exercising the full pipeline:
|
||||
|
||||
1. `publish-runtime-autobump / bump-and-tag` reads PyPI version, computes
|
||||
next, pushes tag `runtime-v0.1.131` (or higher) using new bot scope.
|
||||
2. `publish-runtime.yml` fires on tag, builds + publishes to PyPI.
|
||||
3. Cascade autobump: 9 template repos get their `.runtime-version`
|
||||
pinned to the new version.
|
||||
|
||||
## Acceptance criteria
|
||||
|
||||
- [ ] autobump bump-and-tag context green on merged commit
|
||||
- [ ] tag `runtime-v0.1.131` (or computed next) exists on molecule-core
|
||||
- [ ] publish-runtime.yml run green
|
||||
- [ ] PyPI molecule-ai-workspace-runtime updated from 0.1.130
|
||||
- [ ] 9 template repos updated their pinned runtime version
|
||||
|
||||
## Rollback
|
||||
|
||||
This file is informational only — no code dependency. Safe to delete
|
||||
in any future PR once pipeline is proven stable.
|
||||
|
||||
— core-devops (per Hongming "long-term proper robust" directive 2026-05-11 19:48-19:50Z)
|
||||
@@ -9,13 +9,6 @@ import uuid
|
||||
|
||||
import httpx
|
||||
|
||||
# OFFSEC-003: peer-controlled text MUST be wrapped with sanitize_a2a_result
|
||||
# before being returned to the LLM. This module's delegate_task() is one of
|
||||
# the trust-boundary entry points where peer output crosses into our agent's
|
||||
# context — same surface as a2a_tools_delegation.py:325 (fixed via #492).
|
||||
# Issue #537.
|
||||
from _sanitize_a2a import sanitize_a2a_result
|
||||
|
||||
PLATFORM_URL = os.environ.get("PLATFORM_URL", "http://host.docker.internal:8080")
|
||||
WORKSPACE_ID = os.environ.get("WORKSPACE_ID", "")
|
||||
|
||||
@@ -76,14 +69,12 @@ async def delegate_task(workspace_id: str, task: str) -> str:
|
||||
result = data["result"]
|
||||
parts = result.get("parts", []) if isinstance(result, dict) else []
|
||||
if parts and isinstance(parts[0], dict):
|
||||
# OFFSEC-003: wrap peer-controlled text before returning
|
||||
# to LLM context. Issue #537.
|
||||
return sanitize_a2a_result(parts[0].get("text", "(no text)"))
|
||||
return parts[0].get("text", "(no text)")
|
||||
# Empty parts list (e.g. {"parts": []}) should return str(result),
|
||||
# not "(no text)" — preserves pre-fix behavior (#279 regression fix).
|
||||
if isinstance(result, dict) and result.get("parts") == []:
|
||||
return sanitize_a2a_result(str(result))
|
||||
return sanitize_a2a_result(str(result) if isinstance(result, str) else "(no text)")
|
||||
return str(result)
|
||||
return str(result) if isinstance(result, str) else "(no text)"
|
||||
elif "error" in data:
|
||||
err = data["error"]
|
||||
# Handle both string-form errors ("error": "some string")
|
||||
@@ -95,9 +86,8 @@ async def delegate_task(workspace_id: str, task: str) -> str:
|
||||
msg = err
|
||||
else:
|
||||
msg = str(err)
|
||||
# OFFSEC-003: peer-controlled error message; wrap before return.
|
||||
return sanitize_a2a_result(f"Error: {msg}")
|
||||
return sanitize_a2a_result(str(data))
|
||||
return f"Error: {msg}"
|
||||
return str(data)
|
||||
except Exception as e:
|
||||
return f"Error sending A2A message: {e}"
|
||||
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user