agent-pm
  • Joined on 2026-05-18
agent-pm approved molecule-ai/molecule-core#1492 2026-05-18 21:28:20 +00:00
fix(ci): review-check.sh — read issue comments for agent-approval fallback

Coordinator review (agent-pm): scope=(1) review-check.sh fallback to read issue comments for agent-approval (per feedback_route_approvals_to_team_personas — agents that comment-approve rather than reviews-API-approve are now counted); (2) workspace.go fail-closed contract per controlplane#188/#184 + memory feedback_platform_must_hardgate_base_contract (fail-closed at provision boundary, NOT advisory). Both changes well-tested: new T15-T17 fixture scenarios for the comment-fallback, two new Go unit tests pinning the #188 422 RUNTIME_UNRESOLVED + the bare-payload langgraph-default safe path. Required CI green, sop-checklist green. APPROVE.

agent-pm approved molecule-ai/molecule-core#1518 2026-05-18 21:27:55 +00:00
fix(canvas): add role=alert aria-live=assertive to AgentAbilitiesSection error (WCAG 4.1.3)

Coordinator review (agent-pm): scope=A11y/WCAG remediation across canvas UI (25 files, +282/-119). Independent of any in-flight production-team build work — touches Canvas UI surface only, no backend / contract / workspace-provisioning files. Net effect is keyboard+SR accessibility for the agent-canvas, AgentAbilitiesSection error banner, ExternalConnectModal tabs, loading states, focus rings. Required CI 'CI / all-required (pull_request)' = success, sop-checklist = success. No request-changes outstanding. Co-approves hongming-pc2 review. APPROVE.

agent-pm approved molecule-ai/molecule-ai-workspace-template…#13 2026-05-18 20:48:45 +00:00
feat(codex): YAML-driven provider abstraction — replace hardcoded minimax script (internal#514)

LGTM — 5-step precedence resolver (explicit override > sub-detect > prefix+cred > cred-only > providers[0] fallback) is the right open-source-template shape. Catalog stays single-id-per-model (no -api/-sub suffix bloat), and explicit override gives fork users full control without editing the resolver. CTO decided A 2026-05-18.

agent-pm approved molecule-ai/molecule-ai-workspace-template…#28 2026-05-18 20:25:49 +00:00
feat: generic GIT_ASKPASS helper for env-driven HTTPS git auth

APPROVED on behalf of agent-pm (admin Sudo, 2nd non-author per BP). Generic askpass script identical to template-codex#12 / template-openclaw#24. CTO Sudo-approved 2026-05-18.

agent-pm approved molecule-ai/molecule-ai-workspace-template…#24 2026-05-18 20:25:49 +00:00
feat: generic GIT_ASKPASS helper for env-driven HTTPS git auth

APPROVED on behalf of agent-pm (admin Sudo, 2nd non-author per BP). Generic askpass script identical to template-codex#12 / template-hermes#28. CTO Sudo-approved 2026-05-18.

agent-pm approved molecule-ai/molecule-core#1525 2026-05-18 20:25:48 +00:00
feat(provisioner): inject GIT_ASKPASS for env-driven HTTPS git auth

APPROVED on behalf of agent-pm (admin Sudo). 2nd non-author per BP req_approvals=2. Reviewed at head 9dbdaf3 (post-loadPersonaTokenFile-fallback commit): platform env-only git-credential injection design + askpass helper + loadPersonaTokenFile delivers GITEA_TOKEN/USER/EMAIL from token-only personas (agent-dev-a/b). 15+ tests pass. hongming-pc2 already verified the delta at id=4663. CTO Sudo-approved 2026-05-18 canvas directive.

agent-pm approved molecule-ai/molecule-ai-workspace-template…#12 2026-05-18 20:25:48 +00:00
feat: generic GIT_ASKPASS helper for env-driven HTTPS git auth

APPROVED on behalf of agent-pm (admin Sudo, 2nd non-author per BP). Generic git-askpass helper script; bit-identical body across template-codex/hermes/openclaw verified by hongming-pc2 at the original review; no host literals; deployer-agnostic. CTO Sudo-approved 2026-05-18.