Use gitignore for Biome ignoring

Use ubuntu-latest
Add test step to CI workflow
2025-06-05 14:52:33 -07:00 · 2025-06-02 13:10:44 -07:00 · 2025-06-02 13:01:56 -07:00 · 2025-06-02 13:01:05 -07:00 · 2025-06-02 13:00:44 -07:00 · 2025-05-30 10:49:24 -07:00
21 changed files with 32356 additions and 42057 deletions
@@ -1,74 +0,0 @@
-{
-  "plugins": ["@typescript-eslint"],
-  "extends": ["plugin:github/recommended"],
-  "parser": "@typescript-eslint/parser",
-  "parserOptions": {
-    "ecmaVersion": 9,
-    "sourceType": "module",
-    "project": "./tsconfig.json"
-  },
-  "settings": {
-    "import/resolver": {
-      "typescript": {}
-    }
-  },
-  "rules": {
-    "i18n-text/no-en": "off",
-    "eslint-comments/no-use": "off",
-    "import/no-namespace": "off",
-    "no-unused-vars": "off",
-    "@typescript-eslint/no-unused-vars": [
-      "error",
-      {
-        "argsIgnorePattern": "^_"
-      }
-    ],
-    "@typescript-eslint/explicit-member-accessibility": [
-      "error",
-      {
-        "accessibility": "no-public"
-      }
-    ],
-    "@typescript-eslint/no-base-to-string": "error",
-    "@typescript-eslint/no-require-imports": "error",
-    "@typescript-eslint/array-type": "error",
-    "@typescript-eslint/await-thenable": "error",
-    "@typescript-eslint/ban-ts-comment": "error",
-    "camelcase": "error",
-    "@typescript-eslint/consistent-type-assertions": "error",
-    "@typescript-eslint/explicit-function-return-type": [
-      "error",
-      {
-        "allowExpressions": true
-      }
-    ],
-    "@typescript-eslint/func-call-spacing": ["error", "never"],
-    "@typescript-eslint/no-array-constructor": "error",
-    "@typescript-eslint/no-empty-interface": "error",
-    "@typescript-eslint/no-explicit-any": "error",
-    "@typescript-eslint/no-floating-promises": "error",
-    "@typescript-eslint/no-extraneous-class": "error",
-    "@typescript-eslint/no-for-in-array": "error",
-    "@typescript-eslint/no-inferrable-types": "error",
-    "@typescript-eslint/no-misused-new": "error",
-    "@typescript-eslint/no-namespace": "error",
-    "@typescript-eslint/no-non-null-assertion": "warn",
-    "@typescript-eslint/no-unnecessary-qualifier": "error",
-    "@typescript-eslint/no-unnecessary-type-assertion": "error",
-    "@typescript-eslint/no-useless-constructor": "error",
-    "@typescript-eslint/no-var-requires": "error",
-    "@typescript-eslint/prefer-for-of": "warn",
-    "@typescript-eslint/prefer-function-type": "warn",
-    "@typescript-eslint/prefer-includes": "error",
-    "@typescript-eslint/prefer-string-starts-ends-with": "error",
-    "@typescript-eslint/promise-function-async": "error",
-    "@typescript-eslint/require-array-sort-compare": "error",
-    "@typescript-eslint/restrict-plus-operands": "error",
-    "@typescript-eslint/type-annotation-spacing": "error",
-    "@typescript-eslint/unbound-method": "error"
-  },
-  "env": {
-    "node": true,
-    "es6": true
-  }
-}
@@ -7,8 +7,9 @@ EXPECTED_VERSION="${1}"

 INSTALLED_NIX_VERSION_OUTPUT=$(nix --version)
 INSTALLED_NIX_VERSION=$(echo "${INSTALLED_NIX_VERSION_OUTPUT}" | awk '{print $NF}')
+EXPECTED_OUTPUT="nix (Nix) ${EXPECTED_VERSION}"

-if [ "${INSTALLED_NIX_VERSION}" != "${EXPECTED_VERSION}" ]; then
+if [ "${INSTALLED_NIX_VERSION_OUTPUT}" != "${EXPECTED_OUTPUT}" ]; then
  echo "Nix version ${INSTALLED_NIX_VERSION} didn't match expected version ${EXPECTED_VERSION}"
  exit 1
 else
@@ -8,7 +8,7 @@ on:

 jobs:
  tests:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
    needs:
      - check-dist-up-to-date
      - install-nix
@@ -24,17 +24,19 @@ jobs:

  check-dist-up-to-date:
    name: Check the dist/ folder is up to date
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: DeterminateSystems/nix-installer-action@main
      - uses: DeterminateSystems/flakehub-cache-action@main
      - name: pnpm install
        run: nix develop --command pnpm install
-      - name: prettier format
+      - name: Check formatting
        run: nix develop --command pnpm run check-fmt
-      - name: ESLint
+      - name: Link
        run: nix develop --command pnpm run lint
+      - name: Test
+        run: nix develop --command pnpm run test
      - name: tsup build
        run: nix develop --command pnpm run build
      - name: ncc package
@@ -78,7 +80,7 @@ jobs:
        run: echo $PATH

      - name: Render the devshell
-        if: (success() || failure()) && matrix.runner != 'macos-13-large' && matrix.runner != 'macos-14-large'
+        if: success() || failure()
        run: |
          nix develop --command date

@@ -146,14 +148,18 @@ jobs:

  install-with-non-default-source-inputs:
    name: Install Nix using non-default source-${{ matrix.inputs.key }}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
    strategy:
      matrix:
        inputs:
-          # https://github.com/DeterminateSystems/nix-installer/blob/v3.11.3
+          # https://github.com/DeterminateSystems/nix-installer/blob/v0.18.0
          - key: url
-            value: https://github.com/DeterminateSystems/nix-installer/releases/download/v3.11.3/nix-installer-x86_64-linux
-            nix-version: "2.31.2" # 3.11.3 is based on 2.31.2
+            value: https://github.com/DeterminateSystems/nix-installer/releases/download/v0.18.0/nix-installer-x86_64-linux
+            nix-version: "2.21.2"
+          # https://github.com/DeterminateSystems/nix-installer/tree/7011c077ec491da410fbc39f68676b0908b9ce7e
+          - key: revision
+            value: 7011c077ec491da410fbc39f68676b0908b9ce7e
+            nix-version: "2.19.2"

    steps:
      - uses: actions/checkout@v4
@@ -167,7 +173,7 @@ jobs:

  install-no-id-token:
    name: Install Nix without an ID token
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: ./
@@ -53,9 +53,6 @@ typings/
 # Optional npm cache directory
 .npm

-# Optional eslint cache
-.eslintcache
-
 # Optional REPL history
 .node_repl_history

@@ -1,3 +0,0 @@
-dist/
-lib/
-node_modules/
@@ -1 +0,0 @@
-{}
@@ -96,7 +96,7 @@ Differing from the upstream [Nix](https://github.com/NixOS/nix) installer script
 | Parameter               | Description                                                                                                                                                                                                                                                                    | Type                                       | Default                                                        |
 | :---------------------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :----------------------------------------- | :------------------------------------------------------------- |
 | `backtrace`             | The setting for [`RUST_BACKTRACE`][backtrace]                                                                                                                                                                                                                                  | string                                     |                                                                |
-| `determinate`           | Whether to install [Determinate Nix](https://determinate.systems/enterprise) and log in to FlakeHub for private Flakes and binary caches.                                                                                                                                      | Boolean                                    | `true`                                                         |
+| `determinate`           | Whether to install [Determinate Nix](https://determinate.systems/enterprise) and log in to FlakeHub for private Flakes and binary caches.                                                                                                                                      | Boolean                                    | `false`                                                        |
 | `extra-args`            | Extra arguments to pass to the planner (prefer using structured `with:` arguments unless using a custom [planner]!)                                                                                                                                                            | string                                     |                                                                |
 | `extra-conf`            | Extra configuration lines for `/etc/nix/nix.conf` (includes `access-tokens` with `secrets.GITHUB_TOKEN` automatically if `github-token` is set)                                                                                                                                | string                                     |                                                                |
 | `flakehub`              | Deprecated. Implies `determinate`.                                                                                                                                                                                                                                             | Boolean                                    | `false`                                                        |
@@ -10,7 +10,7 @@ inputs:
  determinate:
    description: |
      Whether to install [Determinate Nix](https://determinate.systems/enterprise) and log in to FlakeHub for private Flakes and binary caches.
-    default: true
+    default: false
  extra-args:
    description: Extra args to pass to the planner (prefer using structured `with:` arguments unless using a custom planner!)
    required: false
@@ -0,0 +1,148 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+  "vcs": { "enabled": true, "clientKind": "git", "useIgnoreFile": true },
+  "files": {
+    "ignoreUnknown": false,
+    "ignore": ["dist"]
+  },
+  "formatter": {
+    "enabled": true,
+    "useEditorconfig": true,
+    "formatWithErrors": false,
+    "indentStyle": "space",
+    "indentWidth": 2,
+    "lineEnding": "lf",
+    "lineWidth": 80,
+    "attributePosition": "auto",
+    "bracketSpacing": true
+  },
+  "organizeImports": { "enabled": true },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": false,
+      "complexity": {
+        "noExtraBooleanCast": "error",
+        "noMultipleSpacesInRegularExpressionLiterals": "error",
+        "noStaticOnlyClass": "error",
+        "noUselessConstructor": "error",
+        "noUselessStringConcat": "error",
+        "noUselessTypeConstraint": "error"
+      },
+      "correctness": {
+        "noConstAssign": "error",
+        "noConstantCondition": "error",
+        "noEmptyCharacterClassInRegex": "error",
+        "noEmptyPattern": "error",
+        "noGlobalObjectCalls": "error",
+        "noInnerDeclarations": "error",
+        "noInvalidConstructorSuper": "error",
+        "noNewSymbol": "error",
+        "noSelfAssign": "error",
+        "noSwitchDeclarations": "error",
+        "noUndeclaredVariables": "error",
+        "noUnreachable": "error",
+        "noUnreachableSuper": "error",
+        "noUnsafeFinally": "error",
+        "noUnusedLabels": "error",
+        "noUnusedVariables": "error",
+        "useArrayLiterals": "off",
+        "useIsNan": "error",
+        "useYield": "error"
+      },
+      "style": {
+        "noArguments": "error",
+        "noCommaOperator": "error",
+        "noInferrableTypes": "error",
+        "noNamespace": "error",
+        "noNonNullAssertion": "warn",
+        "noVar": "error",
+        "useAsConstAssertion": "error",
+        "useConsistentArrayType": "error",
+        "useConst": "error",
+        "useForOf": "warn",
+        "useShorthandFunctionType": "warn",
+        "useSingleVarDeclarator": "error",
+        "useTemplate": "error"
+      },
+      "suspicious": {
+        "noCatchAssign": "error",
+        "noClassAssign": "error",
+        "noCompareNegZero": "error",
+        "noConsole": "error",
+        "noControlCharactersInRegex": "error",
+        "noDebugger": "error",
+        "noDoubleEquals": "error",
+        "noDuplicateCase": "error",
+        "noDuplicateClassMembers": "error",
+        "noDuplicateObjectKeys": "error",
+        "noDuplicateParameters": "error",
+        "noEmptyBlockStatements": "error",
+        "noExplicitAny": "error",
+        "noExtraNonNullAssertion": "error",
+        "noFallthroughSwitchClause": "error",
+        "noFunctionAssign": "error",
+        "noGlobalAssign": "error",
+        "noMisleadingInstantiator": "error",
+        "noRedeclare": "error",
+        "noSparseArray": "error",
+        "noUnsafeDeclarationMerging": "error",
+        "noUnsafeNegation": "error",
+        "useNamespaceKeyword": "error",
+        "useValidTypeof": "error"
+      }
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "jsxQuoteStyle": "double",
+      "quoteProperties": "asNeeded",
+      "trailingCommas": "all",
+      "semicolons": "always",
+      "arrowParentheses": "always",
+      "bracketSameLine": false,
+      "quoteStyle": "double",
+      "attributePosition": "auto",
+      "bracketSpacing": true
+    },
+    "globals": ["exports"]
+  },
+  "overrides": [
+    {
+      "include": ["**/*.ts", "**/*.tsx", "**/*.mts", "**/*.cts"],
+      "linter": {
+        "rules": {
+          "complexity": { "noWith": "off" },
+          "correctness": {
+            "noConstAssign": "off",
+            "noGlobalObjectCalls": "off",
+            "noInvalidBuiltinInstantiation": "off",
+            "noInvalidConstructorSuper": "off",
+            "noNewSymbol": "off",
+            "noSetterReturn": "off",
+            "noUndeclaredVariables": "off",
+            "noUnreachable": "off",
+            "noUnreachableSuper": "off"
+          },
+          "style": {
+            "noArguments": "error",
+            "noVar": "error",
+            "useConst": "error",
+            "useNamingConvention": "error"
+          },
+          "suspicious": {
+            "noClassAssign": "off",
+            "noDuplicateClassMembers": "off",
+            "noDuplicateObjectKeys": "off",
+            "noDuplicateParameters": "off",
+            "noFunctionAssign": "off",
+            "noImportAssign": "off",
+            "noRedeclare": "off",
+            "noUnsafeNegation": "off",
+            "useGetterReturn": "off"
+          }
+        }
+      }
+    }
+  ]
+}
@@ -2,30 +2,30 @@
  "nodes": {
    "flake-schemas": {
      "locked": {
-        "lastModified": 1693491534,
-        "narHash": "sha256-ifw8Td8kD08J8DxFbYjeIx5naHcDLz7s2IFP3X42I/U=",
-        "rev": "c702cbb663d6d70bbb716584a2ee3aeb35017279",
-        "revCount": 21,
+        "lastModified": 1721999734,
+        "narHash": "sha256-G5CxYeJVm4lcEtaO87LKzOsVnWeTcHGKbKxNamNWgOw=",
+        "rev": "0a5c42297d870156d9c57d8f99e476b738dcd982",
+        "revCount": 75,
        "type": "tarball",
-        "url": "https://api.flakehub.com/f/pinned/DeterminateSystems/flake-schemas/0.1.1/018a4c59-80e1-708a-bb4d-854930c20f72/source.tar.gz"
+        "url": "https://api.flakehub.com/f/pinned/DeterminateSystems/flake-schemas/0.1.5/0190ef2f-61e0-794b-ba14-e82f225e55e6/source.tar.gz"
      },
      "original": {
        "type": "tarball",
-        "url": "https://flakehub.com/f/DeterminateSystems/flake-schemas/%2A.tar.gz"
+        "url": "https://flakehub.com/f/DeterminateSystems/flake-schemas/0.1"
      }
    },
    "nixpkgs": {
      "locked": {
-        "lastModified": 1696879762,
-        "narHash": "sha256-Ud6bH4DMcYHUDKavNMxAhcIpDGgHMyL/yaDEAVSImQY=",
-        "rev": "f99e5f03cc0aa231ab5950a15ed02afec45ed51a",
-        "revCount": 534224,
+        "lastModified": 1748460289,
+        "narHash": "sha256-7doLyJBzCllvqX4gszYtmZUToxKvMUrg45EUWaUYmBg=",
+        "rev": "96ec055edbe5ee227f28cdbc3f1ddf1df5965102",
+        "revCount": 807377,
        "type": "tarball",
-        "url": "https://api.flakehub.com/f/pinned/NixOS/nixpkgs/0.1.534224%2Brev-f99e5f03cc0aa231ab5950a15ed02afec45ed51a/018b1d3c-12f0-76a5-b796-7668d7633f08/source.tar.gz"
+        "url": "https://api.flakehub.com/f/pinned/NixOS/nixpkgs/0.1.807377%2Brev-96ec055edbe5ee227f28cdbc3f1ddf1df5965102/01972133-94d2-786e-bfeb-34136c7f0b07/source.tar.gz"
      },
      "original": {
        "type": "tarball",
-        "url": "https://flakehub.com/f/NixOS/nixpkgs/0.1.0.tar.gz"
+        "url": "https://flakehub.com/f/NixOS/nixpkgs/0.1"
      }
    },
    "root": {
@@ -3,13 +3,13 @@
  description = "Development environment for the Nix Installer action for GitHub.";

  inputs = {
-    flake-schemas.url = "https://flakehub.com/f/DeterminateSystems/flake-schemas/*.tar.gz";
-    nixpkgs.url = "https://flakehub.com/f/NixOS/nixpkgs/0.1.0.tar.gz";
+    flake-schemas.url = "https://flakehub.com/f/DeterminateSystems/flake-schemas/0.1";
+    nixpkgs.url = "https://flakehub.com/f/NixOS/nixpkgs/0.1";
  };

  outputs = { self, flake-schemas, nixpkgs }:
    let
-      supportedSystems = [ "x86_64-linux" "aarch64-darwin" "aarch64-linux" ];
+      supportedSystems = [ "x86_64-linux" "aarch64-darwin" "aarch64-linux" "x86_64-darwin" ];
      forEachSupportedSystem = f: nixpkgs.lib.genAttrs supportedSystems (system: f {
        pkgs = import nixpkgs { inherit system; };
      });
@@ -21,9 +21,9 @@
        default = pkgs.mkShell {
          packages = with pkgs; [
            nodejs_latest
-            nixpkgs-fmt
            nodePackages_latest.pnpm
-            nodePackages_latest.typescript-language-server
+            biome
+            nixpkgs-fmt
          ];
        };
      });
@@ -7,12 +7,12 @@
  "type": "module",
  "scripts": {
    "build": "tsup",
-    "format": "prettier --write .",
-    "check-fmt": "prettier --check .",
-    "lint": "eslint src/**/*.ts",
+    "format": "biome format --write",
+    "check-fmt": "biome format",
+    "lint": "biome lint",
    "package": "ncc build",
    "test": "vitest --watch false",
-    "all": "pnpm run test && pnpm run format && pnpm run lint && pnpm run build && pnpm run package"
+    "all": "pnpm run test && pnpm run format && pnpm run lint && pnpm run test && pnpm run build && pnpm run package"
  },
  "repository": {
    "type": "git",
@@ -30,23 +30,15 @@
    "@actions/exec": "^1.1.1",
    "@actions/github": "^6.0.1",
    "detsys-ts": "github:DeterminateSystems/detsys-ts",
-    "got": "^14.6.2",
+    "got": "^14.4.7",
    "string-argv": "^0.3.2",
-    "vitest": "^3.2.4"
+    "vitest": "^3.2.0"
  },
  "devDependencies": {
-    "@trivago/prettier-plugin-sort-imports": "^4.3.0",
-    "@types/node": "^20.19.24",
+    "@types/node": "^20.17.57",
    "@types/uuid": "^9.0.8",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@vercel/ncc": "^0.38.4",
-    "eslint": "^8.57.1",
-    "eslint-import-resolver-typescript": "^3.10.1",
-    "eslint-plugin-github": "^4.10.2",
-    "eslint-plugin-import": "^2.32.0",
-    "eslint-plugin-prettier": "^5.5.4",
-    "prettier": "^3.6.2",
+    "@vercel/ncc": "^0.38.3",
    "tsup": "^8.5.0",
-    "typescript": "^5.9.3"
+    "typescript": "^5.8.3"
  }
 }
@@ -1,8 +1,8 @@
-import { parseEvents, getRecentEvents } from "./events.js";
 import { expect, test } from "vitest";
+import { getRecentEvents, parseEvents } from "./events.js";

 // Handy test for locally making sure you can fetch recent events:
-// eslint-disable-next-line no-constant-condition
+// biome-ignore lint/correctness/noConstantCondition: testing
 if (false) {
  test("Parsing existing events", async () => {
    expect(await getRecentEvents(new Date(Date.now() - 1000000))).toStrictEqual(
@@ -1,6 +1,6 @@
 import got from "got";

-export interface DEvent {
+export interface Event {
  v: string;
  c: string;
  drv: string;
@@ -11,7 +11,7 @@ export interface DEvent {
 }

 export interface ParsedEventsResult {
-  readonly events: DEvent[];
+  readonly events: Event[];
  readonly hasMismatches: boolean;
 }

@@ -5,8 +5,6 @@ import {
  summarizeFailures,
 } from "./failuresummary.js";

-/* eslint-disable @typescript-eslint/no-non-null-assertion */
-
 test("Select for failure events", () => {
  const events = [
    {
@@ -99,10 +97,12 @@ test("Summarize Failures", async () => {
    }
  };

+  // biome-ignore lint/style/noNonNullAssertion: testing
  const summary: FailureSummary = (await summarizeFailures(events, logMaker))!;

-  expect(summary.markdownLines.join("\n"))
-    .toStrictEqual(`### Build error review :boom:
+  expect(
+    summary.markdownLines.join("\n"),
+  ).toStrictEqual(`### Build error review :boom:
 > [!NOTE]
 > 2 builds failed
 <details><summary>Failure log: <code>/nix/store/rz9hrpay90sjrid5hx3x8v606ji679xa-<strong>dep-1</strong>.drv</code></summary>
@@ -150,8 +150,9 @@ test("Summarize Failures", async () => {
 </details>
 `);

-  expect(summary.logLines.join("\n"))
-    .toStrictEqual(`\u001b[38;2;255;0;0mBuild logs from 2 failures
+  expect(
+    summary.logLines.join("\n"),
+  ).toStrictEqual(`\u001b[38;2;255;0;0mBuild logs from 2 failures
 The following build logs are also available in the Markdown summary:
 ::group::Failed build: /nix/store/rz9hrpay90sjrid5hx3x8v606ji679xa-dep-1.drv
    /nix/store/rz9hrpay90sjrid5hx3x8v606ji679xa-dep-1.drv
@@ -228,14 +229,16 @@ test("Omit some logs if there are too many", async () => {
    return `${drv}\n`.repeat(5).trimEnd();
  };

+  // biome-ignore lint/style/noNonNullAssertion: testing
  const summary: FailureSummary = (await summarizeFailures(
    events,
    logMaker,
    500,
  ))!;

-  expect(summary.markdownLines.join("\n"))
-    .toStrictEqual(`### Build error review :boom:
+  expect(
+    summary.markdownLines.join("\n"),
+  ).toStrictEqual(`### Build error review :boom:
 > [!NOTE]
 > 2 builds failed
 <details><summary>Failure log: <code>/nix/store/rz9hrpay90sjrid5hx3x8v606ji679xa-<strong>dep-1</strong>.drv</code></summary>
@@ -254,8 +257,9 @@ test("Omit some logs if there are too many", async () => {
 > The full logs are available in the post-run phase of the Nix Installer Action.
 > * \`/nix/store/rz9hrpay90sjrid5hx3x8v606ji679xa-dep-3.drv\``);

-  expect(summary.logLines.join("\n"))
-    .toStrictEqual(`\u001b[38;2;255;0;0mBuild logs from 2 failures
+  expect(
+    summary.logLines.join("\n"),
+  ).toStrictEqual(`\u001b[38;2;255;0;0mBuild logs from 2 failures
 The following build logs are also available in the Markdown summary:
 ::group::Failed build: /nix/store/rz9hrpay90sjrid5hx3x8v606ji679xa-dep-1.drv
    /nix/store/rz9hrpay90sjrid5hx3x8v606ji679xa-dep-1.drv
@@ -1,14 +1,14 @@
-import { getExecOutput } from "@actions/exec";
-import { DEvent } from "./events.js";
 import { stripVTControlCharacters } from "node:util";
+import { getExecOutput } from "@actions/exec";
+import { Event } from "./events.js";

 // CI summaries have a max length of "1024k" which I assume to be 1048576 bytes.
 // Generously, the mermaid doc is about 50,000 bytes.
 // Rounding it all down a bit further for wiggle room, that leaves lots of log space.
 const defaultMaxSummaryLength = 995_000;

-export function getBuildFailures(events: DEvent[]): DEvent[] {
-  return events.filter((event: DEvent): Boolean => {
+export function getBuildFailures(events: Event[]): Event[] {
+  return events.filter((event: Event): Boolean => {
    return event.c === "BuildFailureResponseEventV1";
  });
 }
@@ -19,7 +19,7 @@ export interface FailureSummary {
 }

 export async function summarizeFailures(
-  events: DEvent[],
+  events: Event[],
  getLog: (drv: string) => Promise<string | undefined> = getLogFromNix,
  maxLength: number = defaultMaxSummaryLength,
 ): Promise<FailureSummary | undefined> {
@@ -1,34 +1,31 @@
+import { SpawnOptions, spawn } from "node:child_process";
+import fs, { mkdirSync, openSync } from "node:fs";
+import { access, readFile, stat, writeFile } from "node:fs/promises";
+import { userInfo } from "node:os";
+import { join } from "node:path";
+import { setTimeout } from "node:timers/promises";
+import * as path from "path";
 import * as actionsCore from "@actions/core";
 import * as actionsExec from "@actions/exec";
 import * as github from "@actions/github";
-import { access, readFile, stat, writeFile } from "node:fs/promises";
-import { join } from "node:path";
-import fs, { mkdirSync, openSync } from "node:fs";
-import { userInfo } from "node:os";
-import stringArgv from "string-argv";
-import * as path from "path";
 import { DetSysAction, inputs, platform, stringifyError } from "detsys-ts";
 import got from "got";
-import { setTimeout } from "node:timers/promises";
-import { getFixHashes } from "./fixHashes.js";
+import stringArgv from "string-argv";
 import { annotateMismatches } from "./annotate.js";
-import { DEvent, getRecentEvents } from "./events.js";
-import { makeMermaidReport } from "./mermaid.js";
+import { getRecentEvents } from "./events.js";
 import { summarizeFailures } from "./failuresummary.js";
-import { SpawnOptions, spawn } from "node:child_process";
+import { getFixHashes } from "./fixHashes.js";
+import { makeMermaidReport } from "./mermaid.js";

 // Nix installation events
 const EVENT_INSTALL_NIX_FAILURE = "install_nix_failure";
 const EVENT_INSTALL_NIX_START = "install_nix_start";
-const EVENT_INSTALL_NIX_SUCCESS = "install_nix_success";
+const EVENT_INSTALL_NIX_SUCCESS = "install_nix_start";
 const EVENT_SETUP_KVM = "setup_kvm";
 const EVENT_UNINSTALL_NIX = "uninstall";

 // FlakeHub events
-const EVENT_LOGIN_START = "flakehub-login:start";
-const EVENT_LOGIN_FAILURE = "flakehub-login:failure";
-const EVENT_LOGIN_SUCCESS = "flakehub-login:success";
-const EVENT_LOGIN_END = "flakehub-login:end";
+const EVENT_LOGIN_TO_FLAKEHUB = "login_to_flakehub";

 // Other events
 const EVENT_CONCLUDE_JOB = "conclude_job";
@@ -48,7 +45,6 @@ const FACT_SENT_SIGTERM = "sent_sigterm";

 // Flags
 const FLAG_DETERMINATE = "--determinate";
-const FLAG_PREFER_UPSTREAM_NIX = "--prefer-upstream-nix";

 // Pre/post state keys
 const STATE_DAEMONDIR = "DNI_DAEMONDIR";
@@ -90,20 +86,6 @@ class NixInstallerAction extends DetSysAction {
  runnerOs: string | undefined;

  constructor() {
-    if (platform.getArchOs() === "X64-macOS") {
-      // Holy guacamole this is ugly
-      actionsCore.error(
-        "Determinate Nix Installer no longer supports macOS on Intel. Please migrate to Apple Silicon, and use Nix's built-in Rosetta support to build for Intel. See: https://github.com/DeterminateSystems/nix-src/issues/224",
-      );
-      const sourceTag = inputs.getStringOrUndefined("source-tag");
-      if (sourceTag === undefined) {
-        actionsCore.notice(
-          "Pinning the installer tag to v3.12.2 (the last version to support Intel Macs) as a temporary fallback.",
-        );
-        process.env["INPUT_SOURCE-TAG"] = "v3.12.2";
-      }
-    }
-
    super({
      name: "nix-installer",
      fetchStyle: "nix-style",
@@ -156,10 +138,10 @@ class NixInstallerAction extends DetSysAction {
  }

  async main(): Promise<void> {
-    actionsCore.saveState(STATE_START_DATETIME, new Date().toISOString());
    await this.scienceDebugFly();
    await this.detectAndForceNoSystemd();
    await this.install();
+    actionsCore.saveState(STATE_START_DATETIME, new Date().toISOString());
  }

  async post(): Promise<void> {
@@ -175,7 +157,7 @@ class NixInstallerAction extends DetSysAction {
    await this.reportOverall();
  }

-  private get isMacOS(): boolean {
+  private get isMacOs(): boolean {
    return this.runnerOs === "macOS";
  }

@@ -212,17 +194,22 @@ class NixInstallerAction extends DetSysAction {
        });

        this.recordEvent("debug-probe-urls:response", {
-          debug_probe_urls_ip: resp.ip, // eslint-disable-line camelcase
-          debug_probe_urls_ok: resp.ok, // eslint-disable-line camelcase
-          debug_probe_urls_status_code: resp.statusCode, // eslint-disable-line camelcase
-          debug_probe_urls_body: resp.body, // eslint-disable-line camelcase
-          // eslint-disable-next-line camelcase
+          // biome-ignore lint/style/useNamingConvention: Posthog JSON
+          debug_probe_urls_ip: resp.ip,
+          // biome-ignore lint/style/useNamingConvention: Posthog JSON
+          debug_probe_urls_ok: resp.ok,
+          // biome-ignore lint/style/useNamingConvention: Posthog JSON
+          debug_probe_urls_status_code: resp.statusCode,
+          // biome-ignore lint/style/useNamingConvention: Posthog JSON
+          debug_probe_urls_body: resp.body,
+          // biome-ignore lint/style/useNamingConvention: Posthog JSON
          debug_probe_urls_elapsed:
            (resp.timings.end ?? 0) - resp.timings.start,
        });
      } catch (e: unknown) {
        this.recordEvent("debug-probe-urls:exception", {
-          debug_probe_urls_exception: stringifyError(e), // eslint-disable-line camelcase
+          // biome-ignore lint/style/useNamingConvention: Posthog JSON
+          debug_probe_urls_exception: stringifyError(e),
        });
      }
    } catch (err: unknown) {
@@ -300,7 +287,7 @@ class NixInstallerAction extends DetSysAction {
    }

    if (this.nixBuildUserBase !== null) {
-      executionEnv.NIX_INSTALLER_NIX_BUILD_USER_ID_BASE = `${this.nixBuildUserBase}`;
+      executionEnv.NIX_INSTALLER_NIX_BUILD_USER_ID_BASE = `${this.nixBuildUserCount}`;
    }

    if (this.nixPackageUrl !== null) {
@@ -320,14 +307,14 @@ class NixInstallerAction extends DetSysAction {

    // TODO: Error if the user uses these on not-MacOS
    if (this.macEncrypt !== null) {
-      if (!this.isMacOS) {
+      if (!this.isMacOs) {
        throw new Error("`mac-encrypt` while `$RUNNER_OS` was not `macOS`");
      }
      executionEnv.NIX_INSTALLER_ENCRYPT = this.macEncrypt;
    }

    if (this.macCaseSensitive !== null) {
-      if (!this.isMacOS) {
+      if (!this.isMacOs) {
        throw new Error(
          "`mac-case-sensitive` while `$RUNNER_OS` was not `macOS`",
        );
@@ -336,7 +323,7 @@ class NixInstallerAction extends DetSysAction {
    }

    if (this.macVolumeLabel !== null) {
-      if (!this.isMacOS) {
+      if (!this.isMacOs) {
        throw new Error(
          "`mac-volume-label` while `$RUNNER_OS` was not `macOS`",
        );
@@ -345,7 +332,7 @@ class NixInstallerAction extends DetSysAction {
    }

    if (this.macRootDisk !== null) {
-      if (!this.isMacOS) {
+      if (!this.isMacOs) {
        throw new Error("`mac-root-disk` while `$RUNNER_OS` was not `macOS`");
      }
      executionEnv.NIX_INSTALLER_ROOT_DISK = this.macRootDisk;
@@ -361,7 +348,7 @@ class NixInstallerAction extends DetSysAction {

    // TODO: Error if the user uses these on MacOS
    if (this.init !== null) {
-      if (this.isMacOS) {
+      if (this.isMacOs) {
        throw new Error(
          "`init` is not a valid option when `$RUNNER_OS` is `macOS`",
        );
@@ -447,8 +434,6 @@ class NixInstallerAction extends DetSysAction {
      if (this.extraArgs && !this.extraArgs.includes(FLAG_DETERMINATE)) {
        args.push(FLAG_DETERMINATE);
      }
-    } else {
-      args.push(FLAG_PREFER_UPSTREAM_NIX);
    }

    return args;
@@ -616,7 +601,6 @@ class NixInstallerAction extends DetSysAction {
      await stat(socketPath);
      return true;
    } catch (error: unknown) {
-      // eslint-disable-next-line no-undef
      if ((error as NodeJS.ErrnoException).code === "ENOENT") {
        actionsCore.debug(`Socket '${socketPath}' does not exist yet`);
        return false;
@@ -636,8 +620,6 @@ class NixInstallerAction extends DetSysAction {
    const startDate = new Date(actionsCore.getState(STATE_START_DATETIME));
    const { events, hasMismatches } = await getRecentEvents(startDate);

-    await this.reportPassFailCount(events);
-
    const mermaidSummary = makeMermaidReport(events);
    const failureSummary = await summarizeFailures(events);

@@ -688,29 +670,6 @@ class NixInstallerAction extends DetSysAction {
    }
  }

-  async reportPassFailCount(events: DEvent[]): Promise<void> {
-    let built = 0;
-    let failed = 0;
-    let unknown = 0;
-
-    for (const event of events) {
-      switch (event.c) {
-        case "BuiltPathResponseEventV1":
-          built++;
-          break;
-        case "BuildFailureResponseEventV1":
-          failed++;
-          break;
-        default:
-          unknown++;
-      }
-    }
-
-    this.addFact("nix_builds_succeeded", built);
-    this.addFact("nix_builds_failed", failed);
-    this.addFact("nix_builds_unknown_event", unknown);
-  }
-
  async setGithubPath(): Promise<void> {
    // Interim versions of the `nix-installer` crate may have already manipulated `$GITHUB_PATH`, as root even! Accessing that will be an error.
    try {
@@ -735,8 +694,6 @@ class NixInstallerAction extends DetSysAction {
  }

  async flakehubLogin(): Promise<void> {
-    this.recordEvent(EVENT_LOGIN_START);
-
    const canLogin =
      process.env["ACTIONS_ID_TOKEN_REQUEST_URL"] &&
      process.env["ACTIONS_ID_TOKEN_REQUEST_TOKEN"];
@@ -747,20 +704,14 @@ class NixInstallerAction extends DetSysAction {
      const head = pr?.head?.repo?.full_name;

      if (pr && base !== head) {
-        this.recordEvent(EVENT_LOGIN_FAILURE, { reason: "fork" });
-        this.recordEvent(EVENT_LOGIN_END);
-
        actionsCore.info(
-          `FlakeHub is disabled because this is a fork. GitHub Actions does not allow OIDC authentication from forked repositories ("${head}" is not from the same repository as "${base}").`,
+          `Not logging in to FlakeHub: GitHub Actions does not allow OIDC authentication from forked repositories ("${head}" is not the same repository as "${base}").`,
        );
        return;
      }

-      this.recordEvent(EVENT_LOGIN_FAILURE, { reason: "not-configured" });
-      this.recordEvent(EVENT_LOGIN_END);
-
      actionsCore.info(
-        "FlakeHub is disabled because the workflow is misconfigured. Please make sure that `id-token: write` and `contents: read` are set for this step's (or job's) permissions so that GitHub Actions provides OIDC token endpoints.",
+        `Not logging in to FlakeHub: GitHub Actions has not provided OIDC token endpoints; please make sure that \`id-token: write\` and \`contents: read\` are set for this step's (or job's) permissions.`,
      );
      actionsCore.info(
        `For more information, see https://docs.determinate.systems/guides/github-actions/#nix-installer-action`,
@@ -769,18 +720,15 @@ class NixInstallerAction extends DetSysAction {
    }

    actionsCore.startGroup("Logging in to FlakeHub");
+    this.recordEvent(EVENT_LOGIN_TO_FLAKEHUB);
    try {
      await actionsExec.exec(`determinate-nixd`, ["login", "github-action"]);
-      this.recordEvent(EVENT_LOGIN_SUCCESS);
    } catch (e: unknown) {
      actionsCore.warning(`FlakeHub Login failure: ${stringifyError(e)}`);
-      this.recordEvent(EVENT_LOGIN_FAILURE, {
-        reason: "failed",
+      this.recordEvent("flakehub-login:failure", {
        exception: stringifyError(e),
      });
    }
-
-    this.recordEvent(EVENT_LOGIN_END);
    actionsCore.endGroup();
  }

@@ -791,6 +739,7 @@ class NixInstallerAction extends DetSysAction {
      ["uninstall"],
      {
        env: {
+          // biome-ignore lint/style/useNamingConvention: environment variable
          NIX_INSTALLER_NO_CONFIRM: "true",
          ...process.env, // To get $PATH, etc
        },
@@ -1006,7 +955,7 @@ class NixInstallerAction extends DetSysAction {
  }

  private get defaultPlanner(): string {
-    if (this.isMacOS) {
+    if (this.isMacOs) {
      return "macos";
    } else if (this.isLinux) {
      return "linux";
@@ -1052,29 +1001,51 @@ class NixInstallerAction extends DetSysAction {
  }
 }

+// All env vars are strings, no fanciness here.
 type ExecuteEnvironment = {
-  // All env vars are strings, no fanciness here.
+  // biome-ignore lint/style/useNamingConvention: environment variable
  RUST_BACKTRACE?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_MODIFY_PROFILE?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_NIX_BUILD_GROUP_NAME?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_NIX_BUILD_GROUP_ID?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_NIX_BUILD_USER_PREFIX?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_NIX_BUILD_USER_COUNT?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_NIX_BUILD_USER_ID_BASE?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_NIX_PACKAGE_URL?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_PROXY?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_SSL_CERT_FILE?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_DIAGNOSTIC_ENDPOINT?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_DIAGNOSTIC_ATTRIBUTION?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_ENCRYPT?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_CASE_SENSITIVE?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_VOLUME_LABEL?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_ROOT_DISK?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_INIT?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_START_DAEMON?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_NO_CONFIRM?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_EXTRA_CONF?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_LOG_DIRECTIVES?: string;
+  // biome-ignore lint/style/useNamingConvention: environment variable
  NIX_INSTALLER_LOGGER?: string;
 };

@@ -1,11 +1,9 @@
-import { mermaidify, makeMermaidReport } from "./mermaid.js";
-import { DEvent, parseEvents } from "./events.js";
 import { expect, test } from "vitest";
+import { Event, parseEvents } from "./events.js";
+import { makeMermaidReport, mermaidify } from "./mermaid.js";

-/* eslint-disable @typescript-eslint/no-non-null-assertion */
-
-function generateEvents(count: number): DEvent[] {
-  const events: DEvent[] = [];
+function generateEvents(count: number): Event[] {
+  const events: Event[] = [];

  for (let i = 0; i < count; i++) {
    events.push({
@@ -29,16 +27,21 @@ test("Empty event list returns no report", () => {
 });

 test("Create a very large report doc and make sure it is small enough", () => {
+  // biome-ignore lint/style/noNonNullAssertion: testing
  const report = makeMermaidReport(generateEvents(2500))!;

  // Assert the `.drv` suffix was pruned (1 reference = the NOTE at the end)
+  // biome-ignore lint/style/noNonNullAssertion: testing
  expect(report.match(/\.drv/g)!.length).equals(1);

  // Assert the `/nix/store` prefix was pruned (1 reference = the NOTE at the end)
+  // biome-ignore lint/style/noNonNullAssertion: testing
  expect(report.match(/\/nix\/store\//g)!.length).equals(1);

  // Assert that some events were pruned
+  // biome-ignore lint/style/noNonNullAssertion: testing
  expect(report.match(/dep-/g)!.length).lessThan(2500);
+  // biome-ignore lint/style/noNonNullAssertion: testing
  expect(report.match(/dep-/g)!.length).greaterThan(1500);

  expect(report).toContain("suffix, and builds that took less than ");
@@ -49,15 +52,19 @@ test("Create a very large report doc and make sure it is small enough", () => {

 test("Create a medium large report doc and make sure it is small enough", () => {
  const eventCount = 675;
+  // biome-ignore lint/style/noNonNullAssertion: testing
  const report = makeMermaidReport(generateEvents(eventCount))!;

  // Assert the `.drv` suffix was pruned (1 reference = the NOTE at the end)
+  // biome-ignore lint/style/noNonNullAssertion: testing
  expect(report.match(/\.drv/g)!.length).equals(1);

  // Assert the `/nix/store` prefix was pruned (1 reference = the NOTE at the end)
+  // biome-ignore lint/style/noNonNullAssertion: testing
  expect(report.match(/\/nix\/store\//g)!.length).equals(1);

  // Assert that no lines were pruned
+  // biome-ignore lint/style/noNonNullAssertion: testing
  expect(report.match(/dep-/g)!.length).toStrictEqual(eventCount);

  expect(report).toContain(
@@ -69,12 +76,15 @@ test("Create a medium large report doc and make sure it is small enough", () =>
 });

 test("Create a small report doc and make sure it isn't pruned", () => {
+  // biome-ignore lint/style/noNonNullAssertion: testing
  const report = makeMermaidReport(generateEvents(100))!;

  // Assert 100 events have the `.drv` suffix, ie: were not pruned
+  // biome-ignore lint/style/noNonNullAssertion: testing
  expect(report.match(/\.drv/g)!.length).equals(100);

  // Assert 100 events have the `.drv` suffix, ie: were not pruned
+  // biome-ignore lint/style/noNonNullAssertion: testing
  expect(report.match(/\/nix\/store\//g)!.length).equals(100);

  expect(report.length).lessThan(50000);
@@ -83,9 +93,13 @@ test("Create a small report doc and make sure it isn't pruned", () => {
 test("Generate a really big report and shrink it", () => {
  const events = generateEvents(1000);

+  // biome-ignore lint/style/noNonNullAssertion: testing
  const originalLength = mermaidify(events, -1)!.length;
+  // biome-ignore lint/style/noNonNullAssertion: testing
  const limitedLengthZero = mermaidify(events, 0)!.length;
+  // biome-ignore lint/style/noNonNullAssertion: testing
  const limitedLengthOne = mermaidify(events, 1)!.length;
+  // biome-ignore lint/style/noNonNullAssertion: testing
  const limitedLengthTwo = mermaidify(events, 2)!.length;

  expect(originalLength).greaterThan(limitedLengthZero);
@@ -173,9 +187,13 @@ hash-mismatch-md5-base16 (4s):crit, 3, 4s
 test("Generate a really big report and shrink it", () => {
  const events = generateEvents(1000);

+  // biome-ignore lint/style/noNonNullAssertion: testing
  const originalLength = mermaidify(events, -1)!.length;
+  // biome-ignore lint/style/noNonNullAssertion: testing
  const limitedLengthZero = mermaidify(events, 0)!.length;
+  // biome-ignore lint/style/noNonNullAssertion: testing
  const limitedLengthOne = mermaidify(events, 1)!.length;
+  // biome-ignore lint/style/noNonNullAssertion: testing
  const limitedLengthTwo = mermaidify(events, 2)!.length;

  expect(originalLength).greaterThan(limitedLengthZero);
@@ -1,7 +1,7 @@
-import { DEvent } from "./events.js";
+import { Event } from "./events.js";
 import { truncateDerivation } from "./util.js";

-export function makeMermaidReport(events: DEvent[]): string | undefined {
+export function makeMermaidReport(events: Event[]): string | undefined {
  // # 50k is the max: https://github.com/mermaid-js/mermaid/blob/c269dc822c528e1afbde34e18a1cad03d972d4fe/src/defaultConfig.js#L55
  const maxLength = 49900;
  let mermaid = "";
@@ -42,7 +42,7 @@ export function makeMermaidReport(events: DEvent[]): string | undefined {
 }

 export function mermaidify(
-  allEvents: DEvent[],
+  allEvents: Event[],
  pruneLevel: number,
 ): string | undefined {
  const events = allEvents
Author	SHA1	Message	Date
Luc Perkins	a474366708	Use gitignore for Biome ignoring	2025-06-05 14:52:33 -07:00
Luc Perkins	1803d0211a	Use ubuntu-latest	2025-06-02 13:10:44 -07:00
Luc Perkins	5f11b96c1b	Add test step to CI workflow	2025-06-02 13:01:56 -07:00
Luc Perkins	526dc45652	Add test step to script	2025-06-02 13:01:05 -07:00
Luc Perkins	4d4228670a	Fix merge conflicts with main	2025-06-02 13:00:44 -07:00
Luc Perkins	7ace8b67c6	Switch to Biome JS	2025-05-30 10:49:24 -07:00