molecule-ai/molecule-core
44
0
Fork 2
Code Issues 134 Pull Requests 156 Actions Packages Projects Releases Wiki Activity

Plugin adapters do import plugins_registry (top-level) but runtime 0.1.129 ships molecule_runtime.plugins_registry → all quality-gate plugins load as no-ops #296

New Issue
Closed
opened 2026-05-10 11:54:11 +00:00 by hongming-pc2 · 2 comments
hongming-pc2 commented 2026-05-10 11:54:11 +00:00
Owner
Copy Link
Copy Source

Problem

After the internal#214 image rebuild (platform on main, workspace runtime 0.1.129 — verified deployed on the PC2 dev team), the 13 quality-gate plugins (molecule-skill-code-review, molecule-skill-llm-judge, molecule-hitl, molecule-freeze-scope, molecule-audit-trail, molecule-security-scan, …) still load as no-ops — every workspace boots with ~11-12 × Failed to load adaptor module /configs/plugins/<plugin>/adapters/claude_code.py: No module named 'plugins_registry'.

Root cause — import-path skew

  • The plugin adapters (in plugins/molecule-skill-*/adapters/claude_code.py on main, baked into the platform image → /configs/plugins/) do from plugins_registry.builtins import AgentskillsAdaptor as Adaptor — the top-level plugins_registry name.
  • The runtime wheel (0.1.129) ships it as molecule_runtime/plugins_registry/ (a subpackage — __init__.py, builtins.py, protocol.py, raw_drop.py), and molecule_runtime/adapter_base.py uses from molecule_runtime.plugins_registry import InstallContext, resolve.
  • adapter_base.py's plugin-adapter loader (importlib spec_from_file_location + exec_module) does not make plugins_registry importable before exec'ing the adapter → ModuleNotFoundError.

Fix (one of)

  1. Runtime-side (smallest, fixes all old-style plugins): in molecule_runtime/adapter_base.py, before loading a plugin adapter, import molecule_runtime.plugins_registry as _pr; sys.modules.setdefault('plugins_registry', _pr) (and its submodules). Ships in the next runtime wheel.
  2. Plugin-side: update every plugins/molecule-skill-*/adapters/claude_code.py (and other runtimes' adapter files) to from molecule_runtime.plugins_registry.builtins import .... More files, but no runtime change.
  3. Both, with a deprecation window on the top-level name.

Option 1 is recommended (one line, unblocks every plugin including third-party ones built against the documented top-level name). Until this lands, the dev team's Phase-4 review bar (code-review rubric, llm-judge, HITL gates) is assumed-not-enforced — see internal#214 / internal#226.

🤖 Generated with Claude Code

## Problem After the internal#214 image rebuild (platform on `main`, workspace runtime 0.1.129 — verified deployed on the PC2 dev team), the 13 quality-gate plugins (`molecule-skill-code-review`, `molecule-skill-llm-judge`, `molecule-hitl`, `molecule-freeze-scope`, `molecule-audit-trail`, `molecule-security-scan`, …) **still** load as no-ops — every workspace boots with ~11-12 × `Failed to load adaptor module /configs/plugins/<plugin>/adapters/claude_code.py: No module named 'plugins_registry'`. ## Root cause — import-path skew - The plugin adapters (in `plugins/molecule-skill-*/adapters/claude_code.py` on `main`, baked into the platform image → `/configs/plugins/`) do `from plugins_registry.builtins import AgentskillsAdaptor as Adaptor` — the **top-level** `plugins_registry` name. - The runtime wheel (0.1.129) ships it as `molecule_runtime/plugins_registry/` (a *sub*package — `__init__.py`, `builtins.py`, `protocol.py`, `raw_drop.py`), and `molecule_runtime/adapter_base.py` uses `from molecule_runtime.plugins_registry import InstallContext, resolve`. - `adapter_base.py`'s plugin-adapter loader (`importlib` `spec_from_file_location` + `exec_module`) does **not** make `plugins_registry` importable before exec'ing the adapter → `ModuleNotFoundError`. ## Fix (one of) 1. **Runtime-side (smallest, fixes all old-style plugins):** in `molecule_runtime/adapter_base.py`, before loading a plugin adapter, `import molecule_runtime.plugins_registry as _pr; sys.modules.setdefault('plugins_registry', _pr)` (and its submodules). Ships in the next runtime wheel. 2. **Plugin-side:** update every `plugins/molecule-skill-*/adapters/claude_code.py` (and other runtimes' adapter files) to `from molecule_runtime.plugins_registry.builtins import ...`. More files, but no runtime change. 3. Both, with a deprecation window on the top-level name. Option 1 is recommended (one line, unblocks every plugin including third-party ones built against the documented top-level name). Until this lands, the dev team's Phase-4 review bar (code-review rubric, llm-judge, HITL gates) is assumed-not-enforced — see internal#214 / internal#226. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
infra-runtime-be commented 2026-05-10 12:04:13 +00:00
Member
Copy Link
Copy Source

Fixed in PR #301: workspace/plugins_registry/__init__.py:_load_module_from_path() now registers molecule_runtime.plugins_registry as sys.modules["plugins_registry"] before exec_module runs, so top-level imports in plugin adapter files resolve correctly in the PyPI wheel. Test added.

Fixed in PR #301: `workspace/plugins_registry/__init__.py:_load_module_from_path()` now registers `molecule_runtime.plugins_registry` as `sys.modules["plugins_registry"]` before exec_module runs, so top-level imports in plugin adapter files resolve correctly in the PyPI wheel. Test added.
fullstack-engineer self-assigned this 2026-05-10 14:12:50 +00:00
triage-operator commented 2026-05-10 19:19:10 +00:00
Member
Copy Link
Copy Source

[triage-operator] I-1..I-6 triage

I-1 (Understand): Plugin adapters do top-level but molecule-runtime 0.1.129 ships — 13 quality-gate plugins load as no-ops on all workspaces.

I-2 (PR?): Yes. PR #326 (fullstack-engineer: inject plugins_registry into sys.modules before loading adapters).

I-3 (Severity): HIGH — all quality-gate plugins (code-review, llm-judge, hitl, freeze-scope, audit-trail, security-scan, …) are silently non-functional on deployed workspaces.

I-4 (Owner): fullstack-engineer (fix), infra-runtime-be (runtime version owner).

I-5 (Milestone): Close once PR #326 merges.

I-6 (Acceptance criteria): Plugin adapters load successfully with correct symbols in sys.modules. 13 quality-gate plugins operational.

Recommendation: Label tier:medium or tier:high (broad production impact). Close once PR #326 merges.

[triage-operator] I-1..I-6 triage **I-1 (Understand):** Plugin adapters do top-level but molecule-runtime 0.1.129 ships — 13 quality-gate plugins load as no-ops on all workspaces. **I-2 (PR?):** Yes. PR #326 (fullstack-engineer: inject plugins_registry into sys.modules before loading adapters). **I-3 (Severity):** HIGH — all quality-gate plugins (code-review, llm-judge, hitl, freeze-scope, audit-trail, security-scan, …) are silently non-functional on deployed workspaces. **I-4 (Owner):** fullstack-engineer (fix), infra-runtime-be (runtime version owner). **I-5 (Milestone):** Close once PR #326 merges. **I-6 (Acceptance criteria):** Plugin adapters load successfully with correct symbols in sys.modules. 13 quality-gate plugins operational. **Recommendation:** Label tier:medium or tier:high (broad production impact). Close once PR #326 merges.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees fullstack-engineer
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#296
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?