fix(queue): query merge-queue label by name not resolved ID
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
CI / Detect changes (pull_request) Successful in 4s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 12s
E2E API Smoke Test / detect-changes (pull_request) Successful in 5s
E2E Chat / detect-changes (pull_request) Successful in 4s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 5s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 5s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 56s
gate-check-v3 / gate-check (pull_request) Successful in 3s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 53s
qa-review / approved (pull_request) Failing after 3s
sop-checklist / na-declarations (pull_request) N/A: (none)
security-review / approved (pull_request) Failing after 3s
sop-checklist / all-items-acked (pull_request) Successful in 3s
sop-tier-check / tier-check (pull_request) Successful in 3s
CI / Platform (Go) (pull_request) Successful in 4m34s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
CI / Canvas (Next.js) (pull_request) Successful in 6m14s
E2E Chat / E2E Chat (pull_request) Successful in 1s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 1s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s
CI / Python Lint & Test (pull_request) Successful in 6m28s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 5m52s

Gitea orders /issues?labels=<id> by PR number ascending with limit
applied before PR #1233 appears — the 50-result page starts at PR #1309
and misses #1233 entirely. Querying by label name returns #1233
correctly. Drop the _ensure_label_ids() startup call (one less API
round-trip per tick) and the now-dead _QUEUE_LABEL_ID/_HOLD_LABEL_ID
globals. Resolves the queue label query bug root-causing SEV-1 #487.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
2026-05-17 09:14:36 +00:00
parent 6c06227871
commit 5e47d2e385
+1 -14
View File
@@ -311,28 +311,15 @@ def _resolve_label_id(name: str) -> str | None:
return None
# Resolve label names to IDs once at startup so list_queued_issues() and
# hold-label checks use stable IDs even when duplicate names exist in the repo.
_QUEUE_LABEL_ID: str | None = None
_HOLD_LABEL_ID: str | None = None
def _ensure_label_ids() -> None:
global _QUEUE_LABEL_ID, _HOLD_LABEL_ID
if _QUEUE_LABEL_ID is None:
_QUEUE_LABEL_ID = _resolve_label_id(QUEUE_LABEL) or QUEUE_LABEL
_HOLD_LABEL_ID = _resolve_label_id(HOLD_LABEL) or HOLD_LABEL
def list_queued_issues() -> list[dict]:
_ensure_label_ids()
_, body = api(
"GET",
f"/repos/{OWNER}/{NAME}/issues",
query={
"state": "open",
"type": "pulls",
"labels": _QUEUE_LABEL_ID,
"labels": QUEUE_LABEL,
"limit": "50",
},
)