Compare commits
17 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 792039e016 | |||
| d03845c4ff | |||
| 438a04a380 | |||
| 022cab0dbb | |||
| fd66cb201e | |||
| 861b562d12 | |||
| 7badce1740 | |||
| e562b60d1b | |||
| 4a84eb3a6b | |||
| d4ed094c7b | |||
| ed089b0c68 | |||
| 09ea1f9ed6 | |||
| d587919d17 | |||
| 15d8cec45f | |||
| 76f37d928f | |||
| 51fb38e063 | |||
| 2ee3b42d6b |
@@ -0,0 +1 @@
|
|||||||
|
ci-auth-test-1778443313
|
||||||
@@ -0,0 +1 @@
|
|||||||
|
ci-auth-test2-1778443456
|
||||||
@@ -0,0 +1,39 @@
|
|||||||
|
name: CI / Test
|
||||||
|
|
||||||
|
# Runs on every PR touching Go code, and on every push to main.
|
||||||
|
# Mirrors the test job from release.yml so PRs are validated independently
|
||||||
|
# of the release workflow. Uses Go 1.25 to match release.yml.
|
||||||
|
|
||||||
|
on:
|
||||||
|
push:
|
||||||
|
branches: [main]
|
||||||
|
paths:
|
||||||
|
- '**.go'
|
||||||
|
- 'go.mod'
|
||||||
|
- 'go.sum'
|
||||||
|
- '.github/workflows/ci.yml'
|
||||||
|
pull_request:
|
||||||
|
paths:
|
||||||
|
- '**.go'
|
||||||
|
- 'go.mod'
|
||||||
|
- 'go.sum'
|
||||||
|
- '.github/workflows/ci.yml'
|
||||||
|
|
||||||
|
permissions:
|
||||||
|
contents: read
|
||||||
|
|
||||||
|
jobs:
|
||||||
|
test:
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@v4
|
||||||
|
- uses: actions/setup-go@v5
|
||||||
|
with:
|
||||||
|
go-version: '1.25'
|
||||||
|
cache: true
|
||||||
|
- name: Tidy
|
||||||
|
run: go mod tidy && git diff --exit-code go.sum
|
||||||
|
- name: Vet
|
||||||
|
run: go vet ./...
|
||||||
|
- name: Test
|
||||||
|
run: go test -race -count=1 ./...
|
||||||
@@ -0,0 +1 @@
|
|||||||
|
verify-fix-1778444420
|
||||||
@@ -4,7 +4,7 @@ Go CLI for the Molecule AI agent platform. Wraps the platform's workspace runtim
|
|||||||
|
|
||||||
**Users:** Platform operators and developers integrating with the Molecule AI platform.
|
**Users:** Platform operators and developers integrating with the Molecule AI platform.
|
||||||
|
|
||||||
**Repo state (2026-04-16):** Thin/stub. Go module is initialized; core CLI commands are not yet implemented. CI (Go binary release via GoReleaser + GitHub Actions) is wired up.
|
**Repo state:** Core commands implemented. 32 integration tests in `cmd/molecule/molecule_test.go`.
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
@@ -23,18 +23,16 @@ This CLI is the primary user-facing tool for interacting with the Molecule AI pl
|
|||||||
# Build the binary to ./bin/molecule (or $GOBIN/molecule)
|
# Build the binary to ./bin/molecule (or $GOBIN/molecule)
|
||||||
go build -o bin/molecule ./cmd/molecule
|
go build -o bin/molecule ./cmd/molecule
|
||||||
|
|
||||||
# Run tests (none yet; add as commands are implemented)
|
# Run tests — uses httptest.Server fixtures, no live platform required
|
||||||
go test ./...
|
go test ./...
|
||||||
|
|
||||||
# Run the CLI locally (requires platform env vars — see Section 5)
|
# Run the CLI locally (requires platform env vars — see Section 5)
|
||||||
./bin/molecule --help
|
./bin/molecule --help
|
||||||
```
|
```
|
||||||
|
|
||||||
There is no `main.go` or `cmd/molecule/main.go` yet. Creating it is the first implementation task. The module path will be auto-detected from `go.mod`.
|
|
||||||
|
|
||||||
## 3. Go Module Conventions
|
## 3. Go Module Conventions
|
||||||
|
|
||||||
**Module path:** `github.com/Molecule-AI/molecule-cli` (from `go.mod`)
|
**Module path:** `go.moleculesai.app/cli` (from `go.mod`)
|
||||||
|
|
||||||
**Dependency management:**
|
**Dependency management:**
|
||||||
- Use `go mod tidy` after adding or removing dependencies.
|
- Use `go mod tidy` after adding or removing dependencies.
|
||||||
@@ -131,8 +129,8 @@ See `known-issues.md` at the repo root for the full tracked list.
|
|||||||
- [x] Control plane API client (initialized with `MOLECULE_API_URL`)
|
- [x] Control plane API client (initialized with `MOLECULE_API_URL`)
|
||||||
- [ ] Workspace runtime client (for dev/proxy mode)
|
- [ ] Workspace runtime client (for dev/proxy mode)
|
||||||
- [ ] Configuration file (e.g., `~/.config/molecule/cli.yaml`) — workspace template per platform rules
|
- [ ] Configuration file (e.g., `~/.config/molecule/cli.yaml`) — workspace template per platform rules
|
||||||
- [ ] Unit tests for core command logic
|
- [x] Unit tests for core command logic (32 integration tests)
|
||||||
- [ ] `molecule init` (bootstrap local workspace config)
|
- [x] `molecule init` (bootstrap local workspace config)
|
||||||
|
|
||||||
**Platform constraint reminders (from `constraints-and-rules.md`):**
|
**Platform constraint reminders (from `constraints-and-rules.md`):**
|
||||||
- Postgres is the source of truth. CLI commands that mutate state ultimately write to Postgres via the control plane.
|
- Postgres is the source of truth. CLI commands that mutate state ultimately write to Postgres via the control plane.
|
||||||
|
|||||||
@@ -8,12 +8,23 @@ command, or a mock for CI).
|
|||||||
## Install
|
## Install
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
go install github.com/Molecule-AI/molecule-cli/cmd/molecule@latest
|
go install go.moleculesai.app/cli/cmd/molecule@latest
|
||||||
```
|
```
|
||||||
|
|
||||||
Or download a binary from [Releases](https://github.com/Molecule-AI/molecule-cli/releases).
|
The vanity import path `go.moleculesai.app/cli` resolves via the
|
||||||
Releases ship Linux/macOS/Windows × amd64/arm64 archives plus a sha256
|
Molecules AI go-get responder (issue [internal#71][i71]) to our
|
||||||
checksums file (see `.goreleaser.yaml`).
|
canonical SCM at git.moleculesai.app. It is independent of any specific
|
||||||
|
SCM host — when we move SCMs again, no install command changes.
|
||||||
|
|
||||||
|
Alternatively, build from source:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git clone https://git.moleculesai.app/molecule-ai/molecule-cli.git
|
||||||
|
cd molecule-cli
|
||||||
|
go build -o molecule ./cmd/molecule
|
||||||
|
```
|
||||||
|
|
||||||
|
[i71]: https://git.moleculesai.app/molecule-ai/internal/issues/71
|
||||||
|
|
||||||
## Quick start — connect an external workspace
|
## Quick start — connect an external workspace
|
||||||
|
|
||||||
@@ -78,7 +89,7 @@ molecule config view / set CLI defaults
|
|||||||
molecule completion generate shell completions
|
molecule completion generate shell completions
|
||||||
```
|
```
|
||||||
|
|
||||||
The full M1 design is in [RFC #10](https://github.com/Molecule-AI/molecule-cli/issues/10).
|
The full M1 design is in [RFC #10](https://git.moleculesai.app/molecule-ai/molecule-cli/issues/10) (originally filed on the suspended GitHub org; the issue may be re-filed on Gitea — check the issue tracker for the live discussion).
|
||||||
|
|
||||||
## License
|
## License
|
||||||
|
|
||||||
|
|||||||
@@ -6,7 +6,7 @@ package main
|
|||||||
import (
|
import (
|
||||||
"os"
|
"os"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/cmd"
|
"go.moleculesai.app/cli/internal/cmd"
|
||||||
)
|
)
|
||||||
|
|
||||||
func main() {
|
func main() {
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
module github.com/Molecule-AI/molecule-cli
|
module go.moleculesai.app/cli
|
||||||
|
|
||||||
go 1.25.0
|
go 1.25.0
|
||||||
|
|
||||||
|
|||||||
@@ -5,7 +5,7 @@
|
|||||||
// that registers itself via `Register()` from an `init()` block.
|
// that registers itself via `Register()` from an `init()` block.
|
||||||
// Runtime selection is done via the --backend flag.
|
// Runtime selection is done via the --backend flag.
|
||||||
//
|
//
|
||||||
// See RFC: https://github.com/Molecule-AI/molecule-cli/issues/10
|
// See RFC: https://git.moleculesai.app/molecule-ai/molecule-cli/issues/10
|
||||||
package backends
|
package backends
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
|||||||
@@ -5,8 +5,8 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/backends"
|
"go.moleculesai.app/cli/internal/backends"
|
||||||
_ "github.com/Molecule-AI/molecule-cli/internal/backends/mock" // register
|
_ "go.moleculesai.app/cli/internal/backends/mock" // register
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestRegister_DuplicatePanics(t *testing.T) {
|
func TestRegister_DuplicatePanics(t *testing.T) {
|
||||||
|
|||||||
@@ -29,8 +29,8 @@ package claudecode
|
|||||||
import (
|
import (
|
||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/backends"
|
"go.moleculesai.app/cli/internal/backends"
|
||||||
exec "github.com/Molecule-AI/molecule-cli/internal/backends/exec"
|
exec "go.moleculesai.app/cli/internal/backends/exec"
|
||||||
)
|
)
|
||||||
|
|
||||||
func init() {
|
func init() {
|
||||||
|
|||||||
@@ -6,8 +6,8 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/backends"
|
"go.moleculesai.app/cli/internal/backends"
|
||||||
_ "github.com/Molecule-AI/molecule-cli/internal/backends/claudecode" // register
|
_ "go.moleculesai.app/cli/internal/backends/claudecode" // register
|
||||||
)
|
)
|
||||||
|
|
||||||
func requireUnix(t *testing.T) {
|
func requireUnix(t *testing.T) {
|
||||||
|
|||||||
@@ -41,7 +41,7 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/backends"
|
"go.moleculesai.app/cli/internal/backends"
|
||||||
)
|
)
|
||||||
|
|
||||||
func init() {
|
func init() {
|
||||||
|
|||||||
@@ -7,8 +7,8 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/backends"
|
"go.moleculesai.app/cli/internal/backends"
|
||||||
_ "github.com/Molecule-AI/molecule-cli/internal/backends/exec" // register
|
_ "go.moleculesai.app/cli/internal/backends/exec" // register
|
||||||
)
|
)
|
||||||
|
|
||||||
// requireUnix skips Windows tests that depend on /bin/sh shell semantics.
|
// requireUnix skips Windows tests that depend on /bin/sh shell semantics.
|
||||||
|
|||||||
@@ -14,7 +14,7 @@ import (
|
|||||||
"context"
|
"context"
|
||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/backends"
|
"go.moleculesai.app/cli/internal/backends"
|
||||||
)
|
)
|
||||||
|
|
||||||
func init() {
|
func init() {
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ import (
|
|||||||
"os"
|
"os"
|
||||||
"text/tabwriter"
|
"text/tabwriter"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/client"
|
"go.moleculesai.app/cli/internal/client"
|
||||||
"github.com/spf13/cobra"
|
"github.com/spf13/cobra"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|||||||
@@ -121,7 +121,7 @@ var configInitCmd = &cobra.Command{
|
|||||||
}
|
}
|
||||||
|
|
||||||
func runConfigInit(cmd *cobra.Command, _ []string) error {
|
func runConfigInit(cmd *cobra.Command, _ []string) error {
|
||||||
const defaultConfig = `# molecule CLI config — https://github.com/Molecule-AI/molecule-cli
|
const defaultConfig = `# molecule CLI config — https://git.moleculesai.app/molecule-ai/molecule-cli
|
||||||
#
|
#
|
||||||
# All values can be overridden by environment variables:
|
# All values can be overridden by environment variables:
|
||||||
# MOLECULE_API_URL, MOLECULE_RUNTIME_URL, MOL_OUTPUT, MOL_VERBOSE, etc.
|
# MOLECULE_API_URL, MOLECULE_RUNTIME_URL, MOL_OUTPUT, MOL_VERBOSE, etc.
|
||||||
|
|||||||
@@ -9,11 +9,11 @@ import (
|
|||||||
"syscall"
|
"syscall"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/backends"
|
"go.moleculesai.app/cli/internal/backends"
|
||||||
_ "github.com/Molecule-AI/molecule-cli/internal/backends/claudecode" // register backend
|
_ "go.moleculesai.app/cli/internal/backends/claudecode" // register backend
|
||||||
_ "github.com/Molecule-AI/molecule-cli/internal/backends/exec" // register backend
|
_ "go.moleculesai.app/cli/internal/backends/exec" // register backend
|
||||||
_ "github.com/Molecule-AI/molecule-cli/internal/backends/mock" // register backend
|
_ "go.moleculesai.app/cli/internal/backends/mock" // register backend
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/connect"
|
"go.moleculesai.app/cli/internal/connect"
|
||||||
"github.com/spf13/cobra"
|
"github.com/spf13/cobra"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -21,7 +21,7 @@ import (
|
|||||||
// molecule connect — bridge an external-runtime workspace to a local backend.
|
// molecule connect — bridge an external-runtime workspace to a local backend.
|
||||||
//
|
//
|
||||||
// The full M1+ design lives in the RFC at
|
// The full M1+ design lives in the RFC at
|
||||||
// https://github.com/Molecule-AI/molecule-cli/issues/10. This file owns the
|
// https://git.moleculesai.app/molecule-ai/molecule-cli/issues/10. This file owns the
|
||||||
// command surface; the wiring (heartbeat, activity poll, dispatch) lands in
|
// command surface; the wiring (heartbeat, activity poll, dispatch) lands in
|
||||||
// internal/connect/ in subsequent PRs.
|
// internal/connect/ in subsequent PRs.
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
@@ -68,7 +68,7 @@ Examples:
|
|||||||
molecule connect ws_01HF2K... --backend exec \
|
molecule connect ws_01HF2K... --backend exec \
|
||||||
--backend-opt cmd="python myhandler.py"
|
--backend-opt cmd="python myhandler.py"
|
||||||
|
|
||||||
See full design: https://github.com/Molecule-AI/molecule-cli/issues/10`,
|
See full design: https://git.moleculesai.app/molecule-ai/molecule-cli/issues/10`,
|
||||||
Args: cobra.ExactArgs(1),
|
Args: cobra.ExactArgs(1),
|
||||||
RunE: runConnect,
|
RunE: runConnect,
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -40,7 +40,7 @@ func runInit(cmd *cobra.Command, _ []string) error {
|
|||||||
|
|
||||||
if _, err := os.Stat(cfgPath); err == nil {
|
if _, err := os.Stat(cfgPath); err == nil {
|
||||||
if initForce {
|
if initForce {
|
||||||
content := `# molecule CLI configuration — https://github.com/Molecule-AI/molecule-cli
|
content := `# molecule CLI configuration — https://git.moleculesai.app/molecule-ai/molecule-cli
|
||||||
#
|
#
|
||||||
# All values can be overridden by environment variables:
|
# All values can be overridden by environment variables:
|
||||||
# MOLECULE_API_URL, MOLECULE_RUNTIME_URL, MOL_OUTPUT, MOL_VERBOSE, etc.
|
# MOLECULE_API_URL, MOLECULE_RUNTIME_URL, MOL_OUTPUT, MOL_VERBOSE, etc.
|
||||||
@@ -69,7 +69,7 @@ func runInit(cmd *cobra.Command, _ []string) error {
|
|||||||
return fmt.Errorf("init: %s already exists — not overwriting (use --force to replace)", cfgPath)
|
return fmt.Errorf("init: %s already exists — not overwriting (use --force to replace)", cfgPath)
|
||||||
}
|
}
|
||||||
|
|
||||||
content := `# molecule CLI configuration — https://github.com/Molecule-AI/molecule-cli
|
content := `# molecule CLI configuration — https://git.moleculesai.app/molecule-ai/molecule-cli
|
||||||
#
|
#
|
||||||
# All values can be overridden by environment variables:
|
# All values can be overridden by environment variables:
|
||||||
# MOLECULE_API_URL, MOLECULE_RUNTIME_URL, MOL_OUTPUT, MOL_VERBOSE, etc.
|
# MOLECULE_API_URL, MOLECULE_RUNTIME_URL, MOL_OUTPUT, MOL_VERBOSE, etc.
|
||||||
|
|||||||
@@ -8,7 +8,7 @@ import (
|
|||||||
"os"
|
"os"
|
||||||
"text/tabwriter"
|
"text/tabwriter"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/client"
|
"go.moleculesai.app/cli/internal/client"
|
||||||
"github.com/spf13/cobra"
|
"github.com/spf13/cobra"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ import (
|
|||||||
"os"
|
"os"
|
||||||
"text/tabwriter"
|
"text/tabwriter"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/client"
|
"go.moleculesai.app/cli/internal/client"
|
||||||
"github.com/spf13/cobra"
|
"github.com/spf13/cobra"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|||||||
@@ -9,7 +9,7 @@ import (
|
|||||||
"sync"
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/backends"
|
"go.moleculesai.app/cli/internal/backends"
|
||||||
)
|
)
|
||||||
|
|
||||||
// Options carries the runtime knobs Run needs. Constructed by the cmd
|
// Options carries the runtime knobs Run needs. Constructed by the cmd
|
||||||
|
|||||||
@@ -13,9 +13,9 @@ import (
|
|||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/backends"
|
"go.moleculesai.app/cli/internal/backends"
|
||||||
_ "github.com/Molecule-AI/molecule-cli/internal/backends/mock" // register mock for tests
|
_ "go.moleculesai.app/cli/internal/backends/mock" // register mock for tests
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/connect"
|
"go.moleculesai.app/cli/internal/connect"
|
||||||
)
|
)
|
||||||
|
|
||||||
// fakeServer is the minimum workspace-server stub the loops need:
|
// fakeServer is the minimum workspace-server stub the loops need:
|
||||||
|
|||||||
@@ -5,7 +5,7 @@ import (
|
|||||||
"path/filepath"
|
"path/filepath"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/Molecule-AI/molecule-cli/internal/connect"
|
"go.moleculesai.app/cli/internal/connect"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestState_LoadMissingReturnsZero(t *testing.T) {
|
func TestState_LoadMissingReturnsZero(t *testing.T) {
|
||||||
|
|||||||
@@ -0,0 +1,146 @@
|
|||||||
|
// Issue molecule-ai/internal#71 lint gate.
|
||||||
|
//
|
||||||
|
// Walks every *.go file in the module + the go.mod declaration + any
|
||||||
|
// Dockerfile in the repo, and rejects any reference to the dead
|
||||||
|
// github.com/Molecule-AI/* identity (or the historical
|
||||||
|
// Molecule-AI/molecule-monorepo path).
|
||||||
|
//
|
||||||
|
// We had a 374+131+30+1-line "github.com/Molecule-AI/" footprint across
|
||||||
|
// the org pre-migration. The class of bug this gate prevents:
|
||||||
|
//
|
||||||
|
// - copy-pastes from old branches re-introducing the dead path
|
||||||
|
// - Dockerfile -ldflags strings drifting back to github.com on a
|
||||||
|
// refactor (the path has to match the module declaration to inject
|
||||||
|
// buildinfo correctly; if they disagree the binary builds but
|
||||||
|
// reports a wrong / stale GitSHA)
|
||||||
|
// - new modules added to the repo with the wrong import root because
|
||||||
|
// someone copied an old go.mod without thinking
|
||||||
|
//
|
||||||
|
// Why not just a CI shell grep: a Go test runs everywhere `go test ./...`
|
||||||
|
// runs, including local pre-push hooks and contributor IDEs. The gate
|
||||||
|
// fires immediately, with a per-file message that points at the line —
|
||||||
|
// CI shell grep failures are silent until the runner picks them up.
|
||||||
|
|
||||||
|
package lint
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// forbiddenSubstrings is the literal-match list. Each string MUST NOT
|
||||||
|
// appear anywhere under the module root. Entries are checked with
|
||||||
|
// substring matching, not regex — keep the patterns specific enough
|
||||||
|
// that a false-positive needs an explicit allowlist entry.
|
||||||
|
var forbiddenSubstrings = []string{
|
||||||
|
"github.com/Molecule-AI/",
|
||||||
|
"Molecule-AI/molecule-monorepo",
|
||||||
|
}
|
||||||
|
|
||||||
|
// allowlistedFiles is the per-file escape hatch. Empty by default —
|
||||||
|
// add an entry only when there is a documented reason a forbidden
|
||||||
|
// string MUST appear (e.g. a regression-test fixture that asserts
|
||||||
|
// the lint gate itself rejects the string). Each entry MUST be
|
||||||
|
// accompanied by a comment explaining why.
|
||||||
|
var allowlistedFiles = map[string]bool{
|
||||||
|
// (intentionally empty — add only with justification)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNoLegacyGitHubImportPaths(t *testing.T) {
|
||||||
|
moduleRoot, err := findModuleRoot()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("findModuleRoot: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
checkExt := map[string]bool{
|
||||||
|
".go": true,
|
||||||
|
".mod": true,
|
||||||
|
".sum": false, // go.sum is auto-generated, refs flow from go.mod
|
||||||
|
".sh": true,
|
||||||
|
".yml": true,
|
||||||
|
".yaml": true,
|
||||||
|
".toml": true,
|
||||||
|
".md": true,
|
||||||
|
".json": true, // package.json / tsconfig.json — catches ref drift in package metadata
|
||||||
|
}
|
||||||
|
checkBasename := map[string]bool{
|
||||||
|
"Dockerfile": true,
|
||||||
|
"Dockerfile.tenant": true,
|
||||||
|
}
|
||||||
|
|
||||||
|
violations := 0
|
||||||
|
walkErr := filepath.Walk(moduleRoot, func(path string, info os.FileInfo, err error) error {
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if info.IsDir() {
|
||||||
|
// Skip vendor + .git + node_modules — not our code.
|
||||||
|
base := info.Name()
|
||||||
|
if base == "vendor" || base == ".git" || base == "node_modules" || base == "testdata" {
|
||||||
|
return filepath.SkipDir
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
ext := filepath.Ext(path)
|
||||||
|
base := filepath.Base(path)
|
||||||
|
if !checkExt[ext] && !checkBasename[base] {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
rel, _ := filepath.Rel(moduleRoot, path)
|
||||||
|
if allowlistedFiles[rel] {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
// Skip the lint test itself — it legitimately names the forbidden
|
||||||
|
// strings as match patterns.
|
||||||
|
if strings.HasSuffix(rel, "import_path_lint_test.go") {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
data, err := os.ReadFile(path)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
text := string(data)
|
||||||
|
for _, bad := range forbiddenSubstrings {
|
||||||
|
if strings.Contains(text, bad) {
|
||||||
|
// Find the line number for a useful error message.
|
||||||
|
for lineNo, line := range strings.Split(text, "\n") {
|
||||||
|
if strings.Contains(line, bad) {
|
||||||
|
t.Errorf("%s:%d — forbidden substring %q (use go.moleculesai.app/<area>/... per molecule-ai/internal#71)", rel, lineNo+1, bad)
|
||||||
|
violations++
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
})
|
||||||
|
if walkErr != nil {
|
||||||
|
t.Fatalf("walk: %v", walkErr)
|
||||||
|
}
|
||||||
|
if violations > 0 {
|
||||||
|
t.Logf("Total violations: %d. Add to allowlistedFiles ONLY with a documented justification.", violations)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// findModuleRoot walks up from the test's CWD to find go.mod. The Go
|
||||||
|
// test harness sets CWD to the package directory; the module root may
|
||||||
|
// be one or more parents up.
|
||||||
|
func findModuleRoot() (string, error) {
|
||||||
|
cwd, err := os.Getwd()
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
dir := cwd
|
||||||
|
for {
|
||||||
|
if _, err := os.Stat(filepath.Join(dir, "go.mod")); err == nil {
|
||||||
|
return dir, nil
|
||||||
|
}
|
||||||
|
parent := filepath.Dir(dir)
|
||||||
|
if parent == dir {
|
||||||
|
return "", os.ErrNotExist
|
||||||
|
}
|
||||||
|
dir = parent
|
||||||
|
}
|
||||||
|
}
|
||||||
+23
-18
@@ -93,7 +93,7 @@ entries may cause CI divergence or checksum mismatches.
|
|||||||
|
|
||||||
### Impact
|
### Impact
|
||||||
`go mod verify` in CI may fail if `go.sum` has extra entries not in the
|
`go mod verify` in CI may fail if `go.sum` has extra entries not in the
|
||||||
lock file. Additionally, if the module path (`github.com/Molecule-AI/molecule-cli`)
|
lock file. Additionally, if the module path (`go.moleculesai.app/cli`)
|
||||||
is referenced via `replace` directives from other repos, those references may
|
is referenced via `replace` directives from other repos, those references may
|
||||||
persist stale entries.
|
persist stale entries.
|
||||||
|
|
||||||
@@ -130,24 +130,29 @@ is set to `.` (repo root) since the main package is at `cmd/molecule`.
|
|||||||
|
|
||||||
## KI-005 — No integration test for the full CLI lifecycle
|
## KI-005 — No integration test for the full CLI lifecycle
|
||||||
|
|
||||||
**File:** `tests/` (does not exist)
|
**File:** `cmd/molecule/molecule_test.go`, `internal/`
|
||||||
**Status:** Not yet implemented
|
**Status:** ✅ Resolved
|
||||||
**Severity:** Medium
|
**Severity:** Medium
|
||||||
|
|
||||||
### Symptom
|
### Resolution
|
||||||
There are no tests at all (per `go test ./...` — no packages match).
|
`cmd/molecule/molecule_test.go` contains 32 table-driven integration tests
|
||||||
As subcommands are built, there is no test harness for end-to-end CLI testing
|
covering the full CLI command surface. Each test:
|
||||||
(e.g. `molecule workspace create --name test --output json` → verify JSON output).
|
- Starts a `httptest.Server` that mirrors the platform REST API (workspace CRUD,
|
||||||
|
agent inspection, delegation, health, audit, config, completion scripts).
|
||||||
|
- Builds the `molecule` binary via `go build -o <tempdir>/molecule .`
|
||||||
|
- Executes it with `exec.Command` and validates stdout/stderr output.
|
||||||
|
|
||||||
### Impact
|
Test coverage includes:
|
||||||
Each subcommand will be shipped without regression protection. Manual testing
|
- Root help, workspace/agent/platform/config help
|
||||||
is required for every release. The absence of a `tests/` directory also means
|
- `workspace list`, `workspace inspect`, `workspace create`, `workspace delete`,
|
||||||
there is no fixture for CLI integration testing with recorded API responses.
|
`workspace restart`, `workspace audit`, `workspace delegate`
|
||||||
|
- `agent list`, `agent inspect`, `agent send`, `agent peers`
|
||||||
|
- `platform health`, `platform audit`
|
||||||
|
- `config init`, `config list`
|
||||||
|
- `init`, `init --force`
|
||||||
|
- `completion bash/zsh/fish/powershell`
|
||||||
|
- Error paths: missing workspace, missing agent, unknown subcommand,
|
||||||
|
missing required args, duplicate init
|
||||||
|
|
||||||
### Suggested fix
|
Run `go test ./...` from the repo root to execute. No live platform required —
|
||||||
Add `tests/` with:
|
all tests use `httptest.Server` fixtures.
|
||||||
- `cmd/molecule/molecule_test.go` — table-driven tests for each subcommand
|
|
||||||
using `exec.Command("molecule", ...)` against a built binary
|
|
||||||
- Use `molecule-sdk-python` fixture server or recorded API responses for
|
|
||||||
offline testing
|
|
||||||
- Add `go test ./...` to CI; require >0 test packages before merge
|
|
||||||
|
|||||||
Reference in New Issue
Block a user