forked from molecule-ai/molecule-core
Hongming Wang
02ae2fd6fb
Defense-in-depth follow-up to #2481 (peer_id trust-boundary gate). Same XML-attribute injection vector applies to the four other meta fields rendered as agent-context attrs in the <channel> tag: <channel kind="..." method="..." activity_id="..." ts="..." source="molecule"> Each field is now passed through a closed-set / shape-validate gate: - kind → frozenset {canvas_user, peer_agent} via _safe_meta_field - method → frozenset {message/send, tasks/send, tasks/get, notify, ""} - activity_id → UUID-shape regex via _safe_activity_id - ts → ISO-8601 RFC3339 regex via _safe_ts Any value outside the allowed shape is replaced with empty string. Today the values come from a platform-DB column so they're trusted, but "trust the source" was the same assumption that got peer_id into trouble (#2481). Closed-enum allowlists make this row-content-blind. 5 new tests mirroring test_envelope_enrichment_strips_path_traversal_peer_id: - test_envelope_strips_unknown_kind — kind injection stripped - test_envelope_strips_unknown_method — method injection stripped - test_envelope_strips_malformed_activity_id — non-UUID stripped - test_envelope_strips_malformed_ts — non-ISO8601 stripped - test_envelope_keeps_valid_meta_fields_unchanged — happy-path negative case Mutation-tested: temporarily making _safe_meta_field permissive kills both kind/method strip tests with the injection payload reflecting into the meta dict, confirming the gate is what blocks them. Two existing tests updated to use UUID-shaped activity_ids ("act-7", "act-bridge-test" → real UUIDs) since the gate strips synthetic ids. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>