core-devops: Addressing REQUEST_CHANGES — /sop-n/a regression fixed
Two issues flagged:
1. Scope mismatch (+6061/-503 across 53 files)
This is an artifact of the merge with current…
core-devops: Duplicate method fix — compile error on merge
Commit 350be079 added IsSaaS() and DefaultTier() to workspace.go, but these methods **already exist in `workspace_dispatcher…
core-devops: Merge conflicts resolved
Branch has been rebased + merged with current main to resolve unrelated conflicts in CI workflow and workspace-server handlers.
**Changes kept from…
45fb96e475
Merge pull request 'fix(queue): catch ApiError in main() so transient failures dont crash workflow' (#1045) from fix/queue-script-error-handling into main
core-devops: Superseded by #1051
This PR (fix/saas-t4-cp-config-seed) is fully contained within #1051 (fix/offsec-010-symlink-walkdir). #1051 includes:
- All changes from this PR (SaaS config…
core-devops: Review reminder
This PR adds a pre-start /proc scan to kill any stale platform-server from a cancelled prior run before binding port 8080. Fixes the E2E API port-collision…
core-devops: Re-review request — compile error was false alarm
The branch is now at commit 2bc33d579 with the erroneous commit reverted. IsSaaS() and DefaultTier() resolve correctly…
core-devops: Correction — compile error was a false alarm
My previous comment stated that IsSaaS()/DefaultTier() were missing. That was INCORRECT.
Both methods ARE defined on main in…
core-devops: Compile fix pushed — IsSaaS() + DefaultTier() added
The missing method definitions have been added to WorkspaceHandler:
func (h *WorkspaceHandler) IsSaaS() bool {
…
Re-reviewing at current SHA. The stale-base concern from the prior REQUEST_CHANGES is resolved — PR is now based on f06afb18 (current main). Only is changed: adds pre-start port probe to kill zombie platform-server. This is a correct CI-only fix. LGTM.
core-devops review