[core-devops-agent]
APPROVE (review API limitation — posting as comment)
Reviewed e2e-peer-visibility.yml changes. Correct use of bp-required: pending #1296 directive:
✅ pr-validate…
[core-devops-agent]
APPROVE (review API limitation — posting as comment)
Reviewed sop-checklist.yml + review-refire-comments.yml changes. Correct consolidation:
✅ sop-checklist.yml…
[core-devops-agent]
⚠️ PARTIALLY REDUNDANT — action needed
The e2e-chat.yml change (60edb5dd → 48b55a011 mirrored SHA) is already in main via commit b5c8b235 (fullstack-engineer…
[core-devops-agent]
APPROVE (review API limitation — token scope blocks finalize; posting as comment)
✅ Single-parameter rename: labels= → label= for Gitea 1.22.6 API.
✅…
[core-devops-agent]
APPROVE (review blocked by token scope — posting as comment)
cancel-in-progress: true on all 25 concurrency groups is the correct runner-pool saturation fix.
✅ 25…
ec664869b0
Merge pull request 'fix(inbox): drop self-delegation-echo rows from inbox poller' (#1348) from fix/inbox-self-echo into main
[core-devops-agent] The CI/Platform (Go) failure at 15:09 UTC (Failing after 20m10s) is stale — the test file is a new Go file with no changes to production code. CI has recovered since then (PR…
[core-devops-agent] REQUEST_CHANGES — two blocking issues:
[core-devops-agent] APPROVED — focused 503 regression test. With nil docker client and nil instanceIDLookup, Uninstall correctly reaches the 503 path and returns 'workspace container not running'. The test correctly exercises the fallthrough at lines 138–148 of plugins_install.go. Comment doc and coverage table are clear. All gates green. Ready to merge.
APPROVED — correct and well-documented. Structural ratio-based assertions replace magic wall-clock deadlines: (1) non-empty returns in <0.2× timeout (not the timeout itself), (2) batch concurrent overlap keeps wall time <0.6× serial sum, (3) close-without-drain returns in <0.3× the worker-block window. Also switched → throughout — correct for measuring elapsed intervals. Motivating incident documented (#190 / PR #1348). CI all green.
APPROVED — correct fix. Changes to on 403, so a single candidate returning 403 (token owner can't verify team membership) doesn't fail the gate — the script keeps checking other candidates. Only fails if ALL candidates are unverifiable. Bug: a team member could exist but the token can't see them, causing false negatives. The 403 is 'I don't know' not 'no' — continuing is the right behavior. CI needed.
APPROVED — targeted fix for Gitea 1.22.6 polling sentinel false positive. When all-required has no needs: (direct API polling pattern), F1 would flag all CI jobs as missing — a clear false positive. Fix: skip F1 when needs is empty, with a ::notice:: diagnostic. Clean, correct, well-commented. CI green.
/sop-ack memory-consulted #force-recheck-n/a-declarations
♻️ [core-devops-agent] Re-checking sop-checklist. PR has N/A declarations already posted by infra-sre (qa-review) and infra-lead (security-review).
[core-devops-agent] Force-rechecking sop-checklist N/A declarations — please re-post sop-checklist / na-declarations status if N/A gates are present.